Tuesday, 2021-01-19

*** tosky has quit IRC00:02
*** zenkuro has quit IRC00:24
*** zenkuro has joined #openstack-nova00:25
*** sapd1 has quit IRC00:35
*** tbachman has joined #openstack-nova01:11
*** tbachman has quit IRC01:16
*** tbachman has joined #openstack-nova01:16
*** LinPeiWen82 has joined #openstack-nova01:29
openstackgerritBrin Zhang proposed openstack/nova master: Nova supports password encrypted VNC  https://review.opendev.org/c/openstack/nova/+/62233601:51
*** martinkennelly has quit IRC01:54
*** zenkuro has quit IRC02:20
*** rcernin has quit IRC02:26
*** hemanth_n has joined #openstack-nova02:40
*** rcernin has joined #openstack-nova02:42
*** rcernin has quit IRC02:44
*** rcernin has joined #openstack-nova02:44
*** mkrai has joined #openstack-nova03:13
*** jhesketh_ has joined #openstack-nova03:40
*** jhesketh has quit IRC03:41
*** jhesketh_ is now known as jhesketh03:43
*** zzzeek has quit IRC03:48
*** zzzeek has joined #openstack-nova03:51
*** mkrai has quit IRC03:51
*** mkrai has joined #openstack-nova03:51
*** ratailor has joined #openstack-nova04:15
*** sapd1 has joined #openstack-nova04:16
*** lbragstad has quit IRC04:16
*** zzzeek has quit IRC04:33
*** zzzeek has joined #openstack-nova04:35
*** hemanth_n has quit IRC04:40
*** hemanth_n has joined #openstack-nova04:44
*** sapd1 has quit IRC05:17
openstackgerritRico Lin proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job  https://review.opendev.org/c/openstack/nova/+/74209405:56
*** vishalmanchanda has joined #openstack-nova06:20
*** hemanth_n has quit IRC06:23
*** hemanth_n has joined #openstack-nova06:23
*** brinzhang has quit IRC06:50
*** brinzhang has joined #openstack-nova06:51
*** rcernin has quit IRC07:19
*** macz_ has joined #openstack-nova07:22
*** xek has joined #openstack-nova07:22
openstackgerritYongli He proposed openstack/nova master: smartnic support  https://review.opendev.org/c/openstack/nova/+/75894407:24
openstackgerritYongli He proposed openstack/nova master: Smartnic support - cyborg drive  https://review.opendev.org/c/openstack/nova/+/77136207:24
openstackgerritYongli He proposed openstack/nova master: smartnic support - new vnic type  https://review.opendev.org/c/openstack/nova/+/77136307:24
*** macz_ has quit IRC07:27
*** ralonsoh has joined #openstack-nova07:27
*** tbachman_ has joined #openstack-nova07:31
*** tbachman has quit IRC07:31
*** tbachman_ is now known as tbachman07:31
*** brinzhang has quit IRC07:32
*** hemanth_n has quit IRC07:32
*** hemanth_n has joined #openstack-nova07:33
*** lpetrut has joined #openstack-nova07:39
*** nightmare_unreal has joined #openstack-nova07:44
*** slaweq has joined #openstack-nova07:48
*** rpittau|afk is now known as rpittau08:07
*** brinzhang has joined #openstack-nova08:07
gibilyarwood, kashyap: never mind I think I found the doc for XMLDesc https://libvirt.org/html/libvirt-libvirt-domain.html#virDomainGetXMLDesc08:08
*** andrewbonney has joined #openstack-nova08:13
*** zzzeek has quit IRC08:14
*** sapd1 has joined #openstack-nova08:14
*** zzzeek has joined #openstack-nova08:16
*** tesseract has joined #openstack-nova08:20
*** tosky has joined #openstack-nova08:39
openstackgerritXing Zhang proposed openstack/nova stable/train: replace the "hide_hypervisor_id" to "hw:hide_hypervisor_id"  https://review.opendev.org/c/openstack/nova/+/76873608:40
lyarwoodgibi: sorry had already logged yesterday when you asked that08:47
lyarwoodteething--08:47
*** hoonetorg has quit IRC08:51
*** hoonetorg has joined #openstack-nova08:53
lyarwoodstephenfin / sean-k-mooney ; https://review.opendev.org/c/openstack/nova/+/761725 - would you mind taking a look at this stable/train backport and the changes made for stable/train? LGTM from a stable core point of view.09:00
*** ociuhandu has joined #openstack-nova09:15
kashyapgibi: Ah, nod09:19
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job  https://review.opendev.org/c/openstack/nova/+/76846609:27
lyarwoodfinally \o/09:28
lyarwoodstill needs some devstack-plugin-ceph and devstack changes to land but it's almost there09:29
lyarwoodthen it's just the multinode grenade job iirc09:29
*** brinzhang has quit IRC09:29
openstackgerritMerged openstack/nova-specs master: Libvirt supports composing cyborg owned vGPU accelerator into domain XML  https://review.opendev.org/c/openstack/nova-specs/+/75011609:33
stephenfinlyarwood: looking09:36
*** martinkennelly has joined #openstack-nova09:39
*** rcernin has joined #openstack-nova09:43
*** derekh has joined #openstack-nova09:44
lyarwooddid we agree on a spec review day before the deadline btw?10:01
lyarwoodI'm trying to finish the libvirt eph encryption spec today for review but appreciate it's pretty late10:02
*** sapd1 has quit IRC10:03
*** ociuhandu has quit IRC10:19
bauzaslyarwood: no, we said no during the meeting10:20
lyarwoodbauzas: ack thanks, and the deadline is Thursday for specs right?10:21
bauzasbut we can continue to look at the specs10:21
bauzascorrect10:21
lyarwoodbauzas: ack thanks, I'll get this posted today and go from there10:21
bauzas++10:21
* lyarwood has had to rewrite it a few times, the block layers can be so damn confusing10:21
sean-k-mooneylyarwood: yep just have a meeting in a at half past but ill look at it after. i am familar with the backport and it is something we shoudl do but ill do an actual review after the meeting10:24
*** ociuhandu has joined #openstack-nova10:24
*** ociuhandu has quit IRC10:24
bauzasstephenfin: do you want to have +2/+W for all the series before merging https://review.opendev.org/c/openstack/nova/+/758155 or do you prefer to merge each of them10:24
bauzas?10:24
openstackgerritMerged openstack/placement master: [goal] Deprecate the JSON formatted policy file  https://review.opendev.org/c/openstack/placement/+/76439410:25
bauzashonestly, I'm fine with both10:25
*** ociuhandu has joined #openstack-nova10:25
stephenfinbauzas: they can go in individually10:25
bauzassure, I was asking for the series, but at least the first can be merged now10:25
stephenfinyeah, I don't think there'll be a case where patch N has to change because of something in M, if that's what you mean. No dependencies10:26
stephenfinat least not in that way10:27
*** rcernin has quit IRC10:28
*** brinzhang has joined #openstack-nova10:28
*** songwenping_ has joined #openstack-nova10:29
*** ociuhandu has quit IRC10:29
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Liberty database migrations  https://review.opendev.org/c/openstack/nova/+/75939910:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Mitaka database migrations  https://review.opendev.org/c/openstack/nova/+/75940010:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Newton database migrations  https://review.opendev.org/c/openstack/nova/+/75940110:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Ocata database migrations  https://review.opendev.org/c/openstack/nova/+/75940210:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Pike database migrations  https://review.opendev.org/c/openstack/nova/+/75940310:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Queens database migrations  https://review.opendev.org/c/openstack/nova/+/75940410:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Rocky database migrations  https://review.opendev.org/c/openstack/nova/+/75940510:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Stein database migrations  https://review.opendev.org/c/openstack/nova/+/75940610:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Add manage.py script  https://review.opendev.org/c/openstack/nova/+/77141910:36
openstackgerritStephen Finucane proposed openstack/nova master: apidb: Compact Train database migrations  https://review.opendev.org/c/openstack/nova/+/77142010:36
*** mkrai has quit IRC10:43
bauzasstephenfin: no worries, for the moment, I don't see any issue with this10:43
*** ociuhandu has joined #openstack-nova10:58
elodlyarwood: I've commented on the train backport patch you mentioned yesterday11:04
elodlyarwood: this one: https://review.opendev.org/c/openstack/nova/+/77094411:06
elodlyarwood: I'd rather not backport those 2 patches :/11:07
lyarwoodelod: ack, I'll add context in the review but tl;dr downstream our OSP 16 release maps to stable/train and we plan on keeping it around until ~2025 https://access.redhat.com/support/policy/updates/openstack/platform/11:09
lyarwoodelod: we've backported a few things downstream and hit issues with pyflakes 1.2.3 not supporting f-strings11:09
lyarwoodelod: and assume that in the future we could easily also land things upstream that hit the same issue11:09
lyarwoodelod: as this is just a lint tooling bump we thought we'd try to land this in stable/train first before doing anything downstream only11:10
lyarwoodmaybe that wasn't a true tl;dr but hopefully you see what I was trying to do now ;)11:10
* lyarwood adds context to the review11:11
*** ociuhandu has quit IRC11:12
*** ociuhandu has joined #openstack-nova11:12
*** rcernin has joined #openstack-nova11:13
elodlyarwood: in train python 2 is still there, and f-sting is not in python211:15
elodI guess you support train with python3 (of course)11:16
lyarwoodelod: yeah indeed only on py36 downstream11:16
lyarwoodelod: was it a supported runtime in stable/train?11:17
*** ociuhandu has quit IRC11:17
* lyarwood checks11:17
lyarwoodah it was11:17
lyarwoodokay then ignore me11:17
elodthe job is still there11:17
lyarwoodsorry I thought it wasn't11:17
lyarwoodhttps://governance.openstack.org/tc/reference/runtimes/train.html11:17
lyarwoodI'll just backport these downstream11:17
lyarwoodapologies for the noise11:17
elodlyarwood: ussuri is the 1st one without py211:18
elodlyarwood: no problem11:18
lyarwoodyup ETOOMANYVERSIONS :)11:19
elodlyarwood: I just don't feel it appropriate upstream :/11:19
lyarwoodyup it isn't if we support py27 still as f-strings are not valid in stable/train as a result11:19
lyarwoodI'll just modify the backports downstream to avoid this and move on11:19
lyarwoodas it's only f-strings11:20
elodlyarwood: ok, thanks11:20
bauzasstephenfin: man, I don't know how other people do for reviewing your DB changes, but it'll need time for me for looking at all the modifications for https://review.opendev.org/c/openstack/nova/+/758394/411:24
*** macz_ has joined #openstack-nova11:24
* bauzas will look at every DB upgrade and make sure that the new compact module supports it11:24
stephenfinbauzas: You can put this script in the root of your nova repo, run it on master and then it run after the change is applied, comparing the diff (there shouldn't be one) https://review.opendev.org/c/openstack/nova/+/76979611:25
stephenfinI've done that a few times now11:25
*** macz_ has quit IRC11:28
* gibi happy to see the db compaction patches in the gate queue11:30
*** rcernin has quit IRC11:37
*** zenkuro has joined #openstack-nova11:44
openstackgerritMerged openstack/nova stable/ussuri: Use cell targeted context to query BDMs for metadata  https://review.opendev.org/c/openstack/nova/+/76574811:49
*** ociuhandu has joined #openstack-nova11:57
*** dpawlik has quit IRC11:57
*** logan- has quit IRC11:57
*** lifeless has quit IRC11:57
*** abhishekk has quit IRC11:57
*** kevinbenton has quit IRC11:57
*** gryf has quit IRC11:57
*** DinaBelova has quit IRC11:57
*** ebbex has quit IRC11:57
*** markmcclain has quit IRC11:57
*** lpetrut_ has joined #openstack-nova11:58
*** kevinbenton has joined #openstack-nova11:58
*** ebbex has joined #openstack-nova11:58
*** lifeless has joined #openstack-nova11:58
*** DinaBelova has joined #openstack-nova11:58
*** markmcclain has joined #openstack-nova11:58
*** gryf has joined #openstack-nova11:59
*** abhishekk has joined #openstack-nova11:59
*** logan- has joined #openstack-nova12:00
*** lpetrut has quit IRC12:01
*** luksky has joined #openstack-nova12:03
*** bbowen_ has quit IRC12:06
*** bbowen has joined #openstack-nova12:06
*** ociuhandu has quit IRC12:10
*** ociuhandu has joined #openstack-nova12:13
*** dpawlik has joined #openstack-nova12:15
*** ociuhandu has quit IRC12:18
*** ratailor has quit IRC12:24
*** artom has quit IRC12:28
*** artom has joined #openstack-nova12:28
*** ociuhandu has joined #openstack-nova12:29
*** ociuhandu has quit IRC12:30
*** ociuhandu has joined #openstack-nova12:32
*** Luzi has joined #openstack-nova12:38
*** raildo has joined #openstack-nova12:42
*** ebbex has quit IRC12:44
openstackgerritRico Lin proposed openstack/nova master: add openstack-python3-wallaby-jobs-arm64 job  https://review.opendev.org/c/openstack/nova/+/74209412:46
openstackgerritRico Lin proposed openstack/nova master: Fix Unit test for arm64  https://review.opendev.org/c/openstack/nova/+/76820212:46
*** ebbex has joined #openstack-nova12:48
*** ttx has quit IRC12:51
*** hemanth_n has quit IRC12:52
*** ttx has joined #openstack-nova13:05
openstackgerritAndrey Volkov proposed openstack/nova master: [WIP] Add conf option for scatter_gather_cells error handling  https://review.opendev.org/c/openstack/nova/+/77144013:05
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy  https://review.opendev.org/c/openstack/nova-specs/+/76555113:11
artomsean-k-mooney, stephenfin, gibi ^^ pretty please :)13:12
* artom has just now caught up to Sean's upgrade concerns, I think what I wrote makes sense...13:12
*** macz_ has joined #openstack-nova13:25
bauzasstephenfin: question here https://review.opendev.org/c/openstack/nova/+/758394/4/nova/db/sqlalchemy/migrate_repo/versions/231_add_ephemeral_key_uuid.py#b32 with a procedural -113:26
*** macz_ has quit IRC13:29
*** LinPeiWen82 has quit IRC13:33
*** lbragstad has joined #openstack-nova13:37
*** avolkov has joined #openstack-nova13:46
*** _erlon_ has joined #openstack-nova13:49
*** _mlavalle_1 has quit IRC13:58
*** mlavalle has joined #openstack-nova13:59
sean-k-mooneyartom: im going to refill my coffee then ill take a look13:59
gibiartom:  refined my question in https://review.opendev.org/c/openstack/nova-specs/+/76555114:02
*** artom has quit IRC14:10
*** ricolin has joined #openstack-nova14:11
*** spatel has joined #openstack-nova14:13
*** Luzi has quit IRC14:14
stephenfinbauzas: replied14:22
bauzasta, looking14:22
stephenfinsean-k-mooney: ta is catching on :P ^14:22
sean-k-mooneyhehe i know bauzas and efried started using it14:23
bauzasta doesn't mean thanks ?14:23
sean-k-mooneyeventually ye will all start spelling in sean speak and we will all be doomed14:23
sean-k-mooneybauzas: kind of yes but its an irish/british thing14:24
stephenfinbauzas: Yup, it does. sean-k-mooney just made a joke about me using it often some time back14:24
stephenfinand I said it would catch on :)14:24
bauzasok, je peux parler en français sinon14:24
bauzas:p14:24
bauzasanyway, saw your reply14:24
bauzashonestly, I'm not a SQLA expert14:24
bauzasso, yeah, the column is *nullable* but I don't know whether the default value is NULL for the SQL14:25
bauzasanyway, maybe it's just a bikeshed14:26
sean-k-mooneygibi: artom seams to have disconencted but i think the spec is wrong14:26
sean-k-mooneyif you have hw_numa_nodes=2 N0 and N2 shoudl be fine14:26
* gibi filters join and part messages14:26
stephenfinyeah, gone since 14:1014:26
stephenfinprobably on breakfast/kid duty14:27
gibisean-k-mooney: that answer I can accept14:27
gibisean-k-mooney: if at least one CPU is on the same socket as the allocated PCI14:27
sean-k-mooneyif you have hw:numa_nodes=2 and the socket policy provide the pci device come form one of the socket of any of the guest numa nodes its fine14:27
sean-k-mooneyhw_pci_numa_affinity_policy=socket should not require that all guest numa nodes come from teh same socket14:27
sean-k-mooneygibi: yep14:28
gibisean-k-mooney: I agre14:28
sean-k-mooneyill comment that on the spec and i guess you can too but i need to read the rest too. i just started with your comment since i saw your ping to artom14:29
stephenfinlyarwood: Yeah, all good on https://review.opendev.org/c/openstack/nova/+/76172514:30
lyarwoodstephenfin: thanks14:31
lyarwoodhmm does anyone know where the openstack-dev archive ended up?14:32
*** artom has joined #openstack-nova14:32
*** artom has quit IRC14:32
*** artom has joined #openstack-nova14:33
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy  https://review.opendev.org/c/openstack/nova-specs/+/76555114:33
spatelsean-k-mooney: morning! do you have any idea about this Bug? - https://bugs.launchpad.net/nova/+bug/191227314:33
openstackLaunchpad bug 1912273 in OpenStack Compute (nova) "SRIOV instance Error: Exception during message handling: KeyError: 'pci_slot'" [Undecided,New]14:33
bauzaslyarwood: http://lists.openstack.org/pipermail/openstack-dev/14:34
bauzas?14:34
*** nweinber has joined #openstack-nova14:34
lyarwoodbauzas: thanks http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev does't list it anymore14:34
bauzasack, gtk14:34
artomgibi, thanks for the question, amended the spec :)14:37
*** sapd1 has joined #openstack-nova14:37
sean-k-mooneyartom: im replying14:37
sean-k-mooneyartom: the spec is incorrect.14:38
*** dave-mccowan has quit IRC14:38
sean-k-mooneyartom: still review but  https://review.opendev.org/c/openstack/nova-specs/+/765551/5/specs/wallaby/approved/pci-socket-policy.rst#8214:40
artomsean-k-mooney, well, it's kinda up to us to decide what we want - or rather, what we think operators want.14:41
sean-k-mooneysure but i disagree with what you chosse14:41
sean-k-mooneyand its inconsitend with require14:41
*** rcernin has joined #openstack-nova14:42
artomSO, with multiple guest NUMA nodes and a single PCI device, it's obviously impossible to have all guest NUMA nodes pinned to the same host NUMA node containing the PCI device14:42
artom(Well, assuming dedicated CPUs)14:42
sean-k-mooneyif we wanted to provide a way to do what you suggested that is a different feature with a different extra spec14:42
artomSo for `require` we have no choice14:42
artomFor `socket` however, it's perfectly possible to have all the guest NUMA nodes come from the same socket, thus guaranteeing that the guest never has to cross the socket boundary to access the PCI device14:43
sean-k-mooneyactully libvirt can do that but you missunderstanding what hw:numa_nodes=2 with require means14:43
sean-k-mooneyhw_numa_nodes=2 with hw_pci_numa_affinity_policy=require means the pci device will be on the same numa node as one fo the guest numa nodes14:44
sean-k-mooneyeach device can be colacate with a different one fo the guests numa nodes14:44
artomsean-k-mooney, I get that, because being on the same host numa node as *both* guest NUMA nodes doens't make sense14:44
sean-k-mooneycorrect14:44
sean-k-mooneywell ig could14:44
artomBut being on the same *socket* as both guest NUMA nodes *would* make sense14:44
artomSo it's a matter of - what's the most useful?14:45
sean-k-mooneywe currenlty dont allow mulitple guest numa nodes to map to one host numa node14:45
sean-k-mooneythat is not a guarnette fo the api14:45
sean-k-mooneyits an implemantion detail fo the libvirt driver14:45
sean-k-mooneyone which strictly speaking operators should not rely on14:45
artomBut de facto they do, because nothing except the libvirt driver will ever implement this :P14:46
artomAnways, that's tangential14:46
sean-k-mooneywell i have wanted to change that sicne we added numa affinity14:46
sean-k-mooneythe intel implematnion did not require this14:46
sean-k-mooneyif we want to provide a way for all nuam nodes to be confiend to the same socket14:47
sean-k-mooneyi think that is a different feature to pci affintiy14:47
artomAh, now that does make sense14:47
sean-k-mooneythat is more a kin to hw:numa_mem_policy which was never impelmented14:47
artomI guess? But yeah, I see the point - forcing all guest numa nodes to come from the same host socket is a different thing from PCI policy, and you could have both14:48
sean-k-mooneyyes14:48
sean-k-mooneyso i would personally find it suprising if the pci policy would trigger that behavior14:49
sean-k-mooneyespcially coupled with the ablity to set the policy via a neutorn port14:49
*** mkrai has joined #openstack-nova14:51
artomFair points, lemme update14:52
openstackgerritBalazs Gibizer proposed openstack/nova stable/train: Use cell targeted context to query BDMs for metadata  https://review.opendev.org/c/openstack/nova/+/77140714:56
*** dcapone2004 has joined #openstack-nova14:59
*** rcernin has quit IRC15:01
*** macz_ has joined #openstack-nova15:01
dcapone2004I am having an issue on ussuri where guest centos VMs with SELinux disabled or set to permissive have the systemd process in the VM consume 100% CPU and never goes back down without rebooting the VM15:02
dcapone2004after rebooting, the issue recurs within several hours15:02
*** dcapone2004 has quit IRC15:02
*** dcapone2004 has joined #openstack-nova15:03
dcapone2004I have been attempting to google for other reports of this issue and have been unable to find anything and was trying to see if anyone has seen this issue before and knows what might cause it or any type of resolution15:03
dcapone2004strace on the systemd process in these VMs, just shows a bunch of epoll_pwait like systemd is hung waiting for something15:05
openstackgerritLee Yarwood proposed openstack/nova-specs master: libvirt: Add support for flavor and image defined ephemeral encryption  https://review.opendev.org/c/openstack/nova-specs/+/77147415:09
sean-k-mooneyartom: finished with the review15:09
artomsean-k-mooney, cheers!15:12
artomHrmm, yeah, placement trait would be faster...15:12
artomI just kinda dislike that it's becoming this endless stream of "NEW_FEATURE_TRAIT_TO_HANDLE_ROLLING_UPGRADES"15:12
artomBut maybe that's what they're for...15:12
sean-k-mooneywell that was basically the entire point of traits15:15
sean-k-mooneyso we can expose capabityes and schdule on them15:15
sean-k-mooneyalthough maybe not for you example15:15
sean-k-mooneythe feature trait is not actully for rolling upgrdes15:15
sean-k-mooneyit can help with that but its for spawn and all move operations15:16
sean-k-mooneyso that we would only consider host that support socket affinity15:16
sean-k-mooneywhich is very useful in a mixed hypervior deployment15:16
*** derekh has quit IRC15:20
*** derekh has joined #openstack-nova15:20
*** gryf has quit IRC15:26
*** gryf has joined #openstack-nova15:26
*** ociuhandu has quit IRC15:27
*** mkrai has quit IRC15:27
*** mkrai has joined #openstack-nova15:27
artomNote to self, when talking about dicts flying over the wire, do not typo "wire" as "wife"15:28
lyarwoodoh my15:45
*** mkrai has quit IRC15:46
artomReminds me of https://www.youtube.com/watch?v=XE1XE6Thp9E for some reason15:48
artom(The oh my)15:48
lyarwoodrisky click of the day15:48
*** brinzhang has quit IRC15:48
lyarwoodoh that part15:48
lyarwoodlol15:48
*** brinzhang has joined #openstack-nova15:51
sean-k-mooneylol15:52
sean-k-mooneywhy15:52
*** spatel has quit IRC15:55
*** ociuhandu has joined #openstack-nova15:55
*** sapd1 has quit IRC15:59
*** sapd1 has joined #openstack-nova16:00
*** ociuhandu has quit IRC16:01
openstackgerritArtom Lifshitz proposed openstack/nova-specs master: `socket` PCI NUMA-affinity Policy  https://review.opendev.org/c/openstack/nova-specs/+/76555116:05
artomsean-k-mooney, ^^ I'll look at the vdpa spec now. I think the only thing I had a bit of a beef with is the whitelist. IIUC, it would have to contian the parent PF of any vdpa devices, so that should get documented methinks16:06
*** ociuhandu has joined #openstack-nova16:11
*** xarlos has quit IRC16:12
efriedI've never used "ta".16:36
efriedI did grow up mostly in London, so I wasn't a stranger to the idiom. But it never made it into my lexicon.16:36
sean-k-mooneyefried: really never knew you had a london connection16:37
sean-k-mooneyefried: hows life in k8s land16:37
*** derekh has quit IRC16:43
sean-k-mooneyartom: +1 on your spec. i think that is consitent with my expections now16:44
*** lbragstad_ has joined #openstack-nova16:46
*** zenkuro has quit IRC16:47
*** zenkuro has joined #openstack-nova16:48
*** lpetrut_ has quit IRC16:48
*** slaweq has quit IRC16:48
*** slaweq has joined #openstack-nova16:49
*** jamesdenton has quit IRC16:49
*** gryf has quit IRC16:49
*** lbragstad has quit IRC16:49
*** hoonetorg has quit IRC16:49
*** jamesdenton has joined #openstack-nova16:49
*** hoonetorg has joined #openstack-nova16:50
*** gryf has joined #openstack-nova16:50
*** macz_ has quit IRC16:52
*** macz_ has joined #openstack-nova16:52
*** lbragstad_ is now known as lbragstad16:58
artomsean-k-mooney, cool, thanks! Yeah, I dunno if the "parent PF must be whitelisted" thing is obvious, but I figure it'd be nice to document it for operators17:01
artomI think what confused me is you initially said in a review comment that the whitelist had nothing to do with VDPA17:02
sean-k-mooneywell the PF should not nessisaryly be what you whitelist it could be but you could whitelist the VFs17:05
sean-k-mooneythe imporant part is we are not changing how the whitelist currenlty works17:06
sean-k-mooneyit declare which pci device can be passthough, we then check if any of those have vdpa devices assocated with them and if they do we mark them as type-VDPA17:07
sean-k-mooneyinstead of type-VF17:07
sean-k-mooneythat is part o fthe code i still need to merge17:07
sean-k-mooney*write17:08
efriedsean-k-mooney: Yeah, lived just outside of London from 84-87 and 89-94.17:08
efriedOpenShift is fun. I'm not loving the devops side of things, but it's tolerable.17:08
sean-k-mooneyefried: have you managed to fine a way to do upstream work or still more on the support side17:09
efriedFor some value of "upstream".17:09
*** brinzhang_ has joined #openstack-nova17:09
sean-k-mooneywell i basicaly ment coding/bugfixing/feature design17:09
efriedYeah, I'm getting to write code.17:09
sean-k-mooneythat good that they are not wasting your experince then at least17:10
efriedThis is my baby: https://github.com/openshift/boilerplate/17:10
sean-k-mooneykind of like cookiecutter?17:10
*** mlavalle has quit IRC17:11
sean-k-mooneyefried: ah not quite17:11
efriedSimilar spirit. Doesn't cookiecutter play just at the birth of a repo? Boilerplate continues to evolve and subscribers get updates as they go.17:11
sean-k-mooneyefried: its more vendorisizng the standard deps17:11
efriednot deps in the package sense.17:12
efriedBut yeah, kinda like vendoring standard workflows, make targets, build scripts...17:12
sean-k-mooneywell you use the term artifacts17:12
*** brinzhang has quit IRC17:12
*** mlavalle has joined #openstack-nova17:12
sean-k-mooneyso im thinking of them as a stanard libviar of things you can use17:12
*** _erlon_ has quit IRC17:13
efriedYeah, something like that. Except the default is *must* use; we make it hard to switch pieces off.17:14
sean-k-mooneypresumably for consitncy between different operators17:15
*** spatel has joined #openstack-nova17:15
sean-k-mooneyand preventing code debt thorugh duplciation17:15
efriedexactly.17:15
artomsean-k-mooney, right, so I think that's the part that could be made more explicit (at least for my brain): "the existing whitelist mechanism is unchanged - if a device is whitelisted and is bound to the vdpa driver, it will be inventoried as type-VDPA and plugged accordingly."17:16
*** ociuhandu_ has joined #openstack-nova17:16
sean-k-mooneyartom: sure i can adde that proably in the developer inpact section17:16
sean-k-mooney* Other deployer impact17:17
sean-k-mooneysorry no17:17
sean-k-mooneyDeveloper impact17:17
sean-k-mooneyill add it now in any case17:17
*** ociuhandu has quit IRC17:19
sean-k-mooneyi guess technically im modifying this code https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L7074-L7110 so i can put it in proposed change section17:19
*** ociuhandu_ has quit IRC17:20
*** ociuhandu has joined #openstack-nova17:31
*** ociuhandu has quit IRC17:35
openstackgerritBalazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach  https://review.opendev.org/c/openstack/nova/+/77024617:37
*** hamalq has joined #openstack-nova17:40
dansmithgmann: hey I was looking for some fat to cut from jobs.. just thinking.. do we really need to run grenade and grenade-multinode against nova? not sure under what circumstances we'd really get benefit from regular grenade that we don't see in the multinode job17:52
gmanndansmith: multinode you mean this right ( not grenade-multinode ) nova-grenade-multinode ?17:55
dansmithsure17:55
gmanndansmith: it run live migration tests too https://github.com/openstack/nova/blob/master/playbooks/legacy/nova-grenade-multinode/run.yaml#L5817:56
dansmithgmann: right, but is there anything fundamental about the base grenade job that we don't or can't do in the multinode variant such that we could stop running the base grenade job?17:56
gmanndansmith: or you are thinking to drop grenade-py3 in favor of nova-grenade-multinode which cover upgrade + live migration?17:56
gmanndansmith: right,17:56
dansmithright17:57
gmannI think yes, that make sense. in grenade-py3 we only run smoke test so it is a rick set of test we run there so nova-grenade-multinode server the purpose17:57
gmannserve17:57
sean-k-mooneydansmith: im not sure we rung the same test in both17:57
dansmithgmann: cool, that'd be another ~1h job we run less17:58
dansmithsean-k-mooney: I think the multinode job is a superset, no?17:58
sean-k-mooneyif its the same tests and same backend e.g. ceph vs non ceph i think we are ok17:58
gmanndansmith: +117:59
sean-k-mooneydansmith: im not sure if we use the same storage backend in both17:59
openstackgerritLee Yarwood proposed openstack/nova-specs master: libvirt: Add support for flavor and image defined ephemeral encryption  https://review.opendev.org/c/openstack/nova-specs/+/77147417:59
dansmithgmann: okay, what's the magic to make zuul not run a job we inherited? :)18:00
dansmithsean-k-mooney: I think those jobs are just stock storage config aren't they?18:00
lyarwoodgmann / dansmith ; just a quick point, at the moment the multinode job is still stuck on bionic18:00
sean-k-mooneyya i would expect so18:00
lyarwoodbut the single node job is on focal18:00
sean-k-mooneyso likel cinder isci/lvm18:01
dansmithlyarwood: okay, but for grenade things is that significant?18:01
lyarwoodI'm not sure if we want to drop the single node job until the multinode job has moved finally18:01
sean-k-mooneythere is noting preventing us form using focal at this point right18:01
dansmithlyarwood: okay, we can wait if it's significant, but I think we should aim to do it18:01
lyarwooddansmith: I guess, it's just not as stable as the focal based job at the moment imho18:01
sean-k-mooneyit was only using bionic for the device detach thing18:02
sean-k-mooneywhich is kind of fixed with the increased timeout18:02
lyarwoodsean-k-mooney: it's the move to the native zuulv3 based job that's blocking us at the moment18:02
dansmithlyarwood: if we run both and the superset is less stable, it's the same number of -1s from zuul, but double the resource usage, so :/18:02
gmannlyarwood: yeah bionic and zuulv218:02
sean-k-mooneyand which gibi is trying to fix fully currently usign the events18:02
gmanndansmith: but to stop the grenade-py3 we need to change in integrated-gate template also18:02
lyarwoodsean-k-mooney: that isn't the issue anymore18:02
sean-k-mooneylyarwood: right but it could be zuulv2 + focal18:02
sean-k-mooneyyou just need to change the label18:03
lyarwoodsean-k-mooney: assuming devstack-gate etc actually support it18:03
gmanndansmith: here https://github.com/openstack/tempest/blob/master/zuul.d/integrated-gate.yaml#L37818:03
lyarwoodI'm not sure that's the case18:03
gmannsean-k-mooney: its not easy, legacy jobs were left to run on bionic and once they move to zuulv3 it will run on focal18:04
gmannso how much work we need for Focal in devstack-gate is not known18:04
sean-k-mooneygmann: devstack-gate basiclaly wraps devstack i dont think its actully executing os level commands18:04
dansmithgmann: right that's where we inherit it from, correct? we have to do something in nova/.zuul to say "don't run this" ?18:04
lyarwoodFWIW I wanted to help move the multinode grenade job to zuulv3 once https://review.opendev.org/q/topic:%2522native-zuulv3-migration%2522+owner:lyarwood%2540redhat.com+status:open had landed for nova-live-migration-ceph18:05
lyarwood^ that's pretty much ready now I think, just needs core reviews in devstack, devstack-plugin-ceph and eventually nova.18:05
gmanndansmith: i do not think there is a way to say "don't run this". we have to remove it from defined pipeline from template or explicitly added18:05
dansmithgmann: ah, what if we set irrelevant files to "everything" ?18:06
* lyarwood drops to help with bath time brb18:06
gmannlyarwood: yeah, I need to look into this patch to proceed further https://review.opendev.org/c/openstack/nova/+/74205618:06
gmanndansmith: :) that is nice trick but let's remove it from template so that grenade testing can be added explicitly by projects with base or specific jobs18:07
dansmithgmann: okay I just didn't want to mess with the base template and/or make everyone add grenade themselves18:07
gmanndansmith: integrated-gate-compute is used by nova only so it is fine.18:09
dansmithah18:09
gmannand we will keep it in integrated-gate so that it can used as complete set of integration + upgrade tests18:09
dansmithoh I see, -compute18:10
dansmithgot it18:10
dansmithgmann: I will propose and we can -W until we do the conversion18:10
gmannyeah, i separated those template per integrated services so that we can do such type of optimization18:10
gmann+118:10
dansmithgmann: you're smart :)18:11
gmannotherwise nova and neutron use to get swift failure and cinder get neutron and vice versa18:11
*** rouk has joined #openstack-nova18:12
rouk2.48 removed lots of kvm details (specifically memory) when standardizing diagnostics, i can get more detail by asking for 2.47, where are these details represented in 2.48+?18:14
*** gyee has joined #openstack-nova18:16
sean-k-mooneywhy are we altering the templates by the way.18:19
sean-k-mooneygiven grenade and the multi node one are both listed in our .zuul.yaml in the check pipeline18:19
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/.zuul.yaml#L443-L47018:19
sean-k-mooneygiven noone else use integrated-gate-compute18:20
sean-k-mooneyim not sure moving grenade into that nessisarly helps18:20
sean-k-mooneyim not sure maintianing https://opendev.org/openstack/tempest/src/branch/master/zuul.d/integrated-gate.yaml#L369-L383 makes sense18:22
sean-k-mooneyat least im not sure it should live in tempest18:22
gmannsean-k-mooney: it need to be at central place in QA side.18:22
sean-k-mooneysame for the other project for that matter18:22
sean-k-mooneyi dont really thing it does18:23
gmannthis can be extended in future to add slow test job too which is currently not separated out as such18:23
*** dtantsur is now known as dtantsur|afk18:23
sean-k-mooneyit could but since we would want the project input when doing that18:24
sean-k-mooneydoes it not make sense to defien it in the proejcts18:24
gmannits both project and QA18:24
sean-k-mooneyright but it feels odd that tempest would reference any job not defiend in it in that template18:25
sean-k-mooneygmann: if dansmith  is ok with it i guess its fine it just feels odd that the qa team would be defining jobs that run against nova outside of the nova repo18:27
dansmithtons of jobs are like that?18:27
dansmithwe define jobs other projects run18:27
sean-k-mooneywell i dont know tha tfeels more elective18:28
sean-k-mooneyi guess its just greneade the feels weried to me18:28
sean-k-mooneyi dotn know why18:28
sean-k-mooneyi know all the tox jobs work this way18:28
sean-k-mooneyi just wasnt expecting to see grenade in those templates18:28
sean-k-mooneysince that was managed in tree by project grenade supported18:29
sean-k-mooneyfor example neutron https://github.com/openstack/neutron/blob/master/zuul.d/project.yaml#L21-L2218:30
*** artom has quit IRC18:30
sean-k-mooneyalthough they do not use integrated-gate-networking18:32
sean-k-mooneygmann: ignore me ill get used to it18:33
gmannneutron has done this changes due to the such optimization only like multiple grenade jobs running18:34
*** ricolin has quit IRC18:34
gmanntemplate help in long term when we extend it to cover the common things.18:34
sean-k-mooneyim not sure what else you would add18:34
gmannslow job is one in list which should be optimize per integrated service and run on gate18:35
sean-k-mooneyif this was a PTI template or something sure but this partly feels like a resstion to defining everything in the project_config repo18:35
gmannintegrated-gate-compute does not cover all the tempest tests18:35
sean-k-mooneygmann: yes but im not sure we want it too18:35
sean-k-mooneyif we did we would need to test multipel storage backend for example18:36
gmannoverall idea is have a common template which can cover all the related tests (which might be in different jobs due to requried configuration)18:36
sean-k-mooneyso we would need at least 2 jobs running full tempest18:36
gmann'full tempest' cannot be covered by two jobs. full name is confusing there always :)18:36
sean-k-mooneyno i meen we need two jobs running all tempest test with different config18:37
*** tesseract has quit IRC18:37
sean-k-mooneyfor exmple nova libvirt backed has 3 ways to pass sotrage to a guest so if you wante test all 3 with live migraiton you need basially 2 jobs18:38
*** sapd1 has quit IRC18:38
sean-k-mooneyone with lvm/iscis to test cinder voluems and block stoarge and one with ceph to test qemu driect connect18:38
sean-k-mooney*qemu network stoage18:38
sean-k-mooneywe also have thigs liek multi cell18:39
sean-k-mooneyso if you want to test every thign in gate you have to run most of check again18:39
sean-k-mooneypersonally i think the way we defien the jobs in the project repo today is better then trying to put service speicic repos in tempest18:40
gmannsure, I mean all tempest tests at least with any one configuration.18:40
*** rpittau is now known as rpittau|afk18:41
gmannwe have tests also in Tempest for 6 services so same way jobs. I feel that is easy to maintain and control also18:41
gmannpreviously infra used to do that, maintain integrated template. and with migration to opendev it is more QA doing those jobs18:42
sean-k-mooneyright but i am not sure its adding much value currently at least for nova everythin in the template is also in our project config18:43
sean-k-mooneyif we removed   - integrated-gate-compute template it would not change the runnign jobs at all18:43
sean-k-mooneywe overrite the jobs in repo anyway https://github.com/openstack/nova/blob/master/.zuul.yaml#L451-L47118:45
sean-k-mooneyhttps://github.com/openstack/nova/blob/master/.zuul.yaml#L497-L50018:45
sean-k-mooneyso we can pass our own irrelevant-files list18:45
*** sapd1 has joined #openstack-nova18:51
*** artom has joined #openstack-nova18:53
openstackgerritMerged openstack/nova stable/train: Update pci stat pools based on PCI device changes  https://review.opendev.org/c/openstack/nova/+/76172518:59
*** nightmare_unreal has quit IRC19:14
*** zenkuro has quit IRC19:20
*** zenkuro has joined #openstack-nova19:21
*** lifeless has quit IRC19:27
*** lifeless has joined #openstack-nova19:27
*** dcapone2004 has quit IRC19:35
*** andrewbonney has quit IRC19:42
*** slaweq has quit IRC19:43
*** dcapone2004 has joined #openstack-nova19:55
openstackgerritsean mooney proposed openstack/nova-specs master: libvirt: support vdpa kernel networking  https://review.opendev.org/c/openstack/nova-specs/+/76499919:55
sean-k-mooneyartom: hopefully that adds what you wanted ^19:59
sean-k-mooneygibi: stephenfin  assuming artom is happy can ye rereivew tommorow20:00
*** Jeffrey4l has quit IRC20:04
*** openstackgerrit has quit IRC20:12
*** Jeffrey4l has joined #openstack-nova20:13
*** lemko3 has joined #openstack-nova20:16
*** lemko has quit IRC20:16
*** lemko3 is now known as lemko20:16
*** rouk has quit IRC20:20
*** artom has quit IRC20:31
*** vishalmanchanda has quit IRC20:39
*** artom has joined #openstack-nova20:42
*** Jeffrey4l has quit IRC20:50
*** Jeffrey4l has joined #openstack-nova20:51
*** ociuhandu has joined #openstack-nova21:07
*** jmlowe has joined #openstack-nova21:09
*** artom has quit IRC21:17
*** artom has joined #openstack-nova21:17
*** zenkuro has quit IRC21:17
*** zenkuro has joined #openstack-nova21:17
*** openstackgerrit has joined #openstack-nova21:26
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: compute: Lock by instance.uuid lock during swap_volume  https://review.opendev.org/c/openstack/nova/+/75873021:26
openstackgerritLee Yarwood proposed openstack/nova stable/stein: libvirt: Skip encryption metadata lookups if secret already exists on host  https://review.opendev.org/c/openstack/nova/+/76577221:27
openstackgerritLee Yarwood proposed openstack/nova stable/victoria: Use absolute path during qemu img rebase  https://review.opendev.org/c/openstack/nova/+/75709821:27
*** priteau has quit IRC21:35
*** nweinber has quit IRC21:42
*** xek has quit IRC21:44
*** arne_wiebalck has quit IRC21:49
*** arne_wiebalck has joined #openstack-nova21:51
*** rcernin has joined #openstack-nova22:09
*** iurygregory has quit IRC22:28
*** mgariepy has quit IRC22:31
*** spatel has quit IRC22:31
*** mgariepy has joined #openstack-nova22:34
*** iurygregory has joined #openstack-nova22:37
openstackgerritGhanshyam proposed openstack/nova master: DNM: Testing system scope in tempest  https://review.opendev.org/c/openstack/nova/+/74012422:42
*** avolkov has quit IRC22:46
*** ociuhandu has quit IRC22:47
*** ociuhandu has joined #openstack-nova22:47
*** dcapone2004 has quit IRC22:55
*** openstackgerrit has quit IRC22:59
*** brinzhang0 has joined #openstack-nova23:17
*** songwenping__ has joined #openstack-nova23:17
*** brinzhang_ has quit IRC23:20
*** songwenping_ has quit IRC23:21
*** luksky has quit IRC23:36
*** raildo has quit IRC23:40
*** brinzhang_ has joined #openstack-nova23:52
*** songwenping_ has joined #openstack-nova23:52
*** brinzhang0 has quit IRC23:55
*** songwenping__ has quit IRC23:55
*** ociuhandu has quit IRC23:58
*** ociuhandu has joined #openstack-nova23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!