*** k_mouza has quit IRC | 00:01 | |
*** rcernin has joined #openstack-nova | 00:03 | |
*** brinzhang has quit IRC | 00:05 | |
*** luksky has quit IRC | 00:08 | |
*** brinzhang has joined #openstack-nova | 00:17 | |
*** rcernin has quit IRC | 00:24 | |
*** rcernin has joined #openstack-nova | 00:27 | |
brinzhang | gmann: do you review this patch I was said last Friday https://review.opendev.org/c/openstack/nova/+/768852/8/nova/tests/unit/api/openstack/compute/test_simple_project_usage.py#586 | 00:29 |
---|---|---|
brinzhang | gmann: From the test case, I found the show or index os-simple-projectt-usage APIs cannot be valid for 2.90 | 00:30 |
*** LinPeiWen has joined #openstack-nova | 00:36 | |
*** LinPeiWen has quit IRC | 00:41 | |
*** LinPeiWen has joined #openstack-nova | 00:46 | |
openstackgerrit | Brin Zhang proposed openstack/nova master: Fix ForbiddenWithAccelerators to HTTPForbidden for shelve API https://review.opendev.org/c/openstack/nova/+/770007 | 00:51 |
*** mlavalle has quit IRC | 01:04 | |
*** rcernin has quit IRC | 01:18 | |
*** k_mouza has joined #openstack-nova | 01:32 | |
*** macz_ has quit IRC | 01:42 | |
*** rcernin has joined #openstack-nova | 01:55 | |
*** k_mouza has quit IRC | 01:58 | |
*** rcernin has quit IRC | 02:02 | |
*** tinwood has quit IRC | 02:08 | |
*** tinwood has joined #openstack-nova | 02:11 | |
*** rcernin has joined #openstack-nova | 02:15 | |
*** zzzeek has quit IRC | 02:19 | |
*** rcernin has quit IRC | 02:20 | |
*** macz_ has joined #openstack-nova | 02:21 | |
*** zzzeek has joined #openstack-nova | 02:22 | |
*** rcernin has joined #openstack-nova | 02:23 | |
*** ociuhandu has joined #openstack-nova | 02:24 | |
*** spatel has joined #openstack-nova | 02:27 | |
*** ociuhandu has quit IRC | 02:28 | |
*** spatel has quit IRC | 02:29 | |
*** spatel has joined #openstack-nova | 02:30 | |
*** macz_ has quit IRC | 02:30 | |
*** spatel has quit IRC | 02:31 | |
*** spatel has joined #openstack-nova | 02:33 | |
*** rcernin has quit IRC | 02:38 | |
*** zzzeek has quit IRC | 02:49 | |
*** spatel has quit IRC | 02:49 | |
*** zzzeek has joined #openstack-nova | 02:51 | |
*** spatel has joined #openstack-nova | 02:55 | |
*** johanssone has quit IRC | 03:00 | |
*** johanssone has joined #openstack-nova | 03:01 | |
*** rcernin has joined #openstack-nova | 03:34 | |
*** rcernin has quit IRC | 03:39 | |
*** khomesh24 has joined #openstack-nova | 03:51 | |
*** k_mouza has joined #openstack-nova | 03:58 | |
*** k_mouza has quit IRC | 04:03 | |
*** macz_ has joined #openstack-nova | 04:47 | |
*** macz_ has quit IRC | 04:52 | |
*** haleyb has quit IRC | 05:09 | |
*** rcernin has joined #openstack-nova | 05:18 | |
*** brinzhang has quit IRC | 05:20 | |
*** brinzhang has joined #openstack-nova | 05:21 | |
*** rcernin has quit IRC | 05:26 | |
*** rcernin has joined #openstack-nova | 05:40 | |
*** rcernin has quit IRC | 05:45 | |
*** spatel has quit IRC | 05:47 | |
*** gyee has quit IRC | 06:07 | |
*** rcernin has joined #openstack-nova | 06:09 | |
*** nightmare_unreal has joined #openstack-nova | 06:32 | |
*** rcernin has quit IRC | 06:49 | |
*** spotz has quit IRC | 06:54 | |
*** antonym has quit IRC | 06:56 | |
*** antonym has joined #openstack-nova | 06:56 | |
*** rcernin has joined #openstack-nova | 07:38 | |
*** luksky has joined #openstack-nova | 07:50 | |
*** dklyle has quit IRC | 07:51 | |
*** xek_ has joined #openstack-nova | 07:52 | |
*** ralonsoh has joined #openstack-nova | 07:52 | |
*** luksky has quit IRC | 07:53 | |
*** zoharm has joined #openstack-nova | 07:55 | |
*** rpittau|afk_ is now known as rpittau | 07:57 | |
*** slaweq has joined #openstack-nova | 07:59 | |
openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 08:01 |
openstackgerrit | Wenping Song proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 08:01 |
openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | 08:01 |
openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 08:01 |
*** tesseract has joined #openstack-nova | 08:09 | |
*** rcernin has quit IRC | 08:17 | |
*** andrewbonney has joined #openstack-nova | 08:19 | |
*** rcernin has joined #openstack-nova | 08:42 | |
*** tosky has joined #openstack-nova | 08:45 | |
*** rcernin has quit IRC | 08:46 | |
openstackgerrit | MIKI Nobuhiro proposed openstack/nova master: libvirt: add IP address to libvirt guest metadata https://review.opendev.org/c/openstack/nova/+/750552 | 08:55 |
*** ociuhandu has joined #openstack-nova | 08:56 | |
*** ociuhandu has quit IRC | 08:58 | |
*** ociuhandu has joined #openstack-nova | 08:59 | |
openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Update Servers APIs https://review.opendev.org/c/openstack/nova/+/764292 | 09:01 |
*** kevko has quit IRC | 09:13 | |
*** swp20 has joined #openstack-nova | 09:14 | |
lyarwood | \o morning | 09:15 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/victoria: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/772480 | 09:18 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/ussuri: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/772481 | 09:19 |
openstackgerrit | Lee Yarwood proposed openstack/nova stable/train: api: Log os-resetState as an instance action https://review.opendev.org/c/openstack/nova/+/772482 | 09:19 |
*** ociuhandu has quit IRC | 09:19 | |
*** ociuhandu has joined #openstack-nova | 09:25 | |
*** kevko has joined #openstack-nova | 09:27 | |
*** rcernin has joined #openstack-nova | 09:27 | |
*** alexe9191 has joined #openstack-nova | 09:27 | |
*** ociuhandu has quit IRC | 09:30 | |
lyarwood | elod / melwitt / bauzas ; https://review.opendev.org/c/openstack/nova/+/758730 would you mind taking a look at this (and the cherry picks) this week? | 09:30 |
alexe9191 | Good day everyone, I was wondering if someone could help me with a question related to novaclient? | 09:36 |
alexe9191 | In order to reach the API endpoint I need to set a specific header | 09:36 |
alexe9191 | I can do this if I am writing my own python code, but I'd like to use the OpenStack cli. | 09:36 |
alexe9191 | There is sadly no -H option in the OpenStack cli. I was wondering where can I set curl options in the code of novaclient so that I can enforce passing the header? | 09:37 |
swp20 | moring gibi, please review noVNC https://review.opendev.org/c/openstack/nova/+/622336/28 ,thanks. | 09:42 |
*** derekh has joined #openstack-nova | 09:44 | |
*** rcernin has quit IRC | 09:45 | |
bauzas | lyarwood: sorry was in a meeting | 09:50 |
bauzas | but sure, I can take a look | 09:50 |
*** ociuhandu has joined #openstack-nova | 09:54 | |
*** rcernin has joined #openstack-nova | 09:58 | |
*** k_mouza has joined #openstack-nova | 09:59 | |
*** k_mouza has quit IRC | 10:03 | |
*** swp20 has quit IRC | 10:10 | |
*** songwenping_ has joined #openstack-nova | 10:10 | |
*** songwenping_ has quit IRC | 10:10 | |
*** songwenping_ has joined #openstack-nova | 10:11 | |
*** sapd1 has joined #openstack-nova | 10:11 | |
*** brinzhang has quit IRC | 10:14 | |
sapd1 | Hello everyone, I would like to use vGPU feature with Nova and KVM(QEMU). Which model should I choose? As I know If we use this feature, we need to pay license for it (NVDIA for example). Is it true? | 10:18 |
*** dtantsur|afk is now known as dtantsur | 10:18 | |
lyarwood | alexe9191: use openstacksdk, it should handle everything for you | 10:19 |
bauzas | sapd1: correct, you need a license if you want to use nvidia GPUs | 10:20 |
bauzas | for the models, sec. | 10:20 |
sapd1 | bauzas, Thanks, There is no other options for it? | 10:20 |
bauzas | sapd1: for the models : https://docs.nvidia.com/grid/latest/grid-vgpu-user-guide/index.html#supported-gpus-grid-vgpu | 10:22 |
alexe9191 | @lyar | 10:22 |
bauzas | sapd1: some folks use nvidia T4s for testing | 10:23 |
alexe9191 | @lyarwood: Thank you, I was looking for a way to hack the code locally so that I can use the openstack command line tools. But that does not seem to be the smartest course of action here. | 10:23 |
elod | lyarwood: the patch looks ok to me! | 10:23 |
elod | +2'd | 10:24 |
sapd1 | bauzas, Thanks, I will check it. | 10:26 |
bauzas | sapd1: fwiw, Intel gvt-g cards also work :p | 10:27 |
MrClayPole | admin0: "virsh list" shows no instances. I can boot the VM, run "dumpxml instance-<ref>" it shows http://paste.openstack.org/raw/801977/ and as it boots the 2 shared storage disks so they should be OK? The migration fails with "Error: Failed to perform requested operation on instance "<VM Name>", the instance has an error status: Please try again later [Error: The server has either erred or is incapable of performing the | 10:27 |
MrClayPole | requested operation. (HTTP 500) (Request-ID: <ID>)". The nova logs show http://paste.openstack.org/raw/801979/. Should I just give up at this point and recreate the VM? | 10:27 |
*** rcernin has quit IRC | 10:27 | |
bauzas | sapd1: but.... what I can say ? :) | 10:27 |
sapd1 | bauzas, could you give some recommendations? Is it required license ? | 10:27 |
bauzas | sapd1: which usecase would you like to do for vGPUs ? | 10:28 |
admin0 | virsh list --all | 10:28 |
admin0 | to also show stopped instances | 10:28 |
*** hack-char has quit IRC | 10:29 | |
bauzas | sapd1: if you want to see my face... https://www.youtube.com/watch?v=sQCgyo2BRe4 | 10:29 |
bauzas | and for the cards, well... as I said, that depends on which kind of use case you'd like to have | 10:30 |
bauzas | t4s are cheap | 10:30 |
*** hack-char has joined #openstack-nova | 10:30 | |
sapd1 | bauzas, some workloads such as ML, video transcode.. | 10:31 |
MrClayPole | Well don't I feel stupid, Thanks for pointing out the --all. This is the output when powered off http://paste.openstack.org/raw/801982/ I've taken a look and can't see anything that would block the migration | 10:31 |
bauzas | sapd1: then, test with a T4 | 10:31 |
* bauzas would love to have an openstack env at home with T4s for transcoding :p | 10:32 | |
sapd1 | bauzas, haha. Is it required license for testing ? | 10:33 |
bauzas | again, there are nvidia docs for this :p | 10:33 |
lyarwood | MrClayPole: look for req-3fc432cf-4d5c-4d9b-b16e-d06d912e93e7 in your cinder-api / cinder-volume logs | 10:33 |
lyarwood | MrClayPole: and yeah if all of your data is in these volumes it might be easier to recreate the instance | 10:34 |
bauzas | sapd1: https://docs.nvidia.com/grid/latest/grid-licensing-user-guide/index.html#license-editions-nvidia-grid | 10:34 |
lyarwood | MrClayPole: I'm assuming this is the first attempt to cold migrate that failed? | 10:34 |
lyarwood | MrClayPole: resize sorry | 10:34 |
bauzas | sapd1: and https://docs.nvidia.com/grid/latest/grid-vgpu-user-guide/index.html#virtual-gpu-types-grid | 10:35 |
bauzas | and for a T4 https://docs.nvidia.com/grid/latest/grid-vgpu-user-guide/index.html#vgpu-types-tesla-t4 | 10:36 |
MrClayPole | lyarwood: Yeah, running a cold migration. I'm temped to see this one through rather than go for the recreate as this'll be a good chance for me to start learning the internals of openstack. | 10:36 |
bauzas | sapd1: if it's just transcoding, a vApps license with a T4-1A vGPU type seems reasonable to me | 10:37 |
lyarwood | MrClayPole: cool well if you can trace that request-id in the cinder logs and pastebin them I can take a look and walk you through this | 10:38 |
bauzas | for ML, well, good luck, that highly depends on your training needs | 10:38 |
lyarwood | elod: do you know if anyone has capped get-pip.py given py27 support has now been dropped? Borked stable/queens AFAICT at least. | 10:39 |
bauzas | sapd1: but you can run for a short period of time a server without a licensed vGPU https://docs.nvidia.com/grid/latest/grid-licensing-user-guide/index.html#software-enforcement-grid-licensing | 10:40 |
sapd1 | bauzas, nice. I will request for buying it and try later. :D | 10:45 |
bauzas | sapd1: ask maybe first a nvidia rep | 10:45 |
bauzas | I'm not a sales person :) | 10:45 |
bauzas | and see which kind of license matches your need | 10:45 |
*** derekh has quit IRC | 10:46 | |
sapd1 | bauzas, yep. I need time to research on it. If I have any issues, I will ping you. thanks :D | 10:46 |
frickler | lyarwood: elod: there's some patches up for devstack about get-pip | 10:46 |
frickler | most of them pushed by elod in fact ;) | 10:46 |
bauzas | sapd1: again, neither working for nvidia, nor a sales person, but if I can help... | 10:47 |
sapd1 | bauzas, yeah :D | 10:47 |
lyarwood | frickler: I had a feeling :D | 10:48 |
* lyarwood looks | 10:48 | |
lyarwood | elod++ | 10:48 |
elod | lyarwood: frickler: yes, I noticed that amotoki had a fix for that and backported it till pike :] | 10:48 |
lyarwood | do we need a bug? I just wrote https://bugs.launchpad.net/devstack/+bug/1913283 before finding this | 10:50 |
openstack | Launchpad bug 1913283 in devstack "get-pip.py no longer supports py27" [Undecided,New] | 10:50 |
elod | it will need merging in reverse order for some patches (where there's grenade) | 10:50 |
elod | these are the patches btw: https://review.opendev.org/q/topic:%22get-pip-py27%22 | 10:51 |
lyarwood | seems a little over the top, can't we just set PIP_GET_PIP_URL on the py27 jobs? | 10:53 |
frickler | lyarwood: then people will complain that their local stuff fails. I personally am all for dropping py2 support completely, but it doesn't seem to be possible to get consensus on that yet | 10:59 |
lyarwood | frickler: ah fair | 11:00 |
*** rcernin has joined #openstack-nova | 11:04 | |
*** brinzhang has joined #openstack-nova | 11:04 | |
*** k_mouza has joined #openstack-nova | 11:05 | |
*** alexe9191 has quit IRC | 11:07 | |
*** rpittau is now known as rpittau|bbl | 11:09 | |
*** masterpe has quit IRC | 11:19 | |
*** masterpe has joined #openstack-nova | 11:29 | |
gibi | stephenfin: hi! if you need me to look at the placement test isolation issue then could you summarize what is the problem? is there a simple reproduction of the problem I can do locally to start with? | 11:33 |
*** rcernin has quit IRC | 11:35 | |
khomesh24 | #openstack-nova Hello, can someone check the bug https://bugs.launchpad.net/nova/+bug/1913016? | 11:40 |
openstack | Launchpad bug 1913016 in OpenStack Compute (nova) "nova api os-resetState should not reset the state when VM is shelved_offloaded" [Undecided,New] - Assigned to Khomesh Thakre (khomesh24) | 11:40 |
sean-k-mooney | gibi: i think the issue is each of the gabby test files are written such that they need to be run indepently | 11:42 |
lyarwood | khomesh24: that looks valid to me, did you have a patch? | 11:42 |
sean-k-mooney | for example https://github.com/openstack/placement/blob/master/placement/tests/functional/gabbits/shared-resources.yaml | 11:43 |
sean-k-mooney | needs to be run with its own placment instance | 11:44 |
sean-k-mooney | although that is proably not the best example since it wont conflict with others since other dont create inventoies of CUSTOM_MAGIC | 11:46 |
stephenfin | gibi: I just figured it out | 11:47 |
stephenfin | https://storyboard.openstack.org/#!/story/2008556 | 11:47 |
stephenfin | pushing a fix shortly | 11:48 |
gibi | sean-k-mooney, stephenfin: thanks, then I will not dig into it | 11:50 |
sean-k-mooney | stephenfin: i assume that is because we are using a global object at some point and not mockign it propertly in the tests | 11:51 |
*** tbachman has quit IRC | 11:52 | |
stephenfin | yes, the RuleDefault objects provided in placement.policies.* | 11:52 |
gibi | sean-k-mooney: replied in https://review.opendev.org/c/openstack/nova/+/757109 I think you missed the @retries decorator | 11:59 |
khomesh24 | lyarwood, no i wanted to valid first | 12:00 |
*** kevko has quit IRC | 12:07 | |
lyarwood | khomesh24: kk for me it's valid, I've marked the bug as confirmed | 12:07 |
lyarwood | khomesh24: it doesn't make sense to allow an admin to reset to active if the instance is offloaded | 12:07 |
khomesh24 | lyarwood, ack, i will start working on the patch then, thank you | 12:08 |
gibi | lyarwood, khomesh24: do we then make os-resetState smart for other non valid reality-db state combinations too? | 12:12 |
gibi | for me os-resetState is a blunt instrument, and the implementation also suggest that (it validates nothing) | 12:13 |
lyarwood | gibi: I wouldn't be opposed to it tbh, anything we can do to avoid obvious PEBKAC is good with me | 12:13 |
gibi | lyarwood: so when the admin reset to ACTIVE then we should call down to the compute to validate that the instance is really running happily? | 12:14 |
lyarwood | gibi: no I'd just sanity check the vm_state | 12:14 |
lyarwood | gibi: SHELVED_OFFLOADED to ACTIVE obviously isn't valid | 12:15 |
lyarwood | gibi: https://docs.openstack.org/api-ref/compute/?expanded=reset-server-state-os-resetstate-action-detail#reset-server-state-os-resetstate-action the docs are also wrong, you can set any valid vm_state AFAICT | 12:16 |
gibi | lyarwood: is it not valid as ACTIVE would need instance.host set but we assume that in SHELVED_OFFLOADED the instance.host is None? | 12:16 |
lyarwood | gibi: correct, any further action would just fail | 12:16 |
lyarwood | gibi: I don't want to block admins from fixing actual issues with instances | 12:17 |
lyarwood | gibi: but I can't see how allowing SHELVED_OFFLOADED to ACTIVE would help in any situation tbh | 12:17 |
lyarwood | gibi: lets wait for a patch to emerge and we can thrash this out on the review | 12:17 |
gibi | lyarwood: the api schema restricts the new state to enum': ['active', 'error'] | 12:17 |
lyarwood | ah | 12:17 |
lyarwood | thanks | 12:18 |
gibi | lyarwood: OK, then I would not depend on SHELVED_OFFLOADED but depend on instance.host is not None, when resetting to ACTIVE | 12:18 |
gibi | that would catch ERROR -> ACTIVE for VM that was never scheduled to a host | 12:18 |
gibi | (and other edge cases, I guess) | 12:19 |
*** ociuhandu has quit IRC | 12:19 | |
*** ociuhandu has joined #openstack-nova | 12:19 | |
gibi | lyarwood: also I would add warning to the API ref that resetting state is dangerous | 12:20 |
*** ociuhandu has quit IRC | 12:24 | |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Suppress policy deprecation warnings https://review.opendev.org/c/openstack/placement/+/771852 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Allow project readers to see project-specific usages https://review.opendev.org/c/openstack/placement/+/771964 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Refactor usage tests to properly test project personas https://review.opendev.org/c/openstack/placement/+/772061 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Deprecate 'admin_api' rule https://review.opendev.org/c/openstack/placement/+/772334 | 12:25 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Don't persist default rule changes in tests https://review.opendev.org/c/openstack/placement/+/772508 | 12:25 |
gibi | sean-k-mooney: replied here too https://review.opendev.org/c/openstack/nova/+/769720 | 12:27 |
*** khomesh24 has quit IRC | 12:34 | |
*** LinPeiWen has quit IRC | 12:42 | |
*** kevko has joined #openstack-nova | 12:55 | |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Allow project readers to see project-specific usages https://review.opendev.org/c/openstack/placement/+/771964 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Refactor usage tests to properly test project personas https://review.opendev.org/c/openstack/placement/+/772061 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333 | 12:55 |
openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Deprecate 'admin_api' rule https://review.opendev.org/c/openstack/placement/+/772334 | 12:55 |
gibi | sean-k-mooney: and here too https://review.opendev.org/c/openstack/nova/+/756530 | 12:55 |
*** ociuhandu has joined #openstack-nova | 12:56 | |
*** rpittau|bbl is now known as rpittau | 12:59 | |
stephenfin | johnthetubaguy: If you have any time in the next fortnight, your attention would be appreciated on https://review.opendev.org/q/topic:%22secure-rbac%22+project:openstack/placement+is:open | 13:02 |
sean-k-mooney | gibi: you are right i did miss the retry decorator | 13:09 |
sean-k-mooney | gibi: and yes i know mypy is smart enough to deduce types when you initalise something directly but i dont think we should actully rely on that in general | 13:11 |
sean-k-mooney | gibi: that is just a prefernce however not a -1 thing | 13:12 |
sean-k-mooney | well i dont know i change my mind on that some times | 13:13 |
sean-k-mooney | i do sometimes use that to say it returns/accpets dict or list | 13:13 |
gibi | mypy requires you to add typehint for func signature (or it will use Any) but in function body mypy does proper deducing or will raise an error and ask you to add hints | 13:20 |
gibi | if the type is not clear | 13:21 |
sean-k-mooney | ya | 13:22 |
openstackgerrit | Merged openstack/nova stable/victoria: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758730 | 13:23 |
sean-k-mooney | gibi: +1 on both of those reviews | 13:26 |
gibi | thanks | 13:28 |
sean-k-mooney | lyarwood: bauzas: stephenfin and I are both +2/+1 on gibi's qos seriese https://review.opendev.org/q/topic:%22bp%252Fsupport-interface-attach-with-qos-ports%22+(status:open%20OR%20status:merged) do either of ye have time to review them and be the second +2+w | 13:30 |
*** tbachman has joined #openstack-nova | 13:30 | |
gibi | would be appreciated ^^ | 13:30 |
*** martinkennelly has joined #openstack-nova | 13:33 | |
*** macz_ has joined #openstack-nova | 13:45 | |
*** macz_ has quit IRC | 13:50 | |
*** mlavalle has joined #openstack-nova | 13:57 | |
gmann | brinzhang: ack, with change in routes.py it should detect the new API. let me check today | 13:58 |
*** spatel has joined #openstack-nova | 14:02 | |
*** macz_ has joined #openstack-nova | 14:06 | |
*** macz_ has quit IRC | 14:11 | |
nightmare_unreal | brinzhang: can you help me with this one ? https://storyboard.openstack.org/#!/story/2008553 | 14:11 |
*** stand has quit IRC | 14:24 | |
*** brinzhang has quit IRC | 14:25 | |
*** brinzhang has joined #openstack-nova | 14:25 | |
*** stand has joined #openstack-nova | 14:26 | |
*** zenkuro has quit IRC | 14:26 | |
*** zenkuro has joined #openstack-nova | 14:27 | |
*** songwenping_ has quit IRC | 14:27 | |
*** songwenping_ has joined #openstack-nova | 14:28 | |
bauzas | sean-k-mooney: ack, sorry for the delay, but I'll try to look at it | 14:28 |
bauzas | I actually promised some time for gibi :D | 14:29 |
sean-k-mooney | bauzas: :) while the series is longish most patches are small and self contaiend so its quite straight forward to review. | 14:30 |
*** stand has quit IRC | 14:43 | |
openstackgerrit | Merged openstack/nova master: db: Compact Icehouse database migrations https://review.opendev.org/c/openstack/nova/+/758394 | 14:44 |
*** dave-mccowan has joined #openstack-nova | 14:44 | |
*** nweinber has joined #openstack-nova | 14:46 | |
*** dave-mccowan has quit IRC | 14:46 | |
*** brinzhang has quit IRC | 14:48 | |
*** bbowen has quit IRC | 14:48 | |
openstackgerrit | Lance Bragstad proposed openstack/placement master: trivial: Remove TODO in LegacyRBACPolicyFixture https://review.opendev.org/c/openstack/placement/+/772535 | 14:49 |
*** brinzhang has joined #openstack-nova | 14:51 | |
*** brinzhang has quit IRC | 14:51 | |
*** brinzhang has joined #openstack-nova | 14:52 | |
*** bbowen has joined #openstack-nova | 14:53 | |
stephenfin | lbragstad: Replied on https://review.opendev.org/c/openstack/placement/+/760238 | 15:03 |
lyarwood | sean-k-mooney: yup I can try to look today | 15:03 |
*** ralonsoh has quit IRC | 15:04 | |
*** ralonsoh has joined #openstack-nova | 15:04 | |
lbragstad | stephenfin ack - thanks | 15:15 |
*** gary_perkins has quit IRC | 15:28 | |
*** dklyle has joined #openstack-nova | 15:45 | |
lyarwood | gibi / dansmith ; https://review.opendev.org/c/openstack/nova/+/771837 should be ready to go now both of the tests are fixed | 15:47 |
gibi | lyarwood: ack | 15:48 |
*** sapd1_x has joined #openstack-nova | 15:54 | |
*** ociuhandu has quit IRC | 15:56 | |
*** ociuhandu has joined #openstack-nova | 15:57 | |
openstackgerrit | Stephen Finucane proposed openstack/placement master: Expand legacy tests for inventories https://review.opendev.org/c/openstack/placement/+/772567 | 15:58 |
stephenfin | lbragstad: ^ | 15:58 |
stephenfin | That's super tedious work. I don't envy you /o\ | 15:58 |
lbragstad | :) | 15:58 |
stephenfin | (and won't be pulling my +2s because they're missing, tbh. I can do without them) | 15:59 |
lbragstad | i'm in the middle of attempting the same for cinder - but thanks for proposing those | 15:59 |
lbragstad | yeah - i think that series looks good and i can propose the followup with additional coverage | 16:00 |
stephenfin | agreed | 16:00 |
stephenfin | we'll see what gmann thinks | 16:00 |
*** ociuhandu has quit IRC | 16:01 | |
*** macz_ has joined #openstack-nova | 16:02 | |
*** macz_ has quit IRC | 16:02 | |
*** ociuhandu has joined #openstack-nova | 16:04 | |
dansmith | lyarwood: question for you here: https://review.opendev.org/c/openstack/tempest/+/771958 | 16:05 |
dansmith | not sure I understand what actually changed | 16:06 |
*** kevko has quit IRC | 16:06 | |
*** ysirndjuro has joined #openstack-nova | 16:07 | |
gmann | stephenfin: lbragstad ack, I will check config things on policy init locally as config setting come into pic when test run and start the policy enforcement instead of policy__init__. but I am ok with the current approach. | 16:07 |
gmann | will review those today | 16:07 |
gmann | config things are similar to what we do in nova. init policy first and then switch the config flag for enforce scope | 16:08 |
ysirndjuro | Is there a way to bake "cpu mode='host-passthrough'" flag inside an image or flavor for nested virt support in an on demand VM, so far the only docs i've found have been from devstack and involve direct virsh edit to an existing VM. | 16:10 |
*** jamesdenton has quit IRC | 16:11 | |
*** jamesden_ has joined #openstack-nova | 16:11 | |
ysirndjuro | or do I just slap 'cpu_mode=host-passthrough' in nova.conf and call it a day | 16:12 |
sean-k-mooney | ysirndjuro:no that is intetniolly not supported | 16:13 |
lyarwood | dansmith: the tests were just creating a fresh image instead of reusing CONF.compute.image_ref, I assumed that borked caching in the job and resulted in us hitting the never_download_image_if_on_rbd check | 16:13 |
* lyarwood looks | 16:13 | |
sean-k-mooney | users cannot set the cpu_mode | 16:13 |
sean-k-mooney | so we dont support it in the image | 16:13 |
dansmith | lyarwood: I don't think so | 16:13 |
dansmith | lyarwood: in that job, we upload the image initially to the file backend in glance, and make nova auto copy it to ceph on the first boot | 16:14 |
dansmith | lyarwood: so just creating another image in the file repo should do the same thing | 16:14 |
sean-k-mooney | and we dont support setting the mode in the flavor since its specific to libvirt and we dont want to encurage a different flavor per cpu model | 16:14 |
sean-k-mooney | ysirndjuro: so either set it in your nova.conf via your local.conf | 16:15 |
dansmith | lyarwood: I'm thinking there's some cinder interaction that tries to do something with that image before it has been moved to ceph, but then your change won't actually make any difference if that test happens to run before any other job that just boots an instance from the normal image | 16:15 |
sean-k-mooney | or modify it and restart n-cpu | 16:15 |
ysirndjuro | sean-k-mooney: thx, yeah figured as much there, was leaning towards a flavor config, feelsbad | 16:15 |
sean-k-mooney | ysirndjuro: this is more or less my default local.conf http://paste.openstack.org/show/801996/ | 16:16 |
lyarwood | dansmith: pretty sure the volume is empty | 16:16 |
lyarwood | dansmith: let me check | 16:17 |
sean-k-mooney | ysirndjuro: it has it set so you can copy that | 16:17 |
lyarwood | dansmith: yeah the volume shouldn't reference any image ref | 16:17 |
dansmith | lyarwood: okay well then I don't see what your change would actually do differently (in the case where that test happens to run first | 16:18 |
lyarwood | 49942 Jan 20 22:28:53.068420 ubuntu-focal-rax-iad-0022637570 nova-compute[94729]: WARNING nova.virt.libvirt.driver [None req-3a8ebd8e-b22a-446f-ad35-16b12e7a1182 tempest-TestEncryptedCinderVolumes-88193216 tempest-TestEncryptedCinderVolumes-88193216] Image 0d4ef007-9ffd-4b8f-9bd2-1d9e3fca5f1b is not on my ceph and [workarounds]/never_download_image_if_on_rbd=True; refusing to fetch and | 16:18 |
lyarwood | upload.: nova.exception.ImageUnaccep table: Image 0d4ef007-9ffd-4b8f-9bd2-1d9e3fca5f1b is unacceptable: Image is not raw format | 16:18 |
lyarwood | ^ that's the error with the original image | 16:18 |
dansmith | yeah | 16:18 |
dansmith | is that in a boot or something else? | 16:19 |
lyarwood | that's on boot | 16:19 |
ysirndjuro | sean-k-mooney: thx for the sample, i've seen that config option already, but was looking to avoid enabling it on every vm on that node, just specific use case where it's needed for CI/CD to run packer builds, but with on-demand capability versus having an openstack admin configure every vm CI spins up | 16:20 |
sean-k-mooney | dansmith: by the way i havent forgoten about testing your devstack patch. im going to test it slightly differently then the gate would in that i did a stack on the node, now im going to unstack and stack again use that as my base time and then unstace and stack with your patch | 16:20 |
dansmith | lyarwood: so nova should ask glance to copy that to the ceph store first, just like it initially did for the image_ref one | 16:20 |
dansmith | sean-k-mooney: thanks | 16:20 |
sean-k-mooney | dansmith: that should elimiate any network overhead | 16:20 |
lyarwood | dansmith: would that be rejected if the disk format isn't RAW? | 16:21 |
dansmith | lyarwood: ...if it's a normal boot all the same as the original.. that's why I'm wondering what else might be different | 16:21 |
sean-k-mooney | ysirndjuro: you can kind fo do what you want if you define your own cpu model in the libvirt directorys | 16:21 |
dansmith | lyarwood: mmmmaybe, what format is the image they created? | 16:22 |
dansmith | lemme look at the conditions for that again | 16:22 |
sean-k-mooney | ysirndjuro: if you use cpu_mode=custom then cpu_model=<default model you want>,<nested-virt-modele> then have a special flavor that request vmx i belive that willl work | 16:22 |
lyarwood | dansmith: I see qcow2 in the request to glance | 16:23 |
dansmith | ah, hmm | 16:23 |
sean-k-mooney | ysirndjuro: you should be able to use https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/cpu-model-selection.html to achive your usecase | 16:25 |
ysirndjuro | literally just dmd u to verify that link haha | 16:25 |
sean-k-mooney | ysirndjuro: but you will need to define a new cpu model with vmx | 16:25 |
dansmith | lyarwood: ah, okay, yeah.. we don't even get to the download code because of this in clone: if image_meta.get('disk_format') not in ['raw', 'iso']: | 16:25 |
lyarwood | dansmith: right it's raising before we get to the copy | 16:25 |
ysirndjuro | ty, will play with that | 16:25 |
lyarwood | dansmith: snap | 16:25 |
dansmith | okay, cool, now I'm a believer :) | 16:25 |
lyarwood | wonderful | 16:26 |
*** artom has quit IRC | 16:28 | |
*** artom has joined #openstack-nova | 16:29 | |
*** ociuhandu_ has joined #openstack-nova | 16:31 | |
*** ociuhandu has quit IRC | 16:35 | |
*** ociuhandu_ has quit IRC | 16:36 | |
*** gary_perkins has joined #openstack-nova | 16:36 | |
*** gyee has joined #openstack-nova | 16:40 | |
*** zenkuro has quit IRC | 16:43 | |
*** mlavalle has quit IRC | 16:44 | |
*** mlavalle has joined #openstack-nova | 16:45 | |
*** ociuhandu has joined #openstack-nova | 16:49 | |
bauzas | dansmith: man, you mean a belieber ? ;) | 16:50 |
dansmith | bauzas: in this *one* thing :) | 16:52 |
dansmith | unless that's a justin bieber joke, in which case.. no. | 16:52 |
* bauzas can't imagine it | 16:52 | |
bauzas | yeah, was just a bad joke | 16:53 |
* bauzas goes outside | 16:53 | |
*** ociuhandu has quit IRC | 16:53 | |
stephenfin | bauzas: bad jokes mean you have to go outside? | 16:54 |
stephenfin | She has you well trained ;) | 16:54 |
bauzas | stephenfin: indeed :) | 16:54 |
*** zenkuro has joined #openstack-nova | 16:58 | |
*** nightmare_unreal has quit IRC | 17:00 | |
sean-k-mooney | dansmith: so when the system is up to date and the repos are already there it looks like the async task change does not make much of a difference its better but only slightly http://paste.openstack.org/show/802006/ | 17:11 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: add AsyncDeviceDetachEventsHandler https://review.opendev.org/c/openstack/nova/+/772381 | 17:11 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: allow querying devices from the persistent domain https://review.opendev.org/c/openstack/nova/+/772383 | 17:11 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: libvirt: parse alias out from device config https://review.opendev.org/c/openstack/nova/+/772384 | 17:11 |
sean-k-mooney | dansmith: i can however try it again with a clean vm and see what teh delta is then | 17:12 |
sean-k-mooney | looking at the console output too i did not see any real change either so it does not seam to affect the debugablity of things | 17:13 |
openstackgerrit | Balazs Gibizer proposed openstack/nova master: Replace blind retry with libvirt event waiting in detach https://review.opendev.org/c/openstack/nova/+/770246 | 17:14 |
dansmith | sean-k-mooney: did you enable async? doesn't look like it | 17:16 |
dansmith | DEVSTACK_PARALLEL=True | 17:16 |
sean-k-mooney | dansmith: it looks like its saveing between 5 and 16 second over a 830 seconds | 17:16 |
sean-k-mooney | oh hehe no | 17:16 |
sean-k-mooney | well in that case i have a better base line | 17:16 |
sean-k-mooney | ill let it restack again | 17:16 |
dansmith | sean-k-mooney: you should see a timing compotent for async_wait once you do | 17:16 |
sean-k-mooney | ok i was seeign async task prinnted but i guess it was blocking | 17:17 |
dansmith | yeah it'll still print those things but wait instead of spawn | 17:17 |
dansmith | sean-k-mooney: how many vcpus on the vm you're using? | 17:18 |
sean-k-mooney | 8 | 17:18 |
dansmith | ack | 17:18 |
dansmith | there are some things that are actually cpu bound, but if you only had one it wouldn't help | 17:19 |
dansmith | the db_syncs for example | 17:19 |
sean-k-mooney | this is like a upstream node so 8 cores and 8GB of ram although it has 2 numa nodes and nested vert | 17:19 |
sean-k-mooney | ya looking at load | 17:19 |
sean-k-mooney | 15 min avgerage is like 0.76 | 17:20 |
sean-k-mooney | it was using 1-2 cores max while running before | 17:20 |
sean-k-mooney | it spiked a littel when doing the db migrations | 17:20 |
sean-k-mooney | so that is where the extra cores definetly help | 17:21 |
dansmith | yeah, on one of my machines it went from about 0.5 to 2.0 | 17:21 |
dansmith | not for the whole thing but for good portions of it | 17:21 |
sean-k-mooney | ok its stacking again ill let you know in 15 mins or so | 17:21 |
sean-k-mooney | 13-15 mins is what i normally expect for this vm so if its better or the same then the patch is proably an improvment | 17:22 |
dansmith | cool | 17:22 |
*** rpittau is now known as rpittau|afk | 17:27 | |
sean-k-mooney | and done | 17:31 |
sean-k-mooney | it hit 3.78 there for a bit | 17:31 |
sean-k-mooney | http://paste.openstack.org/show/802007/ | 17:32 |
sean-k-mooney | so that is much better | 17:32 |
dansmith | 30% | 17:33 |
dansmith | you're welcome :) | 17:33 |
sean-k-mooney | what me to test this on clean vms to see what impact it has then | 17:33 |
sean-k-mooney | this is how i normallyuse devstack however | 17:33 |
sean-k-mooney | so 30% on my normal uscase it very good | 17:34 |
dansmith | well, the gate preloads the project git dirs, so it's closer to what you just tested | 17:34 |
sean-k-mooney | ya it is | 17:34 |
dansmith | there is more fat to be cut, by the way | 17:34 |
dansmith | I've optimized some of stack.sh and nova, | 17:34 |
sean-k-mooney | and they cache the pip and apt stuff close to the vms too | 17:34 |
dansmith | but there are things neutron does that we can parallellize I think | 17:34 |
dansmith | oh I did a bunch of keystone things too | 17:34 |
sean-k-mooney | did you look at the plugins | 17:35 |
dansmith | being able to stack in 6 minutes is a major life improvement to me | 17:35 |
sean-k-mooney | i would have to run in offlinemode to do that | 17:35 |
dansmith | only tempest, which I do some of in parallel, but we regen the venv several times for reasons I don't understand, but we could probably improve there too | 17:35 |
sean-k-mooney | ya i have seen that | 17:36 |
sean-k-mooney | its not clear to me why either | 17:36 |
sean-k-mooney | the local pip cache helps but its not perfect | 17:36 |
sean-k-mooney | dansmith: what was your normal stack time before out of interest | 17:37 |
dansmith | sean-k-mooney: on my usual stripped-down config, it's 513s serialized, 402s parallell | 17:38 |
sean-k-mooney | ya not bad still a nice improvment | 17:39 |
sean-k-mooney | that said even a 15min run is better then ooo | 17:39 |
dansmith | mm yeah :) | 17:40 |
*** sapd1_x has quit IRC | 17:41 | |
sean-k-mooney | dansmith: apparently our downstreeam upgrade jobs take 11hours currently. | 17:42 |
dansmith | yeah that's pretty sadface | 17:43 |
sean-k-mooney | i just can even comprehend debuging those if they fail | 17:43 |
dansmith | yeah :/ | 17:43 |
dansmith | sean-k-mooney: if you could comment on that async patch with your results and environment, I'd appreciate it | 17:43 |
sean-k-mooney | yep i need to prep a fedra 32 vm for other things anyway today so ill do a fresh install run on that and comment when its done with the details | 17:44 |
dansmith | okay thanks | 17:44 |
dansmith | gmann: results from sean-k-mooney btw :) ^ | 17:45 |
dansmith | tl;dr his VMs are closer to upstream gate and he got 30% improvement | 17:45 |
sean-k-mooney | i can test this in my ci later in the week proably too need to do some maintance on it before i do but i have some other things to rebase and backport first so wont get to it for a while | 17:46 |
dansmith | sean-k-mooney: was that a fairly fat devstack config? like all the normal services? | 17:47 |
sean-k-mooney | yes an no ill past bin it | 17:48 |
sean-k-mooney | http://paste.openstack.org/show/802010/ | 17:49 |
sean-k-mooney | no swift or heat but i hav ecinder and horizon | 17:49 |
*** zoharm has quit IRC | 17:49 | |
gmann | dansmith: sean-k-mooney nice. are you running it on fresh machine with/wihtout devstack-parallel or with/without unstack/stack ? | 17:49 |
sean-k-mooney | so nova,neutron,placement,cinder,glance,horizon,tempest with ml2/ovs | 17:50 |
dansmith | gmann: when I test, I run it with/without parallel on a "warmed up" machine, i.e. where /opt/stack already has the projects cloned, like gate | 17:50 |
dansmith | we could definitely parallelize the cloning of all the projects too | 17:50 |
sean-k-mooney | gmann: basically the same for my test | 17:51 |
sean-k-mooney | gmann: i stacked then unstack | 17:51 |
dansmith | sean-k-mooney: ack, okay mine is no cinder or horizin | 17:51 |
dansmith | right, stack/unstack/stack | 17:51 |
sean-k-mooney | then stacked again to get the baseline time unstackted. and stacked in parallel mode | 17:51 |
sean-k-mooney | so all the pacakge and repos should be cached or clonned | 17:51 |
gmann | yeah clone is not something to count in this | 17:51 |
*** zenkuro has quit IRC | 17:52 | |
sean-k-mooney | i did not have OFFLINE=True which i can do that would disable all package installs and clones but it should not really be a factor in my current testing | 17:54 |
sean-k-mooney | ill let ye both know how the fresh install goes | 17:54 |
dansmith | once the system is warmed up I don't think that would do much anyway, right? | 17:55 |
sean-k-mooney | it will prevent it even trying to do apt/dnf install i dont think it really affect pip however | 17:56 |
sean-k-mooney | so when its primmed no not really | 17:56 |
dansmith | ack, but apt should mostly just say "yeah already got that" | 17:56 |
dansmith | minor improvement maybe but nothing major | 17:56 |
dansmith | in the noise I expect | 17:56 |
sean-k-mooney | yep it just has to check the index is up to date | 17:56 |
sean-k-mooney | also i have gigabit networking at home so its going to be pretty fast considing i sit less then 2 miles form where the irish henet mirrors are hosted | 17:57 |
sean-k-mooney | there hosted in the university i live beside | 17:58 |
sean-k-mooney | 64 bytes from ftp-node-prod-bl-01.heanet.ie (193.1.193.10): icmp_seq=1 ttl=58 time=7.50 ms | 17:59 |
sean-k-mooney | vs 64 bytes from 172.20.4.244: icmp_seq=15 ttl=62 time=3.41 ms to my vm :) | 18:01 |
*** tesseract has quit IRC | 18:16 | |
*** k_mouza has quit IRC | 18:48 | |
sean-k-mooney | looks like my clean fedora run is going to fail because the cirros download is hanging | 18:58 |
sean-k-mooney | so ill just post my old results and node details to the devstack review | 18:58 |
*** ianw_pto is now known as ianw | 18:59 | |
openstackgerrit | Merged openstack/nova master: Move query param generation to RequestGroup o.vo https://review.opendev.org/c/openstack/nova/+/756894 | 19:12 |
*** andrewbonney has quit IRC | 19:16 | |
gmann | stephenfin: lbragstad should not placement_policy.reset() take care of cleaning all default or registered rules? https://review.opendev.org/c/openstack/placement/+/772508/1/placement/tests/unit/policy_fixture.py#36 | 19:33 |
gmann | I am not completely understanding how it is causing the issue with placement_policy.reset() in test. though i agree on fixing it on oslo policy side | 19:33 |
gmann | or something i am missing here | 19:34 |
*** hamalq has joined #openstack-nova | 19:36 | |
dansmith | sean-k-mooney: thanks | 19:58 |
*** sapd1_x has joined #openstack-nova | 20:05 | |
*** sapd1 has quit IRC | 20:06 | |
gmann | lbragstad: before I proceed on other patches in that series, one comment about SYSTEM_ADMIN https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/base.py#20 | 20:15 |
gmann | I think we do not need SYSTEM_ADMIN in placement as such | 20:15 |
gmann | and this way is better and avoid rule deprecation - https://review.opendev.org/c/openstack/placement/+/760235/10/placement/policies/aggregate.py#52 | 20:16 |
*** ralonsoh has quit IRC | 20:42 | |
*** brinzhang_ has joined #openstack-nova | 20:44 | |
lbragstad | gmann i think that's true with the exception of the usage api since it supports project and system scope? | 20:45 |
lbragstad | actually - not if enforce_scope=True | 20:46 |
gmann | lbragstad: yeah usage API use only reader right | 20:47 |
*** brinzhang has quit IRC | 20:47 | |
gmann | if enforce_scope=True then scope_type will care as existing scope is system for admin API | 20:48 |
gmann | only use case i see is if enforce_scope=False , enforce_new_defaults=True but technically there is no new default for admin APIs its admin only right | 20:51 |
*** dtantsur is now known as dtantsur|afk | 20:55 | |
*** nweinber has quit IRC | 21:02 | |
*** k_mouza has joined #openstack-nova | 21:06 | |
*** k_mouza has quit IRC | 21:10 | |
openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: compute: Lock by instance.uuid lock during swap_volume https://review.opendev.org/c/openstack/nova/+/758732 | 21:12 |
*** hamalq has quit IRC | 21:21 | |
*** hamalq has joined #openstack-nova | 21:21 | |
*** xek_ has quit IRC | 21:24 | |
*** k_mouza has joined #openstack-nova | 21:25 | |
*** k_mouza has quit IRC | 21:30 | |
*** nweinber has joined #openstack-nova | 21:34 | |
*** raildo has quit IRC | 21:47 | |
*** nweinber has quit IRC | 22:02 | |
*** nweinber has joined #openstack-nova | 22:05 | |
*** slaweq has quit IRC | 22:08 | |
*** nweinber has quit IRC | 22:10 | |
*** rcernin has joined #openstack-nova | 22:16 | |
*** rcernin has quit IRC | 22:24 | |
*** rcernin has joined #openstack-nova | 22:24 | |
*** k_mouza has joined #openstack-nova | 22:26 | |
*** k_mouza has quit IRC | 22:31 | |
*** spatel has quit IRC | 22:50 | |
*** tbachman_ has joined #openstack-nova | 22:56 | |
*** tbachman has quit IRC | 22:58 | |
*** tbachman_ is now known as tbachman | 22:58 | |
openstackgerrit | Merged openstack/nova master: db: Compact Juno database migration https://review.opendev.org/c/openstack/nova/+/758395 | 23:16 |
*** tosky has quit IRC | 23:18 | |
*** k_mouza has joined #openstack-nova | 23:26 | |
*** tbachman_ has joined #openstack-nova | 23:26 | |
*** tbachman has quit IRC | 23:27 | |
*** tbachman_ is now known as tbachman | 23:27 | |
*** k_mouza has quit IRC | 23:30 | |
*** admin0 has quit IRC | 23:39 | |
*** ircuser-1 has joined #openstack-nova | 23:46 | |
sean-k-mooney | lbragstad: gmann im going to stop reviewing the palcemnt series until ye have a chance ot responed regarding defineing SYTEM_ADMIN as a dict and preferably in oslo policy eventually | 23:56 |
sean-k-mooney | i really think that SYSTEM_ADMIN should be a common shared defintion across all poject and not something that can vary between cloud or services. | 23:58 |
gmann | sean-k-mooney: lbragstad stephenfin replied on https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/base.py#20 | 23:59 |
*** admin0 has joined #openstack-nova | 23:59 | |
gmann | sean-k-mooney: we can move to common place but there are few challenge in doing that | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!