| gmann | https://review.opendev.org/c/openstack/oslo.policy/+/766536 | 00:00 |
|---|---|---|
| gmann | if we want to support 4th scenario I mentioned in that review then yes we can have otherwise there is no change with SYSTEM_ADMIN and what we have currently | 00:02 |
| sean-k-mooney | well i was suggesting that at a minium we define SYSTEM_ADMIN as | 00:03 |
| sean-k-mooney | SYSTEM_ADMIN = { | 00:03 |
| sean-k-mooney | 'check_str':'role:admin and system_scope:all', | 00:03 |
| sean-k-mooney | 'scope_types': ['system'] | 00:03 |
| sean-k-mooney | } | 00:03 |
| sean-k-mooney | but i do prefer having real objects for the personas | 00:03 |
| sean-k-mooney | i am not convice that these shoudl be handeled as a rule based on reading https://review.opendev.org/c/openstack/oslo.policy/+/766536 | 00:07 |
| sean-k-mooney | gmann: the thing i want to avoid is SYSTEM_ADMIN meaning differnt things on different clouds. | 00:07 |
| sean-k-mooney | if they want to customis there personsa i think they shoudl defien entirely new ones | 00:07 |
| gmann | challenge in that we cannot add deprecation rule in that which we need at service side | 00:08 |
| gmann | so we can define it as constant for check_str | 00:09 |
| sean-k-mooney | we can make a copy and add deprecations | 00:09 |
| sean-k-mooney | this https://github.com/openstack/nova/blob/3a6c1cbc3a07814b3fecfdc23f28da9294779bcc/nova/policies/migrate_server.py#L35 | 00:09 |
| sean-k-mooney | to me is a pug in nova | 00:09 |
| gmann | yeah that is one use case | 00:09 |
| sean-k-mooney | that api is neither systme admin or project admin | 00:09 |
| sean-k-mooney | its realy a union of both | 00:10 |
| gmann | its system admin by default and allow operator to override for project users | 00:10 |
| sean-k-mooney | no its not | 00:10 |
| sean-k-mooney | its defiend right now as project admin or system admin | 00:11 |
| gmann | https://github.com/openstack/nova/blob/3a6c1cbc3a07814b3fecfdc23f28da9294779bcc/nova/policies/migrate_server.py#L27 | 00:11 |
| gmann | scope_type both means it allow both scoped token but check_str is what controlling it | 00:11 |
| sean-k-mooney | which is 'rule:system_admin_api | 00:12 |
| gmann | with special string in check_str | 00:12 |
| sean-k-mooney | which becomes rule:admin_api | 00:12 |
| gmann | system_admin_api is 'role:admin and system_scope:all', | 00:13 |
| sean-k-mooney | wher eis that defiend | 00:13 |
| sean-k-mooney | i was looking at https://github.com/openstack/nova/blob/3a6c1cbc3a07814b3fecfdc23f28da9294779bcc/nova/policies/base.py#L16 | 00:13 |
| gmann | https://github.com/openstack/nova/blob/3a6c1cbc3a07814b3fecfdc23f28da9294779bcc/nova/policies/base.py#L104 | 00:13 |
| sean-k-mooney | oh here https://github.com/openstack/nova/blob/3a6c1cbc3a07814b3fecfdc23f28da9294779bcc/nova/policies/base.py#L103-L108 | 00:14 |
| gmann | this one ^^ | 00:14 |
| sean-k-mooney | see this is already a problem in that the definiton are different beteen nova and placment | 00:14 |
| gmann | placement has already scope_type so current change for ADMIN-SYSTEM_ADMIN is not needed as such, that is my point on that review | 00:14 |
| sean-k-mooney | ii know its not needed but i dont think we should have default RBAC personcs unless they are the same across all services | 00:15 |
| gmann | ok for consistency if we want to have same default then I am ok. then we can do same in in aggregate API too https://review.opendev.org/c/openstack/placement/+/760235/10/placement/policies/aggregate.py#52 | 00:18 |
| gmann | let's see what lbragstad and stephenfin prefer. | 00:18 |
| sean-k-mooney | keystone has the same definiton for system reader as nova for what its worth | 00:20 |
| sean-k-mooney | https://github.com/openstack/keystone/blob/a98f006f854be02e5682390012d8bb917f4f3940/keystone/common/policies/base.py#L48 | 00:20 |
| gmann | like base rule we have in nova it is easy for operator to only override the 4-5 base rule only in policy file to make changes for all the policy instead of 200 rules override. that is why we defined thee as rule instead of string | 00:23 |
| sean-k-mooney | so with my downstrem had on im in two minds | 00:24 |
| sean-k-mooney | first we dont support custom policy | 00:24 |
| sean-k-mooney | so our customer are not able to override any fo them | 00:24 |
| sean-k-mooney | on the other had if they where i would have to check the policy difeintion when looking at api issue or suggesting what steps they could take for there given cloud | 00:24 |
| sean-k-mooney | so while i understand its useful for operators to quickly redfien things in reality it will make debug ing much harder | 00:25 |
| sean-k-mooney | e.g. if we have upstream bug reports or they are working with a vendor | 00:26 |
| sean-k-mooney | the interop part of me is schreaming policy is config diriven api behavior | 00:26 |
| sean-k-mooney | which is bad | 00:26 |
| sean-k-mooney | its componded by the fact as a client i have no way of determining what i am alowed to do | 00:27 |
| sean-k-mooney | there is no policy endpoin i can query to figure it out | 00:27 |
| sean-k-mooney | so for me if we have default RBAC personas across multipel project they shoudl be imutable | 00:27 |
| sean-k-mooney | we could provide a way to simpley replce SYSTEM_ADMIN with CUSTOM_SYSTEM_ADMIN via policy.yaml but i think that hsould be the excption rahter then what we expect people to do | 00:28 |
| sean-k-mooney | lbragstad: gmann that is the main context around my view on this and why i think we should have shared constants for the personas | 00:29 |
| gmann | sean-k-mooney: yeah i agree on common persona which provide much needed consistency but we need to see if those should be as constant or rule or rule-with-set-method to add deprecated rule | 00:31 |
| gmann | may be best way is to proceed with constant string. that is one of the possible option we discussed in policy meeting last week | 00:32 |
| brinzhang_ | nightmare_unreal> ack, add to my list, after done my things I will try to fill this issue | 00:34 |
| brinzhang_ | gmann: thanks ^ | 00:34 |
| *** ircuser-1 has quit IRC | 00:37 | |
| *** hamalq has quit IRC | 00:41 | |
| *** LinPeiWen has joined #openstack-nova | 00:41 | |
| *** mlavalle has quit IRC | 00:58 | |
| *** ircuser-1 has joined #openstack-nova | 01:01 | |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replace all_tenants with all_projects in List Server APIs https://review.opendev.org/c/openstack/nova/+/765311 | 01:05 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | 01:05 |
| openstackgerrit | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 01:05 |
| sapd1_x | bauzas, Hi, do we need RHEL for vGPU feature? in the supported matrix, they dont mention Ubuntu or CentOS (https://docs.nvidia.com/grid/latest/product-support-matrix/index.html) | 01:18 |
| sapd1_x | we are running Ubuntu + KVM. | 01:19 |
| *** zenkuro has joined #openstack-nova | 01:29 | |
| *** k_mouza has joined #openstack-nova | 01:30 | |
| *** k_mouza has quit IRC | 01:34 | |
| *** rcernin has quit IRC | 01:54 | |
| *** dklyle has quit IRC | 01:55 | |
| *** dklyle has joined #openstack-nova | 01:57 | |
| mnaser | sean-k-mooney: sorry for the late reply, been dealing with a lot of stuff (move and puppy) | 02:09 |
| mnaser | sean-k-mooney: we run it daily because we noticed when we don't, too many records accumualte and we end up with a near impossible to clean state | 02:10 |
| mnaser | sapd1_x: it should work fine without rhel | 02:10 |
| *** k_mouza has joined #openstack-nova | 02:10 | |
| *** ircuser-1 has quit IRC | 02:12 | |
| *** sapd__x has joined #openstack-nova | 02:13 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Drop support for UML https://review.opendev.org/c/openstack/nova/+/743230 | 02:14 |
| *** k_mouza has quit IRC | 02:15 | |
| *** ircuser-1 has joined #openstack-nova | 02:18 | |
| lbragstad | sean-k-mooney gmann fwiw - i'm fine with constant strings somewhere if that helps move things along | 02:33 |
| lbragstad | i agree having the common personas represented as objects would be ideal | 02:35 |
| *** rcernin has joined #openstack-nova | 02:38 | |
| *** rcernin has quit IRC | 02:43 | |
| *** k_mouza has joined #openstack-nova | 03:04 | |
| *** rcernin has joined #openstack-nova | 03:05 | |
| *** hemanth_n has joined #openstack-nova | 03:07 | |
| *** k_mouza has quit IRC | 03:09 | |
| *** rcernin has quit IRC | 03:12 | |
| *** rcernin has joined #openstack-nova | 03:12 | |
| *** martinkennelly has quit IRC | 03:18 | |
| *** k_mouza has joined #openstack-nova | 03:23 | |
| *** mkrai has joined #openstack-nova | 03:24 | |
| *** k_mouza has quit IRC | 03:28 | |
| *** ircuser-1 has quit IRC | 03:32 | |
| *** psachin has joined #openstack-nova | 03:36 | |
| *** ircuser-1 has joined #openstack-nova | 03:45 | |
| *** zoharm has joined #openstack-nova | 04:07 | |
| *** jamesden_ has quit IRC | 04:08 | |
| *** logan- has quit IRC | 04:08 | |
| *** f0o has quit IRC | 04:08 | |
| *** janno has quit IRC | 04:08 | |
| *** PrinzElvis has quit IRC | 04:08 | |
| *** zigo has quit IRC | 04:08 | |
| *** sorrison has quit IRC | 04:08 | |
| *** mgoddard has quit IRC | 04:11 | |
| *** mgoddard has joined #openstack-nova | 04:14 | |
| *** f0o has joined #openstack-nova | 04:14 | |
| *** janno has joined #openstack-nova | 04:14 | |
| *** PrinzElvis has joined #openstack-nova | 04:14 | |
| *** zigo has joined #openstack-nova | 04:14 | |
| *** sorrison has joined #openstack-nova | 04:14 | |
| *** masterpe has quit IRC | 04:20 | |
| *** dklyle has quit IRC | 04:24 | |
| *** sapd__x has quit IRC | 04:28 | |
| *** ircuser-1 has quit IRC | 04:31 | |
| *** jamesden_ has joined #openstack-nova | 04:34 | |
| *** logan- has joined #openstack-nova | 04:34 | |
| *** jamesden_ has quit IRC | 04:36 | |
| *** logan- has quit IRC | 04:36 | |
| *** ratailor has joined #openstack-nova | 04:36 | |
| *** jamesden_ has joined #openstack-nova | 04:38 | |
| *** logan- has joined #openstack-nova | 04:38 | |
| *** vishalmanchanda has joined #openstack-nova | 04:41 | |
| *** ysirndjuro has quit IRC | 04:44 | |
| *** jamesden_ has quit IRC | 04:54 | |
| *** logan- has quit IRC | 04:54 | |
| *** jamesden_ has joined #openstack-nova | 04:57 | |
| *** logan- has joined #openstack-nova | 04:57 | |
| *** sapd__x has joined #openstack-nova | 05:19 | |
| *** k_mouza has joined #openstack-nova | 05:21 | |
| *** k_mouza has quit IRC | 05:26 | |
| *** spatel has joined #openstack-nova | 05:29 | |
| *** sapd__x has quit IRC | 05:32 | |
| *** spatel has quit IRC | 05:33 | |
| *** masterpe has joined #openstack-nova | 05:36 | |
| *** k_mouza has joined #openstack-nova | 05:57 | |
| *** avolkov has joined #openstack-nova | 05:59 | |
| *** k_mouza has quit IRC | 06:01 | |
| *** lbragstad has quit IRC | 06:03 | |
| *** lbragstad has joined #openstack-nova | 06:03 | |
| *** k_mouza has joined #openstack-nova | 06:29 | |
| *** k_mouza has quit IRC | 06:33 | |
| *** gyee has quit IRC | 06:44 | |
| *** psachin has quit IRC | 06:45 | |
| *** mkrai has quit IRC | 06:55 | |
| *** mkrai_ has joined #openstack-nova | 06:55 | |
| *** psachin has joined #openstack-nova | 07:00 | |
| *** hoonetorg has quit IRC | 07:14 | |
| *** mkrai_ has quit IRC | 07:14 | |
| *** hoonetorg has joined #openstack-nova | 07:19 | |
| *** LinPeiWen has quit IRC | 07:19 | |
| openstackgerrit | Wenping Song proposed openstack/os-traits master: remove babel.cfg https://review.opendev.org/c/openstack/os-traits/+/772634 | 07:28 |
| *** lpetrut has joined #openstack-nova | 07:32 | |
| *** ralonsoh has joined #openstack-nova | 07:34 | |
| *** psachin has quit IRC | 07:36 | |
| *** psachin has joined #openstack-nova | 07:37 | |
| *** khomesh24 has joined #openstack-nova | 07:39 | |
| *** sapd__x has joined #openstack-nova | 07:45 | |
| *** mkrai_ has joined #openstack-nova | 07:51 | |
| *** andrewbonney has joined #openstack-nova | 08:08 | |
| *** slaweq has joined #openstack-nova | 08:08 | |
| *** tesseract has joined #openstack-nova | 08:10 | |
| *** songwenping_ has quit IRC | 08:15 | |
| *** songwenping_ has joined #openstack-nova | 08:15 | |
| *** xek_ has joined #openstack-nova | 08:29 | |
| *** rpittau|afk is now known as rpittau | 08:30 | |
| *** tosky has joined #openstack-nova | 08:43 | |
| MrClayPole | admin0 & lyarwood Thanks for both you help recently. We were able to trace it through to a possible issue with our storage cinder driver. | 08:44 |
| *** yoctozepto5 has joined #openstack-nova | 08:47 | |
| *** yoctozepto has quit IRC | 08:48 | |
| *** yoctozepto5 is now known as yoctozepto | 08:48 | |
| *** sapd__x has quit IRC | 08:49 | |
| *** rcernin has quit IRC | 08:53 | |
| *** songwenping__ has joined #openstack-nova | 08:53 | |
| *** songwenping_ has quit IRC | 08:56 | |
| *** ociuhandu has joined #openstack-nova | 09:00 | |
| *** vishalmanchanda has quit IRC | 09:00 | |
| *** spatel has joined #openstack-nova | 09:01 | |
| lyarwood | MrClayPole: awesome, np! | 09:04 |
| *** rcernin has joined #openstack-nova | 09:04 | |
| *** sapd__x has joined #openstack-nova | 09:05 | |
| *** spatel has quit IRC | 09:05 | |
| *** sapd__x has quit IRC | 09:09 | |
| *** ccstone has quit IRC | 09:11 | |
| *** eandersson has quit IRC | 09:11 | |
| *** ccstone has joined #openstack-nova | 09:12 | |
| *** eandersson has joined #openstack-nova | 09:12 | |
| *** tkajinam has quit IRC | 09:22 | |
| bauzas | sapd1_x: you're unfortunately absolutely correct | 09:28 |
| *** derekh has joined #openstack-nova | 09:47 | |
| openstackgerrit | Wenping Song proposed openstack/os-traits master: remove babel.cfg https://review.opendev.org/c/openstack/os-traits/+/772634 | 09:47 |
| *** martinkennelly has joined #openstack-nova | 10:05 | |
| *** dtantsur|afk is now known as dtantsur | 10:18 | |
| *** martinkennelly has quit IRC | 10:25 | |
| stephenfin | bauzas: If you have time this week, there are a couple of DB compaction patches that still need a final +2, starting here https://review.opendev.org/c/openstack/nova/+/758397/ | 10:25 |
| stephenfin | Lower priority than gibi's series, but it would still be nice to close that out in Wallaby so I can work on getting alembic integrated (assuming we decide to do that) | 10:26 |
| *** nightmare_unreal has joined #openstack-nova | 10:27 | |
| bauzas | stephenfin: ack, currently reviewing gibi's series | 10:27 |
| *** whoami-rajat__ has joined #openstack-nova | 10:28 | |
| bauzas | even if I have to look at https://review.opendev.org/c/openstack/nova/+/769942/ | 10:28 |
| bauzas | mypy my love <3 | 10:28 |
| * bauzas is ironic :p | 10:28 | |
| *** rcernin has quit IRC | 10:28 | |
| *** vishalmanchanda has joined #openstack-nova | 10:28 | |
| *** LinPeiWen has joined #openstack-nova | 10:35 | |
| stephenfin | bauzas: don't you dare diss mypy | 10:35 |
| * stephenfin whispers sweet nothings to mypy | 10:35 | |
| bauzas | I love cakes | 10:36 |
| bauzas | but surely it's not mypy | 10:36 |
| stephenfin | boo this man | 10:36 |
| stephenfin | boooooo | 10:36 |
| * bauzas can' hide on an IRC channel | 10:36 | |
| bauzas | emojis are for the others | 10:37 |
| *** martinkennelly has joined #openstack-nova | 10:40 | |
| *** spatel has joined #openstack-nova | 10:49 | |
| *** spatel has quit IRC | 10:54 | |
| *** k_mouza has joined #openstack-nova | 10:54 | |
| *** yoctozepto5 has joined #openstack-nova | 11:01 | |
| *** yoctozepto has quit IRC | 11:02 | |
| *** yoctozepto5 is now known as yoctozepto | 11:02 | |
| *** rcernin has joined #openstack-nova | 11:17 | |
| *** ociuhandu has quit IRC | 11:27 | |
| *** ociuhandu has joined #openstack-nova | 11:27 | |
| *** ociuhandu has quit IRC | 11:30 | |
| *** ociuhandu has joined #openstack-nova | 11:30 | |
| *** rcernin has quit IRC | 11:31 | |
| *** martinkennelly has quit IRC | 12:04 | |
| *** ociuhandu_ has joined #openstack-nova | 12:15 | |
| *** ociuhandu has quit IRC | 12:17 | |
| *** ociuhandu_ has quit IRC | 12:19 | |
| *** ociuhandu has joined #openstack-nova | 12:23 | |
| *** ociuhandu has quit IRC | 12:28 | |
| *** raildo has joined #openstack-nova | 12:30 | |
| *** gibi has quit IRC | 12:41 | |
| *** hack-char has quit IRC | 12:42 | |
| *** hack-char has joined #openstack-nova | 12:44 | |
| *** ratailor has quit IRC | 12:45 | |
| *** khomesh24 has quit IRC | 12:45 | |
| *** hemanth_n has quit IRC | 12:50 | |
| *** liuyulong has joined #openstack-nova | 13:12 | |
| lyarwood | https://review.opendev.org/q/topic:bug/1909120 & https://review.opendev.org/q/topic:bug/1908075 could use reviews from cores if anyone has time in the coming weeks, simple enough bugfixes. | 13:13 |
| lyarwood | elod / bauzas ; https://review.opendev.org/c/openstack/nova/+/764611 & https://review.opendev.org/c/openstack/nova/+/764612 - can I get stable reviews on these please? | 13:20 |
| bauzas | ack, will try | 13:20 |
| elod | lyarwood: looking | 13:22 |
| lyarwood | many thanks both | 13:24 |
| *** LinPeiWen has quit IRC | 13:26 | |
| lyarwood | https://review.opendev.org/c/openstack/nova/+/752489/ and the series below it on stable/train is also ready | 13:26 |
| *** yoctozepto2 has joined #openstack-nova | 13:27 | |
| *** spatel has joined #openstack-nova | 13:28 | |
| *** yoctozepto has quit IRC | 13:28 | |
| *** yoctozepto2 is now known as yoctozepto | 13:28 | |
| *** links has joined #openstack-nova | 13:31 | |
| *** spatel has quit IRC | 13:33 | |
| openstackgerrit | Merged openstack/nova master: zuul: Allow encryption tests in nova-ceph-multistore again https://review.opendev.org/c/openstack/nova/+/771837 | 13:35 |
| *** hemna has quit IRC | 13:36 | |
| *** hemna has joined #openstack-nova | 13:36 | |
| *** gibi has joined #openstack-nova | 13:37 | |
| *** khomesh24 has joined #openstack-nova | 13:45 | |
| openstackgerrit | Merged openstack/nova master: libvirt: Drop support for Xen https://review.opendev.org/c/openstack/nova/+/743231 | 13:47 |
| *** hemanth_n has joined #openstack-nova | 13:53 | |
| *** sapd__x has joined #openstack-nova | 13:55 | |
| *** liuyulong has quit IRC | 13:58 | |
| lyarwood | \o/ | 13:58 |
| *** liuyulong has joined #openstack-nova | 13:59 | |
| *** spatel has joined #openstack-nova | 13:59 | |
| *** spatel has quit IRC | 14:01 | |
| *** spatel has joined #openstack-nova | 14:01 | |
| *** xek_ has quit IRC | 14:02 | |
| *** zoharm has quit IRC | 14:03 | |
| *** spotz has joined #openstack-nova | 14:03 | |
| *** zoharm has joined #openstack-nova | 14:05 | |
| *** xek has joined #openstack-nova | 14:05 | |
| *** liuyulong has quit IRC | 14:07 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981 | 14:08 |
| *** liuyulong has joined #openstack-nova | 14:08 | |
| *** liuyulong has quit IRC | 14:09 | |
| *** nweinber has joined #openstack-nova | 14:10 | |
| *** yoctozepto8 has joined #openstack-nova | 14:14 | |
| *** yoctozepto has quit IRC | 14:15 | |
| *** yoctozepto8 is now known as yoctozepto | 14:15 | |
| *** zoharm1 has joined #openstack-nova | 14:33 | |
| *** tosky has quit IRC | 14:35 | |
| *** tosky has joined #openstack-nova | 14:36 | |
| *** zoharm has quit IRC | 14:36 | |
| *** yoctozepto0 has joined #openstack-nova | 14:41 | |
| *** yoctozepto has quit IRC | 14:41 | |
| *** yoctozepto0 is now known as yoctozepto | 14:41 | |
| *** songwenping_ has joined #openstack-nova | 14:48 | |
| stephenfin | lyarwood: I have an open API policy question on https://review.opendev.org/c/openstack/nova/+/768352/ | 14:49 |
| *** songwenping_ has quit IRC | 14:49 | |
| *** songwenping_ has joined #openstack-nova | 14:49 | |
| *** tosky has quit IRC | 14:50 | |
| *** tosky has joined #openstack-nova | 14:50 | |
| *** songwenping__ has quit IRC | 14:51 | |
| lyarwood | stephenfin: ah my bad, looking | 14:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702 | 14:53 |
| *** irclogbot_0 has quit IRC | 14:55 | |
| openstackgerrit | Merged openstack/nova master: Refactor _claim_pci_device_for_interface_attach to prepare for qos https://review.opendev.org/c/openstack/nova/+/756895 | 14:57 |
| *** belmoreira has joined #openstack-nova | 14:57 | |
| *** irclogbot_0 has joined #openstack-nova | 14:59 | |
| *** sapd__x has quit IRC | 15:07 | |
| dansmith | sean-k-mooney: gdi, I do that *every* dang time :/ | 15:08 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: rpc: Rework 'get_notifier', 'wrap_exception' https://review.opendev.org/c/openstack/nova/+/741663 | 15:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to 'nova.pci' https://review.opendev.org/c/openstack/nova/+/676209 | 15:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657 | 15:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658 | 15:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806 | 15:11 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | 15:11 |
| *** ociuhandu has joined #openstack-nova | 15:11 | |
| *** zoharm has joined #openstack-nova | 15:17 | |
| *** zoharm1 has quit IRC | 15:20 | |
| *** ociuhandu has quit IRC | 15:23 | |
| *** ociuhandu has joined #openstack-nova | 15:24 | |
| *** spatel has quit IRC | 15:24 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1909120 https://review.opendev.org/c/openstack/nova/+/768351 | 15:24 |
| openstack | bug 1909120 in OpenStack Compute (nova) "n-api should reject requests to detach a volume when the compute is down" [Medium,Confirmed] https://launchpad.net/bugs/1909120 - Assigned to Lee Yarwood (lyarwood) | 15:24 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Reject requests to detach a volume when the compute is down https://review.opendev.org/c/openstack/nova/+/768352 | 15:24 |
| *** mlavalle has joined #openstack-nova | 15:26 | |
| *** ociuhandu has quit IRC | 15:29 | |
| *** ociuhandu has joined #openstack-nova | 15:34 | |
| *** zenkuro has quit IRC | 15:34 | |
| *** zenkuro has joined #openstack-nova | 15:35 | |
| *** rcernin has joined #openstack-nova | 15:36 | |
| *** rcernin has quit IRC | 15:41 | |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: Add regression test for bug #1908075 https://review.opendev.org/c/openstack/nova/+/766976 | 15:41 |
| openstack | bug 1908075 in OpenStack Compute (nova) "Nova allows a non-multiattach volume to be attached to multiple instances *if* its volume state is reset by an admin" [Undecided,New] https://launchpad.net/bugs/1908075 - Assigned to Lee Yarwood (lyarwood) | 15:41 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: api: Reject volume attach requests when an active bdm exists https://review.opendev.org/c/openstack/nova/+/768472 | 15:41 |
| *** khomesh24 has quit IRC | 15:45 | |
| *** zenkuro has quit IRC | 15:51 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Rationalize attachment of USB tablet https://review.opendev.org/c/openstack/nova/+/756551 | 15:53 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/c/openstack/nova/+/756552 | 15:53 |
| *** lpetrut has quit IRC | 16:00 | |
| *** xek has quit IRC | 16:01 | |
| *** xek has joined #openstack-nova | 16:03 | |
| *** mkrai_ has quit IRC | 16:06 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Enable 'vmcoreinfo' feature by default https://review.opendev.org/c/openstack/nova/+/752912 | 16:10 |
| gmann | stephenfin: lbragstad sean-k-mooney replied on https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/base.py#20 | 16:11 |
| gmann | Let's go with SYSTEM_ADMIN so that we donot depends on the timing of removing the old rule and enforce_scope=true by default | 16:12 |
| *** macz_ has joined #openstack-nova | 16:13 | |
| *** dklyle has joined #openstack-nova | 16:14 | |
| *** rpittau is now known as rpittau|afk | 16:24 | |
| openstackgerrit | sean mooney proposed openstack/nova master: libvirt: delegate ovs plug to os-vif https://review.opendev.org/c/openstack/nova/+/602432 | 16:24 |
| *** yoctozepto2 has joined #openstack-nova | 16:28 | |
| *** yoctozepto has quit IRC | 16:29 | |
| *** yoctozepto2 is now known as yoctozepto | 16:29 | |
| stephenfin | lyarwood: Two of those three patches from me above ^ previously had +2 from you but conflicted with the just-merged Xen removal patch. Can you (re)look at them real quick? | 16:31 |
| stephenfin | If you could get to https://review.opendev.org/c/openstack/nova/+/756552 too that'd be extra awesome. Spec is approved, fwiw | 16:33 |
| *** CeeMac has quit IRC | 16:37 | |
| *** PrinzElvis has quit IRC | 16:37 | |
| lyarwood | stephenfin: need to run for a while now but I'll try to look later or first thing tomorrow | 16:37 |
| *** vdrok has quit IRC | 16:37 | |
| *** NobodyCam has quit IRC | 16:37 | |
| *** avolkov has quit IRC | 16:37 | |
| *** flaviof has quit IRC | 16:37 | |
| *** cz3 has quit IRC | 16:37 | |
| *** mnaser has quit IRC | 16:37 | |
| stephenfin | ack, thanks | 16:37 |
| *** vishalmanchanda has quit IRC | 16:37 | |
| *** pas-ha has quit IRC | 16:38 | |
| *** johnsom has quit IRC | 16:38 | |
| *** gmann has quit IRC | 16:38 | |
| *** arne_wiebalck has quit IRC | 16:38 | |
| *** whoami-rajat__ has quit IRC | 16:38 | |
| *** donnyd has quit IRC | 16:38 | |
| *** csatari has quit IRC | 16:38 | |
| *** knikolla has quit IRC | 16:38 | |
| *** rpittau|afk has quit IRC | 16:38 | |
| *** TheJulia has quit IRC | 16:38 | |
| *** coreycb has quit IRC | 16:38 | |
| *** fyx has quit IRC | 16:38 | |
| *** guilhermesp has quit IRC | 16:38 | |
| *** mnasiadka has quit IRC | 16:38 | |
| *** nicolasbock has quit IRC | 16:38 | |
| *** andrewbonney has quit IRC | 16:38 | |
| *** nightmare_unreal has quit IRC | 16:38 | |
| *** dviroel has quit IRC | 16:38 | |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/stein: tests: Add regression test for bug 1894966 https://review.opendev.org/c/openstack/nova/+/772720 | 16:38 |
| openstack | bug 1894966 in OpenStack Compute (nova) stein "Create servergroup failed with unexpected error" [Undecided,Confirmed] https://launchpad.net/bugs/1894966 | 16:38 |
| *** CeeMac has joined #openstack-nova | 16:39 | |
| *** johnsom has joined #openstack-nova | 16:39 | |
| *** vdrok has joined #openstack-nova | 16:39 | |
| *** NobodyCam has joined #openstack-nova | 16:39 | |
| *** andrewbonney has joined #openstack-nova | 16:39 | |
| *** avolkov has joined #openstack-nova | 16:40 | |
| *** gouthamr has quit IRC | 16:40 | |
| *** flaviof has joined #openstack-nova | 16:40 | |
| *** jrosser has quit IRC | 16:40 | |
| *** pas-ha has joined #openstack-nova | 16:40 | |
| *** vishalmanchanda has joined #openstack-nova | 16:40 | |
| *** rm_work has quit IRC | 16:40 | |
| *** coreycb has joined #openstack-nova | 16:40 | |
| *** knikolla has joined #openstack-nova | 16:40 | |
| *** TheJulia has joined #openstack-nova | 16:40 | |
| *** rpittau|afk has joined #openstack-nova | 16:40 | |
| *** donnyd has joined #openstack-nova | 16:40 | |
| *** dviroel has joined #openstack-nova | 16:41 | |
| *** hemanth_n has quit IRC | 16:41 | |
| *** whoami-rajat__ has joined #openstack-nova | 16:42 | |
| *** arne_wiebalck has joined #openstack-nova | 16:42 | |
| *** csatari has joined #openstack-nova | 16:42 | |
| *** guilhermesp has joined #openstack-nova | 16:42 | |
| *** nightmare_unreal has joined #openstack-nova | 16:42 | |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/stein: api: Set min, maxItems for server_group.policies field https://review.opendev.org/c/openstack/nova/+/772721 | 16:42 |
| *** gmann has joined #openstack-nova | 16:45 | |
| *** mnaser has joined #openstack-nova | 16:45 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: tox: Enable parallel docs build https://review.opendev.org/c/openstack/nova/+/751034 | 16:46 |
| gmann | lbragstad: did your single tests for all persona approach worked? https://review.opendev.org/c/openstack/placement/+/760238/9/placement/tests/functional/gabbits/inventory-legacy-rbac.yaml#20 | 16:47 |
| gmann | nova did the same to avoid 409 or creating new resource per persona though nova tests are with stub for non-api layer | 16:47 |
| lbragstad | gmann i haven't gotten back around to it - i've been helping cinder setup test plumbing | 16:47 |
| gmann | ohk | 16:48 |
| lbragstad | i can repropose the beginning of that series since it sounds like we have consensus on the check string | 16:49 |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Add support for virtio-based input devices https://review.opendev.org/c/openstack/nova/+/756552 | 16:50 |
| *** fyx has joined #openstack-nova | 16:50 | |
| *** nicolasbock has joined #openstack-nova | 16:50 | |
| *** rm_work has joined #openstack-nova | 16:50 | |
| *** mnasiadka has joined #openstack-nova | 16:50 | |
| *** rm_work has quit IRC | 16:50 | |
| *** gouthamr has joined #openstack-nova | 16:50 | |
| *** gouthamr has quit IRC | 16:50 | |
| gmann | lbragstad: for using common constraint from oslo? | 16:51 |
| *** rm_work has joined #openstack-nova | 16:51 | |
| *** gouthamr has joined #openstack-nova | 16:51 | |
| *** rm_work has quit IRC | 16:51 | |
| *** gouthamr has quit IRC | 16:52 | |
| lbragstad | oh - no, i was just going to rebase them and cleanup the concern in the aggregate patch | 16:52 |
| gmann | lbragstad: ah this https://review.opendev.org/c/openstack/placement/+/760235/10/placement/policies/aggregate.py#52 | 16:52 |
| *** rm_work has joined #openstack-nova | 16:53 | |
| *** rm_work has quit IRC | 16:53 | |
| *** gouthamr has joined #openstack-nova | 16:53 | |
| *** gouthamr has quit IRC | 16:53 | |
| lbragstad | yeah | 16:53 |
| *** rm_work has joined #openstack-nova | 16:55 | |
| *** rm_work has quit IRC | 16:55 | |
| *** jrosser has joined #openstack-nova | 16:55 | |
| gmann | lbragstad: ok, as you are rebasing what you think of https://review.opendev.org/c/openstack/placement/+/760240/21/placement/policies/resource_provider.py#50 | 16:55 |
| *** gouthamr has joined #openstack-nova | 16:55 | |
| *** gouthamr has quit IRC | 16:55 | |
| *** nicolasbock has quit IRC | 16:55 | |
| gmann | this can leave all explicit deprecation in policies. | 16:55 |
| *** rm_work has joined #openstack-nova | 16:55 | |
| *** gouthamr has joined #openstack-nova | 16:55 | |
| *** mnasiadka has quit IRC | 16:55 | |
| *** rm_work has quit IRC | 16:55 | |
| *** gouthamr has quit IRC | 16:56 | |
| *** PrinzElvis has joined #openstack-nova | 16:56 | |
| gmann | and deprecate current admin with system-admin rule in base.py and use system-admin rule as check_str | 16:56 |
| gmann | and in system-admin rule we will use common string from oslo whenever we are ready | 16:56 |
| *** rm_work has joined #openstack-nova | 16:56 | |
| *** gouthamr has joined #openstack-nova | 16:56 | |
| *** gouthamr has quit IRC | 16:56 | |
| *** rm_work has quit IRC | 16:57 | |
| *** gouthamr has joined #openstack-nova | 16:57 | |
| *** rm_work has joined #openstack-nova | 16:57 | |
| *** nicolasbock has joined #openstack-nova | 16:57 | |
| *** gouthamr has quit IRC | 16:57 | |
| gmann | lbragstad: if that is too much asking at this stage then we can leave that i can do that in follow up for all policy together | 16:57 |
| *** mnasiadka has joined #openstack-nova | 16:57 | |
| *** viks____ has joined #openstack-nova | 16:57 | |
| *** rm_work has quit IRC | 16:57 | |
| lbragstad | gmann stephenfin has a patch to do the deprecation https://review.opendev.org/c/openstack/placement/+/772334/4 | 16:57 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | 16:58 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | 16:58 |
| *** gouthamr has joined #openstack-nova | 16:58 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | 16:58 |
| *** gouthamr has quit IRC | 16:58 | |
| gmann | lbragstad: i see, l do that there. | 16:58 |
| stephenfin | lbragstad: gmann: Yeah, I just replied :) | 16:58 |
| *** rm_work has joined #openstack-nova | 16:58 | |
| *** rm_work has quit IRC | 16:58 | |
| *** johanssone has quit IRC | 16:58 | |
| gmann | stephenfin: nice, do you mind if I update that to define all other deprecation also in common place? https://review.opendev.org/c/openstack/placement/+/772334/4 | 16:59 |
| stephenfin | Not at all. Go for it | 17:00 |
| *** cz3 has joined #openstack-nova | 17:00 | |
| gmann | or i can do on top of that to see how it look like | 17:00 |
| gmann | ok | 17:00 |
| *** johanssone has joined #openstack-nova | 17:01 | |
| *** rm_work has joined #openstack-nova | 17:02 | |
| *** rm_work has quit IRC | 17:02 | |
| *** gouthamr has joined #openstack-nova | 17:02 | |
| *** gouthamr has quit IRC | 17:02 | |
| *** tesseract has quit IRC | 17:06 | |
| *** gouthamr has joined #openstack-nova | 17:08 | |
| *** gouthamr has quit IRC | 17:08 | |
| *** rm_work has joined #openstack-nova | 17:09 | |
| *** rm_work has quit IRC | 17:09 | |
| *** rm_work has joined #openstack-nova | 17:13 | |
| *** gouthamr has joined #openstack-nova | 17:13 | |
| *** gouthamr has quit IRC | 17:13 | |
| *** rm_work has quit IRC | 17:13 | |
| *** psachin has quit IRC | 17:14 | |
| *** nicolasbock has quit IRC | 17:18 | |
| *** viks____ has quit IRC | 17:18 | |
| *** mnasiadka has quit IRC | 17:18 | |
| *** cz3 has quit IRC | 17:18 | |
| *** fyx has quit IRC | 17:18 | |
| *** gouthamr has joined #openstack-nova | 17:19 | |
| *** gouthamr has quit IRC | 17:19 | |
| *** nicolasbock has joined #openstack-nova | 17:19 | |
| *** fyx has joined #openstack-nova | 17:19 | |
| *** rm_work has joined #openstack-nova | 17:20 | |
| *** rm_work has quit IRC | 17:20 | |
| *** mnasiadka has joined #openstack-nova | 17:20 | |
| *** stand has joined #openstack-nova | 17:20 | |
| *** cz3 has joined #openstack-nova | 17:21 | |
| *** arne_wiebalck has quit IRC | 17:21 | |
| *** andrewbonney has quit IRC | 17:21 | |
| *** andrewbonney has joined #openstack-nova | 17:24 | |
| openstackgerrit | Merged openstack/nova stable/victoria: Add regression test for bug #1899649 https://review.opendev.org/c/openstack/nova/+/764611 | 17:27 |
| openstack | bug 1899649 in OpenStack Compute (nova) "Volume marked as available after a failure to build" [Undecided,In progress] https://launchpad.net/bugs/1899649 - Assigned to Lee Yarwood (lyarwood) | 17:27 |
| *** arne_wiebalck has joined #openstack-nova | 17:28 | |
| *** gouthamr has joined #openstack-nova | 17:29 | |
| *** gouthamr has quit IRC | 17:30 | |
| *** rm_work has joined #openstack-nova | 17:30 | |
| *** ociuhandu_ has joined #openstack-nova | 17:30 | |
| *** rm_work has quit IRC | 17:30 | |
| kashyap | gibi: stephenfin: When you get a minute, can you please have a gander at this (but it is from chengsheng, a new contributor, fixing a good problem): https://review.opendev.org/c/openstack/nova/+/762330/ | 17:33 |
| gibi | kashyap: ack, added to my queue | 17:33 |
| kashyap | It is related using the correct CPU APIs | 17:33 |
| kashyap | And he's addressed some feedback of mine in the past; and it also checks off one of the items in this old spec: | 17:34 |
| kashyap | https://opendev.org/openstack/nova-specs/commit/70811da221035044e27 (Add "CPU selection with hypervisor consideration" spec) | 17:34 |
| *** rm_work has joined #openstack-nova | 17:34 | |
| *** gouthamr has joined #openstack-nova | 17:34 | |
| *** ociuhandu has quit IRC | 17:34 | |
| *** gouthamr has quit IRC | 17:34 | |
| *** rm_work has quit IRC | 17:34 | |
| *** ociuhandu_ has quit IRC | 17:35 | |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Pass context objects to oslo.policy directly https://review.opendev.org/c/openstack/placement/+/766785 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: policy: Suppress policy deprecation warnings https://review.opendev.org/c/openstack/placement/+/771852 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: policy: Don't persist default rule changes in tests https://review.opendev.org/c/openstack/placement/+/772508 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource providers https://review.opendev.org/c/openstack/placement/+/760240 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for aggregates https://review.opendev.org/c/openstack/placement/+/760235 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocations https://review.opendev.org/c/openstack/placement/+/760236 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for allocation candidates https://review.opendev.org/c/openstack/placement/+/760237 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for inventories https://review.opendev.org/c/openstack/placement/+/760238 | 17:35 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for resource classes https://review.opendev.org/c/openstack/placement/+/760239 | 17:36 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for traits https://review.opendev.org/c/openstack/placement/+/760241 | 17:36 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: Implement secure RBAC for usage https://review.opendev.org/c/openstack/placement/+/760242 | 17:36 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: policy: Remove the deprecated 'placement' rule https://review.opendev.org/c/openstack/placement/+/772333 | 17:36 |
| openstackgerrit | Lance Bragstad proposed openstack/placement master: policy: Deprecate 'admin_api' rule https://review.opendev.org/c/openstack/placement/+/772334 | 17:36 |
| lbragstad | stephenfin gmann sean-k-mooney since i needed to go through and fix things early in the series, i cleaned up a bunch of the one-off patches later in the series | 17:36 |
| lbragstad | i abandoned the ones i had the ability to abandon | 17:36 |
| sean-k-mooney | lbragstad: yep just saw them come in | 17:36 |
| gmann | lbragstad: thanks, | 17:37 |
| lbragstad | and i left comments on others that can be abandoned because i rolled them into subsequent patches | 17:37 |
| sean-k-mooney | i need to look at how the roles compose and this works again because it sound like its working muc differently then i tought | 17:37 |
| sean-k-mooney | to the point where im questinging the feature | 17:37 |
| sean-k-mooney | i hope i am just missundering how the tests are written | 17:38 |
| sean-k-mooney | basically the point im trying to figure out is as a SYSTEM_ADMIN do i only have the admin role or do i also have the member and reader role | 17:39 |
| sean-k-mooney | im hoping its the former | 17:40 |
| sean-k-mooney | and that we have ineritence between the roles | 17:40 |
| *** gouthamr has joined #openstack-nova | 17:40 | |
| *** gouthamr has quit IRC | 17:40 | |
| stephenfin | ack | 17:40 |
| * stephenfin abandons the remainder | 17:40 | |
| sean-k-mooney | if we dont have inheritance betwen the roles then i dont think it make sense to have personas and reference them in the policy rules | 17:41 |
| *** rm_work has joined #openstack-nova | 17:41 | |
| *** rm_work has quit IRC | 17:41 | |
| sean-k-mooney | if im reading https://specs.openstack.org/openstack/keystone-specs/specs/keystone/queens/system-scope.html#system-roles-implied-roles-inherited-roles correctly | 17:44 |
| sean-k-mooney | if i have role:admin i should have role:member and role:reader trasitivly as they are implied roles | 17:45 |
| sean-k-mooney | but i shoudl not have to add them to my user explictly | 17:45 |
| sean-k-mooney | so im very confused by https://review.opendev.org/c/openstack/placement/+/760240/21/placement/tests/functional/gabbits/resource-provider-legacy-rbac.yaml#9 | 17:46 |
| stephenfin | sean-k-mooney: I'm pretty sure it is implied, and because it's implied both the main role and the implied roles are included in the HTTP_X_ROLES header in CSV form | 17:47 |
| stephenfin | so the implied link is encoded in keystone, and oslo.context and oslo.policy don't need to know about it. They can simply check for the role they care about | 17:47 |
| sean-k-mooney | right i think including them in the x roles header explictly is odd | 17:48 |
| lbragstad | if you have the admin role on a project and you look at the token response, you'll see keystone expands those out for you | 17:48 |
| stephenfin | Yeah, that seems perfectly sensible to me | 17:48 |
| lbragstad | the reason why we set them in the headers explicitly is so you don't have a dependency on keystone via keystonemiddleware | 17:48 |
| sean-k-mooney | lbragstad: ok so the gabit test data is not the input date for the user to create | 17:48 |
| sean-k-mooney | its a mix of both the input and the expect output | 17:49 |
| lbragstad | the header input should represent what keystonemiddleware would translate | 17:49 |
| lbragstad | since we're cutting that out of these tests | 17:49 |
| sean-k-mooney | ah ok | 17:49 |
| sean-k-mooney | can we add that as a note | 17:49 |
| stephenfin | sean-k-mooney: You're simulating the request. In a real-world deployment keystonemiddleware would add those headers for you | 17:50 |
| sean-k-mooney | i was not expect use to cut that out | 17:50 |
| stephenfin | yeah | 17:50 |
| sean-k-mooney | since these are functional tests | 17:50 |
| sean-k-mooney | not unit tests | 17:50 |
| sean-k-mooney | so we normally would not mock that | 17:50 |
| * stephenfin looks at the mocking of libvirt in nova and smiles :) | 17:50 | |
| stephenfin | *nova functional tests | 17:50 |
| kashyap | gibi: Also, just to note, chengsheng, the reporter has done real live migration tests w/ the patch. I've discussed with them in December | 17:50 |
| lbragstad | if placement wants to add functional test with keystone - then i'd say just use tempest? | 17:50 |
| lbragstad | functional tests* | 17:50 |
| stephenfin | sean-k-mooney: https://review.opendev.org/c/openstack/placement/+/760240/22/placement/auth.py | 17:50 |
| sean-k-mooney | well im not suggesting keystone i was expecting a test fixture | 17:51 |
| *** gouthamr has joined #openstack-nova | 17:51 | |
| *** gouthamr has quit IRC | 17:51 | |
| sean-k-mooney | that would do the translation instead of use doing it by hand | 17:51 |
| sean-k-mooney | but if you add a note to the test saying that is what happeing then im ok with it | 17:51 |
| sean-k-mooney | these vars are bing used as the request headers in the test | 17:52 |
| gmann | in nova also we prepared the context like that by adding admin, member, reader in admin or so | 17:52 |
| *** rm_work has joined #openstack-nova | 17:52 | |
| sean-k-mooney | so i was expecting them to be differnet | 17:52 |
| *** rm_work has quit IRC | 17:52 | |
| stephenfin | we could rework that test fixture to associate known usernames with specific roles and set the headers that way, but what lbragstad has done is far more obvious IMO | 17:52 |
| gmann | https://github.com/openstack/nova/blob/master/nova/tests/unit/policies/base.py#L57 | 17:52 |
| sean-k-mooney | stephenfin: the bit i was missing was keystone auto expanding all the roles you have and flatening them | 17:53 |
| openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702 | 17:53 |
| sean-k-mooney | i was expecting that to be a list of your direct roles only | 17:53 |
| sean-k-mooney | lbragstad: if i add a role i dont have to that maully keystone midelware will validate that on the project api side right | 17:54 |
| sean-k-mooney | lbragstad: e.g. it will hit keystone to valideate it | 17:54 |
| sean-k-mooney | as part of normal token validation | 17:55 |
| lbragstad | sean-k-mooney ksm cleans out those headers and repopulates them based on the token validation response | 17:55 |
| sean-k-mooney | assuming yes then i think i understand how the tests are workign now | 17:55 |
| *** k_mouza has quit IRC | 17:56 | |
| sean-k-mooney | lbragstad: ok so the imporant thin is in the project we can trust the roles in the context because ksm has checked for us | 17:56 |
| lbragstad | https://opendev.org/openstack/keystonemiddleware/src/branch/master/keystonemiddleware/auth_token/_request.py#L75 | 17:56 |
| sean-k-mooney | thats what i was expecting but just wanted to confirm | 17:56 |
| lbragstad | https://opendev.org/openstack/keystonemiddleware/src/branch/master/keystonemiddleware/auth_token/_request.py#L224-L227 | 17:56 |
| openstackgerrit | Stephen Finucane proposed openstack/placement master: policy: Add note about keystone's expansion of roles https://review.opendev.org/c/openstack/placement/+/772752 | 17:57 |
| sean-k-mooney | lbragstad: thanks perfect | 17:57 |
| lbragstad | yep | 17:57 |
| *** nightmare_unreal has quit IRC | 17:57 | |
| stephenfin | sean-k-mooney: lemme know if that's useful ^ | 17:57 |
| stephenfin | We can refine wording if so | 17:58 |
| *** tosky has quit IRC | 17:58 | |
| sean-k-mooney | stephenfin: yep no that make sense to me | 17:58 |
| * stephenfin read that initially as "that makes no sense" :) | 17:58 | |
| sean-k-mooney | im not sure why gerrit thinks you change the last 3 lins | 17:58 |
| *** tosky has joined #openstack-nova | 17:58 | |
| sean-k-mooney | i should have a , after yep | 17:59 |
| *** xek_ has joined #openstack-nova | 17:59 | |
| stephenfin | Oh no, I really did add spacing :) | 17:59 |
| stephenfin | a'ight, and with that | 17:59 |
| * stephenfin -> 🏋️ o/ | 17:59 | |
| stephenfin | kashyap: I'll take a look at that tomorrow | 17:59 |
| *** derekh has quit IRC | 18:00 | |
| kashyap | stephenfin: Thank you; it is fixing some real gnarly problem | 18:00 |
| *** vishalmanchanda has quit IRC | 18:00 | |
| *** mnasiadka has quit IRC | 18:00 | |
| *** coreycb has quit IRC | 18:00 | |
| *** coreycb has joined #openstack-nova | 18:00 | |
| *** mnasiadka has joined #openstack-nova | 18:00 | |
| *** vishalmanchanda has joined #openstack-nova | 18:01 | |
| *** xek has quit IRC | 18:01 | |
| *** k_mouza has joined #openstack-nova | 18:03 | |
| *** pas-ha has quit IRC | 18:04 | |
| *** dviroel has quit IRC | 18:04 | |
| *** pas-ha has joined #openstack-nova | 18:05 | |
| *** dviroel has joined #openstack-nova | 18:05 | |
| *** andrewbonney has quit IRC | 18:05 | |
| *** mgariepy has quit IRC | 18:06 | |
| *** swp20 has joined #openstack-nova | 18:07 | |
| *** songwenping_ has quit IRC | 18:07 | |
| *** vishalmanchanda has quit IRC | 18:08 | |
| *** k_mouza has quit IRC | 18:08 | |
| *** ralonsoh has quit IRC | 18:13 | |
| *** mnasiadka has quit IRC | 18:13 | |
| *** dviroel has quit IRC | 18:14 | |
| *** pas-ha has quit IRC | 18:14 | |
| *** coreycb has quit IRC | 18:14 | |
| *** cz3 has quit IRC | 18:17 | |
| *** fyx has quit IRC | 18:17 | |
| *** guilhermesp has quit IRC | 18:17 | |
| *** nicolasbock has quit IRC | 18:17 | |
| *** mnaser has quit IRC | 18:17 | |
| *** donnyd has quit IRC | 18:17 | |
| *** mgariepy has joined #openstack-nova | 18:18 | |
| *** mnaser has joined #openstack-nova | 18:18 | |
| *** donnyd has joined #openstack-nova | 18:18 | |
| *** cz3 has joined #openstack-nova | 18:18 | |
| *** nicolasbock has joined #openstack-nova | 18:18 | |
| *** mnasiadka has joined #openstack-nova | 18:18 | |
| *** dviroel has joined #openstack-nova | 18:18 | |
| *** coreycb has joined #openstack-nova | 18:18 | |
| *** fyx has joined #openstack-nova | 18:18 | |
| *** guilhermesp has joined #openstack-nova | 18:18 | |
| *** pas-ha has joined #openstack-nova | 18:19 | |
| *** gouthamr has joined #openstack-nova | 18:20 | |
| *** gyee has joined #openstack-nova | 18:23 | |
| *** dviroel has quit IRC | 18:25 | |
| *** pas-ha has quit IRC | 18:25 | |
| *** mnasiadka has quit IRC | 18:25 | |
| *** donnyd has quit IRC | 18:25 | |
| *** guilhermesp has quit IRC | 18:25 | |
| *** fyx has quit IRC | 18:25 | |
| *** cz3 has quit IRC | 18:25 | |
| *** mnaser has quit IRC | 18:27 | |
| *** coreycb has quit IRC | 18:27 | |
| *** nicolasbock has quit IRC | 18:27 | |
| *** donnyd has joined #openstack-nova | 18:28 | |
| *** pas-ha has joined #openstack-nova | 18:30 | |
| *** k_mouza has joined #openstack-nova | 18:31 | |
| *** guilhermesp has joined #openstack-nova | 18:31 | |
| *** fyx has joined #openstack-nova | 18:31 | |
| *** dviroel_ has joined #openstack-nova | 18:31 | |
| *** cz3 has joined #openstack-nova | 18:32 | |
| *** mnaser has joined #openstack-nova | 18:32 | |
| *** mnasiadka has joined #openstack-nova | 18:33 | |
| *** nicolasbock has joined #openstack-nova | 18:33 | |
| *** coreycb has joined #openstack-nova | 18:33 | |
| openstackgerrit | Merged openstack/nova stable/victoria: compute: Don't detach volumes when RescheduledException raised without retry https://review.opendev.org/c/openstack/nova/+/764612 | 18:35 |
| *** k_mouza has quit IRC | 18:35 | |
| *** k_mouza has joined #openstack-nova | 18:40 | |
| *** dtantsur is now known as dtantsur|afk | 18:44 | |
| *** k_mouza has quit IRC | 18:45 | |
| *** rm_work has joined #openstack-nova | 18:53 | |
| *** rm_work has quit IRC | 18:53 | |
| *** zoharm1 has joined #openstack-nova | 18:53 | |
| *** dviroel_ has quit IRC | 18:54 | |
| *** mnasiadka has quit IRC | 18:54 | |
| *** guilhermesp has quit IRC | 18:54 | |
| *** fyx has quit IRC | 18:55 | |
| *** coreycb has quit IRC | 18:55 | |
| *** nicolasbock has quit IRC | 18:55 | |
| *** mnaser has quit IRC | 18:55 | |
| *** cz3 has quit IRC | 18:55 | |
| *** markmcclain has quit IRC | 18:55 | |
| *** zoharm has quit IRC | 18:56 | |
| *** eharney has quit IRC | 18:56 | |
| *** markmcclain has joined #openstack-nova | 18:57 | |
| *** links has quit IRC | 19:04 | |
| *** hamalq has joined #openstack-nova | 19:08 | |
| *** eharney has joined #openstack-nova | 19:09 | |
| gmann | stephenfin: lbragstad replied on this. as per my finding/run oslo.policy does not change rule's self.check_str even it only change rule's self.check which is internal attribute for oslo policy to play with - https://review.opendev.org/c/openstack/placement/+/772508/1//COMMIT_MSG#13 | 19:15 |
| *** dviroel_ has joined #openstack-nova | 19:15 | |
| gmann | I ran few scenario and did not find oslo policy changing defined rule check_str. | 19:15 |
| openstackgerrit | Merged openstack/nova stable/victoria: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761809 | 19:18 |
| *** gouthamr_ has joined #openstack-nova | 19:18 | |
| *** rm_work has joined #openstack-nova | 19:18 | |
| *** rm_work has quit IRC | 19:18 | |
| *** mnaser has joined #openstack-nova | 19:19 | |
| *** dviroel_ is now known as dviroel | 19:19 | |
| *** cz3 has joined #openstack-nova | 19:19 | |
| *** guilhermesp has joined #openstack-nova | 19:20 | |
| *** mnasiadka has joined #openstack-nova | 19:20 | |
| *** fyx has joined #openstack-nova | 19:20 | |
| *** nicolasbock has joined #openstack-nova | 19:20 | |
| *** coreycb has joined #openstack-nova | 19:21 | |
| *** zoharm1 has quit IRC | 19:32 | |
| openstackgerrit | melanie witt proposed openstack/nova stable/ussuri: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761810 | 19:37 |
| *** coreycb has quit IRC | 19:40 | |
| *** gouthamr_ has quit IRC | 19:40 | |
| *** mnaser has quit IRC | 19:40 | |
| *** fyx has quit IRC | 19:40 | |
| *** guilhermesp has quit IRC | 19:40 | |
| *** mnasiadka has quit IRC | 19:40 | |
| *** nicolasbock has quit IRC | 19:40 | |
| *** cz3 has quit IRC | 19:40 | |
| *** mnasiadka has joined #openstack-nova | 19:42 | |
| *** mnaser has joined #openstack-nova | 19:42 | |
| *** fyx has joined #openstack-nova | 19:42 | |
| *** coreycb has joined #openstack-nova | 19:42 | |
| *** guilhermesp has joined #openstack-nova | 19:42 | |
| *** spatel has joined #openstack-nova | 19:43 | |
| *** nicolasbock has joined #openstack-nova | 19:45 | |
| *** cz3 has joined #openstack-nova | 19:45 | |
| *** yoctozepto9 has joined #openstack-nova | 19:50 | |
| *** yoctozepto has quit IRC | 19:51 | |
| *** yoctozepto9 is now known as yoctozepto | 19:51 | |
| *** rm_work has joined #openstack-nova | 19:54 | |
| *** rm_work has quit IRC | 19:54 | |
| *** rcernin has joined #openstack-nova | 20:01 | |
| *** rm_work has joined #openstack-nova | 20:19 | |
| *** rm_work has quit IRC | 20:19 | |
| *** jdillaman has joined #openstack-nova | 20:19 | |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/train: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761811 | 20:24 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/train: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761811 | 20:31 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/stein: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761812 | 20:34 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/rocky: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761813 | 20:35 |
| openstackgerrit | Vlad Gusev proposed openstack/nova stable/queens: Use subqueryload() instead of joinedload() for (system_)metadata https://review.opendev.org/c/openstack/nova/+/761814 | 20:37 |
| *** rcernin has quit IRC | 20:41 | |
| *** stand has quit IRC | 20:42 | |
| *** dviroel has quit IRC | 20:43 | |
| *** stand has joined #openstack-nova | 20:46 | |
| *** rm_work has joined #openstack-nova | 20:54 | |
| *** rm_work has quit IRC | 20:54 | |
| *** avolkov has quit IRC | 20:59 | |
| *** nweinber has quit IRC | 21:03 | |
| openstackgerrit | Merged openstack/nova stable/stein: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761727 | 21:08 |
| *** rm_work has joined #openstack-nova | 21:19 | |
| *** rm_work has quit IRC | 21:19 | |
| *** xek_ has quit IRC | 21:29 | |
| *** whoami-rajat__ has quit IRC | 21:37 | |
| *** dviroel_ has joined #openstack-nova | 21:42 | |
| *** ircuser-1 has joined #openstack-nova | 21:49 | |
| *** masterpe has quit IRC | 21:50 | |
| *** raildo has quit IRC | 21:51 | |
| *** raildo has joined #openstack-nova | 21:52 | |
| *** rcernin has joined #openstack-nova | 21:52 | |
| *** ganso has quit IRC | 21:53 | |
| *** rm_work has joined #openstack-nova | 21:55 | |
| *** vdrok has quit IRC | 21:55 | |
| *** rm_work has quit IRC | 21:55 | |
| *** rcernin has quit IRC | 21:55 | |
| *** rcernin has joined #openstack-nova | 21:56 | |
| *** k_mouza has joined #openstack-nova | 21:56 | |
| *** vdrok has joined #openstack-nova | 21:57 | |
| *** k_mouza has quit IRC | 22:01 | |
| *** ganso has joined #openstack-nova | 22:01 | |
| *** macz_ has quit IRC | 22:02 | |
| *** ganso has quit IRC | 22:04 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | 22:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | 22:04 |
| openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the SOCKET NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | 22:04 |
| *** rcernin has quit IRC | 22:05 | |
| *** rcernin has joined #openstack-nova | 22:05 | |
| *** ganso has joined #openstack-nova | 22:05 | |
| openstackgerrit | Ghanshyam proposed openstack/nova master: DNM:try l-c with direct deps https://review.opendev.org/c/openstack/nova/+/772780 | 22:15 |
| *** rm_work has joined #openstack-nova | 22:20 | |
| *** rm_work has quit IRC | 22:20 | |
| *** f0o has quit IRC | 22:29 | |
| *** janno has quit IRC | 22:29 | |
| *** zigo has quit IRC | 22:29 | |
| *** sorrison has quit IRC | 22:29 | |
| *** f0o has joined #openstack-nova | 22:30 | |
| *** janno has joined #openstack-nova | 22:30 | |
| *** zigo has joined #openstack-nova | 22:30 | |
| *** sorrison has joined #openstack-nova | 22:30 | |
| *** ircuser-1 has quit IRC | 22:31 | |
| *** spatel has quit IRC | 22:43 | |
| *** macz_ has joined #openstack-nova | 22:45 | |
| openstackgerrit | Ghanshyam proposed openstack/placement master: Move policy deprecation to base rules https://review.opendev.org/c/openstack/placement/+/772784 | 22:48 |
| *** slaweq has quit IRC | 22:51 | |
| *** rm_work has joined #openstack-nova | 22:55 | |
| *** rm_work has quit IRC | 22:55 | |
| *** tkajinam has joined #openstack-nova | 22:59 | |
| *** rm_work has joined #openstack-nova | 23:04 | |
| *** rm_work has quit IRC | 23:04 | |
| *** rm_work has joined #openstack-nova | 23:05 | |
| *** rm_work has quit IRC | 23:05 | |
| *** rm_work has joined #openstack-nova | 23:05 | |
| *** rm_work has quit IRC | 23:05 | |
| *** rm_work has joined #openstack-nova | 23:05 | |
| *** rm_work has quit IRC | 23:05 | |
| *** rm_work has joined #openstack-nova | 23:06 | |
| gmann | brinzhang_: few comments left to fix in https://review.opendev.org/c/openstack/nova/+/764292 | 23:06 |
| *** masterpe has joined #openstack-nova | 23:34 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!