*** tosky has quit IRC | 00:21 | |
brinzhang_ | gmann: ack, thanks | 00:25 |
---|---|---|
brinzhang_ | gmann: https://review.opendev.org/c/openstack/nova/+/766726/13/nova/api/openstack/compute/views/servers.py | 00:25 |
brinzhang_ | I was confusing with this comments, what does your mean? | 00:25 |
gmann | brinzhang_: i commented in this file that we do not need to change get_instance_security_groups method itself https://review.opendev.org/c/openstack/nova/+/766726/11/nova/network/security_group_api.py#279 | 00:27 |
gmann | we get the sg from neutron and neutron does return tenant_id and project_id in sg response but both are same thing | 00:27 |
gmann | they kept both for backward compatibility as they do not have microversion concept. | 00:28 |
*** k_mouza has joined #openstack-nova | 00:29 | |
brinzhang_ | gmann:in "def _convert_to_nova_security_group_format(" we update the security_group[], does it need to be consider? | 00:29 |
gmann | brinzhang_: this one right https://review.opendev.org/c/openstack/nova/+/766726/11/nova/network/security_group_api.py#279 | 00:29 |
gmann | we can just change L275 from 'nova_group['project_id'] = security_group['tenant_id']' -> nova_group['project_id'] = security_group['project_id'] | 00:30 |
gmann | and without microversion condition. that way we do not need to change the signature of any interface | 00:31 |
brinzhang_ | I think I get you idea | 00:31 |
brinzhang_ | s/you/your/ | 00:31 |
gmann | cool | 00:32 |
brinzhang_ | in neutron api, we dont need to be consider the nova microversion, we just need to get the sg keep the same way | 00:33 |
gmann | yeah and fetch project_id from neutron sg instead of tenant_id | 00:33 |
*** k_mouza has quit IRC | 00:33 | |
gmann | because at some point in future neutron also will remove the tenant_id form their API so we can take care of that in advance | 00:34 |
brinzhang_ | yeah | 00:34 |
gmann | brinzhang_: and in first commit, we can remove the 2.89 sample. i commented in previous PS also. sorry about asking for that in initial reiview. this one - https://review.opendev.org/c/openstack/nova/+/764292/14/nova/tests/functional/api_sample_tests/test_servers.py#659 | 00:34 |
brinzhang_ | gmann: np, will update in next patch | 00:36 |
gmann | brinzhang_: thanks | 00:36 |
brinzhang_ | gmann: did you review the os-simple-project-suage patch? the router change, and that hit the test issue? | 00:36 |
*** macz_ has quit IRC | 00:37 | |
gmann | brinzhang_: I did until 766726 but I will check the simple-project-usage tomorrow | 00:38 |
brinzhang_ | that I requested 2.90, but it always goto <=2.89 index or show APis | 00:38 |
gmann | humm strange | 00:38 |
brinzhang_ | gmann: dont worry^, my env has broken yesterday, firstly, I will restore my env | 00:38 |
gmann | I will debug that tomorrow. dinner time for me | 00:39 |
gmann | routes.py looks fine to me in first glance may be API controller causing it | 00:39 |
brinzhang_ | gmann: thanks, have a good dinner ^^ | 00:39 |
*** LinPeiWen has joined #openstack-nova | 00:46 | |
*** lifeless has quit IRC | 00:55 | |
*** mlavalle has quit IRC | 00:57 | |
*** lifeless has joined #openstack-nova | 00:57 | |
*** sapd__x has joined #openstack-nova | 01:12 | |
*** amodi has quit IRC | 01:15 | |
*** priteau has quit IRC | 01:16 | |
*** zenkuro has joined #openstack-nova | 01:19 | |
*** zenkuro has quit IRC | 01:24 | |
*** zenkuro has joined #openstack-nova | 01:24 | |
*** xinranwang has joined #openstack-nova | 01:58 | |
*** gyee has quit IRC | 01:59 | |
*** sapd__x has quit IRC | 02:07 | |
*** hamalq has quit IRC | 02:10 | |
*** songwenping_ has joined #openstack-nova | 02:19 | |
*** nicolasbock_ has joined #openstack-nova | 02:21 | |
*** nicolasbock has quit IRC | 02:21 | |
*** irclogbot_0 has quit IRC | 02:21 | |
*** CeeMac has quit IRC | 02:21 | |
*** nicolasbock_ is now known as nicolasbock | 02:21 | |
*** jdillaman has quit IRC | 02:22 | |
*** swp20 has quit IRC | 02:22 | |
*** jdillaman has joined #openstack-nova | 02:22 | |
*** CeeMac has joined #openstack-nova | 02:22 | |
*** irclogbot_0 has joined #openstack-nova | 02:23 | |
*** rcernin has quit IRC | 02:34 | |
*** rcernin has joined #openstack-nova | 02:36 | |
*** mkrai has joined #openstack-nova | 02:53 | |
*** khomesh24 has joined #openstack-nova | 03:21 | |
*** yonglihe has joined #openstack-nova | 03:32 | |
*** psachin has joined #openstack-nova | 03:37 | |
*** links has joined #openstack-nova | 03:42 | |
*** gouthamr has quit IRC | 04:18 | |
*** vishalmanchanda has joined #openstack-nova | 04:22 | |
*** lifeless has quit IRC | 04:36 | |
*** xinranwang has quit IRC | 04:38 | |
*** lifeless has joined #openstack-nova | 04:38 | |
*** lemko7 has joined #openstack-nova | 04:57 | |
*** lemko has quit IRC | 04:58 | |
*** lemko7 is now known as lemko | 04:58 | |
*** whoami-rajat__ has joined #openstack-nova | 04:59 | |
*** songwenping_ has quit IRC | 05:01 | |
*** songwenping_ has joined #openstack-nova | 05:02 | |
*** lemko2 has joined #openstack-nova | 05:11 | |
*** lemko has quit IRC | 05:12 | |
*** lemko2 is now known as lemko | 05:12 | |
*** ircuser-1 has joined #openstack-nova | 05:13 | |
*** ratailor has joined #openstack-nova | 05:24 | |
*** k_mouza has joined #openstack-nova | 05:57 | |
*** k_mouza has quit IRC | 06:02 | |
*** songwenping_ has quit IRC | 06:13 | |
*** songwenping_ has joined #openstack-nova | 06:13 | |
openstackgerrit | Hemanth N proposed openstack/nova stable/rocky: Update pci stat pools based on PCI device changes https://review.opendev.org/c/openstack/nova/+/761824 | 06:15 |
*** rcernin has quit IRC | 06:18 | |
*** rcernin has joined #openstack-nova | 06:22 | |
*** ircuser-1 has quit IRC | 06:31 | |
*** ircuser-1 has joined #openstack-nova | 06:34 | |
*** hemanth_n has joined #openstack-nova | 06:42 | |
*** ircuser-1 has quit IRC | 06:54 | |
*** mkrai has quit IRC | 07:15 | |
*** khomesh24 has quit IRC | 07:19 | |
*** khomesh24 has joined #openstack-nova | 07:19 | |
*** liuyulong has joined #openstack-nova | 07:23 | |
*** xek_ has joined #openstack-nova | 07:28 | |
*** liuyulong has quit IRC | 07:37 | |
*** nightmare_unreal has joined #openstack-nova | 07:41 | |
*** rcernin has quit IRC | 07:42 | |
*** dklyle has quit IRC | 07:45 | |
*** slaweq has joined #openstack-nova | 07:58 | |
*** macz_ has joined #openstack-nova | 08:00 | |
*** ralonsoh has joined #openstack-nova | 08:01 | |
*** macz_ has quit IRC | 08:04 | |
*** andrewbonney has joined #openstack-nova | 08:14 | |
*** rcernin has joined #openstack-nova | 08:15 | |
*** tesseract has joined #openstack-nova | 08:22 | |
*** rpittau|afk is now known as rpittau | 08:27 | |
*** liuyulong has joined #openstack-nova | 08:35 | |
*** mkrai has joined #openstack-nova | 08:41 | |
*** tosky has joined #openstack-nova | 08:45 | |
*** mgariepy has quit IRC | 08:49 | |
*** macz_ has joined #openstack-nova | 08:52 | |
*** macz_ has quit IRC | 08:57 | |
*** tkajinam has quit IRC | 08:58 | |
*** mgariepy has joined #openstack-nova | 08:58 | |
*** martinkennelly has joined #openstack-nova | 09:27 | |
*** ircuser-1 has joined #openstack-nova | 09:36 | |
*** derekh has joined #openstack-nova | 09:38 | |
*** ociuhandu has joined #openstack-nova | 09:40 | |
*** rcernin has quit IRC | 10:24 | |
*** songwenping__ has joined #openstack-nova | 10:25 | |
*** zenkuro has quit IRC | 10:26 | |
*** osmanlicilegi has quit IRC | 10:27 | |
*** songwenping_ has quit IRC | 10:28 | |
*** osmanlicilegi has joined #openstack-nova | 10:29 | |
*** k_mouza has joined #openstack-nova | 10:48 | |
*** rcernin has joined #openstack-nova | 10:50 | |
*** dtantsur|afk is now known as dtantsur | 10:55 | |
*** martinkennelly has quit IRC | 10:59 | |
lyarwood | stephenfin: looking to undeprecate ['glance']/allowed_direct_url_schemes now that it's used by https://review.opendev.org/q/topic:bp/nova-image-download-via-rbd | 11:00 |
lyarwood | stephenfin: is that just a case of removing the deprecation notes etc? | 11:01 |
*** osmanlicilegi has quit IRC | 11:01 | |
stephenfin | Yeah, remove the deprecation note from the config opt itself and if it's not already done, add a release note | 11:01 |
lyarwood | ack thanks | 11:04 |
*** osmanlicilegi has joined #openstack-nova | 11:05 | |
*** rcernin has quit IRC | 11:08 | |
*** ociuhandu has quit IRC | 11:09 | |
*** ociuhandu has joined #openstack-nova | 11:09 | |
*** ociuhandu has quit IRC | 11:10 | |
*** ociuhandu has joined #openstack-nova | 11:10 | |
*** ociuhandu has quit IRC | 11:11 | |
*** ociuhandu has joined #openstack-nova | 11:12 | |
zigo | Swift fails with Python 3.9 under Debian Unstable with Python 3.9: http://paste.openstack.org/show/802063/ | 11:12 |
zigo | I got the same problem with neutron-rpc-server when trying to tell Nova that my VM port is up: http://paste.openstack.org/show/802071/ | 11:12 |
zigo | This looks like general to OpenStack, and feels like yet-another-problem-with-eventlet... :( | 11:12 |
*** ociuhandu has quit IRC | 11:17 | |
stephenfin | anyone want to speed up our docs build? https://review.opendev.org/c/openstack/nova/+/751034 | 11:20 |
*** ttx has quit IRC | 11:22 | |
*** zenkuro has joined #openstack-nova | 11:23 | |
*** ttx has joined #openstack-nova | 11:23 | |
*** mkrai has quit IRC | 11:24 | |
*** ociuhandu has joined #openstack-nova | 11:25 | |
*** zenkuro has quit IRC | 11:27 | |
*** zenkuro has joined #openstack-nova | 11:28 | |
kashyap | stephenfin: Nice | 11:40 |
kashyap | stephenfin: Thanks for that; several times I wished for speeder doc builds! | 11:41 |
kashyap | Gave my lowly +1, FWIW | 11:44 |
*** bbowen_ has joined #openstack-nova | 11:45 | |
*** bbowen has quit IRC | 11:45 | |
*** k_mouza has quit IRC | 11:48 | |
*** k_mouza_ has joined #openstack-nova | 11:48 | |
*** ratailor has quit IRC | 11:51 | |
*** osmanlicilegi has quit IRC | 11:58 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Use specific user when probing encrypted rbd disks during extend https://review.opendev.org/c/openstack/nova/+/772869 | 11:59 |
*** osmanlicilegi has joined #openstack-nova | 12:01 | |
lyarwood | stephenfin: looking | 12:01 |
lyarwood | stephenfin: also I've lost the tabs with the reviews you asked me about yesterday, what were they again? | 12:01 |
stephenfin | https://review.opendev.org/c/openstack/nova/+/75655, https://review.opendev.org/c/openstack/nova/+/752912 and if possible https://review.opendev.org/c/openstack/nova/+/756552 | 12:02 |
lyarwood | ack | 12:03 |
lyarwood | thanks | 12:03 |
*** dviroel_ is now known as dviroel | 12:16 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Increase SWIFT_LOOPBACK_DISK_SIZE within nova-lvm job https://review.opendev.org/c/openstack/nova/+/772702 | 12:18 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: zuul: Mark nova-lvm as voting https://review.opendev.org/c/openstack/nova/+/772871 | 12:18 |
*** khomesh24 has quit IRC | 12:21 | |
*** khomesh24 has joined #openstack-nova | 12:22 | |
*** hemanth_n has quit IRC | 12:26 | |
*** ociuhandu has quit IRC | 12:31 | |
*** ociuhandu has joined #openstack-nova | 12:31 | |
*** ociuhandu has quit IRC | 12:36 | |
*** priteau has joined #openstack-nova | 12:44 | |
*** khomesh24 has quit IRC | 12:47 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: glance: Remove [glance]/allowed_direct_url_schemes https://review.opendev.org/c/openstack/nova/+/772874 | 12:47 |
*** osmanlicilegi has quit IRC | 12:50 | |
*** osmanlicilegi has joined #openstack-nova | 12:55 | |
*** sapd__x has joined #openstack-nova | 13:01 | |
*** ociuhandu has joined #openstack-nova | 13:04 | |
*** LinPeiWen has quit IRC | 13:26 | |
openstackgerrit | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for Xena https://review.opendev.org/c/openstack/nova-specs/+/772878 | 13:30 |
*** k_mouza has joined #openstack-nova | 13:43 | |
*** xek__ has joined #openstack-nova | 13:43 | |
*** tosky has quit IRC | 13:45 | |
*** tosky_ has joined #openstack-nova | 13:46 | |
*** sapd__x has quit IRC | 13:46 | |
*** k_mouza_ has quit IRC | 13:46 | |
*** sapd__x has joined #openstack-nova | 13:46 | |
*** xek_ has quit IRC | 13:46 | |
*** vishalmanchanda has quit IRC | 13:51 | |
openstackgerrit | Ghanshyam proposed openstack/placement master: Move policy deprecation to base rules https://review.opendev.org/c/openstack/placement/+/772784 | 13:57 |
lyarwood | stephenfin: https://review.opendev.org/c/openstack/nova/+/771981 - would you mind hitting this today if you have some docs review bandwidth | 14:00 |
lyarwood | https://review.opendev.org/c/openstack/nova/+/772874 might also be something you'd be interested in | 14:00 |
lyarwood | gibi: https://review.opendev.org/c/openstack/nova/+/772871/ - could you take a look at this change marking the nova-lvm job as voting (and the fix underneath it)? | 14:02 |
gibi | lyarwood: ack, added to my queue. (that queue getting log in the last couple of days) | 14:02 |
* gibi hunts a possible memory leak in nova-compute in pike downstream :/ | 14:03 | |
lyarwood | gibi: ack np, if there's anything I can trade let me know | 14:03 |
lyarwood | gibi: systemctl restart nova-compute? ;) | 14:03 |
gibi | yepp that what couple of our customers do weekly but they getting impatient | 14:05 |
gibi | fun stuf | 14:05 |
lyarwood | ouch | 14:05 |
gibi | I had the same experience a decade ago with jvm :D the solution was the same, restart it during maintenance window to free up ram | 14:06 |
sean-k-mooney | gibi: given python is garbage collected any memory leask is likely form interaction with libvirt right | 14:08 |
sean-k-mooney | e.g. the proxy objects | 14:08 |
sean-k-mooney | or well interaction with external things via real threads | 14:08 |
gibi | sean-k-mooney: or thing the code actually stores and accumlates for no reason | 14:08 |
sean-k-mooney | i know we can have meemory issue if we return excptions instead of raising them too on python 3 | 14:09 |
sean-k-mooney | *2 | 14:09 |
gibi | like this https://github.com/openstack/oslo.messaging/blob/00d15eaeaba0ded0330cdcec7b19eee3adbfb1e1/oslo_messaging/_drivers/amqpdriver.py#L426 | 14:09 |
sean-k-mooney | gibi: ah well that is less a leak but rather using more memory then it need to due to a poor algorithim | 14:09 |
gibi | yepp | 14:10 |
gibi | actually I can hit that log in pike devstack by poking rabbitmq | 14:10 |
sean-k-mooney | oh in this case it also qould be an rabbitissue | 14:10 |
sean-k-mooney | ya that could grow if the reply are lost right | 14:11 |
gibi | I see two types of increase one that eventually recovers. after a long timeout the disconnect is logged in nova side and the connection is removed | 14:12 |
sean-k-mooney | back to debuging why an osp env that is freshly deployed passes tempest but then after 9+ hours apparenlty stops working | 14:12 |
gibi | but there are connections that does not freed even after an hour | 14:12 |
sean-k-mooney | that sound like an amqp bug | 14:13 |
sean-k-mooney | like the clinet has gone away but for some reason it keeps the file desctprot for the connection open | 14:13 |
sean-k-mooney | and never recognises the disconnect | 14:14 |
gibi | could be | 14:14 |
sean-k-mooney | althoug | 14:14 |
gibi | now I have to proove that this is what happens in the customer env | 14:14 |
gibi | as it is still in my local devstack | 14:14 |
sean-k-mooney | ya not sure how to determin that | 14:14 |
gibi | I bet on the warning log from oslo | 14:15 |
gibi | If the customer sees that then I have a lead | 14:15 |
lyarwood | ~. | 14:27 |
*** ociuhandu has quit IRC | 14:33 | |
*** ociuhandu has joined #openstack-nova | 14:33 | |
*** ociuhandu has quit IRC | 14:38 | |
*** k_mouza has quit IRC | 14:42 | |
*** k_mouza has joined #openstack-nova | 14:43 | |
*** k_mouza has quit IRC | 14:45 | |
*** rcernin has joined #openstack-nova | 14:46 | |
*** k_mouza has joined #openstack-nova | 14:46 | |
*** liuyulong has quit IRC | 14:59 | |
*** haleyb has joined #openstack-nova | 15:00 | |
*** rcernin has quit IRC | 15:00 | |
stephenfin | lyarwood: comments left on one, +2 on the other | 15:02 |
*** ociuhandu has joined #openstack-nova | 15:03 | |
lyarwood | kashyap: libvirt is always starts with a lower case l right? | 15:06 |
lyarwood | kashyap: I'm sure this came up in the past and has confused me for ages | 15:06 |
kashyap | lyarwood: On a call; bbiab | 15:07 |
sean-k-mooney | i have seen both | 15:07 |
kashyap | But yes, lower case | 15:07 |
lyarwood | np | 15:07 |
sean-k-mooney | but its normally lowercase | 15:07 |
lyarwood | yeah this came up before and I was told always lowercase for $reasons | 15:07 |
sean-k-mooney | if its in a commit mesage or specs then i always use libvirt instead of Libvirt | 15:08 |
sean-k-mooney | same for release notes | 15:08 |
*** k_mouza has quit IRC | 15:09 | |
*** k_mouza_ has joined #openstack-nova | 15:09 | |
sean-k-mooney | although funally enough it's uppercase here https://github.com/libvirt/libvirt/blob/30703564c2ac8d95279801a821cf5510fa4b8149/docs/ci.rst#libvirt-continuous-integration but i think thats wrong | 15:11 |
sean-k-mooney | also a few places in the readme too https://github.com/libvirt/libvirt/blob/30703564c2ac8d95279801a821cf5510fa4b8149/README.rst | 15:11 |
sean-k-mooney | but again that feel more like there editor auto capitalising then intentional as the use lowercase when its not the start of a sentence | 15:12 |
*** bauzas has quit IRC | 15:12 | |
*** nweinber has joined #openstack-nova | 15:13 | |
*** gouthamr has joined #openstack-nova | 15:14 | |
openstackgerrit | Ghanshyam proposed openstack/nova master: DNM:try l-c with direct deps https://review.opendev.org/c/openstack/nova/+/772780 | 15:16 |
kashyap | lyarwood: Back; unless it's at the start of a sentence, it's always lowercase. | 15:24 |
kashyap | sean-k-mooney: Both those occurrences are correct -- because the word came at the start of a sentence | 15:25 |
kashyap | So it's only natural to capitalize it :-) | 15:25 |
kashyap | lyarwood: What made you ask? Are you writing some docs / code comments or something? | 15:26 |
sean-k-mooney | kashyap: ya althoguh some porject for trademark reason say you should not capatilise it or use a spefic capatialistion when you do | 15:28 |
sean-k-mooney | kashyap: so the english rule dont alway apply if you are follow the project style/trademark guidelines | 15:28 |
kashyap | sean-k-mooney: Right; but pretty sure I saw what I described "lowercase all the time, except at the start of a sentence" somewhere in libvirt upstream discussions | 15:29 |
kashyap | But I can't find a link for you at the moment | 15:29 |
openstackgerrit | Ghanshyam proposed openstack/nova master: DNM:try l-c with direct deps https://review.opendev.org/c/openstack/nova/+/772780 | 15:31 |
sean-k-mooney | ya makes sense | 15:31 |
sean-k-mooney | i assume lyarwood was looking at documentaiton or simiarl and just wanted to make sure it was correct | 15:32 |
*** dklyle has joined #openstack-nova | 15:33 | |
*** mlavalle has joined #openstack-nova | 15:44 | |
lyarwood | sean-k-mooney / kashyap ; https://review.opendev.org/c/openstack/nova/+/771981 was the context, stephenfin had a few nits and I couldn't remember the reasons for libvirt being lowercase all the time etc. | 15:44 |
lyarwood | thanks kashyap, I'll sort the change out now | 15:44 |
kashyap | lyarwood: No prob | 15:45 |
gibi | nova meeting starts in 10 minutes on #openstack-meeting-3 | 15:50 |
openstackgerrit | Lee Yarwood proposed openstack/nova master: docs: Move the LibvirtDistroSupportMatrix wiki page into our docs https://review.opendev.org/c/openstack/nova/+/771981 | 15:55 |
*** macz_ has joined #openstack-nova | 15:57 | |
*** macz_ has quit IRC | 15:57 | |
*** macz_ has joined #openstack-nova | 15:57 | |
*** psachin has quit IRC | 16:00 | |
*** tesseract has quit IRC | 16:06 | |
*** tosky_ is now known as tosky | 16:06 | |
*** tesseract has joined #openstack-nova | 16:07 | |
openstackgerrit | Merged openstack/nova master: tox: Enable parallel docs build https://review.opendev.org/c/openstack/nova/+/751034 | 16:08 |
*** mgagne has joined #openstack-nova | 16:10 | |
sean-k-mooney | lyarwood: ah ok that was in the wiki for easy editing but we very very rarely update it so moving it too docs makes sense i guess | 16:30 |
lyarwood | yeah it wasn't easy and it's just nice to have it in tree and updated in the same change as the actual bump etc | 16:32 |
artom | Lol, I just realized running functional tests locally that need an un-mergde os-traits patch is... dumb. | 16:33 |
sean-k-mooney | artom: you can do that | 16:35 |
lyarwood | artom: install it into the env | 16:35 |
sean-k-mooney | you just pip install it in the env | 16:35 |
artom | Right, I'm sure there are ways | 16:35 |
sean-k-mooney | basicaly .tox/functional/bin/python3 -m pip install -e ../os-traits | 16:36 |
openstackgerrit | Kashyap Chamarthy proposed openstack/nova master: [WIP] libvirt: Remove compareCPU() check on the destination https://review.opendev.org/c/openstack/nova/+/772917 | 16:36 |
sean-k-mooney | assuming you have os-traits cloneed and checked out beside your nova dir | 16:36 |
*** coreycb has quit IRC | 16:37 | |
*** coreycb has joined #openstack-nova | 16:38 | |
*** dosaboy has quit IRC | 16:41 | |
*** dosaboy has joined #openstack-nova | 16:41 | |
*** efried has quit IRC | 16:52 | |
*** gyee has joined #openstack-nova | 17:02 | |
*** ircuser-1 has quit IRC | 17:07 | |
*** nweinber_ has joined #openstack-nova | 17:07 | |
*** tosky has quit IRC | 17:07 | |
*** macz_ has quit IRC | 17:07 | |
*** nweinber has quit IRC | 17:07 | |
*** tosky has joined #openstack-nova | 17:07 | |
*** mgariepy has quit IRC | 17:07 | |
*** ircuser-1 has joined #openstack-nova | 17:08 | |
*** mgariepy has joined #openstack-nova | 17:08 | |
*** efried has joined #openstack-nova | 17:17 | |
*** tesseract has quit IRC | 17:17 | |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add nova.cmd, nova.conf, nova.console https://review.opendev.org/c/openstack/nova/+/705657 | 17:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: mypy: Add type annotations to top-level modules https://review.opendev.org/c/openstack/nova/+/705658 | 17:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Clean manager.Manager, service.Service signatures https://review.opendev.org/c/openstack/nova/+/764806 | 17:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: WIP: Expand type hints for nova.block_device https://review.opendev.org/c/openstack/nova/+/742170 | 17:27 |
openstackgerrit | Stephen Finucane proposed openstack/nova master: libvirt: Remove dead code https://review.opendev.org/c/openstack/nova/+/772928 | 17:28 |
*** zenkuro has quit IRC | 17:31 | |
*** zenkuro has joined #openstack-nova | 17:32 | |
*** links has quit IRC | 17:34 | |
*** ociuhandu_ has joined #openstack-nova | 17:40 | |
*** ociuhandu has quit IRC | 17:43 | |
*** ociuhandu_ has quit IRC | 17:45 | |
*** bauzas has joined #openstack-nova | 17:47 | |
*** zenkuro has quit IRC | 17:50 | |
*** rpittau is now known as rpittau|afk | 17:57 | |
*** nightmare_unreal has quit IRC | 17:58 | |
*** derekh has quit IRC | 18:00 | |
*** dtantsur is now known as dtantsur|afk | 18:25 | |
*** andrewbonney has quit IRC | 18:26 | |
openstackgerrit | Lee Yarwood proposed openstack/nova master: Disallow CONF.compute.max_disk_devices_to_attach = 0 https://review.opendev.org/c/openstack/nova/+/755360 | 18:34 |
artom | Didn't melwitt already do that? | 18:35 |
lyarwood | artom: that was just a rebase | 18:36 |
artom | Ag | 18:36 |
artom | Ah | 18:36 |
artom | *facepalm* | 18:38 |
artom | When 0 is an "allowed" value, but None is not, don't just if <value> :( | 18:39 |
artom | That's a couple of hours wasted | 18:39 |
sean-k-mooney | its the same as the rpc workers issue we fixed a whiel back | 18:54 |
sean-k-mooney | jsut missign the min=1 | 18:54 |
sean-k-mooney | ah we have -1 for unlimited | 18:54 |
sean-k-mooney | so so we cant do that | 18:55 |
sean-k-mooney | really we should have used 0 for that | 18:55 |
sean-k-mooney | in this case since 0 is not valid | 18:55 |
*** k_mouza_ has quit IRC | 19:08 | |
*** amodi has joined #openstack-nova | 19:13 | |
*** k_mouza has joined #openstack-nova | 19:48 | |
*** jamesden_ is now known as jamesdenton | 19:53 | |
*** k_mouza has quit IRC | 19:54 | |
*** itsjg has joined #openstack-nova | 19:58 | |
*** whoami-rajat__ has quit IRC | 19:58 | |
*** rcernin has joined #openstack-nova | 20:03 | |
ganso | Hi Nova folks! I just logged this bug https://bugs.launchpad.net/nova/+bug/1913641 and while thinking about the possible ways to solve it, I started wondering whether it was intentional (and therefore not a bug) to consider shelved_offloaded instances as running, metric-wise. | 20:12 |
openstack | Launchpad bug 1913641 in OpenStack Compute (nova) "Incorrect Shelved_offloaded instance metrics on openstack usage show output" [Undecided,New] | 20:12 |
*** rcernin has quit IRC | 20:30 | |
*** rcernin has joined #openstack-nova | 20:41 | |
*** ircuser-1 has quit IRC | 20:44 | |
*** ralonsoh has quit IRC | 20:48 | |
*** zzzeek has quit IRC | 20:57 | |
*** zzzeek has joined #openstack-nova | 20:57 | |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: libvirt: start tracking NUMACell.socket for hosts https://review.opendev.org/c/openstack/nova/+/766816 | 21:03 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: extra specs/image pros: add `socket PCI NUMA affinity https://review.opendev.org/c/openstack/nova/+/772748 | 21:03 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: Add `socket` PCI NUMA affinity policy request prefilter https://review.opendev.org/c/openstack/nova/+/772749 | 21:03 |
openstackgerrit | Artom Lifshitz proposed openstack/nova master: WIP: pci: implement the SOCKET NUMA affinity policy https://review.opendev.org/c/openstack/nova/+/772779 | 21:03 |
artom | ganso, I *think* `openstack show usage` is about quotas, and shelved offloaded still count against the quota | 21:04 |
artom | But you're correct in assuming their resources (disk, VM) should not be counted... | 21:04 |
*** belmoreira has quit IRC | 21:06 | |
*** belmoreira has joined #openstack-nova | 21:07 | |
ganso | artom: Thanks for the response. hmm given that the metrics shown are cpu-hours, ram-hours and disk-hours, it is a constantly updating, and therefore increasing the value to be billed, if this info is used for billing, whereas quotas remain constant if the number of instances do not change. And indeed, since "count_usage_from_placement" was introduced, shelved_offloaded instances do not even have allocations anymore (nor quotas), but they are listed | 21:10 |
ganso | in usage show because they show up in "InstanceList". So, considering all that, sounds like a valid bug. | 21:10 |
*** belmoreira has quit IRC | 21:14 | |
*** belmoreira has joined #openstack-nova | 21:17 | |
*** belmoreira has quit IRC | 21:22 | |
*** rcernin has quit IRC | 21:34 | |
*** itsjg has left #openstack-nova | 21:40 | |
*** xek__ has quit IRC | 21:44 | |
*** nweinber_ has quit IRC | 21:47 | |
*** rcernin has joined #openstack-nova | 21:51 | |
openstackgerrit | Merged openstack/nova master: Allow extending an existing instance allocation https://review.opendev.org/c/openstack/nova/+/757109 | 21:52 |
openstackgerrit | Merged openstack/nova master: Make remove allocation symmetric with add allocation https://review.opendev.org/c/openstack/nova/+/757110 | 22:06 |
openstackgerrit | Merged openstack/nova master: Factor out port resource deallocation https://review.opendev.org/c/openstack/nova/+/757111 | 22:19 |
openstackgerrit | Merged openstack/nova master: Refactor update_pci_request_spec_with_allocated_interface_name https://review.opendev.org/c/openstack/nova/+/757614 | 22:20 |
*** k_mouza has joined #openstack-nova | 23:09 | |
*** slaweq has quit IRC | 23:11 | |
*** k_mouza has quit IRC | 23:14 | |
*** mlavalle has quit IRC | 23:17 | |
*** knikolla has quit IRC | 23:36 | |
*** pas-ha has quit IRC | 23:36 | |
*** knikolla has joined #openstack-nova | 23:37 | |
*** pas-ha_ has joined #openstack-nova | 23:37 | |
*** dviroel_ has joined #openstack-nova | 23:37 | |
*** csatari has quit IRC | 23:37 | |
*** PrinzElvis has quit IRC | 23:37 | |
*** PrinzElvis_ has joined #openstack-nova | 23:37 | |
*** PrinzElvis_ is now known as PrinzElvis | 23:37 | |
*** csatari has joined #openstack-nova | 23:37 | |
*** dviroel has quit IRC | 23:37 | |
*** dviroel_ is now known as dviroel | 23:37 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!