Friday, 2021-03-19

*** k-s-dean has quit IRC00:01
*** mlavalle has quit IRC00:03
*** k_mouza has joined #openstack-nova00:05
*** vishalmanchanda has quit IRC00:09
*** k_mouza has quit IRC00:09
*** tosky has quit IRC00:14
brinzhang_bauzas: can you re recheck the bug 1917592's fix?
openstackbug 1917592 in OpenStack Compute (nova) "Missed 'accel_uuids' when we the 'shelved_offload_time' time out in shelving instance periodic task" [Medium,In progress] - Assigned to Brin Zhang (zhangbailin)00:19
*** openstackgerrit has joined #openstack-nova00:25
openstackgerritBrin Zhang proposed openstack/nova master: Refactor check and exception
*** songwenping__ has joined #openstack-nova00:26
*** songwenping_ has quit IRC00:29
*** penick has joined #openstack-nova00:34
*** sapd1 has quit IRC00:37
*** penick has quit IRC00:59
*** penick has joined #openstack-nova01:00
*** k-s-dean has joined #openstack-nova01:03
*** penick has quit IRC01:05
*** zzzeek has quit IRC01:16
*** zzzeek has joined #openstack-nova01:17
*** jamesdenton has quit IRC01:34
*** jamesden_ has joined #openstack-nova01:35
*** hamalq has quit IRC01:39
*** k-s-dean has quit IRC01:43
*** lbragstad has quit IRC02:06
*** zzzeek has quit IRC02:52
*** songwenping_ has joined #openstack-nova02:53
*** zzzeek has joined #openstack-nova02:55
*** hemanth_n has joined #openstack-nova02:57
*** songwenping__ has quit IRC02:57
*** rcernin has quit IRC03:16
*** songwenping__ has joined #openstack-nova03:23
*** songwenping_ has quit IRC03:26
openstackgerritMerged openstack/nova stable/train: compute: Lock by instance.uuid lock during swap_volume
*** psachin has joined #openstack-nova03:32
*** rcernin has joined #openstack-nova03:37
*** hemanth_n has quit IRC03:37
*** hemanth_n has joined #openstack-nova03:38
*** rcernin has quit IRC03:39
*** rcernin has joined #openstack-nova03:39
*** vishalmanchanda has joined #openstack-nova04:16
openstackgerritRico Lin proposed openstack/nova master: [TEST][ARM64]Revert "libvirt: Add parsing of firmware metadata files"
*** jamesden_ has quit IRC04:24
*** jamesdenton has joined #openstack-nova04:24
*** penick has joined #openstack-nova04:35
*** gyee has quit IRC04:44
*** macz_ has joined #openstack-nova04:45
*** mkrai has joined #openstack-nova04:46
*** ratailor has joined #openstack-nova04:47
*** macz_ has quit IRC04:50
*** jamesdenton has quit IRC05:09
*** jamesdenton has joined #openstack-nova05:10
*** penick has quit IRC05:24
*** penick has joined #openstack-nova05:27
*** penick has quit IRC05:38
*** xinranwang has joined #openstack-nova05:41
openstackgerritJosephine Seifert proposed openstack/nova stable/victoria: Add config parameter 'live_migration_scheme' to live migration with tls guide
*** Luzi has joined #openstack-nova06:04
*** khomesh24 has joined #openstack-nova06:23
*** khomesh24 has quit IRC06:29
*** elod is now known as elod_afk06:31
*** khomesh24 has joined #openstack-nova06:32
*** lpetrut has joined #openstack-nova06:42
*** links has joined #openstack-nova06:45
*** LinPeiWen has quit IRC07:08
*** LinPeiWen80 has joined #openstack-nova07:10
*** macz_ has joined #openstack-nova07:11
*** mkrai has quit IRC07:15
*** mkrai_ has joined #openstack-nova07:15
*** macz_ has quit IRC07:16
*** dklyle has quit IRC07:35
*** rcernin has quit IRC07:43
*** xinranwang has quit IRC07:51
*** brinzhang0 has joined #openstack-nova07:59
*** brinzhang_ has quit IRC08:01
*** k-s-dean has joined #openstack-nova08:03
*** mkrai_ has quit IRC08:07
*** macz_ has joined #openstack-nova08:11
*** macz_ has quit IRC08:16
*** zzzeek has quit IRC08:19
*** zzzeek has joined #openstack-nova08:21
*** mkrai has joined #openstack-nova08:22
*** rpittau|afk is now known as rpittau08:24
*** rcernin has joined #openstack-nova08:28
*** tesseract has joined #openstack-nova08:31
*** rcernin has quit IRC08:35
*** whoami-rajat_ has joined #openstack-nova08:36
*** whoami-rajat_ is now known as whoami-rajat08:44
lyarwoodgibi: so I managed to get out of dad taxi duty this morning when you're able to talk about the detach series08:45
gibilyarwood: I've just replied to some of your comments in the series08:47
gibilyarwood: so we can talk08:47
gibiI see you point about not raise when device is not in the live domain but try the detach from the persistent domain08:48
*** elod_afk is now known as elod08:48
*** andrewbonney has joined #openstack-nova08:51
lyarwoodgibi: yeah it's just handles corner cases where things are in a weird state when a caller retries the detach08:52
lyarwoodgibi: not attached to the live but still in the persistent somehow08:52
*** tosky has joined #openstack-nova08:54
*** zzzeek has quit IRC08:55
gibilyarwood: give me 20 mins and I can make a proper conversation...08:56
*** zzzeek has joined #openstack-nova08:57
lyarwoodgibi: yeah np I'll reply in the review08:57
*** tesseract has quit IRC09:00
*** tesseract has joined #openstack-nova09:02
*** lucasagomes has joined #openstack-nova09:05
bauzasbrinzhang0: sure, will review
bauzasas it's an important bugfix for Wallaby09:06
brinzhang0bauzas: thanks09:06
bauzasbrinzhang0: actually, can you please rebase it above ?09:06
brinzhang0It seems not impact for your patch, right?09:08
bauzasbrinzhang0: nevermind, I'll +W your patch and then I'll rebase my one09:09
*** rcernin has joined #openstack-nova09:10
brinzhang0bauzas: thanks, there are not order ^09:10
bauzasbrinzhang0: unfortunately, yes09:10
*** rcernin has quit IRC09:10
bauzassee the merge conflicts09:10
bauzasbut I'll rebase my patch09:10
*** rcernin has joined #openstack-nova09:10
brinzhang0bauzas: thanks, may conflict the test case in compute_mgr09:11
*** macz_ has joined #openstack-nova09:14
*** macz_ has quit IRC09:19
*** rcernin has quit IRC09:20
lucasagomeshi, could somebody take a look at, and ?09:22
lucasagomesthey r small patches towards enabling OVN to be the default backend in DevStack at the beggining of the next release cycle09:22
gibilyarwood: thanks for the reply. Is there anything else that I need to think about in the detach series?09:22
lucasagomesit makes sure the nova gate won't break once we flip it09:23
*** ociuhandu has joined #openstack-nova09:26
*** derekh has joined #openstack-nova09:26
nautikgibi: Hi! Following our chat the other day, I pushed the blueprint along with the merge request
*** rcernin has joined #openstack-nova09:29
nautikgibi: reviews and comments are welcome, first time doing this and not yet so-much familiar with nova code; don't hesitate to tell me if you see missing tests for example09:29
gibinautik: thanks09:31
*** macz_ has joined #openstack-nova09:35
gibigmann, stephenfin, bauzas: can we extend accepted charachter set of keypair names without microversion?09:38
gibisee the bp above09:38
gibithe API ref and the json validation code in nova does not restrict a charset for the name but we have some custom code that rejectes @ for example09:39
*** macz_ has quit IRC09:39
gibithe custom check is You specified more local devices than the limit allows09:40
gibithe custom check is
gibistrictly speaking there everyting that worked before will work after we extend the charset so we are not breaking existing clients09:43
bauzasgibi: looking09:43
gibiexcept for those clients that relied on getting http 400 with keypair names containing @ for example09:44
bauzasgibi: well, in between clouds, this would change, right?09:44
bauzasas a user, how could I know I could use specific chars ?09:44
gibibauzas: yes, so for discoverability it would need a new microversion09:44
bauzasfor interop, yes09:45
bauzasbecause when I'm creating my keypair, I want to make sure this works09:45
bauzasi could have scripts for creating such keypairs09:45
gibitoday you have scripts to create keypairs without @ as @ is not allowed09:46
bauzasalso, does the DB accept this, btw ?09:46
gibithis script will work in the future too09:46
gibibauzas: good question about the db09:46
gibiname = Column(String(255), nullable=False)09:46
gibidb will accept it09:46
bauzasso it's purely an API restriction ?09:47
gibithe thing that will not work is a script that relies on this proposed change using @ in the names, towards a cloud that does not have this change09:47
bauzaswhat this blueprint is trying to fix ?09:47
*** ociuhandu has quit IRC09:47
bauzasah I see09:47
bauzasthe arobase case09:47
bauzasand the dot one09:47
gibiit is common to have an email address or a domain name in the keypair name09:48
bauzasI see people wanting to use email adresses as keypair names :p09:48
*** mkrai has quit IRC09:48
bauzasthat, after the instance name...09:48
Corwinbauzas: usually a public key will have a comment in the form of user@hostname09:48
Corwinand hostname can be a fqdn, with dots in it09:49
bauzasCorwin: you're working on clouds09:49
bauzasso users don't know the hosts09:49
bauzasthis is irrelevant from this perspective09:49
bauzashence the string09:49
bauzasand my ssh keynames don't have an arobase :)09:50
Corwinwhat I'm saying is that a lot of users will generate keypairs and name those after the comment in the public key09:50
Corwinor at least would want to09:50
gibilike when I upload my key to gerrit it also names after the comment09:51
Corwingithub does this too09:51
bauzasfor knowing where you created the key ?09:51
bauzasand from which user ?09:51
*** ociuhandu has joined #openstack-nova09:51
Corwinyes, it's the default behavior of a lot of services to pre-fill the name from the comment09:52
bauzasthis comment comes from the fact ssh-keygen stupidely writes who created the key and where09:52
bauzasbut that's stale information09:52
bauzasas you can create the key elsewhere and just use it for other things09:53
CorwinI know, but it doesn't really matter09:53
bauzasCorwin: you recognize that identifying a public key doesn't rely on matching the comment ?09:53
Corwinthere is no reason to disable those characters though09:53
bauzasbut rather on matching the key itself09:53
Corwinbauzas: I know how ssh works thanks09:54
bauzasas I could have N keys created with the same comment09:54
gibibauzas: the machine protocol use the key itself but humans are bad at matching long strings by eye09:54
bauzasCorwin: sure, I'm just pointing that you could end up having multiple keys in Nova that would share the same name09:54
bauzaswhich doesn't help09:54
Corwinthat would happen also without authorizing those 2 characters, it's still user input09:55
bauzaseither way, we're digressing, I agree09:55
bauzasthe question is not about the use case09:55
bauzasbut whether this sounds interoperable09:55
bauzasand my guts tell me it's not so we need a microversion09:56
Corwinyep I think it would be better with a new microversion09:56
gibiOK I can accept the reasoning that the end user should know if the cloud support @ in the name and the way to publis that informatin is via the /version endpoint telling the max supported microversion09:57
Corwina script should always work on one microversion regardless of the service provider09:57
bauzasgibi: I guess we unique index the keynames ?09:58
bauzas(I'm lazy and you already opened the code :p )09:58
gibi    __table_args__ = (09:58
gibi        schema.UniqueConstraint("user_id", "name", "deleted",09:58
gibi                                name="uniq_key_pairs0user_id0name0deleted"),09:58
gibi    )09:58
bauzasthat will be fun09:58
gibiso yes09:58
gibiper user09:58
bauzas"I don't understand why Nova isn't accepting my keyname, boo"09:59
gibibauzas: it is already like that09:59
bauzasI know09:59
gibiwe dont change the uniqueness constraint09:59
bauzasbut users had to name it explicitely09:59
Corwinthat doesn't change09:59
bauzashere, we will open a way to automatically use the comment for creating the keypair09:59
bauzas but, heh09:59
gibiwe allow more flexibility yes, but not ultimate flexibility10:00
Corwinthat's a issue for the service provider, not nova10:00
bauzasprovided we don't have some folks asking to automatically create the keypair by looking up the public key :)10:01
gibithat would be a separate bp :)10:01
bauzasoh sure and my -1 to it10:01
*** rcernin has quit IRC10:01
*** ricolin has quit IRC10:01
bauzaseither way, looks like we're in violent agreement10:02
gibinautik: so based on the above discussion your change will need a new API microversion10:02
gibinautik: let me link to some documentation about it10:02
gibinautik: and that also means you need to file a small specification document in the nova-specs repo10:02
nautikgibi: ok sure10:03
gibibauzas: Corwin: thanks!10:03
*** rcernin has joined #openstack-nova10:04
gibinautik:     __table_args__ = (10:04
gibi        schema.UniqueConstraint("user_id", "name", "deleted",10:04
gibi                                name="uniq_key_pairs0user_id0name0deleted"),10:04
gibi    )10:04
* gibi hates copy paste buffers10:04
bauzasgibi: this could have been getting way worst :p10:04
gibibauzas: yeah I know10:05
*** lewo has joined #openstack-nova10:05
gibithis is the spec template10:06
gibibauzas: could you hit this patch creating the xena spec directory and template?
gibinautik: after ^^ merges, there will be a directory for the xena specs10:07
gibinautik: this helps about how to add a new microversion to nova
bauzasgibi: /me clicks10:09
nautikgibi: thank you, will check this asap :)10:09
gibinautik: if you get stuck with the spec template or hte implementation just ask here and we will help10:10
gibionce the spec is up on review you can ping me and bauzas to take a look10:10
nautikwill do10:11
openstackgerritMerged openstack/nova-specs master: Create specs directory for Xena
*** rcernin has quit IRC10:24
lyarwoodgibi: sorry ssh dropped without me noticing, I don't think there was anything else, tbh my reason for chatting with you was to ensure you were still okay pushing it through ahead of rc10:30
*** k_mouza has joined #openstack-nova10:30
*** Underknowledge has quit IRC10:31
*** Underknowledge1 has joined #openstack-nova10:31
gibilyarwood: if I get the time to fix up the thing then yes10:31
gibilyarwood: it is a bit risk change though10:31
gibilyarwood: so I could also accept if we wait until after the release10:31
*** Underknowledge1 is now known as Underknowledge10:32
lyarwoodgibi: yeah it's really your call as author and PTL, we could backport it in the future once proven to work in X I guess?10:39
gibilyarwood: how risky this change looks from your perspective?10:40
lyarwoodgibi: on the face of it, not very risky but then we are so close to rc that I'm not sure it's worth any risk at the moment10:41
lyarwoodgibi: given the alternative to wait until Xena opens up and we then have ~6 months to verify things10:42
gibiI think the backport from early Xena to W will be easy, backporting further could be harder10:43
lyarwoodit's tough, I really want this rework but at the same time I don't want us to bork things just before the release10:43
*** ociuhandu has quit IRC10:44
lyarwoodwith my downstream hat on an upstream backport just to Wallaby would be awesome10:44
lyarwoodadditional backports would also be nice but that's something I can take on10:44
lyarwoodif it's even possible obviously10:44
gibiOK, lets see if I can have time for finishing up the series today10:45
lyarwoodgibi: sorry I thought we had talked ourselves into delaying until X10:46
lyarwoodgibi: but I guess if you have time now we can get it ready ahead of that, but don't burn yourself with it if you have other more pressing work.10:47
*** jraju__ has joined #openstack-nova10:47
*** links has quit IRC10:47
*** rcernin has joined #openstack-nova10:48
gibilyarwood: I lean towards delaying but if I have time I will make progress10:48
*** ociuhandu has joined #openstack-nova10:50
*** dtantsur|afk is now known as dtantsur10:52
*** k_mouza has quit IRC11:12
*** ociuhandu has quit IRC11:25
*** k_mouza has joined #openstack-nova11:27
*** tesseract has quit IRC11:29
*** tesseract has joined #openstack-nova11:31
*** priteau has joined #openstack-nova11:38
*** rcernin has quit IRC11:39
*** rcernin has joined #openstack-nova11:41
*** k-s-dean has quit IRC11:42
*** kd has joined #openstack-nova11:42
openstackgerritLee Yarwood proposed openstack/nova master: compute: Reject requests to commit intermediary snapshot of an inactive instance
*** rcernin has quit IRC11:46
*** hemanth_n has quit IRC11:59
*** rcernin has joined #openstack-nova12:04
*** rcernin has quit IRC12:09
*** lbragstad has joined #openstack-nova12:22
*** tbachman has quit IRC12:22
*** tbachman has joined #openstack-nova12:23
*** rcernin has joined #openstack-nova12:41
*** macz_ has joined #openstack-nova12:43
*** rcernin has quit IRC12:46
*** macz_ has quit IRC12:48
*** jraju__ has quit IRC12:55
*** links has joined #openstack-nova13:03
*** links has quit IRC13:09
*** tbachman_ has joined #openstack-nova13:13
*** rcernin has joined #openstack-nova13:14
*** tbachman has quit IRC13:15
*** tbachman_ is now known as tbachman13:15
*** martinkennelly has joined #openstack-nova13:21
*** macz_ has joined #openstack-nova13:25
*** lucasagomes_ has joined #openstack-nova13:25
*** lbragstad_ has joined #openstack-nova13:25
*** k-s-dean has joined #openstack-nova13:26
*** janno_ has joined #openstack-nova13:28
*** macz_ has quit IRC13:29
*** brinzhang0 has quit IRC13:30
*** brinzhang0 has joined #openstack-nova13:31
*** ratailor has quit IRC13:31
*** lbragstad has quit IRC13:33
*** kd has quit IRC13:33
*** derekh has quit IRC13:33
*** lucasagomes has quit IRC13:33
*** zzzeek has quit IRC13:33
*** irclogbot_0 has quit IRC13:33
*** openstackgerrit has quit IRC13:33
*** janno has quit IRC13:34
*** irclogbot_0 has joined #openstack-nova13:36
*** jamesdenton has quit IRC13:36
*** purplerbot has quit IRC13:36
*** jamesdenton has joined #openstack-nova13:39
*** purplerbot has joined #openstack-nova13:44
gmanngibi: bauzas stephenfin yes, this is changing 400->200 which break interopability and cross cloud migration., hence need microversion bump.13:55
*** mlavalle has joined #openstack-nova13:58
*** jmlowe has quit IRC14:00
*** jmlowe has joined #openstack-nova14:03
*** lucasagomes_ is now known as lucasagomes14:04
*** ociuhandu has joined #openstack-nova14:10
kashyapGerrit bot is down?14:11
*** jobewan has quit IRC14:12
kashyapstephenfin: For later, since you asked so nicely on the original review:
*** ociuhandu has quit IRC14:13
gibigmann: ack14:14
*** ociuhandu has joined #openstack-nova14:14
stephenfinOh, this is fun
stephenfinSo we broke the Aarch64 CI, but I have no idea how14:23
*** ociuhandu has quit IRC14:23
stephenfinHopefully ricolin will get back to us on that14:23
stephenfinI suspect the metadata files are missing for some reason14:24
stephenfinkashyap: FYI ^14:24
* kashyap clicks14:24
kashyapstephenfin: Yeah, I don't have an AArch64 box; but 'hrw' (not here on IRC right now) did talk about AArch64 failures14:25
kashyapSo I hope indeed ricolin gets back w/ more precise details of the nature of the failure14:25
*** viks____ has joined #openstack-nova14:26
kashyapstephenfin: BTW, aside: upstream libvirt began implementing your RFE.  I was reviewing bits of this series:
kashyap(About firmware auto-selection)14:28
stephenfinaha, very good14:28
stephenfinif you're following that, some WIP patches for nova that implement the libvirt feature would be helpful to make sure we don't forget14:29
*** ociuhandu has joined #openstack-nova14:29
kashyapstephenfin: Yeah, but it still needs some more review.  And I noticed a potential confusion in my review earlier today:
jkulikAny idea why `osc-placement` doesn't include versions after 1.28?14:29
kashyapstephenfin: But I agree14:30
stephenfinjkulik: Is there a version after 1.2814:30
stephenfinGenuine question :)14:30
stephenfinIf there is, I suspect we simply haven't added it14:30
jkulik1.28 was added for ussuri. 1.29 is supported in rocky ... O.o14:31
jkulikI cannot run "os --os-placement-api-version 1.30 allocation candidate list" because it only knows how to do versions 1.28 and below ...14:32
jkulikplacement version 1.30 is not in supported versions: 1.0, 1.1, 1.2, 1.3, 1.4, 1.5, 1.6, 1.7, 1.8, 1.9, 1.10, 1.11, 1.12, 1.13, 1.14, 1.15, 1.16, 1.17, 1.18, 1.19, 1.20, 1.21, 1.22, 1.28, 1.2914:32
stephenfinIn that case, I assume it's just a case that people haven't done it14:33
jkulikso no allocation requests with providers in trees with osc-placement14:33
stephenfinDue to lack of impetus14:33
jkulikhm ... makes sense. no real reason, then :D14:33
*** ociuhandu has quit IRC14:34
jkulikIs there any objection against always supporting the latest version available in placement?14:34
viks____Hi, When a new instance is created, nova sets a random password. But this password does work. So how to make this work? I know a method where we set with `nova set-password` command and qemu agent running on instances, but then what is the use of the random password generated during instance creation?14:34
gibijkulik: no objection. If pathces are proposed against osc-placement to add support for the newer versions then please ping me and I will try to review them14:34
viks____Also if we rescue instance, it asks to set a password, but that also does not work? how to make rescue password work?14:34
stephenfinjkulik: I can't think of one, no14:34
stephenfinWe probably have just been forgetting to bump things like we do in novaclient14:35
jkulikok. I'll propose a patch for the latest versions.14:35
stephenfinjkulik: With that said, adding e.g. 1.29 to that list doesn't really do anything new14:35
stephenfinUnless you implement the functionality of that microversion14:35
jkulikstephenfin: it actually does14:36
jkulikit allows me to query allocation candidates that are in trees14:36
jkulikbefore, I don't get anything returned. with 1.29, I get the providers like I got on queens btw.14:36
stephenfinDoesn't that require changes to the client?14:36
stephenfinI assume the output from the server is different?14:36
* stephenfin apologizes for not having loaded up on context on this yet14:37
jkulikhm ... looks the same to me. we still have queens around and I compared the output right now.14:37
jkulikhaving the rocky code-base and an api-version below 1.29 returns nothing anymore.14:37
*** ociuhandu has joined #openstack-nova14:40
jkulikwe could™ extend osc-placement to show the new "parent_provider_uuid" and "root_provider_uuid"14:40
gibijkulik: I think you are correct. the two new things is are those^^ attributesd in the a_c response14:43
gibithe rest is just logic change in the placement server14:43
gibibut no structural change in the input or output14:43
*** ociuhandu has quit IRC14:44
*** khomesh24 has quit IRC14:45
*** khomesh24 has joined #openstack-nova14:45
jkulikgibi, stephenfin
stephenfin+2 from me14:52
gibistephenfin: jkulik: gerrit now showed that there is already a patch for 1.29 and it is more widespread change that adds mutliple things that is missing from the client like support for 1.25 adding granular request
*** Luzi has quit IRC14:55
stephenfinI saw that conflict and skipped over it once I saw 1.25 in the commit message14:55
stephenfinI can review that now14:55
gibijkulik: do you also need support for 1.25 and so on?14:56
jkulikgibi: 1.26 would be nice, yes14:57
*** ociuhandu has joined #openstack-nova14:57
jkulikshall I abandon my request in favor of the exiting one?14:58
*** macz_ has joined #openstack-nova14:59
gibiI think would be better as it is a more complete solution than just enabling 1.2915:02
jkulikI agree. abandoned my change.15:05
*** rcernin has quit IRC15:05
*** ociuhandu has quit IRC15:07
*** rpittau is now known as rpittau|afk15:08
*** lbragstad_ is now known as lbragstad15:11
*** ociuhandu has joined #openstack-nova15:12
*** ociuhandu has quit IRC15:18
kashyapstephenfin: I blame you for my slow-gaining rST obsession.  In my reviews in libvirt rST docs upstream, I began typing out little rST tweaks they could do :D15:23
stephenfinGood :) It's got a learning curve but it is very powerful stuff15:23
stephenfinespecially when you introduce extensions15:24
kashyapstephenfin: Yeah, I'm nowhere near your ability to spot all rST problems from a mile away...but still, now I feel like I should tackle this 8000+ line doc15:24
kashyapstephenfin: While you're here:15:24
kashyapstephenfin: Say, a project prefers at most 80 cols of text width.  Do you care to adjust pre-formatted and tables which overflow 80 cols?15:25
*** martinkennelly has quit IRC15:25
stephenfinI try to wrap e.g. commands in code-blocks, but only because they don't wrap very well in PDF output15:26
stephenfinbut obviously you can't do that for source code snippets15:26
kashyapstephenfin: A libvirt dev was asking me would you _do_ anything about it15:26
*** martinkennelly has joined #openstack-nova15:26
stephenfinAlso, you can unusually replace literal tables with e.g. the '.. list-table' directive15:26
kashyap(Where "it" == long code snippets; or other similar pre-formatted stuff)15:27
stephenfinIt's not as nice to read in the source, but it's far simpler to prepare and the output is identical15:27
kashyapstephenfin: Ah, nice15:27
stephenfinI'd keep those things as-is, personally15:27
kashyapstephenfin: I didn't know the ".. list-table" directive.  Do we have an example of it in our docs?15:27
*** ociuhandu has joined #openstack-nova15:28
kashyapstephenfin: Okay, that's what I thought.  It's less work too15:28
stephenfinloads of examples, yes15:28
stephenfindoc/source/cli/nova-manage.rst for one15:28
kashyapstephenfin: Thanks.  And speaking of extensions, what extensions are recommended?  Even if it's your subjective list15:29
stephenfinThat's entirely doc specific15:29
stephenfinWe use a load of custom ones for things like autodocumenting oslo.policy and oslo.config code that wouldn't make sense outside of OpenStack15:30
kashyapstephenfin: Ah, okay.  I'll be modest and fix the obvious stuff for libvirt.  I'm just adjusting some secure boot docs in libvirt, hence this chatter here15:30
stephenfinOnce you start needing to cross-reference project-unique things or auto-generate some kind of docs, this stuff starts becoming useful15:31
kashyapThey recently big-bang convereted HTML to rST an 8000-line file (this one, which we commonly refer to:
kashyapWith `pandoc`:
kashyapIgnore the silly GitLab thing in the commit message.  It converted :anchor: to ⚓ emoji :D15:32
*** dklyle has joined #openstack-nova15:35
*** ociuhandu has quit IRC15:38
*** sapd1 has joined #openstack-nova15:38
stephenfingibi: melwitt: You think we can go ahead with now?15:39
stephenfinI just got asked "why doesn't 'openstack resource provider inventory list' show usage" downstream and was like, aha, I'm not crazy!15:39
jkulikstephenfin: can you elaborate on that?15:42
stephenfinjkulik: On that patch?15:42
jkulikstephenfin: on not showing usage15:42
*** openstackgerrit has joined #openstack-nova15:42
openstackgerritMerged openstack/osc-placement master: Support granular allocation candidate list
stephenfinoh, 'openstack resource provider inventory list' shows total available inventory for a resource provider15:43
stephenfinbut it doesn't include usage information15:43
jkulikyes. we built our on little command to also see the usage next to it15:43
jkulikwhy isn't that included?15:43
stephenfinto get that, you need to use a separate command, 'openstack resource provider usage show'15:43
stephenfinjkulik: That's my argument: it should be :)15:43
jkulikoh :D15:43
jkulikI read your message wrong :D15:44
stephenfinSo I'm adding it there and proposing we eventually deprecated the separate usage command15:44
jkulikshould just have clicked the review link, thanks m)15:45
*** ociuhandu has joined #openstack-nova15:45
*** psachin has quit IRC15:59
*** LinPeiWen80 has quit IRC16:00
gibistephenfin: I have to get back to this on Monday16:02
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Add nova-live-migration-ceph job
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Replace grenade and nova-grenade-multinode with grenade-multinode
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Create and use nova-libvirt-irrelevant-files
*** ociuhandu has quit IRC16:05
*** brinzhang0 has quit IRC16:14
*** brinzhang0 has joined #openstack-nova16:15
*** ociuhandu has joined #openstack-nova16:36
*** ociuhandu has quit IRC16:45
*** k-s-dean has quit IRC16:46
openstackgerritLee Yarwood proposed openstack/nova master: zuul: Remove nova-dsvm-multinode-base
openstackgerritLee Yarwood proposed openstack/nova master: WIP zuul: Create and use nova-libvirt-irrelevant-files
*** ociuhandu has joined #openstack-nova16:47
*** lpetrut has quit IRC16:47
*** ociuhandu has quit IRC16:53
*** ociuhandu has joined #openstack-nova16:54
*** k-s-dean has joined #openstack-nova16:55
*** lucasagomes has quit IRC16:56
*** ociuhandu has quit IRC16:58
*** tesseract has quit IRC17:04
*** ociuhandu has joined #openstack-nova17:12
*** ociuhandu has quit IRC17:12
*** ociuhandu has joined #openstack-nova17:12
*** ociuhandu_ has joined #openstack-nova17:20
*** dtantsur is now known as dtantsur|afk17:21
*** ociuhandu has quit IRC17:24
*** ociuhandu_ has quit IRC17:24
*** k_mouza has quit IRC17:26
*** k_mouza_ has joined #openstack-nova17:26
*** ociuhandu has joined #openstack-nova17:28
*** ociuhandu has quit IRC17:32
*** hamalq has joined #openstack-nova17:41
openstackgerritMerged openstack/nova stable/victoria: libvirt: Use specific user when probing encrypted rbd disks during extend
openstackgerritMerged openstack/nova master: doc: mark the max microversion for wallaby
*** andrewbonney has quit IRC17:50
*** k_mouza_ has quit IRC17:52
*** k_mouza has joined #openstack-nova18:14
*** khomesh24 has quit IRC18:16
*** k_mouza has quit IRC18:20
*** hamalq has quit IRC18:36
*** hamalq has joined #openstack-nova18:36
*** tbachman has quit IRC18:57
*** tbachman_ has joined #openstack-nova18:57
*** whoami-rajat has quit IRC19:00
openstackgerritMerged openstack/nova master: releasenotes: Fix typo
*** viks____ has quit IRC19:04
*** jamesdenton has quit IRC19:07
*** jamesdenton has joined #openstack-nova19:07
*** songwenping__ has quit IRC19:09
*** songwenping__ has joined #openstack-nova19:10
*** jamesdenton has quit IRC19:29
*** jamesdenton has joined #openstack-nova19:29
*** vishalmanchanda has quit IRC19:35
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update .gitreview for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/os-vif stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Update master for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/os-vif master: Add Python3 xena unit tests
openstackgerritOpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update .gitreview for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/osc-placement stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/osc-placement master: Update master for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update .gitreview for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient stable/wallaby: Update TOX_CONSTRAINTS_FILE for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient master: Update master for stable/wallaby
openstackgerritOpenStack Release Bot proposed openstack/python-novaclient master: Add Python3 xena unit tests
*** ociuhandu has joined #openstack-nova19:57
*** ociuhandu has quit IRC20:48
*** ociuhandu has joined #openstack-nova20:48
*** jobewan has joined #openstack-nova20:57
*** k-s-dean has quit IRC21:00
*** jobewan has quit IRC21:04
*** ociuhandu has quit IRC21:12
*** openstackgerrit has quit IRC21:22
*** jamesdenton has quit IRC21:30
*** jamesdenton has joined #openstack-nova21:31
*** k-s-dean has joined #openstack-nova21:39
*** rcernin has joined #openstack-nova22:03
*** dpawlik has quit IRC22:11
*** lbragstad has quit IRC22:11
*** mdbooth has quit IRC22:11
*** k-s-dean has quit IRC22:11
*** tbachman_ has quit IRC22:12
*** brinzhang_ has joined #openstack-nova22:12
*** lbragstad_ has joined #openstack-nova22:12
*** kd has joined #openstack-nova22:12
*** dpawlik9 has joined #openstack-nova22:12
*** dpawlik9 is now known as dpawlik22:13
*** rnoriega- has quit IRC22:13
*** martinkennelly has quit IRC22:13
*** brinzhang0 has quit IRC22:13
*** tobiash has quit IRC22:13
*** tobiash has joined #openstack-nova22:14
*** mgoddard has quit IRC22:16
*** rnoriega_ has joined #openstack-nova22:18
*** mgoddard has joined #openstack-nova22:19
*** amodi has quit IRC22:22
*** tbachman has joined #openstack-nova22:32
*** jamesdenton has quit IRC23:00
*** jamesdenton has joined #openstack-nova23:02
*** hamalq has quit IRC23:05
*** efried has quit IRC23:17
*** efried has joined #openstack-nova23:18
*** tkajinam has quit IRC23:27
*** jamesdenton has quit IRC23:30
*** jamesdenton has joined #openstack-nova23:30
*** mlavalle has quit IRC23:37
*** stand has quit IRC23:47

Generated by 2.17.2 by Marius Gedminas - find it at!