*** bhagyashris__ <bhagyashris__!~bhagyashr@103.98.79.86> has joined #openstack-nova | 01:51 | |
*** bhagyashris_ <bhagyashris_!~bhagyashr@103.98.79.86> has quit IRC (Ping timeout: 480 seconds) | 01:58 | |
*** priteau <priteau!~priteau@93.186.40.84> has quit IRC (Ping timeout: 480 seconds) | 02:04 | |
*** priteau <priteau!~priteau@93.186.40.84> has joined #openstack-nova | 02:06 | |
*** vishalmanchanda <vishalmanchanda!uid326448@id-326448.charlton.irccloud.com> has joined #openstack-nova | 04:40 | |
gibi | good morning | 05:16 |
---|---|---|
gibi | early cores, can we turn on mypy now https://review.opendev.org/c/openstack/nova/+/795973 ? | 05:16 |
gibi | the missing requirement for mpyp 0.9 has been merged over the weekend | 05:17 |
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-nova | 05:18 | |
*** ratailor_ <ratailor_!~ratailor@103.115.207.241> has joined #openstack-nova | 05:43 | |
*** ratailor_ is now known as ratailor | 05:48 | |
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has joined #openstack-nova | 06:02 | |
*** iurygregory_ <iurygregory_!~iurygrego@2a02:8308:a007:3900:93ab:1c8f:2b9e:9349> has joined #openstack-nova | 06:07 | |
*** iurygregory|afk <iurygregory|afk!~iurygrego@ip-86-49-241-46.net.upcbroadband.cz> has quit IRC (Read error: Connection reset by peer) | 06:07 | |
*** icey <icey!~icey@0001bbad.user.oftc.net> has quit IRC () | 06:18 | |
*** icey <icey!~icey@0001bbad.user.oftc.net> has joined #openstack-nova | 06:18 | |
*** bhagyashris__ is now known as bhagyashris | 06:36 | |
*** rpittau|afk is now known as rpittau | 07:07 | |
*** luksky <luksky!~luksky@hC1F2D42A.cust.netmar.net.pl> has joined #openstack-nova | 07:16 | |
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has quit IRC (Quit: Leaving) | 07:16 | |
*** tkajinam <tkajinam!~tkajinam@240d:1a:6af:1b00:3462:14d1:c5f6:8946> has joined #openstack-nova | 07:17 | |
*** andrewbonney <andrewbonney!uid417545@id-417545.highgate.irccloud.com> has joined #openstack-nova | 07:21 | |
*** tosky <tosky!~luigi@dynamic-adsl-78-13-253-141.clienti.tiscali.it> has joined #openstack-nova | 07:45 | |
bauzas | gibi: I could do it but... | 07:47 |
gibi | but? :) | 07:47 |
gibi | ahh, you are the author | 07:47 |
bauzas | ;) | 07:47 |
gibi | you tricked me :) | 07:48 |
bauzas | gibi: just do a fast approval | 07:48 |
gibi | I think stephenfin will be up soon | 07:48 |
bauzas | well ok | 07:49 |
*** lucasagomes <lucasagomes!~lucasagom@89.100.20.18> has joined #openstack-nova | 07:55 | |
*** CeeMac <CeeMac!uid366483@id-366483.brockwell.irccloud.com> has joined #openstack-nova | 08:05 | |
*** elodilles is now known as elodilles_afk | 08:05 | |
*** derekh <derekh!~derekh@2a01:b340:80:9a52:6423:15e0:3703:2> has joined #openstack-nova | 08:12 | |
*** whoami-rajat <whoami-rajat!uid314320@id-314320.brockwell.irccloud.com> has joined #openstack-nova | 08:14 | |
lyarwood | +W'd | 08:37 |
lyarwood | looking at https://bugs.launchpad.net/nova/+bug/1931716 now btw | 08:38 |
opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Rebuild Server API https://review.opendev.org/c/openstack/nova/+/766380 | 08:41 |
opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List SG API https://review.opendev.org/c/openstack/nova/+/766726 | 08:42 |
opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from Flavor Access APIs https://review.opendev.org/c/openstack/nova/+/767704 | 08:43 |
opendevreview | Wenping Song proposed openstack/nova master: Replaces tenant_id with project_id from List/Show usage APIs https://review.opendev.org/c/openstack/nova/+/768509 | 08:44 |
gibi | lyarwood: thanks. I pushed a small patch with debug log to see what is the error code libvirt sends https://review.opendev.org/c/openstack/nova/+/796043 | 08:44 |
kashyap | Hmm, it's this disk not found thing ... I have a deja vu of this w/ device-detach | 08:48 |
gibi | kashyap: yes, it is totally deja vus | 08:49 |
* kashyap nods; morning, folks | 08:50 | |
gibi | morning | 08:50 |
lyarwood | I called out some commits in https://review.opendev.org/c/openstack/nova/+/741561 that seemed to show we were using VIR_ERR_DEVICE_MISSING now so I'm slightly confused by this | 08:52 |
lyarwood | unless someone reverted some of this in libvirt | 08:53 |
lyarwood | https://libvirt.org/git/?p=libvirt.git;a=blobdiff;f=src/qemu/qemu_hotplug.c;h=5be3e0659ad749e7e8a3585f6b98e2f218f34059;hp=a62dbe79e5650b051f02bb059afbd251b296b899;hb=126db34a81bc9f9f9710408f88cceaa1e34bbbd7;hpb=bb189c8e8c93f115c13fa3bfffdf64498f3f0ce1 for example | 08:53 |
gibi | lyarwood: I think we can wait until I can reproduce the problem with the extra debug log to is what is the error code, then after that I can add that code to the handler in nova | 08:55 |
gibi | s/to is/to see/ | 08:55 |
lyarwood | ack yeah and I'll have a quick look at the libvirt code to see what's changed if anything | 08:57 |
gibi | ack, thanks | 08:57 |
lyarwood | https://github.com/libvirt/libvirt/blob/55ea45acc99c549c7757efe954aacc33ad30a8ef/src/qemu/qemu_hotplug.c#L5324-L5328 yeah it didn't change all the paths | 09:03 |
lyarwood | gah! | 09:03 |
lyarwood | that's the one I'm assuming we are hitting here tbh | 09:03 |
gibi | jepp, that could be the case | 09:10 |
gibi | then I will prepare a commit adding handler for it | 09:10 |
*** abhishekk <abhishekk!~akekane@116.74.162.143> has quit IRC (Quit: Bye...) | 09:19 | |
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has joined #openstack-nova | 09:47 | |
*** MrClayPole <MrClayPole!~quassel@2a02:8010:6538:104:216:3eff:fed5:272f> has joined #openstack-nova | 10:00 | |
opendevreview | Jorhson Deng proposed openstack/nova master: remove the redundant code for attach interface https://review.opendev.org/c/openstack/nova/+/796208 | 10:10 |
opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful reference: https://opendev.org/openstack/nova/src/branch/master/nova/compute/manager.py#L2897 https://review.opendev.org/c/openstack/nova/+/796209 | 10:13 |
opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | 10:14 |
lyarwood | gibi: https://listman.redhat.com/archives/libvir-list/2021-June/msg00337.html FWIW | 10:19 |
gibi | lyarwood: awesome | 10:20 |
gibi | thanks | 10:20 |
gibi | I'm just writing the unit test for the nova patch | 10:20 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Handle OPERATION_FAILED error during detach https://review.opendev.org/c/openstack/nova/+/796255 | 10:35 |
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has joined #openstack-nova | 10:40 | |
*** ratailor_ <ratailor_!~ratailor@2409:4052:2204:5df:d46:7ddd:22bd:3dc0> has quit IRC (Remote host closed the connection) | 10:40 | |
gibi | lyarwood: ^^ | 10:41 |
lyarwood | ack looking | 10:41 |
lyarwood | LGTM | 10:45 |
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has joined #openstack-nova | 10:46 | |
*** ratailor <ratailor!~ratailor@103.115.207.241> has quit IRC (Ping timeout: 480 seconds) | 10:46 | |
*** mgariepy <mgariepy!~mgariepy@0002bc4d.user.oftc.net> has quit IRC (Ping timeout: 480 seconds) | 10:55 | |
opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796257 | 11:00 |
opendevreview | Lee Yarwood proposed openstack/nova stable/wallaby: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796258 | 11:00 |
opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796259 | 11:01 |
opendevreview | Lee Yarwood proposed openstack/nova stable/victoria: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796260 | 11:01 |
opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: virt: Add destroy_secrets kwarg to destroy and cleanup https://review.opendev.org/c/openstack/nova/+/796262 | 11:05 |
opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: Detach is broken for multi-attached fs-based volumes https://review.opendev.org/c/openstack/nova/+/796263 | 11:05 |
opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: libvirt: Do not destroy volume secrets during _hard_reboot https://review.opendev.org/c/openstack/nova/+/796264 | 11:05 |
stephenfin | lyarwood: elodilles_afk: Could you folks stick https://review.opendev.org/c/openstack/os-vif/+/765967 and its relatives on the stable review list for this week? | 11:09 |
lyarwood | ack | 11:09 |
stephenfin | ta | 11:09 |
lyarwood | didn't we say that the os-vif cores were going to end up as stable cores? | 11:10 |
lyarwood | ah lunch is ready, I'll get to this afterwards brb | 11:10 |
stephenfin | I thought we did but we haven't made the change yet | 11:10 |
stephenfin | nw | 11:10 |
*** elodilles_afk is now known as elodilles | 11:17 | |
elodilles | stephenfin: sure, will review as soon as I get there :) | 11:18 |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Remote host closed the connection) | 11:27 | |
*** mgoddard- <mgoddard-!~mgoddard@240.240.125.91.dyn.plus.net> has joined #openstack-nova | 11:35 | |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova | 11:37 | |
*** artom <artom!~artom@205.233.59.73> has joined #openstack-nova | 11:37 | |
*** mgoddard <mgoddard!~mgoddard@238.240.125.91.dyn.plus.net> has quit IRC (Ping timeout: 480 seconds) | 11:38 | |
*** mgoddard- is now known as mgoddard | 11:38 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | 11:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | 11:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | 11:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 11:39 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 11:40 |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC (Quit: leaving) | 11:43 | |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova | 11:43 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 11:44 |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has quit IRC () | 11:45 | |
*** smcginnis <smcginnis!~smcginnis@72-50-207-44.fttp.usinternet.com> has joined #openstack-nova | 11:46 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 11:46 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 11:48 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 11:49 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 11:49 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | 11:52 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 11:53 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 11:54 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 11:54 |
gibi | lyarwood: are you working on adding a retry to nova.virt.libvirt.storage.lvm.get_volume_group_info due to https://bugs.launchpad.net/nova/+bug/1931710 ? If not then I can jump on that (I just so that error again in a fresh run)( | 11:55 |
lyarwood | gibi: I haven't started so if you have the time please go ahead :) | 11:56 |
gibi | then I go and do it | 11:56 |
gibi | :) | 11:56 |
*** mgariepy <mgariepy!~mgariepy@styx-204.ccs.usherbrooke.ca> has joined #openstack-nova | 12:09 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Retry volume group query https://review.opendev.org/c/openstack/nova/+/796269 | 12:17 |
gibi | lyarwood: here it is ^^ | 12:17 |
*** erlon <erlon!uid7593@id-7593.brockwell.irccloud.com> has joined #openstack-nova | 12:18 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796269 | 12:37 |
gibi | realized that I saw failures both in case of lvs and vgs queries | 12:38 |
lyarwood | Yeah indeed sorry the UI didn't refresh in time | 12:40 |
* lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/XfLAFrLrlNopmHKdnwasGPBm/message.txt > | 12:40 | |
lyarwood | fun | 12:40 |
lyarwood | ^ in nova-multi-cell | 12:41 |
lyarwood | and | 12:41 |
* lyarwood < https://matrix.org/_matrix/media/r0/download/matrix.org/xHwHZZDQSCYqDpBONAKLZWRZ/message.txt > | 12:41 | |
lyarwood | in tox-py-36 | 12:41 |
* lyarwood creates some bugs | 12:41 | |
gibi | oh nice | 12:42 |
gibi | it was release monday out there it seems :D | 12:42 |
gibi | but what is the conflict in the stevedore case? stevedore >=1.20.0 and stevedore === 3.3.0 are not conflicting | 12:44 |
gibi | or am I missing something? | 12:44 |
lyarwood | tbh both are confusing | 12:44 |
*** ratailor_ <ratailor_!~ratailor@103.115.207.228> has quit IRC (Quit: Leaving) | 12:46 | |
lyarwood | yeah I can't reproduce the numpy websockify one | 12:50 |
*** rloo <rloo!~rloo@2001:4998:ef83:14:8000::10c2> has joined #openstack-nova | 13:06 | |
sean-k-mooney | lyarwood: how are you finding the matix bridge? i likke the way image sharing work on the irc side | 13:06 |
sean-k-mooney | its nicer on the matrix side of cource since its inline but the urls work well for irc users too | 13:07 |
lyarwood | I've hardly noticed it thus far that's a great thing | 13:07 |
sean-k-mooney | still using the web interface or have you tried the weechat plugin | 13:07 |
sean-k-mooney | gibi: lyarwood if you want a third person to test just let me know | 13:08 |
lyarwood | sean-k-mooney: I'm using element | 13:09 |
sean-k-mooney | gibi: lyarwood oh wile i rememebr while i rememeber https://review.opendev.org/c/openstack/ovsdbapp/+/795789 seams to work but terry is fixing it properly in ovs. | 13:11 |
sean-k-mooney | im going to also see if i can find an os-vif only solution that we could backport | 13:12 |
gibi | cool | 13:12 |
gibi | let me know if you need a reviewer to let the solution merges | 13:12 |
sean-k-mooney | ack will do im not going to get to working on it today but its on my todo list for tomorrow | 13:12 |
sean-k-mooney | im going to try and finish the off path accleartor spec review today and start on the next revision or the pci in placemnet one | 13:13 |
gibi | ack | 13:13 |
sean-k-mooney | i spoke to artom about it last week and im going to split the pci one the first spec will just be for non neutron devices and the second will cover the netruon aspect im also goign to file a but for a different semi feature semi bug which ill bring up in either this weeks meetign or next | 13:14 |
gibi | the split works for me | 13:15 |
gibi | just try not to do something for the non neutron devices that will be a dead en for the neutron ones | 13:15 |
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has quit IRC (Quit: Leaving) | 13:26 | |
*** ralonsoh <ralonsoh!~ralonsoh@36.red-79-150-231.dynamicip.rima-tde.net> has joined #openstack-nova | 13:26 | |
sean-k-mooney | ack | 13:26 |
*** abhishekk <abhishekk!~akekane@116.74.162.143> has joined #openstack-nova | 13:37 | |
*** abhishekk is now known as akekane|home | 13:37 | |
*** akekane|home is now known as abhishekk | 13:37 | |
opendevreview | Merged openstack/nova master: Revert "Removing mypy to fix the nova CI" https://review.opendev.org/c/openstack/nova/+/795973 | 13:41 |
*** Luzi <Luzi!~Luzi@ipservice-092-208-056-099.092.208.pools.vodafone-ip.de> has quit IRC (Quit: Leaving) | 14:01 | |
stephenfin | lyarwood++ Good catch on the libvirt device removal thing | 14:34 |
stephenfin | and gibi++ too | 14:35 |
stephenfin | gibi: I've a small nit on https://review.opendev.org/c/openstack/nova/+/796255. Do you want to address now (since CI is rerunning anyway) or in a follow-up? | 14:35 |
*** rpittau is now known as rpittau|afk | 16:08 | |
opendevreview | Stephen Finucane proposed openstack/nova master: docs: Replace 'nova boot' with 'openstack server create' https://review.opendev.org/c/openstack/nova/+/794007 | 17:22 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Handle OPERATION_FAILED error during detach https://review.opendev.org/c/openstack/nova/+/796255 | 17:40 |
gibi | lyarwood, stephenfin: fixed up ^^ | 17:40 |
opendevreview | Merged openstack/nova master: Add debug log for device detach libvirt error https://review.opendev.org/c/openstack/nova/+/796043 | 17:44 |
opendevreview | Mohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796319 | 20:55 |
opendevreview | Mohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796319 | 20:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!