opendevreview | norman shen proposed openstack/nova master: Saving security group to info_cache https://review.opendev.org/c/openstack/nova/+/786348 | 00:36 |
---|---|---|
opendevreview | Merged openstack/nova master: Test the NotificationFixture https://review.opendev.org/c/openstack/nova/+/758450 | 00:47 |
opendevreview | Merged openstack/nova master: Move fake_notifier impl under NotificationFixture https://review.opendev.org/c/openstack/nova/+/758451 | 00:47 |
*** liuyulong_ is now known as liuyulong | 02:25 | |
opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 02:33 |
opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 02:33 |
opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 02:33 |
opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 02:33 |
opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 02:33 |
*** iurygregory_ is now known as iurygregory | 06:19 | |
gibi | lyarwood, stephenfin: good morning! another pip conflict http://paste.openstack.org/show/806617/ in https://f4c7a70c63adb2c6ee00-366864060e164744cd046650ee1657de.ssl.cf1.rackcdn.com/794639/6/gate/nova-ceph-multistore/cbf9aff/job-output.txt | 07:04 |
gibi | lyarwood: did you managed to find some hint yesterday about the websockify or the the stevedore case? | 07:08 |
gibi | this feels pretty random | 07:09 |
*** rpittau|afk is now known as rpittau | 07:13 | |
opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:31 |
opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 07:31 |
lyarwood | gibi: no I couldn't work it out, is this another hit? | 08:04 |
lyarwood | sean-k-mooney: https://bugs.launchpad.net/nova/+bug/1912310/comments/4 btw looks like more evidence of the ovsdbapp polling bug #1929446 the client here fails to send some keepalives to libvirtd on the dest so it kills the migration and domain | 08:36 |
lyarwood | gibi: https://zuul.opendev.org/t/openstack/build/cbf9affc449848f9910eaab857c5df74/log/job-output.txt#29072 another example | 08:43 |
lyarwood | 2021-06-14 17:43:15.964340 | controller | The conflict is caused by: | 08:43 |
lyarwood | 2021-06-14 17:43:15.964414 | controller | cinder-tempest-plugin 1.4.1.dev16 depends on tempest>=17.1.0 | 08:43 |
lyarwood | 2021-06-14 17:43:15.964457 | controller | The user requested (constraint) tempest===27.0.0 | 08:43 |
lyarwood | /o\ | 08:43 |
lyarwood | oh sorry that was the same one you pointed out | 08:46 |
lyarwood | I've updated https://bugs.launchpad.net/nova/+bug/1931864 to track these | 08:46 |
bauzas | lyarwood: gibi: sorry was on and off those 2 days as I need to use another laptop, but is https://bugs.launchpad.net/nova/+bug/1931864 a gate failure for all the changes ? | 08:48 |
lyarwood | not all changes, I've seen it ~3 or 4 times now in the gate | 08:48 |
bauzas | ack thanks | 08:49 |
sean-k-mooney | lyarwood: ack, terry would prefer to not merge my ovsdbapp fix and is instead fixing the issue in ovs | 10:02 |
sean-k-mooney | lyarwood: although i think we need to have a backportable fix also | 10:02 |
lyarwood | kk awesome, I'm starting to think that we can likely attribute lots of the recent weirdness in the gate to this tbh | 10:03 |
sean-k-mooney | ya proably | 10:03 |
sean-k-mooney | we change the default to native in victoria | 10:03 |
sean-k-mooney | until then we were still using the cli based driver instead of the python libs | 10:03 |
sean-k-mooney | so this being the default is relitivly recent form a ci point of view | 10:04 |
gibi | lyarwood: no worries | 10:23 |
* gibi will be on and off today | 10:24 | |
opendevreview | Balazs Gibizer proposed openstack/nova master: Retry lvm volume and volume group query https://review.opendev.org/c/openstack/nova/+/796269 | 10:44 |
gibi | stephenfin: fixed up the syle nit ^^ | 10:44 |
gibi | lyarwood: an easy review for the lvm job fix ^^ | 10:45 |
stephenfin | ta, done | 10:45 |
gibi | thanks | 10:45 |
lyarwood | thanks ack'd | 10:46 |
gibi | lyarwood: this is also ready to go https://review.opendev.org/c/openstack/nova/+/796255 | 10:57 |
lyarwood | ack thanks | 10:58 |
gibi | thanks | 11:00 |
opendevreview | Mohammed Naser proposed openstack/nova master: Allow X-OpenStack-Nova-API-Version header in CORS https://review.opendev.org/c/openstack/nova/+/796319 | 11:35 |
opendevreview | Lee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run successfully on RHEL https://review.opendev.org/c/openstack/nova/+/796428 | 11:51 |
opendevreview | Lee Yarwood proposed openstack/nova master: tests: Allow bindep and test-setup.sh to run successfully on RHEL https://review.opendev.org/c/openstack/nova/+/796428 | 11:58 |
*** halali is now known as halali_ | 13:08 | |
*** rpittau is now known as rpittau|afk | 14:29 | |
bauzas | gibi: I have a scheduled appointment in 30 mins, I could not be back at the meeting time | 14:51 |
bauzas | in case I'm not around, nothing to say about the libvirt subteam | 14:51 |
opendevreview | norman shen proposed openstack/nova master: Saving security group to info_cache https://review.opendev.org/c/openstack/nova/+/786348 | 14:53 |
gibi | bauzas: thanks for the info | 14:58 |
spatel | sean-k-mooney do you know where is this error coming from - default default] [instance: 9a490cfa-8da6-4c14-868a-e10a08278c66] Instance failed to spawn: libvirt.libvirtError: unsupported configuration: Emulator '/usr/bin/qemu-system-x86_64' does not support virt type 'kvm' | 14:58 |
spatel | i have 20 compute nodes and only 4 compute nodes complaining about that error, they all running same config/os etc.. | 14:58 |
pjakuszew | spatel: sounds like virtualisation support is disabled on these machines | 15:00 |
spatel | hmm | 15:00 |
spatel | let me go to bios and verify incase i missed something | 15:00 |
pjakuszew | spatel: does /dev/kvm exist? | 15:02 |
spatel | '/dev/kvm': No such file or directory | 15:03 |
pjakuszew | and how about lsmod | grep kvm? | 15:03 |
spatel | kvm 663552 0 | 15:03 |
pjakuszew | it depends on the architecture, but on x86 there should be kvm + kvm_{intel,amd} | 15:04 |
pjakuszew | you only have kvm | 15:04 |
spatel | look like something is wrong in my BIOS setting then.. | 15:04 |
pjakuszew | which suggests that either the cpu doesn't handle vt-x/svm, or you simply have it disabled in bios/uefi | 15:04 |
pjakuszew | yeah | 15:04 |
spatel | rebooting my VM to verify | 15:04 |
spatel | host i meant | 15:05 |
opendevreview | norman shen proposed openstack/nova master: Saving security group to info_cache https://review.opendev.org/c/openstack/nova/+/786348 | 15:08 |
spatel | pjakuszew turned out VT was disable in BIOS :) good catch thank you.. | 15:10 |
sean-k-mooney | spatel: i was just going to say likely vt-d | 15:12 |
sean-k-mooney | or vt-x | 15:12 |
sean-k-mooney | there is a script to check that | 15:13 |
pjakuszew | ubuntu has one iirc | 15:14 |
sean-k-mooney | virt-host-validate | 15:14 |
sean-k-mooney | or you can use kvm_ok on ubuntu | 15:14 |
sean-k-mooney | virt-host-validate is what you use on fedora/centos/rhel | 15:14 |
sean-k-mooney | although it might be on ubuntu also | 15:15 |
sean-k-mooney | i think its actully part of libvirt where as kvm_ok is part of cpu-checker i think | 15:15 |
sean-k-mooney | its not actully part of libvirt | 15:15 |
spatel | sean-k-mooney here its - http://paste.openstack.org/show/806634/ | 15:17 |
spatel | kvm-ok | 15:17 |
sean-k-mooney | yep so it deteced the problem | 15:17 |
sean-k-mooney | do you happen to have virt-host-validate also | 15:17 |
sean-k-mooney | it check more things but kvm_ok is nice for a quick check | 15:18 |
spatel | yes i do have virt-host-validate, it has nice output.. i didn't know about this | 15:18 |
spatel | i will add in my ansible playbook to validate VT before start deploying code | 15:19 |
sean-k-mooney | kvm-ok was what i always used to use only found out about virt-host-validate about a year ago | 15:19 |
pjakuszew | spatel: the hostname from your pastebin suggests that you probably will be interested in vt-d and intel_iommu=on as well | 15:19 |
sean-k-mooney | virt-host-validate will check if you can use sriov and a few other things also | 15:19 |
sean-k-mooney | intel_iommu=on iommu=pt most likely | 15:20 |
spatel | pjakuszew my all computes running on sriov | 15:20 |
sean-k-mooney | iommu=pt is not strictly requried if its only sriov and not dpdk | 15:20 |
spatel | i have added both anyway | 15:20 |
spatel | sean-k-mooney nowadays i am playing with OVN, it looks complicated but promissing | 15:22 |
spatel | promising* | 15:23 |
sean-k-mooney | it is on both counts | 15:23 |
sean-k-mooney | simpler then odl or onos | 15:23 |
sean-k-mooney | but more complex the simple sriov | 15:23 |
spatel | complex with sriov? | 15:24 |
spatel | i haven't started playing with OVN + SR-IOV yet. I am planning to use dpdk instead of sriov this time | 15:25 |
sean-k-mooney | no i ment sriov is relitvly simple in that its just a vlan on a vf in most case with simpel vlan networking | 15:26 |
spatel | oh! | 15:26 |
sean-k-mooney | ovn is more complex because of the need to under stand how the logical switchs in ovn mape too the neutron network and how ovn translattes the configuretion into openflow rules and the complexites of geneve tunneling | 15:27 |
sean-k-mooney | once you wrap your head around it its fine but there is a lot more context to understand with ovn | 15:27 |
spatel | no doubt about complexity. it has lots of moving components in single piece. l2/l3/firewall/dhcp so it looks simple but kinda hard to troubleshoot. | 15:29 |
spatel | sometime its very hard to read flow table for troubleshooting, specially when it has hundreds of entries. | 15:30 |
spatel | but i like all the feature it providing like DVR etc.. which is very easy and it won't waste of public IPs unlike legacy DVR | 15:31 |
*** halali is now known as halali_ | 15:32 | |
gibi | fyi I've opened a new gate-failure bug https://bugs.launchpad.net/nova/+bug/1932043 nova-ceph-multinode test_resize_server_revert fails with rbd.ReadOnlyImage: [errno 30] RBD read-only image | 15:35 |
melwitt | elodilles: if I could trouble you for review on https://review.opendev.org/c/openstack/nova/+/794186 and https://review.opendev.org/c/openstack/nova/+/791577 please if you get a chance | 15:35 |
sean-k-mooney | gibi: strange was the a new cpeh release or soemthign | 15:36 |
sean-k-mooney | e.g. did somethign cause a change in the behaivor | 15:37 |
gibi | sean-k-mooney: I saw it 3 times in the last couple of days, so it is not a total blocker | 15:37 |
sean-k-mooney | im not sure why the image would be ReadOnlyImage | 15:37 |
sean-k-mooney | ok | 15:37 |
melwitt | lyarwood: and if I could trouble you for review on https://review.opendev.org/c/openstack/nova/+/791577 please if you get a chance | 15:37 |
gibi | sean-k-mooney: I don't see ceph version differences between failed and successfull jobs both using nautilus | 15:44 |
sean-k-mooney | ack do you know why an image would be read only? | 15:45 |
sean-k-mooney | i can only assume its a permissions issue but i woudl expect taht to affect all vms in the same tempest run | 15:46 |
gibi | sean-k-mooney: no idea. it happens during a same host resize | 15:48 |
sean-k-mooney | that does a direct snapshot of the volumn in ceph | 15:49 |
sean-k-mooney | at least when using the rbd image backend in nova | 15:50 |
gibi | FYI nova meeting starts in 10 minutes _in this channel_ | 15:50 |
sean-k-mooney | :) | 15:50 |
gibi | sean-k-mooney: yes it does a snapshot during finish_migration and that fails | 15:51 |
pjakuszew | I have a question about extra_specs mangling but I guess I will ask about it after the meeting :) | 15:52 |
sean-k-mooney | pjakuszew: we dont actully mangel extra specs in the db as far as im aware | 15:52 |
sean-k-mooney | we do prefix image properties with image_ in the system metadata table | 15:52 |
pjakuszew | uh I phrased it wrong | 15:53 |
pjakuszew | this is something I mentioned ~last week here | 15:53 |
pjakuszew | "regenerate extra_specs in requestspec" topic | 15:53 |
sean-k-mooney | regenerating the request spec? | 15:53 |
pjakuszew | yeah | 15:53 |
sean-k-mooney | we store an copy of the entire flavor as a json bob i think | 15:54 |
pjakuszew | so, I noticed that Instance.flavor seems to be a different entity stored somewhere else | 15:54 |
pjakuszew | http://paste.openstack.org/show/806638/ | 15:54 |
sean-k-mooney | in instnace_extra maybe havent checked in a while | 15:54 |
pjakuszew | and I wonder where Instance.flavor is actually stored, if it is not looked up from either RequestSpec, or the actual Flavor | 15:55 |
sean-k-mooney | pjakuszew: yes when we create an instance we make a copy of the flavor and extra specs an store a copy to use for the lifetime of the instace | 15:55 |
sean-k-mooney | to intentionally not pick up any change to extra specs that operators do after the vm is created | 15:56 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L389 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove dead code https://review.opendev.org/c/openstack/nova/+/786291 | 15:56 |
sean-k-mooney | its sotred in the instance_extra db tables as a json blob | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.sqlalchemy.utils' https://review.opendev.org/c/openstack/nova/+/786292 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove unused DB methods https://review.opendev.org/c/openstack/nova/+/786293 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy https://review.opendev.org/c/openstack/nova/+/786295 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Fold in ForeignKey constraints https://review.opendev.org/c/openstack/nova/+/786297 | 15:56 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Remove 'nova.db.base' module https://review.opendev.org/c/openstack/nova/+/786298 | 15:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Copy docs from 'nova.db.*' to 'nova.db.sqlalchemy.*' https://review.opendev.org/c/openstack/nova/+/786299 | 15:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Synchronize function signatures https://review.opendev.org/c/openstack/nova/+/786300 | 15:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Clean up migration code https://review.opendev.org/c/openstack/nova/+/786301 | 15:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Use module-level imports for sqlalchemy (for real) https://review.opendev.org/c/openstack/nova/+/796519 | 15:57 |
sean-k-mooney | lol i just realise that that is one drawback of having the meeting here | 15:57 |
pjakuszew | sean-k-mooney: huh ok, I thought that InstanceExtra was the RequestSpec actually | 15:57 |
sean-k-mooney | pjakuszew: no that is in the api db | 15:57 |
sean-k-mooney | instance extra is in the cell db | 15:58 |
sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api_models.py#L169-L181 | 15:58 |
pjakuszew | hm, okay, and what is taken into consideration when a migration is requested? | 15:58 |
pjakuszew | the cell db, or api db? | 15:58 |
sean-k-mooney | both | 15:58 |
sean-k-mooney | the flavor will come form the instance_extra table | 15:59 |
sean-k-mooney | schduler hints and other thing like az will come form teh request spec | 15:59 |
pjakuszew | right, so if I want to make it behave like new instances, should I change both objects? | 15:59 |
sean-k-mooney | but lets pick this up after the meeting | 15:59 |
pjakuszew | sure thing | 15:59 |
gibi | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Jun 15 16:00:03 2021 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
gibi | o/ | 16:00 |
gmann | o/ | 16:00 |
gibi | welcome in our new meeting venue | 16:00 |
sean-k-mooney | o/ it feels familar for some reason i woneder why :) | 16:00 |
stephenfin | could do with a lick of paint but otherwise not bad | 16:01 |
gibi | you should appreciate that you did not need to move rooms :) | 16:01 |
gibi | no uncessary walking around | 16:01 |
elodilles | o/ | 16:01 |
melwitt | meetingshed paint debate time | 16:01 |
sean-k-mooney | :) | 16:02 |
* gibi bad at colors | 16:02 | |
gibi | anyhow lets get started | 16:02 |
artom | Because it's colours ;) | 16:02 |
lyarwood | o/ | 16:02 |
gibi | ;) | 16:02 |
melwitt | openstack server create --flavour | 16:02 |
sean-k-mooney | :) that used to be in the docs | 16:03 |
sean-k-mooney | i think most people are hear now | 16:03 |
gibi | nyitottverem gep elterhozas --iz | 16:03 |
gibi | ;) | 16:03 |
gibi | if we are at linguistics | 16:03 |
stephenfin | gibi's having a stroke | 16:03 |
dansmith | o/ | 16:03 |
gibi | s/eletrhozas/letrehozas/ | 16:03 |
artom | The old channel was better, I could understand what people were saying :( | 16:03 |
artom | (Some of the time) | 16:04 |
gibi | #topic Bugs (stuck/critical) | 16:04 |
gibi | no critical onse | 16:04 |
gibi | ones | 16:04 |
gibi | #link 14 new untriaged bugs (+3 since the last meeting): #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New | 16:04 |
gibi | besides gate bugs (coming in the next topic) is there any bug we need to talk about? | 16:04 |
gibi | #topic Gate status | 16:06 |
gibi | Nova gate bugs #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure | 16:06 |
gibi | we fixed the mypy blockage but the gate is still shaky | 16:07 |
gibi | we are tracking a list of new bugs that causing intermittent failures | 16:07 |
gibi | and rechecking fixes | 16:08 |
gibi | I don't want to go through the whole list of bugs | 16:08 |
sean-k-mooney | we have made some progress on https://bugs.launchpad.net/nova/+bug/1929446 , otherwiseguy summerised some of the steps forward in https://bugs.launchpad.net/nova/+bug/1929446/comments/3 while https://review.opendev.org/c/openstack/ovsdbapp/+/795789 seams to fix it we are not going to proceedd with merging it | 16:08 |
sean-k-mooney | im going to try and implement the os-vif changes this week | 16:08 |
gibi | sean-k-mooney: it is the one that suspected to causing timeouts in live migrations? | 16:09 |
sean-k-mooney | terry is proceedign with the fix in ovs. | 16:09 |
sean-k-mooney | yes | 16:09 |
sean-k-mooney | not just live migrations | 16:09 |
sean-k-mooney | it i causeing the agent to periodically block for several seconds whenever there is a disconnection form ovs | 16:10 |
sean-k-mooney | so its likely makeing the many things flaky | 16:10 |
* melwitt majorly looks forward to that fix | 16:11 | |
gibi | sean-k-mooney: thanks | 16:11 |
gibi | any other bug needs discussion? | 16:11 |
gibi | Placement periodic jobs looks green | 16:13 |
gibi | #link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly | 16:13 |
gibi | #topic Release Planning | 16:13 |
gibi | Milestone 2 is 15 of July | 16:13 |
gibi | anything else about the release? | 16:13 |
gibi | #topic Stable Branches | 16:14 |
gibi | stable/ussuri is blocked -- fix needs to be merged: https://review.opendev.org/c/openstack/nova/+/794675 | 16:14 |
gibi | other branches should be OK | 16:14 |
gibi | stable/ocata will be EOL'd -- nova patch: https://review.opendev.org/c/openstack/releases/+/795664 | 16:14 |
gibi | EOM | 16:14 |
gibi | thanks elodilles for the summary | 16:14 |
elodilles | np | 16:15 |
gibi | anything else on stable? | 16:15 |
tosky | gibi: about that first patch, I think it's a bit more complicated, melwitt created a squashed patch with more changes | 16:15 |
tosky | but it's failing too | 16:15 |
melwitt | yeah elodilles has added a comment wrt the fail | 16:15 |
elodilles | yes, I've just commented on it as it is failing on the post tasks | 16:16 |
elodilles | :] | 16:16 |
melwitt | and yes it's a megasquash. I defer to elodilles as to how the commit message should be bc I don't know :) | 16:16 |
tosky | this one: https://review.opendev.org/c/openstack/nova/+/795432/2 (which should probably get a better combined subject) | 16:17 |
lyarwood | I missed our reasoning for doing this but as it's mostly my work I'll try to take a look before I leave today | 16:17 |
tosky | or you can preserve https://review.opendev.org/c/openstack/nova/+/794675 as it is, but set nova-live-migration as non-voting, and re-enable it in a subsequent commit | 16:17 |
tosky | which would reduce the diff and avoid a supermegasquash | 16:18 |
gibi | lyarwood: thanks | 16:18 |
melwitt | lyarwood: tl;dr is tosky recommended we backport the native zuul v3 patches instead of fixing legacy versions | 16:18 |
melwitt | so I tried to do it. it worked ok until ussuri | 16:19 |
lyarwood | ack understood | 16:19 |
tosky | it's mostly working in fact: https://review.opendev.org/c/openstack/nova/+/795432/ shows that the backported change works, but something else fails | 16:19 |
melwitt | so feel free to take another approach if it's too messy | 16:19 |
elodilles | maybe just that post task should be fixed (to avoid the supermegasquash :)) | 16:20 |
elodilles | I mean... if that is possible... | 16:20 |
elodilles | without the supermegasquash | 16:20 |
lyarwood | yeah it's possible | 16:21 |
elodilles | \o/ | 16:21 |
lyarwood | it's just because this was written against focal but the nodes here are bionic AFAICT | 16:21 |
sean-k-mooney | on ussuri? | 16:21 |
elodilles | yes, it's bionic | 16:21 |
gmann | yeah ussuri is on bionic | 16:21 |
sean-k-mooney | really ok i thought that was focal | 16:21 |
gmann | from victoria we moved to focal | 16:22 |
sean-k-mooney | hopefully that wont be hard to fix then | 16:22 |
sean-k-mooney | Could not find the requested service libvirtd-ro.socket: host | 16:22 |
sean-k-mooney | ok so likely hte service names are different | 16:22 |
sean-k-mooney | both that should be a quick fix | 16:22 |
gibi | OK I think we generated ideas about the way forwards | 16:23 |
gibi | anything else about stable? | 16:23 |
elodilles | nothing from me | 16:23 |
gibi | OK moving on | 16:24 |
gibi | skipping the libvirt subteam topic as bauzas is absent, but he said nothing to report | 16:24 |
gibi | #topic Open discussion | 16:24 |
gibi | there is one item on the agenda | 16:24 |
gibi | (yonglihe)smartnic support need one extra core reviewer , we have alex now, anyone else could help? thanks : https://review.opendev.org/c/openstack/nova/+/779913 (yongli could not attending due to time slot...) | 16:25 |
gibi | looking at the patches I think alex_xu haven't reviewed them | 16:25 |
*** ricolin_ is now known as ricolin | 16:26 | |
gibi | or at least not recently | 16:26 |
gibi | as I reviewed these in the past I can be the second core | 16:26 |
gibi | but I will wait for Alex to to the first rounds | 16:27 |
gibi | any comment? | 16:27 |
sean-k-mooney | i can proably take another look at that although i kind of wanted | 16:28 |
sean-k-mooney | someone else who can review the code to be on board with it | 16:28 |
sean-k-mooney | oh that the implemtion not the spec | 16:28 |
gibi | yep the spec is approved | 16:29 |
sean-k-mooney | well i can try and review the code i guess but maybe stephenfin or bauzas could take a look? | 16:30 |
stephenfin | I can give it a shot | 16:30 |
gibi | OK thanks I think this is more than enough :) | 16:31 |
gibi | any other topic for today? | 16:31 |
stephenfin | oh, one | 16:32 |
stephenfin | specless BP approval | 16:32 |
stephenfin | for https://blueprints.launchpad.net/nova/+spec/remove-sqlalchemy-migrate | 16:32 |
stephenfin | I thought I had done this before, but clearly not | 16:32 |
stephenfin | that's the spec to track replacing sqlalchemy-migrate with alembic | 16:32 |
sean-k-mooney | you mean blueprint | 16:33 |
sean-k-mooney | or is there actully a spec | 16:33 |
stephenfin | sorry, blueprint, yeah | 16:33 |
sean-k-mooney | i assume you want to track it as a specless blueprint | 16:33 |
sean-k-mooney | ok | 16:34 |
opendevreview | Lee Yarwood proposed openstack/nova stable/ussuri: zuul: Start to migrate nova-live-migration to zuulv3 https://review.opendev.org/c/openstack/nova/+/795432 | 16:34 |
gibi | stephenfin: do you forsee any complication that might warrant a spec? | 16:34 |
stephenfin | not at the moment, no. It's very simple if tedious so far | 16:35 |
sean-k-mooney | in the ptg we said """create a contributor doc showing how a migration will look like after the change. Document how to backport a migration to stable""" and """figure out if alembic collapsing migrations can this cause timeouts for big migrations""" | 16:35 |
stephenfin | if I encounter something that I think warrants discussion, I'll happily write one then | 16:35 |
sean-k-mooney | did we we figure out the latter | 16:35 |
stephenfin | I haven't managed to rewrite all the migrations yet, so no | 16:36 |
sean-k-mooney | i think that was the only concern we had e.g. how does it scale | 16:36 |
sean-k-mooney | ok | 16:36 |
opendevreview | Lee Yarwood proposed openstack/nova master: gate: Remove test_evacuate.sh https://review.opendev.org/c/openstack/nova/+/796523 | 16:36 |
stephenfin | though neutron's use of this suggests we'll be fine (famous last words :)) | 16:36 |
sean-k-mooney | i suspect as well as what we currently use or at least well enough for neutron | 16:36 |
stephenfin | yup | 16:36 |
sean-k-mooney | i dont really have any open quetsion that woudl warrent a spec | 16:37 |
sean-k-mooney | provided you provide the contib doc as part of the series | 16:37 |
gibi | any objection against approving it as specless bp? | 16:38 |
gibi | then it is approved | 16:39 |
gibi | any other topic for today? | 16:39 |
stephenfin | hurrah | 16:39 |
stephenfin | not from me | 16:39 |
sean-k-mooney | am one | 16:40 |
gibi | any feedback on having the meeting on this channel? | 16:40 |
sean-k-mooney | gibi: when did you want to do the next spec review day | 16:40 |
dansmith | ++ on meeting in channel :) | 16:40 |
sean-k-mooney | gibi: and i think it worked ok | 16:40 |
gmann | ++ | 16:40 |
gibi | sean-k-mooney: 6th of July maybe? | 16:40 |
stephenfin | meeting in the channel seems sensible so far, yup | 16:41 |
sean-k-mooney | ya that gives a few days befor m2 on the 12th | 16:41 |
gibi | that is a bit more than a week before the freeze | 16:41 |
sean-k-mooney | so works for me | 16:41 |
stephenfin | as does that date | 16:41 |
sean-k-mooney | oh m2 is the 15th | 16:42 |
sean-k-mooney | ya | 16:42 |
sean-k-mooney | ok that was all i wanted to ask | 16:42 |
gibi | if nothing else then thanks for joining. | 16:42 |
gibi | I give the channel back :) | 16:42 |
gibi | #endmeeting | 16:42 |
opendevmeet | Meeting ended Tue Jun 15 16:42:57 2021 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:42 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.html | 16:42 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.txt | 16:42 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2021/nova.2021-06-15-16.00.log.html | 16:42 |
sean-k-mooney | pjakuszew: im going to get somethign to drink but if you have more question regarding the embeded flavor feel free to ask them | 16:43 |
sean-k-mooney | brb | 16:43 |
gibi | fyi I noticed a new version of the wierd pip version conflict, now with paramiko. Added the info to https://bugs.launchpad.net/nova/+bug/1931864 | 16:46 |
pjakuszew | sean-k-mooney: just one, should I change both Instance.flavor.extra_specs and RequestSpec.flavor.extra_specs to the new ones from Flavor, if I want the instance migration to work in the same way as the new instances with that modified flavor | 16:46 |
pjakuszew | i.e. if I added 'foo':'bar' to flavor extra_specs, should I modify both Instance and RequestSpec so migrations behave in the same way as for new instances which have these specs already | 16:47 |
pjakuszew | this is all assuming that I have enabled InstanceAggregateExtraSpecs scheduler filter and now I want the old instance migrations to behave like the new ones | 16:49 |
sean-k-mooney | yes you would have to update both | 16:52 |
sean-k-mooney | the request spec flavor is used for schduling but the instinace.flavor is used form cretating the vm xml | 16:52 |
sean-k-mooney | but it depends on your goal | 16:52 |
sean-k-mooney | if you only wanted to sync the extra spec use for the InstanceAggregateExtraSpecs filter technically only the request spec flavor would need to be updated | 16:53 |
pjakuszew | right, though it wouldn't probably hurt to also have the Instance flavor in-sync, just to keep things "clean" | 16:54 |
sean-k-mooney | am is your pimary usecase the InstanceAggregateExtraSpecs filter | 16:55 |
sean-k-mooney | if so you could limit the extra spec update to just those that are prefixed with aggregate_instance_extra_specs | 16:55 |
sean-k-mooney | pjakuszew: the main issue is the two flavor opies are stored in different databases | 16:56 |
sean-k-mooney | so you cant update both in the same transaction i bleive | 16:56 |
pjakuszew | it shouldn't be a big issue in this situation | 16:58 |
pjakuszew | ok, then my main focus is requestspec flavor object | 16:58 |
sean-k-mooney | the main thing you would have to do is look up the cell/instance maping to know which db to update it in for the instnace copy | 16:58 |
sean-k-mooney | i would start with the request spec yes and preferably limit it to extra specs that are used by that filter | 16:59 |
sean-k-mooney | so extra specs with aggregate_instance_extra_specs: or no namespeace | 16:59 |
sean-k-mooney | if you wanted all extra specs to be updated via nova manage in this way i think you would have to update the copy in instnace_extra also | 17:00 |
pjakuszew | yes I have some preliminary version of that added into nova-manage locally for tests | 17:02 |
pjakuszew | in current form it iterates over InstanceList and does 'if instance.flavor.extra_specs != flavor.extra_specs: instance.flavor.extra_specs = flavor.extra_specs; instance.save()' | 17:03 |
pjakuszew | that was before we talked | 17:04 |
pjakuszew | now I know that reqspec.flavor.extra_specs = flavor.extra_specs is the way | 17:05 |
pjakuszew | and there's a separate command which prints a table of instances that don't have extra_specs matching their flavors | 17:09 |
pjakuszew | sean-k-mooney: thanks for the help, it is now more clear to me | 17:11 |
*** ricolin_ is now known as ricolin | 17:32 | |
opendevreview | sean mooney proposed openstack/nova-specs master: [WIP] pci device tracking in placment https://review.opendev.org/c/openstack/nova-specs/+/791047 | 18:50 |
opendevreview | Merged openstack/nova stable/wallaby: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/794328 | 18:55 |
opendevreview | Merged openstack/nova master: Remove references to 'inst_type' https://review.opendev.org/c/openstack/nova/+/778548 | 21:47 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!