| opendevreview | Merged openstack/nova stable/victoria: rbd: Get rbd_utils unit tests running again https://review.opendev.org/c/openstack/nova/+/794624 | 02:39 |
|---|---|---|
| opendevreview | Merged openstack/nova stable/victoria: Initialize global data separately and run_once in WSGI app init https://review.opendev.org/c/openstack/nova/+/785059 | 02:40 |
| opendevreview | Merged openstack/nova stable/train: Add missing exception https://review.opendev.org/c/openstack/nova/+/763393 | 03:30 |
| sean-k-mooney | gmann: thanks i just did not want it showing up in my endpoint list so i just delete the endpoint and tweaked my gloabl.yaml so that kolla would not recreate it | 03:55 |
| opendevreview | sean mooney proposed openstack/os-vif master: update os-vif ci to account for devstack default changes https://review.opendev.org/c/openstack/os-vif/+/798038 | 05:15 |
| opendevreview | sean mooney proposed openstack/os-vif master: update os-vif ci to account for devstack default changes https://review.opendev.org/c/openstack/os-vif/+/798038 | 05:16 |
| opendevreview | sean mooney proposed openstack/os-vif master: update os-vif ci to account for devstack default changes https://review.opendev.org/c/openstack/os-vif/+/798038 | 05:19 |
| opendevreview | Jorhson Deng proposed openstack/nova master: recheck the attachment_id after the reschedule successful https://review.opendev.org/c/openstack/nova/+/796209 | 06:28 |
| opendevreview | Jorhson Deng proposed openstack/nova master: To deal instance with soft-deleting in _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | 07:13 |
| *** rpittau|afk is now known as rpittau | 07:15 | |
| opendevreview | Jorhson Deng proposed openstack/nova master: To deal instance with soft-deleting in _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | 07:16 |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 07:49 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 07:49 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 07:49 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 07:49 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 07:49 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | 07:49 |
| opendevreview | Jorhson Deng proposed openstack/nova master: process instance in soft-deleting task state during _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | 07:55 |
| opendevreview | Jorhson Deng proposed openstack/nova master: process instance in soft-deleting task state during _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | 07:57 |
| opendevreview | sean mooney proposed openstack/os-vif master: [WIP] add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/798055 | 07:57 |
| opendevreview | Yongli He proposed openstack/nova master: Smartnic support - cyborg drive https://review.opendev.org/c/openstack/nova/+/771362 | 08:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - new vnic type https://review.opendev.org/c/openstack/nova/+/771363 | 08:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support https://review.opendev.org/c/openstack/nova/+/758944 | 08:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - cleanup arqs https://review.opendev.org/c/openstack/nova/+/798054 | 08:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - reject server move and suspend https://review.opendev.org/c/openstack/nova/+/779913 | 08:06 |
| opendevreview | Yongli He proposed openstack/nova master: smartnic support - functional tests https://review.opendev.org/c/openstack/nova/+/780147 | 08:06 |
| opendevreview | sean mooney proposed openstack/os-vif master: [WIP] add configurable per port bridges https://review.opendev.org/c/openstack/os-vif/+/798055 | 08:08 |
| opendevreview | Lee Yarwood proposed openstack/nova master: compute: Avoid calling detach with src connection_info during LM rollback https://review.opendev.org/c/openstack/nova/+/797725 | 09:00 |
| opendevreview | Elod Illes proposed openstack/nova stable/ussuri: [CI] Fix gate by using zuulv3 live migration and grenade jobs https://review.opendev.org/c/openstack/nova/+/795432 | 09:44 |
| elodilles | lyarwood: as the ussuri gate fixing supermegasquash did not pass I decided to update the commit message (maybe it's a bit easier to track what happened in it) | 09:48 |
| opendevreview | Jorhson Deng proposed openstack/nova master: process instance in soft-deleting task state during _init_instance https://review.opendev.org/c/openstack/nova/+/761264 | 09:49 |
| elodilles | lyarwood: it's really just a commit message update. so if you will have time then please review it o:) | 09:49 |
| elodilles | melwitt: ^^^ | 09:49 |
| lyarwood | elodilles: ack will do, melwitt is out this week btw | 10:08 |
| stephenfin | elodilles: mel is out all this week | 10:08 |
| stephenfin | jinx | 10:08 |
| stephenfin | gibi: Can we update the os-vif stable core team to include os-vif core now? We discussed during the team meeting a few weeks back and had no disagreements from what I can recall | 10:10 |
| stephenfin | assuming you have the power to do so | 10:10 |
| gibi | stephenfin: let me see | 10:14 |
| elodilles | lyarwood stephenfin : ok, thanks for the info :) | 10:15 |
| gibi | stephenfin: I did not find the meeting where we discussed that change | 10:20 |
| stephenfin | hmm, maybe it was here so | 10:22 |
| * stephenfin searches through logs | 10:22 | |
| gibi | and also I dont see a os-vif stable group in gerrit | 10:22 |
| stephenfin | we started discussing it here https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2021-06-02.log.html#t2021-06-02T12:42:10 | 10:22 |
| stephenfin | we also discussed it here https://meetings.opendev.org/irclogs/%23openstack-nova/%23openstack-nova.2021-06-14.log.html#t2021-06-14T11:09:39 | 10:23 |
| stephenfin | now did we discuss it in the interim :) | 10:23 |
| gibi | OK so it is a bit more complicated | 10:24 |
| gibi | as there is no stable group for os-vif in gerrit | 10:24 |
| gibi | or I dont see it | 10:25 |
| gibi | elodilles: do you know who has approve rights now on os-vif stable? | 10:25 |
| stephenfin | gibi: looks like it's nova-stable-maint https://github.com/openstack/project-config/blob/master/gerrit/acls/openstack/os-vif.config | 10:27 |
| stephenfin | plus stable-maint-core | 10:27 |
| stephenfin | so if we wanted to do this, we'd simply add os-vif-core to that list | 10:27 |
| stephenfin | gibi: will I post to openstack-discuss about this, or do you want to? | 10:27 |
| gibi | stephenfin: go ahead and post this on ML and then I reply that we should do it | 10:30 |
| gibi | can we simply propose the acl change in gerrit review against the linked project config? | 10:30 |
| stephenfin | I think so, yes | 10:31 |
| opendevreview | Lee Yarwood proposed openstack/nova master: DNM: Test libvirtd with increased keepalive_interval https://review.opendev.org/c/openstack/nova/+/798069 | 10:32 |
| gibi | stephenfin: cool, then could you propose the patch too/ | 10:32 |
| gibi | ? | 10:32 |
| stephenfin | make sense. Will do | 10:33 |
| gibi | thanks | 10:34 |
| lyarwood | gibi: ^ the LM with volumes attached failures continue even after the os-vif workaround in devstack, I'm going to see if playing around with the keepalive_interval helps in libvirtd | 10:38 |
| lyarwood | gibi / stephenfin ; https://review.opendev.org/q/topic:nova-centos-8-stream - could I get some reviews on this series, tl;dr we are trying to use more upstream zuul infra downstream and given centos 8 stream is a supported base OS we wanted to get it covered in the upstream gate | 10:46 |
| stephenfin | sure, I'll look shortly | 10:47 |
| *** akekane_ is now known as abhishekk | 10:49 | |
| lyarwood | ta | 10:51 |
| *** rpittau is now known as rpittau|bbl | 11:17 | |
| opendevreview | Merged openstack/nova master: db: Use module-level imports for sqlalchemy https://review.opendev.org/c/openstack/nova/+/786295 | 12:10 |
| gibi | lyarwood: ack | 12:20 |
| gibi | lyarwood: did we merged the os-vif WA? | 12:20 |
| sean-k-mooney | gibi: i think so. | 12:22 |
| sean-k-mooney | gibi: yes https://review.opendev.org/c/openstack/devstack/+/796826 | 12:22 |
| sean-k-mooney | that is merged | 12:23 |
| sean-k-mooney | gibi: is it helping | 12:23 |
| sean-k-mooney | thats only on master actully we could backport that | 12:23 |
| sean-k-mooney | gibi: i spoke to otherwiseguy about this last night and they have repoduced the issue and a plocibel fix | 12:24 |
| sean-k-mooney | gibi: https://gist.github.com/otherwiseguy/af8f6ede8a09ccf5cef259c93bb00792 | 12:24 |
| sean-k-mooney | that evenlet.sleep will fix it https://gist.github.com/otherwiseguy/af8f6ede8a09ccf5cef259c93bb00792#file-test_eventlet_reconnect-py-L17 | 12:25 |
| gibi | ack | 12:25 |
| gibi | lyarwood: does the os-vif WA helped decreasing the LM issue but not fully avoidet it? | 12:27 |
| gibi | decreasing the frequency | 12:27 |
| sean-k-mooney | gibi: i think lyarwood is a way for a while just an fyi but he will see that when he gets back | 12:28 |
| gibi | sean-k-mooney: thanks | 12:31 |
| opendevreview | Luigi Toscano proposed openstack/nova stable/ussuri: Remove broken legacy zuul jobs https://review.opendev.org/c/openstack/nova/+/795374 | 12:44 |
| tosky | now that https://review.opendev.org/c/openstack/nova/+/795432/ seems to pass (just need a new +2!), I suspect 795374 may work too | 12:47 |
| *** rpittau|bbl is now known as rpittau | 12:56 | |
| opendevreview | Merged openstack/nova master: db: Fold in indexes https://review.opendev.org/c/openstack/nova/+/786296 | 12:57 |
| ganso | lyarwood, elodilles: Could you please re-workflow https://review.opendev.org/c/openstack/nova/+/795432 now that the CI has passed? | 13:08 |
| elodilles | ganso: I'll let lyarwood approve that, as I was who updated the commit message | 13:23 |
| *** rpittau is now known as rpittau|afk | 14:47 | |
| gibi | I hate that I can only choose between a) duplicate the qos functional test to cover pps, b) reimplement a lot of production logic in the test to have dynamic asserts that works both for the old resource request format and the new one. | 14:54 |
| sean-k-mooney | c) dont have tests and just assume its broken? | 14:56 |
| sean-k-mooney | cause that my default when a or b is not done :) | 14:57 |
| gibi | it is in the state of broken now, as I have a buch of TODOs to fix before the new resource request format and logic start fully working. So I've already achieved c) :D | 14:57 |
| gibi | and with simple changes in the production logic I can make some scenarios work, but when I want to add test coverage to it I end up hating any solution I come up with | 14:58 |
| sean-k-mooney | can you point me at the test quickly | 14:58 |
| sean-k-mooney | im going to finsih shortly but maybe something will occure to me | 14:59 |
| sean-k-mooney | this one https://review.opendev.org/c/openstack/nova/+/787205 | 15:00 |
| sean-k-mooney | oh you have them spread over multiple patches | 15:00 |
| sean-k-mooney | o/ | 15:03 |
| gibi | sean-k-mooney: I can make https://review.opendev.org/c/openstack/nova/+/792394/9/nova/tests/functional/test_servers.py#6770 scenario to work locally with some modification in nova's neutron client code. But when I want to make that test actually pass I have to blow up the original test case to modify the asserts | 15:03 |
| gibi | sean-k-mooney: have a nice weekend | 15:03 |
| sean-k-mooney | ah ya i was looking at that | 15:04 |
| sean-k-mooney | but did not see really what it was doiing | 15:04 |
| sean-k-mooney | when you said neutron cleint code do you mean realy code or fixtures | 15:04 |
| sean-k-mooney | i assume /nova/network/neutron.py | 15:05 |
| gibi | that one ^^ | 15:05 |
| sean-k-mooney | ok if it was just the fixture i woudl have jsut said make two | 15:05 |
| gibi | I have multiple fixtures to support old and new resource request format | 15:06 |
| gibi | that is a relatively small duplication | 15:06 |
| gibi | https://review.opendev.org/c/openstack/nova/+/794306/2 | 15:06 |
| gibi | and here https://review.opendev.org/c/openstack/nova/+/792394/9/nova/tests/fixtures/neutron.py | 15:06 |
| gibi | the test logic, especially the the asserts needs to be changed as a) there will be more allocations b) the bindig profile allocation key changes format | 15:07 |
| gibi | I could pull out all the asserts to functions and override the functions in the child test class according to the new needs | 15:09 |
| gibi | it just probably needs a lot of refactoring, and a way to foresee how all assert will look like in the with the new resource request format in place | 15:10 |
| gibi | to know what direction to refactor to | 15:10 |
| sean-k-mooney | it might be simpler to just duplicate things | 15:11 |
| sean-k-mooney | and if you have time later see if the commonality can be abstrated | 15:11 |
| gibi | yeah that is one way to go | 15:12 |
| sean-k-mooney | rather then trying to do both up front | 15:12 |
| gibi | if i copy paste, then I need some reminder not to forget to abstract things out later | 15:12 |
| gibi | as I will be lazy | 15:12 |
| gibi | so not a reminder like a # TODO, but a reminder like a pain in the ass | 15:13 |
| sean-k-mooney | have a test that emails you every time it runs :P | 15:13 |
| gibi | :D | 15:14 |
| sean-k-mooney | duplication when its not extream i think is ok | 15:14 |
| gibi | yeah, in test I allow duplication if in return it helps seeing the test scenario cleanly | 15:16 |
| gibi | I'm affraid there will be extreme copy past now to have all the server create scenarios and then all the server move scenarios covered | 15:16 |
| gibi | ~1000 LOC | 15:16 |
| gibi | anyhow you are right If I cannot predic which direction I should refactor then probably I need to duplicate first | 15:17 |
| opendevreview | Merged openstack/nova master: tests: Allow bindep and test-setup.sh to run on EL distros https://review.opendev.org/c/openstack/nova/+/796428 | 15:17 |
| opendevreview | Merged openstack/nova master: zuul: Add nova-tox-functional-centos8-py36 job https://review.opendev.org/c/openstack/nova/+/796684 | 15:40 |
| opendevreview | Elod Illes proposed openstack/nova stable/stein: compute: Validate a BDMs disk_bus when provided https://review.opendev.org/c/openstack/nova/+/744554 | 16:19 |
| gibi | stephenfin: can we release https://review.opendev.org/c/openstack/oslo.db/+/797426 so that nova can benefit from the silence deprecation warning? | 16:24 |
| stephenfin | gibi: sure | 16:24 |
| stephenfin | I'll ping hberaud | 16:25 |
| stephenfin | in a call atm | 16:25 |
| gibi | cool, thanks | 16:25 |
| opendevreview | Elod Illes proposed openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/c/openstack/nova/+/757084 | 16:37 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | 16:41 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | 16:42 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | 16:43 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 16:45 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 16:46 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 16:47 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 16:49 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 16:50 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 16:51 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 16:53 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Support the new port resource_request format https://review.opendev.org/c/openstack/nova/+/787208 | 16:54 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 16:56 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 16:57 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 16:59 |
| opendevreview | Rodrigo Barbieri proposed openstack/nova stable/ussuri: Error anti-affinity violation on migrations https://review.opendev.org/c/openstack/nova/+/796719 | 17:10 |
| opendevreview | Elod Illes proposed openstack/nova stable/victoria: Stop leaking ceph df cmd in RBD utils https://review.opendev.org/c/openstack/nova/+/791938 | 17:51 |
| opendevreview | Stephen Finucane proposed openstack/nova master: WIP: api: Validate host belongs to availability zone https://review.opendev.org/c/openstack/nova/+/798145 | 18:02 |
| stephenfin | gibi: bauzas: Would appreciate input on https://review.opendev.org/c/openstack/nova/+/798145 on Monday, just so I know I'm not wasting my time on that solution. I'll write up a bug if there isn't one already available | 18:03 |
| * stephenfin finishes for the weekend o/ | 18:03 | |
| opendevreview | Merged openstack/nova stable/train: Add a workaround config toggle to refuse ceph image upload https://review.opendev.org/c/openstack/nova/+/757177 | 19:30 |
| opendevreview | Merged openstack/nova stable/train: Use absolute path during qemu img rebase https://review.opendev.org/c/openstack/nova/+/757084 | 23:11 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!