opendevreview | melanie witt proposed openstack/placement master: Add consumer_types migration, database and object changes https://review.opendev.org/c/openstack/placement/+/669170 | 01:34 |
---|---|---|
opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | 01:34 |
opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 01:34 |
melwitt | gibi: finally I have an update for consumer types https://review.opendev.org/c/openstack/placement/+/679441 sorry for the long delay | 01:40 |
opendevreview | Merged openstack/nova-specs master: Move placement specs to placement repo https://review.opendev.org/c/openstack/nova-specs/+/800775 | 07:15 |
gibi | melwitt: OK, I've added it to my queue | 07:20 |
gibi | melwitt: I have the RP re-parenting patch ready too https://review.opendev.org/c/openstack/placement/+/784020 | 07:21 |
gibi | if you have time | 07:22 |
*** rpittau|afk is now known as rpittau | 07:49 | |
*** bhagyashris_ is now known as bhagyashris | 08:05 | |
opendevreview | Lee Yarwood proposed openstack/nova master: libvirt: Handle silent failures to extend volume within os-brick https://review.opendev.org/c/openstack/nova/+/801714 | 08:10 |
stephenfin | lyarwood: Could you review a few outstanding docs changes for me today? https://review.opendev.org/c/openstack/nova/+/782410/1 | 09:12 |
lyarwood | stephenfin: sure thing | 09:13 |
stephenfin | Thanks. I addressed your comments in that one specifically too, gibi ^ | 09:13 |
gibi | stephenfin: ack | 09:13 |
stephenfin | bauzas: In case you didn't see it, I addressed your issues on https://review.opendev.org/c/openstack/nova/+/798145 with a follow-up https://review.opendev.org/c/openstack/nova/+/801523 | 09:19 |
bauzas | stephenfin: ok, will look | 09:19 |
bauzas | and thanks | 09:19 |
opendevreview | Sylvain Bauza proposed openstack/nova master: DNM (yet) : Expose the mdev class https://review.opendev.org/c/openstack/nova/+/801743 | 09:25 |
lyarwood | https://github.com/openstack/nova/blob/3545356ae3a719442833cb8c3c911408d4bd3c15/nova/conductor/manager.py#L166-L184 - This is likely a stupid idea but why aren't we logging anything here as breadcrumbs for RPC timeouts etc? | 09:26 |
lyarwood | Have an example downstream of a bdm.save() timing out on the compute and I've got no way of seeing what n-cond was doing AFAICT | 09:26 |
lyarwood | I guess any breadcrumbs need to land in the actual object methods being exercised | 09:28 |
sean-k-mooney | ya i dont know really | 09:29 |
sean-k-mooney | i guess one question would be where | 09:29 |
sean-k-mooney | as in in what log would they end up | 09:30 |
sean-k-mooney | the api/conductor wont know where it actuly got too | 09:30 |
lyarwood | it should end up in n-cond right? | 09:30 |
lyarwood | almost need a TRACE log level below DEBUG for stuff like this | 09:31 |
gibi | stephenfin: what should I do to enable ':oslo.config:option:' directive in the api-guide doc build? I've added 'oslo_config.sphinxext' extension to the config but it fails with https://paste.opendev.org/show/807644/ | 09:34 |
*** bhagyashris_ is now known as bhagyashris | 09:35 | |
lyarwood | nvm another n-cond log is full of `Too many heartbeats missed` errors from oslo.msg | 09:40 |
lyarwood | really wish gerrit had a `move the unified diff to the middle of your giant ass screen` option | 10:10 |
stephenfin | gibi: You'd need to render the config options somewhere like we do here https://raw.githubusercontent.com/openstack/nova/master/doc/source/configuration/config.rst | 10:12 |
stephenfin | (the '.. show-options::' directive) | 10:13 |
stephenfin | which we probably don't want to do. We could build something that relies on intersphinx to link back to the main docs but that doesn't exist yet | 10:13 |
opendevreview | Stephen Finucane proposed openstack/nova master: neutron: Remove references to dead 'qos-queue' extension https://review.opendev.org/c/openstack/nova/+/754448 | 10:43 |
stephenfin | gibi: turns out that extension was used by the VMWare NSX neutron plugin, but they dropped it about two years ago. Have updated the commit message to state as much ^ | 10:44 |
sean-k-mooney | stephenfin: nice find | 11:35 |
sean-k-mooney | stephenfin: im kind of surpised we have any third party exstions reference in nova | 11:36 |
sean-k-mooney | at least on the common code. i would have expect those constance to live in teh vmware dirver | 11:37 |
sean-k-mooney | do we know if vnic-index is used still | 11:37 |
opendevreview | Stephen Finucane proposed openstack/nova master: db: Final cleanups https://review.opendev.org/c/openstack/nova/+/800484 | 11:44 |
stephenfin | sean-k-mooney: vnic-index? | 11:45 |
stephenfin | oh, wait, yeah | 11:45 |
stephenfin | hmm, probably not actually | 11:45 |
gibi | stephenfin: re sphinx: OK, then I stop fighting with sphinx :) | 11:45 |
stephenfin | sean-k-mooney: actually no, it's still there https://opendev.org/x/vmware-nsx/src/branch/master/vmware_nsx/extensions/vnicindex.py | 11:46 |
stephenfin | whether it actually works is a different thing of course | 11:46 |
gibi | stephenfin: I'm +2 on the QoS extension removal | 11:47 |
stephenfin | hurrah | 11:48 |
stephenfin | thanks gibi++ | 11:48 |
gibi | stephenfin: I'm fixing your comments in the pps series I hope I can push it today | 11:48 |
gibi | moving around the func test was a nice exercise :) | 11:49 |
* gibi loves sweedish summer time when there is no internal meetings and no interrupts | 11:49 | |
stephenfin | yeah, it felt like the right thing to do | 11:50 |
gibi | yepp, it is much better now. and pycharm is glad not to reparse the whole test_servers.py when I edit something in the func tests | 11:51 |
stephenfin | fair to say that 5kloc+ files are a thing best avoided where possible. 5kloc+ *test* files are 100% worth avoiding :) | 11:51 |
stephenfin | \o/ | 11:51 |
gibi | I hope not just me but jetbrains using the nova codebase to performance test pycharm :D | 11:52 |
stephenfin | there a few projects that could benefit from using nova as a test bed | 11:53 |
gibi | :D | 11:53 |
stephenfin | gitea for one | 11:53 |
gibi | we should promote that as a goal of nova :D being big and complicated python codebase for "you" to test your python tooling on | 11:54 |
stephenfin | don't know if you clicked through the links on the nsx-mh removal patch but it basically crashed my browser | 11:54 |
stephenfin | GitHub (smartly) refuses to render large files by default | 11:54 |
stephenfin | lol | 11:54 |
gibi | mine is not crashed (yet) | 11:55 |
opendevreview | Stephen Finucane proposed openstack/nova master: tox: Encode specific Python versions https://review.opendev.org/c/openstack/nova/+/797054 | 12:12 |
sean-k-mooney | anyone ohter then stephenfin have time to reivew an os-vif patch https://review.opendev.org/c/openstack/os-vif/+/798055 | 12:39 |
*** elodilles is now known as elodilles_afk | 12:48 | |
gibi | sean-k-mooney: done | 12:54 |
gibi | incoming... | 12:56 |
sean-k-mooney | thanks im finsihing up some testing downstream this week ill be working on some other os-vif patches next week and ill start with a followup for the nits | 12:56 |
sean-k-mooney | pps series? | 12:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] create pps resource on OVS agent RP https://review.opendev.org/c/openstack/nova/+/787205 | 12:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port creation to the NeutronFixture https://review.opendev.org/c/openstack/nova/+/787206 | 12:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] neutron fixture for extended resource request https://review.opendev.org/c/openstack/nova/+/794306 | 12:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Detect extended_resource_request neutron API extension https://review.opendev.org/c/openstack/nova/+/793618 | 12:56 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move port resource request tests https://review.opendev.org/c/openstack/nova/+/801815 | 12:56 |
gibi | sean-k-mooney: yepp, pps :D | 12:58 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server create with extended resource req https://review.opendev.org/c/openstack/nova/+/793619 | 13:00 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Reject server operations with extended resource req https://review.opendev.org/c/openstack/nova/+/793620 | 13:00 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Add same_subtree field to RequestLevelParams https://review.opendev.org/c/openstack/nova/+/791503 | 13:04 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Bump min placement microversion to 1.36 https://review.opendev.org/c/openstack/nova/+/791504 | 13:05 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support same_subtree in allocation_canadidate query https://review.opendev.org/c/openstack/nova/+/791505 | 13:05 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor assertPortMatchesAllocation https://review.opendev.org/c/openstack/nova/+/792458 | 13:05 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor asserts in qos tests https://review.opendev.org/c/openstack/nova/+/798930 | 13:09 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] ports with both bw and pps resources https://review.opendev.org/c/openstack/nova/+/792394 | 13:10 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Parse extended resource request from the port data https://review.opendev.org/c/openstack/nova/+/800085 | 13:12 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 13:13 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | 13:14 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | 13:16 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | 13:17 |
bauzas | stephenfin: awesome ! thanks for the FUP <3 | 13:18 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 13:18 |
gibi | and I f*ck up the rebase at some point and lost a patch in the series :/ | 13:22 |
sean-k-mooney | hopefully you have it localy | 13:26 |
gibi | git reflog has it | 13:27 |
gibi | I basically merged two subseqent commit together | 13:28 |
gibi | in the series | 13:28 |
gibi | during the rebase | 13:28 |
gibi | I hate that git does not warn against commit --amend when during interactive rebase it stops at the commit both because it marked as edit and becuase it has a merge conflict | 13:38 |
belmoreira | Hello everyone... I have a question regarding DBs... but also related with nova :) | 13:39 |
sean-k-mooney | well thats becasue you can do commit --amend for valid reasons | 13:39 |
sean-k-mooney | with an interactive rebase | 13:39 |
sean-k-mooney | but yes i have done that too | 13:39 |
gibi | sean-k-mooney: yeah, but not during a conflict resolution I guess | 13:39 |
sean-k-mooney | belmoreira: nova does have them | 13:39 |
sean-k-mooney | gibi: i have used it where i was not finsihed with the full resolution | 13:39 |
belmoreira | sean-k-mooney :) | 13:40 |
sean-k-mooney | then came back | 13:40 |
belmoreira | We will need to move some nova DBs from mysql 5.7.x to 8.x. Our DB team was testing this DB migration and a character convertion is required (utf8mb3 -> utf8mb4) | 13:40 |
belmoreira | Apparently utf8 in mysql 8.x uses 4 bytes instead of 3 bytes (like previously) | 13:40 |
sean-k-mooney | belmoreira: nova currently does not supeciric any charicterset or coalation type in our schema | 13:40 |
sean-k-mooney | belmoreira: utf8 in gereal uses between 1 an 4 bytes depending on the charater | 13:41 |
belmoreira | sean-k-mooney right | 13:41 |
belmoreira | my concern is that they reported that (silent) changes of data types can happen, for example from TEXT to MEDIUMTEXT to allow the column to accommodate the original data using 4bytes for each character instead of 3. For similar reasons we could also potentially hit the innodb index key max size... | 13:42 |
belmoreira | Is there something that you are aware? Or this should be safe for Nova | 13:43 |
sean-k-mooney | i think nova largely should not care but im not sure. | 13:44 |
sean-k-mooney | nova likely should jsut use utf_8_bin | 13:44 |
sean-k-mooney | at some point | 13:44 |
sean-k-mooney | https://en.wikipedia.org/wiki/UTF-8#MySQL_utf8mb3 | 13:45 |
belmoreira | thanks sean-k-mooney | 13:46 |
sean-k-mooney | we do use mediumetext in somplaces | 13:47 |
sean-k-mooney | in general nova does not allow you to change the column data types form what we have in the schema | 13:48 |
sean-k-mooney | btu the encoding i dont think will break anything | 13:48 |
sean-k-mooney | belmoreira: are they plannign to actully modify the types in the tables | 13:49 |
sean-k-mooney | we generally are allowing sqlalchmy to mange the filed types | 13:50 |
belmoreira | I'm afraid to just discover some of these changes in prod. Anyway I will try to test it as much as possible and I will let you know if I discover something | 13:50 |
belmoreira | sean-k-mooney no they will not explicitly change the schema but they say it can happen when moving to utf8mb4 | 13:51 |
sean-k-mooney | well text files unlike nvarcars are not actully stored in the db correct | 13:51 |
belmoreira | I'm learning about all of this utf8 encoding :) | 13:51 |
sean-k-mooney | they are stored as sepereate files | 13:51 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Transfer RequestLevelParams from ports to scheduling https://review.opendev.org/c/openstack/nova/+/791506 | 13:51 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support boot with extended resource request https://review.opendev.org/c/openstack/nova/+/800086 | 13:51 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support move ops with extended resource request https://review.opendev.org/c/openstack/nova/+/800087 | 13:52 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] refactor interface attach with qos https://review.opendev.org/c/openstack/nova/+/800088 | 13:52 |
sean-k-mooney | we use string https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L256 when we wnat fixed lenght nvarchar columns | 13:52 |
belmoreira | I think the best is to do the conversion of a test DB and I will go manually through the schema. Maybe at the end there is nothing about this | 13:53 |
sean-k-mooney | ya | 13:54 |
sean-k-mooney | but ya just confirm that text filds are stored off table https://www.navicat.com/en/company/aboutus/blog/1308-choosing-between-varchar-and-text-in-mysql | 13:55 |
sean-k-mooney | belmoreira: where the issue might happen | 13:55 |
sean-k-mooney | would be for user-data | 13:56 |
sean-k-mooney | text field cans sture up to 64k fo data | 13:56 |
belmoreira | sean-k-mooney thanks a lot. I will let you know if something comes up | 13:57 |
sean-k-mooney | user-data is defiened to be medium text already https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L288 | 13:57 |
opendevreview | Balazs Gibizer proposed openstack/nova master: Support interaface attach / detach with new resource request format https://review.opendev.org/c/openstack/nova/+/800089 | 13:57 |
sean-k-mooney | so it should not need to be upgraded but ya let us know | 13:57 |
opendevreview | Balazs Gibizer proposed openstack/nova master: [func test] move unshelve test to the proper place https://review.opendev.org/c/openstack/nova/+/793621 | 13:58 |
sean-k-mooney | MediumText can store 16 MB but we limit the user-data to 64k i belive in the api so it should fit thats the only filed that is likely to get close to 64k i think so hopefully it will just work out | 13:58 |
gibi | stephenfin:I've fixed your comments in the pps series | 14:04 |
gibi | I think we have a gate block due to https://zuul.opendev.org/t/openstack/builds?job_name=openstacksdk-functional-devstack&project=openstack/nova | 14:07 |
gibi | coudl be due to https://review.opendev.org/c/openstack/cinder/+/792299 | 14:08 |
gibi | moving to cinder ... | 14:09 |
lyarwood | Yeah you should be able to drop the v2 tests from osc now on master | 14:14 |
lyarwood | the sdk even sorry | 14:15 |
gibi | lyarwood: hm, good point, these are v2 tests | 14:16 |
gibi | then I'm going to delete them ... | 14:16 |
*** elodilles_afk is now known as elodilles | 14:34 | |
gibi | lyarwood: fyi, here is the removal of those tests https://review.opendev.org/c/openstack/openstacksdk/+/801864 | 14:38 |
sean-k-mooney | gibi: how did the v2 removal impact the nova gate by the way | 15:00 |
sean-k-mooney | https://review.opendev.org/c/openstack/openstacksdk/+/801864 should not affefct us right | 15:01 |
melwitt | gibi: thanks! and ack, will check the re-parenting | 15:03 |
gibi | sean-k-mooney: we gate on openstacksdk-functional-devstack job that started failing as it runs against a devstack and trying to find block storage v2 | 15:03 |
lyarwood | sean-k-mooney: I don't think it did | 15:04 |
lyarwood | sean-k-mooney: all of our cinderv2 stuff goes through cinderv3 now anyway | 15:04 |
sean-k-mooney | gibi: oh it is | 15:06 |
lyarwood | gibi: re osc, sorry I'm not trying to be difficult but I think we can just exclude these tests for now | 15:14 |
gibi | lyarwood: sure no worries. I #openstack-sdks gtema said he will inventigate a better way to fix this so I defer to him | 15:17 |
lyarwood | gibi: ah sorry I'm not in that channel, sounds good :) | 15:17 |
gibi | yeah it is in good hands now :) | 15:17 |
gibi | 12 | 15:26 |
gibi | ups | 15:26 |
gibi | melwitt: re consumer_types: so you created one transaction that containst both the ensure_consumer and the Allocation.replace_all calls | 15:26 |
gibi | melwitt: with a @db_api.placement_context_manager.writer decorator on the top. | 15:27 |
melwitt | gibi: yes, put both calls into a helper function decorated with the database context manager (this initiates the session/transaction) | 15:27 |
melwitt | it took me a long time to arrive at that because previously I was looking at the wrong code path for a different "set allocations" path that was already a single transaction /o\ | 15:28 |
gibi | melwitt: and later on when the ensure_consumer or the Allocation.replace_all calls the db_api.placement_context_manager.writer again then it won't start a separate transaction as the new, bigger one, is already started. Is it how the nested db decorator works? | 15:28 |
melwitt | gibi: right, it will check whether there is a session already created and if not it creates a new one (which will be a new transaction). if it finds a session already there, it will use that and that's how the nested things get connected. the session is an attribute on the RequestContext | 15:32 |
gibi | melwitt: awesome, thanks for the explanation | 15:33 |
melwitt | so you put the decorator on the outermost function with RequestContext as the first argument to group things into same transaction | 15:33 |
gibi | cool, clever solution | 15:35 |
melwitt | I couldn't move past the "why is it not a single transaction" because from all the code comments around setting allocations, it should have been. so I was going to keep looking until I found out why 😆 | 15:36 |
opendevreview | Merged openstack/nova master: docs: Clarify host-model, host-passthrough differences https://review.opendev.org/c/openstack/nova/+/782410 | 15:36 |
gibi | :) | 15:37 |
gmann | gibi: lyarwood for sdk https://review.opendev.org/c/openstack/openstacksdk/+/801872 | 15:42 |
melwitt | easy review to correct a reno https://review.opendev.org/c/openstack/nova/+/801144 if anyone can take a look. has a +2 from stephenfin already | 15:42 |
opendevreview | Samuel proposed openstack/nova master: Add REST and compute APIs to migrate instances between projects https://review.opendev.org/c/openstack/nova/+/801377 | 15:43 |
melwitt | I was able to consult a SME on telemetry and they let me know telemetry doesn't call the audit log API, it uses only the notifications | 15:44 |
lyarwood | gmann: cool thanks | 15:44 |
gibi | melwitt: I left 3 small comment in the consumer_type impl but over all it looks good https://review.opendev.org/c/openstack/placement/+/679441 | 15:55 |
gibi | gmann: will check soon | 15:55 |
gibi | melwitt: approved the reno update. thanks for that! | 15:56 |
melwitt | gibi: thanks for your patience on this one! and one of your comments looks familiar, apologies if it's one I missed in previous PS's | 15:56 |
melwitt | I will address them | 15:57 |
gibi | melwitt: no worries. | 15:58 |
*** rpittau is now known as rpittau|afk | 16:02 | |
opendevreview | Merged openstack/nova master: Correct reno for archiving task_log database records https://review.opendev.org/c/openstack/nova/+/801144 | 16:19 |
opendevreview | Stephen Finucane proposed openstack/nova master: Move 'hw:pmu', 'hw_pmu' parsing to nova.virt.hardware https://review.opendev.org/c/openstack/nova/+/792364 | 16:43 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Rename 'parameter_types.hostname' -> 'fqdn' https://review.opendev.org/c/openstack/nova/+/778549 | 16:48 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Add support for 'hostname' parameter https://review.opendev.org/c/openstack/nova/+/778550 | 16:48 |
opendevreview | Stephen Finucane proposed openstack/nova master: objects: Don't use generic 'Field' container https://review.opendev.org/c/openstack/nova/+/738239 | 16:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove unnecessary type aliases, exceptions https://review.opendev.org/c/openstack/nova/+/738240 | 16:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: objects: Use imports instead of type aliases https://review.opendev.org/c/openstack/nova/+/738018 | 16:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: objects: Remove wrappers around ovo mixins https://review.opendev.org/c/openstack/nova/+/738019 | 16:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: WIP: add ovo-mypy-plugin to type hinting o.vos https://review.opendev.org/c/openstack/nova/+/758851 | 16:57 |
opendevreview | Stephen Finucane proposed openstack/nova master: docs: Further tweaks to the CPU models document https://review.opendev.org/c/openstack/nova/+/784066 | 16:59 |
opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | 17:36 |
opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 17:36 |
opendevreview | melanie witt proposed openstack/placement master: Microversion 1.37: API support for consumer types https://review.opendev.org/c/openstack/placement/+/679441 | 18:21 |
opendevreview | melanie witt proposed openstack/placement master: Switch ConsumerType to use an AttributeCache https://review.opendev.org/c/openstack/placement/+/679486 | 18:21 |
opendevreview | melanie witt proposed openstack/nova master: WIP Add force kwarg to delete_allocation_for_instance https://review.opendev.org/c/openstack/nova/+/688802 | 21:22 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!