Monday, 2022-04-04

*** amoralej|off is now known as amoralej07:06
*** amoralej is now known as amoralej|lunch12:06
yuvalHey how do I join the PTG I need to download the eventbrite app?12:38
sean-k-mooneyyuval: no12:42
sean-k-mooneyyuval: https://ptg.opendev.org/ptg.html12:42
sean-k-mooneythis is the ptg site12:42
sean-k-mooneyif you click on the project in the calandar it will open the zoom meeting for you12:42
sean-k-mooneythere is also the list of etherpads at the top12:42
sean-k-mooneysome will use jitsi meet instead of zoom12:43
sean-k-mooneybut you just need a web browzer to join12:43
sean-k-mooneyno need to install the client or download eventbrite12:43
kashyapgibi[m]: Just to give a heads-up (for later): on this (old) CPU APIs patch, I've addressed some comments from Stephen, and I'm systematically combing through some of your older remarks - https://review.opendev.org/c/openstack/nova/+/762330/12:48
kashyapgibi[m]: ... and adress what I can.  I'll include a short changelog of summary when I post a revison, so you know what's addressed12:48
yuvalthanks12:48
kashyapgibi[m]: Don't look at it yet, but just giving a heads-up for later :)12:48
gibikashyap: ack, thanks for the headsup12:50
bauzashappy PTG for everyone13:01
gibibauzas: o/13:02
bauzasI have nothing specific in the PTG agenda that I want to go, but ping me if you want me to be around13:08
*** amoralej|lunch is now known as amoralej13:08
bauzasgmann: do you want me to be around on the QA meeting given you would discuss about Secure RBAC ?13:08
gmannbauzas: not as such from nova perspective but you can join on what plan we will do13:18
bauzasgmann: ok, b/c we have a TC/community session at 2pm UTC13:18
gmannbauzas: yeah, there we need you. but TC one will be after QA RBAC 13:21
bauzasgmann: I'm around on QA13:21
gmanncool13:22
bauzasgmann: then I'll go to the TC meeting at 2pm13:22
gmannbauzas: thanks.13:26
kashyapgibi: I have a question on an old comment of yours here on line-795: https://review.opendev.org/c/openstack/nova/+/762330/20..23/nova/virt/libvirt/host.py13:35
kashyapgibi: You're saying about capabilities being logged but then we modify.  I just want to make sure you've noticed the two libvirt APIs in play here:13:36
kashyap- getCapabilities will tell you what libvirt code can do in general ("yes, this libvirt is new enough for particular XML constructs")13:37
kashyap- getDomainCapbilities will tell you what libvirt can do with the given qemu-kvm binary13:37
kashyapIsn't the logging being done there is of getCapabilties(), but the modification on line 809/810 (PS20) is being done of _get_domain_capabilities() - the second API?13:38
gibikashyap: I have to look at it again13:49
gibigive me some time :)13:50
kashyapYeah, new context.  If you're busy w/ PTG stuff, let it wait13:50
kashyapRight, I'm posting a new rev (not touching this part yet).  Also closely read the note from chengsheng, I think he's confusing.  (Or I'm doing it)13:50
gibiyeah, it was hard to follow 13:51
* kashyap nods; I squinted hard and see that it _is_ modifying _caps with "domcap[s]"13:54
*** dasm|ruck|off is now known as dasm|ruck13:59
gibikashyap: yeah, I think that is what I thought when I wrote the comment.14:00
kashyapgibi: You're right14:00
gibikashyap: looking at master we already do that in case of arm14:00
gibito add cpu features14:00
kashyapgibi: Already do what, sorry?  Can you give a code pointer14:00
gibihttps://github.com/openstack/nova/blob/b0851b0e9c82446aec2ea0317514766fbc53abc0/nova/virt/libvirt/host.py#L80614:01
gibiwe already modify self._caps after we logged it14:01
kashyapAhh, so it is just "following the existing behaviour" from Ari14:02
kashyaps/Ari/Arm/14:02
gibiit seems like so14:02
gibiso feel free to ignore that comment14:02
kashyapRight; I'll leave it intact in this case.14:03
gibiOK14:03
kashyapI'm addressing your other comments.  Thanks for the quick look14:03
gibithanks for picking that patch up14:06
kashyapgibi: I might need some more help to get it to the finish line.  This is getting more important as I see bugs in this area that can be fixed by these APIs14:23
opendevreviewKashyap Chamarthy proposed openstack/nova master: Libvirt: Use improved guest CPU config APIs  https://review.opendev.org/c/openstack/nova/+/76233016:07
sean-k-mooneybauzas: have you finished organising the ptg adgenda by the way?16:15
bauzassean-k-mooney: yup16:15
sean-k-mooneycool16:15
* bauzas removes the 'shuffling in progress' header, my bad16:15
sean-k-mooneywe are starting at 14:00 utc ok16:16
gibibauzas: do we want to add a separate agenda point for the blind recheck discussion or we handle that as part of the nova's CI footprint topic?16:16
sean-k-mooneyneutron i think are starting at 13:00 so i will likely be intere room before we start16:16
bauzasgibi: good question, I saw your addition16:16
bauzasgibi: I'm ok with leaving it as one topic16:16
bauzasgibi: I don't have anything more to say besides it16:16
sean-k-mooneygibi: we used to have contibutor docs for recheck i dont think it will be contoverl to re add them to nova16:17
gibisean-k-mooney: that is a good action item16:17
gibibauzas: OK, lets keep it as is then16:17
sean-k-mooneyso i hope its more an FYI and then proceed to the gerrit doc review for main details16:17
bauzasthen let's move the CI point closer to the procedural section16:17
bauzasgibi: ^16:17
gibibauzas: I have no problem with that16:17
bauzasdone16:18
gibisean-k-mooney: top of the doc change I think we should start pointing to that doc when we see blind rechecks (i.e. apply peer pressure)16:18
gibibauzas: cool16:18
*** amoralej is now known as amoralej|off16:19
bauzasgibi: yup, I think we agreed on ideally having a zuul reply that would provide this link but at least we can comment using this link16:19
bauzasbut let's not start the conversation by now16:19
gibiyepp, I would you the link in my comment :)16:19
gibiack16:19
sean-k-mooneygibi: we currently point to the shared contibutor doc but its kind of burried16:21
sean-k-mooneyso the shared one already tells peopel to not do a blind recheck16:21
sean-k-mooneybut again its not trivial to find that16:21
bauzasideally this should be a contributor doc, not a project doc16:23
sean-k-mooneyso here https://docs.openstack.org/nova/latest/contributor/code-review.html we have https://docs.openstack.org/infra/manual/developers.html#peer-review as the first line 16:23
sean-k-mooneybauzas: it is16:23
sean-k-mooney in https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing16:23
sean-k-mooneypoint 216:24
sean-k-mooneyExamine the console log or other relevant log files to determine the cause of the error. If it is related to your change, you should fix the problem and upload a new patchset. Do not use “recheck”.16:24
sean-k-mooneywe link to that in our testing doc https://opendev.org/openstack/nova/src/branch/master/doc/source/contributor/testing.rst#voting-in-gerrit16:25
bauzassean-k-mooney: the point is, this is acceptable to do 'recheck something'16:25
bauzasprovided 'something' is meaningful16:25
sean-k-mooneyhttps://docs.openstack.org/nova/latest/contributor/testing.html#voting-in-gerrit16:25
bauzassean-k-mooney: add those links to the etherpad and we'll discuss it once we're at this topic16:25
sean-k-mooneyright but my point is its hard to find the exsing docs on when you should recheck16:25
sean-k-mooneysure16:26
bauzassean-k-mooney: I don't disagree, this is tribal knowledge16:29
bauzashence why I'd have appreciated some automatic zuul reply with link16:29
sean-k-mooneyyes that is why i suggested doing that16:29
bauzassean-k-mooney: I think I expressed this beforehand :p16:30
bauzasanyway, if there is a consensus, we should see how to do this16:30
sean-k-mooneyi know how to do this16:30
sean-k-mooneyits trivial16:30
bauzasnot for me :)16:31
bauzasbut I'll review you :p16:31
sean-k-mooneyupdate this https://github.com/openstack/project-config/blob/master/zuul.d/pipelines.yaml#L10-L12=16:31
sean-k-mooneyit currently links to the section that contians the guidence on when to recheck16:31
sean-k-mooneythis is part of the pipeline config so it affect all jobs in the pipeline16:32
sean-k-mooneyso it woudl be for all projects16:32
sean-k-mooneywe likely and update that to be more explcit and say do not recheck without first reading ....16:32
*** dasm|ruck is now known as dasm|22:26
*** dasm| is now known as dasm|off22:26

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!