Tuesday, 2022-04-05

opendevreviewmelanie witt proposed openstack/nova master: scheduler: Add an ephemeral encryption pre filter  https://review.opendev.org/c/openstack/nova/+/76045605:36
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add DriverImageBlockDevice to block_device_info  https://review.opendev.org/c/openstack/nova/+/82652705:36
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add encryption attributes to image and ephemeral disks  https://review.opendev.org/c/openstack/nova/+/82652805:36
opendevreviewmelanie witt proposed openstack/nova master: virt: Add block_device_info helper to find encrypted disks  https://review.opendev.org/c/openstack/nova/+/82652905:36
opendevreviewmelanie witt proposed openstack/nova master: blockinfo: Add encryption details to the disk_info mappings when provided  https://review.opendev.org/c/openstack/nova/+/77227205:36
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Add disk_info_mapping as an optional attribute of Image  https://review.opendev.org/c/openstack/nova/+/82653005:36
opendevreviewmelanie witt proposed openstack/nova master: privsep: Move qemu-img create calls under nova.privsep.qemu  https://review.opendev.org/c/openstack/nova/+/82675005:36
opendevreviewmelanie witt proposed openstack/nova master: privsep: Return QemuImgInfo objects from qemu-img info calls  https://review.opendev.org/c/openstack/nova/+/82675105:36
opendevreviewmelanie witt proposed openstack/nova master: privsep: Add encryption support to qemu-img create command  https://review.opendev.org/c/openstack/nova/+/82675205:36
gibigood morning nova06:45
*** icey_ is now known as icey06:59
*** amoralej|off is now known as amoralej07:10
UgglaHello guys, dumb question. Is there a preferred style syntax for string. I mean any preference for 'string' or "string" ?09:27
opendevreviewWenping Song proposed openstack/nova-specs master: Usage of new trait of OWNER_NOVA  https://review.opendev.org/c/openstack/nova-specs/+/83658309:31
opendevreviewWenping Song proposed openstack/nova-specs master: Usage of new trait of OWNER_NOVA  https://review.opendev.org/c/openstack/nova-specs/+/83658309:34
gibiUggla: no hard rule exists. I try to follow the style from the code around my edit (if that is consistent :D)09:38
* gibi would go with an automatic black run if we could preserve git blame easily 09:39
sean-k-mooneygibi: or we can have pre-comit do it09:41
sean-k-mooneythere is a rule that will make them all ''09:41
gibiyeah09:41
sean-k-mooneyi used it on one of my other repos personaly i prefer ""09:41
gibibut black would change everything so we would loose git blame and easy backport09:41
gibiI use black for personal projects too09:42
sean-k-mooneybut i prefer machine enforced style more09:42
sean-k-mooneyoh i dont use black09:42
sean-k-mooneyi just use pre-commit + autopep809:42
gibiahh autopep8 09:42
gibican it only format the current diff?09:42
sean-k-mooneyi was suggesting we could use pre-commit to normalise the strings and have that run in the pep8 target09:42
sean-k-mooneyif we wanted too09:43
sean-k-mooneyyes09:43
gibithen I'm supportive09:43
gibiI use https://github.com/gibizer/blacken_selection in my IDE09:43
sean-k-mooneybut we already did the gloabl update for autopep8 but pre-commit only runs on the current diff by default09:43
Ugglasean-k-mooney, is autopep8 will be "smart" enough to not broke strings like: "Share '0000:1222:1144:7777'" ? (strings where you want to display quotes).09:46
sean-k-mooneyautopep8 wont change this we would have to use a pre-commit hook. autopep8 is conservitive and tries to only enforce pep8 rules and sting format is not one of them09:47
sean-k-mooneyso we shoudl just test the hook.09:48
sean-k-mooneyhttps://pre-commit.com/hooks.html09:48
sean-k-mooneydouble-quote-string-fixer09:48
sean-k-mooneyis the one i use in other repo09:48
UgglaI have question regarding https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/libvirt-virtiofs-attach-manila-shares.html09:54
UgglaIs there a reason to have an "attachmentId" ? Not saying that because I forget it... :)09:55
Ugglathis field is not used by the api.09:58
sean-k-mooneyyes10:02
sean-k-mooneyso a volume can have multiple attachments when its moving10:02
sean-k-mooneyalthoguh this is a manilla share10:03
sean-k-mooneyso not entirly sure10:03
sean-k-mooneyi woudl ahve to read the spec again10:03
sean-k-mooney Uggla  so attachment id is the interanl id filed in the share_mappings table https://specs.openstack.org/openstack/nova-specs/specs/yoga/approved/libvirt-virtiofs-attach-manila-shares.html#data-model-impact10:05
sean-k-mooneyi think the intent is to allow the share to be assoated with teh vim but with differe exprot locations during move operations10:07
sean-k-mooneybut im not certin10:08
Ugglasean-k-mooney, each line of the table is unique by the couple instance_uuid, share_id 10:08
sean-k-mooneyi think attachment id was ment to be in the unique constraint10:08
sean-k-mooneylyarwood: ^ if you are around10:09
sean-k-mooneylyarwood: do you remember why we have attachment id10:09
sean-k-mooneyif the id filed is just intended as a primary key it should be an integer not a uuid so the fact its listed as a uuid is what is making me belive it for move operations10:11
Ugglasean-k-mooney, I think I can add it easily, it is just to understand the purpose of it.10:11
sean-k-mooneyso that we can create a new attachmet with a different export location for the destination.10:11
sean-k-mooneyyep10:12
Ugglalet's see id lyarwood can answer. If not I'll try to ping him.10:13
sean-k-mooneyhave you already implemented move operations10:13
* lyarwood reads back10:14
sean-k-mooneyi dont think you will need it before then10:14
sean-k-mooneythe other suecases is allowign the share to be mounted to the vm multiple times10:14
lyarwoodyeah I was just typing that10:15
lyarwoodI think this was more to do with the multi attach case of a share10:15
Ugglasean-k-mooney, with this first version --> Support for move operations once a share is attached will also not be covered by this spec10:16
Ugglasean-k-mooney, ny requests to shelve, evacuate, resize, cold migrate or live migrate an instance with a share attached will be rejected for the time being10:16
lyarwoodthat and debugging issues, I've always found it easier to use the underlying bdm id when tracing volume attachment issues10:16
Ugglalyarwood, ok make sens.10:18
Ugglalyarwood, thx10:18
opendevreviewStephen Finucane proposed openstack/nova master: hacking: Prevent use of six  https://review.opendev.org/c/openstack/nova/+/83658810:25
stephenfinsean-k-mooney: bauzas: ^10:25
sean-k-mooneystephenfin: care to add a pre-commit check? i guess that should be picked up by the flake8 check 10:33
sean-k-mooneyso i guess it already is there10:33
sean-k-mooneyhave you tested that locally to confirm one way or another?10:33
sean-k-mooneyotherwise ya that looks like a good idea to me10:33
gibiUggla: left a bunch of comments / questions on https://review.opendev.org/c/openstack/nova-specs/+/833669 (manila shares spec). Let me know if something of them are unclear10:50
opendevreviewStephen Finucane proposed openstack/nova master: Sync rootwrap.conf from oslo.rootwrap  https://review.opendev.org/c/openstack/nova/+/82322911:14
sean-k-mooneystephenfin: actully i need to add that to the cinder ptg11:19
sean-k-mooneystephenfin:we only have rootwrap because of os-brick11:19
sean-k-mooneynova does not use it directly11:19
sean-k-mooneyso i would like to move ti to os-brick11:19
sean-k-mooneythat or we could finsih porting os-brick to privsep so that it does not need it either11:20
stephenfinmakes sense11:22
sean-k-mooneyi pinged the cinder folks to see if i can get a slot to chat to them about it in there ptg adgenda11:25
sean-k-mooneyit looks pretty full so maybe we can do it in ours if they can have people join11:25
sean-k-mooneystephenfin: ping me when you have time to review my comments on the hacking change https://review.opendev.org/c/openstack/nova/+/83658811:57
sean-k-mooneyill be afk for the next 30 mins or so but happy to look at that again when im back11:57
opendevreviewStephen Finucane proposed openstack/nova master: hacking: Prevent use of six  https://review.opendev.org/c/openstack/nova/+/83658811:59
*** whoami-rajat__ is now known as whoami-rajat12:01
opendevreviewStephen Finucane proposed openstack/nova master: pre-commit: Sync hacking version, bump plugins  https://review.opendev.org/c/openstack/nova/+/83663912:03
stephenfinsean-k-mooney: Thanks for the review. Fixed that issue12:03
stephenfin(good spot)12:03
Ugglagibi, thx I'm will have a look at your comments.12:15
*** amoralej is now known as amoralej|lunch12:15
gibiack12:16
sean-k-mooneystephenfin: ack ill test them both locally again and then review12:29
bauzasstephenfin: ack too12:30
bauzasstephenfin: given it's only for new changes (thanks to hacking), it looks good to me 12:30
bauzasoh waity12:36
opendevreviewMerged openstack/nova master: Fix unit tests when they are run with OS_DEBUG=True  https://review.opendev.org/c/openstack/nova/+/83311512:37
bauzasstephenfin: sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/836588/2/nova/hacking/checks.py#104612:39
sean-k-mooneybauzas: we shoudl not currently have any usage of six in the codebases12:39
sean-k-mooneybauzas: https://codesearch.opendev.org/?q=six&i=nope&literal=nope&files=&excludeFiles=&repos=openstack%2Fnova12:40
bauzasthat's what I was verifying12:41
sean-k-mooneybauzas: tox -e pep8 check all files and i verified that with pre-commit run --all-files also12:42
sean-k-mooneyso i know that the only files that it flagged on where the two places i added it for testing12:42
sean-k-mooneyso on master at least we are all good. replied in the revew with the codesearch link too12:43
bauzassean-k-mooney: sent to the gate12:49
opendevreviewMerged openstack/nova master: Remove the code that never reach  https://review.opendev.org/c/openstack/nova/+/80957213:07
opendevreviewMerged openstack/nova master: Fix eventlet.tpool import  https://review.opendev.org/c/openstack/nova/+/83038313:07
opendevreviewMerged openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/83611313:08
*** amoralej|lunch is now known as amoralej13:13
opendevreviewAlexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints  https://review.opendev.org/c/openstack/nova/+/83665013:18
tobias-urdinnow when running_vms key is removed from /os-hypervisors/detail after microversion 2.87 what is the best way (without looping every single servers) to get total amount of instance and running vms using api?13:19
opendevreviewAlexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints  https://review.opendev.org/c/openstack/nova/+/83665013:24
*** artom__ is now known as artom13:28
opendevreviewMaxim Korezkij proposed openstack/nova master: Handle volume attachments  https://review.opendev.org/c/openstack/nova/+/83323413:33
bauzasreminder : we start our PTG in 20 mins \o/13:40
artomPrecarious Tricky Game?13:45
bauzasmuh13:46
tobias-urdinhm I guess I could hit os-instance_usage_audit_log but that isn't reliable13:47
*** dasm|off is now known as dasm13:59
*** dasm is now known as dasm|ruck14:00
sean-k-mooneynormally you would get the totals form placment14:00
sean-k-mooneyand the runnign instance i guess via a openstack server list --all-tenant and filter that for running14:00
sean-k-mooneyit depends on what you actually are trying to do 14:00
sean-k-mooneytobias-urdin: ^14:00
sean-k-mooneyhttps://www.openstack.org/ptg/rooms/newton14:01
sean-k-mooneynova room ^14:01
bauzaswhat sean-k-mooney said14:03
bauzasopening the PTG14:03
stephenfinI'll be along at :30. Got a conflict14:03
opendevreviewMaxim Korezkij proposed openstack/nova master: Handle volume attachments  https://review.opendev.org/c/openstack/nova/+/83323414:08
tobias-urdinsean-k-mooney: we get allocations from placement (vcpu, memory, disk, gpu etc) instead of the old hypervisor statistics API but cannot find a way to get number of instances only resource usage14:10
sean-k-mooneyyou would count allocations of type instance14:11
tobias-urdinoh there is a consumer_type on allocations, i see, thanks :)14:12
sean-k-mooneyalthough honestly openstack server list --all-projects is proably the best way to do this14:12
sean-k-mooneyif you are an admin at least14:12
sean-k-mooneyplacement wont actully count shelved instnaces14:13
sean-k-mooneysince they are not on a host14:13
tobias-urdinit's just to get an overview the easiest way (an less intensive way), isn't actually used for anything else since we have resource usage for planning14:13
sean-k-mooneyso one of the reasons we remvoed this is it was cached info that can get out of sync if the resouce tracker had a problem14:14
sean-k-mooneye.g. any that broke the update_available_resouces preiodic task ment the data in the hypervior api was out of date14:15
sean-k-mooneyserver list on the other hand will always be correct14:15
sean-k-mooneyif you do no hit the server detail api then i think it also only hits the api db14:15
sean-k-mooneyso its fast14:16
tobias-urdinfor now i'll just lazy guess with len(allocations) when hitting /resource_provider/<uuid>/allocations since the returned allocations doesn't include consumer_type like /allocations does14:25
tobias-urdinit doesn't have to be perfect, seems inefficient to just loop all allocations to check for VCPU resource or similar, so just using that for now14:26
sean-k-mooneyconsumer types is new14:29
sean-k-mooneyso unless you are on yoga it wont be there14:29
sean-k-mooneybefore yoga they are always vms14:30
sean-k-mooneywell no vms or migrations14:30
tobias-urdinah, ack good to know then I can check that when we move to yoga14:30
sean-k-mooneyyep14:30
tobias-urdinthanks!14:32
dansmithbauzas: are ya'll on track for cadence discussion at 1500?14:45
bauzasyup14:45
dansmithcool14:45
sean-k-mooneydansmith: technially we are slightly behind but going to jump to it at the top of the hour14:47
dansmithokay, I'm planning to come over for that, FYI14:47
bauzas+14:50
opendevreviewAlexey Stupnikov proposed openstack/nova stable/xena: stable/xena: fix openstack-tox-lower-constraints  https://review.opendev.org/c/openstack/nova/+/83665014:58
opendevreviewAndre Aranha proposed openstack/nova master: Remove Centos 8 jobs  https://review.opendev.org/c/openstack/nova/+/83666514:59
sean-k-mooneygmann: we are staring the release cadance discussion15:01
gmannsean-k-mooney: thanks, I am in keystone too but will jpin15:02
stephenfinsean-k-mooney: Are you using a monospace font as your system font? What is _wrong_ with you? :-D15:03
sean-k-mooneyyes15:03
sean-k-mooneyyes i am15:03
sean-k-mooneyi think im using source code pro15:04
sean-k-mooneysource code pro regualar 10pt :)15:05
sean-k-mooneyalthoug my desktop font is notserif Nerd Font medium15:05
sean-k-mooneyso it depends on the app15:06
clarkbsource code pro is a great font15:10
opendevreviewMerged openstack/nova master: hacking: Prevent use of six  https://review.opendev.org/c/openstack/nova/+/83658815:27
gibibauzas: i will be 10 minutes late for the next session15:49
bauzaswe're restarting the sessions15:51
*** dasm|ruck is now known as dasm|ruck|mtg17:01
opendevreviewStephen Finucane proposed openstack/python-novaclient master: Deprecate nova CLI  https://review.opendev.org/c/openstack/python-novaclient/+/83668217:05
opendevreviewStephen Finucane proposed openstack/python-novaclient master: docs: Update docs to reflect deprecation status  https://review.opendev.org/c/openstack/python-novaclient/+/83668317:05
stephenfindansmith: export NOVACLIENT_IAMDAN=1 ^ yw17:08
dansmithlol17:10
dansmithfine with me, but probably should make that something else.. but definitely keep the comment :)17:11
stephenfinI initially used NOVACLIENT_IGNORE_DEPRECATION but I wanted to avoid people using this in e.g. ansible playbooks (vs. just changing their used commands). Giving it a weird name should make it sound less official, right?17:12
dansmithstephenfin: yeah that's a good goal... what you have might be too unofficial, but whatever :)17:25
*** dasm|ruck|mtg is now known as dasm|ruck17:57
opendevreviewArtom Lifshitz proposed openstack/nova stable/wallaby: extend_volume of libvirt/volume/iscsi should not use device_path  https://review.opendev.org/c/openstack/nova/+/83660419:16
opendevreviewArtom Lifshitz proposed openstack/nova stable/victoria: extend_volume of libvirt/volume/iscsi should not use device_path  https://review.opendev.org/c/openstack/nova/+/83660519:17
opendevreviewArtom Lifshitz proposed openstack/nova stable/ussuri: extend_volume of libvirt/volume/iscsi should not use device_path  https://review.opendev.org/c/openstack/nova/+/83660619:17
opendevreviewArtom Lifshitz proposed openstack/nova stable/train: extend_volume of libvirt/volume/iscsi should not use device_path  https://review.opendev.org/c/openstack/nova/+/83660719:17
opendevreviewMerged openstack/nova master: Fix wrong attribute to find remote address  https://review.opendev.org/c/openstack/nova/+/83624820:27
*** dasm|ruck is now known as dasm|off22:43

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!