*** tbachman_ is now known as tbachman | 04:30 | |
Uggla | Hello Nova o/ | 07:52 |
---|---|---|
opendevreview | Rajat Dhasmana proposed openstack/nova-specs master: Repropose volume backed server rebuild spec https://review.opendev.org/c/openstack/nova-specs/+/840155 | 08:21 |
gibi | o/ | 08:26 |
bauzas | \œ | 08:36 |
bauzas | wow | 08:36 |
bauzas | \o even | 08:36 |
Uggla | bauzas, Hi, I would like to add a graphviz schema in my spec any objection to add sphinx.ext.graphviz extension to the configuration ? | 09:09 |
bauzas | Uggla: I'm not a sphinx specialist but IIRC, we already support some way to add a schema | 09:10 |
bauzas | not sure about specs, but at least for our docs | 09:10 |
Uggla | bauzas, yep it is the case for the doc, the extension is available. But not for the nova-spec part. | 09:11 |
bauzas | oh | 09:11 |
bauzas | Uggla: then, create a change and we can discuss on it | 09:12 |
bauzas | Uggla: some specs were having some schemes | 09:13 |
Uggla | bauzas, I have just tested, it is just a matter of adding the extension in the conf for specs. Unless you don't want schema in specs. | 09:13 |
bauzas | in general, we did like this : https://specs.openstack.org/openstack/nova-specs/specs/rocky/implemented/granular-resource-requests.html#use-cases | 09:14 |
Uggla | bauzas, by the way seqdiag are available but not graphviz one (into specs). | 09:14 |
bauzas | Uggla: honestly, I'm not against | 09:14 |
Uggla | bauzas, what do you prefer, change included in my specs or a new one, just for that purpose ? | 09:15 |
bauzas | Uggla: no, as a specific change | 09:15 |
Uggla | bauzas, ok | 09:16 |
bauzas | and thanks for having looked at it | 09:17 |
Uggla | I'm gonna propose a patch for it in a moment. | 09:17 |
Uggla | bauzas, do we need something in launchpad for this ? (bug ?, bp ?) | 09:19 |
bauzas | Uggla: no, just a patch | 09:19 |
gibi | if you can draw the picture in ascii (e.g with https://asciiflow.com/#/) then I would prefer that instead of a dot file as it is directly reviewable in the source | 09:19 |
bauzas | Uggla: if you want, we can discuss on it at the next meeting | 09:19 |
bauzas | gibi: that's why we can discuss it in a meeting | 09:20 |
gibi | but I know that after a certain complexity ascii is not an option | 09:20 |
Uggla | gibi, yep and you need to change the ascii for each change. | 09:23 |
bauzas | Uggla: I did that in the past :p | 09:23 |
Uggla | gibi, and I'm too lazy to redraw the ascii when graphviz will do it for me. :) | 09:24 |
gibi | I also know the feeling | 09:31 |
opendevreview | ribaudr proposed openstack/nova-specs master: Allow to use graphviz into specifications https://review.opendev.org/c/openstack/nova-specs/+/840167 | 09:41 |
*** whoami-rajat__ is now known as whoami-rajat | 11:15 | |
gibi | bauzas: do you have an example how we name pGPU RPs? | 11:53 |
gibi | bauzas: is it like pci_0000_84_00_0 ? | 11:55 |
gibi | (asking just to make a consistent proposal for PF RPs) | 11:55 |
bauzas | gibi: sorry was a dad taxi | 12:51 |
* bauzas getting his older daughter from medium high school | 12:52 | |
gibi | no worries | 12:56 |
bauzas | gibi: did you eventually got your answer ? | 13:07 |
bauzas | if not, lemme give you the link | 13:07 |
gibi | from the code comments I see nodename_pci_0000_84_00_0 as the pGPU RP name | 13:08 |
gibi | but would be nice to confirm | 13:08 |
bauzas | https://github.com/openstack/nova/blob/b8cc5704558d3c08fda9db2f1bb7fecb2bcd985d/nova/virt/libvirt/driver.py#L8784 | 13:10 |
bauzas | eg. https://github.com/openstack/nova/blob/b8cc5704558d3c08fda9db2f1bb7fecb2bcd985d/nova/virt/libvirt/driver.py#L8756 | 13:10 |
bauzas | so yeah | 13:10 |
gibi | thanks | 13:11 |
bauzas | or https://github.com/openstack/nova/blob/master/nova/tests/functional/libvirt/test_vgpu.py#L362-L363 | 13:11 |
bauzas | gibi: ^ see the functest example | 13:12 |
gibi | ack | 13:12 |
artom_ | bauzas, when's the spec review day again? May 13? | 13:42 |
*** artom_ is now known as artom | 13:42 | |
bauzas | artom: shit, forgot to send the email | 13:42 |
bauzas | artom: May the 10th https://meetings.opendev.org/meetings/nova/2022/nova.2022-04-26-16.00.html | 13:43 |
artom | Next Tuesday fsck me | 13:43 |
* artom needs to write 2 specs | 13:44 | |
opendevreview | Balazs Gibizer proposed openstack/nova-specs master: PCI device tracking in Placement https://review.opendev.org/c/openstack/nova-specs/+/791047 | 16:08 |
gibi | sean-k-mooney, bauzas: ^^ this is a long but hopefully interesting read | 16:08 |
opendevreview | Sylvain Bauza proposed openstack/nova-specs master: Proposes to remove keypair generation https://review.opendev.org/c/openstack/nova-specs/+/840217 | 16:51 |
opendevreview | ribaudr proposed openstack/nova-specs master: libvirt: Allow Manila shares to be directly attached to instances https://review.opendev.org/c/openstack/nova-specs/+/833669 | 16:53 |
erlon | sean-k-mooney: hey Sean, can you give a look on this bugfix backport when you have a chance so I can continue the backporting throught the other releases? | 17:04 |
erlon | https://review.opendev.org/c/openstack/nova/+/838788 | 17:04 |
erlon | https://review.opendev.org/c/openstack/nova/+/836014 | 17:04 |
*** dasm|ruck|off is now known as dasm|ruck | 17:16 | |
mnaser | sean-k-mooney: i feel like you might have some context on this -- but thoughts at isolcpus=X vs CPUAffinity+systemd? | 19:37 |
*** dasm|ruck is now known as dasm|ruck|bbl | 22:23 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!