Thursday, 2022-12-01

opendevreviewmelanie witt proposed openstack/nova stable/train: Adapt websocketproxy tests for SimpleHTTPServer fix  https://review.opendev.org/c/openstack/nova/+/86620100:02
*** akekane is now known as abhishekk04:59
opendevreviewWenping Song proposed openstack/nova master: Get only resolved arqs instead of filter all arqs  https://review.opendev.org/c/openstack/nova/+/86629106:12
opendevreviewManuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings  https://review.opendev.org/c/openstack/nova/+/82867508:44
opendevreviewMerged openstack/nova master: Adds regression functional test for 1980720  https://review.opendev.org/c/openstack/nova/+/86135708:45
opendevreviewMerged openstack/nova stable/train: add regression test case for bug 1978983  https://review.opendev.org/c/openstack/nova/+/86416810:25
jsanemethello10:54
jsanemetcould i get a review for this spec?10:54
jsanemethttps://review.opendev.org/c/openstack/nova-specs/+/86543210:54
jsanemetthanks10:54
opendevreviewMerged openstack/nova stable/train: For evacuation, ignore if task_state is not None  https://review.opendev.org/c/openstack/nova/+/86416911:37
opendevreviewRajat Dhasmana proposed openstack/nova stable/wallaby: [stable-only] Use os-brick from source in wallaby  https://review.opendev.org/c/openstack/nova/+/86632611:49
*** akekane is now known as abhishekk13:07
*** dasm|off is now known as dasm13:46
opendevreviewManuel Bentele proposed openstack/nova master: libvirt: Add configuration options to set SPICE compression settings  https://review.opendev.org/c/openstack/nova/+/82867513:55
tobias-urdindo we support live migration of instances with pinned pcpus? perhaps sean-k-mooney can shime in14:08
tobias-urdinimo should be supported since train, but always better to ask i guess14:11
sean-k-mooneytobias-urdin: yes but it depend on the release14:11
bauzaswe indeed do14:12
sean-k-mooneyhttps://specs.openstack.org/openstack/nova-specs/specs/train/implemented/numa-aware-live-migration.html14:12
sean-k-mooneythe numa aware live migration feature added the ablity to recaluate and update the xml for the destination host14:12
sean-k-mooneytobias-urdin: before that you could only live migrate if the same cpus were free on the dest and that was kind of a hack14:13
sean-k-mooneyso before train really only cold  migration14:13
sean-k-mooneyafter train live migration should work properly14:13
sean-k-mooneytobias-urdin: the same is true for hugepages. it was done in the same feautre14:14
sean-k-mooneytobias-urdin: there is still one unfixed bug14:14
sean-k-mooneylive migrating between hosts with different vcpu_pin_sets or different cpu_shared_sets14:14
sean-k-mooneyfor non numa instnace is still technically broken14:15
opendevreviewMerged openstack/nova stable/yoga: Record SRIOV PF MAC in the binding profile  https://review.opendev.org/c/openstack/nova/+/85502314:15
opendevreviewMerged openstack/nova stable/yoga: Remove double mocking  https://review.opendev.org/c/openstack/nova/+/85502414:15
tobias-urdinack, so if nodes are identical in terms of config (pin sets) it shouldn't be a problem14:15
opendevreviewMerged openstack/nova stable/yoga: Remove double mocking... again  https://review.opendev.org/c/openstack/nova/+/85502514:15
sean-k-mooneywe do not update the cpus for floating instnaces until you hard reboot the vm14:15
opendevreviewMerged openstack/nova stable/yoga: Add compute restart capability for libvirt func tests  https://review.opendev.org/c/openstack/nova/+/85502614:15
opendevreviewMerged openstack/nova stable/victoria: [compute] always set instance.host in post_livemigration  https://review.opendev.org/c/openstack/nova/+/86390314:15
sean-k-mooneytobias-urdin: for pinend vms the pin sets can be differnt and it shoudl not be a problem14:16
sean-k-mooneyin trian+14:16
tobias-urdinack, not sure I understand the bug tho14:18
sean-k-mooneythe but is if you are not using cpu pinning, and you have set cpu_share_set or vcpu_pin_set14:19
sean-k-mooneyif that is not the same on all hosts floating vms will float over the wrong cores after migrating14:20
sean-k-mooneythe numa aware migration feature only updates the cpus if the vm has a numa toplogy14:20
sean-k-mooneyif its a normal vm with no numa info it does not update the cpus14:20
sean-k-mooneyand if you have eiterh vcpu_pin_set defiend or cpu_shared_set then the floating vms will be soft pinned to float over those cores14:21
tobias-urdinah I see, thanks, that shouldn't be an issue on our part then. thanks as always!14:21
sean-k-mooneyso this bug has been there since like icehouse wehn vcpu_pin_set was added as a config option14:21
sean-k-mooneywe have just never fixed it as it need an rpc change to pass back the requried info14:22
tobias-urdinack14:45
*** blarnath is now known as d34dh0r5315:06
atmarkhello, looking at resume_state_on_host_boot() in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4150-L4172, I like to add OR condition in https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L4164 such that it also ignores if the VM has property `NoRestart=True' e.g. `if state in ignored_states or instance_properties =15:32
atmark'NoRestart=True':`. Appreciate any pointers on how can I accomplish this. 15:32
bauzassean-k-mooney: gibi found a good issue in your stable/xena series for VDPA https://review.opendev.org/c/openstack/nova/+/86493215:54
bauzassean-k-mooney: just update the commit msg and we're all cool16:00
sean-k-mooneybauzas: yes i think i have seen that16:01
sean-k-mooneyand i think its adressed in the train version16:01
sean-k-mooneybut ill need to look at it again16:01
sean-k-mooneyi know i have to respine it for something and redo the train oen as a result16:01
opendevreviewsean mooney proposed openstack/nova stable/xena: refactor: remove duplicated logic  https://review.opendev.org/c/openstack/nova/+/86493218:14
opendevreviewsean mooney proposed openstack/nova stable/xena: Record SRIOV PF MAC in the binding profile  https://review.opendev.org/c/openstack/nova/+/86493318:14
opendevreviewsean mooney proposed openstack/nova stable/xena: Remove double mocking  https://review.opendev.org/c/openstack/nova/+/86493418:14
opendevreviewsean mooney proposed openstack/nova stable/xena: Remove double mocking... again  https://review.opendev.org/c/openstack/nova/+/86493518:14
opendevreviewsean mooney proposed openstack/nova stable/xena: Add compute restart capability for libvirt func tests  https://review.opendev.org/c/openstack/nova/+/86493618:14
opendevreviewsean mooney proposed openstack/nova stable/xena: enable blocked VDPA move operations  https://review.opendev.org/c/openstack/nova/+/86493718:14
sean-k-mooneybauzas: once ^ are merged ill redo the wallaby ones to update teh cherry-picked lines18:15
sean-k-mooneyi just updated the commit messages in the first two patches the rest are the same just rebased18:16
*** EugenMayer42 is now known as EugenMayer419:14
opendevreviewMerged openstack/nova stable/yoga: enable blocked VDPA move operations  https://review.opendev.org/c/openstack/nova/+/85503519:25
*** dasm is now known as dasm|off22:07

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!