Friday, 2022-12-02

*** akekane is now known as abhishekk04:51
*** akekane is now known as abhishekk06:09
whoami-rajathey #openstack-nova , nova-ceph-multistore is failing on wallaby gate, can anyone take a look at this patch fixing it? https://review.opendev.org/c/openstack/nova/+/86632609:30
bauzaswhoami-rajat: haha, I saw the problem 09:51
bauzaswhoami-rajat: thanks for your change, but I have a question09:52
bauzaswhy couldn't we have a new os-brick version ? 09:53
bauzasbecause Wallaby is on EM ?09:53
whoami-rajatbauzas, yes, the only way (I know of) is to take os-brick from source, I talked to the release team and not possible to release another os-brick for wallaby10:07
bauzaswhoami-rajat: which release model do you have for os-brick ?10:10
bauzaslemme check actually10:10
bauzashttps://releases.openstack.org/teams/cinder.html#os-brick hah, you're not using the independent model10:16
bauzasok, so I understand then10:16
bauzaswe can't release a new version in the wallaby branch indeed as it's EM10:16
* bauzas wonders if that's the only solution10:27
bauzasbut given it's on EM...10:27
bauzasgibi: sean-k-mooney elodilles: if you could quickly review https://review.opendev.org/c/openstack/nova/+/866326 that'd be loved10:30
sean-k-mooneyoh the os brick change10:31
sean-k-mooneysure10:31
sean-k-mooneydone10:33
bauzasthanks10:37
whoami-rajatbauzas, nope, we use cycle-with-intermediary https://github.com/openstack/releases/blob/4f29f584f85a7b26b69f6b5f8e47af4026dea686/deliverables/antelope/os-brick.yaml#L411:01
whoami-rajatthanks bauzas and sean-k-mooney for the quick reviews!11:01
sean-k-mooneyits the same as os-vif 11:04
sean-k-mooneycycle-with-intermediary is the default and most useful release model we have11:04
whoami-rajatyep, works good for client/non-client libraries11:05
opendevreviewJorge San Emeterio proposed openstack/nova-specs master: Review usage of oslo-privsep library on Nova  https://review.opendev.org/c/openstack/nova-specs/+/86543211:29
*** sfinucan is now known as stephenfin11:42
elodillesbauzas: sean-k-mooney: i think that patch is not needed: https://review.opendev.org/c/openstack/nova/+/86632612:14
elodillesi mean the above fixed already the issue ^^^12:14
elodillesso this is not needed and does not change anything: https://review.opendev.org/c/openstack/nova/+/86632612:15
elodillesby default the 'required project' is checked out with the matching branch12:15
elodillesthe override-branch is needed only if we run the job from a different branch, which we don't do12:17
opendevreviewMerged openstack/nova stable/wallaby: [stable-only] Use os-brick from source in wallaby  https://review.opendev.org/c/openstack/nova/+/86632612:21
opendevreviewMerged openstack/nova stable/wallaby: Add nova-ovs-hybrid-plug job  https://review.opendev.org/c/openstack/nova/+/82841812:21
sean-k-mooneyelodilles: oh sorry your right12:21
sean-k-mooneyits not12:21
sean-k-mooneyelodilles: i miss read it i tought it was adding os-brick12:22
sean-k-mooneynot adding the branchi missed that because of the comment12:22
sean-k-mooneyactully its also using the explit fully quallifed version which we shoudl revert12:22
sean-k-mooneyopendev.org/openstack/os-brick make it harder for third party cis12:23
opendevreviewAlexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt  https://review.opendev.org/c/openstack/nova/+/86366512:23
opendevreviewMerged openstack/nova stable/wallaby: Revert "Revert resize: wait for events according to hybrid plug"  https://review.opendev.org/c/openstack/nova/+/82841912:24
opendevreviewsean mooney proposed openstack/nova stable/wallaby: Revert "[stable-only] Use os-brick from source in wallaby"  https://review.opendev.org/c/openstack/nova/+/86645412:25
sean-k-mooneyelodilles: ^ bauzas ^12:25
sean-k-mooneyelodilles: the other disadvantage of the patch we just merged is i think override-branch: takes precidence over depneds on but not 100% sure about that12:26
opendevreviewAlexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt  https://review.opendev.org/c/openstack/nova/+/86366512:29
elodillessean-k-mooney: thanks, +2'd12:32
sean-k-mooneywhoami-rajat: ^ just so you are aware we are reverting that patch since we already had an equivlanet merged12:33
opendevreviewAlexey Stupnikov proposed openstack/nova master: Don't ignore InstanceNotFound exception by libvirt  https://review.opendev.org/c/openstack/nova/+/86366512:35
whoami-rajatsean-k-mooney, not sure what's the reason of revert since the gate on devstack is still broken with existing changes -- as mentioned in my commit message12:54
whoami-rajatwhich my patch intended to fix12:55
opendevreviewAlexey Stupnikov proposed openstack/nova master: Log some InstanceNotFound exceptions from libvirt  https://review.opendev.org/c/openstack/nova/+/86366512:57
elodilleswhoami-rajat: are you sure?13:01
whoami-rajatelodilles, well, it was broken when i proposed the patch, checking again13:01
elodilleswhoami-rajat: our fix landed on Nov 22nd, ~ 7 pm13:01
sean-k-mooneywhoami-rajat: the two shoudl mostly be the same exactp you are forcing the branch to be stable/wallaby 13:02
sean-k-mooneywhich is the default that will be used by zuul on the stable brnach13:02
sean-k-mooneythe only other change is you are explcitly referncing the connection that provides the repo13:03
whoami-rajatah i see now13:04
whoami-rajatthe gate report on this is 11:49 (my time) 22nd november 13:05
whoami-rajatand the patch you've referenced merged 11:48 22nd november https://review.opendev.org/c/openstack/nova/+/86513413:05
whoami-rajatlet's see if the gate is green on devstack after the revert13:06
*** akekane is now known as abhishekk13:40
bauzaswhoami-rajat: sean-k-mooney: elodilles: sorry was doing other things13:54
bauzas+Wd the revert13:54
bauzasthanks elodilles for the spotting, gtk that by default we don't use a release 13:55
sean-k-mooneyif you add it to requried project it add it to devstackts LIBS_FROM_GIT config option14:00
sean-k-mooneyand it also make zuul prepare the git repo in the corerct location14:01
sean-k-mooneyinclduing resloveing any depends on14:01
sean-k-mooneyby default the same branch as the job will be used for the branch of any required proejct14:01
sean-k-mooneyso branch-override is only need for thinks like tempest athat are branchless14:02
*** dasm|off is now known as dasm14:14
opendevreviewMerged openstack/nova stable/wallaby: Revert "[stable-only] Use os-brick from source in wallaby"  https://review.opendev.org/c/openstack/nova/+/86645415:37

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!