| opendevreview | melanie witt proposed openstack/nova master: tests: Use GreenThreadPoolExecutor.shutdown(wait=True) https://review.opendev.org/c/openstack/nova/+/883317 | 00:17 |
|---|---|---|
| melwitt | gibi, sean-k-mooney: ^ this is an attempt to improve stability wrt to the leaked greenlets in unit/func test jobs issue, if you are interested to take a look | 00:22 |
| melwitt | *further improve stability | 00:24 |
| opendevreview | melanie witt proposed openstack/nova master: tests: Use GreenThreadPoolExecutor.shutdown(wait=True) https://review.opendev.org/c/openstack/nova/+/883317 | 00:58 |
| opendevreview | David Wlazlo proposed openstack/python-novaclient master: Typo - nova CLI deprecation warning https://review.opendev.org/c/openstack/python-novaclient/+/883320 | 01:49 |
| opendevreview | David Wlazlo proposed openstack/python-novaclient master: Typo - nova CLI deprecation warning https://review.opendev.org/c/openstack/python-novaclient/+/883320 | 02:21 |
| opendevreview | melanie witt proposed openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325 | 03:21 |
| opendevreview | Merged openstack/python-novaclient master: Typo - nova CLI deprecation warning https://review.opendev.org/c/openstack/python-novaclient/+/883320 | 05:28 |
| opendevreview | Sahid Orentino Ferdjaoui proposed openstack/nova master: [wip]network: convert usage of neutronclient to openstacksdk https://review.opendev.org/c/openstack/nova/+/882714 | 06:55 |
| zigo | There's something that I still don't understand. When Moving from "nova server-migraiton-list" to "openstack server migration list --server <UUID>", how do I see the migration ID, so I can give it as argument to "server migration show" ? | 07:24 |
| zigo | It this fixed in a later openstackclient version ? | 07:24 |
| gibi | melwitt: Thanks for that func test patch. I'm totally +2 to merge it | 07:28 |
| sean-k-mooney | melwitt: that is an interesting approch | 08:38 |
| sean-k-mooney | gibi: i still kind of want to follow up wiht moveing all our greenthread usage into a global pool | 08:39 |
| sean-k-mooney | but i think im ok with mergeing melwitt's patch for now | 08:40 |
| sean-k-mooney | i dont knwo when ill get time to work on that again | 08:40 |
| sean-k-mooney | melwitt: once your patch merges i might rebase https://review.opendev.org/c/openstack/nova/+/873061 on top of it | 08:48 |
| sean-k-mooney | kashyap: lol slack is dead | 08:56 |
| kashyap | sean-k-mooney: Oh, is it? | 08:56 |
| kashyap | sean-k-mooney: Yeah, I was trying to say something back :) | 08:56 |
| kashyap | LOL | 08:56 |
| sean-k-mooney | my web client and weechat both cant connect | 08:56 |
| sean-k-mooney | 503 | 08:57 |
| kashyap | Yeah, same here | 08:58 |
| gibi | my web client seems to be OK | 09:02 |
| gibi | and I see your messages so I guess slack is back | 09:02 |
| sean-k-mooney | ya its back | 09:02 |
| gibi | sean-k-mooney: sure I think the melwitt fix is a good approach for now, and we can get back to your approach in the future as well | 09:02 |
| opendevreview | Merged openstack/nova master: tests: Use GreenThreadPoolExecutor.shutdown(wait=True) https://review.opendev.org/c/openstack/nova/+/883317 | 09:21 |
| opendevreview | Rodolfo Alonso proposed openstack/nova master: [alembic] Alembic operations require keywords only arguments https://review.opendev.org/c/openstack/nova/+/883344 | 10:16 |
| opendevreview | John Garbutt proposed openstack/nova master: WIP: Deprecate ironic.peer_list https://review.opendev.org/c/openstack/nova/+/883346 | 10:33 |
| sean-k-mooney | stephenfin: by the way i found an nova api that is not supproted by osc that we missed (its also nto supproted in nova client) | 10:36 |
| stephenfin | oh? | 10:36 |
| sean-k-mooney | https://specs.openstack.org/openstack/nova-specs/specs/train/implemented/show-server-numa-topology.html | 10:36 |
| sean-k-mooney | https://docs.openstack.org/api-ref/compute/?expanded=show-server-topology-detail#show-server-topology | 10:37 |
| sean-k-mooney | i was considerign trying to add that to the sdk | 10:38 |
| sean-k-mooney | just to get used to that process | 10:38 |
| stephenfin | sean-k-mooney: https://github.com/openstack/openstacksdk/blob/master/openstack/compute/v2/server.py#L695-L707 ? | 10:38 |
| sean-k-mooney | maybe on firday as a hack and hussel thing | 10:38 |
| sean-k-mooney | hum ok so its in the sdk | 10:39 |
| sean-k-mooney | so its just missing form osc | 10:39 |
| sean-k-mooney | so adding a new "openstack server toplogy show" command shoudl not be hard | 10:40 |
| sean-k-mooney | the show i guess is a littel reduntant | 10:40 |
| sean-k-mooney | since there is only one action on that endpoint but i think its consitent with the other commands | 10:40 |
| stephenfin | Yup, should be minimally complicated. I'd swear we had that also though... | 10:41 |
| sean-k-mooney | if i try and write a patch for this on friday can you take a look if and give me pointers if i gest stuck | 10:41 |
| sean-k-mooney | i think we missed it because its not in nova client as far as i can see | 10:41 |
| sean-k-mooney | i tought we did too | 10:42 |
| stephenfin | https://docs.openstack.org/python-openstackclient/latest/cli/command-objects/server.html#server-show | 10:42 |
| stephenfin | openstack server show --topology <server> | 10:42 |
| sean-k-mooney | its not in server show intentionally | 10:42 |
| sean-k-mooney | so that returns only the toplogy and not the rest of the server detail? | 10:42 |
| sean-k-mooney | we made the point in the spec that this should not be part fo the server show api respocne for performance reasons | 10:43 |
| sean-k-mooney | i guess as a client opt in it not terible | 10:43 |
| stephenfin | Yeah. It's not how I'd personally do that normally since it's really a separate command but it predates my involvement in the project. Ditto for the --diagnostics argument | 10:44 |
| sean-k-mooney | but that means the client is merging in a second api request into the output | 10:44 |
| stephenfin | I moved 'server migrate --confirm' to 'server migration confirm' | 10:44 |
| sean-k-mooney | ok if this is in the osc we have downstream for 17 i could suggest using it for verifying an instnac ehas been booted with a numa toplogy | 10:45 |
| stephenfin | Yeah, it is. Client-side though | 10:45 |
| sean-k-mooney | ok so if we have the supprot should i just leave it as it is | 10:45 |
| stephenfin | For 17 I'd pull the Antelope version of OSC. It's so much better than the Wallaby version or whatever | 10:45 |
| sean-k-mooney | i didnt find it as i was expecting it to be a seperate command sicne its a differnt api but its not without precended | 10:45 |
| stephenfin | Ditto for SDK | 10:46 |
| sean-k-mooney | we use server migrate for cold and live | 10:46 |
| stephenfin | openstacksdk 1.0 is a big move forward | 10:46 |
| sean-k-mooney | stephenfin: that has issues depeningon where you isntall it | 10:46 |
| sean-k-mooney | you cant intall the pypi verisonon the undercloud becasue it use the rpm version to run tripleo | 10:46 |
| sean-k-mooney | but any of our custoemr using it on there laptops shoudl defintly use it form pypi | 10:47 |
| stephenfin | True | 10:47 |
| sean-k-mooney | ok well thanks for confirming this is techinaly supproted | 10:48 |
| sean-k-mooney | i guess ill park doing any refactorign for now | 10:48 |
| sean-k-mooney | we could rename it but its proably not worth the upgrade impact | 10:48 |
| dvo-plv_ | sen-k-mooney, Hello. Will you have some free time to verify new test for packed ring, which were created ? https://review.opendev.org/c/openstack/nova/+/876075 | 11:40 |
| dvo-plv_ | sean-k-mooney: sorry, I've made a mistake in your nick | 11:48 |
| sean-k-mooney | hehe i have done that in comments i left in the code so dont worry about it | 11:49 |
| sean-k-mooney | dvo-plv_: and no i have not yet but ill try and take a look. i have a meeting at the top of the hour so im oging to go grab coffee but ill take a look at them when i get back | 11:50 |
| dvo-plv_ | sure, we always should find time for coffee :) | 11:53 |
| *** thelounge553 is now known as thelounge55 | 13:18 | |
| *** thelounge551 is now known as thelounge55 | 13:26 | |
| *** d34dh0r5| is now known as d34dh0r53 | 13:35 | |
| opendevreview | Carl Morris proposed openstack/nova master: Improving logging at '_numa_cells_support_network_metadata'. https://review.opendev.org/c/openstack/nova/+/860930 | 14:09 |
| opendevreview | Carl Morris proposed openstack/nova master: Improving logging at '_numa_cells_support_network_metadata'. https://review.opendev.org/c/openstack/nova/+/860930 | 14:16 |
| mnasiadka | Hello | 15:04 |
| mnasiadka | Is there a reason https://review.opendev.org/c/openstack/nova/+/853267 backport has not been merged yet? | 15:04 |
| opendevreview | melanie witt proposed openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325 | 15:28 |
| opendevreview | Mark Goddard proposed openstack/nova master: ironic: Let Ironic handle deployment cleanup actions during destroy https://review.opendev.org/c/openstack/nova/+/883411 | 15:40 |
| sean-k-mooney | mnasiadka: review bandwith | 17:59 |
| sean-k-mooney | i dont see any orhter reason its not merge ill take a look now | 18:00 |
| sean-k-mooney | mnasiadka:they are on its way on yoga | 18:04 |
| sean-k-mooney | mnasiadka: what branch do you need the fix on | 18:05 |
| *** elodilles is now known as elodilles_ooo | 19:42 | |
| *** dmellado95 is now known as dmellado9 | 23:04 | |
| opendevreview | Merged openstack/nova stable/yoga: Reproducer for bug 1983753 https://review.opendev.org/c/openstack/nova/+/853266 | 23:20 |
| opendevreview | Merged openstack/nova stable/yoga: Update RequestSpec.pci_request for resize https://review.opendev.org/c/openstack/nova/+/853267 | 23:28 |
| opendevreview | Merged openstack/nova stable/yoga: Add reno for fixing bug 1941005 https://review.opendev.org/c/openstack/nova/+/853268 | 23:28 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!