| opendevreview | melanie witt proposed openstack/nova master: Add debug logging when Instance raises OrphanedObjectError https://review.opendev.org/c/openstack/nova/+/883325 | 00:20 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: testing: Use the oslo.log ContextFormatter in the log fixture https://review.opendev.org/c/openstack/nova/+/883466 | 04:24 |
| opendevreview | melanie witt proposed openstack/nova master: testing: Use the oslo.log ContextFormatter in the log fixture https://review.opendev.org/c/openstack/nova/+/883466 | 04:26 |
| opendevreview | Amit Uniyal proposed openstack/nova master: Fixes a typo in availability-zone doc https://review.opendev.org/c/openstack/nova/+/883474 | 06:25 |
| opendevreview | Mark Goddard proposed openstack/nova master: Add functional regression test for 1860555 https://review.opendev.org/c/openstack/nova/+/760354 | 11:40 |
| opendevreview | Mark Goddard proposed openstack/nova master: Fix PCI passthrough race on reschedule (refresh) https://review.opendev.org/c/openstack/nova/+/710848 | 11:40 |
| dvo-plv | sean-k-mooney, gibi: Hello, sorry for annoying you, but will your have a ability to review new bp changes ? :) https://review.opendev.org/q/bp/virtio | 12:29 |
| sean-k-mooney | ill try and get to it this week yes | 12:30 |
| sean-k-mooney | if you have added teh test coverage i asked for i think it will be in reasonably shape to proceed | 12:30 |
| sean-k-mooney | just looking at it very quickly it woudl be good to add a release note | 12:31 |
| sean-k-mooney | "tox -e venv reno new libvirt-virtio-packed-queues" will stub out a release note file for you | 12:31 |
| sean-k-mooney | you can delete all the section excpet feature | 12:31 |
| sean-k-mooney | and there just give a bifr describption of the feature | 12:32 |
| sean-k-mooney | it should be trarged in a way that operator will see it an go "oh that could be useful" so it does not have to have all the deatil jut a high level short paragraph | 12:32 |
| sean-k-mooney | dvo-plv: addtional documenation could be added in a follow up patch but the release note should be in the patch that addes the features | 12:33 |
| opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 12:37 |
| dvo-plv | I added test coverage and releasnote. I forgot to do git add for release note in the previous patch | 12:38 |
| sean-k-mooney | :) | 12:39 |
| sean-k-mooney | would you mind removing the tabs https://review.opendev.org/c/openstack/nova/+/876075/8/releasenotes/notes/packed-virtqueue-filter-43a376674cb5b345.yaml | 12:39 |
| dvo-plv | sure | 12:40 |
| sean-k-mooney | actully they might be spaces but either way it would be nice to remove them | 12:40 |
| sean-k-mooney | i think the release note is ok | 12:40 |
| sean-k-mooney | it does not really explain why you want want to enable it | 12:41 |
| sean-k-mooney | or what it is however | 12:41 |
| sean-k-mooney | ideally an opeartor that does not know what this feature is should be able to look at the release note and get a sense for why they might care about learnign more | 12:42 |
| sean-k-mooney | i woudl add a sentence basically saying that the pack virtqueue format can improve the performance espically when combinind with hadware offloads or dpdk | 12:43 |
| sean-k-mooney | ill try an review this properly later or tomorrow | 12:44 |
| dvo-plv | okay, I see. Should I left sentence regarding packed filter and scheduling or this is too dive for the operator? | 12:44 |
| sean-k-mooney | am no i dont think that is needed but it would be nice to add a link to the spec https://specs.openstack.org/openstack/nova-specs/specs/2023.2/approved/virtio_packedring_configuration_support.html | 12:46 |
| sean-k-mooney | just add it in the "Usefull references about virtqueue:" list | 12:47 |
| sean-k-mooney | maybe make that jsut "Usefull references:" | 12:47 |
| sean-k-mooney | with those change the operator that reads it will have an idea of what the feature is and why they might want it and then links to learn more | 12:48 |
| sean-k-mooney | so that shoudl be good. | 12:48 |
| dvo-plv | okay, thanks, I will apply all advice | 12:51 |
| opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 13:12 |
| dansmith | we need another +2 on the CVE stack for wallaby please: https://review.opendev.org/c/openstack/nova/+/882869/2 | 13:23 |
| sean-k-mooney | dansmith: done | 13:32 |
| dansmith | sean-k-mooney: thanks | 13:32 |
| dvo-plv | sean-k-mooney: When we've told about queue feature, you mentioned that in could defined via '/sys/bus/pci/devices/...' path. I found this parser in the nova/pci/utils.py | 13:49 |
| dvo-plv | But you also mentined about getting queue from the libvirt xml. Could you please direct me to the module, which parse libvirt output | 13:50 |
| sean-k-mooney | eiehter will work for your case since the PF will be bound to dpdk | 13:51 |
| sean-k-mooney | and the representors are in user space | 13:51 |
| dvo-plv | class LibvirtConfigNodeDevicePciCap ? | 13:52 |
| sean-k-mooney | that is the libvir class i think yes | 13:54 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/host.py#L1568 we list the pci devices here | 13:54 |
| sean-k-mooney | this is what parses the nodedevs https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L3245 | 13:56 |
| sean-k-mooney | and yes https://github.com/openstack/nova/blob/master/nova/virt/libvirt/config.py#L3293 | 13:56 |
| sean-k-mooney | is what pares node devs that model pci devices | 13:56 |
| sean-k-mooney | the sturcture returend form libvirt looks somethign like this https://libvirt.org/drvnodedev.html#pci-host-devices | 13:57 |
| dvo-plv | thank you a lot | 13:58 |
| sean-k-mooney | idealy the kernel driver woudl be modifed to report theyse capablits such as the queue avaiale and then libvirt would be modifed to present that in the nodedev api | 14:00 |
| sean-k-mooney | then nova woudl just read that | 14:00 |
| opendevreview | Danylo Vodopianov proposed openstack/nova master: Packed virtqueue support was added. https://review.opendev.org/c/openstack/nova/+/876075 | 14:00 |
| sean-k-mooney | we can read form sysfs if we really need too | 14:00 |
| sean-k-mooney | but thats somehtign we try not to do | 14:00 |
| opendevreview | Sofia Enriquez proposed openstack/nova-specs master: Implement support for LUKS inside qcow2 volumes when using Libvirt https://review.opendev.org/c/openstack/nova-specs/+/883516 | 14:26 |
| noonedeadpunk | hey folks! I was kinda wondering about `send_service_user_token` requirement. For some reason, I thought it should have been covered by `service_token_roles_required` but seems it's an independant thing? | 14:49 |
| opendevreview | Merged openstack/nova master: vmwareapi: Mark driver as experimental https://review.opendev.org/c/openstack/nova/+/863911 | 15:08 |
| dansmith | noonedeadpunk: isn't the "required" one set on the middleware and not the client? | 15:09 |
| noonedeadpunk | Ok, this question is cornering me :) I think it is. I guess that auth_section as an option, which I pointed to keystone_authtoken, mislead me | 15:13 |
| noonedeadpunk | but yeah, now I see what you mean I guess | 15:14 |
| opendevreview | Merged openstack/nova stable/wallaby: Use force=True for os-brick disconnect during delete https://review.opendev.org/c/openstack/nova/+/882869 | 15:22 |
| opendevreview | Ghanshyam proposed openstack/nova master: Add integrated job to test the Nova RBAC old defaults https://review.opendev.org/c/openstack/nova/+/883557 | 18:04 |
| opendevreview | Carl Morris proposed openstack/nova master: Improving logging at '_numa_cells_support_network_metadata'. https://review.opendev.org/c/openstack/nova/+/860930 | 19:30 |
| melwitt | noonedeadpunk: send_service_user_token = True needs to go on the client side (nova) and service_token_roles_required = True needs to go on the server (cinder) | 19:36 |
| melwitt | i.e. cinder will require service tokens and so nova will send one | 19:37 |
| opendevreview | melanie witt proposed openstack/nova master: testing: Use the oslo.log ContextFormatter in the log fixture https://review.opendev.org/c/openstack/nova/+/883466 | 20:30 |
| opendevreview | Merged openstack/nova stable/wallaby: Enable use of service user token with admin context https://review.opendev.org/c/openstack/nova/+/882870 | 22:24 |
| dansmith | tres woot | 22:31 |
| dansmith | melwitt: ^ should be the last one | 22:31 |
| melwitt | woohoo | 22:33 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!