Wednesday, 2023-12-20

opendevreviewMerged openstack/nova-specs master: Enforce console session timeout  https://review.opendev.org/c/openstack/nova-specs/+/89855300:54
opendevreviewmelanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption  https://review.opendev.org/c/openstack/nova/+/87093901:45
opendevreviewmelanie witt proposed openstack/nova master: WIP Support rescue with ephemeral encryption  https://review.opendev.org/c/openstack/nova/+/87367501:45
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS  https://review.opendev.org/c/openstack/nova/+/77227301:45
opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS  https://review.opendev.org/c/openstack/nova/+/88431301:45
opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS  https://review.opendev.org/c/openstack/nova/+/88991201:45
sean-k-mooney[m]melwitt:  im going to sleep now but can you do a full rebase of the ephmeral encyption serise so we can start reviewing and merging the firest couple of patches? i would suggest putting them on top of stephenfin ‘s mypy patch to avoid the merge conflict01:51
melwittsean-k-mooney[m]: ok, sure01:52
sean-k-mooney[m]https://review.opendev.org/c/openstack/nova/+/884312 need a recheck anyway so might as well just do a rebase of the serise and get fresh results for the seriese01:52
melwitt++01:53
opendevreviewArtom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys  https://review.opendev.org/c/openstack/nova/+/90406003:42
opendevreviewMerged openstack/nova master: Remove deprecated [api] use_forwarded_for  https://review.opendev.org/c/openstack/nova/+/90333903:47
opendevreviewMerged openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/90342703:47
opendevreviewMerged openstack/nova master: Reproducer test of bug #1999674  https://review.opendev.org/c/openstack/nova/+/86780703:50
opendevreviewMerged openstack/nova master: docs: fix 404 for ironic docs  https://review.opendev.org/c/openstack/nova/+/88764305:29
opendevreviewMerged openstack/nova master: Adds a repoducer for post_live_migration_at_destination failures  https://review.opendev.org/c/openstack/nova/+/86808805:43
opendevreviewArtom Lifshitz proposed openstack/nova master: weights debug log: stop using tuples as dict keys  https://review.opendev.org/c/openstack/nova/+/90406006:23
opendevreviewliwenjian proposed openstack/nova stable/2023.2: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90401707:41
opendevreviewliwenjian proposed openstack/nova stable/2023.1: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90401807:42
opendevreviewliwenjian proposed openstack/nova stable/zed: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90401907:44
opendevreviewliwenjian proposed openstack/nova stable/yoga: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90402007:44
opendevreviewliwenjian proposed openstack/nova stable/xena: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90408107:45
opendevreviewliwenjian proposed openstack/nova stable/wallaby: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90408207:45
opendevreviewliwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90408307:46
opendevreviewliwenjian proposed openstack/nova stable/victoria: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90408307:49
opendevreviewliwenjian proposed openstack/nova stable/ussuri: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/90408407:57
opendevreviewmelanie witt proposed openstack/nova master: block_device: Add encryption attributes to swap disks  https://review.opendev.org/c/openstack/nova/+/88431207:59
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Configure and teardown ephemeral encryption secrets  https://review.opendev.org/c/openstack/nova/+/82675407:59
opendevreviewmelanie witt proposed openstack/nova master: imagebackend: Add support to libvirt_info for LUKS based encryption  https://review.opendev.org/c/openstack/nova/+/82675507:59
opendevreviewmelanie witt proposed openstack/nova master: Add encryption support to convert_image  https://review.opendev.org/c/openstack/nova/+/87093407:59
opendevreviewmelanie witt proposed openstack/nova master: Support create with ephemeral encryption for qcow2  https://review.opendev.org/c/openstack/nova/+/87093207:59
opendevreviewmelanie witt proposed openstack/nova master: Support resize with ephemeral encryption for qcow2  https://review.opendev.org/c/openstack/nova/+/87093307:59
opendevreviewmelanie witt proposed openstack/nova master: Add hw_ephemeral_encryption_secret_uuid image property  https://review.opendev.org/c/openstack/nova/+/87093507:59
opendevreviewmelanie witt proposed openstack/nova master: Add encryption support to qemu-img rebase  https://review.opendev.org/c/openstack/nova/+/87093607:59
opendevreviewmelanie witt proposed openstack/nova master: Support snapshot with ephemeral encryption for qcow2  https://review.opendev.org/c/openstack/nova/+/87093707:59
opendevreviewmelanie witt proposed openstack/nova master: Support rebuild and unshelve with ephemeral encryption  https://review.opendev.org/c/openstack/nova/+/87093907:59
opendevreviewmelanie witt proposed openstack/nova master: Support rescue with ephemeral encryption  https://review.opendev.org/c/openstack/nova/+/87367507:59
opendevreviewmelanie witt proposed openstack/nova master: libvirt: Introduce support for qcow2 with LUKS  https://review.opendev.org/c/openstack/nova/+/77227307:59
opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS  https://review.opendev.org/c/openstack/nova/+/88431308:00
opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS  https://review.opendev.org/c/openstack/nova/+/88991208:00
opendevreviewmelanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd  https://review.opendev.org/c/openstack/nova/+/86241608:01
opendevreviewMerged openstack/nova master: Call Neutron immediately upon _post_live_migration() start  https://review.opendev.org/c/openstack/nova/+/88368209:04
opendevreviewBalazs Gibizer proposed openstack/nova stable/zed: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90408510:24
opendevreviewMerged openstack/nova-specs master: Proposes mdev live-migration support in libvirt  https://review.opendev.org/c/openstack/nova-specs/+/90063610:37
bauzasgibi: thanks for the spec review but actually about how to check the destination compute, I was wrong10:49
bauzasgibi: I just checked and we recreate the migrate-data object in the source by using the latest version10:50
bauzasso target_mdevs field should be here10:50
bauzasso I'll create another field for just telling whether we support 10:51
bauzaslike https://github.com/openstack/nova/blob/master/nova/objects/migrate_data.py#L27010:51
gibiaddign a field there is OK to me. I guess we don't persist those10:54
bauzasnope indeed11:08
bauzasI'll start to upload the mdev-liv-mig series hopefully today EOB11:09
damiandabrowskiHey! I looked into my issue with VMs that are moved to the other AZs during resize/migrate.11:39
damiandabrowskisean-k-mooney: bauzas Thanks for showing me code responsible for preventing this behavior: https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L120511:39
damiandabrowskiThe problem is: this method is executed only when instance is created and due to the _get_volumes_for_bdms behavior, it sets proper request specs only when instance is booted from pre-existing volume.11:39
damiandabrowskiBut if user creates a VM using CLI and --boot-from-volume argument, the VM does not have AZ assigned in requests specs even though its root volume is associated with a specific AZ.11:39
damiandabrowskiShould it be considered as a bug?11:39
sean-k-mooney[m]im not sure it could be fixed as a bug12:34
sean-k-mooney[m]i would have expeced boot from volume form image and boot form prexising volume to have the same behavior12:35
sean-k-mooney[m]i.e. both a boot form voluem but in one instance nova is creating the volume and in the other we are using a user provided volume12:36
sean-k-mooney[m]it is expected that we execute this only once at instance creation12:37
sean-k-mooney[m]i assume the ax is not the default az “nova”12:42
sean-k-mooney[m]https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L133312:42
sean-k-mooney[m]this code https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L1399-L1406 will only work with precreated volumes12:44
sean-k-mooney[m]but i tought there was code later to update the request spec if its bfv form image12:45
sean-k-mooney[m]we would have to do that in the conductor after we have created the volume unless that happens on the computer. fi it does then its too late to update the request spec12:47
damiandabrowskiyeah exactly, _get_volumes_for_bdms considers only precreated volumes12:49
damiandabrowskiand since bfv from image is problematic on my dev environment and bfv from existing volume works fine, we most likely don't have anything that would update request specs later on :/12:50
damiandabrowskii can file a bug report today if you don't have anything against it12:50
sean-k-mooney[m]so i think this might be a non bakcportable feature not a bug12:53
sean-k-mooney[m]https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L164612:54
sean-k-mooney[m]looking at that method we do not create the cinder volumes before down calling to the compute agent12:54
sean-k-mooney[m]the request specifically is stored in the api db12:54
sean-k-mooney[m]we do not allow upcalls form the compute-agent to the api db in general12:55
sean-k-mooney[m]so to resolve this we would need to move the volume creation to the conductor prior to schduleing12:56
sean-k-mooney[m]alternitively prior to the downcall we could get the selected hosts AZ and update the requet spec here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L177912:59
sean-k-mooney[m]we have already looked up the instance.az here https://github.com/openstack/nova/blob/master/nova/conductor/manager.py#L172713:01
sean-k-mooney[m]so we would need to add13:01
sean-k-mooney[m]if request_spec.is_bfv:13:02
sean-k-mooney[m]if request_spec.az is non and instance.az != conf.default_az:13:04
sean-k-mooney[m]request_spec.az = instance.az13:04
sean-k-mooney[m]request_spec.save()13:04
sean-k-mooney[m]that might work but it would pin the vm to the az of the first host we trided. that may or may not have space to create the volume on that backend and it may still fail for other reasons when we down call meaing  we would have to ensure the alternat hosts are  also in the same az13:06
sean-k-mooney[m]damiandabrowski:  ^ so i guess you can file a bug but i suspect this was not done orginally since nova created ports and volumes are normally only created by the compute agent which is too late to update the request spec.13:07
opendevreviewMerged openstack/nova master: Use configuration for single enabled mdev type  https://review.opendev.org/c/openstack/nova/+/89940613:08
damiandabrowskisean-k-mooney: thanks for explanation! that's a lot of information to understand for now, but I'll try to process it all today :D 13:11
opendevreviewMerged openstack/nova stable/zed: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90408513:49
*** d34dh0r5- is now known as d34dh0r5314:48
opendevreviewMerged openstack/nova master: Resolve mypy error  https://review.opendev.org/c/openstack/nova/+/90353015:03
opendevreviewMerged openstack/nova master: tox: Use pre-commit for pep8 target  https://review.opendev.org/c/openstack/nova/+/89622715:03
melwittstephenfin: it looks like the CI failure on https://review.opendev.org/c/openstack/nova/+/903749 is legit ... codespell found a misspelling. not sure how it didn't fail before though18:13
sean-k-mooneyinteresting my guess is previous runs had not been rebased 18:15
melwittoh it was from the merge of post_live_migration reordering patch heh18:15
melwittthere was one misspelling in that18:15
sean-k-mooneyi should check something18:16
melwitthttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L934718:16
sean-k-mooneyi was wondering if it was https://github.com/openstack/nova/commit/2ffdf2e9173ca2ad0f95ac7f565da64b8b62691f18:17
melwittI wondered that at first too18:17
sean-k-mooneybut precommit is using --all-files before and after18:17
sean-k-mooneyi knwo stephen mentioned i shoudl use all-files but i could nto recall if i had made that change or not18:18
melwitthttps://zuul.opendev.org/t/openstack/build/de967e204d724b27821268c1fe0c5b75/log/job-output.txt#413218:18
sean-k-mooney ok am i can just submit a change to adress the typo quickly if ye like18:19
sean-k-mooneyor if you want to do that18:19
melwittno go ahead18:19
sean-k-mooneythen we can proceed with stephens change18:19
sean-k-mooneyoh18:22
sean-k-mooneyso stephen is bumpiong the codespell version18:22
sean-k-mooneyso on master it passes fine18:22
melwittoh huh18:22
sean-k-mooneybut with 2.2.6 presumablly it addes new misspeling to the list18:22
melwittwhy would it consider that not a misspelling in the older version 😆 18:22
melwittyeah, guess so18:23
sean-k-mooneyso codespell works by having a list of known incorrect words18:23
sean-k-mooneynot a dictonary of correct words18:23
melwittoh, interesting18:23
sean-k-mooneythats why it tends not to have a lot of false positives18:23
sean-k-mooneybrb18:24
sean-k-mooneyso stephen is done for today but he is fine wiht use just updating this. im confirming if i can see it locally now18:29
sean-k-mooneyoh...18:30
sean-k-mooneyso i think i know whats happening18:30
sean-k-mooneyso locally this is passing for me evne if i clean the cached copies18:31
sean-k-mooneybut the ci does not run on the patch under review.18:31
sean-k-mooneythe ci run on the patch under review rebased on top of master18:31
sean-k-mooneyand stepehns patch does not have artoms one18:31
sean-k-mooneyyep if i rebase stephens patch locally i see the same issue18:32
melwittah right18:32
sean-k-mooneyand that why we actully run this in ci 18:33
opendevreviewsean mooney proposed openstack/nova master: pre-commit: Add mypy  https://review.opendev.org/c/openstack/nova/+/89622818:34
opendevreviewsean mooney proposed openstack/nova master: pre-commit: Bump linter versions  https://review.opendev.org/c/openstack/nova/+/90374918:34
sean-k-mooneymelwitt: ^ care to reapprove18:37
melwittdone18:40
sean-k-mooneyby the way i thin kthe merge conflcit with yoru serise was in the patch that is already merged18:41
sean-k-mooneyso if that does not merged shortly you could just unparent again if you want too18:41
sean-k-mooneymelwitt: are you around tomorow/friday18:42
melwittsean-k-mooney: I'm around tomorrow18:42
sean-k-mooneyok i might try and review your code tomorrow so if i can find time18:42
sean-k-mooneyare you taking much pto over the next few weeks18:43
melwittwe have the year-end recharge Dec 22 until Jan 218:44
sean-k-mooneyill be back on the 8th if you think its ready i think it woudl be great to try an land your seriese in early january 18:44
melwitt++ yeah I'm pushing hard to get everything into finished shape by then. it's mostly adding unit tests and stuff like that18:45
melwitt(i.e. the implementation won't change much if at all)18:46
sean-k-mooneywell to aid with athat i think it woudl be good to see if we can merge som of the eairler patches.18:46
sean-k-mooneymainly so there is less to rebase/review18:46
melwittyeah, makes sense18:47
opendevreviewmelanie witt proposed openstack/nova master: DNM test ephemeral encryption + resize: qcow2, raw, rbd  https://review.opendev.org/c/openstack/nova/+/86241620:26
opendevreviewmelanie witt proposed openstack/nova master: Fix logging of exc_info in compute.utils.delete_image()  https://review.opendev.org/c/openstack/nova/+/90415522:53
opendevreviewMerged openstack/nova master: Allow best effort sending of notifications  https://review.opendev.org/c/openstack/nova/+/90380723:29

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!