Tuesday, 2023-12-19

opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for raw with LUKS  https://review.opendev.org/c/openstack/nova/+/88431301:13
opendevreviewmelanie witt proposed openstack/nova master: WIP libvirt: Introduce support for rbd with LUKS  https://review.opendev.org/c/openstack/nova/+/88991201:13
opendevreviewOpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata  https://review.opendev.org/c/openstack/nova/+/90342703:35
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.2: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90383408:07
gibisean-k-mooney: elodilles: a clean cherry pick backport ^^08:08
opendevreviewMerged openstack/nova master: Fixed an error when caching multiple images in aggregate  https://review.opendev.org/c/openstack/nova/+/89428808:18
elodillesgibi: +2'd10:40
gibithanks10:42
gibiI will push it back to antelope as well when the bobcat one lands10:43
elodilles++10:43
sean-k-mooneygibi: you might as well bring it to zed to have it on all stable branches11:42
opendevreviewTakashi Kajinami proposed openstack/python-novaclient master: coveragerc: Fix wrong omitted directory  https://review.opendev.org/c/openstack/python-novaclient/+/90396011:58
opendevreviewTakashi Kajinami proposed openstack/os-vif master: coveragerc: Remove non-existent path  https://review.opendev.org/c/openstack/os-vif/+/90396111:59
gibisean-k-mooney: I can12:03
sean-k-mooneyfor now thats going to be my default backport target until next it moves to unmaintened next cycle12:04
sean-k-mooney^ those two patches form takashi are trival and correct by the way if anyone wants some simple reviews12:07
gibidone12:19
opendevreviewElod Illes proposed openstack/nova stable/zed: Translate VF network capabilities to port binding  https://review.opendev.org/c/openstack/nova/+/89922913:03
opendevreviewMerged openstack/nova stable/2023.2: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90383413:28
opendevreviewBalazs Gibizer proposed openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90384014:05
gibielodilles: sean-k-mooney: ^^ moving it back to Antelope14:06
elodilles+2'd14:54
*** EugenMayer440189 is now known as EugenMayer4401814:59
opendevreviewMerged openstack/python-novaclient master: coveragerc: Fix wrong omitted directory  https://review.opendev.org/c/openstack/python-novaclient/+/90396015:20
opendevreviewMerged openstack/nova stable/2023.2: Fix traits to cpu flags mapping  https://review.opendev.org/c/openstack/nova/+/90344315:24
opendevreviewMerged openstack/nova stable/2023.1: Remove outdated comment about allocation ratios  https://review.opendev.org/c/openstack/nova/+/90369515:24
gibielodilles: thanks15:37
opendevreviewMerged openstack/os-vif master: coveragerc: Remove non-existent path  https://review.opendev.org/c/openstack/os-vif/+/90396115:38
bauzasreminder : nova meeting in 12 mins here15:48
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Dec 19 16:00:06 2023 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
bauzashowdy folks16:00
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:00
bauzaswho's around ?16:00
elodilleso/16:01
bauzasanybody else ?16:02
elodilleslooks like holiday season :)16:02
bauzaswell, yes and no :)16:02
bauzasnot for all of us yet :)16:02
gibio/16:03
bauzaslet's start, we'll see16:03
bauzas#topic Bugs (stuck/critical) 16:03
bauzas#info No Critical bug16:03
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 44 new untriaged bugs (+3 since the last meeting)16:03
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:04
bauzasartom: could you look at some bug reports this week ?16:04
bauzasanyway, moving on16:05
bauzas#topic Gate status 16:05
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:05
bauzas#link https://etherpad.opendev.org/p/nova-ci-failures-minimal16:05
bauzasfwiw, I haven't seen any CI failure this week16:06
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status16:06
bauzasall greens \o/16:06
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:07
JayFI've seen a couple unrelated failures this week on patches I've pushed, but the frequency I've seen on my limited sample size has been significantly reduced.16:07
bauzasany CI failure you would want to discuss ?16:07
JayFThank you for the improvement \o/16:07
bauzasJayF: cool16:07
* fwiesel joins late16:07
bauzasshall we move ?16:07
bauzas#topic Release Planning 16:08
bauzas#link https://releases.openstack.org/caracal/schedule.html#nova16:08
sean-k-mooneyo/16:08
bauzas#info Caracal-2 (and spec freeze) milestone in 3 weeks16:08
bauzaswe still have some open specs16:08
bauzasso if you could review them, it would be nice : https://review.opendev.org/q/project:openstack/nova-specs+is:open+file:%5Especs/2024.1/.*16:09
bauzas(at least mine, it would be nice :p )16:10
bauzasas a reminder, the specs freeze deadline is on January 11 (eob)16:10
sean-k-mooneyill do some spec reviews before i finsih up fo rthe year16:11
bauzasditto16:11
sean-k-mooneyill then be back on the 8th16:11
bauzas#topic Review priorities 16:11
grandchildo/16:11
bauzassean-k-mooney: as well, but let's discuss about when we're off by the last topic16:11
bauzasI added an item about that16:12
bauzasso, about review prios16:12
bauzas#link https://etherpad.opendev.org/p/nova-caracal-status16:12
bauzasI checked every item in the etherpad before the meeting16:12
bauzasas a reminder, you can use this etherpad to know which features or bug reports to review16:12
bauzaseach of the approved bps has one item in the etherpad with the related change16:13
bauzasand we have a few accepted prioritied bug reports 16:13
bauzasmoving on16:14
bauzas#topic Stable Branches 16:14
Ugglao/16:14
bauzaselodilles: passing you16:14
elodilles#info stable gates don't seem blocked16:14
elodillesat least I'm not aware of any *constantly* failing job16:14
elodilles#info nova stable releases are out: 2023.2 Bobcat (28.0.1), 2023.1 Antelope (27.2.0), Yoga (25.3.0)16:14
elodillesnote that there won't be more release out of stable/yoga as that branch will transition to Unmaintained16:15
elodilles#info Zed stable release is not yet approved: https://review.opendev.org/89960416:15
elodilles#info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci16:15
elodillesand that's all from me regarding stable branches16:15
bauzaselodilles: so about yoga16:15
bauzasI guess we would have another change for EM ?16:16
bauzasI mean the tag16:16
elodillesnope16:16
elodillesit will be a different tag,16:16
elodillesthen unmaintained/yoga will be cut from that tag16:16
elodilles(and stable/yoga branch will be deleted)16:16
bauzasokayt16:16
elodillesthat's the plan16:16
bauzasJayF: I can't remember, does the TC eventually accepted the unmaintained resolution ?16:18
* bauzas looks at https://governance.openstack.org/tc/16:18
opendevreviewMerged openstack/nova-specs master: Re-submit Ironic-shards for Caracal  https://review.opendev.org/c/openstack/nova-specs/+/90269816:18
bauzasI mean, what do we miss for starting to use unmaintained/yoga ?16:19
* bauzas reads now https://governance.openstack.org/tc/resolutions/20230724-unmaintained-branches.html16:19
elodillesbauzas: the automation tools are missing from release tooling :)16:19
elodillesbauzas: i'm working on it ;)16:20
bauzasokay16:20
bauzasso, basically, people can backport some changes to stable/yoga but we shouldn't be merging them ?16:20
elodillesalso this is a good reading for people who are interested in the topic: https://governance.openstack.org/tc/resolutions/20231114-amend-unmaintained-status.html16:21
bauzasnow we released yoga with the last number?16:21
sean-k-mooneythe stable/yoga branch will be deleted after the tag is created adn unmaintained/yoga is created16:21
sean-k-mooneyone thing we need to do is update the .gitreview file16:21
elodillesbauzas: we can merge, the tag will be applied at the HEAD of stable/yoga (like the *-eol tag)16:21
sean-k-mooneyonce we cut the new branch16:21
bauzaselodilles: okay16:22
bauzasgood to know16:22
bauzasso, basically, we can still backport some changes if we need (like some important fixes), but it would be better to wait until yoga is unmaintained16:22
elodilles+116:23
bauzaspeople interested in maintaining yoga would tho still want to backport changes to the stable branch, but we shouldn't be releasing it16:23
bauzasI'm cool with the plan then16:24
bauzasmoving on16:24
bauzas#topic vmwareapi 3rd-party CI efforts Highlights 16:24
fwiesel#Info Script installs functional devstack, starting from a blank vm snapshot in ca. 500s16:24
bauzasfwiesel: grandchild: if you want to tell us16:24
bauzasfwiesel: bravo !16:24
fwieselSo, we should be able to hook now things up, but...16:24
fwiesel#Info Need to lock down network before hooking up CI (ETA: Roughly Mid-January due to holidays)16:25
fwieselFor the curious ones, the stack.log I've put here: http://sap-openstack-ci.s3-website.us-east-2.amazonaws.com/logs-stack.tar.gz16:25
bauzasheh, sure :)16:25
* bauzas clicks16:25
fwieselWe will probably dump there also then the output of the test-runs, so they are publically visible16:25
bauzasfwiesel: I got a 403 from the link16:26
elodilles(fwiesel: it says 403 forbidden)16:26
fwieselHmm, I'll have to check with the colleague then. Just five minutes I we fixed the permissions. And I do not have the means to change them myself16:27
bauzasfwiesel: no rush16:27
sean-k-mooneyfor what its worht  this https://www.ovhcloud.com/en-ie/web-hosting/performance-offer/ used to be what we used to host the logs publicly in teh past16:27
sean-k-mooneyit is much cheaper then aws 16:27
bauzasI didn't wanted to play the French card :D16:28
fwieselNot if you factor in the bureaucracy to get that through in a big company16:28
sean-k-mooneyso its 120 euro a year so it genrelly does not require appoveal and can be expensed in most companies :)16:28
sean-k-mooneybut sue16:29
sean-k-mooney*sure16:29
bauzaswe're publicly logged here so I won't speak that much, but yeah AWS is good as being the primer16:29
sean-k-mooneyanyway good to know16:29
fwieselWe probably put it behind a dns redirect, so we can switch it whenever we want.16:29
bauzasfwiesel: that's a good idea and you shouldn't publiclize what you use for your environment IMHO )16:30
bauzas:)16:30
bauzaseven if people can see the dns redirect :)16:30
bauzasanyway16:30
bauzasthanks for the report, and that's very good to hear that your lab is running :)16:31
bauzaskudos again16:31
fwieselbauzas: You're welcome. Thanks for giving us the opportunity to pitch in.16:31
bauzasshall we move on ? 16:31
bauzasI have an item16:31
fwiesel#Info Next update on 9th January16:31
bauzasnoted.16:32
bauzasand it will transition to my own item actually :)16:32
bauzas#topic Open discussion 16:32
bauzas(bauzas) Skip next two nova meetingsĀ ?16:32
sean-k-mooneyi think yes16:32
bauzasso, I'm off from Christmas to Jan 816:32
bauzas(Jan 8 not included, tbc)16:33
gibi+1 on skipping16:33
gibiI'm back on the 15th16:33
elodilles+1 from me, too16:33
bauzasanyone having concerns and wanting to discuss the next day after Jan 1 ? :D16:33
bauzaslooks not16:34
bauzas#agreed Next two nova meetings (Dec 26 and Jan 2) will be SKIPPED. Next meeting will be Jan 916:34
bauzas#action bauzas to communicate this over ML16:34
bauzasokay16:35
bauzasso, we have another item16:35
bauzasthat we already discussed last week16:35
bauzas(JayF/johnthetubaguy) Specless blueprint for ironic guest metadata 16:35
bauzashttps://blueprints.launchpad.net/nova/+spec/ironic-guest-metadata16:35
JayFI've put a significant amount of detail in this since last week16:35
bauzasJayF: fancy taking the baton again ?16:35
bauzascool16:35
JayFI'm happy to discuss here, or async in the blueprint/mailing list/etc16:35
* bauzas reads the whiteboard16:35
JayFThis is mostly based on conversations with sean-k-mooney, especially the part about generalizing the libvirt code16:36
sean-k-mooneyjust readign it now16:36
bauzasJayF: I just have one question16:37
JayFI either have an answer or a clever deflection technique ;)16:37
bauzaswith a SLURP environment consisted of Caracal controllers, Caracal computes but also Antelope computes, how Ironic could use this ?16:37
JayFIronic is going to just look for the metadata provided by Nova in instnace_info16:38
sean-k-mooneyim not sure that will matter given this will be entrily in the driver16:38
JayFif it's there; Ironic will add the lessee; if not, it won't16:38
JayFif someone is migrating, they'll migrate *after* the upgrade is complete and because the migration script is additive only, it'll make the environment consistent16:38
sean-k-mooneyif the ironic compute are running antelope code it just wotn set that data16:39
bauzasJayF: here, I just want to hear that you understand that the metadata will be optional, at least until we upgrade to 2024.216:39
sean-k-mooneyif its upgraded it can check the ironic api version if needed16:39
JayFAbsolutely; 100%, ironic will opportunistically use that metadata if it exists, we will not make a hard dependency on it16:39
JayFit'd be an API break for us to do anything else16:39
sean-k-mooneythe ironic script that will be created for backfilling can also be used to reconsile everythign after the upgrade is fully done16:40
opendevreviewStephen Finucane proposed openstack/nova master: Resolve mypy error  https://review.opendev.org/c/openstack/nova/+/90353016:40
opendevreviewStephen Finucane proposed openstack/nova master: tox: Use pre-commit for pep8 target  https://review.opendev.org/c/openstack/nova/+/89622716:40
opendevreviewStephen Finucane proposed openstack/nova master: pre-commit: Add mypy  https://review.opendev.org/c/openstack/nova/+/89622816:40
opendevreviewStephen Finucane proposed openstack/nova master: pre-commit: Bump linter versions  https://review.opendev.org/c/openstack/nova/+/90374916:40
bauzasJayF: then I'm cool16:40
JayFwoo16:40
sean-k-mooneyi think im oke with moving forward with this as a specless bluepint and movign the dicussion to the implementaion16:40
bauzasfrom a nova pov, this is just a small thing16:40
JayFThat's sorta how I feel about it too, but it's hard for me to tell :)16:41
bauzasbut again, I don't want Ironic to have a bug because we continue to support Antelope computes, that's it :)16:41
bauzasif the plan is already sorted, then yay, sounds specless16:41
bauzasanyone concerned by any design problem ?16:41
bauzasanyone thinking of some nit that would need to be discussed ?16:42
bauzasapparently no16:42
bauzasso,16:42
JayFI'll note Ironic team discussed this at PTG; this reflects that discussion. I'll run it by our cores as well, don't expect any contention but I'll make another round trip here if there's any change.16:42
bauzas#agreed https://blueprints.launchpad.net/nova/+spec/ironic-guest-metadata to be approved as a specless blueprint for 2024.1 timeframe16:43
JayFThank you o/16:43
bauzasI already did the paperwork stamping16:44
bauzasI guess we're done with the meeting16:44
bauzasI don't see anything else in the agenda16:44
fwieselThanks everyone and happy holidays16:44
bauzasso, anything anyone ?16:44
gibihave a nice time off folks!16:45
elodilleshappy holidays o/16:45
bauzasyeah, happy holidays to all of you and for those who take time off, have a good one :)16:45
bauzassee you all next year16:45
bauzas#endmeeting16:45
opendevmeetMeeting ended Tue Dec 19 16:45:50 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:45
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.html16:45
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.txt16:45
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2023/nova.2023-12-19-16.00.log.html16:45
artombauzas, sorry, was AFK, yep, can look at bugs16:55
bauzasartom: thanks and again, as a reminder, low prio, stretch good at most16:58
bauzasgoal*16:58
bauzasdon't feel obliged.16:58
artomWell don't say that :)16:58
bauzasI'm just clear on the fact I can't force anyone to do upstream work if they are not recognized for that16:59
sean-k-mooneybauzas: https://review.opendev.org/c/openstack/nova-specs/+/900636 +1 can you review my comments17:03
* bauzas looks17:03
damiandabrowskiUnfortunately, even I have cinder.cross_az_attach=False, scheduler moves VM to the other AZ during migrate/resize which breaks it.17:04
damiandabrowski^ it was not intended, please let me send messages in a correct order :D17:04
damiandabrowskiHey! I want to deploy multi-AZ environment(shared network, separate ceph cluster in each AZ, no default_schedule_zone, no explicit AZ provided when creating VM, Zed Release).17:07
damiandabrowskiUnfortunately, even I have cinder.cross_az_attach=False, scheduler moves VM to the other AZ during migrate/resize which breaks it.17:07
damiandabrowskiIn documentation, I found the following statement so I guess it's an expected behavior: "If the server was not created in a specific zone then it is free to be moved to other zones, i.e. the AvailabilityZoneFilter is a no-op."17:07
damiandabrowskiIs there any way to prevent changing AZs during resize/migrate?17:07
sean-k-mooneydamiandabrowski: if the vm was create before enabling that settign on both the comptues and contoler it wont have updated the request spec with the az17:08
sean-k-mooneydamiandabrowski: live migration ebtween AZ is expected to work in genreal yes17:09
sean-k-mooneydamiandabrowski: my guess is if you check the request spec of the vm in question17:09
sean-k-mooneyit will not have an az specified 17:09
sean-k-mooneyonly the az in the request spec is considerd when schduling17:09
bauzassean-k-mooney: you're right on your first comment, we could return the mdev values in one step by the claim https://github.com/openstack/nova/blob/45e2349408dd3b385217066a3c5a4c29d7bdd3a0/nova/compute/manager.py#L855017:10
bauzasthat's a good call17:10
sean-k-mooneythe second change is so we know which uuid mapps to which type so that we can avoid changing the pci adress of the vgpus if we every have more then one in vm17:16
sean-k-mooneythat way i want to map the source mdev to the dest mdev that has the same type17:16
damiandabrowskisean-k-mooney: thanks for reply. My test vm are created after setting cinder.cross_az_attach=False on controllers and computes.17:19
damiandabrowskiI guess nova.instance_extra is a place where I can find instance extra specs right? 17:19
damiandabrowskihttps://paste.openstack.org/show/bXZgVyObqHQfn6yAVdET/17:19
sean-k-mooneybauzas: ^ you are more familar with that code path.17:20
sean-k-mooneydamiandabrowski: yes but this is not an extra spec17:20
sean-k-mooneythe request_spec is an object in the api db17:20
damiandabrowskiahh my bad, thanks!17:21
damiandabrowskihttps://paste.openstack.org/raw/bUwKEZg6FsylqJj4mDBi/17:21
damiandabrowski"availability_zone": null17:21
bauzasstrange17:22
bauzasif you had cross_az_attach=False, then the reqspec should have been modified17:22
bauzasby pinning to the volume AZ17:22
bauzassean-k-mooney: noted, will change too17:22
bauzasdamiandabrowski: sean-k-mooney: the path that's checking whether we should pin to an AZ for a volume https://github.com/openstack/nova/blob/d28a55959e50b472e181809b919e11a896f989e3/nova/compute/api.py#L126817:24
JayFbauzas: others; feedback from dtantsur in #openstack-ironic leads me to revise the ironic guest metadata spec to remove flavor since flavor name is volatile and can change while the instance is provisioned; in general can you consider us sending *less* fields to Ironic than listed in that spec an implementation detail? 17:24
bauzasJayF: yup, no worries17:25
sean-k-mooney JayF: that why i was saying we should use the falvor uuid17:25
bauzaswe said all that meat is specless17:25
JayFack17:25
JayFsean-k-mooney: that's not in the libvirt one today, fwiw17:25
bauzasthis is an implementation detail that will reviewed at time17:25
sean-k-mooneyJayF: yep i know thats an oversight i wanted to fix17:25
sean-k-mooneywe have access to it we are just not storing it right now17:26
sean-k-mooneyJayF: flavors are imuntable (extra_spec are not)17:26
JayF++ sounds good, we can easily do that with the centralization of that code17:26
sean-k-mooneyyou can recarete a flavor with the same name as previously deleted one but you cant specify a uuid17:27
sean-k-mooneyJayF: with regards to updating the bluepint lets add a doc in the refernce/continbutor section17:28
dtantsurJayF: I assume the flavor uuid only fixes a half of the problem: the flavor can deleted or (?changed?)17:28
sean-k-mooneyto detail how this works17:28
sean-k-mooneydtantsur: it can be but that does not make the info useless17:28
dtantsursean-k-mooney: but isn't it the reason why nova provides neither name nor uuid in the newer API versions?17:29
JayFsean-k-mooney: I don't know what that means?17:29
sean-k-mooneyJayF: while the flavor exist the uuid is useful for operator s to correalte nodes17:29
dtantsuryeah, I don't see flavor UUID in https://docs.openstack.org/api-ref/compute/#show-server-details17:30
JayFsean-k-mooney: the "doc in reference/contributor section" bit is what I don't understand17:30
sean-k-mooneydtantsur: we provide flavor.original_name i server show17:30
JayFIf the flavor uuid/name isn't in Nova's API, it's not super useful in Ironic's API tbh17:30
JayFand given there's a price to putting keys in that json field, if it's not cross-referenceable, I'd rather not send it17:31
damiandabrowskibauzas: thanks, then something is off...I'll try to gather more details17:31
sean-k-mooneyJayF: it is in the api up to version 2.4617:31
dtantsurwhen you say flavor UUID, you mean its numerical ID?17:31
dtantsur"The ID of the flavor. While people often make this look like an int, this is really a string."?17:31
sean-k-mooneyJayF: in 2.47 we addded flavor.original_name and remove flavor.name and flavor.id because they can be deleted but we cache a copy of hte flavor in the isntance_extra table when its created17:32
JayFsean-k-mooney: so it sounds like that is probably information better left for the operator to lookup in nova api17:32
sean-k-mooneydtantsur: flavor.id is a string filed that can be an int or any other sting. we generate a uuid if you dont provide one17:32
dtantsurI"m curious, why don't you publish id yourself then?17:33
dtantsurit's weird to add something to ironic that nova decided to remove17:33
opendevreviewMerged openstack/nova stable/zed: Translate VF network capabilities to port binding  https://review.opendev.org/c/openstack/nova/+/89922917:33
sean-k-mooneywe did and im not sure why we did keep it17:33
sean-k-mooneybut you can still get it usign the old microverion17:33
sean-k-mooneyim not sure why we dont have flavor.original_id17:33
dtantsuryeah, this ^^^17:34
opendevreviewSylvain Bauza proposed openstack/nova-specs master: Proposes mdev live-migration support in libvirt  https://review.opendev.org/c/openstack/nova-specs/+/90063617:34
bauzassean-k-mooney: gibi: updated based on sean-k-mooney's nice improvments17:34
JayFEither way, it's clear the arrows of the "latest" version of the API is that this information is best looked up and kept in nova, if it's not a first class API object in Nova that's guaranteed to be there and/or Ironic is not going to cache the flavor like nova does17:34
JayFthis was going to be an easy win; it's not; so punt it and keep the metadata that is the easy wins IMO17:35
JayFour API already has enough places with weird corners, this sounds like an easy place to avoid making another one17:35
sean-k-mooneyso looks like it was changed in pike  https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id43 so there should be a spec17:35
sean-k-mooneyhttps://specs.openstack.org/openstack/nova-specs/specs/pike/implemented/instance-flavor-api.html#proposed-change it jsut says it could be stale but i kind of think that was a mistake17:36
sean-k-mooneyJayF: ack i tought the falvor was the main motavator for this17:37
dtantsurhold on. if a user can specify the uuid, cannot they specify a uuid of an already deleted flavor?17:37
JayFsean-k-mooney: user_id/project_id is the primary motivator, to enable that next-step feature outlined in the blueprint (automatic_lessee)17:38
sean-k-mooneyfirst flavor are admin only. and yes looking at the api they can recreate a flavor wit hteh same id and name17:38
sean-k-mooneyJayF: oh ok17:38
sean-k-mooneythen sure feel free to exclude flavor or any other filed not useful to you17:38
sean-k-mooneyJayF: back to my docs comment we ahve refnece docs that detail some of the internal works of nova https://github.com/openstack/nova/tree/d28a55959e50b472e181809b919e11a896f989e3/doc/source/reference17:40
opendevreviewMerged openstack/nova stable/wallaby: db: Resolve additional SAWarning warnings  https://review.opendev.org/c/openstack/nova/+/87406917:40
JayFsean-k-mooney: so you're saying "Ironic <> Nova API interactions" would be a good document for there, potentially17:40
JayFsean-k-mooney: including a section on metadata passed over17:40
sean-k-mooneyJayF: they refence section is inteded for developers  so i was suggesting adding a instance metadata doc ther that just says this si what ironic uses 17:40
JayFsean-k-mooney: even if that's not what you're saying, it's what I'm saying now, because it's a good idea and might make the ironic driver generally less scary17:41
sean-k-mooneyyep 17:41
sean-k-mooneyso im fine fi the details change as part of the impleation as long as we documetn /test the expecte behavior so we know why17:41
sean-k-mooneynormally i woudl refer to the spec for those detail of intent17:41
opendevreviewMerged openstack/nova stable/2023.1: Allow live migrate paused instance when post copy is enabled  https://review.opendev.org/c/openstack/nova/+/90384017:55
sean-k-mooneybauzas: +2 on https://review.opendev.org/c/openstack/nova-specs/+/900636 gibi if you agree can you +2w 18:39
opendevreviewJay Faulkner proposed openstack/nova master: [ironic] Partition & use cache for list_instance*  https://review.opendev.org/c/openstack/nova/+/90083122:57
opendevreviewJay Faulkner proposed openstack/nova master: Limit nodes by ironic shard key  https://review.opendev.org/c/openstack/nova/+/90391522:57
opendevreviewJay Faulkner proposed openstack/nova master: Add nova-manage ironic-compute-node-move  https://review.opendev.org/c/openstack/nova/+/90391622:57
opendevreviewJay Faulkner proposed openstack/nova master: Make compute node rebalance safter  https://review.opendev.org/c/openstack/nova/+/90391722:57

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!