| *** bauzas_ is now known as bauzas | 01:33 | |
| opendevreview | Masahito Muroi proposed openstack/nova master: Change instance_system_metadata value to Text type https://review.opendev.org/c/openstack/nova/+/925163 | 06:20 |
|---|---|---|
| *** bauzas_ is now known as bauzas | 08:14 | |
| opendevreview | Julien Le Jeune proposed openstack/nova stable/2024.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/925181 | 09:50 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Fix KeyError on assisted snapshot call https://review.opendev.org/c/openstack/nova/+/900783 | 10:08 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Restore original AZ when unshelve fails https://review.opendev.org/c/openstack/nova/+/911108 | 10:14 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | 10:28 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 10:28 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | 10:32 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 10:32 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: Add config option to require secure SPICE. https://review.opendev.org/c/openstack/nova/+/922544 | 10:33 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 10:33 |
| mikal | Sorry about that, I have no idea how that hook ended up in my rebase. | 10:34 |
| mikal | sean-k-mooney: I've dropped the concurrency patch, and the first two patches in the series should be good to review now. I'll do the sound and usb device extra specs next but that's not done yet. | 10:35 |
| *** bauzas_ is now known as bauzas | 10:52 | |
| opendevreview | Merged openstack/nova stable/2023.1: Remove AMI snapshot format special case https://review.opendev.org/c/openstack/nova/+/925000 | 11:54 |
| jlejeune | sean-k-mooney: hello, since the last commit "Remove AMI snapshot format special case" has been merged, the test_snapshot_running test is now running but it depends on qemu-img binary which is not necessary installed, so it fails | 12:46 |
| jlejeune | why not putting qemu-utils package in bindep.txt ? | 12:55 |
| sean-k-mooney | jlejeune: because our unit test are not ment to depend on it | 13:08 |
| sean-k-mooney | jlejeune: its an optiona depency | 13:08 |
| sean-k-mooney | and we will be removing those tests when we factor this out of nova | 13:08 |
| sean-k-mooney | we could add it as a test only dep in bindep | 13:09 |
| sean-k-mooney | but we dont want to require peopel to install qemu image just to run unit test in general | 13:09 |
| jlejeune | agree, so in the meantime waiting for the removal of that code in oslo instead of nova, we need to skip that test if qemu-img binary is missing | 13:17 |
| sean-k-mooney | yep like you did for the ohter one | 13:21 |
| jlejeune | yep :) | 13:21 |
| sean-k-mooney | its not a blocker just an anoyance currently | 13:21 |
| sean-k-mooney | i was hopign to do a new release today/tomorrow | 13:22 |
| sean-k-mooney | we could include it if the patch is ready quickly | 13:22 |
| sean-k-mooney | but i dont really want to hold the release just for this | 13:22 |
| jlejeune | I understand | 13:23 |
| mnaser | question.. has anyone ran into this in nova CI? | 13:24 |
| mnaser | `TypeError: canonicalize_version() got an unexpected keyword argument 'strip_trailing_zero'` | 13:24 |
| mnaser | https://zuul.opendev.org/t/openstack/build/7e95381e525e43e6afb34c1a0381e971 | 13:24 |
| mnaser | I know its unmaintained zed but in case this rings a bell and needs us to back port something in specific : | 13:24 |
| dansmith | it's a new change in packageutils or something I think | 13:37 |
| dansmith | I hit it elsewhere outside of openstack | 13:38 |
| dansmith | part of a larger theme of issues everyone has been facing, because the python community decided they should tell us what our version numbers have to look like | 13:38 |
| sean-k-mooney | that has been fixed kind fo | 13:38 |
| sean-k-mooney | its caused by a new release of setuptools conflciting with the max version of packaging we allowed in 2023.1 | 13:39 |
| sean-k-mooney | we resolved that on stable by bumping the max version to the same as 2023.2 | 13:39 |
| sean-k-mooney | alternitivly you can clamp the max veriosn of setup tools on older release | 13:39 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Rephrase the help message https://review.opendev.org/c/openstack/nova/+/925207 | 13:42 |
| mnaser | hmmm | 13:43 |
| mnaser | so I'd have to fix this in requirements | 13:43 |
| mnaser | or cap it inside nova? | 13:43 |
| sean-k-mooney | mnaser: yes you would | 13:47 |
| sean-k-mooney | you cant cap settup tool in requiremnts | 13:47 |
| sean-k-mooney | you could only bump the pacakging version | 13:47 |
| sean-k-mooney | if you didnt want to do that you would have to clamp it in the ci job | 13:47 |
| opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running test when qemu-img binary is missing https://review.opendev.org/c/openstack/nova/+/925208 | 13:50 |
| opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running test when qemu-img binary is missing https://review.opendev.org/c/openstack/nova/+/925208 | 13:56 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: Fix typos and punctuation issues https://review.opendev.org/c/openstack/nova/+/878779 | 13:59 |
| elodilles | mnaser: i'm not sure that patch is needed. i mean, the gate is fine without that patch. but if you could review these CVE related zed backports, that would be awesome o:) (6 patch :S) https://review.opendev.org/c/openstack/nova/+/925018/2 | 13:59 |
| jlejeune | elodilles: hello, following your comment, I backported that commit in 2024.1: https://review.opendev.org/c/openstack/nova/+/925181 | 14:05 |
| elodilles | jlejeune: thanks! looks good to me! +2'd | 14:16 |
| sean-k-mooney | jlejeune: ya we have that dowsn tream too already i agree iwth backporting that | 14:25 |
| jlejeune | elodilles: sean-k-mooney: thanks, I have another small fix on unit test like previous one I made last week: https://review.opendev.org/c/openstack/nova/+/925208 | 14:25 |
| sean-k-mooney | i tought there were already backport of that proposed but i guess not | 14:25 |
| sean-k-mooney | jlejeune: yep i reviewd thats incorrect | 14:25 |
| sean-k-mooney | previosly it was fine to skip if qemu-img was not installed as the tests in question were validtating the behaivor of calling qemu image | 14:26 |
| sean-k-mooney | this test is just missing a mock | 14:26 |
| jlejeune | ok doing | 14:26 |
| mnaser | elodilles: the thing is nova-multistore job is broken so not letting glance job pass so we can't finish landing the CVE fixes in glance :( | 14:43 |
| elodilles | mnaser: ahh, i see | 14:45 |
| elodilles | mnaser: meanwhile i found the issue you mentioned: https://bugs.launchpad.net/neutron/+bug/2073585 | 14:46 |
| mnaser | elodilles: reviewed the zed stuff, lgtm | 14:46 |
| elodilles | mnaser: and it seems there were some discussion in this patch, that might lead to some kind of a fix: https://review.opendev.org/c/openstack/requirements/+/924494 | 14:47 |
| elodilles | mnaser: though i don't see yet what is the right fix o:) | 14:47 |
| mnaser | elodilles: I think here - https://review.opendev.org/c/openstack/requirements/+/925271 | 14:48 |
| opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running https://review.opendev.org/c/openstack/nova/+/925208 | 14:49 |
| elodilles | mnaser: hmmm, that doesn't seem right to me. i mean, upper-constraints shouldn't be updated on non-master branches (except openstack libraries) in general. is the nova-multistore job's tempest coming from master branch, or zed-last tag? | 14:51 |
| elodilles | mnaser: and thanks for reviewing the zed patches o/ I'll fast-approve them then now | 14:53 |
| clarkb | elodilles: I had to push back on that when this issue first came up | 14:56 |
| clarkb | the issue is a requirements upper constraints bug as far as our ability to fix things goes | 14:56 |
| clarkb | we need to have flexibility in policy to understand that these cases do occasionally occur and allow for fixing them when they do | 14:56 |
| clarkb | we can say "policy is to never change this thing" but then you have to accept it will break at some point due to bitrot. The bitrot has occurred. The decision is "do we want to make this work again or not" and less so "what is our policy" imo | 14:58 |
| elodilles | clarkb: yeah, i mean, we had issues in the past, too, when we needed to bump upper version for some external dependencies. but at a first glance this seems to me that (for zed) we should not use latest master from tempest. | 15:00 |
| clarkb | its just a bump of the upper constraint value of a package to a working version | 15:01 |
| clarkb | and things are already broken so the risk of breaking things harder is low | 15:02 |
| elodilles | i'm not against it, fwiw, just saying that maybe we could use zed-last (given that the issue comes from tempest and the fact that we use it from master branch), in that way we can avoid some other bitrot issues in the future o:) | 15:04 |
| clarkb | I don't think changing the branch will fix the problem because the issue is in setuptools | 15:04 |
| elodilles | clarkb: i see, then it's an other issue. of course in that case probably this is the best workaround | 15:05 |
| jlejeune | sean-k-mooney: something like that : https://review.opendev.org/c/openstack/nova/+/925208 ? | 15:12 |
| elodilles | melwitt dansmith : sorry for pinging you, but when you have some time, could you please review these two fix for the cherry-pick-validator script? o:) https://review.opendev.org/c/openstack/nova/+/924104 and https://review.opendev.org/c/openstack/nova/+/924103 | 15:17 |
| sean-k-mooney | jlejeune: that might be too low level | 15:17 |
| bauzas | reminder: nova meeting in 24 mins here | 15:36 |
| jlejeune | sean-k-mooney: you're tlaking about the mock over processutils.execute() function ? | 15:39 |
| sean-k-mooney | so that test shoudl not be doign image inspection really | 15:40 |
| jlejeune | ok so I need to mock create_image() and extract_snapshot() methods ? | 15:40 |
| sean-k-mooney | this is ment to test https://github.com/openstack/nova/blob/7a7427691e0bd4818bb7a2c5f5371e0244addbbb/nova/virt/driver.py#L757C9-L757C17 | 15:42 |
| sean-k-mooney | using the fake driver | 15:42 |
| sean-k-mooney | so https://github.com/openstack/nova/blob/master/nova/virt/fake.py#L213-L216 | 15:43 |
| sean-k-mooney | however it seam like we are using the libvirt fixutre in theses tests instead | 15:43 |
| sean-k-mooney | in the libvirt driver its calling https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L3122 | 15:45 |
| jlejeune | yes | 15:46 |
| sean-k-mooney | we are now intereally callign the image inspection code in that datapaht | 15:46 |
| sean-k-mooney | we sould not be | 15:46 |
| sean-k-mooney | in this thest | 15:46 |
| sean-k-mooney | *test | 15:46 |
| sean-k-mooney | so that is pointing to a gap in the fixutre | 15:47 |
| sean-k-mooney | do you have a traceback of how this failed? | 15:47 |
| jlejeune | here: https://bugs.launchpad.net/nova/+bug/2075178 | 15:47 |
| sean-k-mooney | ok so libvirt_utils.create_image shoudl be stubbed here and should not be callign qemu-img | 15:50 |
| sean-k-mooney | jlejeune: so we need to fix this in https://github.com/openstack/nova/blob/master/nova/tests/unit/virt/test_virt_drivers.py#L817 | 15:53 |
| sean-k-mooney | that subcalses shoudl be stubing the call to create image | 15:53 |
| jlejeune | by adding a new stub | 15:53 |
| jlejeune | ok because I've mocked that function in my ongoing patchset, but I will update it to stub the call instead | 15:54 |
| sean-k-mooney | you are doing it in the wrong place | 15:54 |
| sean-k-mooney | your doing it in the share test function that is used acrros several virt drivers | 15:54 |
| sean-k-mooney | you need to do it in the libvirt specific class that inherits form it | 15:54 |
| jlejeune | ok, ok, I didn't yet pushed it actually | 15:55 |
| jlejeune | I will do it tomorrow, I must leave right now | 15:55 |
| sean-k-mooney | in the bug we see its nova.tests.unit.virt.test_virt_drivers.LibvirtConnTestCase.test_snapshot_running | 15:55 |
| jlejeune | ok I see | 15:55 |
| sean-k-mooney | that is failing so we need to stub it form LibvirtConnTestCase class | 15:55 |
| jlejeune | ok I get it | 15:56 |
| jlejeune | thanks | 15:56 |
| jlejeune | will do it tomoroww, see you | 15:56 |
| sean-k-mooney | dansmith: you might have some insight into what exactly might have changed to cause https://bugs.launchpad.net/nova/+bug/2075178 | 15:58 |
| sean-k-mooney | you mentioned seeing some NotImplementedError in the tests | 15:59 |
| dansmith | I think that's because we call qemu-img in those paths but didn't before right? | 15:59 |
| sean-k-mooney | i had taught we have a poison fixtreure in our tests that prevented all calls to qemu like the libivrt one but perhaps imagined that. | 15:59 |
| sean-k-mooney | yep | 15:59 |
| sean-k-mooney | well yes and no | 16:00 |
| dansmith | not sure if that's comprehensive enough | 16:00 |
| bauzas | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Jul 30 16:00:14 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| sean-k-mooney | we clearly are based on the failure | 16:00 |
| sean-k-mooney | ah lest talk about this after the meeting | 16:00 |
| bauzas | hey folks | 16:00 |
| bauzas | let's do a short meeting if you want | 16:00 |
| bauzas | https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
| bauzas | doh | 16:01 |
| bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:01 |
| bauzas | who's around ? | 16:01 |
| elodilles | o/ | 16:01 |
| dansmith | o/ | 16:01 |
| auniyal | o/ | 16:01 |
| bauzas | let's start | 16:01 |
| bauzas | #topic Bugs (stuck/critical) | 16:02 |
| bauzas | #info No Critical bug | 16:02 |
| bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:02 |
| bauzas | anything people want to talk about bugs ? | 16:02 |
| bauzas | looks nothing | 16:03 |
| bauzas | #topic Gate status | 16:03 |
| bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:03 |
| bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:03 |
| bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:03 |
| bauzas | #info centos9 jobs seem b0rked | 16:03 |
| bauzas | #info centos9 jobs seem b0rked | 16:03 |
| bauzas | same issue for all of them | 16:04 |
| bauzas | Failed to enable unit: Unit file rabbitmq-server.service does not exist. | 16:04 |
| bauzas | I guess a launchpad bug exists for devstack | 16:04 |
| dansmith | maybe they renamed the service or something? | 16:05 |
| dansmith | but, further support for my feeling that stream is not stable enough for us to run tests on :) | 16:05 |
| bauzas | fun fact : apparently no devstack bug report already exists for that issue | 16:06 |
| sean-k-mooney | ya its posible it was renamed | 16:06 |
| sean-k-mooney | im not sure how much we care | 16:06 |
| sean-k-mooney | althoguh its goign to break the fips job | 16:07 |
| bauzas | yeah that's the most possible one | 16:07 |
| sean-k-mooney | thats the only thing that uses it | 16:07 |
| bauzas | it already broke the fips one | 16:07 |
| bauzas | https://zuul.openstack.org/build/1e22dd2615f14f2ea29f34575b822471 | 16:07 |
| sean-k-mooney | it might be good to highlight this to our downstream secuirty folks | 16:07 |
| bauzas | we also run periodic jobs on centos9 for integrated compute | 16:08 |
| sean-k-mooney | althoufu if you have tiem to debug it im sure they would be happy for the help | 16:08 |
| bauzas | I'll just create the devstack bug | 16:08 |
| sean-k-mooney | ack | 16:08 |
| bauzas | and then I could ping folks, but given I'll disappear for 3.1 weeks on Thursday I will wait for other folks | 16:09 |
| bauzas | anyway, moving on | 16:10 |
| bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:10 |
| bauzas | #info Please try to provide meaningful comment when you recheck | 16:10 |
| bauzas | #topic Release Planning | 16:10 |
| bauzas | #link https://releases.openstack.org/dalmatian/schedule.html | 16:10 |
| bauzas | #info Dalmatian-3 in 4 weeks | 16:10 |
| bauzas | #topic Review priorities | 16:10 |
| bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:10 |
| bauzas | I need to modify this etherpad ^ | 16:11 |
| bauzas | to verify which changes are now merged | 16:11 |
| bauzas | #topic Stable Branches | 16:11 |
| bauzas | elodilles: hello ! | 16:11 |
| elodilles | o/ | 16:12 |
| elodilles | #info stable/202*.* gates seem to be OK | 16:12 |
| elodilles | at least i'm not aware any blocking issue :) | 16:12 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:12 |
| elodilles | but if you find any issue then please add it here ^^^ | 16:12 |
| sean-k-mooney | so regardign the stable branches https://review.opendev.org/q/topic:%22bug/2073528%22 is still pending | 16:12 |
| sean-k-mooney | other wise i think we could do a release today/now | 16:13 |
| sean-k-mooney | im around today and tomrow | 16:13 |
| sean-k-mooney | do we want to try and get that landed today | 16:13 |
| sean-k-mooney | or do we want to proceed without it | 16:13 |
| sean-k-mooney | i would hope we could do a release this week | 16:13 |
| sean-k-mooney | elodilles: bauzas: toughts ^ | 16:14 |
| bauzas | I'm good if all the changes are now merged | 16:14 |
| elodilles | i can prepare the release patches today or later, which you prefer best | 16:14 |
| bauzas | elodilles: do this and then ping me please | 16:14 |
| sean-k-mooney | well | 16:15 |
| sean-k-mooney | bauzas: the cve patches are merged but not the cpu govenor ones you ask me to include | 16:15 |
| sean-k-mooney | those are making there way thoguh the gate just not ready right now | 16:15 |
| sean-k-mooney | so what im askign is shall we wait for them | 16:16 |
| sean-k-mooney | or porceed with the current state of the branches | 16:16 |
| bauzas | sean-k-mooney: then we could just wait for them | 16:16 |
| sean-k-mooney | im inclined to say wait 1 more day | 16:16 |
| sean-k-mooney | and do it tomorrow | 16:17 |
| bauzas | tomorrow morning we could look at them | 16:17 |
| elodilles | ACK, sounds good to me too | 16:17 |
| bauzas | thanks elod | 16:17 |
| sean-k-mooney | ok that the only topic i had for stable branches we can move on unless anyone else has one | 16:17 |
| bauzas | thanks | 16:17 |
| bauzas | I don't | 16:17 |
| elodilles | (i did not realise the patch is failed on gate :/) | 16:17 |
| elodilles | nothing else from me either | 16:18 |
| bauzas | ok, moving on then | 16:18 |
| bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:18 |
| bauzas | fwiesel: around ? | 16:18 |
| fwiesel | Yes, sorry | 16:19 |
| bauzas | looks not, no worries | 16:19 |
| bauzas | oh | 16:19 |
| bauzas | then, tell this :) | 16:19 |
| fwiesel | #info Fixed bug in our network driver causing failure in devstack master setup. Working down backlog of old changes affected by it. | 16:19 |
| bauzas | \o/ | 16:19 |
| bauzas | cool, nothing else ? | 16:19 |
| fwiesel | So, if you were missing notifications from the VMware Ci, that should hopefully be fixed now. | 16:19 |
| bauzas | ++ | 16:20 |
| bauzas | thanks | 16:20 |
| bauzas | last topic then | 16:20 |
| bauzas | #topic Open discussion | 16:20 |
| bauzas | I already asked it | 16:20 |
| bauzas | (bauzas) Aug 6, 13 and 20 nova meetings | 16:20 |
| bauzas | so, I'll be PTO on Friday, until Aug 25 | 16:21 |
| bauzas | so either you run the meetings without me, or we punt them | 16:21 |
| bauzas | as folks want | 16:21 |
| gibi | I can take the 6th if others can take the 13th and 20th | 16:21 |
| bauzas | thanks gibi | 16:21 |
| bauzas | I'll just create an email | 16:22 |
| sean-k-mooney | i guess lets defer that to the 6th | 16:22 |
| sean-k-mooney | and see who is around ectra | 16:22 |
| bauzas | okay, I'm done now | 16:22 |
| bauzas | any other stuff to discuss ? | 16:22 |
| sean-k-mooney | we could discssu it off meeting but i have a question for fwiesel | 16:22 |
| bauzas | yes, I'd appreciate | 16:23 |
| bauzas | I'm burned, litterally because of the heat wave :-) | 16:23 |
| bauzas | thanks folks | 16:23 |
| bauzas | #endmeeting | 16:23 |
| opendevmeet | Meeting ended Tue Jul 30 16:23:39 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:23 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-30-16.00.html | 16:23 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-30-16.00.txt | 16:23 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-30-16.00.log.html | 16:23 |
| sean-k-mooney | fwiesel: bauzas: baiscally there are patches we need to reveiw to fix vmware | 16:23 |
| priteau | May I ask for a fairly simple review of https://review.opendev.org/c/openstack/nova/+/924104 which is required to backport some fixes to unmaintained/yoga? | 16:23 |
| sean-k-mooney | but im not sure we are makeing progress on that | 16:23 |
| bauzas | sean-k-mooney: also https://bugs.launchpad.net/devstack/+bug/2075203 | 16:23 |
| bauzas | sean-k-mooney: as I said, I need to review a lot of patches | 16:24 |
| sean-k-mooney | priteau: that a good question i kind of want to say no | 16:24 |
| bauzas | before I'm going off | 16:24 |
| sean-k-mooney | priteau: so the unmaintained banches are not maintined by the core team snd we cant actuly merge patches there by desgin | 16:24 |
| bauzas | anyway, I need to hardstop now, I need some fresh air | 16:24 |
| bauzas | my home office is around 32°C | 16:25 |
| sean-k-mooney | so im not sure if it woudl be better to have a sepreate channel to dicuss those branches or not | 16:25 |
| priteau | sean-k-mooney: I know, but even though elodilles is happy to approve some patches, they are blocked by CI before of the cherry-pick validation | 16:25 |
| elodilles | sean-k-mooney: it's about the tooling, and on master branch, though it is to handle unmaintained branches o:) | 16:25 |
| sean-k-mooney | granted thsi patch is to master for the cherry pick validator | 16:25 |
| sean-k-mooney | but im not sure we shoudl change master of this | 16:25 |
| priteau | The idea was to backport this to all branches one by one so future unmaintained branches would already have the fix | 16:26 |
| priteau | At some point stable/2024.1 will be unmaintained/2024.1 | 16:26 |
| sean-k-mooney | elodilles: yep im just conficlted about adjusting any maintained branch becuse of unmaintianed | 16:26 |
| elodilles | sean-k-mooney: i'd rather change this on master so that we(/i o:)) don't have to fix it everytime a new unmaintained branch is created o:) | 16:26 |
| sean-k-mooney | elodilles: or you turn off that job on umaintainted | 16:27 |
| elodilles | sean-k-mooney: if we use it on stable then i rather keep it on unmaintained | 16:27 |
| sean-k-mooney | in this specific case we proably can but | 16:27 |
| sean-k-mooney | but as a general rule i dont think we shoudl do that | 16:27 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [manila]Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | 16:29 |
| fwiesel | sean-k-mooney: Sorry, I was AFK. There is https://review.opendev.org/c/openstack/nova/+/910627 (on the list) and then there is bug (https://bugs.launchpad.net/nova/+bug/2058225) | 16:29 |
| elodilles | sean-k-mooney: if this would be something complex change i'd vote for the same (don't waste time on master+stable branches), but this is a rather simple fix | 16:30 |
| fwiesel | Hopefully, if we have addressed those then we should be good to go. | 16:30 |
| sean-k-mooney | elodilles: well the reason im bringin it is is by definition we shoudl not be speinding time maintianing the unmainted branches espcially on the ci front | 16:30 |
| sean-k-mooney | in this case i think your right its simple enough to do this | 16:31 |
| sean-k-mooney | but i would not like to see use chanign job defitions on master and backportign them to fix a unmaintinaed job | 16:31 |
| elodilles | ACK, understood | 16:31 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/924103/1 is a good find by the way | 16:32 |
| elodilles | yepp, i was surprised that we have a (non-working) check for that already :) | 16:33 |
| sean-k-mooney | we proably should have a bug for thsoe but im going to ignore that since its just a ci issue not a code one | 16:33 |
| sean-k-mooney | elodilles: i guess its not often that a cherry-pick merges without a merge for some reason | 16:33 |
| sean-k-mooney | although i do wonder if this is perhaps version specific behavior | 16:34 |
| elodilles | for bot proposed patches it is quite often | 16:34 |
| elodilles | hence i updated the commit message in the past with [stable-only] | 16:35 |
| elodilles | after this fix, that won't be necessary anymore \o/ | 16:35 |
| sean-k-mooney | both changes look correct to me so +2 | 16:36 |
| elodilles | thanks o/ | 16:36 |
| sean-k-mooney | although maybe we shoudl try cherry-picking before we mrege them | 16:36 |
| sean-k-mooney | to make sure | 16:36 |
| elodilles | i'll do the cherry picks now | 16:36 |
| sean-k-mooney | i assume you have tried them on stable and unmainted locally and they worked | 16:37 |
| sean-k-mooney | so ci shoudl be similar but it does not hurt to precheck | 16:37 |
| opendevreview | Elod Illes proposed openstack/nova stable/2024.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925278 | 16:38 |
| sean-k-mooney | fwiesel: what i was really getting at is, its great that you ahve ci working | 16:38 |
| opendevreview | Elod Illes proposed openstack/nova stable/2024.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925279 | 16:38 |
| sean-k-mooney | fwiesel: but if there is still no code review happeing of your fixes | 16:38 |
| sean-k-mooney | then its still effectivly unmaintaiend since the issues are not being adressed | 16:39 |
| elodilles | sean-k-mooney: yepp, i've did a quick test | 16:39 |
| opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925280 | 16:40 |
| opendevreview | Elod Illes proposed openstack/nova stable/2023.2: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925281 | 16:40 |
| opendevreview | Elod Illes proposed openstack/nova stable/2023.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925282 | 16:40 |
| opendevreview | Elod Illes proposed openstack/nova stable/2023.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925283 | 16:41 |
| sean-k-mooney | fwiesel: the logs seam to have rotated on http://openstack-ci-logs.global.cloud.sap/openstack-nova-910627-l7ppx/index.html which should be the most recent run for https://review.opendev.org/c/openstack/nova/+/910627 | 16:43 |
| sean-k-mooney | fwiesel: is there a way to recheck your ci and run it again | 16:43 |
| sean-k-mooney | ah sap-openstack-ci recheck | 16:44 |
| fwiesel | sean-k-mooney: sure, I can trigger it again | 16:50 |
| frickler | fwiesel: not directly nova, but while you're around: did you see my comment on cirros #112? we're pretty close to making a new release | 16:52 |
| fwiesel | frickler: I didn't see it, but I'll add a comment. | 16:55 |
| sean-k-mooney | frickler: oh really cool | 16:55 |
| sean-k-mooney | frickler: can you ensure that has the latest avaiable kernel included | 16:56 |
| sean-k-mooney | ideally form ubuntu 24.04 or the upstream lts branch | 16:56 |
| sean-k-mooney | if its still on a 22.04 based kernel that ok but ideally it would be updated to the latest hwe kernel | 16:57 |
| frickler | sean-k-mooney: my plan was to do 0.6.3 with the latest 22.04 kernel, then try to bump both buildroot and 24.04 kernel for 0.7.0 (cf. https://github.com/cirros-dev/cirros/pull/117) | 17:09 |
| sean-k-mooney | cool | 17:10 |
| sean-k-mooney | that sounds good | 17:10 |
| opendevreview | Merged openstack/nova stable/2024.1: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/925181 | 18:15 |
| opendevreview | Merged openstack/nova master: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/924103 | 18:15 |
| opendevreview | Merged openstack/nova master: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/924104 | 18:15 |
| *** bauzas_ is now known as bauzas | 20:11 | |
| opendevreview | Masahito Muroi proposed openstack/nova master: Change instance_system_metadata value to Text type https://review.opendev.org/c/openstack/nova/+/925163 | 20:32 |
| *** bauzas_ is now known as bauzas | 21:14 | |
| *** bauzas_ is now known as bauzas | 21:55 | |
| *** bauzas_ is now known as bauzas | 23:07 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!