| *** bauzas_ is now known as bauzas | 06:58 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [manila]Use client token when talking to manila https://review.opendev.org/c/openstack/nova/+/925277 | 07:13 |
|---|---|---|
| opendevreview | Fabian Wiesel proposed openstack/nova master: Vmware: Remove uuid parameter from get_vmdk_info call https://review.opendev.org/c/openstack/nova/+/910627 | 07:52 |
| *** bauzas_ is now known as bauzas | 08:09 | |
| opendevreview | Adam Oswick proposed openstack/nova master: Refactor _get_pci_passthrough_devices function https://review.opendev.org/c/openstack/nova/+/925382 | 11:32 |
| jlejeune | sean-k-mooney: bauzas: hello, I found why the test_snapshot_running is now failing: https://bugs.launchpad.net/nova/+bug/2075178/comments/1 | 12:59 |
| sean-k-mooney | jlejeune: yes we discussed that change in behavior with dansmith and it was noted in the commit message | 13:00 |
| sean-k-mooney | jlejeune: https://github.com/openstack/nova/commit/d5a631ba7791b37e49213707e4ea650a56d2ed9e | 13:00 |
| sean-k-mooney | """Note that this includes seemingly-unrelated test changes because we | 13:01 |
| sean-k-mooney | were actually skipping the snapshot_running test for libvirt, which | 13:01 |
| sean-k-mooney | has been a bug for years. In that test case, when we went to look | 13:01 |
| sean-k-mooney | for image_meta.disk_format, that attribute was not set on the o.vo | 13:01 |
| sean-k-mooney | object, which raised a NotImplementedError. That error is also checked | 13:01 |
| sean-k-mooney | by the test to skip the test for drivers that do not support snapshot, | 13:01 |
| sean-k-mooney | which meant that for libvirt, we haven't been running that case | 13:01 |
| sean-k-mooney | beyond the point at which we create snapshot metadata and trip that | 13:01 |
| sean-k-mooney | exception.""" | 13:01 |
| sean-k-mooney | dan added some stubs https://github.com/openstack/nova/commit/d5a631ba7791b37e49213707e4ea650a56d2ed9e#diff-4104495b69c5ecf83423c1b9aafa2a8b55e2f8ebbd4cc36a5299206a004263d2R835 | 13:02 |
| sean-k-mooney | buy i guess is missign one | 13:02 |
| jlejeune | y es I saw them | 13:02 |
| jlejeune | I will add new ones, but I have also to mock file_open() utils function, is it ok for you if I mock it at the test level ? | 13:04 |
| sean-k-mooney | you shoudl not need to mock file_open | 13:07 |
| sean-k-mooney | you idealy you woudl mock hihger then that as mocking file open may breakt things | 13:08 |
| sean-k-mooney | we basically want to mock the file inspector methods i think | 13:09 |
| sean-k-mooney | oh its nova.virt.libvirt.utils.file_open | 13:19 |
| sean-k-mooney | not open() | 13:19 |
| sean-k-mooney | ya we might want to add that to the global poion at some point | 13:19 |
| jlejeune | :) | 13:23 |
| elinux | can someone comment on this please https://bugs.launchpad.net/nova/+bug/2075150 | 13:47 |
| elinux | anyone online yet ? | 13:56 |
| opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running https://review.opendev.org/c/openstack/nova/+/925208 | 13:57 |
| opendevreview | Julien Le Jeune proposed openstack/nova stable/2023.2: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905135 | 14:07 |
| jlejeune | elodilles: hello, I've updated the review by cherry-picking the right commit from 2024.1 branch if you want to have a look: https://review.opendev.org/c/openstack/nova/+/905135 | 14:24 |
| opendevreview | Adam Oswick proposed openstack/nova master: Refactor _get_pci_passthrough_devices function https://review.opendev.org/c/openstack/nova/+/925382 | 14:25 |
| opendevreview | Julien Le Jeune proposed openstack/nova master: Fix test_snapshot_running https://review.opendev.org/c/openstack/nova/+/925208 | 14:30 |
| elodilles | jlejeune: looks good, thanks! +2+W'd | 14:35 |
| opendevreview | Merged openstack/nova stable/2024.1: [tools] Ignore bot generated patches https://review.opendev.org/c/openstack/nova/+/925278 | 16:49 |
| opendevreview | Merged openstack/nova stable/2024.1: [tools] Backport validator: handle unmaintained https://review.opendev.org/c/openstack/nova/+/925279 | 16:49 |
| opendevreview | Merged openstack/nova stable/2023.2: Refactor vf profile for PCI device https://review.opendev.org/c/openstack/nova/+/905135 | 18:03 |
| *** bauzas_ is now known as bauzas | 18:09 | |
| *** bauzas_ is now known as bauzas | 20:04 | |
| opendevreview | Merged openstack/nova stable/2024.1: cpu: Only check governor type on online cores https://review.opendev.org/c/openstack/nova/+/924514 | 21:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!