| *** bauzas_ is now known as bauzas | 02:39 | |
| *** bauzas_ is now known as bauzas | 04:47 | |
| *** elodilles_pto is now known as elodilles | 05:51 | |
| *** bauzas_ is now known as bauzas | 07:37 | |
| songwenping | hi team, i have update libvirt-python to lastest version of 10.6.0, but also meet the error: module 'libvirt' has no attribute 'VIR_NODE_DEVICE_CREATE_XML_VALIDATE', any advice? | 08:45 |
|---|---|---|
| gibi | songwenping: the libvirt api def still documents that flag https://libvirt.org/html/libvirt-libvirt-nodedev.html#virNodeDeviceCreateXMLFlagsh | 09:00 |
| gibi | and I can import it in 10.5.0 | 09:02 |
| gibi | bash-5.1$ rpm -qa | grep python3-libvirt | 09:02 |
| gibi | python3-libvirt-10.5.0-1.el9.x86_64 | 09:02 |
| gibi | bash-5.1$ python3 | 09:02 |
| gibi | Python 3.9.19 (main, Jul 18 2024, 00:00:00) | 09:02 |
| gibi | [GCC 11.4.1 20231218 (Red Hat 11.4.1-3)] on linux | 09:02 |
| gibi | Type "help", "copyright", "credits" or "license" for more information. | 09:02 |
| gibi | >>> import libvirt | 09:02 |
| gibi | >>> libvirt.VIR_NODE_DEVICE_CREATE_XML_VALIDATE | 09:02 |
| gibi | 1 | 09:02 |
| gibi | >>> | 09:02 |
| songwenping | my OS is ubuntu2204, i will try 10.5.0 | 09:03 |
| gibi | hm I pulled 10.6.0 from pypi and I can still import the constant : https://paste.opendev.org/show/b0IJ31RkWUw7MvcqpReb/ | 09:04 |
| frickler | should one generally use libvirt-python from the distro to match the installed libvirt? and thus not use it from pypi at all? | 09:06 |
| songwenping | yeah, tried 10.5.0, still has no this attribute. | 09:07 |
| gibi | frickler: I would say, use the matching version | 09:07 |
| frickler | fwiw I don't see the above symbol either on 22.04, libvirt version 8.0.0-1ubuntu7.10 | 09:16 |
| frickler | songwenping: do you use libvirt from ubuntu or a newer version built from source? | 09:16 |
| songwenping | libvirt on ubuntu with 'pip install libvirt-python' | 09:18 |
| gibi | frickler: I don't see it either in ubuntui 22.04 installed python-libvirt with apt | 09:21 |
| songwenping | i replace VIR_NODE_DEVICE_DEFINE_XML_VALIDATE with 1 and the vm is created successful. | 09:23 |
| frickler | I only found this single ref in nova code, does it mean this is not tested on 22.04? or does it need newer libvirt from UCA? can't check the latter right now https://opendev.org/openstack/nova/blame/branch/master/nova/virt/libvirt/host.py#L1267 | 09:26 |
| gibi | nova declares libvirt min version as 8.0.0 | 09:27 |
| gibi | https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L221 | 09:27 |
| frickler | but devstack loads uca, so maybe this isn't really tested anywhere | 09:28 |
| gibi | yeah | 09:28 |
| frickler | also MIN_LIBVIRT_VERSION is still 7.0.0, NEXT_MIN_LIBVIRT_VERSION is only for the future, isn't it? | 09:29 |
| gibi | frickler: sorry you are right | 09:29 |
| gibi | frickler: so yeah we should work with 7.0.0 | 09:30 |
| gibi | but the persistent mdev feature that introduced the usage of the constant only enabled with 7.3.0 or higher https://github.com/openstack/nova/commit/74befb68a79f8bff823fe067e0054504391ee179#diff-486ddc37ce8e7c105a51566dd2cffbda034f28fae7eaad2e74abf470ab296352R248 | 09:31 |
| gibi | still it seems the constant is missing in those old libvirts | 09:31 |
| frickler | seems uca no longer has newer libvirt, so devstack is running with the same 8.0.0 currently that I checked. makes me wonder why tests aren't failing, or maybe there is no integrated test for mdevs? | 09:42 |
| gibi | frickler: we test with 8.0.0 https://zuul.opendev.org/t/openstack/build/38facdd66a1e4e69bd6995fea4174d82/log/job-output.txt#9305 we just don't test mdevs | 09:42 |
| sean-k-mooney | frickler: we dont test mdevs upstream yet | 09:43 |
| sean-k-mooney | frickler: it requires us to compile a kernel module | 09:43 |
| gibi | I think we will test is via https://review.opendev.org/q/topic:%22mtty_support%22 | 09:43 |
| sean-k-mooney | frickler: bauzas is currently working on a job for that | 09:43 |
| sean-k-mooney | gibi: yep that the series | 09:44 |
| sean-k-mooney | although at the moment bauzas is working on it in a different job instead of nova-next like we orginally proposed | 09:44 |
| gibi | frickler, sean-k-mooney: so to conclude we have a bug on master as with libvirt 7.3.0 (or 8.0.0) the persistent mdev feature does not work due to the missing constant libvirt.VIR_NODE_DEVICE_CREATE_XML_VALIDATE | 09:44 |
| gibi | I will file a bug... | 09:45 |
| sean-k-mooney | am we are ment to have a falback | 09:45 |
| sean-k-mooney | thats form melwitt's series | 09:45 |
| sean-k-mooney | we only supprot persistance in a later libvirt and falback to the old way when runingon older libvirt | 09:46 |
| sean-k-mooney | at least that was teh plan | 09:46 |
| gibi | https://github.com/openstack/nova/commit/74befb68a79f8bff823fe067e0054504391ee179#diff-486ddc37ce8e7c105a51566dd2cffbda034f28fae7eaad2e74abf470ab296352R248-R252 | 09:46 |
| gibi | these are the checks | 09:46 |
| gibi | on the libvirt version | 09:46 |
| gibi | but the constant is not even in 8.0.0 | 09:47 |
| sean-k-mooney | i wonder if they complied it out | 09:47 |
| gibi | I don't know how to check that | 09:48 |
| sean-k-mooney | that or that support came later. | 09:48 |
| sean-k-mooney | https://github.com/libvirt/libvirt/blob/049846497b9e8a3eec82bfdcf3ebfe7c15e62c55/include/libvirt/libvirt-nodedev.h#L152 | 09:49 |
| sean-k-mooney | so that looks liek the validation is a 8.10.0 feature | 09:49 |
| gibi | https://github.com/libvirt/libvirt/commit/d8791c3c7caa6e3cadaf98a5a2c94b232ac30fed | 09:49 |
| gibi | yeah I found the same thing | 09:50 |
| sean-k-mooney | so looking at that | 09:50 |
| sean-k-mooney | the validation was only added in 8.10. | 09:50 |
| gibi | so we either need to remove the flag or change the version guard | 09:50 |
| sean-k-mooney | right | 09:50 |
| gibi | I lean towards changing th guard | 09:50 |
| sean-k-mooney | so for 8.10+ we can pass the validation | 09:51 |
| gibi | as this is on master | 09:51 |
| sean-k-mooney | and below that no flag | 09:51 |
| sean-k-mooney | why? | 09:51 |
| sean-k-mooney | schma validation is nice to have but it was never part of the feature | 09:51 |
| frickler | ah, likely that's why the experimental job runs on 24.04 which has 10.0.0 | 09:52 |
| sean-k-mooney | frickler: thats not the only reason but one of them | 09:52 |
| gibi | OK from that perspective we can make the flag version dependent. My viewpoint was that on master we can require newer libvirt | 09:52 |
| sean-k-mooney | frickler: this code was tested with centos 9 with 8.10 | 09:52 |
| sean-k-mooney | gibi: ya im not sure if we are alowed to do that bump this cycle or if we are allwoed to do it next | 09:53 |
| sean-k-mooney | i wanted to do it on the non slurps | 09:53 |
| sean-k-mooney | so advertise the next version during a slurp and bump in the next non slurp | 09:54 |
| sean-k-mooney | meanign we could bump it now but we cant really do that until we move to noble | 09:54 |
| sean-k-mooney | so for this release i woudl just add the version check | 09:54 |
| gibi | sean-k-mooney: ack, make sense, we have a dependency on noble :/ | 09:54 |
| sean-k-mooney | and we can remove that when we bump | 09:54 |
| * gibi filing bug | 09:54 | |
| gibi | https://bugs.launchpad.net/nova/+bug/2076163 | 09:58 |
| elodilles | auniyal Uggla : when you have some time, could you please take a look at these release patches? https://review.opendev.org/c/openstack/releases/+/925646 & https://review.opendev.org/c/openstack/releases/+/925647 | 10:57 |
| elodilles | if you have any question then feel free to ping me | 10:57 |
| jlejeune | elodilles: hello, after your release, will you have some time to review my patchs please ? https://review.opendev.org/c/openstack/nova/+/899379 and https://review.opendev.org/c/openstack/nova/+/901655 | 12:21 |
| elodilles | jlejeune: just to note, i'm not core reviewer on master branch, I don't have +2 rights on master, I'm only stable maintainer core member o:) | 12:54 |
| jlejeune | elodilles: ho sorry for the misunderstanding, I saw that you were very active so I thought you were a core reviewer, my bad :) | 13:01 |
| sean-k-mooney | jlejeune: https://review.opendev.org/c/openstack/nova/+/899379 is not a correct fix | 13:04 |
| sean-k-mooney | jlejeune: also as a aside no one form the core team has reviewd https://bugs.launchpad.net/nova/+bug/2040986 to confirm if its even valid and ^ did not include a repoducer functional test to demponstarte the bug | 13:06 |
| jlejeune | ok, sorry I'm not yet very familiar with the process... | 13:17 |
| jlejeune | now you have seen the bug report, what do you think about it ? | 13:17 |
| sean-k-mooney | so https://bugs.launchpad.net/nova/+bug/2040986 is partly valid. the request spec shoudl not have the property for iamge b | 13:21 |
| sean-k-mooney | when it faild | 13:21 |
| sean-k-mooney | but the issue is not that we dont revert request spec content | 13:21 |
| sean-k-mooney | it shoudl not have been updated unless it passed the schduler | 13:21 |
| sean-k-mooney | fixing the issue in the excpt class is invliad as propsoed because its trying to use the info form glance and not corm the cell db copy | 13:22 |
| jlejeune | yes we are treating the symthom and not the bug itself, agree about that | 13:22 |
| sean-k-mooney | ideally we woudl fix the orginal issue by not saving the modifed request spec until after the schduler says its ok | 13:22 |
| sean-k-mooney | jlejeune: back to the procedure topic the first step in fixing the bug should be to create a functional regression test for the bug to demonstarte the incorrect behaivor | 13:23 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1732947.py and https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_2040264.py are two examples of rebuidl regression tests for past bugs | 13:24 |
| sean-k-mooney | https://github.com/openstack/nova/commit/21fd0c430c714d21c52e0a0c996351c374a3e3d6 and https://github.com/openstack/nova/commit/ee9ed0f7c6abf7c4847e6dc31f6d3d79b25b9d99 | 13:25 |
| sean-k-mooney | demontrate the standard pattern | 13:25 |
| jlejeune | are the regression tests are always mandatory ? because I see a lot of changes without them | 13:41 |
| artom | jlejeune, strongly encouraged when fixing bugs. Our so-called "functional" tests are advanced enough that most bugs, even races, can be reproduced with them, with judicious use of stubs or mocks. The accepted standard practice is to first demonstrate the bug in a functional test, then with the patch on top demonstrate that the fix does what it's supposed to. | 13:45 |
| artom | jlejeune, other than that, regression tests are not mandatory (and even for bug fixes there can be exceptions, depending on the nature of the bug). | 13:45 |
| sean-k-mooney | jlejeune: we dont always requrie a funcitonal repoducer sometime unit test repoducer are also fine but for anyting like rebuild or an change that is not targeted to a very speciifc part of code i.e. the xml generation or logging its almost alwayys requried | 13:47 |
| jlejeune | ok so in that case, I need to ? | 13:51 |
| sean-k-mooney | yes in this case you are trying to fix an issue that hapens as a result of multipel api action and an interaction betwwen the conductor and schduler resulting in incositenies betwwen two dbs | 13:52 |
| sean-k-mooney | that is not somethign that unit tests are sufficent to demondatate | 13:52 |
| sean-k-mooney | so we woudl generally requrie a fucntioanl repoducer test | 13:52 |
| jlejeune | ok | 13:53 |
| sean-k-mooney | this is a littel out of date but this is where that was orignally documented https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/README.rst#tests-for-specific-regressions | 13:54 |
| sean-k-mooney | the bit that is a littel out of date is "These should be full stack tests which inherit from nova.test.TestCase directly." | 13:54 |
| sean-k-mooney | that is still prefered but not required anymore | 13:55 |
| sean-k-mooney | it can be a heavy lift to set up all the fixtures unless you are deeply familar with how our test work | 13:55 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block https://review.opendev.org/c/openstack/nova/+/925771 | 13:56 |
| sean-k-mooney | so we do allow inheriting form ntegrated_helpers._IntegratedTestBase | 13:56 |
| sean-k-mooney | as is done in https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1732947.py | 13:56 |
| sean-k-mooney | or sometimes even the libvirt specific vairiant however if its not virt driver specific we avoid using the more complex base classes | 13:57 |
| jlejeune | ok I will try | 13:59 |
| *** bauzas_ is now known as bauzas | 14:05 | |
| jlejeune | artom: sean-k-mooney: and what about that one: https://review.opendev.org/c/openstack/nova/+/901655 ? | 14:11 |
| artom | jlejeune, IMO that's simple enough to not need a reproducer. | 14:13 |
| sean-k-mooney | that ism more incliend to say is a valid bug but on the other hand im not eintrly sure its safe to not mark the instnace as in error | 14:13 |
| sean-k-mooney | if the rpc timeout happens in pre live migrate i agree the instance should stay in active | 14:14 |
| sean-k-mooney | and only the migration should be in error | 14:14 |
| sean-k-mooney | so https://review.opendev.org/c/openstack/nova/+/901655/4/nova/compute/manager.py i think is the correct approch in this case | 14:15 |
| sean-k-mooney | if the rpc timeout happesn after we have started the migration its get harder | 14:16 |
| sean-k-mooney | jlejeune: i woudl prefer ot have a fucntioal repoducer for that too | 14:17 |
| sean-k-mooney | but i think the way its being fixed is generally ok | 14:18 |
| *** ministry is now known as __ministry | 15:04 | |
| *** ykarel is now known as ykarel|away | 15:29 | |
| gibi | nova meeting starts here in 15 minutes | 15:45 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Detect AMD SEV-ES support https://review.opendev.org/c/openstack/nova/+/925685 | 15:55 |
| gibi | #startmeeting nova | 16:00 |
| opendevmeet | Meeting started Tue Aug 6 16:00:48 2024 UTC and is due to finish in 60 minutes. The chair is gibi. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
| opendevmeet | The meeting name has been set to 'nova' | 16:00 |
| elodilles | o/ | 16:00 |
| gibi | I will be your host today as bauzas is on PTO | 16:01 |
| dansmith | o/ | 16:01 |
| gibi | #topic Bugs (stuck/critical) | 16:02 |
| tkajinam | o/ | 16:02 |
| gibi | #info No Critical bug | 16:02 |
| gibi | is there any bug that we need to discuss? | 16:02 |
| gibi | #topic Gate status | 16:03 |
| gibi | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:03 |
| gibi | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:03 |
| gibi | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:03 |
| gibi | centos 9 based jobs are still read | 16:04 |
| gibi | red | 16:04 |
| gibi | due to | 16:04 |
| gibi | Failed to enable unit: Unit file rabbitmq-server.service does not exist. | 16:04 |
| dansmith | so some work was done in devstack recently, | 16:04 |
| dansmith | related to the release repo, which I thought was going to fix some of it | 16:05 |
| dansmith | rocky started working at least | 16:05 |
| dansmith | but it was also (re-)asserted that stream is making it clear it's not stable enough for our purposes, which I definitely agree with :) | 16:05 |
| dansmith | https://review.opendev.org/c/openstack/devstack/+/925368?tab=change-view-tab-header-zuul-results-summary | 16:06 |
| gibi | thank dansmith for the pointers | 16:07 |
| gibi | If somebody has the time to investigate further then go for it. :) | 16:08 |
| gibi | but I guess as it is not blocking the CI directly it will take a while to get to it | 16:08 |
| gibi | anything else about the centos jobs or about the gate in general? | 16:09 |
| gibi | #topic Release Planning | 16:10 |
| gibi | #link https://releases.openstack.org/dalmatian/schedule.html | 16:10 |
| gibi | #info Dalmatian-3 in 3 weeks | 16:10 |
| gibi | #topic Review priorities | 16:10 |
| gibi | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:10 |
| gibi | Is there anything to discuss about the upcoming release? | 16:11 |
| tkajinam | there is one open follow-up edit of the spec. would be nice if it can be quickly reviewed https://review.opendev.org/c/openstack/nova-specs/+/924563 | 16:12 |
| gibi | tkajinam: I will look at it after the meeting | 16:12 |
| tkajinam | gibi, thx ! | 16:12 |
| gibi | #topic Stable Branches | 16:13 |
| gibi | elodilles: hi! :) | 16:13 |
| elodilles | o/ | 16:13 |
| elodilles | #info stable/202*.* gates seem to be OK | 16:13 |
| elodilles | #info nova stable release patches (with CVE fix): https://review.opendev.org/q/project:openstack/releases+intopic:nova+is:open | 16:14 |
| sean-k-mooney | dansmith: it may be worth condiering if the fibs jobs could move to rocky to be slightly more stable but ya i still agree in general. we can discusus that later if peopel want to do that work outside the meeting or in open dicussion at the end | 16:14 |
| elodilles | waiting for release liaison reviews ^^^ o:) | 16:14 |
| gibi | bauzas and Uggla are on PTO | 16:14 |
| elodilles | gibi: ACK | 16:14 |
| sean-k-mooney | amit is also a release liason | 16:14 |
| dansmith | sean-k-mooney: yep | 16:15 |
| elodilles | then auniyal is the only available release liaison o:) | 16:15 |
| sean-k-mooney | auniyal: ^ can you prioitse that | 16:15 |
| elodilles | thanks in advance o:) | 16:15 |
| elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:15 |
| elodilles | if anyone finds any gate issue then please add it there ^^^ | 16:16 |
| elodilles | that's all about stable from me | 16:16 |
| gibi | elodilles: thanks! | 16:17 |
| elodilles | np | 16:17 |
| gibi | #topic vmwareapi 3rd-party CI efforts Highlights | 16:17 |
| gibi | #info fwiesel on PTO until the 27th August. | 16:17 |
| gibi | so I guess no news here | 16:17 |
| gibi | #topic Open discussion | 16:17 |
| gibi | (bauzas) Aug 6, 13 and 20 nova meetings | 16:17 |
| gibi | so I took today's meeting but cannot do 13th or 20th | 16:18 |
| gibi | any volunteer? | 16:18 |
| gibi | then they are cancelled | 16:20 |
| gibi | #info the meeting on the 13th and on the 20th are cancelled | 16:20 |
| gibi | any other topic for today? | 16:21 |
| dansmith | ++ for cancel :) | 16:21 |
| gibi | I guess we are done for today then | 16:23 |
| gibi | #endmeeting | 16:23 |
| opendevmeet | Meeting ended Tue Aug 6 16:23:31 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:23 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-06-16.00.html | 16:23 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-06-16.00.txt | 16:23 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-06-16.00.log.html | 16:23 |
| elodilles | thanks o/ | 16:23 |
| gibi | thanks folks | 16:23 |
| tkajinam | thanks | 16:24 |
| opendevreview | Merged openstack/nova-specs master: Follow up for "libvirt: AMD SEV-ES support" https://review.opendev.org/c/openstack/nova-specs/+/924563 | 16:24 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block https://review.opendev.org/c/openstack/nova/+/925771 | 18:09 |
| opendevreview | Artom Lifshitz proposed openstack/nova master: POC/DNM: Remove vTPM live migration block https://review.opendev.org/c/openstack/nova/+/925771 | 18:31 |
| *** bauzas_ is now known as bauzas | 19:37 | |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Check version for node device XML validate flags https://review.opendev.org/c/openstack/nova/+/925826 | 23:09 |
| melwitt | fyi gibi and sean-k-mooney ^ thanks songwenping_ for reporting the issue | 23:14 |
| sean-k-mooney | melwitt: that wont work | 23:17 |
| sean-k-mooney | the api does not have a flags filed before 8.10.0 | 23:17 |
| sean-k-mooney | melwitt: so you ned to change the function call rahter then the flags | 23:18 |
| melwitt | sean-k-mooney: ugh dammit. thanks 😩 | 23:18 |
| sean-k-mooney | actully | 23:19 |
| sean-k-mooney | no i miss read the c code | 23:19 |
| sean-k-mooney | https://github.com/libvirt/libvirt/commit/d8791c3c7caa6e3cadaf98a5a2c94b232ac30fed#diff-29f62ad20a5a2dffc62d8d09df5ef6e7b28c36c723ae7da56eb371c7547fbf98L70 | 23:19 |
| sean-k-mooney | so it was passing a hardcoded 0 for flags before | 23:19 |
| sean-k-mooney | so your change shoudl be good | 23:19 |
| sean-k-mooney | ill review it properly tomorrow after we see what ci says | 23:20 |
| sean-k-mooney | the docs change clarifies it | 23:20 |
| sean-k-mooney | https://github.com/libvirt/libvirt/commit/d8791c3c7caa6e3cadaf98a5a2c94b232ac30fed#diff-7552129210db333b0c2e3d224d1ae11a674bbb0b56f6b2708452be4e0c023a98L697 | 23:20 |
| sean-k-mooney | @flags: extra flags; not used yet, so callers should always pass 0 | 23:20 |
| sean-k-mooney | to * @flags: bitwise-OR of supported virNodeDeviceCreateXMLFlags | 23:20 |
| melwitt | ah ok, I have seen they have that for some APIs where it takes flags of 0 as sort of a placeholder | 23:22 |
| sean-k-mooney | yep | 23:22 |
| sean-k-mooney | the try to future proof may apis by allowing flags even if not supproted | 23:23 |
| sean-k-mooney | i guess that semi reasonabel for c to not break abi compatiablity | 23:23 |
| *** bauzas_ is now known as bauzas | 23:45 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!