opendevreview | Merged openstack/os-vif master: Drop kuryr-kubernetes-tempest https://review.opendev.org/c/openstack/os-vif/+/941568 | 02:47 |
---|---|---|
opendevreview | sean mooney proposed openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | 02:51 |
opendevreview | sean mooney proposed openstack/nova master: per-property ImageMetaPropsWeigher https://review.opendev.org/c/openstack/nova/+/941601 | 02:51 |
opendevreview | sean mooney proposed openstack/nova master: Per-Property ImageMetaPropsWeigher https://review.opendev.org/c/openstack/nova/+/941601 | 03:00 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 04:27 |
melwitt | sean-k-mooney, dansmith: partial revert is proposed ^. I wasn't sure if we should have a release note as I think none of the branches have been released yet with the regression? | 04:28 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 04:30 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 04:35 |
sean-k-mooney | melwitt: i think your right that we have not had a release with it. its possibel someone picked it up from master or stabel in a downstream or directly but its unlikely. | 11:21 |
dansmith | gibi: did you want to re-review the imageprops weigher or should I +W? | 14:54 |
opendevreview | Johannes Kulik proposed openstack/nova master: libvirt: fix maxphysaddr passthrough dom parsing https://review.opendev.org/c/openstack/nova/+/942371 | 15:11 |
gibi | dansmith: go ahead I will have no time today to get back to it. I did not review the original impl either just discussed the high level design. | 15:26 |
dansmith | okay | 15:26 |
gibi | dansmith: I think we are in agreement of the design, and I trust your review about the impl | 15:27 |
dansmith | gibi: ack | 15:27 |
dansmith | bauzas: if you want to +W the patch below the first two can land, waiting on a recheck of the third | 15:27 |
bauzas | dansmith: sure | 15:27 |
sean-k-mooney | while we are talking about merging things can someone +2w this https://review.opendev.org/c/openstack/os-vif/+/941585 so i can propose a os-vif release | 15:45 |
sean-k-mooney | we need to do that today so we can bump it in uc before the non clinet lib freeze | 15:46 |
sean-k-mooney | also once https://review.opendev.org/c/openstack/nova/+/940873 is merged we can merge the spice direct series | 15:47 |
sean-k-mooney | well almost we also need to merge https://review.opendev.org/c/openstack/tempest/+/942023 but thats approved | 15:50 |
sean-k-mooney | it just hitting random ci failure that are not related to it | 15:51 |
melwitt | sean-k-mooney: thanks for looking at the patch, I'll check out your comments | 16:28 |
opendevreview | Merged openstack/nova master: Add fill_metadata() to InstanceList https://review.opendev.org/c/openstack/nova/+/942214 | 17:35 |
melwitt | sean-k-mooney: I added a comment on the nova-ovs-hybrid-plug patch, few release note things left | 17:35 |
sean-k-mooney | ya... so i fixed those in my editor but didnt hit save before i commited and pushed. | 17:36 |
sean-k-mooney | melwitt: would you like me to respin or would you be happy with a followup patch on top | 17:41 |
melwitt | sean-k-mooney: yeah I guess put a follow up so we don't lose bauzas +2 | 17:42 |
sean-k-mooney | that was my concern i was hoping ot let this and perhasp the speic sereise merge/recheck over the weekend | 17:42 |
melwitt | ++ | 17:43 |
melwitt | I think it's good, just waiting for the tempest change to merge to get that last sanity check on the series, then I can go through and +W them | 17:44 |
opendevreview | sean mooney proposed openstack/nova master: FUP for reno issues https://review.opendev.org/c/openstack/nova/+/942386 | 17:44 |
melwitt | CI has been extra bad on the tempest patch for some reason | 17:45 |
sean-k-mooney | ya so with ci changes the last patch cant merge until tempest is fixed | 17:45 |
sean-k-mooney | but i was also going to wait for that to happen before putting +w on the bottom of the seriese | 17:45 |
bauzas | I'm done now for the week | 17:46 |
sean-k-mooney | melwitt: im not sure why the tempest patch has been so unfortunete | 17:47 |
sean-k-mooney | im hoping it maybe load related | 17:47 |
sean-k-mooney | and it will stableise before next week and FF propper | 17:47 |
melwitt | yeah. I think that has been a big factor | 17:48 |
sean-k-mooney | bauzas: Uggla how is offically PTL/release liason currently | 17:48 |
melwitt | sean-k-mooney: agree with waiting for tempest sanity check before +W the bottom of the series. I guess that's what I really meant | 17:48 |
sean-k-mooney | im keen ot get this over the line so i was plannign to check in on it over the weekend, of couse if ti merges before then even better | 17:49 |
sean-k-mooney | bauzas: Uggla the reason im asking is i need to do the os-vif release later today and ill need ptl/release liason approval on that patch | 17:49 |
melwitt | +1 to getting this done | 17:50 |
sean-k-mooney | i guess bauzas is ptl in the governace repo and Uggla or amit is a release liason | 17:50 |
melwitt | yeah I think it won't swap in Uggla until this cycle closes probably. I don't remember what day of the cycle they use for that tho | 17:51 |
sean-k-mooney | i think your right i belive its after the offial release but ill jsut check what is in git | 17:52 |
sean-k-mooney | so ya rene and ammit are release liasons and can approve https://github.com/openstack/releases/blob/master/data/release_liaisons.yaml#L90-L96 | 17:53 |
Uggla | sean-k-mooney, I'm not sure it is official yet. And at least I'm not ready for that yet. :) | 17:53 |
sean-k-mooney | the osvif patch need to be recheck again anyay it failed in gate... | 17:54 |
opendevreview | Merged openstack/nova master: Add a new ImagePropertiesWeigher https://review.opendev.org/c/openstack/nova/+/940642 | 18:02 |
mikal | Morning | 19:12 |
sean-k-mooney | mikal: o/ | 19:17 |
sean-k-mooney | mikal: we are stuggallign to get your tempest change merged | 19:17 |
sean-k-mooney | it keeps hitting random unrelated isseus altough im partly concerd about the ironic failure | 19:18 |
sean-k-mooney | it snot related to our change that i cna see but the ipa job failed twice now | 19:19 |
sean-k-mooney | mikal: im hoping it just load related and a recheck at a less busy time will pass | 19:19 |
mikal | Yeah, I am not sure I see how my tempest test would affect ironic at all. | 19:24 |
mikal | Thank you for chasing it though. | 19:24 |
sean-k-mooney | most of us are off tomorrow but im goign to t check in perodicaly over the weekend | 19:25 |
sean-k-mooney | if the tempest fix is merged and my job fix merges hten ill trigger one recheck on the top patch and if that passes ill approve the 3 pathces for spice direct | 19:26 |
sean-k-mooney | im actully goign to finish now so ill be online intermitntly later to check in | 19:27 |
mikal | sean-k-mooney: no worries. Thanks for keeping an eye on it. | 19:37 |
MengyangZhang[m] | sean-k-mooney: I saw your comment about the min check yesterday. Just wondering if we still want to have it. I looked into the API code a bit and I don't think it's trivial to implement it. | 19:39 |
opendevreview | Merged openstack/nova master: move nova-ovs-hybrid-plug to deploy with spice and fix qxl default https://review.opendev.org/c/openstack/nova/+/940873 | 20:16 |
opendevreview | Merged openstack/nova master: FUP for reno issues https://review.opendev.org/c/openstack/nova/+/942386 | 20:16 |
opendevreview | Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 21:14 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942402 | 21:33 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 21:40 |
*** haleyb is now known as haleyb|out | 22:49 | |
opendevreview | melanie witt proposed openstack/nova master: Reproducer for bug 2098892 https://review.opendev.org/c/openstack/nova/+/942402 | 22:51 |
opendevreview | melanie witt proposed openstack/nova master: libvirt: Fix regression of listDevices() return type https://review.opendev.org/c/openstack/nova/+/942334 | 22:51 |
melwitt | weird new-to-me CI failure in nova.tests.unit.db.main.test_migrations.TestMigrationsWalkPostgreSQL.test_single_head_revision: sqlalchemy.exc.OperationalError: (psycopg2.errors.ObjectInUse) source database "template1" is being accessed by other users | 23:41 |
sean-k-mooney | ... werid | 23:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!