| sean-k-mooney | melwitt: +2 on your repodcuer and fix for the listDevices thing | 00:15 |
|---|---|---|
| melwitt | sean-k-mooney: thanks :) | 00:15 |
| melwitt | sean-k-mooney: hm ... the top patch is still failing the spice test after merging the tempest change. seems to be the same error about "additional schema properties" | 03:11 |
| sean-k-mooney | did the tempet one merge? | 03:12 |
| melwitt | yes. it merged and then I rechecked it | 03:12 |
| melwitt | not sure if I'm missing something | 03:13 |
| sean-k-mooney | let me check the results | 03:13 |
| sean-k-mooney | were you watching it live | 03:13 |
| sean-k-mooney | i dont see zuul reproting yet | 03:13 |
| melwitt | yeah watching it live. as soon as it turned red | 03:14 |
| melwitt | not sure if this will work https://zuul.openstack.org/stream/85ee800351e444bcbf37a907f0e9ac50?logfile=console.log | 03:14 |
| sean-k-mooney | i have it open :) | 03:14 |
| melwitt | heh | 03:14 |
| sean-k-mooney | i think this is a diffent error | 03:15 |
| melwitt | my first thought is I wonder if it somehow has to do with the image properties patch merged, if some schema update was needed for that? | 03:15 |
| sean-k-mooney | yep that what im thinking | 03:15 |
| melwitt | bleh | 03:15 |
| melwitt | we really need a better way (or a way :P) to make sure we sync tempest with api changes | 03:16 |
| sean-k-mooney | so we need ot also update the tempest schema validate with the 2.98 stuff | 03:16 |
| sean-k-mooney | well normlay we merge the tempets change after the api change and have a dnm on nova to show its working | 03:16 |
| sean-k-mooney | so nova(api) <- tempest <- nova (DNM) | 03:17 |
| melwitt | I see | 03:18 |
| sean-k-mooney | so this isnt a problem with any of mikal patches | 03:18 |
| sean-k-mooney | its because tempest is not aware of 2.98 | 03:18 |
| melwitt | ok. that makes sense then | 03:18 |
| sean-k-mooney | and any test that uses 2.99 is going to fail if it does a server show i think | 03:19 |
| melwitt | yeah I think you're right | 03:19 |
| sean-k-mooney | given it 3:20 i shoudl probaly either go to bed or get a glass of wiskey | 03:21 |
| sean-k-mooney | we could push a patch to tempest and then put a patch on top of the speice direct one to verify it fixes it | 03:22 |
| melwitt | those are some choices lol | 03:22 |
| melwitt | yeah. I could probably do that. I have done a tempest schema patch once before | 03:23 |
| sean-k-mooney | i mean it clearly to late? early? for coffee | 03:23 |
| melwitt | yeah. no coffee | 03:23 |
| sean-k-mooney | ok so it kind of an issue with mikals tempest patch but only because the schemav299 tehy defiend does not have the image stuff | 03:29 |
| sean-k-mooney | so we need to add a 2_98 and update https://review.opendev.org/c/openstack/tempest/+/942023/3/tempest/lib/api_schema/response/compute/v2_99/servers.py#15 | 03:29 |
| sean-k-mooney | to import that instead | 03:29 |
| melwitt | ah ok | 03:30 |
| sean-k-mooney | also when we hit 2.100 can we defien a 3.0 that is just 2.100 and move on withour lives | 03:30 |
| melwitt | lol. that's ... a good point | 03:30 |
| sean-k-mooney | it wouldnt be the first tiem we had a 3.0 ... | 03:31 |
| melwitt | hah. yeah | 03:31 |
| masahito | hi nova folks, please review the API bug fix for v2.96 and later version if you have time. https://review.opendev.org/c/openstack/nova/+/939658 | 03:32 |
| sean-k-mooney | oht he pined az | 03:33 |
| masahito | yes :-) The show scheduler hint feature needs to follow similar change because it checks request_spec. | 03:34 |
| sean-k-mooney | im currently ruminating on https://review.opendev.org/c/openstack/nova/+/939658/6/nova/api/openstack/compute/views/servers.py#222 | 03:36 |
| sean-k-mooney | syliticlly this annoys me but im tryign to decied if there is actully an issue | 03:36 |
| sean-k-mooney | if i read that if cascade | 03:37 |
| sean-k-mooney | it imples provided_az is either the litral boolean False or its a sting contiaing the az name | 03:38 |
| sean-k-mooney | so the data type of provided_az is union(NONE|bool|str) | 03:40 |
| masahito | yes, I also wondering it follows Nova's nice coding manner. The _get_pinned_az needs to identify 3 patterns as commented. | 03:40 |
| sean-k-mooney | so None is only passe if show is invoed and prived_az is not passed | 03:42 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/939658/6/nova/api/openstack/compute/views/servers.py#244 | 03:42 |
| sean-k-mooney | correct? | 03:42 |
| sean-k-mooney | in what case is false passed? | 03:43 |
| masahito | right. | 03:43 |
| masahito | fales is passed if list is invoked and no request_specs object to an instance | 03:44 |
| sean-k-mooney | ah | 03:44 |
| sean-k-mooney | it woudl be nice if None was passed then | 03:45 |
| sean-k-mooney | thats form here right https://review.opendev.org/c/openstack/nova/+/939658/6/nova/api/openstack/compute/views/servers.py#539 | 03:45 |
| sean-k-mooney | if we change req_specs_dict.get(server.uuid, False) to req_specs_dict.get(server.uuid, None) | 03:46 |
| sean-k-mooney | im trying to decide if that allows use to simplfy the if | 03:47 |
| sean-k-mooney | it would allow use toe get rid of the first two brances and jsut replace it with pinned_az = provided_az | 03:48 |
| sean-k-mooney | but the else woudl have to become if pinned_az is None: | 03:48 |
| masahito | but in that case, _get_pinned_az can't identify pre-fetheched None in list or no input in show. | 03:48 |
| masahito | s/no input in show/no input None in show/ | 03:48 |
| sean-k-mooney | sure but im trying to decied if that matters | 03:48 |
| sean-k-mooney | if we dont have a request spec then it cant be pinned | 03:49 |
| masahito | i see. | 03:49 |
| sean-k-mooney | im not sayign you should change this | 03:50 |
| sean-k-mooney | im trying to undersand the desing chooices that lead to this current patch | 03:51 |
| sean-k-mooney | "if provided_az is False:" is very specific and odd | 03:51 |
| masahito | thanks for the follow up. my reply is one previous your message. | 03:51 |
| sean-k-mooney | you are using False as a sential | 03:51 |
| sean-k-mooney | but it might be better to actuly create a new sentail object instead | 03:51 |
| sean-k-mooney | and use that instead | 03:51 |
| sean-k-mooney | so its clear what its role is | 03:52 |
| masahito | like a empty request_spec object instead of False? | 03:52 |
| sean-k-mooney | no | 03:52 |
| sean-k-mooney | so at teh module level define sentinel = object() | 03:53 |
| sean-k-mooney | then do req_specs_dict.get(server.uuid, sentinel) here | 03:53 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/939658/6/nova/api/openstack/compute/views/servers.py#539 | 03:53 |
| sean-k-mooney | and if provided_az is sentinel: | 03:54 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/939658/6/nova/api/openstack/compute/views/servers.py#222 | 03:54 |
| sean-k-mooney | rather then using the singleton False object create your own | 03:55 |
| sean-k-mooney | you can give it a descriptive name | 03:55 |
| sean-k-mooney | AZ_NOT_IN_REQUEST_SEPC = obejct() | 03:55 |
| masahito | I may get your point. at the first if-condition checks the provided_az is the sentinel object or not. | 03:55 |
| sean-k-mooney | right | 03:56 |
| sean-k-mooney | basiclly https://python-patterns.guide/python/sentinel-object/#sentinel-objects | 03:56 |
| sean-k-mooney | ill leave a comment to this effect and also +1 | 03:57 |
| sean-k-mooney | letss see if others care one way or the other | 03:58 |
| masahito | Let me update to use the sentinel. I don't think it difficult change. | 03:59 |
| sean-k-mooney | sure | 03:59 |
| opendevreview | Masahito Muroi proposed openstack/nova master: Use dict object for request_specs_dict in the _list_view https://review.opendev.org/c/openstack/nova/+/939658 | 04:07 |
| masahito | updated. thanks | 04:10 |
| sean-k-mooney | i have one nit in the release note but im +2 | 04:10 |
| sean-k-mooney | melwitt: im not sure if you wrote that patch or not but im actully got to head to sleep now, enjoy whats left of your evnening | 04:38 |
| melwitt | sean-k-mooney: no not yet. gnight o/ | 04:39 |
| sshmlbrg | sean-k-mooney: o/ | 04:57 |
| opendevreview | sean mooney proposed openstack/nova master: only show standard image propeties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 05:30 |
| sean-k-mooney | gibi: ^ that shoudl fix | 05:30 |
| sean-k-mooney | https://launchpad.net/bugs/2098384 | 05:30 |
| sean-k-mooney | well maybe not | 05:33 |
| sean-k-mooney | this is ligtly diffent damb it | 05:33 |
| sean-k-mooney | well that fixes a bug but it might only be a partial fix | 05:35 |
| opendevreview | Merged openstack/nova-specs master: Extend image-properties-in-server-show spec with rebuild https://review.opendev.org/c/openstack/nova-specs/+/940360 | 05:55 |
| mikal | sean-k-mooney / melwitt: there is this WIP tempest patch for v2.98 -- https://review.opendev.org/c/openstack/tempest/+/939375 | 06:59 |
| mikal | I am a little surprised its not in merge conflict now though. | 06:59 |
| mikal | Oh wait, that's the _other_ _other_ competitor for v2.98? Is there any existing attempt at testing for v2.98? If it changed the schema how did it merge without any tempest tests? | 07:12 |
| mikal | I am confused enough that I am going to stop and think about this some more. | 07:12 |
| mikal | I cannot find a proposed tempest change for the code which landed as v2.98. | 07:18 |
| opendevreview | Johannes Kulik proposed openstack/nova master: libvirt: fix maxphysaddr passthrough dom parsing https://review.opendev.org/c/openstack/nova/+/942371 | 07:42 |
| melwitt | sean-k-mooney: I saw your comments on the image properties patch and your fix patch. I assume that means I should hold off on trying any tempest schema patch for 2.98 for the moment if there is some bug in the API response? | 08:36 |
| ratailor | sean-k-mooney, you around ? | 08:39 |
| sshmlbrg | ratailor: he's sleeping | 08:40 |
| ratailor | sshmlbrg, ack. Thanks! | 08:41 |
| opendevreview | Rajesh Tailor proposed openstack/nova master: only show standard image properties in server show. https://review.opendev.org/c/openstack/nova/+/942413 | 10:23 |
| sean-k-mooney | melwitt: it does not change teh schema becuase in the schema its just a dict of sting | 11:11 |
| opendevreview | Vasyl Saienko proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.opendev.org/c/openstack/nova-specs/+/471815 | 11:41 |
| nisha | hi nova folks, please review the one line bug fix for port after live migration if you have time. thank you! https://review.opendev.org/c/openstack/nova/+/936338 | 12:04 |
| sean-k-mooney | nisha: that not a trivile change | 12:04 |
| sean-k-mooney | i skimmed it when you first pushed it and i did have tiem to fully load all the context | 12:05 |
| sean-k-mooney | there are some filed that should be diffent between the souce and dest | 12:06 |
| sean-k-mooney | for example the pci adress of an sriov nic. | 12:07 |
| sean-k-mooney | so this need careful review to ensure its actully correct | 12:08 |
| sean-k-mooney | the binding provile is an admin only filed that is ment to be used by nova to pass info to the neutron network backend | 12:09 |
| sean-k-mooney | its not a freform field that operators or end user are allowed to put arbitary keys in | 12:09 |
| nisha | ahh I see. thank you for taking a look at it already. | 12:10 |
| sean-k-mooney | what filed were being lost in your case | 12:11 |
| sean-k-mooney | do you have a specific case that is broken | 12:11 |
| sean-k-mooney | {"os_vif_delegation": true} was not ment to be the only content by the way it was ment to be added to the prociel and remvoe dlater | 12:12 |
| sean-k-mooney | the bug doe snot say it just say "openstack port set $port_id --binding-profile aaa=bbb --binding-profile ccc=ddd" | 12:14 |
| sean-k-mooney | which is not supproted | 12:14 |
| sean-k-mooney | there is only one filed that can be set by a human in the bidnign profile ant that trusted_vf | 12:15 |
| sean-k-mooney | and removing that has been on our todo list forever | 12:15 |
| nisha | in our case, the bgp network settings are set to the port in the binding profile and after live migration it is completely overwritten by os_vif_delegation | 12:21 |
| sean-k-mooney | that doesn not sound like a supprote setup. can you point to the neutron pluging and confirm what virt driver your using | 12:27 |
| sean-k-mooney | in the case of use with nova the content of the binding profile is exlicively resrevd for novas use, for zun it reserved for zun for standalone ironic it cna use it but it may not modify it when used via nova | 12:29 |
| sean-k-mooney | there is a bug on the nova side but its not ok for neturon to modify the content of that filed | 12:29 |
| sean-k-mooney | so if the ml2 dirver is modifying its incorrect | 12:30 |
| nisha | yes, ml2 is the neutron core plugin and libvirt driver | 12:35 |
| sean-k-mooney | that does not answer my question | 12:36 |
| sean-k-mooney | which ml2 driver? | 12:36 |
| sean-k-mooney | there are many | 12:36 |
| cardoe | vsaienko: so fwiw, your trunk details patch https://review.opendev.org/c/openstack/nova/+/941227 with my suggested change works for us on real hardware | 12:49 |
| opendevreview | Vasyl Saienko proposed openstack/nova-specs master: Expose vlan trunking in metadata/configdrive https://review.opendev.org/c/openstack/nova-specs/+/471815 | 12:54 |
| vsaienko | cordoe: thanks, nova team asked to create a spec https://review.opendev.org/c/openstack/nova-specs/+/471815, and I've discovered that in my patch grenade job is failing because of issues with Instance object format not recognized correctly by older nova-compute. | 12:55 |
| opendevreview | Luis Enrique Morales Mendez proposed openstack/nova master: Add 'LOG' to archive_deleted_rows function https://review.opendev.org/c/openstack/nova/+/942441 | 13:05 |
| cardoe | Looking to land https://review.opendev.org/c/openstack/nova/+/942019 and then create some backports to 2024.2 and 2024.1 without that change those versions just log the SDK Result Object at <0xDEADBEEF> as the error message. | 13:06 |
| nisha | sean-k-mooney: we use custom driver which is a combination of srv6 and l2isolate type driver using linuxbridge based agent, i suspect this is responsible to overwrite the binding_profile. i understand the current situation on nova's side. thank you for sharing the details. | 13:12 |
| ratailor | sean-k-mooney, you around ? | 15:57 |
| opendevreview | melanie witt proposed openstack/nova master: DNM test microversion 2.99 https://review.opendev.org/c/openstack/nova/+/942493 | 21:01 |
| mikal | melwitt / sean-k-mooney: https://review.opendev.org/c/openstack/tempest/+/942495 is an attempt at the schema changes in tempest for v2.98. I am fairly confident it is wrong. | 21:11 |
| melwitt | mikal: I also uploaded one a few minutes ago heh. I'm running a DNM patch at the end of the series to see if it works | 21:18 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 21:18 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 21:18 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 21:18 |
| mikal | melwitt: oh I saw your nova one, did you do a tempest one too? | 21:18 |
| melwitt | aaand it just got orphaned I think | 21:19 |
| melwitt | haha, yes I did | 21:19 |
| mikal | melwitt: I might have just stomped on yours then... | 21:19 |
| mikal | Ok, I'll revert mine changes to the nova series. Sorry. | 21:19 |
| melwitt | no I think it's ok | 21:19 |
| mikal | Well the series now depends on my lame attempt at a v2.98 schema in tempest | 21:19 |
| melwitt | mikal: it looks like it's still working anyway | 21:20 |
| mikal | melwitt: your tempest patch is definitely better than mine. I am pretty sure mine will get in your way unless your orphan test is just continuing to run? | 21:20 |
| melwitt | it looks like it's pinned to PS 40. that's pretty cool | 21:21 |
| melwitt | mikal: it's continuing to run. I didn't think it used to work that way but this is nice | 21:21 |
| mikal | I'll still have to drop the depends on for my WIP tempest change or it will get in the way. I'll do that now. | 21:22 |
| opendevreview | Douglas Viroel proposed openstack/nova master: Add support for showing scheduler_hints in server details https://review.opendev.org/c/openstack/nova/+/938604 | 21:22 |
| melwitt | sorry for duplicating. I wanted to try to help since the microversion race messed everything up | 21:22 |
| mikal | Oh, I am very grateful for the help. I definitely don't want to be chasing this over the weekend, but I am also very worried about missing feature freeze at this point. | 21:23 |
| mikal | error: remote unpack failed: error Missing tree 4a45ed28aa51f7ae9791b3f90a1fe8fef3c42dab | 21:23 |
| mikal | fatal: Unpack error, check server log | 21:23 |
| mikal | I have no idea what that means. | 21:24 |
| melwitt | no, we will get it working | 21:24 |
| melwitt | bleh. my DNM patch just failed. must be something in my tempest patch, I'll figure out what's wrong with it | 21:29 |
| mikal | I am just arguing with gerrit to try and remove that depends-on I only just added, but for reasons too boring to explain git review takes like five minutes in my workflow. | 21:30 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 21:30 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 21:30 |
| opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 21:30 |
| mikal | Right, depends-on for my bad tempest change removed. melwitt, feel free to add a depends on to your change if that's easier. I am not offended by you uploading patches to that series. | 21:31 |
| melwitt | sure. yeah adding depends-on would probably be better. tbh I didn't expect anyone would be doing anything with it today so I just stacked it on top :P | 21:33 |
| melwitt | and will obviously abandon once this gets working | 21:33 |
| mikal | Whatever works for you is fine with me. | 21:37 |
| mikal | I need to go for a run before it gets any hotter outside, but I will check back in a couple of hours. | 21:37 |
| opendevreview | Max proposed openstack/nova master: feat: nova-manage db instance events cleanup https://review.opendev.org/c/openstack/nova/+/916927 | 22:07 |
| melwitt | sean-k-mooney, mikal: I think I got things working for 2.98 in tempest here https://review.opendev.org/c/openstack/tempest/+/942492. the spice series passes the spice tempest test with that cc gmann | 23:28 |
| sean-k-mooney | so skimming that i think that looks corect to me | 23:39 |
| sean-k-mooney | and it "shoudl" fix the spice test i belvie | 23:39 |
| melwitt | I tested it here https://review.opendev.org/c/openstack/nova/+/942493 | 23:39 |
| sean-k-mooney | oh awsome | 23:39 |
| melwitt | it definitely works for now. but if we change the schema again (I saw the fix you are working on) then we'll need to correspondingly adjust tempest after I think | 23:40 |
| sean-k-mooney | am we should not need to change it | 23:41 |
| sean-k-mooney | if we change it from properties to image properties like ragesh suggested we woudl be ut that need a new microversion | 23:42 |
| sean-k-mooney | so we shoudl avoid that | 23:42 |
| melwitt | we definitely need to add 'null' as a type bc the api is currently returning None for some properties like hw_input_bus. I comment about it on your patch | 23:42 |
| mikal | Thanks for chasing this down guys, I really appreciate it. | 23:43 |
| melwitt | the previous failure of the spice test was because 'null' wasn't allowed by the schema, so I added it to the schema on the tempest side | 23:43 |
| mikal | Is there anything I can do here to be helpful, or do you think its largely sorted out now? | 23:44 |
| melwitt | afaict I think it's sorted. just need to merge this tempest patch and then we need to re-apply +2s and +W the bottom 3 patches. I assume we can diff against PS40 to see that no code changed | 23:45 |
| melwitt | *3 spice patches | 23:45 |
| mikal | The first two still have their +2s in gerrit, the third one was clobbered. | 23:47 |
| sean-k-mooney | i guess we have 2 chocies | 23:50 |
| sean-k-mooney | we coudl add null or we could jsut not print that key in that case | 23:50 |
| sean-k-mooney | is None a valid value or is it just printign that because its unset? | 23:51 |
| sean-k-mooney | i had to step away to let freya (my frieds dog im minding for the week) out | 23:52 |
| sean-k-mooney | but i started lookign at the third spice patch | 23:52 |
| sean-k-mooney | melwitt: we can add a depends on on my image property patch to make sure its tested with your tempest patch to make sure we confrom to it | 23:52 |
| melwitt | you know better than I do whether None is a valid/meaningful value. I would think it's not but I don't know for sure | 23:54 |
| sean-k-mooney | we would have had to require it to be set to null in glance i think | 23:54 |
| sean-k-mooney | i suspect not but we can adress that in my bugfix patch | 23:55 |
| melwitt | ++ | 23:55 |
| melwitt | mikal: ah ok, thanks | 23:55 |
| sean-k-mooney | i readded +2 on hte third | 23:56 |
| sean-k-mooney | so reading your schema patch comment | 23:58 |
| mikal | sean-k-mooney: I assume the door has now closed on that os-traits change landing this cycle, yeah? | 23:58 |
| sean-k-mooney | for the bools ectra i thinks we can make sure we alwasy convert the vlues to stings | 23:58 |
| sean-k-mooney | mikal: am technically the release should have haappend today | 23:58 |
| sean-k-mooney | but in realisty i dont know if it has so we could try and squeeze it in | 23:59 |
| sean-k-mooney | let me check | 23:59 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!