| *** mhen_ is now known as mhen | 01:11 | |
| opendevreview | melanie witt proposed openstack/nova master: Move cleanup of vTPM secret from driver to compute https://review.opendev.org/c/openstack/nova/+/962007 | 02:41 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: Opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | 02:41 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 02:45 |
| opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | 06:13 |
| sean-k-mooney | gibi: fun https://review.opendev.org/c/openstack/placement/+/962596 | 09:42 |
| sean-k-mooney | the inital fix was more of a stop the bleeding type fix rather then a full rewrite some im not surpised that it did nto cover all edgecases | 09:43 |
| sean-k-mooney | ValueError: Length too long: 11601115 so your functional test are failign because we are hitting the max subunite packet lenth in the test outpu | 09:44 |
| sean-k-mooney | i tought this was fixed in stestr a long time ago but maybe we worked aroudn that in nova or didnt apply the fix to placemnt | 09:45 |
| gibi | sean-k-mooney: "fun" indeed. what I learned is that our first fix limited the search space of the valid candidates with a global limit, but it does not limit the search space of the intermediate representaton placement uses, and that represenatation is even bigger causing the issue. | 10:05 |
| sean-k-mooney | right i think that was at least partly expected | 10:06 |
| sean-k-mooney | we dicussed that we woudl need to refactor the algorithim to do a breath first lazy pick form each host up to the relevent limits | 10:06 |
| sean-k-mooney | if we wanted to properly fix it | 10:06 |
| sean-k-mooney | you added the breathfirst bit | 10:07 |
| sean-k-mooney | but i dont think you made it lazy in the orginal change did you? | 10:07 |
| sean-k-mooney | i guess we also only counted valid reulst toward the limits | 10:08 |
| gibi | lazyness is not the problem afaik. we are generators all the way down | 10:08 |
| gibi | and we stop when enough valid candidates are generated | 10:08 |
| sean-k-mooney | so there is also the consideration of just how many candiates we examin | 10:08 |
| gibi | but to generate enough valid candidate we go throuhg a lot of invalid one | 10:08 |
| sean-k-mooney | ya | 10:08 |
| sean-k-mooney | so really we need a second config option for how many we woudl evaculate | 10:08 |
| gibi | that is hard, as in the current config 300k invalid is generated before the first valid is found from the 40k valid and 16M total candidates | 10:09 |
| sean-k-mooney | i.e limit=100 , check=10000 | 10:09 |
| sean-k-mooney | ya | 10:10 |
| sean-k-mooney | really we need a better approch overall to this problem rather then trying to retofit the existign algorthim | 10:10 |
| sean-k-mooney | but obviouly that is a much larger change | 10:10 |
| gibi | I have high level ideas how to prune the search when we found an invalid candidate | 10:10 |
| sean-k-mooney | i was just going to ask | 10:11 |
| gibi | I just need time to put it together and see if it is enough help or not | 10:11 |
| sean-k-mooney | what is the direction you are thinking of going wiht this | 10:11 |
| sean-k-mooney | ack | 10:11 |
| gibi | E.g. if G1-R1, G2-R1, G3-R2 is invalid due to R1 is overallocated by G1 and G2 then we don't have to check G1-R1, G2-R1, G3-R3 | 10:11 |
| gibi | so a single invalid candidate can remove a bunch of other possible candidate that would fail the same check the same reason | 10:12 |
| sean-k-mooney | you did something similar to the numa node code in nova too if i recall | 10:12 |
| gibi | I did caching there | 10:12 |
| gibi | here I would rather skip generating the candidate | 10:13 |
| gibi | but the idea is similar | 10:13 |
| sean-k-mooney | ya | 10:13 |
| gibi | don't go through the same sub check repatedly | 10:13 |
| sean-k-mooney | ok well since you have a direction i wont suggest any other but if you want to brainstorm or chat about it let me know | 10:13 |
| gibi | I want to go down to this path a bit, then we can re-discuss | 10:16 |
| gibi | also I think there will be a ptg topic about it as well :) | 10:16 |
| gibi | thanks for checking the patch | 10:17 |
| gibi | I will keep the nova team informed about the progress | 10:17 |
| Vii | for informational purposes, working copy/paste novnc https://github.com/Vishwamithra37/galam_nonvc_copypaste/blob/CopyPasteWorking_NoVnc_OpenStack/README.md | 10:20 |
| sean-k-mooney | Vii: it need a addtiona spice clipborad device added to the xml i belive | 10:25 |
| sean-k-mooney | we looked at it breifly before but did you mange to get it workign without nova code changes? | 10:25 |
| sean-k-mooney | upstream novnc supprot copypaset i bleive but not the way we create the vms | 10:27 |
| sean-k-mooney | https://github.com/novnc/noVNC?tab=readme-ov-file#features | 10:27 |
| sean-k-mooney | https://libvirt.org/formatdomain.html#channel | 10:28 |
| sean-k-mooney | we need to add a qemu-vdagent channel | 10:28 |
| sean-k-mooney | o supprot the clipboard functionalty | 10:29 |
| sean-k-mooney | Vii: i looked into this a bit about a year ago but never worked on a poc | 10:30 |
| sean-k-mooney | but form talking ot our virt team internally this functionalyt shoudl work with vnc and novnc if we wire it up properly | 10:30 |
| sean-k-mooney | without the need for spice | 10:31 |
| sean-k-mooney | it seams like you did it a diffent way by modifying the novnc html client applcation instead | 10:31 |
| bauzas | do people here know how the fuck I could check DEBUG logs with something like _wait_for_log() in either a functional test or a regression one ? | 10:34 |
| sean-k-mooney | this has been requested in teh past so we proably shoudl implement copy paste supprot at some point although VDI usecase for openstack in the past have mainly invovled isntalling a vdi service like window RDP server in the gust in the past | 10:34 |
| bauzas | unless of course if you use OS_DEBUG | 10:34 |
| sean-k-mooney | bauzas: i dont know if we have a wait funciton | 10:35 |
| bauzas | we have one | 10:35 |
| sean-k-mooney | but you can do asserts | 10:35 |
| sean-k-mooney | ack | 10:35 |
| bauzas | even with assertIn, the log doesn't have debug logs | 10:35 |
| sean-k-mooney | it should let me check the capture fixture | 10:35 |
| sean-k-mooney | im pretty sure we hage regression tests that assert debug logs | 10:36 |
| bauzas | I wasn't able to see some of them | 10:36 |
| sean-k-mooney | https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/functional/regressions/test_bug_1853009.py#L109-L111 | 10:37 |
| sean-k-mooney | that may not be a debug log but i expect output to have all logs including debug | 10:38 |
| bauzas | I'm now able to get debug logs by doing in the SetUp : | 10:39 |
| bauzas | root = logging.getLogger() | 10:39 |
| bauzas | if root.handlers: | 10:39 |
| bauzas | root.handlers[0].setLevel(logging.DEBUG) | 10:39 |
| bauzas | but that's not right good | 10:39 |
| sean-k-mooney | ya so that why i said i want to check the fixture | 10:39 |
| sean-k-mooney | i was expectign our default log level in the funtional test to be debug | 10:40 |
| sean-k-mooney | you coudl jsut ensure that by suign flags | 10:40 |
| sean-k-mooney | in the test to set the confgi option to make it debug and see if that is enough | 10:40 |
| sean-k-mooney | that woudl be the better way to do that | 10:40 |
| sean-k-mooney | so this is our defult logging fixture https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/fixtures/nova.py#L126-L205 | 10:41 |
| bauzas | yeah, I'll try to use a conf flag instead | 10:42 |
| bauzas | and yeah I found the fixture, that's why I'm mimic'ing it | 10:43 |
| bauzas | wait_for_log now works with DEBUG, but I'll look at the conf flag | 10:43 |
| sean-k-mooney | ya os it mention using OS_DEBUG=True to print out the debug logs but i tought it was just for that contoling the printing not if we capture them | 10:43 |
| sean-k-mooney | i.e. i expected them to still be aviablein the tests to use | 10:44 |
| sean-k-mooney | but just not logged to the test output | 10:44 |
| sean-k-mooney | the ohter way to do this | 10:44 |
| sean-k-mooney | is you can mock the LOG module level variable | 10:44 |
| sean-k-mooney | and then just assert that its called with the message you expect | 10:44 |
| sean-k-mooney | we do do that in places too | 10:44 |
| bauzas | fwiw, self.flags(debug=True, group='DEFAULT') doesn't work | 10:45 |
| sean-k-mooney | right it wont not with how this is written | 10:45 |
| sean-k-mooney | that why im suggeting just mockign LOG in the relevent module | 10:45 |
| bauzas | sean-k-mooney: yup, should be better to assert the LOG call for the weigher | 10:45 |
| bauzas | thanks, will do it instead | 10:46 |
| sean-k-mooney | https://github.com/openstack/nova/blob/b99a882366251f88d145e27312b94692e0b2266f/nova/tests/unit/virt/libvirt/volume/test_mount.py#L583 | 10:46 |
| bauzas | yup, there are examples, I just forgot them | 10:46 |
| sean-k-mooney | so we typicly do that in a buch of place for unit test but it shoudl work the same for functional | 10:46 |
| bauzas | mocking LOG is the right pattern for debug logs then, I forgot it | 10:46 |
| bauzas | thanks | 10:47 |
| sean-k-mooney | no worries | 10:47 |
| sean-k-mooney | i also often just end up trying one way then the ohter depending on which works | 10:47 |
| sean-k-mooney | i prefer ot not mock if i can avoid it but its just simpler in this case | 10:48 |
| *** tkajinam_ is now known as tkajinam | 10:54 | |
| opendevreview | Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408 | 12:23 |
| opendevreview | Thomas Goirand proposed openstack/nova-specs master: Restrict booting from volume with disk https://review.opendev.org/c/openstack/nova-specs/+/960513 | 13:27 |
| opendevreview | Kamil Sambor proposed openstack/nova master: [hacking] Improve N373 to catch also other primitives https://review.opendev.org/c/openstack/nova/+/958408 | 13:57 |
| opendevreview | Jonas Schäfer proposed openstack/nova master: Preserve vTPM state between power off and power on https://review.opendev.org/c/openstack/nova/+/955657 | 14:28 |
| opendevreview | Merged openstack/nova master: Centralize cooperative yield https://review.opendev.org/c/openstack/nova/+/950991 | 20:04 |
| opendevreview | Merged openstack/nova master: [hacking] N374 do not use time.sleep(0) to yield https://review.opendev.org/c/openstack/nova/+/950992 | 20:24 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `user` secret security https://review.opendev.org/c/openstack/nova/+/942502 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `host` secret security https://review.opendev.org/c/openstack/nova/+/941795 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: Add vtpm_secret_(uuid|value) to LibvirtLiveMigrateData https://review.opendev.org/c/openstack/nova/+/952628 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/941483 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version and require it for live migration https://review.opendev.org/c/openstack/nova/+/962051 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support instances with `deployment` secret security https://review.opendev.org/c/openstack/nova/+/942021 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: Opt-in to new TPM secret security via resize https://review.opendev.org/c/openstack/nova/+/962052 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 20:51 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 23:51 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!