| *** mhen_ is now known as mhen | 01:08 | |
| jlejeune1 | hello, now that 2025.2 is out, I would like to have new reviews for my backports please: https://review.opendev.org/q/topic:%22bug-2044235%22 :) | 07:15 |
|---|---|---|
| opendevreview | Balazs Gibizer proposed openstack/placement master: Reproduce GET a_c slowness https://review.opendev.org/c/openstack/placement/+/962596 | 09:43 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Remove excessive logging from GET a_c https://review.opendev.org/c/openstack/placement/+/962775 | 09:43 |
| opendevreview | Balazs Gibizer proposed openstack/placement master: Prune search space with invalid prefixes https://review.opendev.org/c/openstack/placement/+/962776 | 09:43 |
| gibi | dansmith: sean-k-mooney: ^^ this helps if we keep max_allocation_candidates <= 1000 . I will test it in devstack next. I know that it is uggly and I have intention to clean it up as much as possible | 09:45 |
| gibi | I just need proof first that it helps my customer as well | 09:45 |
| sean-k-mooney[m] | cool ill take a look | 09:46 |
| sean-k-mooney[m] | ugly and works reliably is better then broken at least in the short to medium term | 09:46 |
| sean-k-mooney[m] | without buying in to any of the graphql hype i do wonder if there are larger refactors we may want to look at eventually. i know there was an experimetn to see if more could be done in sql in the past bt i dont know if that ever landed | 09:49 |
| sean-k-mooney[m] | gibi: one comment can you keep the assisted-By in the commit message only. i really dont think that belongs in commetnt or doc strings | 09:52 |
| sean-k-mooney[m] | gibi also that is not that ugly you just created your own product generatior, when you said ugly i was expectign somthing much more hack ish although im not a huge fan of the while true. i need to step away breifly but ill read it propler when i get back | 09:56 |
| stephenfin | gibi: sean-k-mooney[m]: Can you review this test-only change? https://review.opendev.org/c/openstack/nova/+/951744 | 10:02 |
| stephenfin | I'm trying to remove keystoneclient from keystonemiddleware, and lajoskatona is trying to remove python-neutronclient, so this will (hopefully) break at some point | 10:03 |
| sean-k-mooney | ack that makes sense to me | 10:54 |
| gibi | sean-k-mooney[m]: I agree. I will move the assisted by tag to the commit message | 11:05 |
| gibi | stephenfin: +2+A | 11:06 |
| stephenfin | ty | 11:06 |
| *** mhen_ is now known as mhen | 11:15 | |
| sean-k-mooney | gibi: sambork: https://review.opendev.org/c/openstack/nova/+/962478/2 see comment in line i think we are leakying that executor between test runs | 11:31 |
| sean-k-mooney | im happy to proceed with teh first 2 nova-conductor native threading patchs for what its worth but the third i think has a bug | 11:32 |
| gibi | sean-k-mooney: lets procede with the first two for now while Kamil checks the refactor. dansmith could you review https://review.opendev.org/c/openstack/nova/+/962478 ? | 11:49 |
| opendevreview | Merged openstack/nova master: tests: Replace keystoneclient with keystoneauth1 https://review.opendev.org/c/openstack/nova/+/951744 | 12:07 |
| zigo | stephenfin: Thanks for taking over https://review.opendev.org/c/openstack/python-openstackclient/+/962487 ! | 12:16 |
| zigo | Much appreciated. | 12:16 |
| stephenfin | nw, actually need to approve that | 12:16 |
| * stephenfin does the necessary | 12:16 | |
| opendevreview | Merged openstack/nova master: Switch nova-conductor to use ThreadPoolExecutor https://review.opendev.org/c/openstack/nova/+/957088 | 13:40 |
| opendevreview | Takashi Kajinami proposed openstack/placement master: Remove remaining basepython https://review.opendev.org/c/openstack/placement/+/962804 | 14:03 |
| opendevreview | Takashi Kajinami proposed openstack/os-traits master: Drop basepython https://review.opendev.org/c/openstack/os-traits/+/962805 | 14:04 |
| opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: Drop basepython https://review.opendev.org/c/openstack/os-resource-classes/+/962806 | 14:04 |
| opendevreview | Takashi Kajinami proposed openstack/os-resource-classes master: Drop basepython https://review.opendev.org/c/openstack/os-resource-classes/+/962806 | 14:05 |
| opendevreview | Takashi Kajinami proposed openstack/os-traits master: Drop basepython https://review.opendev.org/c/openstack/os-traits/+/962805 | 14:05 |
| tkajinam | anyone care to merge these trivial changes ? https://review.opendev.org/c/openstack/os-resource-classes/+/947488 https://review.opendev.org/c/openstack/os-resource-classes/+/932878 | 14:10 |
| sean-k-mooney | done | 14:17 |
| sean-k-mooney | well for the last 2 | 14:17 |
| gibi | done | 14:17 |
| gibi | ahh | 14:17 |
| tkajinam | thanks both ! | 14:17 |
| gibi | :) | 14:17 |
| sean-k-mooney | the basepython thing we can do | 14:18 |
| sean-k-mooney | but it also will nto break anything if we never do it | 14:18 |
| sean-k-mooney | so ill look at it eventually but i need to go rebase things | 14:18 |
| sean-k-mooney | so ill try to remember to loop back | 14:18 |
| opendevreview | Merged openstack/os-resource-classes master: Drop unnecessary 'x' bit from doc config file https://review.opendev.org/c/openstack/os-resource-classes/+/932878 | 14:24 |
| opendevreview | Merged openstack/os-resource-classes master: Replace UPPER_CONSTRAINTS_FILE https://review.opendev.org/c/openstack/os-resource-classes/+/947488 | 14:31 |
| opendevreview | Merged openstack/os-traits master: Drop basepython https://review.opendev.org/c/openstack/os-traits/+/962805 | 15:50 |
| opendevreview | Merged openstack/nova master: Run nova-conductor in native threading mode https://review.opendev.org/c/openstack/nova/+/958575 | 15:55 |
| lajoskatona | sean-k-mooney: after some desperate reading in n-client, neutron and nova I think the exotic exceptions like IpAddressGenerationFailureClient & ExternalIpAddressExhaustedClient and all similar ones are not really used anymore | 16:18 |
| lajoskatona | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/962604/1/nova/network/neutron.py#b3099 | 16:18 |
| lajoskatona | as I see the method allocate_floating_ip is only called from nova/api/openstack/compute/floating_ips.py which is if I understand well is the deprecated FIP API in Nova which calls to Neutron (https://docs.openstack.org/api-ref/compute/#floating-ips-os-floating-ips-deprecated ) | 16:20 |
| lajoskatona | sean-k-mooney: am I thinking the right way or I am totally lost in how these API exceptions work? | 16:20 |
| lajoskatona | I checked on the Neutron side and for IpAddressGenerationFailureClient for example that catches the Neutron ipam http "exception" https://opendev.org/openstack/neutron/src/branch/master/neutron/ipam/exceptions.py#L62 | 16:22 |
| lajoskatona | I am not sure how that is done to tell the truth, but anyway the Neutron ipam IpAddressGenerationFailure 's base is Conflict so I can check the inside of the SDK ConflictException to check for msg "No more IP addresses available for subnet..." | 16:25 |
| sean-k-mooney | lajoskatona: ack reading back | 16:27 |
| lajoskatona | so summary (I think) 1.) part of these exception consumer methods are for deprecated Nova APIs (/os-floating-ips) 2.) it seems that as Neutron packs the msg of the http rsp with definite msg (like "No more IP addresses available for subnet....") I can catch these messages and raise different nova exceptions back based on the message | 16:28 |
| lajoskatona | sean-k-mooney: thanks, it is a summary for myself also to not forget it for tomorrow :-) | 16:28 |
| sean-k-mooney | lajoskatona: i belive you are correct that is is realted to the porxy apis | 16:28 |
| sean-k-mooney | nova does not to my knowlage allcoate floating ips internally | 16:29 |
| sean-k-mooney | so i cant think of any other reasonable usage of those methods | 16:29 |
| lajoskatona | sean-k-mooney: ack, so the possibility that I break something important is lower :-) | 16:30 |
| lajoskatona | that is always good news .... | 16:30 |
| sean-k-mooney | yep | 16:32 |
| sean-k-mooney | the other thing to consier is while the error code is part of the api contract the exact details of the error message isnt nessisarly part of it | 16:33 |
| sean-k-mooney | so if we anted to make these proxy apis bevhve a little more like neturon wew could but if we can do the convertion without a visible impact that is stil probly better | 16:33 |
| noonedeadpunk | hey folks! I've spotted that there's a spec regarding iothreads for virto-blk lying here: https://review.opendev.org/c/openstack/nova-specs/+/951636 | 17:06 |
| noonedeadpunk | which should be placed to 2026.1 I guess | 17:06 |
| noonedeadpunk | But I have a different, but related question | 17:06 |
| noonedeadpunk | I've spotted there's also an scsi blueprint without spec: https://blueprints.launchpad.net/nova/+spec/libvirt-add-support-for-virtio-scsi-multiqueue | 17:07 |
| noonedeadpunk | it seems that these 2 should not be conflicting with each other and I assume both can be implemented? | 17:09 |
| noonedeadpunk | as if I'm not mistaken, that Windows virtio-blk driver is always a single queue, so the way to get any disk performance on windows would be to have scsi and multiqueue there | 17:11 |
| noonedeadpunk | jsut trying to validate if I'm sane and can proceed to working on spec :) | 17:16 |
| noonedeadpunk | (or it could be specless one) | 17:16 |
| dansmith | noonedeadpunk: we have at least three things that are all related, so probably best to have a PTG discussion on it | 17:17 |
| dansmith | domain iothreads, device iothread pinning, and any of these queue things are probably related enough to combine into a single conversation | 17:18 |
| noonedeadpunk | also ports multique I guess? | 17:18 |
| noonedeadpunk | yeah | 17:18 |
| noonedeadpunk | fair enough | 17:18 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 19:47 |
| sean-k-mooney | noonedeadpunk: https://review.opendev.org/c/openstack/nova-specs/+/953940 i sthe related one that we created to try and scope down the propsoal to make some progres in 2025.2 but that also got hit by spec freeze | 20:10 |
| sean-k-mooney | noonedeadpunk: im hoping that Masahito will pick up the prosal again this cycle if they have time | 20:11 |
| sean-k-mooney | this was the other thing they were interested in https://review.opendev.org/c/openstack/nova-specs/+/938823 | 20:12 |
| sean-k-mooney | so there multiple iothreds, mapping disk queues to iothread and filterign service by netwrok id | 20:14 |
| sean-k-mooney | i dont know which is there priority | 20:14 |
| sean-k-mooney | noonedeadpunk: im just siging off for today but i assuem you want to progress the live migration concurncy feture as well in 2026.1 | 20:15 |
| sean-k-mooney | i know there was some code up for that but i lost track for where that review was | 20:16 |
| sean-k-mooney | noonedeadpunk: this was your spec for that https://review.opendev.org/c/openstack/nova-specs/+/955783 | 20:16 |
| sean-k-mooney | but i also belive there was a specless blueprint approved indepently? | 20:17 |
| sean-k-mooney | this was your bluepint https://blueprints.launchpad.net/nova/+spec/libvirt-parallel-migrate but https://blueprints.launchpad.net/nova/+spec/libvirt-migrate-parallel | 20:18 |
| sean-k-mooney | was appoved then deferd | 20:18 |
| sean-k-mooney | noonedeadpunk: so we currently have two competing propsoals for this one form you and another form Fabian Wiesel | 20:20 |
| sean-k-mooney | noonedeadpunk: given they have revierd and +1 your versiohn i assume yours is the one that we inteded ot proceed with but we shoudl abandon one fo them and if decied if its goign to be specless or requrie a spec | 20:22 |
| sean-k-mooney | Uggla: fyi ^ do you have any prefernce on which of the two blueprint we use and if we want to proceed specless or not | 20:24 |
| melwitt | sean-k-mooney: do you happen to know if this needs to be changed to something else, perhaps devstack@q-ovn-metadata-agent ? now that q-agt is not used? https://github.com/openstack/nova/blob/master/roles/run-evacuate-hook/tasks/main.yaml#L24 | 20:34 |
| melwitt | I'm working on vtpm tempest tests and noticed the error "controller | Unit devstack@q-agt.service could not be found." in the zuul stream | 20:35 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 23:10 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889 | 23:10 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add documentation and reno for live migration https://review.opendev.org/c/openstack/nova/+/962889 | 23:21 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 23:21 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!