| *** erlon5 is now known as erlon | 01:08 | |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | 03:27 |
|---|---|---|
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182 | 03:29 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405 | 03:32 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 03:49 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 03:50 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | 05:26 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182 | 05:30 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405 | 05:36 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 05:37 |
| opendevreview | Sylvain Bauza proposed openstack/nova master: Support multiple allocations for vGPUs https://review.opendev.org/c/openstack/nova/+/845757 | 09:24 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Use firmware auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | 11:26 |
| stephenfin | gmaan: while you're going through the OpenAPI series, you'll probably like https://review.opendev.org/c/openstack/nova/+/958858/ Should save you having to check for that manually | 12:48 |
| jkulik | gibi: regarding the tempest tests for volume-attach with API 2.101 - could you provide some guidance on how to proceed here? https://github.com/openstack/tempest/blob/9b0e71cb3e11604daaf1e1a8249249555a6b5b33/tempest/api/compute/volumes/test_attach_volume.py seems to contain the tests, but adding a new test for 2.101 and making the old ones skip on 2.101 seems bad. | 14:54 |
| jkulik | so I'd guess adding a new one to explicitly request that version is necessary, but additionally is adapting the existing tests to work with either <2.101 or >=2.101? | 14:55 |
| jkulik | I wouldn't want to duplicate them all | 14:55 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Include catalog for official service type of manila https://review.opendev.org/c/openstack/nova/+/977825 | 15:20 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [compute]Use single long task executor https://review.opendev.org/c/openstack/nova/+/977251 | 15:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 15:24 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 15:24 |
| gibi | bauzas: gmaan: ^^ fixed up your comments. Lets land this 3 patch for G :) | 15:26 |
| gibi | hold on I see bauzas found typos in the first patch too | 15:26 |
| gibi | respinning once more | 15:26 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Deprecate unlimited compute actions https://review.opendev.org/c/openstack/nova/+/975833 | 15:28 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [compute]Use single long task executor https://review.opendev.org/c/openstack/nova/+/977251 | 15:28 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 15:28 |
| gibi | bauzas: gmaan: ^^ now it is ready :) | 15:29 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: DNM:Test with oslo.vmware + compute eventlet removal patches https://review.opendev.org/c/openstack/nova/+/973468 | 15:30 |
| gibi | gmaan: I'm +2 on the gracefull series, execept the doc patch at the top | 15:40 |
| gibi | good progress! | 15:40 |
| sean-k-mooney | jkulik: generally we need to test the new and old behvior so while you want have to duplciate all the test you woudl want to add new ones for the 2.101 bevhior although im hoping that micorversion will go to stephenfin's get flavor by name serise | 15:58 |
| sean-k-mooney | the old test shoudl alreday be pinning there microversion to the previous change too the atchment api | 15:59 |
| sean-k-mooney | they should not be using latest | 15:59 |
| sean-k-mooney | jkulik: althoug hi dont see that so maybe they are gmaan would be the best person ot ask on how to proceed | 16:00 |
| sean-k-mooney | i guess some of them do | 16:03 |
| sean-k-mooney | https://github.com/openstack/tempest/blob/master/tempest/api/compute/volumes/test_attach_volume.py#L195-L196 | 16:03 |
| gmaan | stephenfin: ack | 16:27 |
| gmaan | gibi: thanks., i will check on eventlet one after dropping my son to school. and thanks for graceful shutdown review, will fix the doc change soon | 16:28 |
| *** gmaan is now known as gmaan_afk | 16:29 | |
| opendevreview | ribaudr proposed openstack/nova master: FUP Add HW_PCI_LIVE_MIGRATABLE trait to PCI resource providers https://review.opendev.org/c/openstack/nova/+/977310 | 16:43 |
| gibi | tkajinam: I'm +2 all the way up on the fw autoselect series. Thanks for the work. I added +As to the bottom patches so it is starting to land soon | 17:29 |
| *** gmaan_afk is now known as gmaan | 17:37 | |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 17:46 |
| gmaan | gibi: ^^ updated the doc one | 17:46 |
| gibi | gmaan: thanks +2 there as well | 17:49 |
| gmaan | thanks | 17:49 |
| opendevreview | Merged openstack/nova master: Add manager graceful shutdown, timeout, and wait https://review.opendev.org/c/openstack/nova/+/975586 | 17:58 |
| opendevreview | Merged openstack/nova master: Fix for bug 2140537 https://review.opendev.org/c/openstack/nova/+/975934 | 18:23 |
| opendevreview | Merged openstack/nova master: Fix the negative sleep value in graceful_shutdown() https://review.opendev.org/c/openstack/nova/+/977708 | 19:14 |
| opendevreview | Merged openstack/nova master: libvirt: Extend functional test coverage of UEFI boot guests https://review.opendev.org/c/openstack/nova/+/969263 | 19:15 |
| gmaan | bauzas: thanks for review on first 3, these 4 are also ready (need 2nd +2), hoping we can land those before FF. https://review.opendev.org/q/topic:%22bp/nova-services-graceful-shutdown-part1%22+status:open | 19:32 |
| sean-k-mooney | those seam to be listed as merconfict with some of the eventlet serise. is tehre a planned merge order betweeen teh two? | 19:34 |
| sean-k-mooney | or a plan to stack them to avoid that? | 19:34 |
| gmaan | oh, I did not see in gerrit. | 19:35 |
| gmaan | where did you see merge conflict | 19:35 |
| sean-k-mooney | there isnt one yet but if you look at the merge conflicts listed on https://review.opendev.org/c/openstack/nova/+/975588/26 | 19:36 |
| sean-k-mooney | it will conflict with https://review.opendev.org/c/openstack/nova/+/965467 and the two patches below it | 19:36 |
| gmaan | I think that is only for https://review.opendev.org/c/openstack/nova/+/977582 | 19:36 |
| gmaan | but I need to check with gibi if we need to plan that as part of this cycle of can we do in next cycle | 19:37 |
| gmaan | other one should be fine | 19:37 |
| sean-k-mooney | well i think its form https://review.opendev.org/c/openstack/nova/+/975833 | 19:37 |
| gmaan | I do not see any other changing same file | 19:38 |
| sean-k-mooney | and the other two just depend on that | 19:38 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/975833 and https://review.opendev.org/c/openstack/nova/+/975588 are both changing the comptue manger | 19:38 |
| gmaan | yes but i do not think there will be merge conflict as both changing different lines | 19:39 |
| gmaan | not sure if gerrit showing correctly but if it happens we can resolve those | 19:39 |
| gmaan | let's see how it goes in order | 19:39 |
| sean-k-mooney | ok well i could just review https://review.opendev.org/c/openstack/nova/+/975833 now and appove it i have reviewd the other two and we could finish that work for the cycle | 19:39 |
| sean-k-mooney | and the i can try and look at your serise tomorrow if you remined me | 19:40 |
| gmaan | sean-k-mooney: yeah, i was typing the same :) | 19:40 |
| gmaan | if we can merge 975833, it will be more clear | 19:40 |
| sean-k-mooney | cool ill look at that now. im around for the next 20 mins | 19:41 |
| gmaan | perfect, thanks | 19:41 |
| gmaan | now time for openapi series, let see how much i can finish | 19:41 |
| sean-k-mooney | ok assuming the recheck for the kernel panic goes through those 3 eventelt patche should be ready to merge | 19:45 |
| gmaan | cool | 19:45 |
| sean-k-mooney | ill try and do a pass on https://review.opendev.org/q/topic:%22bp/nova-services-graceful-shutdown-part1%22+is:open tomorrow | 19:46 |
| gmaan | perfect, thanks | 19:46 |
| gmaan | i see ceph error "Could not find the requested service virtlockd.service: host" | 19:47 |
| gmaan | in other change | 19:47 |
| gmaan | did not we merge your fix? | 19:47 |
| sean-k-mooney | we did | 19:47 |
| sean-k-mooney | in what job? | 19:47 |
| gmaan | ceph job but that is 7 days old https://zuul.opendev.org/t/openstack/build/89f3ebb0ca94482082afe504069ed2a8/console | 19:48 |
| gmaan | yeah, it merged after this test run https://review.opendev.org/c/openstack/nova/+/977150 | 19:48 |
| gmaan | so recheck should work | 19:49 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/977150/1 | 19:49 |
| sean-k-mooney | that merged 6 days ago so ya recheck should pass now | 19:49 |
| sean-k-mooney | that or a rebase | 19:49 |
| gmaan | yeah, all good. i recheked the failure | 19:49 |
| sean-k-mooney | cool | 19:50 |
| gmaan | it should pick up latest master in recheck | 19:50 |
| opendevreview | Merged openstack/nova master: libvirt: Add basic xml generation for firmware auto selection https://review.opendev.org/c/openstack/nova/+/969085 | 20:11 |
| opendevreview | Merged openstack/nova master: libvirt: Add capability to load loader and nvram from xml https://review.opendev.org/c/openstack/nova/+/969086 | 20:12 |
| opendevreview | Doug Goldstein proposed openstack/nova master: return error about external network to the user on build failure https://review.opendev.org/c/openstack/nova/+/972601 | 21:56 |
| gmaan | stephenfin: one comment for this, rest all lgtm https://review.opendev.org/c/openstack/nova/+/976765 | 22:30 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (1/6) https://review.opendev.org/c/openstack/nova/+/956234 | 23:44 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (2/6) https://review.opendev.org/c/openstack/nova/+/956236 | 23:45 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (3/6) https://review.opendev.org/c/openstack/nova/+/956237 | 23:57 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (4/6) https://review.opendev.org/c/openstack/nova/+/956238 | 23:57 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!