| opendevreview | Merged openstack/nova master: tests: Fix bound https://review.opendev.org/c/openstack/nova/+/971038 | 00:17 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | 01:34 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 01:34 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 01:34 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 01:34 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052 | 01:34 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 01:39 |
| opendevreview | Doug Goldstein proposed openstack/nova master: return error about external network to the user on build failure https://review.opendev.org/c/openstack/nova/+/972601 | 01:44 |
| gmaan | gibi: fyi, due to dentist appointment, i will skipping the eventlet call tomorrow | 02:11 |
| opendevreview | Nope proposed openstack/nova master: scheduler: re-query Placement after stale-snapshot claim failures https://review.opendev.org/c/openstack/nova/+/977908 | 05:00 |
| opendevreview | Nope proposed openstack/nova master: scheduler: re-query Placement after stale-snapshot claim failures https://review.opendev.org/c/openstack/nova/+/977908 | 07:00 |
| gibi | gmaan: ack, good luck with the dentist | 08:39 |
| gibi | it seems nova-next is blocked by | 08:42 |
| gibi | Details: {'code': 400, 'message': 'Port 7896377a-52fa-43b1-94d6-c97eb5e4ac79 requires a FixedIP in order to be used.'} | 08:43 |
| gibi | e.g. https://9d9eac1385c9916c71e7-8b0899cb6c8c0582fa25b52fb6031f3e.ssl.cf2.rackcdn.com/openstack/e293ec7c475544fab51185c08ef61814/testr_results.html | 08:43 |
| gibi | https://zuul.opendev.org/t/openstack/builds?job_name=nova-next&project=openstack/nova | 08:43 |
| gibi | since this morning | 08:43 |
| frickler | gibi: that looks like https://review.opendev.org/c/openstack/tempest/+/959187 ? | 08:45 |
| gibi | frickler: ahh thanks it very much like that | 08:46 |
| gibi | I'm going to propose revert to save the progress towards FF | 08:46 |
| frickler | ack, I think I could override if you don't want to wait for gmaan's dentist | 08:47 |
| gibi | frickler: yes please Signed-off-by: Balazs Gibizer <gibi@redhat.com> | 08:50 |
| gibi | https://review.opendev.org/c/openstack/tempest/+/977922 | 08:50 |
| gibi | (sorry wrong buffer) | 08:50 |
| gibi | cc Uggla gmaan ^^ | 08:52 |
| Uggla | gibi :+1 | 08:54 |
| frickler | and done. gibi can you please also create a revert of the revert and add a nova testing patch this time? | 08:59 |
| gibi | sure I can | 09:01 |
| gibi | thanks for the help | 09:01 |
| gibi | frickler: this is the reapply patch with nova-next testing now https://review.opendev.org/c/openstack/tempest/+/977930 | 09:21 |
| frickler | thx | 09:22 |
| sean-k-mooney | gibi: i have not looks but we could also just skip that test in nova-next quickly | 11:37 |
| sean-k-mooney | ah i see the revert is merged already | 11:39 |
| gibi | yep | 12:13 |
| r-taketn | gibi: Uggla: Hello. Thank you for reviewing the SEV refactoring patches despite your busy schedule. I'd appreciate it if you could also take a look at the remaining patches. | 12:27 |
| sean-k-mooney | gibi: im going to review gmaan graceful shutdown patches now but ill hold +w on the bottom patch until we hopefully see your 3 eventlet removal patchs merge | 12:27 |
| sean-k-mooney | gibi: but we can check in on that in the call later today | 12:28 |
| gibi | sean-k-mooney: ack thanks. I saw the merge conflict. Hopefully we land the eventlet patches soon. They are approved but needed a recheck due to the tempest issue | 12:30 |
| opendevreview | Bence Romsics proposed openstack/nova master: Functional reproducer for #2051685 https://review.opendev.org/c/openstack/nova/+/977331 | 12:30 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove errant field https://review.opendev.org/c/openstack/nova/+/976765 | 12:32 |
| stephenfin | gmaan: sean-k-mooney: Addressed gmaan's comment on ☝️ if you could revisit 🙏 | 12:32 |
| sean-k-mooney | gibi: yep i checked them when i logged on this morning | 12:32 |
| sean-k-mooney | stephenfin: done | 12:33 |
| stephenfin | ty | 12:33 |
| tkajinam | gibi, thanks ! | 13:00 |
| tkajinam | bauzas, I'm wondering if you have chance to re-review https://review.opendev.org/c/openstack/nova/+/969132 ? I think I addressed your previous comments blocking +2 (If I took these right, hopefully | 13:06 |
| tkajinam | the others are being merged | 13:06 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for general additionalProperties https://review.opendev.org/c/openstack/nova/+/958858 | 14:12 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Fix issue with instance usage audit log schema https://review.opendev.org/c/openstack/nova/+/977967 | 14:12 |
| stephenfin | gmaan: sean-k-mooney: I had to rework that second patch slightly to handle a few more corner cases. Also found a bug in one of the more complicated schemas. Would appreciate a once-over ☝️ | 14:12 |
| stephenfin | s/second/first/ | 14:14 |
| opendevreview | Stephen Finucane proposed openstack/nova master: db: Move regex helpers to utils https://review.opendev.org/c/openstack/nova/+/958745 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Clean up flavors tests https://review.opendev.org/c/openstack/nova/+/958746 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Simplify API version check for flavor description https://review.opendev.org/c/openstack/nova/+/958747 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add ability to filter flavors by name https://review.opendev.org/c/openstack/nova/+/958748 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 14:22 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 14:22 |
| opendevreview | Nope proposed openstack/nova master: scheduler: re-query Placement after stale-snapshot claim failures https://review.opendev.org/c/openstack/nova/+/977908 | 14:55 |
| bauzas | tkajinam: done now :) | 15:40 |
| bauzas | gmaan: gibi: there is a potential merge conflict in between https://review.opendev.org/c/openstack/nova/+/975588/26 (2nd RPC service) and n-cpu threading support so I won't accept the former until there is a rebase | 15:48 |
| bauzas | threading support is more important for the cycle, I hope you get it | 15:49 |
| sean-k-mooney | yep that is why we are merging the eventlet patches first | 15:49 |
| gibi | sorry folks I totally missed the eventlet call today | 15:50 |
| gibi | :/ | 15:50 |
| sean-k-mooney | ^ cordiating with graceful shutdown was the only topic i was going to raise | 15:51 |
| sean-k-mooney | im review that serice now but honestly i was expect gmann ot have creted fucntionla test to test graceful shutdown | 15:51 |
| gibi | bauzas: yeah the eventlet series is approved but gate is slow and unstable so it will take time. | 15:51 |
| gibi | I'm monitoring it... | 15:52 |
| sean-k-mooney | so im not sure that is ready i am also not really ok with callign it anything more then expreimetnal until we comple phase 2 and 3 | 15:52 |
| bauzas | I guess I'll give another swing to vtpm live-migration series | 15:58 |
| tkajinam | bauzas, thanks ! | 16:41 |
| melwitt | bauzas, dansmith: for vtpm the patches targeted for FF are the fixups patch https://review.opendev.org/c/openstack/nova/+/976316 and the service version bump https://review.opendev.org/c/openstack/nova/+/975724 (since we got 'host' secret security mode available at this time). the rest will have to wait until H | 16:42 |
| dansmith | melwitt: ack, I'll try to circle back soon, sorry for being pulled in multiple directions | 16:45 |
| melwitt | thanks 🙏 | 16:46 |
| bauzas | melwitt: noted, I'll look at those before ending my day | 17:08 |
| melwitt | thanks 🙏 | 17:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.101 https://review.opendev.org/c/openstack/nova/+/978002 | 17:20 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove unused gabbi https://review.opendev.org/c/openstack/nova/+/978006 | 17:36 |
| opendevreview | Merged openstack/nova master: libvirt: Add capability to load smm feature from existing xml https://review.opendev.org/c/openstack/nova/+/969131 | 17:47 |
| opendevreview | Merged openstack/nova master: libvirt: Use firmware auto-selection by libvirt https://review.opendev.org/c/openstack/nova/+/969132 | 18:13 |
| gmaan | sean-k-mooney: thanks for review on graceful shutdown, i am ok to callout the experimental in releasenotes and once we finish the all phases we will have exact list/things which finish or move to safe state in shitdown | 19:47 |
| gmaan | sean-k-mooney: bauzas gibi seeing the gate eventlet series might take time to merge and rebasing the graceful shutdown can miss the FF date. | 19:48 |
| gmaan | as eventlet changes are with +w let me rebase in advance so that graceful shutdown can be in gate in parallel | 19:48 |
| sean-k-mooney | ack | 19:49 |
| sean-k-mooney | i really jsut dont want to get a custoemr case in the future whre the go "you said shutdown was graceful" and the interupted a live migration and got into an underined state | 19:50 |
| sean-k-mooney | so if we call it experimetal untill pahse 2 or 3 is done i think its fine to merge although i woudl really like to see functional tests added next cycle to buidl conficance in this | 19:50 |
| gmaan | for me interrupted is fine as it can be solved with the configured timeout but an underined state i agree that we should make sure | 19:51 |
| sean-k-mooney | the ansible/bash tests help | 19:51 |
| gmaan | sean-k-mooney: functional test for phase 2 and 3 will cover the things but for phase1 which is all about RPC redesign cannot be cover by functional tests as they use fake driver | 19:51 |
| sean-k-mooney | oh ya i have said its totally fine with me if we just abort the ongoing live migration or interupt them in a fixable state. | 19:52 |
| gmaan | yeah | 19:52 |
| sean-k-mooney | the funcitonl tests can use the livbirt driver | 19:52 |
| sean-k-mooney | and we have live migration fucntional test already | 19:52 |
| gmaan | I mean fake RPC driver | 19:52 |
| gmaan | they do not use real RPC | 19:52 |
| sean-k-mooney | thye use the fake rpc yes, the in memory one but ya the reaosn i bring it up was it was stated we would have them in the spec and i was expecting to see them in the code when i went to review | 19:53 |
| sean-k-mooney | so we need to modify oslo to make the fake tansport supprot more the one rpc server ? | 19:54 |
| sean-k-mooney | or can we make that work form the nova side? | 19:54 |
| gmaan | I will say integration tests which is doable are ok for the RPC part | 19:55 |
| gmaan | sand for phase 2/3 yes, it can be covered in functional with better control | 19:55 |
| sean-k-mooney | ack, i can live with that. i dont relaly trust the integration tests to test this on its own | 19:56 |
| sean-k-mooney | but we agree to make incremental progress so thats ok | 19:56 |
| gmaan | k, let me rebase and fix the other comments you have | 19:57 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | 20:22 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | 20:32 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182 | 20:36 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405 | 20:46 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (5/6) https://review.opendev.org/c/openstack/nova/+/956239 | 21:00 |
| gmaan | bauzas: sean-k-mooney gibi it seems, there is no merge conflict between eventlet and graceful shutdown changes, but anyways I have rebased latter one on eventlet. | 21:19 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 21:19 |
| gmaan | sean-k-mooney: updated ^^ doc change also | 21:19 |
| sean-k-mooney | gmaan: im +2 on all of your changes thanks for the update | 21:33 |
| sean-k-mooney | gmaan: gibi is unfutently not have great luck with the ci gods at the moment but maybe you can recheck the eventlet patches later in NA time when the ci might be less flaky | 21:34 |
| gmaan | sean-k-mooney: thanks, I will keep eyes on CI | 21:45 |
| cardoe | sean-k-mooney: ping https://review.opendev.org/c/openstack/nova/+/972601 | 22:02 |
| cardoe | I just posted a reply to you but I wanted to discuss it. | 22:02 |
| cardoe | I believe you're misunderstanding what my change did. My change is matching the behavior of KVM/libvirt with the ironic driver. And making it so that the full backtrace is unnecessary to the end user to troubleshoot. | 22:03 |
| cardoe | There's half a dozen bug reports / issues today where if I do X with KVM/libvirt, I get a clear error message explaining why it didn't work. But when I use the ironic driver via nova, the error message I get as a user is either wrong or generic and the only way to work out what happened is to read the full backtrace. Inside of that full backtrace is the same one that's being delivered back to the user in the KVM/libvirt case. | 22:09 |
| gmaan | sean-k-mooney: thanks | 22:32 |
| gmaan | gibi: if you can re-review it https://review.opendev.org/c/openstack/nova/+/975588 this first one | 22:32 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | 22:49 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 22:49 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 22:49 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 22:49 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052 | 22:49 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 22:49 |
| cardoe | gmaan: neat. So we'll be able to shutdown gracefully and let it continue to manage things. | 23:54 |
| gmaan | cardoe: yes, we introduced the 2 RPC server in compute so that compute stop accepting the new request and finish the in-progress one. in this phase-1, services wait for configuration timeout which will be replaced by task tracking in next part. | 23:59 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!