| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 00:05 |
|---|---|---|
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 01:33 |
| gmaan | gate is in its worst situation | 01:35 |
| gmaan | gibi: sean-k-mooney and this doc also need re-review, fixed pep8 spell things https://review.opendev.org/c/openstack/nova/+/977590 | 02:38 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for servers APIs (6/6) https://review.opendev.org/c/openstack/nova/+/956240 | 03:00 |
| opendevreview | Merged openstack/nova master: api: Add response body schemas for server shares APIs https://review.opendev.org/c/openstack/nova/+/956266 | 08:50 |
| opendevreview | Merged openstack/nova master: tests: Invert validation check https://review.opendev.org/c/openstack/nova/+/956241 | 08:50 |
| gibi | I'm envy about the folks who can land patches through the gate. The eventlet series now stuck for more than 24 hours behind random failures. I feel bad about grinding rechecks but I will do it anyhow :/ | 08:59 |
| frickler | let me know if you need help like re-enqueueing changes directly back into gate or even force-merging. once you're sufficiently sure the failures are unrelated IMO it doesn't make sense to keep doing rechecks and using up CI resources | 09:15 |
| frickler | and I say this knowing that getting tests more stable is a high priority for the nova team anyway | 09:16 |
| gibi | yeah, we need to stabilize our gate | 09:18 |
| gibi | and thanks I might eventually ask for help requeuing | 09:19 |
| sean-k-mooney | frickler: gibi os we can remove a class of error form the ceph jobs it we just move them to useing nested virt (kvm) | 09:28 |
| sean-k-mooney | nova doesnt do that but nuetorn and some other teams do | 09:29 |
| sean-k-mooney | for exampel the kernel panics on volume detach | 09:30 |
| sean-k-mooney | the ssh timeout might go away if we enabel the creation fo the tap devices by os-vif. i need to try enableing that in the gate now that the neutron bits are all in place | 09:31 |
| sean-k-mooney | but yes we take some time to adress more of those failures. the issue nova has is those failure are often not form nova/hypervior comonents | 09:32 |
| sean-k-mooney | i.e. the etc/ceph contianer download fialures | 09:32 |
| sean-k-mooney | *etcd | 09:33 |
| sean-k-mooney | i think we can improve ^ in devstack by stragicly retrying some fo the downloads | 09:33 |
| bauzas | do we have at least an idea on why the failures are more recurrent those days ? those look like usual suspects | 09:33 |
| bauzas | (speaking of the volume detach kernel panics and the ssh timeouts - the latter already being WA'd a lot) | 09:34 |
| sean-k-mooney | bauzas: i dont think any of the failure gibi has been hitting were new. they all looked like the "ususal suspects" | 09:34 |
| sean-k-mooney | so my guess is load make it manifest more | 09:35 |
| sean-k-mooney | the kernel panics dont happen if we use either kvm or the uec images | 09:35 |
| sean-k-mooney | both of which change (speedup) the timing of the kernel loading in cirrus | 09:35 |
| gibi | yeah load does not help | 09:36 |
| gibi | I just saw a guest bootop where every step took a second | 09:36 |
| gibi | SEND | 09:36 |
| gibi | [ 4.017889] clocksource: Switched to clocksource tsc | 09:36 |
| gibi | [ 5.258926] ACPI: \_SB_.LNKB: Enabled at IRQ 10 | 09:36 |
| gibi | [ 5.553620] Freeing initrd memory: 8864K | 09:36 |
| gibi | [ 6.239466] ACPI: \_SB_.LNKC: Enabled at IRQ 11 | 09:36 |
| gibi | [ 7.080979] ACPI: \_SB_.LNKD: Enabled at IRQ 11 | 09:36 |
| gibi | [ 7.966979] ACPI: \_SB_.LNKA: Enabled at IRQ 10 | 09:36 |
| gibi | [ 8.834095] Free page reporting enabled | 09:36 |
| gibi | [ 8.839828] Serial: 8250/16550 driver, 32 p | 09:36 |
| sean-k-mooney | ya... | 09:36 |
| gibi | this is not sustainable with our current ssh timeouts | 09:36 |
| sean-k-mooney | so the ceph jobs i think we shoudl consdier movign to the nested virt lables to compenstate for the ceph cpu load or look at the perfromence of them in general because those are the ones that hit those time out most often | 09:38 |
| sean-k-mooney | and the kernel panincs most often | 09:38 |
| sean-k-mooney | it would be intersting to compare the boot time form one of those jobs vs the non ceph jobs | 09:38 |
| sean-k-mooney | or look at the load average for the jobs | 09:39 |
| gibi | eah | 09:40 |
| gibi | yeah | 09:40 |
| sean-k-mooney | gibi: i take it the eventlet changes didnt merge last night | 09:40 |
| * bauzas reads the kernel boot timings above and is amazed | 09:50 | |
| sean-k-mooney | amazed that any of the jobs pass? :) | 09:51 |
| bauzas | gibi: were you able to see the vmstat values of the host at the time the VM was booting that fast ? | 09:51 |
| bauzas | sean-k-mooney: looks like we play a Claw machine game | 09:53 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 11:07 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 11:07 |
| opendevreview | Stephen Finucane proposed openstack/nova master: conf: Deprecate AggregateImagePropertiesIsolation opts https://review.opendev.org/c/openstack/nova/+/783396 | 11:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: conf: Deprecate AggregateImagePropertiesIsolation opts https://review.opendev.org/c/openstack/nova/+/783396 | 11:09 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.101 https://review.opendev.org/c/openstack/nova/+/978002 | 11:28 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 11:28 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 11:28 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 11:28 |
| opendevreview | sean mooney proposed openstack/nova master: ci: Define nested nodesets, audit KVM/UEC, move nova-next https://review.opendev.org/c/openstack/nova/+/978066 | 12:14 |
| gibi | sean-k-mooney: it didn't. I still rechecking :/ | 12:21 |
| gibi | bauzas: I did not dig deeper. I see overall slowness so it is probably infra overload due to FF churn | 12:22 |
| sean-k-mooney | ^ might help but it has not run in ci yet to see if its functionatl | 12:22 |
| sean-k-mooney | lol nope | 12:22 |
| sean-k-mooney | it has zuul sytax errors | 12:22 |
| sean-k-mooney | which i thinkis a typo | 12:22 |
| opendevreview | sean mooney proposed openstack/nova master: ci: Define nested nodesets, audit KVM/UEC, move nova-next https://review.opendev.org/c/openstack/nova/+/978066 | 12:34 |
| sean-k-mooney | was missign a 1 in compute1 | 12:37 |
| opendevreview | sean mooney proposed openstack/nova master: ci: Define nested nodesets, audit KVM/UEC, move nova-next https://review.opendev.org/c/openstack/nova/+/978066 | 12:47 |
| opendevreview | sean mooney proposed openstack/nova master: ci: Define nested nodesets, audit KVM/UEC, move nova-next https://review.opendev.org/c/openstack/nova/+/978066 | 13:00 |
| sean-k-mooney | i shoudl not try to update patches while also in an irc meeting... | 13:00 |
| gmaan | oh, i hoped at least a few will be merged overnight... | 13:25 |
| opendevreview | Merged openstack/nova master: api: Fix issue with instance usage audit log schema https://review.opendev.org/c/openstack/nova/+/977967 | 13:26 |
| opendevreview | Merged openstack/nova master: api: Add runtime check for general additionalProperties https://review.opendev.org/c/openstack/nova/+/958858 | 13:26 |
| opendevreview | Merged openstack/nova stable/2024.2: api: Fix validators for hw:cpu_max_* extra specs https://review.opendev.org/c/openstack/nova/+/957744 | 13:26 |
| sean-k-mooney | so it si posibel to merge things ^ | 13:26 |
| sean-k-mooney | but that seriese is apprently cursed | 13:27 |
| DominikDanelski[m] | sean-k-mooney: In https://review.opendev.org/c/openstack/nova/+/971176/comment/e96c41d6_d900c91a/ you mentioned 'repurposing' the spec. Is it done by essentially making a modified copy that targets a newer release and has no direct link to the previous one, or should git move the accepted one from Ussuri, since it wasn't implemented then, modify it, and add an appropriate line to redirects file? | 13:27 |
| sean-k-mooney | DominikDanelski[m]: yes you copy the spec to the new folder and update the history section at the end to note its re proposed | 13:28 |
| sean-k-mooney | we do not move them as we want to keep every revsion fo the spec that were prevsouly approved so we can clearly see any deltas | 13:28 |
| DominikDanelski[m] | All right, thank you. | 13:29 |
| opendevreview | Merged openstack/nova master: libvirt: Remove unnecessary arg https://review.opendev.org/c/openstack/nova/+/881817 | 13:49 |
| *** sambork_ is now known as sambork | 14:10 | |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 14:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 14:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 14:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 14:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 14:35 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 14:35 |
| gibi | dansmith: o/ I'm +2 on the making the volume attach async in https://review.opendev.org/c/openstack/nova/+/971068 | 14:42 |
| dansmith | ack | 14:43 |
| cardoe | sean-k-mooney: around? Wanted to follow up about what I posted here. | 14:50 |
| Uggla | gibi, bauzas, any chance we can merge https://review.opendev.org/q/topic:%22bp/generalize-sev-code%22 to my mind it is ok except maybe the latest one. | 14:51 |
| bauzas | Uggla: I was trying to look at it | 14:53 |
| Uggla | dansmith it would be super cool if you can check https://review.opendev.org/c/openstack/nova/+/971068 | 14:54 |
| gibi | Uggla: I have couple of +2s in the series | 14:54 |
| gibi | but not all the way top | 14:54 |
| gibi | so I'm not sure if I will have the energy today to go up to the top | 14:54 |
| gibi | but I will try | 14:54 |
| Uggla | gibi, i guess all comments were addressed and that looks in a good shape. | 14:55 |
| dansmith | Uggla: isn't that the one gibi just poked me on? | 14:55 |
| Uggla | dansmith yes, just re-enforcing the msg. :) | 14:55 |
| Uggla | sean-k-mooney, gmaan super cool for openapi. Thanks for the effort. 👍 | 14:59 |
| cardoe | Uggla: I'm hoping we can get https://review.opendev.org/c/openstack/nova/+/972601 into the next release. | 15:06 |
| cardoe | I'm trying to follow up with sean-k-mooney cause his -1 reason is literally what this patch is correcting. | 15:06 |
| cardoe | For context, KVM/libvirt driver does not use the prepare_networks_before_block_device_mapping() while the ironic driver does. Which is what is the root cause of this. | 15:07 |
| bauzas | cardoe: maybe you don't know but today is FeatureFreeze, we prioritize for the moment reviews for blueprints | 15:07 |
| bauzas | cardoe: during the next two weeks, we can then look at bugfixes like this one | 15:08 |
| Uggla | cardoe, that's a bug right. So it is not impacted by FF. | 15:08 |
| cardoe | bauzas: okay I didn't know. | 15:08 |
| cardoe | I was just trying to provide context. | 15:09 |
| bauzas | cardoe: no worries, you can usually find the release cadence there : https://releases.openstack.org/gazpacho/schedule.html | 15:09 |
| Uggla | cardoe, so as bauzas explains we could merge it in the following weeks. Assuming all comments will be addressed | 15:09 |
| bauzas | cardoe: again, no worries, my only concern is about context switching, like for the moment I'm trying to make sure we could accept a SEV-ES usecase | 15:09 |
| bauzas | cardoe: but please ping us next week around Tuesday, we could look at the bug | 15:10 |
| cardoe | Not asking you folks to context switch right now. Just putting info in here so that you can follow up async. | 15:10 |
| cardoe | But I can ping next Tuesday. | 15:10 |
| bauzas | thanks | 15:10 |
| Uggla | cardoe also good to put it in our dev plan: https://etherpad.opendev.org/p/nova-2026.1-status so we should not missed it. (note: I did it for you) | 15:14 |
| sean-k-mooney | cardoe: i was confused by the wroding you had in relese note | 15:15 |
| sean-k-mooney | ill take anouther look | 15:15 |
| cardoe | We've just had 4 bugs opened this cycle alone with users hitting that which was surprising. | 15:15 |
| sean-k-mooney | cardoe: part of the concern i had with that patch was i did not see you addinga unit test that clearly showed what the meesage would be | 15:18 |
| sean-k-mooney | cardoe: i.e. it was not clear at a glance what you were actully fixign when i looked at it | 15:18 |
| cardoe | I can if you'd like. All the other tests to decide what exceptions come up to the user just validate the exception that's raised and not the text of the exception | 15:19 |
| cardoe | So the test would be different than all the others. | 15:19 |
| cardoe | To me it looked like you guys white list certain exceptions that can make it to the user otherwise all other exceptions get wrapped such that the error message to the user is a generic "this step failed" | 15:20 |
| cardoe | But I can change it to validate the string of the exception. | 15:20 |
| gibi | Uggla: I spotted a potential bug in the sev refactor series in https://review.opendev.org/c/openstack/nova/+/967972 | 15:21 |
| tkajinam | Returning 400 to user: Invalid input for field/attribute addresses. Value: {'': [{'version': 4, 'addr': '10.1.1.162', 'OS-EXT-IPS:type': 'fixed', 'OS-EXT-IPS-MAC:mac_addr': 'fa:16:3e:cb:ae:2e'}]}. '' does not match any of the regexes: '^.+$' | 15:28 |
| tkajinam | it seems some of the GET requests are broken by schema validation | 15:28 |
| * tkajinam is creating a bug | 15:28 | |
| gibi | tkajinam: is it a fresh one? did we landed some new schema validation thst break it? | 15:37 |
| tkajinam | these were caught in https://zuul.opendev.org/t/openstack/build/d293798e270240c18bbfbb8d02d1ed4b which completed a few hours ago | 15:37 |
| tkajinam | https://bugs.launchpad.net/nova/+bug/2142767 | 15:38 |
| tkajinam | https://bugs.launchpad.net/nova/+bug/2142765 | 15:38 |
| tkajinam | I have to dig into the latter because it is blocking instance creation by heat, it seems | 15:38 |
| tkajinam | hmm I guess these two are connected because the failure might be detected during returning a response | 15:40 |
| bauzas | I reviewed the first patch and I'm looking into the second, but I still have a bit of concerns, so I guess we gonna have to make a draw | 15:41 |
| *** dviroel is now known as dviroel_afk | 15:45 | |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Accept an empty key for addresses https://review.opendev.org/c/openstack/nova/+/978089 | 15:49 |
| gibi | both seems to complaim that addresses are empty | 15:49 |
| Uggla | gibi, bauzas ok | 15:49 |
| tkajinam | gibi, yeah. I think the problem is the top key under the addresses are empty and IIUC these keys are network names in neutron | 15:50 |
| tkajinam | and ... name in neutron networks is optional. | 15:50 |
| tkajinam | testing the above patch by https://review.opendev.org/c/openstack/ceilometermiddleware/+/978090 ... | 15:51 |
| opendevreview | Merged openstack/nova master: db: Move regex helpers to utils https://review.opendev.org/c/openstack/nova/+/958745 | 15:54 |
| opendevreview | Merged openstack/nova master: tests: Clean up flavors tests https://review.opendev.org/c/openstack/nova/+/958746 | 15:54 |
| sean-k-mooney | cardoe: we only allow exepciton that have no hostspecif info to get to the user | 15:56 |
| sean-k-mooney | or ratehr we often only show the name of the exctpion to non admins | 15:56 |
| cardoe | yeah this makes the behavior identical to KVM/libvirt driver for this error | 15:57 |
| cardoe | because the ironic driver has prepare_networks_before_block_device_mapping, it sets up the networks earlier than the KVM/libvirt does. | 15:58 |
| sean-k-mooney | on the nova side we treat any exposure of the hypervior/compute node name as a security hardenign opertunity | 15:58 |
| sean-k-mooney | not nessiarly a cve but we try to treat that as privldage so we are a bit carfeul with the raw tracebacks as a result | 15:59 |
| sean-k-mooney | cardoe: ya idely the behvior shoudl be the same give me a sec to finsih up something now im off a call and ill take a look again | 16:00 |
| gibi | tkajinam: make sense +2 | 16:01 |
| opendevreview | Merged openstack/nova master: api: Simplify API version check for flavor description https://review.opendev.org/c/openstack/nova/+/958747 | 16:20 |
| opendevreview | Merged openstack/nova master: Deprecate unlimited compute actions https://review.opendev.org/c/openstack/nova/+/975833 | 16:59 |
| opendevreview | Merged openstack/nova master: [compute]Use single long task executor https://review.opendev.org/c/openstack/nova/+/977251 | 16:59 |
| *** dviroel_afk is now known as dviroel | 17:01 | |
| sean-k-mooney | gibi: ^ :) | 17:02 |
| gibi | \○/ | 17:06 |
| gibi | one more to go | 17:07 |
| sean-k-mooney | im watching nova-next finish its tempest run | 17:07 |
| gibi | then we can root for the graceful series on top | 17:07 |
| sean-k-mooney | yep also https://review.opendev.org/c/openstack/nova/+/958748/6 if we can land that | 17:08 |
| gmaan | finally :) | 17:14 |
| gmaan | I think there are 3 changes competing for microversion 2.101 | 17:20 |
| dansmith | I just approved the async volume attach one that wants 101 | 17:20 |
| gmaan | this one is in gate, which should get it https://review.opendev.org/c/openstack/nova/+/971068 | 17:20 |
| gmaan | dansmith: yeah | 17:20 |
| gmaan | I am reviewing the remove-os-volumes_boot which is almost ready but remember the async volume one | 17:21 |
| gmaan | stephenfin: do you want to update remove-os-volumes_boot on top of async vol one? | 17:22 |
| gmaan | stephenfin: I am holding the +w and one comment to update the spec whihc mentioned to return 410 instead of 404 | 17:31 |
| gmaan | sean-k-mooney: also, you tagged this cleanup as part of this BP but that is not related, it will be good to keep that separate https://review.opendev.org/c/openstack/nova/+/958863 | 17:32 |
| gmaan | stephenfin: ^^ | 17:32 |
| gmaan | sean-k-mooney: please ignore, i need to start my auto tab after typing two letter :) | 17:33 |
| sean-k-mooney | ya i mented that seperatly to stephenfin, that it woudl be better to flip the order of that and teh one on top | 17:41 |
| sean-k-mooney | gmaan: i was debeaitn if i shoudl rasie the 404 vs 410 point | 17:42 |
| sean-k-mooney | i decied not to becasue i think the pattern we have is we only return 410 if we remove it form all micoverions | 17:42 |
| sean-k-mooney | but use a 404 if its only remove in a specific microverison | 17:43 |
| gmaan | yes, because we have same patter for other APIs also for example proxy one. and the one which are gone for all microversion they return 410 | 17:43 |
| opendevreview | Merged openstack/nova master: Run nova-compute in native threading mode https://review.opendev.org/c/openstack/nova/+/965467 | 17:44 |
| opendevreview | Merged openstack/nova master: Use 2nd RPC server in compute operations https://review.opendev.org/c/openstack/nova/+/975588 | 17:45 |
| gibi | \○/ | 17:45 |
| gmaan | \o/ gibi grab a beer | 17:45 |
| gibi | I'm done for today :) | 17:45 |
| opendevreview | Merged openstack/nova master: Prepare resize/cold migration for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977182 | 17:45 |
| gmaan | o/ | 17:45 |
| sean-k-mooney | gmaan: so this doesnt remvoe it outright right | 17:45 |
| gibi | o/ | 17:45 |
| opendevreview | Merged openstack/nova master: Add more test for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977405 | 17:46 |
| gibi | when things start moving... | 17:46 |
| opendevreview | Merged openstack/nova master: Add operator document for graceful shutdown https://review.opendev.org/c/openstack/nova/+/977590 | 17:46 |
| gmaan | sean-k-mooney: did not get, you mean for spec update? | 17:46 |
| sean-k-mooney | i ment https://review.opendev.org/c/openstack/nova/+/958864 | 17:47 |
| gibi | gmaan: you reached early beer state today :) | 17:47 |
| sean-k-mooney | so ya im jsut clarifyign are you asking for a 410 to be returend or the spec to be updated to 404 | 17:47 |
| gmaan | yeah, gate check our patient level and gives blessing | 17:47 |
| gmaan | gibi: heh yeah | 17:48 |
| gmaan | sean-k-mooney: ohk, I am saying code is good i am +2 there. i am asking spec to update once we land the code | 17:48 |
| gmaan | just paper work nothing else | 17:48 |
| sean-k-mooney | ack stephenfin ^ you might want to read back | 17:48 |
| gmaan | which can be done later but I am holding +w due to microversion conflict only | 17:49 |
| sean-k-mooney | stephen wont be around for the next 2 hours but they will be back on line later | 17:52 |
| gmaan | ack, no issue, I will check as soon as it is updated | 17:57 |
| opendevreview | Sebastian Krott proposed openstack/nova master: conductor: Clean up port-bindings for live migrations https://review.opendev.org/c/openstack/nova/+/978121 | 18:14 |
| opendevreview | Sebastian Krott proposed openstack/nova master: network: Add host filtering to `cleanup_instance_network_on_host` https://review.opendev.org/c/openstack/nova/+/978122 | 18:14 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: fixups for live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/976316 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 18:19 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: fixups for live migration of `host` secret security https://review.opendev.org/c/openstack/nova/+/976316 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 18:21 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: bump service version to enable live migration https://review.opendev.org/c/openstack/nova/+/975724 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: support live migration of `deployment` secret security https://review.opendev.org/c/openstack/nova/+/925771 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: test live migration between hosts with different security https://review.opendev.org/c/openstack/nova/+/952629 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: add late check for supported TPM secret security https://review.opendev.org/c/openstack/nova/+/956975 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: TPM: enable conversion of secret security modes via resize https://review.opendev.org/c/openstack/nova/+/962052 | 18:24 |
| opendevreview | melanie witt proposed openstack/nova master: DNM vtpm tempest https://review.opendev.org/c/openstack/nova/+/957477 | 18:24 |
| melwitt | bauzas, dansmith: fyi I had to manually rebase and change service version 71 => 72 due to merge conflict in objects/service.py after https://review.opendev.org/c/openstack/nova/+/975588 merged | 18:27 |
| dansmith | ack | 18:28 |
| gmaan | melwitt: ah, sorry for that, I did not realise that vtpm also bumping service version | 18:30 |
| melwitt | not your fault gmaan :) | 18:31 |
| stephenfin | sean-k-mooney: gmaan: I can't rebase my series because that one in the gate is based off an old master. I'll have to do so once it lands (or rebase everything if it fails the gate) | 19:22 |
| gmaan | stephenfin: if they are not conflict on files then it should work as zuul will pick the master and merge the things while testing. | 19:28 |
| gmaan | it was same for eventlet and grafeul shutdown series, I rebased gs one on eventlet which did not have the latest master | 19:29 |
| gmaan | try, I think that should work | 19:29 |
| stephenfin | gmaan: unfortunately there's conflicts on files due to missing openapi patches :( | 19:30 |
| gmaan | stephenfin: I mean this one does not need openapi things right? https://review.opendev.org/c/openstack/nova/+/958864 | 19:32 |
| stephenfin | good point. I was only thinking of stacking the flavor one on top | 19:32 |
| stephenfin | ...though if I stack that one and it goes into the gate, I'd have to wait for that to merge before I can stack the flavor one 😅 | 19:33 |
| gmaan | yeah that one need, but at least can get os-volumes_boot in | 19:33 |
| gmaan | ohk | 19:33 |
| stephenfin | and the flavor one is more important (we want it for gopherclouds and openstack-resource-controller) | 19:33 |
| sean-k-mooney | yep the flavor one is more imporant | 19:34 |
| sean-k-mooney | and the follow up clean up patches | 19:34 |
| gmaan | it seems async vol is a bout to merge if nova-next goes fine, <1 min remaining | 19:34 |
| stephenfin | it's okay though it's about to merge https://zuul.opendev.org/t/openstack/status | 19:34 |
| stephenfin | gmaan: jinx, you owe me a coke | 19:34 |
| gmaan | yeah | 19:34 |
| stephenfin | :) | 19:34 |
| stephenfin | okay that makes my life easier | 19:35 |
| opendevreview | Merged openstack/nova master: Attaching a volume returns HTTP 202 https://review.opendev.org/c/openstack/nova/+/971068 | 20:04 |
| gmaan | stephenfin: you need to remove rxtx_factor from sort key also https://review.opendev.org/c/openstack/nova/+/958749 | 20:06 |
| stephenfin | ack | 20:07 |
| gmaan | a few doc comment, I think you are checking those while doping microvesion number change | 20:08 |
| gmaan | I am on 958856, will be finishing soon | 20:08 |
| gmaan | stephenfin: done | 20:18 |
| opendevreview | Merged openstack/nova master: api: Remove errant field https://review.opendev.org/c/openstack/nova/+/976765 | 20:19 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add ability to filter flavors by name https://review.opendev.org/c/openstack/nova/+/958748 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.102 https://review.opendev.org/c/openstack/nova/+/978002 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 20:27 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 20:27 |
| stephenfin | gmaan: Should be good. Just running through unit/pep8 tests now in case I missed something | 20:27 |
| gmaan | ack | 20:28 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.102 https://review.opendev.org/c/openstack/nova/+/978002 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 20:34 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 20:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 20:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 20:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 20:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 20:46 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 21:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 21:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 21:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 21:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 21:16 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 21:17 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 21:17 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 21:17 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 21:17 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 21:17 |
| stephenfin | gmaan: Okay, I believe all unit tests and pep8 tests should pass now. I had to update some tests to remove use of os-volumes_boot since it's now deprecated | 21:18 |
| stephenfin | I'm running functional tests but those take _forever_ | 21:18 |
| gmaan | stephenfin: ack, I am going for lunch, will check after that | 21:19 |
| stephenfin | nw. I also have to include https://review.opendev.org/c/openstack/nova/+/958863/ before the remove os-volumes_boot since I rely on the renamed methods in that patch. It's trivial enough, thankfully, and the other test-related patches are shoved to the end | 21:28 |
| opendevreview | Stephen Finucane proposed openstack/nova-specs master: Update remove-os-volumes_boot-api to reflect changes https://review.opendev.org/c/openstack/nova-specs/+/978144 | 21:30 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove dead fields from flavors response https://review.opendev.org/c/openstack/nova/+/958749 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Restrict additional query string arguments https://review.opendev.org/c/openstack/nova/+/958750 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Update REST API version history for 2.102 https://review.opendev.org/c/openstack/nova/+/978002 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Remove unnecessary action method prefix https://review.opendev.org/c/openstack/nova/+/958863 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Deprecate os-volumes_boot API https://review.opendev.org/c/openstack/nova/+/958864 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Fix typo https://review.opendev.org/c/openstack/nova/+/958855 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: api: Add runtime check for query additionalProperties https://review.opendev.org/c/openstack/nova/+/958856 | 21:39 |
| opendevreview | Stephen Finucane proposed openstack/nova master: tests: Add missing test coverage https://review.opendev.org/c/openstack/nova/+/958857 | 21:39 |
| stephenfin | one failing functional test :( | 21:39 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!