| *** ykarel__ is now known as ykarel | 03:20 | |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add conf option for live migration monitor interval https://review.opendev.org/c/openstack/nova/+/937223 | 03:53 |
|---|---|---|
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add conf option for live migration monitor interval https://review.opendev.org/c/openstack/nova/+/937223 | 03:57 |
| opendevreview | Shalini Srivastava proposed openstack/nova stable/2025.2: Filter invalid kwargs in volume_api.create to prevent TypeError https://review.opendev.org/c/openstack/nova/+/992849 | 06:50 |
| opendevreview | Shalini Srivastava proposed openstack/nova stable/2025.2: Filter invalid kwargs in volume_api.create to prevent TypeError https://review.opendev.org/c/openstack/nova/+/992849 | 07:38 |
| lajoskatona | sean-k-mooney, sean-k-mooney[m]: Hi, for the bug https://bugs.launchpad.net/nova/+bug/1854844 (libvirt: tx/rx queue length and max queues are not updated on live migration) | 07:58 |
| lajoskatona | sean-k-mooney, sean-k-mooney[m]: I pushed a reproducer: https://review.opendev.org/c/openstack/nova/+/991772 as a first step | 07:58 |
| lajoskatona | I plan to push patch on top of it (I hope this week, but who knows....) | 07:59 |
| sean-k-mooney[m] | lajoskatona: its technically not a bug | 08:04 |
| sean-k-mooney[m] | or rather it was a known issue with using config optins to contol it. | 08:05 |
| sean-k-mooney[m] | also in older version of qemu you could not change it during live migraton | 08:05 |
| sean-k-mooney[m] | the same way you cant always change the mtu | 08:06 |
| sean-k-mooney[m] | you can update the mtu if the mtu element is already but adding/removing ti change the vhost-user feature flags form 32 bit format to 64 bit format whic you canoot do during a live migration | 08:07 |
| sean-k-mooney[m] | lajoskatona: with all that said ya that is someitng i wold liek to fix if tis somethign we can fix today | 08:09 |
| sean-k-mooney[m] | the fix requires use to pass the queue lenghts back from the dest to the source | 08:09 |
| sean-k-mooney[m] | which requires adding new fileds to the live migration data object or some other hacks | 08:10 |
| sean-k-mooney[m] | thanks for creating the repoducer | 08:10 |
| sean-k-mooney[m] | do you plan on creating a fix? | 08:10 |
| sean-k-mooney[m] | lajoskatona: just to be clear changign the tx/rx quee lenaght is changing the emulated hardware to report a diffent quene lenght which is not somehting real hardware would do. today what happens is you live migrate with the old value and they update the next time you reboot. the nuber of ques is also not really somethign that should change as the number fo tx/rx queue on a real nic wont magicly change at runtime like that | 08:15 |
| sean-k-mooney[m] | either. | 08:15 |
| sean-k-mooney[m] | so ideally we would schdule to a host that supprot hte same number and lenght of queues as the real fix | 08:15 |
| sean-k-mooney[m] | rather then adjusgting the geust hardware live | 08:16 |
| sean-k-mooney[m] | lajoskatona: assuming the plan is not to add the number of queues and there lenght if not alreay in the xml like we did for mtu that would be a good firsst step. | 08:25 |
| sean-k-mooney[m] | eventually we should also schdule on this in some way but the first step would at least help with the upgrade impact | 08:26 |
| lajoskatona | sean-k-mooney[m]: yes I plan to push a fix also, thanks for the details, I consider them before pushing anything | 08:26 |
| sean-k-mooney[m] | we also dont want to remove them from the xml if tis already there | 08:26 |
| sean-k-mooney[m] | no worrise im glad some one has had time to actully look at fixing it | 08:26 |
| sean-k-mooney[m] | i treid to explain in the bug that i did carea bout fixing it but just didnt have the time to do it | 08:27 |
| sean-k-mooney[m] | so im happy to review | 08:27 |
| sean-k-mooney[m] | ill also admit i forgot this was still a bug | 08:28 |
| opendevreview | Ashish Gupta proposed openstack/nova master: [DNM][Experimental] tests: Use per-database write locks instead of global lock https://review.opendev.org/c/openstack/nova/+/992862 | 08:45 |
| cw0306-lee[m] | Hi, gibi! I added comment on review.opendev.org/c/openstack/nova-specs/+/991636 | 09:25 |
| cw0306-lee[m] | Could you please check it? | 09:25 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Change nova-alt-configurations job https://review.opendev.org/c/openstack/nova/+/983179 | 09:25 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Restore 'fork' start method for daemon mode on Python 3.14 https://review.opendev.org/c/openstack/nova/+/987815 | 09:25 |
| opendevreview | Kamil Sambor proposed openstack/nova master: [dnm] testing python 3.14 with restored fork https://review.opendev.org/c/openstack/nova/+/987821 | 09:26 |
| cw0306-lee[m] | * Hi, | 09:26 |
| cw0306-lee[m] | @_oftc_gibi:matrix.org! I added comment on https://review.opendev.org/c/openstack/nova-specs/+/991636 Could you please check it? | 09:26 |
| sean-k-mooney | how do we feel about https://review.opendev.org/c/openstack/nova-specs/+/471815, we are at spec freeze today and i would really like to finally see that adance | 09:41 |
| sean-k-mooney | the implemtion might need some addtional docs and or test but it exists https://review.opendev.org/c/openstack/nova/+/941227 | 09:42 |
| sean-k-mooney | so to me this is small and worth doing | 09:43 |
| seyeongkim | sean-k-mooney: Hi. I've addressed your comments on https://review.opendev.org/c/openstack/nova/+/963665 and also updated the LP bug with more details on the use case — when you have a moment, could you take another look and let me know if anything else is needed? Thanks! | 10:00 |
| sean-k-mooney | seyeongkim: sure but again this is really a feature nto a bug | 10:05 |
| sean-k-mooney | we have never offcially supproted the usecase your trying to enable | 10:06 |
| opendevreview | Seyeong Kim proposed openstack/nova master: libvirt: Support boot_index for multiple block devices https://review.opendev.org/c/openstack/nova/+/963665 | 10:10 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | 10:16 |
| opendevreview | Konrad Gube proposed openstack/nova-specs master: Propose assisted-volume-extend API https://review.opendev.org/c/openstack/nova-specs/+/949504 | 10:24 |
| seyeongkim | sean-k-mooney: Thanks Sean, and fair point on it being closer to a feature. Could I ask you to take one more detailed look though? My thinking is mostly from the user's side: once someone sets boot_index on a volume, it feels reasonable to expect that device to at least show up to the grub, rather than being silently skipped. Right now Nova accepts the boot_index but the extra disks never get a per-device boot order, so SeaBIOS skips them entire | 10:26 |
| sean-k-mooney | i jsut did i have not -2'd it but i dont think this is approate to treat as a bug | 10:28 |
| sean-k-mooney | seyeongkim: if you removed all the logic related to attch/detach | 10:28 |
| sean-k-mooney | it might eb accpable to set the index staticly via server create | 10:28 |
| sean-k-mooney | that is the only thing the api ahs ever allowed | 10:29 |
| sean-k-mooney | but it was documetned as driver spcric | 10:29 |
| sean-k-mooney | and im not sure this was ever supproted in the libvirt driver | 10:29 |
| sean-k-mooney | i think that was only ever properly suprpoted in xen or one of the other drivers | 10:29 |
| sean-k-mooney | ah found it it was implemt by the hyperv driver | 10:33 |
| sean-k-mooney | https://github.com/openstack/nova/commit/d68c04299aa2c04aea16e881d93076236cc64d7b | 10:34 |
| sean-k-mooney | seyeongkim: so this wa never supprot by libvirt, vmware, xen or powervm | 10:38 |
| seyeongkim | sean-k-mooney: Thanks for the review. Our customer relies on a multiple-disk boot scenario that worked before this SeaBIOS change (https://github.com/coreboot/seabios/commit/2f4d068645c211e309812372cd0ac58c9024e93b), and I haven't been able to find a workaround yet(it turned out SATA is not viable workaround although I mentioned it in review comment). Since libvirt provide options that per-disk boot order in the XML, I thought this Nova patch co | 10:41 |
| sean-k-mooney | sure but nova does nto provide the libvirt api | 10:46 |
| seyeongkim | right thank you so much! | 10:47 |
| sean-k-mooney | you cant assume that jsut ebcause libvirt supprot soemthign that nova supprot it even if it worked by acindent before | 10:47 |
| seyeongkim | agreed | 10:48 |
| cw0306-lee[m] | sean-k-mooney @_oftc_sean-k-mooney:matrix.org: Thank you for comment. I replied to it. | 10:52 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | 13:39 |
| opendevreview | Masanori Ueno proposed openstack/nova master: live-migration: Ensure limits are set before _call_livem_checks_on_host https://review.opendev.org/c/openstack/nova/+/990212 | 14:03 |
| opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | 14:13 |
| opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | 14:13 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2026.1: DNM trigger whitebox https://review.opendev.org/c/openstack/nova/+/992965 | 15:34 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: DNM trigger whitebox https://review.opendev.org/c/openstack/nova/+/992966 | 15:36 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.1: DNM trigger whitebox https://review.opendev.org/c/openstack/nova/+/992967 | 15:38 |
| opendevreview | melanie witt proposed openstack/nova master: libvirt: Add conf option for live migration monitor interval https://review.opendev.org/c/openstack/nova/+/937223 | 15:39 |
| melwitt | gmaan: not urgent but would love to get your brain waves on my question on API samples updates for new microversion https://review.opendev.org/c/openstack/nova/+/990682/comment/9a2359f1_59d3600d/ I thought since this change is added a new req param for PUT /servers/{server_id} we would only need new samples for that API ... no other schema is changing. so do we really need to push a bunch more API samples for seemingly no reason? | 18:41 |
| gmaan | melwitt: checking | 18:51 |
| dansmith | melwitt: if not, presumably we could remove them from the last two microversions' sample tests and gmaan's own "fix" commit wasn't needed? | 19:06 |
| gmaan | dansmith: melwitt commented, you do not need to have all of them if you just run the update server tests. | 19:08 |
| dansmith | gmaan: so why are they there for like 2.98 which also didn't change rebuild? | 19:08 |
| gmaan | dansmith: they did, response of GET server, update, and rebuild is changed all together | 19:09 |
| melwitt | yeah. happens often with responses bc so many response schema are shared among APIs | 19:09 |
| gmaan | dansmith: api sample tests expect all the APi sample file in same microversion dir if tests are running for that microversion even API is changed or not | 19:09 |
| gmaan | yeah, they are shared from view builder | 19:10 |
| melwitt | req schema should be minimal blast radius | 19:10 |
| dansmith | okay so wait | 19:10 |
| dansmith | "expect all the APi sample file in same microversion dir if tests are running for that microversion even API is changed or not" is what I figured, which is that I didn't change server response but still need the sample | 19:10 |
| gmaan | in unpin az, we should only need req and resp file of PUT server only | 19:10 |
| gmaan | dansmith: because you are running test as part of ServersSampleJson2104Test https://review.opendev.org/c/openstack/nova/+/990682/3/nova/tests/functional/api_sample_tests/test_servers.py#749 | 19:11 |
| gmaan | i mean tests for post, get servers | 19:11 |
| dansmith | ohh, ok I see | 19:11 |
| dansmith | I was going to say.. doesn't work without, but I see your point | 19:11 |
| dansmith | if I change the base | 19:11 |
| gmaan | yeah, we do not need to run any other test than update sevrer in this microversion | 19:12 |
| opendevreview | Merged openstack/nova stable/2025.1: Fix resize to unpermitted flavors https://review.opendev.org/c/openstack/nova/+/988154 | 19:21 |
| *** Unknown123 is now known as Mike-- | 19:22 | |
| melwitt | looks like I have another flaky test test_refresh_nfs_swap_cache_stale 😩 | 22:26 |
| * melwitt looks to fix | 22:27 | |
| dansmith | gmaan: yeah I was just missing that inheriting from that test class is what was making it require them all for me and I figured that since the last few also had all the samples that I needed them | 22:45 |
| dansmith | but makes sense not | 22:45 |
| dansmith | *now | 22:45 |
| opendevreview | melanie witt proposed openstack/nova master: Fix intermittent test_refresh_nfs_swap_cache_stale failure https://review.opendev.org/c/openstack/nova/+/993059 | 23:01 |
| opendevreview | melanie witt proposed openstack/nova master: Fix intermittent test_refresh_nfs_swap_cache_stale failure https://review.opendev.org/c/openstack/nova/+/993059 | 23:05 |
| melwitt | gmaan: ^ another flaky test shame fix above | 23:19 |
| melwitt | huh I noticed nova-graceful-shutdown job is running on that unit test only change, perhaps needs some irrelevant-files in .zuul.yaml? | 23:45 |
| gmaan | melwitt: lgtm, +2 | 23:48 |
| melwitt | thanks gmaan | 23:48 |
| gmaan | melwitt: oh is it? i thought i used the same irrelevant file there like other jobs | 23:48 |
| melwitt | it inherits from devstack-multinode that might be why it doesn't have | 23:49 |
| gmaan | oh, yeah, no irrelevant file in nova side https://github.com/openstack/nova/blob/master/.zuul.yaml#L967 | 23:50 |
| melwitt | that aside, the job is running pretty fast so | 23:50 |
| melwitt | is beating openstack-tox-cover lol | 23:50 |
| melwitt | *it's | 23:50 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!