| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add irrelevant-files for the graceful shutdown jobs https://review.opendev.org/c/openstack/nova/+/993063 | 00:45 |
|---|---|---|
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Add irrelevant-files for the graceful shutdown jobs https://review.opendev.org/c/openstack/nova/+/993063 | 00:50 |
| gmaan | melwitt: ^^ | 00:57 |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/991948 | 03:23 |
| gmaan | not sure why tox cover job takes more than hr to finish | 04:24 |
| opendevreview | Shalini Srivastava proposed openstack/nova stable/2025.2: Filter invalid kwargs in volume_api.create to prevent TypeError https://review.opendev.org/c/openstack/nova/+/992849 | 05:17 |
| opendevreview | Merged openstack/nova master: libvirt: Add conf option for live migration monitor interval https://review.opendev.org/c/openstack/nova/+/937223 | 08:02 |
| sean-k-mooney | sambork: gibi im correct in thinkign we are still defaulting to eventlet mode for the novnc proxy currently right? | 08:41 |
| sean-k-mooney | i know the plan is to update that to threaded but master today is eventlet ya? | 08:42 |
| sambork | yes | 08:42 |
| sean-k-mooney | cool | 08:42 |
| sean-k-mooney | i have ubuntu 26.04 workign in devstack but the 2 failign test are for the novnc proxy | 08:44 |
| sean-k-mooney | https://e5392d8b5c67a9e24e1f-aa881d493e66ac85e397d3a18f294794.ssl.cf5.rackcdn.com/openstack/a154d2bf5825493cb4ae423d6e989638/testr_results.html | 08:44 |
| sean-k-mooney | and its ths stame test failure i got in eventlet mode with uv on python 3.14 | 08:44 |
| sean-k-mooney | so i just need to swap to threaded mode and that will start passing | 08:44 |
| sambork | yeah also there is this patch https://review.opendev.org/c/openstack/nova/+/987815/6 which should fix this issue based on ci run with 3.14 | 08:45 |
| sean-k-mooney | ah the fork one. ya i could add that as a depens on | 08:46 |
| sean-k-mooney | but i think ill just swap to threading mode for now and i can add a followup to drop the override that depends on that | 08:47 |
| sean-k-mooney | ok ill make bot chagnes to my devstack patch and add a followup to use that thanks | 08:48 |
| sambork | cool, np! | 08:49 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | 09:11 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [whitebox]Turn off iothreads feature https://review.opendev.org/c/openstack/nova/+/992966 | 10:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.1: [whitebox]Turn off iothreads feature https://review.opendev.org/c/openstack/nova/+/992967 | 10:08 |
| opendevreview | Karol Klimaszewski proposed openstack/nova-specs master: Spec for SPDK-based nova-provisioned storage backend https://review.opendev.org/c/openstack/nova-specs/+/985676 | 10:16 |
| *** ykarel_ is now known as ykarel | 11:37 | |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | 12:02 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | 12:12 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | 12:12 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | 12:13 |
| opendevreview | Ashish Gupta proposed openstack/placement master: tests: Add connection parameter to Database and PlacementFixture https://review.opendev.org/c/openstack/placement/+/993106 | 12:50 |
| *** jgilaber_ is now known as jgilaber | 12:53 | |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [whitebox]Turn off iothreads feature https://review.opendev.org/c/openstack/nova/+/992966 | 13:05 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [whitebox]Disable vtpm live migration https://review.opendev.org/c/openstack/nova/+/993109 | 13:05 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron floating IPs https://review.opendev.org/c/openstack/nova/+/962604 | 13:09 |
| melwitt | sean-k-mooney: a couple of patches you might be interested, flaky unit test fix https://review.opendev.org/c/openstack/nova/+/993059 and add irrelevant-files for nova-graceful-shutdown job https://review.opendev.org/c/openstack/nova/+/993063 | 13:12 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [stable-only][whitebox]Disable vtpm live migration https://review.opendev.org/c/openstack/nova/+/993109 | 13:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.2: [stable-only][whitebox]Turn off iothreads feature https://review.opendev.org/c/openstack/nova/+/992966 | 13:19 |
| sean-k-mooney | melwitt: i saw them last night but decied post midnight code revew were not ideal :) | 13:19 |
| sean-k-mooney | melwitt: but sure ill take a look | 13:19 |
| melwitt | heh np | 13:19 |
| opendevreview | Balazs Gibizer proposed openstack/nova stable/2025.1: [stable-only][whitebox]Turn off iothreads feature https://review.opendev.org/c/openstack/nova/+/992967 | 13:19 |
| sean-k-mooney | melwitt: i htink gibi filed a bug for one of the flaky tests last week by the way | 13:20 |
| sean-k-mooney | has that one already been fixed | 13:20 |
| melwitt | oh really, let me check | 13:20 |
| sean-k-mooney | it was related to the nfs cching change | 13:20 |
| melwitt | oh yeah it's the same thing oops. let me mark as duplicate I guess | 13:21 |
| sean-k-mooney | https://bugs.launchpad.net/nova/+bug/2155773 | 13:21 |
| sean-k-mooney | but ya either is fine | 13:22 |
| sean-k-mooney | i just notice it when they mentioned it on irc in my morning | 13:22 |
| sean-k-mooney | but i didnt have a change to look at it beofre you and gmaan had already found it | 13:22 |
| melwitt | yeah I wonder, will the gerrit Closes-Bug automation still work if I close the one I opened as a duplicate | 13:23 |
| sean-k-mooney | @mock.patch('nova.virt.libvirt.driver.os.open', return_value=99) | 13:23 |
| sean-k-mooney | ya so this is oen of the resaon i said mocking open is tricky | 13:23 |
| gibi | melwitt: thanks for fixing that flakyness | 13:24 |
| melwitt | sorry for introducing it /o\ | 13:24 |
| gibi | nah, that was all of us reviewing and accepting it ;) | 13:25 |
| sean-k-mooney | melwitt: both of those look fine to me so +w | 13:25 |
| melwitt | thanks ! | 13:26 |
| melwitt | sorting the gate-failure bug tag by most recent, I'm reminded I had proposed this other fix for a ceph memory allocation error https://review.opendev.org/c/openstack/nova/+/969538 | 13:31 |
| opendevreview | Ashish Gupta proposed openstack/nova master: tests: use file-backed Placement SQLite in functional threading https://review.opendev.org/c/openstack/nova/+/992581 | 13:48 |
| opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | 13:48 |
| opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | 13:48 |
| jgilaber | melwitt, Hi! I've been discussing with sean-k-mooney about this patch https://review.opendev.org/c/openstack/nova/+/922140 and would like your inpute as well | 13:48 |
| jgilaber | I'm working on getting the whitebox vgpu tests running with mtty | 13:49 |
| sean-k-mooney | jgilaber: melwitt so basiclly my comemnt was since nova-next is getting quite long, and since nova-vtpm is already using whitebox | 13:50 |
| sean-k-mooney | why not rename that to say nova-whitebox | 13:50 |
| sean-k-mooney | and just add the vgpu/mtty testing to that | 13:50 |
| sean-k-mooney | then we have 1 whitebox job that we can selectivly enabel test in like the recent iothread ones gibi is workign on | 13:51 |
| sean-k-mooney | we have a weakly perodic for whitebox which ahs been pretty stabel so i think we could effectily promote it to check and or remove it rom the perodic line too | 13:52 |
| melwitt | yeah I think that sounds reasonable | 13:52 |
| melwitt | nova-vtpm is a good candidate for rename + expand since it's very small currently | 13:53 |
| sean-k-mooney | jgilaber: out of interst did the boot issues go away when you swap form the 64mb flavor to the standard sized ones? | 13:53 |
| sean-k-mooney | melwitt: i have not had time to look but i also wonder what test in nova-next shoudl be in say the integrated comptue jobs or others | 13:54 |
| sean-k-mooney | melwitt: i.e. is there any clean up on the options or thigns that are now default that are coverd elsewhere | 13:54 |
| jgilaber | sean-k-mooney, the ssh seems to work fine after doubling the memory | 13:55 |
| melwitt | sean-k-mooney: yeah, it's likely time for an audit there | 13:55 |
| sean-k-mooney | i noticed it average runtim was over 2.5 hours | 13:55 |
| sean-k-mooney | most of the other are 1-2 | 13:55 |
| sean-k-mooney | so if we could get it below 2 that would be nice | 13:55 |
| sean-k-mooney | given zuul reports only after the slowest job | 13:56 |
| * melwitt nods | 13:57 | |
| opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | 14:14 |
| opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | 14:14 |
| dansmith | melwitt: I had opened gmaan's comment when he made it and didn't see yours about the update tests, so this moves that down ^ | 14:15 |
| dansmith | as noted it's a bit annoying that they're named that because I had missed them in my grepping of the file but alas | 14:15 |
| opendevreview | Joan Gilabert proposed openstack/nova master: move compile earlier https://review.opendev.org/c/openstack/nova/+/950516 | 14:19 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty/mdpy support for testing fake mdevs https://review.opendev.org/c/openstack/nova/+/898100 | 14:19 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | 14:19 |
| melwitt | dansmith: oh yeah I didn't notice it at first either and then was like wait a minute ... cool | 14:21 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Add mtty support to nova-next https://review.opendev.org/c/openstack/nova/+/922140 | 14:47 |
| opendevreview | Konrad Gube proposed openstack/nova-specs master: Propose assisted-volume-extend API https://review.opendev.org/c/openstack/nova-specs/+/949504 | 14:53 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Rename vtpm job and add mtty support for vpgu test https://review.opendev.org/c/openstack/nova/+/922140 | 15:17 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron Ports https://review.opendev.org/c/openstack/nova/+/969298 | 15:24 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron security-groups https://review.opendev.org/c/openstack/nova/+/981141 | 15:25 |
| opendevreview | Joan Gilabert proposed openstack/nova master: Rename vtpm job and add mtty support for vpgu test https://review.opendev.org/c/openstack/nova/+/922140 | 15:44 |
| opendevreview | melanie witt proposed openstack/nova master: Fix intermittent test_refresh_nfs_swap_cache_stale failure https://review.opendev.org/c/openstack/nova/+/993059 | 15:49 |
| sean-k-mooney | sambork: so just enabling threaded mode didnt fix the novnc test on 3.14 with ubuntu 26.04 but https://review.opendev.org/c/openstack/nova/+/987815 did | 15:54 |
| sean-k-mooney | so restoring fork seams to work | 15:54 |
| sean-k-mooney | with threaded mode it fixed 1 of the these but the other got the token expired thing you were seeing on ubuntu 24.04 | 15:55 |
| sean-k-mooney | so for now i think doing multiprocessing.set_start_method('fork', force=True) uncondtionaly regarless fo eventlet or threaidng is the right move | 15:55 |
| sean-k-mooney | until we fiture out how to make novnc without that in general | 15:56 |
| melwitt | sean-k-mooney: had to change approach on ^ due to it still failing bc the scoping of the mock did not actually help bc they apparently all resolve to the same place in the end | 16:00 |
| sean-k-mooney | yes they do | 16:00 |
| melwitt | I'll be rechecking it some times | 16:00 |
| sean-k-mooney | did you swap to useign mock_open | 16:00 |
| melwitt | no, used list.count() to assert the specified fd was called close with once. a claude idea that _seems_ ok afaict | 16:01 |
| sean-k-mooney | yep just saw | 16:01 |
| melwitt | to just ignore the rest. yeah | 16:01 |
| sean-k-mooney | ill pull that patch locally and run it in a loop on one of my systems for like 30 mins | 16:02 |
| melwitt | the shame deepens | 16:02 |
| melwitt | I'll run a loop | 16:03 |
| sean-k-mooney | --until-failure | 16:03 |
| melwitt | although I guess I need to run all tests that's key to the issue | 16:03 |
| sean-k-mooney | ill let it run on my mac mini for a while that really fast at this | 16:03 |
| sean-k-mooney | yep but i have like 3 systems taht can do that pretty quickly | 16:04 |
| melwitt | :) sean-k-mooney's data center | 16:04 |
| melwitt | I'm lucky it failed in the gate. this sucks haha | 16:05 |
| sean-k-mooney | my home sever may be 10+ years old but if you trho 48 cores at nova unit tests it still flies | 16:05 |
| melwitt | 48 o_O | 16:06 |
| sean-k-mooney | my m4 base spec mac mini almost but not quite catchs my server | 16:06 |
| opendevreview | Merged openstack/nova master: Add irrelevant-files for the graceful shutdown jobs https://review.opendev.org/c/openstack/nova/+/993063 | 16:06 |
| melwitt | my 10+ year old home server only has 12 and it finally got too slow | 16:06 |
| sean-k-mooney | techinaly it 2 14 core cpus so 24 cores and 48 threads | 16:07 |
| sean-k-mooney | https://paste.opendev.org/show/bzdwOUsGPvkQPl8HU6Rz/ | 16:08 |
| melwitt | wow | 16:09 |
| sean-k-mooney | oh i was wrong it 2 12 cores | 16:09 |
| sean-k-mooney | but that still 24 cors and 48 threads im just bad at math | 16:10 |
| opendevreview | melanie witt proposed openstack/nova master: Fix cover env HTML testr results missing unit tests https://review.opendev.org/c/openstack/nova/+/993151 | 16:28 |
| sean-k-mooney | hum so thinkign abou tthis a bit | 16:28 |
| sean-k-mooney | your sill mockign all calls to open clsoe and unlink | 16:29 |
| sean-k-mooney | which we need to do | 16:30 |
| sean-k-mooney | but i one der if we shoudl make the call to open and unlink more robust as well | 16:31 |
| melwitt | what do you have in mind? | 16:32 |
| sean-k-mooney | on the ohter hand i have doen over 20 complet runs locally without any issue | 16:32 |
| sean-k-mooney | removing the once assert_called_once_with | 16:32 |
| sean-k-mooney | and juse using assert_called_with | 16:32 |
| melwitt | yeah. I think the specific asserts are pretty much avoiding issues but maybe the mock_open.assert_called_once_with('/swap', os.O_CREAT | os.O_EXCL | os.O_WRONLY) could technically run into trouble somehow | 16:33 |
| sean-k-mooney | well all 3 could use assert_called_with without really losing much in terms of coverage | 16:33 |
| melwitt | true | 16:34 |
| sean-k-mooney | i know normally we like to assert the call count as well but in this case i dont know if it get us much | 16:35 |
| melwitt | yeah, I hear ya | 16:35 |
| sean-k-mooney | if ci say no again we can try that | 16:35 |
| sean-k-mooney | if it has not failed locally by the tim it report back i think im ok to leave it as is and proceed | 16:35 |
| melwitt | yeah, same. I have a loop going too and if it's also still going then extra good haha | 16:36 |
| melwitt | --until-failure is nice, I forgot about that | 16:36 |
| sean-k-mooney | this is basiclly all i use if for but ya i think gibi first told me about it many moons ago | 16:38 |
| opendevreview | Merged openstack/os-vif master: Make ``PyPyroute2._lookup_interface`` private https://review.opendev.org/c/openstack/os-vif/+/991292 | 16:41 |
| opendevreview | Balazs Gibizer proposed openstack/nova master: Avoid stacktrace at CLI exit https://review.opendev.org/c/openstack/nova/+/993153 | 16:46 |
| gmaan | dansmith: so you want to inherit it from ServersUpdateSampleJsonTest instead of ServersSampleBase, same way other update serve rmicroversion tests did https://review.opendev.org/c/openstack/nova/+/990682/comment/7a022078_05092941/ | 16:52 |
| gmaan | I also missed to check those update test | 16:53 |
| gmaan | that way, you do not need to create the GET server samples in new microvesion dir | 16:53 |
| dansmith | gmaan: ah meant to | 17:02 |
| dansmith | I thought that still required the get samples though which is why I left them in there, | 17:02 |
| dansmith | but perhaps I missed an editor save or something, saw it still requiring the get samples, put those back, and then never committed the save | 17:03 |
| gmaan | ohk, this file is getting huge and difficult to read. I think I should split it. | 17:05 |
| dansmith | yeah, it is for sure | 17:06 |
| opendevreview | Dan Smith proposed openstack/nova master: Add unpin AZ functionality https://review.opendev.org/c/openstack/nova/+/990682 | 17:09 |
| opendevreview | Dan Smith proposed openstack/nova master: Doc changes for unpin-az https://review.opendev.org/c/openstack/nova/+/992469 | 17:09 |
| dansmith | okay sorry about that.. I had a successful run in my terminal buffer from when I removed everything but the update samples | 17:09 |
| dansmith | then when I was rebasing to apply the change to the first commit I must have lost the inheritance part and then running made me add the get/list things back in so I thought I had stale samples on disk last time or something | 17:10 |
| gmaan | k | 17:11 |
| dansmith | trying to get claude to "help" with this stuff is maybe not the best plan past initial generation.. like having a pair programmer messing with things on disk while you're trying to clean up :) | 17:11 |
| gmaan | yeah, i think you should change the tag also now as you updated it manually https://review.opendev.org/c/openstack/nova/+/990682/comment/9a9abe22_4f0d2b93/ | 17:12 |
| dansmith | gmaan: meh | 17:13 |
| dansmith | it's still mostly generated and I think the tag is still okay | 17:13 |
| dansmith | Generated-By: claude, Fixed-By: human meat bag | 17:13 |
| melwitt | claude has been betraying me a lot lately | 17:14 |
| dansmith | same | 17:14 |
| dansmith | there's betrayal and there's also the aspect of just being a third thing competing for context... you have on-disk state, you have in-git state, you have the current state of your editor, and then whatever claude is doing | 17:15 |
| melwitt | in my commit message tag I also include the claude code version bc I think it's interesting and it's been updated/upgraded at least twice since I stated this morning | 17:15 |
| melwitt | *started | 17:15 |
| melwitt | so I'm like 🙏 they are fixing things | 17:16 |
| gmaan | it is difficult to say if Generated-By is still ok when we modified the generated code but does not matter much anyways | 17:16 |
| melwitt | Clauded-By | 17:16 |
| sean-k-mooney | well i nomrally update to assisted-by once i have reworked some | 17:18 |
| sean-k-mooney | but generate by does not have to mean entrilly llm output | 17:18 |
| melwitt | I never use Generated-By, problem solved | 17:18 |
| melwitt | #efficiency | 17:19 |
| sean-k-mooney | ya for many things is v 2 or 3 before i push for review the first time anyway | 17:19 |
| sean-k-mooney | as an aside how ould folk feel about add a funtional py 3.14 job, myign the unit test job voting and maybe moving the coverage job to 3.14 as well | 17:22 |
| sean-k-mooney | the reason i ask is openstack-tox-py314 has been passing stablty for a good few weeks | 17:23 |
| sean-k-mooney | and if the funciotnal job also passes we coudl mvoe coverge to 3.14 | 17:23 |
| sean-k-mooney | and look into the alternitve backend that stephen mentioned that speed it up | 17:23 |
| melwitt | on coverage, I asked claude about it again today and it said tl;dr that you can only get the speedup without eventlet | 17:24 |
| melwitt | which I guess we can't do bc coverage runs functional now too | 17:25 |
| melwitt | "There it is — concurrency = ["eventlet"] in pyproject.toml forces coverage.py to use sys.settrace instead of sys.monitoring, even on Python 3.12+. That's likely the biggest performance hit." | 17:25 |
| sean-k-mooney | hum ok well we are getting closer on functionla coverage in threading mode | 17:26 |
| melwitt | *we can't switch coverage to native threading bc we don't have the func tests sorted out yet | 17:26 |
| sean-k-mooney | so maybe we can just run it in threading mode in a bit | 17:26 |
| melwitt | yeah | 17:26 |
| * melwitt needs to look at the func test stuff again | 17:27 | |
| sean-k-mooney | i might put up a patch thetn jsut for makeing the py314 unit test voting and addign a non voting functionl 3.14 job to see how that goes | 17:28 |
| melwitt | I had tried a patch to help with that and then lots of unrelated stuff happened and I dropped the ball | 17:28 |
| melwitt | gmaan: fyi I noticed you got some questions on the graceful shutdown func tests https://review.opendev.org/c/openstack/nova/+/991743 so I cc'ed myself when you have got a chance to reply | 17:47 |
| melwitt | sean-k-mooney: I just approved https://review.opendev.org/c/openstack/nova/+/993109 but then I wondered, shouldn't that change go in whitebox not nova? | 17:49 |
| sean-k-mooney | whitebox is not branched | 17:50 |
| sean-k-mooney | so normally in whitebox we do the opisce of tempet | 17:50 |
| sean-k-mooney | we disabel new tests and make them opt in | 17:50 |
| melwitt | ohhh ok | 17:50 |
| sean-k-mooney | tempest enables them on master and then uses stable patchs | 17:51 |
| sean-k-mooney | so gman wanted to go the tempest way which is fine | 17:51 |
| sean-k-mooney | we did it the other way in whitebox historically because our downstream used ot direcly use master | 17:51 |
| sean-k-mooney | so we coudl not assume the only user of whitebox was our first praty zuul | 17:51 |
| sean-k-mooney | we also need to fix or disble the hugepage tests to get the stable branches green again it seams | 17:53 |
| melwitt | yeah | 17:53 |
| sean-k-mooney | im not entirly sure why | 17:55 |
| sean-k-mooney | because i dont see those test runing on master | 17:55 |
| sean-k-mooney | this is not a firday after noone problem | 17:56 |
| sean-k-mooney | we can fix the rest later | 17:56 |
| melwitt | yeah I am a bit lost tbh :) | 17:57 |
| sean-k-mooney | we were not runing stable jobs on the plugin repo | 17:57 |
| melwitt | you're saying from the periodic whitebox job you don't see hugepages test running | 17:58 |
| sean-k-mooney | so we didnt notice when we broke stable | 17:58 |
| sean-k-mooney | there is a seprate whitebox-devstack-multinode-hugepages job | 17:58 |
| sean-k-mooney | https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_29c/openstack/29c8adb8349b437bb53993094287774d/testr_results.html | 17:59 |
| sean-k-mooney | that was https://zuul.opendev.org/t/openstack/build/29c8adb8349b437bb53993094287774d | 17:59 |
| melwitt | gibi: if you dare https://review.opendev.org/c/openstack/nova/+/993059 (had to change fix due to first fix not working). sean and I have been running all unit tests in a loop for > 1 hour and no fails yet so we are hoping this is stable now | 17:59 |
| melwitt | oh, right | 17:59 |
| sean-k-mooney | but that is not the hugepages job | 18:00 |
| sean-k-mooney | so im not entirly sure why those ran | 18:00 |
| sean-k-mooney | given it has tempest_exclude_regex:"^whitebox_tempest_plugin\.api\.compute\.test_hugepages" | 18:00 |
| melwitt | _magic_ | 18:00 |
| sean-k-mooney | oh | 18:00 |
| sean-k-mooney | ok no so gibie broke it in the previosu platch | 18:01 |
| sean-k-mooney | when he added tempest_exclude_regex: (test_vtpm_live_migration_secret_security_host) | 18:01 |
| sean-k-mooney | it overrote the hugepage exclude | 18:01 |
| sean-k-mooney | so we need to exlude both | 18:01 |
| melwitt | wait what | 18:01 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/993109/2/.zuul.yaml | 18:01 |
| melwitt | do we need to pull the patch from the gate | 18:01 |
| sean-k-mooney | just did | 18:01 |
| melwitt | ok good thanks | 18:02 |
| sean-k-mooney | and its not any more broken then it was before | 18:02 |
| sean-k-mooney | ill leave a comment explaining now | 18:02 |
| melwitt | yeah. I didn't know nowadays what's the easiest way to pull a patch. I had thought in the past -W didn't work but that was probably ages ago | 18:02 |
| sean-k-mooney | so -w wont pull it | 18:04 |
| sean-k-mooney | but it will prevent zuul form submitting it | 18:04 |
| sean-k-mooney | the easisly way to pull it as in stop the job | 18:05 |
| sean-k-mooney | is to rebase | 18:05 |
| melwitt | ah gotcha | 18:05 |
| sean-k-mooney | oh looks like they impoved it in zuul | 18:06 |
| sean-k-mooney | it -2'd with "This change is unable to merge due to a missing merge requirement." | 18:06 |
| sean-k-mooney | the same as if a depend on failes or goes into merge conflict | 18:06 |
| gmaan | melwitt: yeah, i need to fix those first. thanks | 18:09 |
| melwitt | sean-k-mooney: very cool | 18:09 |
| sean-k-mooney | gmaan: fyi https://review.opendev.org/c/openstack/whitebox-tempest-plugin/+/992998/comment/1c2bae72_2cb0d3e5/ the whitebox jobs need nested virt and multinode nodeset | 18:10 |
| sean-k-mooney | so that why that is failing | 18:10 |
| gmaan | sean-k-mooney: thanks, did not get chance to check if those are passing, fixed. | 18:13 |
| sean-k-mooney | actully | 18:17 |
| sean-k-mooney | gmaan: so to melwitt's point | 18:17 |
| sean-k-mooney | for thos to pass we need the fixes that gibi is making in nova | 18:17 |
| sean-k-mooney | so instead fo doing that | 18:17 |
| sean-k-mooney | why dont we fix those in whitebox in the new jobs | 18:17 |
| sean-k-mooney | and then change the job we are running on stable | 18:17 |
| gmaan | you mean separate jobs to run on stable | 18:18 |
| sean-k-mooney | since they are perodic we dont care about the overried checkout | 18:18 |
| sean-k-mooney | ya so the master jobs your addign on master | 18:19 |
| gmaan | we can, I think that will be easy to maintain things on one side (whitebox plugin) | 18:19 |
| gmaan | let me do it | 18:19 |
| sean-k-mooney | right we can update the exclude as we add things | 18:19 |
| gmaan | neutron plugin does the same and it is helpful | 18:19 |
| sean-k-mooney | ack ya so i think that the better patten then | 18:19 |
| sean-k-mooney | nova will still need a stabel patch per branch but only to use the relevent job | 18:20 |
| sean-k-mooney | ok im really going to call it a day as i feel myself stuggaleing to thing that ture o/ | 18:20 |
| gmaan | o/ no worry, I will propose those. | 18:22 |
| melwitt | sean-k-mooney: have a nice weekend o/ | 18:22 |
| sean-k-mooney | you too o/ | 18:23 |
| opendevreview | Ghanshyam Maan proposed openstack/nova stable/2026.1: DNM: testing whitebox stable branch jobs https://review.opendev.org/c/openstack/nova/+/993173 | 19:37 |
| opendevreview | Ghanshyam Maan proposed openstack/nova stable/2025.2: DNM: testing whitebox stable branch jobs https://review.opendev.org/c/openstack/nova/+/993174 | 19:37 |
| opendevreview | Ghanshyam Maan proposed openstack/nova stable/2025.1: DNM: testing whitebox stable branch jobs https://review.opendev.org/c/openstack/nova/+/993175 | 19:37 |
| melwitt | gmaan: this release notes static page change is ready for your re-review https://review.opendev.org/c/openstack/nova/+/989211 you were previously +2 but your vote got dropped by a new PS | 20:08 |
| gmaan | melwitt: thanks, done | 20:10 |
| opendevreview | Merged openstack/nova master: Use static pages for eol release release notes https://review.opendev.org/c/openstack/nova/+/989210 | 20:10 |
| opendevreview | Merged openstack/nova master: Use static pages for eom release release notes https://review.opendev.org/c/openstack/nova/+/989211 | 20:27 |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/991948 | 20:34 |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/991948 | 20:53 |
| opendevreview | Brian Haley proposed openstack/nova master: Change neutron API calls to use project_id https://review.opendev.org/c/openstack/nova/+/991948 | 22:02 |
| opendevreview | Stephen Finucane proposed openstack/nova master: docs: Speed up release notes builds https://review.opendev.org/c/openstack/nova/+/989212 | 22:33 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!