| opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | 00:35 |
|---|---|---|
| opendevreview | Takashi Kajinami proposed openstack/nova master: wip: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 00:35 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 00:35 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: wip: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 00:36 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 00:36 |
| opendevreview | Goutham Pacha Ravi proposed openstack/nova master: Add live migration support for virtiofs shares https://review.opendev.org/c/openstack/nova/+/1008566 | 05:24 |
| *** amorin_ is now known as amorin | 07:45 | |
| opendevreview | Balazs Gibizer proposed openstack/nova master: [test]Ensure shutdown thread is waited on https://review.opendev.org/c/openstack/nova/+/1003245 | 08:33 |
| *** bauzas67 is now known as bauzas | 08:38 | |
| opendevreview | ribaudr proposed openstack/nova master: Add regression test for bug 2162835 https://review.opendev.org/c/openstack/nova/+/999977 | 09:43 |
| opendevreview | ribaudr proposed openstack/nova master: Reproduce part of bug/2166474 https://review.opendev.org/c/openstack/nova/+/1007750 | 09:43 |
| opendevreview | ribaudr proposed openstack/nova master: Fix evacuate race conditions with periodic task and task_state https://review.opendev.org/c/openstack/nova/+/999978 | 09:43 |
| opendevreview | HyungJoon Kim proposed openstack/nova-specs master: Add spec for booting from Cinder backup-based image https://review.opendev.org/c/openstack/nova-specs/+/1009014 | 10:20 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Default native threading for console proxies https://review.opendev.org/c/openstack/nova/+/1009027 | 11:06 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Replace deprecated sqlalchemy.orm.noload https://review.opendev.org/c/openstack/nova/+/1007632 | 11:53 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Replace deprecated sqlalchemy.orm.noload https://review.opendev.org/c/openstack/nova/+/1007632 | 11:54 |
| opendevreview | ribaudr proposed openstack/nova master: Fix swap disk creation skipped on NFS during cold migration https://review.opendev.org/c/openstack/nova/+/1006036 | 13:07 |
| *** elodille1 is now known as elodilles | 14:23 | |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron networks https://review.opendev.org/c/openstack/nova/+/928022 | 15:10 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | 15:12 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron subnets https://review.opendev.org/c/openstack/nova/+/962190 | 15:12 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | 15:13 |
| opendevreview | Lajos Katona proposed openstack/nova master: Use SDK for Neutron extensions https://review.opendev.org/c/openstack/nova/+/962270 | 15:13 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 15:15 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 15:16 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 15:18 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 15:20 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | 15:22 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 15:22 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 15:22 |
| tkajinam | after 10+ years interacting with gerrit I eventually learned how that "copy" button next to the change title works... | 15:25 |
| tkajinam | idk how many times I copy-pasted the title and link separately ... | 15:25 |
| tkajinam | and manually ... | 15:25 |
| opendevreview | Konrad Gube proposed openstack/nova master: Add assisted volume extend API. https://review.opendev.org/c/openstack/nova/+/1009077 | 15:27 |
| sean-k-mooney | tkajinam: huh ya i have never uesed that | 15:29 |
| sean-k-mooney | i guess that is useful | 15:30 |
| tkajinam | especially when you put the link to etherpad :-) | 15:32 |
| tkajinam | for ptg, review priority list, etc ... | 15:33 |
| melwitt | good to know -- thanks for sharing. fwiw it might be a more recent feature in gerrit and it is not that you missed it for a long time :) | 15:44 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | 15:59 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 15:59 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 15:59 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 16:02 |
| opendevreview | Lajos Katona proposed openstack/nova master: Cfg: document devname reject in [pci]device_spec https://review.opendev.org/c/openstack/nova/+/1009083 | 16:28 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Stop testing missing sev capability in libvirt < 10.0.0 https://review.opendev.org/c/openstack/nova/+/1009084 | 16:31 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | 16:39 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | 16:41 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Create base class for domain capability feature https://review.opendev.org/c/openstack/nova/+/1009086 | 17:52 |
| clif | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/1005118 seems to be failing on nova-tox-py312-threading, but the test failures seem to hinge on nova/utils.py accessing executor._workers, which doesn't seem to exist which this patch doesn't change in any way afaict | 18:08 |
| sean-k-mooney | hum that may be a issue with the version of oslo or rather futureist used on that stable branch | 18:09 |
| clif | have you run into this before? | 18:11 |
| sean-k-mooney | no | 18:11 |
| sean-k-mooney | but i know that eariler in the eventlet removal process we did have some issue like that | 18:12 |
| sean-k-mooney | where the executors ewre not as swapable as they shoudl have been | 18:12 |
| sean-k-mooney | that does nto look liek thsoe failrue are related to your packt really | 18:14 |
| sean-k-mooney | *patch | 18:14 |
| clif | do we need to patch stable/2025.2 to change the version of oslo or futurist? or patch nova/utils.py to not refer to executor._workers? | 18:16 |
| sean-k-mooney | well the larger problem is that code is refering to the greetheadpool executor | 18:18 |
| sean-k-mooney | in the version of the job that does not use eventlet | 18:18 |
| sean-k-mooney | so that is also incorrect | 18:18 |
| clif | the code in nova/utils.py? | 18:19 |
| sean-k-mooney | https://paste.opendev.org/show/bcyOL5SrnQtVCITo8DeV/ | 18:19 |
| sean-k-mooney | that the traceback | 18:19 |
| clif | right | 18:19 |
| clif | you mentioned that the version of oslo or futurist might be an issue | 18:20 |
| sean-k-mooney | so that is invoking cdoe that depens on using the treaded executor but tis callign it on a GreenThreadPoolExecutor | 18:20 |
| sean-k-mooney | maybe but this looks more liek a test confiurtion issue | 18:20 |
| sean-k-mooney | looking at master futureist it also does not provide _workers | 18:21 |
| sean-k-mooney | so i dont think its a regresion | 18:21 |
| clif | so you the the executor object would be a different type that does have _workers if the tests were configured correctly? | 18:21 |
| clif | you think* | 18:21 |
| sean-k-mooney | yes | 18:22 |
| sean-k-mooney | the normal threadpool executor has that value | 18:22 |
| sean-k-mooney | https://github.com/openstack/futurist/blob/master/futurist/_futures.py#L175 | 18:22 |
| sean-k-mooney | and that is what we are expectign to use in that job but we are not for some reason | 18:22 |
| clif | sounds reasonable | 18:22 |
| clif | do you know how to fix the configuration | 18:23 |
| sean-k-mooney | so you are mockign @mock.patch('nova.utils.spawn_on') | 18:23 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/tests/unit/compute/test_compute_mgr.py#518 | 18:23 |
| sean-k-mooney | so im wondering if its related to that in some way | 18:23 |
| sean-k-mooney | althouhg at least in the test that is failing its in a completely unrealted part of the code | 18:25 |
| sean-k-mooney | ah found the bug https://review.opendev.org/c/openstack/nova/+/1005118/1/nova/compute/manager.py#674 | 18:25 |
| clif | that's why I thought this change was indepedent of the failures | 18:25 |
| sean-k-mooney | so you cant hardcode the executor type there | 18:26 |
| clif | But that's what the line above it does? | 18:26 |
| clif | line 671 also hardcodes a GreenThreadPoolExecutor | 18:26 |
| clif | which exists prior to this change | 18:26 |
| sean-k-mooney | yes but we have the power sysnt disbsle i think | 18:27 |
| sean-k-mooney | so i dont think that executor is actully used in the tests | 18:27 |
| sean-k-mooney | in newer verisons fo this patch on master for example | 18:28 |
| sean-k-mooney | you were getting the executor form a util funciton that did the right thing | 18:28 |
| sean-k-mooney | i.e. that checked if it shoudl be using real thread or not | 18:28 |
| sean-k-mooney | in the backport your not doing that so eitehr we need to emulate that logic or backport hte helper funciton | 18:29 |
| sean-k-mooney | this is the same line one release newer https://review.opendev.org/c/openstack/nova/+/1005115/1/nova/compute/manager.py#673 | 18:30 |
| sean-k-mooney | your calling nova.utils.create_executor | 18:30 |
| sean-k-mooney | so you coudl do a minimial backprot of just that one fuction in utils.py adn its assocated tets or backprot that as an addtional patch prior to this one | 18:30 |
| sean-k-mooney | clif: its djust this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L116-L121 | 18:32 |
| clif | ahh I see ok | 18:32 |
| sean-k-mooney | and this https://github.com/openstack/nova/blob/stable/2026.1/nova/utils.py#L1336-L1341 | 18:33 |
| clif | yeah I can handle that | 18:33 |
| sean-k-mooney | that was remvoed durign the hibiscus cycle after the chagne merged on master | 18:33 |
| sean-k-mooney | clif: by the way when you fix this in your backport make sure to update the commit message to note the partical backport of those fucntiosn if you dont do it in a seperate commit | 18:52 |
| clif | sure | 18:53 |
| clif | do you prefer separate? | 18:53 |
| sean-k-mooney | either is fine i would check the orginal commit that added the funciton | 18:53 |
| sean-k-mooney | if that is a clean cherry pick then that is prefered | 18:54 |
| sean-k-mooney | if not its ok ot pull it in just make note of the change id that orginally added them | 18:54 |
| clif | gotcha | 18:54 |
| opendevreview | Merged openstack/nova master: Replace deprecated sqlalchemy.orm.noload https://review.opendev.org/c/openstack/nova/+/1007632 | 19:18 |
| opendevreview | Gabin Lanore proposed openstack/nova master: libvirt: stop the event dispatch loops on cleanup https://review.opendev.org/c/openstack/nova/+/1005022 | 20:15 |
| opendevreview | Adam Harwell proposed openstack/nova master: Stop the service when its start fails https://review.opendev.org/c/openstack/nova/+/1009119 | 20:29 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!