| *** haleyb|out is now known as haleyb | 00:31 | |
| opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after local delete https://review.opendev.org/c/openstack/nova/+/1008334 | 00:35 |
|---|---|---|
| opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce node leak after failed build cleanup https://review.opendev.org/c/openstack/nova/+/1009134 | 00:43 |
| opendevreview | Michael Sherman proposed openstack/nova master: ironic: Reproduce 409 on unprovision during deploy https://review.opendev.org/c/openstack/nova/+/1009135 | 00:45 |
| opendevreview | Ghanshyam Maan proposed openstack/nova master: Stop hanging the test if threadpool executor is stuck in cleanup https://review.opendev.org/c/openstack/nova/+/1006351 | 00:57 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Bump MIN_{LIBVIRT,QEMU} for "Indri" https://review.opendev.org/c/openstack/nova/+/1008847 | 01:47 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: Remove version check for old libvirt/qemu https://review.opendev.org/c/openstack/nova/+/1008862 | 01:48 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Remove vTPM version detection for < 8.6.0 https://review.opendev.org/c/openstack/nova/+/1008867 | 01:48 |
| opendevreview | Takashi Kajinami proposed openstack/nova master: libvirt: Stop testing missing sev capability in libvirt < 10.0.0 https://review.opendev.org/c/openstack/nova/+/1009084 | 01:48 |
| opendevreview | Matěj Mudra proposed openstack/nova master: Add --verbose to nova-manage commands https://review.opendev.org/c/openstack/nova/+/999956 | 07:55 |
| opendevreview | Thibaut Démaret proposed openstack/nova-specs master: Spec for default SSD rotation rate on instance disks https://review.opendev.org/c/openstack/nova-specs/+/979696 | 07:56 |
| opendevreview | Markus Hentsch proposed openstack/nova master: Adapt to Cinder and Glance changes for image encryption https://review.opendev.org/c/openstack/nova/+/926326 | 07:56 |
| -opendevstatus- NOTICE: zuul processing is broken since about 03:00 UTC, investigation is in progress, please be patient | 08:02 | |
| *** tobias-u1 is now known as tobias-urdin | 08:19 | |
| bauzas | doh I just rechecked :( | 08:31 |
| opendevreview | Lucas HENRY proposed openstack/nova master: Extract running a shutdown step with a timeout from Service https://review.opendev.org/c/openstack/nova/+/1009163 | 08:49 |
| opendevreview | Lucas HENRY proposed openstack/nova master: Shut down executors after the RPC servers drain https://review.opendev.org/c/openstack/nova/+/1009164 | 08:49 |
| opendevreview | Lucas HENRY proposed openstack/nova master: compute: shut executors down after the RPC servers drain https://review.opendev.org/c/openstack/nova/+/1009165 | 08:49 |
| opendevreview | Konrad Gube proposed openstack/nova master: Add assisted volume extend API. https://review.opendev.org/c/openstack/nova/+/1009077 | 08:49 |
| *** mikal0 is now known as mikal | 08:57 | |
| opendevreview | ChungWon Lee proposed openstack/placement master: Spec: allow to overcommit for HA https://review.opendev.org/c/openstack/placement/+/1009206 | 11:20 |
| cw0306-lee[m] | Hi! I want to suggest two specs for nova and placement.... (full message at <https://matrix.org/oftc/media/v1/media/download/AW0Zu02QY1E5cI5ajhOGtU7XXnHC8IVcI34z0Y-Os25ypLL9BN18cMKu6OQd45aRNnxkvuRpdB3Q1j33Vx9b7yBCehXjm1ZAAG1hdHJpeC5vcmcvbGJKR3d5b3NHV0hkQ3dTeUd6dU5mZ3pI>) | 11:30 |
| opendevreview | Merged openstack/nova master: Imported Translations from Zanata https://review.opendev.org/c/openstack/nova/+/1007361 | 12:38 |
| opendevreview | Kamil Sambor proposed openstack/nova master: Create an executor wrapper that has task limit per type https://review.opendev.org/c/openstack/nova/+/975924 | 12:45 |
| Uggla | Reminder: upstream triage in ~15mn. (https://meet.google.com/zjr-rxus-hzj) | 15:17 |
| gmaan | gibi_: updated it as per comment, please check https://review.opendev.org/c/openstack/nova/+/1006351 | 15:37 |
| gibi_ | gmaan: thanks, I cannot promise I get to it this week. I have to drop for today and tomorrow I need to use my time to read the cross cell live migration spec, and firday I'm off. But I will get back to it hopefully next week | 15:55 |
| opendevreview | Stephen Finucane proposed openstack/nova master: Remove test for local ServiceAuthTokenWrapper https://review.opendev.org/c/openstack/nova/+/1009297 | 15:57 |
| stephenfin | melwitt: ^ easier than I thought: we can straight up remove it | 15:57 |
| stephenfin | sean-k-mooney: you probably want to look at that also since you reviewed https://review.opendev.org/c/openstack/nova/+/1002540. We need it to unblock the ksa bump in upper-constraints | 15:59 |
| melwitt | ahhh lol ... that was me again too. geesh. ok, well at least that makes the removal straightforward | 15:59 |
| stephenfin | https://i.kym-cdn.com/entries/icons/original/000/037/468/cover5.jpg | 16:00 |
| sean-k-mooney | ah ok that makes sense | 16:01 |
| sean-k-mooney | i guess the way we were mockign did not catch the removal of our local versoin | 16:01 |
| sean-k-mooney | im kind of surperise that this is broken by the new release if im honest | 16:02 |
| sean-k-mooney | did | 16:03 |
| sean-k-mooney | user_auth.get_endpoint_data.assert_called_once_with( | 16:03 |
| sean-k-mooney | mock.sentinel.session) | 16:03 |
| sean-k-mooney | stop passing because we didnt need to call it to fill in the data | 16:03 |
| melwitt | I think it's due to this change https://review.opendev.org/c/openstack/keystoneauth/+/1002219/1/keystoneauth1/service_token.py | 16:05 |
| melwitt | although it seems that was released a while ago | 16:07 |
| sean-k-mooney | mostly likely i jsut dont see how that broke the test | 16:07 |
| sean-k-mooney | the asset behvior we vhae shoudl have been the saem regardess of it was our wrapper or not | 16:08 |
| melwitt | I was thinking the above change added **kwargs to the call which made it no longer match the assert | 16:11 |
| sean-k-mooney | oh no it might be but i think its becasue its now caullign self.user_auth | 16:12 |
| melwitt | but hm yeah the previous one was passing **kwargs too. nevermind | 16:12 |
| sean-k-mooney | so we are creating a mock and passign that as the user aut when we get the service tone auth plugin | 16:13 |
| sean-k-mooney | so i woudl expect our mock to be assigned to self.user_auth | 16:13 |
| sean-k-mooney | and for that call to still cause or test to pass | 16:13 |
| sean-k-mooney | stephenfin: do you have a link to the failure | 16:14 |
| sean-k-mooney | i want to see which assert actully failed | 16:14 |
| stephenfin | https://zuul.opendev.org/t/openstack/build/381a96a08d294adcbb4407e7bef15914 | 16:14 |
| stephenfin | also linked from a comment on the change | 16:14 |
| stephenfin | I didn't put it in the commit message since those links expire after ~30 days | 16:14 |
| sean-k-mooney | oh i see | 16:14 |
| sean-k-mooney | the argument changes | 16:15 |
| sean-k-mooney | so its still being called but with diffenrt kwargs | 16:15 |
| stephenfin | yep | 16:15 |
| stephenfin | but as I've noted in the review, whether it's called or not is immaterial to Nova, at least in the context of a unit test | 16:16 |
| melwitt | sean-k-mooney: ok I think it's from this change rather https://review.opendev.org/c/openstack/keystoneauth/+/1003778/3/keystoneauth1/service_token.py | 16:18 |
| stephenfin | melwitt: beat me to it | 16:18 |
| melwitt | \o/ did one thing right today. eventually. | 16:19 |
| sean-k-mooney | yes i was lookign at the refactorign that stephtn did on top | 16:19 |
| sean-k-mooney | ya so that makes sense | 16:19 |
| sean-k-mooney | i just wanted to narrow down what change broke it as yours shoudl not have | 16:19 |
| melwitt | Mystery Solved ™ | 16:20 |
| sean-k-mooney | so we can delete this or we coud jsut replace called_once_with with called_once | 16:20 |
| sean-k-mooney | i htink the delete | 16:20 |
| sean-k-mooney | is fine | 16:20 |
| melwitt | yeah, ++ diligence | 16:20 |
| sean-k-mooney | as this si really internal behvior of the lib | 16:20 |
| sean-k-mooney | we do care that the endpoing data is there but if nova is the thing catching that in its unit test its already too late | 16:21 |
| opendevreview | Clif Houck proposed openstack/nova stable/2025.2: Parallelize per-node resource updates https://review.opendev.org/c/openstack/nova/+/1005118 | 16:30 |
| shermanm | hey, I wanted to note that I opened a few related issues with the ironic driver, but I was looking for some feedback on how best to approach functional tests for the regression given that there wasn't an existing fixture. I took a shot at it, the first reproducer is here https://review.opendev.org/c/openstack/nova/+/1008334 , and I've been using topic | 16:50 |
| shermanm | `ironic-orphaned-nodes` | 16:50 |
| shermanm | I didn't want to take things out of WIP and start spamming the CI without asking first :) | 16:51 |
| sean-k-mooney | i did start on a basic set of fixture for some limited ironic functionl testing but i think i abandoned them | 16:52 |
| sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/980641/6 | 16:53 |
| sean-k-mooney | shermanm: so im not sure if any of that woudl be useful for you | 16:54 |
| gmaan | gibi_: no worry, i understand | 16:56 |
| tkajinam | can we merge this classifier update ? https://review.opendev.org/c/openstack/nova/+/1007898 | 17:03 |
| tkajinam | I should have covered that in the previous job update... | 17:03 |
| sean-k-mooney | for 3.14 sure | 17:04 |
| sean-k-mooney | we already have tox jobs and if my match merged tempet | 17:04 |
| sean-k-mooney | it will be enabeld by default in many of our tempest jobs shortly if its not alreay | 17:04 |
| tkajinam | at least unit tests already runs on py314 and the job is voting | 17:05 |
| tkajinam | and yeah we may get full functional test coverage once devstack jobs are moved to resolute | 17:05 |
| sean-k-mooney | yep but we have had ubuntu 26.04 testing in devstack for several months now | 17:05 |
| sean-k-mooney | and canonicall ship 2026.1 on python 3.14 as well so you knwo it work in reality | 17:06 |
| sean-k-mooney | so we shoudl declar it as such | 17:06 |
| sean-k-mooney | shermanm: you have made a good start on extingn supprot to ironic based on a quick glance | 17:14 |
| stephenfin | tkajinam: I am hoping to automate those classifier changes soon enough https://review.opendev.org/c/openstack/releases/+/993557 | 17:25 |
| stephenfin | jfyi | 17:25 |
| stephenfin | for now, I've sent that on its way | 17:26 |
| tkajinam | stephenfin, yeah I saw that | 17:34 |
| tkajinam | I was wondering if we can split it out to a separate file somehow to avoid running full CI... though I'm unsure if we can do that really for pyproject.toml | 17:35 |
| tkajinam | it's a bit annoying that just adding a single line without functional impact triggers heavy ci | 17:35 |
| tkajinam | though it might eventually mean that we should drop these classifiers, as you suggested in the past | 17:35 |
| opendevreview | Merged openstack/nova master: Remove test for local ServiceAuthTokenWrapper https://review.opendev.org/c/openstack/nova/+/1009297 | 18:13 |
| dansmith | Uggla: cross-cell migration is scheduled for wednesday but gibi_ says he'll have competition for brainpower.. I think we need (100% of) gibi for those conversations, FYI | 18:15 |
| gmaan | Uggla: added comment in ths bug and mark it invalid for nova and opened for openstack client https://bugs.launchpad.net/python-openstackclient/+bug/2060812 | 18:23 |
| gmaan | dansmith: if you have time, this is ready (stop hanging tests in cleanup of executor shutdown) which we chatted about in IRC a few weeks before https://review.opendev.org/c/openstack/nova/+/1006351 | 18:28 |
| opendevreview | Damian Dąbrowski proposed openstack/nova master: libvirt: refresh frontend QoS on volume extend https://review.opendev.org/c/openstack/nova/+/982733 | 20:28 |
| *** priteau_ is now known as priteau | 21:38 | |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
