openstackgerrit | A change was merged to openstack/taskflow: Make version.py handle pbr not being installed https://review.openstack.org/118192 | 00:28 |
---|---|---|
openstackgerrit | A change was merged to openstack/oslo.db: Use oslo.i18n https://review.openstack.org/117257 | 00:34 |
*** dims has joined #openstack-oslo | 00:47 | |
*** yamahata has quit IRC | 00:55 | |
*** ajo__ has quit IRC | 01:18 | |
*** dims has quit IRC | 01:28 | |
*** stevemar has joined #openstack-oslo | 01:53 | |
*** yamahata has joined #openstack-oslo | 01:53 | |
*** miqui has quit IRC | 01:57 | |
*** alexpilotti has quit IRC | 01:57 | |
*** amotoki has joined #openstack-oslo | 02:00 | |
*** harlowja_at_home has joined #openstack-oslo | 02:09 | |
*** harlowja_at_home has quit IRC | 02:14 | |
*** takedakn has joined #openstack-oslo | 02:18 | |
*** harlowja_at_home has joined #openstack-oslo | 02:46 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Remove the dependency on prettytable https://review.openstack.org/117629 | 02:49 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Add existing types to generated documentation https://review.openstack.org/106930 | 02:50 |
*** harlowja_at_home has quit IRC | 03:01 | |
*** shakamunyi has joined #openstack-oslo | 03:15 | |
*** shakamunyi has quit IRC | 03:20 | |
*** harlowja_at_home has joined #openstack-oslo | 04:30 | |
*** ildikov_ has quit IRC | 04:33 | |
*** harlowja_at_home has quit IRC | 04:43 | |
*** takedakn has quit IRC | 04:53 | |
*** ildikov has joined #openstack-oslo | 05:25 | |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.i18n: Imported Translations from Transifex https://review.openstack.org/116553 | 06:05 |
openstackgerrit | OpenStack Proposal Bot proposed a change to openstack/oslo.db: Imported Translations from Transifex https://review.openstack.org/118258 | 06:05 |
*** k4n0 has joined #openstack-oslo | 06:06 | |
*** flaper87|afk is now known as flaper87 | 06:26 | |
*** YorikSar_ has quit IRC | 06:28 | |
*** ildikov has quit IRC | 06:54 | |
*** openstackgerrit has quit IRC | 07:02 | |
*** ildikov has joined #openstack-oslo | 07:04 | |
*** stevemar has quit IRC | 07:29 | |
*** YorikSar has joined #openstack-oslo | 07:38 | |
YorikSar | dhellmann: Hi. I could add oslo.concurrency to bug 1357582 but I can't change status to triaged and importance level. | 07:39 |
YorikSar | dhellmann: https://bugs.launchpad.net/oslo.concurrency/+bug/1357582 | 07:39 |
*** flaper87 is now known as flaper87|afk | 07:43 | |
*** flaper87|afk is now known as flaper87 | 07:48 | |
*** noelbk has quit IRC | 07:53 | |
*** dims has joined #openstack-oslo | 07:56 | |
*** dims has quit IRC | 08:00 | |
*** morganfainberg is now known as morganfainberg_Z | 08:12 | |
*** pblaho has joined #openstack-oslo | 08:20 | |
*** jaosorior has joined #openstack-oslo | 08:25 | |
*** noelbk has joined #openstack-oslo | 08:29 | |
*** flaper87 is now known as flaper87|afk | 08:37 | |
*** ildikov_ has joined #openstack-oslo | 08:44 | |
*** ildikov has quit IRC | 08:47 | |
*** flaper87|afk is now known as flaper87 | 08:50 | |
*** dtantsur|afk is now known as dtantsur | 08:57 | |
*** i159 has joined #openstack-oslo | 09:19 | |
*** praneshp has quit IRC | 09:28 | |
*** pblaho is now known as pblaho|afk | 10:06 | |
*** pcm_ has joined #openstack-oslo | 10:31 | |
*** yamahata has quit IRC | 10:36 | |
*** alexpilotti has joined #openstack-oslo | 10:42 | |
*** pcm_ has quit IRC | 10:44 | |
*** dims has joined #openstack-oslo | 10:46 | |
*** pcm_ has joined #openstack-oslo | 10:47 | |
*** dims has quit IRC | 10:50 | |
*** pblaho|afk is now known as pblaho | 10:54 | |
dtantsur | Hi folks! Yesterday I encountered SyntaxErrors in site-packages/sphinx/apidoc.py on Py33: http://logs.openstack.org/78/113978/4/check/gate-oslo-incubator-python33/b466718/console.html | 11:13 |
dtantsur | Is it a known bug? Should I recheck on it? | 11:14 |
*** pblaho is now known as pblaho|afk | 11:18 | |
*** ihrachyshka has joined #openstack-oslo | 11:19 | |
*** amotoki has quit IRC | 11:22 | |
*** ihrachyshka has quit IRC | 11:25 | |
*** vigneshvar has joined #openstack-oslo | 11:25 | |
vigneshvar | hi guys, a quick question. I have subscribed to a queue using rpc_getserver method and start call, i tried to stop and then start again. But now messages are not consumed | 11:27 |
*** AJaeger has joined #openstack-oslo | 11:27 | |
vigneshvar | what could be the issue | 11:27 |
*** pblaho|afk is now known as pblaho | 11:30 | |
*** dims has joined #openstack-oslo | 11:42 | |
*** k4n0 has quit IRC | 11:46 | |
*** kgiusti has joined #openstack-oslo | 11:55 | |
*** jaosorior has quit IRC | 12:02 | |
dhellmann | dtantsur: I saw something about a bad sphinx wheel being published, so that may have caused your problem. If rechecking doesn't fix it, you should ask in #openstack-infra to see if they can help track down the bad package. | 12:04 |
*** dims has quit IRC | 12:08 | |
*** dims has joined #openstack-oslo | 12:08 | |
AJaeger | dims, oslo.log is available now - but does not pass gating. There're two patches for it that fail due to python26 check failing | 12:15 |
dtantsur | dhellmann, thanks, will try | 12:23 |
*** amrith is now known as _amrith_ | 12:28 | |
dims | AJaeger: got a url? | 12:35 |
*** jeckersb_gone is now known as jeckersb | 12:55 | |
AJaeger | dims, I see your patch already, thanks! | 12:57 |
AJaeger | dims, https://review.openstack.org/117610 and https://review.openstack.org/117941 | 12:57 |
AJaeger | both should pass IMHO | 12:57 |
dims | AJaeger: found it | 12:57 |
*** gordc has joined #openstack-oslo | 12:58 | |
dims | AJaeger: not sure what i did will work, just trying something to see if it will | 12:58 |
AJaeger | dims, let's wait ;) As long as you're on it and aware of it, I'm happy! :) | 12:59 |
AJaeger | dims, thanks! | 12:59 |
dims | :) | 12:59 |
*** pblaho is now known as pblaho|afk | 13:00 | |
*** tongli has joined #openstack-oslo | 13:00 | |
dims | AJaeger: looks like it worked - https://jenkins03.openstack.org/job/gate-oslo.log-python26/2/console | 13:01 |
AJaeger | dims, that single character change is all? Wow! | 13:02 |
AJaeger | dims, let'S find some reviewers and get it in ;) | 13:02 |
dims | weird :) | 13:02 |
dims | AJaeger: rebased the other 2 on top of this one to see if they fare better | 13:03 |
AJaeger | dims,good idea - thanks! | 13:04 |
AJaeger | https://jenkins03.openstack.org/job/gate-oslo.log-python26/3/console ;( | 13:04 |
*** ildikov_ has quit IRC | 13:04 | |
dims | AJaeger: that global requirements did not fare well | 13:06 |
dims | this seems to have passed - https://jenkins04.openstack.org/job/gate-oslo.log-python26/1/console | 13:06 |
AJaeger | dims, but mine worked better ;) | 13:06 |
dims | y | 13:06 |
*** flaper87 is now known as flaper87|afk | 13:06 | |
dims | k. i'll go chase other gremlins :) | 13:07 |
*** ildikov has joined #openstack-oslo | 13:07 | |
AJaeger | dims, thanks | 13:07 |
*** pblaho|afk is now known as pblaho | 13:10 | |
*** Guest44661 is now known as hartsocks | 13:14 | |
*** pblaho_ has joined #openstack-oslo | 13:15 | |
*** pblaho has quit IRC | 13:16 | |
*** jaosorior has joined #openstack-oslo | 13:17 | |
*** jecarey_ has quit IRC | 13:21 | |
*** pblaho_ has quit IRC | 13:22 | |
*** zz_jgrimm is now known as jgrimm | 13:22 | |
*** pblaho_ has joined #openstack-oslo | 13:22 | |
*** bknudson has joined #openstack-oslo | 13:23 | |
*** mriedem has joined #openstack-oslo | 13:35 | |
viktors | dims: hi! Can you please review patch to incubator https://review.openstack.org/#/c/68963/ (Fix response_key parameter usage in BaseManager) ? Thanks! | 13:45 |
*** _amrith_ is now known as amrith | 13:49 | |
dims | viktors: looks good | 13:54 |
viktors | dims: thank you! | 13:55 |
*** pblaho_ has quit IRC | 13:57 | |
*** abhijeetm has joined #openstack-oslo | 13:58 | |
*** zzzeek has joined #openstack-oslo | 13:59 | |
*** stevemar has joined #openstack-oslo | 14:04 | |
*** openstackgerrit has joined #openstack-oslo | 14:05 | |
*** abhijeetm has quit IRC | 14:13 | |
dhellmann | dims, AJaeger : +2a on the testr fix for oslo.log | 14:28 |
dims | dhellmann: thanks! | 14:28 |
*** yamahata has joined #openstack-oslo | 14:31 | |
*** vigneshvar has quit IRC | 14:37 | |
*** ildikov_ has joined #openstack-oslo | 14:46 | |
*** shakamunyi has joined #openstack-oslo | 14:47 | |
*** jecarey has joined #openstack-oslo | 14:48 | |
*** ildikov has quit IRC | 14:49 | |
zzzeek | hey dhellmann , does sep 4 feature freeze apply to what I’m trying to do with oslo.db testing | 15:02 |
*** mtanino has joined #openstack-oslo | 15:02 | |
*** yamahata has quit IRC | 15:03 | |
*** yamahata has joined #openstack-oslo | 15:03 | |
*** shakamunyi has quit IRC | 15:07 | |
*** yamahata has quit IRC | 15:11 | |
*** shakamunyi has joined #openstack-oslo | 15:11 | |
zhiyan | dhellmann: hi, do you have 2 mins? i have a interesting question on excutils.save_and_reraise_exception(), could you give me some input? | 15:14 |
*** markmcclain has joined #openstack-oslo | 15:15 | |
dhellmann | zzzeek: yes, oslo.db is in use so that work may need to be deferred to kilo :-/ | 15:15 |
dhellmann | zhiyan: what's up? | 15:15 |
zzzeek | OK, not a prob | 15:15 |
*** markmcclain has quit IRC | 15:16 | |
zhiyan | dhellmann: i used it in most places and works ok, but today i met an issue when i do it for urllib2.URLErro exception. | 15:16 |
dhellmann | zzzeek: you can keep working on it, obviously, so we can land it as early as possible | 15:16 |
zhiyan | dhellmann: i got AttributeError: __exit__ issue | 15:17 |
zzzeek | dhellmann: shoudld i move the blueprint in oslo-specs to kilo/ ? | 15:17 |
zhiyan | dhellmann: did you meet this as well? i'm interested in the cause, but no idea. | 15:17 |
dhellmann | zzzeek: you can, but we have some other setup work to do in that repo so it might be less disruptive to go ahead and review it as it is for now | 15:18 |
zzzeek | ok | 15:18 |
dhellmann | zhiyan: I haven't seen that. Can you post a traceback somewhere? | 15:18 |
*** markmcclain has joined #openstack-oslo | 15:18 | |
zhiyan | dhellmann: http://paste.openstack.org/show/104790/ | 15:18 |
zhiyan | dhellmann: btw, i'm using Python 2.7.6 | 15:19 |
dhellmann | zhiyan: you need to call save_and_reraise_exception by adding the () even if you aren't passing any arguments | 15:20 |
dhellmann | line 13 | 15:20 |
*** viktors is now known as viktors|afk | 15:21 | |
zhiyan | dhellmann: oh, my bad! hmm, i must need some sleeps. thanks! | 15:22 |
dhellmann | zhiyan: :-) | 15:22 |
*** jecarey_ has joined #openstack-oslo | 15:23 | |
*** Ajaeger1 has joined #openstack-oslo | 15:41 | |
Ajaeger1 | dhellmann: thanks for the testr approval. Could you review https://review.openstack.org/117610, please? That gets the translation jobs working... | 15:42 |
dhellmann | Ajaeger1: looking | 15:43 |
dhellmann | Ajaeger1: +2a | 15:44 |
Ajaeger1 | dhellmann: thanks a lot! | 15:44 |
dhellmann | Ajaeger1: oslo.log work is likely to be lower priority this week, until after feature freeze | 15:44 |
Ajaeger1 | with those two patches in, oslo.log should be fine from a gate perspective... | 15:44 |
Ajaeger1 | dhellmann: I justed wanted the infra side working, I'm not planning on more patches ;) | 15:45 |
dhellmann | Ajaeger1: ok :-) | 15:45 |
*** shakamunyi has quit IRC | 15:46 | |
*** takedakn has joined #openstack-oslo | 15:57 | |
*** takedakn has quit IRC | 16:01 | |
*** i159 has quit IRC | 16:03 | |
dhellmann | YorikSar: have you set up oslo.concurrency on pypi already? | 16:03 |
*** shakamunyi has joined #openstack-oslo | 16:04 | |
*** morganfainberg_Z is now known as morganfainberg | 16:11 | |
hartsocks | dhellmann: ping | 16:11 |
dhellmann | hartsocks: here | 16:11 |
hartsocks | dhellmann: I just saw your note. I wasn't sure if you were aware I keep a presence in IRC. | 16:11 |
hartsocks | dhellmann: The short of it is, I was moved teams just after the last OpenStack summit. I'm not active on that team right now. That might change soon. | 16:13 |
dhellmann | hartsocks: the context isn't coming to mind, what note? | 16:13 |
hartsocks | dhellmann: you asked about oslo.vmware and group memberships. | 16:13 |
dhellmann | hartsocks: ah! that didn't go to just you, I used launchpad's "contact the maintainers" link | 16:13 |
dhellmann | hartsocks: it has been handled, but thank you for following up | 16:13 |
hartsocks | dhellmann: I'm basically, saying I'm not on that team's leadership anymore. | 16:14 |
hartsocks | dhellmann: okay. Good. | 16:14 |
*** shakamunyi has quit IRC | 16:20 | |
openstackgerrit | Ken Giusti proposed a change to openstack/oslo.messaging: An initial implementation of an AMQP 1.0 based messaging driver https://review.openstack.org/75815 | 16:21 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Switch oslo-incubator to use oslo.utils https://review.openstack.org/114649 | 16:31 |
*** ildikov_ has quit IRC | 16:38 | |
*** praneshp has joined #openstack-oslo | 16:51 | |
amrith | russellb, would you please take a look at https://review.openstack.org/#/c/114664/. Thanks! | 17:00 |
*** takedakn has joined #openstack-oslo | 17:01 | |
*** dtantsur is now known as dtantsur|afk | 17:01 | |
amrith | dhellmann, YorikSar ... but 1343604 has an OSSA alert tied to it. Commit https://review.openstack.org/#/c/116763/ is waiting for review on oslo.concurrency. Would you please help with a review if poss. Thanks! | 17:03 |
*** takedakn1 has joined #openstack-oslo | 17:04 | |
*** harlowja has joined #openstack-oslo | 17:04 | |
*** takedakn has quit IRC | 17:05 | |
openstackgerrit | A change was merged to openstack/oslo.db: Add doc8 to tox environment docs https://review.openstack.org/114003 | 17:07 |
*** bnemec has quit IRC | 17:17 | |
*** bnemec has joined #openstack-oslo | 17:18 | |
*** praneshp_ has joined #openstack-oslo | 17:24 | |
*** praneshp has quit IRC | 17:24 | |
*** praneshp_ is now known as praneshp | 17:24 | |
*** vigneshvar has joined #openstack-oslo | 17:26 | |
*** mtanino has quit IRC | 17:26 | |
*** praneshp_ has joined #openstack-oslo | 17:26 | |
*** praneshp has quit IRC | 17:29 | |
*** praneshp_ is now known as praneshp | 17:29 | |
*** takedakn1 has quit IRC | 17:35 | |
*** takedakn has joined #openstack-oslo | 17:35 | |
harlowja | dhellmann u might re+2ing https://review.openstack.org/#/c/106683/ ? | 17:48 |
harlowja | *u mind | 17:48 |
harlowja | anyone know the author of python-memcached ? | 17:50 |
harlowja | be nice to have it for https://github.com/linsomniac/python-memcached/pull/52 (for dims and others... ) | 17:50 |
dhellmann | harlowja: +2a | 17:54 |
harlowja | thx | 17:54 |
dhellmann | harlowja: we should talk about FF and taskflow, too | 17:54 |
harlowja | dhellmann on on https://review.openstack.org/#/c/106683/ +2a ? | 17:54 |
harlowja | *only one on, ha | 17:54 |
harlowja | sureeee | 17:55 |
dhellmann | harlowja: mis-hit the mouse, 2nd time worked | 17:55 |
harlowja | damn mice | 17:55 |
harlowja | so dhellmann i'd like to get the 2-3 others on high priority @ https://etherpad.openstack.org/p/TaskFlow-0.4 | 17:55 |
harlowja | then have 0.4 | 17:55 |
harlowja | then feature freeze and such, and then 0.4.1 with other ones on there | 17:55 |
dhellmann | is that likely to happen by the deadline? | 17:56 |
harlowja | this thursday right? | 17:56 |
dhellmann | yes | 17:56 |
harlowja | i think we can get 2 more reviews by this thursday | 17:56 |
harlowja | i hope, ha | 17:56 |
harlowja | 2-3 | 17:56 |
harlowja | btw added tests for https://review.openstack.org/#/c/116544/ | 17:57 |
dhellmann | ok, so that covers 0.4, and then do you have some bugs planned for 0.4.1? | 17:57 |
harlowja | a few ya, | 17:58 |
harlowja | https://review.openstack.org/#/c/111543/ would be nice | 17:58 |
harlowja | and a few tiny other ones i think (and some other claenups) | 17:58 |
harlowja | i'd say 0.4.1 would be nice to have the medium priority ones on that list | 17:58 |
dhellmann | ok, it would be good to have that etherpad list clarified down to the minimal set | 17:58 |
dhellmann | 0.4.1 should really only include bug fixes, right? | 17:59 |
harlowja | yes, although shifting code around isn't really a bug or feature | 17:59 |
harlowja | stuff like https://review.openstack.org/#/c/103245/ is just arrangement of code into better plae | 17:59 |
harlowja | *place | 17:59 |
dhellmann | right, so that also seems out of scope for a patch release | 17:59 |
harlowja | kk | 18:00 |
harlowja | let me adjust that set then | 18:00 |
harlowja | docs and bugs then i think are ok for 0.4.1 ? | 18:00 |
dhellmann | yeah, docs and bugs are good | 18:00 |
dhellmann | did you see the thread about milestone management? | 18:01 |
harlowja | reading | 18:01 |
harlowja | seems fair i think | 18:02 |
dhellmann | ok, we'll probably plan on adopting that starting in kilo, then | 18:03 |
dhellmann | although maybe earlier for some of the libs that don't have the long roadmap laid out like taskflow does | 18:03 |
*** Ajaeger1 has left #openstack-oslo | 18:04 | |
harlowja | long roadmap u say :-P | 18:05 |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Reject WBE messages if they can't be put in an ack state https://review.openstack.org/114814 | 18:06 |
dhellmann | harlowja: well, you had a 0.5 series laid out :-) | 18:07 |
harlowja | ah | 18:07 |
harlowja | kk | 18:07 |
harlowja | guess that might be longer than others ;) | 18:07 |
dhellmann | harlowja: yeah, most of the other libs haven't started thinking seriously about kilo yet | 18:10 |
*** harlowja has quit IRC | 18:12 | |
*** harlowja has joined #openstack-oslo | 18:13 | |
harlowja | dhellmann k, updated https://etherpad.openstack.org/p/TaskFlow-0.4 | 18:19 |
harlowja | let me know if u think some of those not ok | 18:19 |
harlowja | i personally like https://review.openstack.org/#/c/106216/ | 18:20 |
harlowja | :-P | 18:20 |
harlowja | remote calculatiion of the mandlebrot set ;) | 18:20 |
dhellmann | harlowja: looking | 18:22 |
dhellmann | harlowja: I'd like to get taskflow on the same cadence as the other libs, making kilo 0.5 and only actually releasing 0.4.1 if we have bugs to fix in 0.4. | 18:23 |
harlowja | that is fine with me | 18:23 |
dhellmann | harlowja: ok, thanks, that will make release tracking a bit more predictable | 18:24 |
dhellmann | harlowja: now, when do you think you'll be ready for a 1.0? | 18:24 |
harlowja | that seems to be the cadence anyway that is naturally occuring right now anyway, so might as well keep with it :-P | 18:24 |
dhellmann | yep | 18:24 |
harlowja | so 1.0, hmmmm | 18:25 |
*** mtanino has joined #openstack-oslo | 18:25 | |
dhellmann | can we talk about that as a goal for kilo, instead of calling it 0.5? | 18:25 |
harlowja | we could, although i start to wonder why (besides just making us all feel happy that we are using semantic versiioning and 1.0 is nice there) | 18:26 |
dhellmann | yeah, the idea is to signal our intent that it is ready to be used in production (since it already is being used) | 18:27 |
harlowja | who really wants/desires that signal though ;) | 18:27 |
harlowja | its already a signal, person can just ask me | 18:28 |
harlowja | lol | 18:28 |
dhellmann | I hear a lot from consuming projects | 18:28 |
harlowja | have of the stuff in https://github.com/openstack/requirements/blob/master/global-requirements.txt isn't production ready then :-P | 18:28 |
dhellmann | not specifically about taskflow | 18:28 |
harlowja | *half the stuff | 18:28 |
dhellmann | yeah, well, most of that isn't being produced by openstack devs | 18:28 |
harlowja | anyways, let me think about it, it's probably possible, although i'm not sure it does much/adds much value (i've already been trying to make sure changes are X - 1 compat and such) | 18:30 |
harlowja | it'd almost though let the project naturally evolve through its current rate and just let it evolve as is | 18:31 |
harlowja | seems less forced, more normal in a way | 18:31 |
dhellmann | do you have a roadmap to 1.0 then? | 18:31 |
harlowja | i don't plan that far out, ha | 18:31 |
harlowja | ^ part of the evolution part (code to me evolves, ages if u will) | 18:32 |
harlowja | like a wine, ha | 18:32 |
dhellmann | ok, well, think about it. I'd really rather have everyone following the same system. | 18:33 |
harlowja | u can't make a wine age quicker by just saying its aged, software sorta feels like that to me to :-P | 18:33 |
dhellmann | what's https://review.openstack.org/#/c/109840/10/taskflow/engines/worker_based/proxy.py doing with kombu? | 18:33 |
harlowja | do u want to know what that review is doign with kombu, or just in general? | 18:34 |
harlowja | http://docs.openstack.org/developer/taskflow/workers.html might be useful | 18:35 |
harlowja | taskflow not just run tasks locally | 18:35 |
harlowja | *its what i call the WBE (not to confused with whooper) | 18:37 |
dhellmann | that code in general; I'll read the docs | 18:37 |
harlowja | k, basically an engine can run things locally (useful for when this is useful) in threads or non-threads, then it can also connect that same stuff into remote workers | 18:38 |
harlowja | since an engine recieves a workflow, translates it into some format, then orchestrates/manages running it, this same thing can be done with remote processes as well | 18:39 |
harlowja | just manages things that aren't local (but may percieve to be local from a users point of view) | 18:39 |
harlowja | so from a taskflow user point of view its meant to be somewhat transparent (as transparent as possible) | 18:41 |
harlowja | i was someday in the future/past going to use oslo.messaging, but that appears to be openstack centric and thus taskflow can't currently pull it in :- | 18:46 |
harlowja | :-/ | 18:46 |
*** flaper87|afk is now known as flaper87 | 18:49 | |
dhellmann | harlowja: how about oslo.utils? https://review.openstack.org/#/c/116191/5/taskflow/utils/misc.py | 18:57 |
harlowja | once https://github.com/openstack/oslo.utils/blob/master/requirements.txt#L4 is gone, yup | 18:57 |
harlowja | i'll use that | 18:58 |
harlowja | still seems to suck in oslo.config | 18:58 |
harlowja | is that planned to not get sucked in? | 18:58 |
dhellmann | harlowja: I don't actually see us importing that anywhere | 18:58 |
dhellmann | weird | 18:59 |
harlowja | ah, then sure, i'll use oslo.utils | 18:59 |
harlowja | and oslo.serialization (which afaik also has the same problem) | 18:59 |
dhellmann | I wonder if we have that in our cookiecutter template | 18:59 |
harlowja | ah, maybe | 18:59 |
harlowja | ya, from looking at oslo.utils not seeing it used | 19:00 |
dhellmann | no, it may be coming from the exported requirements from the incubator? | 19:00 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: fix small typo https://review.openstack.org/118437 | 19:00 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo.utils: Remove unused dependency on oslo.config https://review.openstack.org/118438 | 19:01 |
dhellmann | harlowja, dims : ^^ | 19:01 |
harlowja | cool | 19:01 |
dims | dhellmann: ah nice | 19:01 |
harlowja | seems good then, less things i don't have to worry about and can just use, phew | 19:02 |
*** lifeless has joined #openstack-oslo | 19:09 | |
lifeless | oh look another huge channel | 19:10 |
*** markmc has joined #openstack-oslo | 19:10 | |
lifeless | dhellmann: pbr-semver ping | 19:10 |
dhellmann | lifeless: hey, I'm trying to sort out what we need to land by FF and what can wait. Where do things stand with the semver changes you're working on? | 19:11 |
dhellmann | lifeless: I can't, for example, tell which changesets are associated with that blueprint | 19:11 |
lifeless | ok so | 19:11 |
harlowja | lifeless more channels! | 19:11 |
harlowja | we need mooooreee channels | 19:11 |
lifeless | all the helpful automation like tag-for-me can wait | 19:11 |
* dhellmann hadn't noticed we have so many lurkers in here until now | 19:12 | |
*** jecarey has quit IRC | 19:12 | |
lifeless | dhellmann: https://review.openstack.org/#/c/114403/ and everything under it should be included asap IMO because that provides a cohesive transition | 19:12 |
lifeless | dhellmann: https://review.openstack.org/#/c/108270/18 failed because its not symmetrically gated with neutron | 19:13 |
lifeless | dhellmann: devstack doesn't do 'setup.py install' just 'develop' | 19:13 |
lifeless | dhellmann: I was asking around yesterday about opinions on the best way to make that symmetric | 19:13 |
dhellmann | lifeless: yeah, I had a patch ready for infra for stuff like that but it lingered and sdague thought it was going to use too many resources | 19:14 |
*** dteselkin has quit IRC | 19:14 | |
dhellmann | lifeless: so do we need changes in neutron to fix the issue and let that patch land? | 19:14 |
lifeless | so this is a repeating problem with neutron at least | 19:14 |
lifeless | they have a patch | 19:15 |
lifeless | it was wending its way through gate 24h ago | 19:15 |
lifeless | I asked about promoting it | 19:15 |
lifeless | but must have hit everyones lunch or something :/ | 19:15 |
dhellmann | oh, I saw a -1 from jenkins | 19:15 |
dhellmann | or do you mean the neutron change? | 19:15 |
openstackgerrit | Davanum Srinivas (dims) proposed a change to openstack/oslo-incubator: Switch oslo-incubator to use oslo.utils https://review.openstack.org/114649 | 19:15 |
lifeless | the neutron change | 19:15 |
dhellmann | have a changeset id?I can ask kmestery and markmcclain to baby sit it | 19:16 |
lifeless | it landed - 622b3cac8f1bab2c0348992e43929cd5dd8c13a2 | 19:16 |
lifeless | I've rechecked the pbr change | 19:16 |
dhellmann | ok | 19:16 |
vigneshvar | hi guys. I have an issue. i have used rpc.get_server method with a specific topic. I started it and i am able stop as well. How ever if i try to start again, it does not seem to work. Any clue ? | 19:16 |
lifeless | note the 'again' - this is the very identical change that neutron had to back out last time | 19:17 |
lifeless | so really, running setup.py install somewhere on each neutron change shouldn't be a resource killer | 19:17 |
*** dteselkin has joined #openstack-oslo | 19:18 | |
dhellmann | vigneshvar: you probably want markmc, flaper87, or sileht to help with that. They're all in european time zones | 19:18 |
lifeless | tripleo catches it, if we had the capacity to autorun all those jobs | 19:18 |
vigneshvar | dhellmann: Thanks | 19:18 |
dhellmann | vigneshvar: we have a big deadline this week, so we're going to be focusing on code reviews and it may take a little time to get a response -- the -dev mailing list might be effective, too | 19:18 |
vigneshvar | dhellmann: sure i will follow it up with mailing list. thanks a ton | 19:19 |
dhellmann | vigneshvar: any time! | 19:19 |
dhellmann | lifeless: a simple job to run "pip instlal ." for each app seems fast and useful, but wouldn't the gate runs catch that anyway? | 19:23 |
lifeless | dhellmann: they don't today | 19:26 |
lifeless | dhellmann: because they use devstack which does pip develop . | 19:26 |
lifeless | and thus doesn't run all the static file collection-copy-install code | 19:26 |
dhellmann | ah, right | 19:26 |
dhellmann | does building the sdist catch it? | 19:27 |
lifeless | I don't know | 19:27 |
* dhellmann is looking for the quickest job | 19:27 | |
dhellmann | ok | 19:27 |
lifeless | There are two jobs today that I know of that catch it | 19:27 |
lifeless | anything tripleo, which we would like to be running against everything | 19:27 |
dhellmann | pbr has that job that verifies we can still install everything | 19:28 |
lifeless | and check-requirements-integration-dsvm | 19:28 |
dhellmann | that's the one | 19:28 |
lifeless | which we don't run against neutron etc changes | 19:28 |
dhellmann | lifeless: building the sdist does not catch the error | 19:30 |
dims | dhellmann: did you have oslo.utils on your list as a fresh release? (fix for _import_*) | 19:33 |
lifeless | dhellmann: you're testing with a older revision right? cause tip is fixed ;) | 19:33 |
dhellmann | dims: I was going to hold off on releases until after the deadline thursday. do we need that one earlier? | 19:33 |
dhellmann | lifeless: yes, I checked out the commit you sent, then HEAD~1 and tested both ways. sdist worked, install errored | 19:33 |
lifeless | cool | 19:34 |
lifeless | ttx: ping | 19:34 |
dims | dhellmann: i think we should do that since _import_* caused a lot of headaches | 19:34 |
dhellmann | ok, are we ready for that? | 19:34 |
dims | checking | 19:34 |
dhellmann | we have 2 merging and the oslo.config dependency needs to merge I think | 19:35 |
dims | dhellmann: right | 19:36 |
dims | dhellmann: with that set, we should be good | 19:36 |
dhellmann | dims: ok | 19:37 |
dhellmann | dims: we should be careful about having anyone use utils until it is in the devstack gate | 19:37 |
dhellmann | dims: https://review.openstack.org/#/c/117307/ has been approved but not merged yet | 19:38 |
dims | dhellmann: agreed | 19:38 |
dhellmann | dims, bnemec : that doc I just shared with you has what I *think* we have left to do to call these libraries "done" | 19:42 |
dims | dhellmann: going through it | 19:44 |
* bnemec will look closer as soon as he finishes the file locking backport | 19:45 | |
dhellmann | quite a few holes, but I think we can finish for rc1 | 19:45 |
dhellmann | and of course the list is based on the wiki instructions | 19:45 |
* dhellmann needs to go prep for the TC meeting | 19:45 | |
openstackgerrit | amrith proposed a change to openstack/oslo-incubator: Mask passwords in exceptions and error messages https://review.openstack.org/118452 | 19:48 |
dims | dhellmann: when you get a chance - https://launchpad.net/oslo is missing oslo.log | 19:57 |
*** morganfainberg is now known as needs | 19:57 | |
*** needs is now known as needscoffee | 19:57 | |
bnemec | Why does pypi hate me? | 19:58 |
dhellmann | dims: fixed | 20:04 |
dims | thanks! | 20:04 |
openstackgerrit | Ben Nemec proposed a change to openstack/oslo-incubator: Use file locks by default again https://review.openstack.org/118457 | 20:05 |
bnemec | ^Push and pray since I can't get pypi to cooperate long enough to build a venv. >:-( | 20:06 |
*** kgiusti has left #openstack-oslo | 20:10 | |
openstackgerrit | Joshua Harlow proposed a change to openstack/taskflow: Use and verify event and latch waited for values with timeouts https://review.openstack.org/118460 | 20:13 |
*** GheRivero_afk is now known as GheRivero | 20:27 | |
*** amrith is now known as _amrith_ | 20:34 | |
jogo | so I may have a oslo.db error | 20:50 |
jogo | http://logs.openstack.org/31/105031/14/gate/gate-tempest-dsvm-full/c05b927/logs/screen-n-cond.txt.gz? | 20:50 |
jogo | https://bugs.launchpad.net/nova/+bug/1353131 | 20:50 |
jogo | there is a retry decorator on that function that does't seem to trigger | 20:50 |
jogo | mriedem: ^ | 20:51 |
mriedem | jogo: nova isn't using oslo.db yet | 20:51 |
mriedem | there is a review for it | 20:52 |
jogo | mriedem: sure, but oslo-incubator version of the code | 20:52 |
mriedem | the regex is a match: http://git.openstack.org/cgit/openstack/oslo-incubator/tree/openstack/common/db/sqlalchemy/session.py#n406 | 20:54 |
mriedem | note the postgresql fix for the same isn't in there, but is in oslo.db | 20:54 |
mriedem | this is a mysql run though you linked me to | 20:54 |
*** needscoffee is now known as morganfainberg | 20:56 | |
*** markmc has quit IRC | 21:02 | |
jogo | mriedem: a more recent failure in mysql http://logs.openstack.org/79/95279/16/gate/gate-tempest-dsvm-full/d7e1280/logs/screen-n-cond.txt.gz? | 21:03 |
jogo | mriedem: does oslo.db fix this somehow? | 21:03 |
mriedem | jogo: not that i'm aware of | 21:03 |
mriedem | jogo: as noted in -nova the code looks correct, not sure why it's not handling the failure | 21:03 |
mriedem | jogo: if this were pg i'd say it's obvious, because nova doesn't have the handling for pg, but that's not the case here | 21:04 |
jogo | yeah | 21:04 |
jogo | I am thinking the error being raised changed subtly? | 21:04 |
mriedem | jogo: don't think so | 21:04 |
mriedem | i plugged them into a regex tester and it's fine | 21:05 |
jogo | mriedem: not the regex | 21:05 |
jogo | but the try except bock | 21:05 |
jogo | block | 21:05 |
jogo | zzzeek: ^ | 21:06 |
mriedem | jogo: seems fine | 21:08 |
mriedem | the db api calls are passing session as a kwarg to model_query which calls session.query which is wrapped http://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/db/sqlalchemy/session.py#n700 | 21:09 |
*** flaper87 is now known as flaper87|afk | 21:09 | |
jogo | mriedem: we are catching a OperationalError in SQLA but the stacktrace starts in Mysqldb | 21:09 |
mriedem | well the stacktrace starts in the sqla driver which is mysqlconnector, and should be translated to sqla OperationalError | 21:12 |
mriedem | which that wrapper should be catching | 21:12 |
jogo | mriedem: that is a few layers of should ;) | 21:13 |
ekarlso | btw, what's the pros / cons of mysqldb vs connnector + | 21:13 |
mriedem | jogo: i'm wondering if self.bind.dialect.name is what we expect | 21:13 |
mriedem | sorry this is mysqldb, not connector | 21:15 |
jogo | mriedem: good question | 21:15 |
jogo | mriedem: looks like it may be correct | 21:16 |
mriedem | jogo: would be nice if this warned when the engine isn't handling deadlock failures: | 21:19 |
mriedem | http://git.openstack.org/cgit/openstack/nova/tree/nova/openstack/common/db/sqlalchemy/session.py#n418 | 21:19 |
mriedem | "i'd like to help but you haven't told me how" | 21:20 |
jogo | mriedem: great idea | 21:20 |
jogo | you should add something to oslo.db | 21:21 |
jogo | mriedem: https://review.openstack.org/118470 | 21:21 |
jogo | mriedem: a test patch to get some more logs | 21:21 |
*** takedakn1 has joined #openstack-oslo | 21:21 | |
*** takedakn has quit IRC | 21:22 | |
mriedem | yeah i can add something to oslo.db | 21:22 |
jogo | mriedem: cool thanks | 21:24 |
jogo | mriedem: do you think its worth switching over to oslo.db for Juno? | 21:24 |
jogo | mriedem: I am torn on it | 21:24 |
jogo | its risky but it makes backports and maint easier | 21:25 |
mriedem | i haven't reviewed the change | 21:26 |
mriedem | it does seem risky this late in the cycle | 21:26 |
mriedem | i.e. not enough time for burn in | 21:26 |
jogo | mriedem: that is my thinking as well | 21:27 |
openstackgerrit | Doug Hellmann proposed a change to openstack/oslo-specs: Move the deferred logging specs to kilo https://review.openstack.org/118471 | 21:27 |
jogo | if a oslo.db maint wants to compain for it I am all ears | 21:27 |
mriedem | jogo: rpodolyaka was asking for reviews in -nova this morning | 21:29 |
zzzeek | jogo: execption catching/rewriting is all different in oslo.db now | 21:29 |
zzzeek | tehre’s no more wrapper its done with a central event | 21:29 |
mriedem | jogo: fwiw, we did merge a big oslo db sync right before feature freeze in icehouse | 21:30 |
jogo | zzzeek: so are you saying it should work better? | 21:30 |
jogo | mriedem: rpodolyaka and I didn't overlap this morning | 21:30 |
mriedem | i'd be interested in knowing what other projects are already using oslo.db, for how long and if they've had any issues | 21:30 |
dhellmann | jogo: I would advise planning to move to oslo.db by kilo-1 because the incubator code is going to be deleted soon. I'll leave it up to the nova team to decide whether that means doing it now, though. | 21:30 |
jogo | mriedem: ++ | 21:30 |
zzzeek | oslo.db’s current approach should guarantee all execptions intercepted, if that’s the issue | 21:30 |
zzzeek | mriedem: said logic is brand new as of a few weeks ago :) | 21:31 |
dhellmann | mriedem: cinder designate glance heat ironic keystone neutron sahara tuskar | 21:31 |
dhellmann | mriedem: according to their requirements.txt | 21:31 |
jogo | dhellmann: wow | 21:31 |
jogo | mriedem: so mabe we should land the oslo.db patch | 21:31 |
jogo | I'll review it later today | 21:31 |
dhellmann | jogo: yeah, oslo has stopped coming to nova first because you guys have a lot of other stuff going on, so this gives us a chance to work with smaller teams to resolve issues | 21:31 |
jogo | being there appears to already be good adoption and a few people to yell at when it breaks us ;) | 21:32 |
jogo | dhellmann: ++ | 21:32 |
*** morganfainberg is now known as steve_notmorgan | 21:32 | |
mriedem | jogo: maybe, jaypipes was reviewing it before | 21:32 |
dhellmann | jogo: we learned from oslo.messaging :-) | 21:32 |
mriedem | jogo: i haven't reviewed it yet, and won't be able to in the next 10 min | 21:32 |
mriedem | read: i'm busy for the next several hours, | 21:32 |
*** steve_notmorgan is now known as morganfainberg | 21:32 | |
jogo | mriedem: neither well I but I its now at the top of my review list | 21:33 |
mriedem | (and don't really want to review that tonight...) | 21:33 |
mriedem | i'd be ok with it being a FFE in the ML too | 21:33 |
mriedem | to get some attention on it, and would require 3 cores | 21:33 |
mriedem | you me and jaypipes would probably sponsor it | 21:33 |
mriedem | actually it's not even tied to a blueprint | 21:34 |
*** _amrith_ is now known as amrith | 21:39 | |
dhellmann | harlowja: how much of oslo.messaging did you have to build into taskflow so that taskflow doesn't have to depend on oslo.messaging? | 21:40 |
harlowja | dhellmann ah, good question | 21:40 |
dhellmann | harlowja: https://review.openstack.org/#/c/114814/3 | 21:40 |
dhellmann | harlowja: would it make sense to pull out the message bus driver stuff into a separate lib that taskflow can use and that can depend on oslo.messaging? | 21:41 |
jogo | mriedem: I would sponser a FFE too | 21:41 |
dhellmann | harlowja: ditto for oslo.db in https://review.openstack.org/#/c/111543/ | 21:42 |
harlowja | dhellmann so u could consider https://github.com/openstack/taskflow/blob/master/taskflow/engines/worker_based/proxy.py to be part of oslo.messaging | 21:42 |
harlowja | dhellmann anything that brings in oslo.config i won't touch it :) | 21:42 |
*** jgrimm is now known as zz_jgrimm | 21:42 | |
harlowja | jd__ tried and that caused lots of problems in tooz currently | 21:43 |
harlowja | *well not lots, but problems | 21:43 |
harlowja | i don't want apis that are half from one place, half from config... | 21:43 |
dhellmann | harlowja: ok, we might have to have another discussion about whether taskflow is an oslo lib then, because I don't think it makes sense for us to be supporting 2 versions of all of these things just so you don't have to install oslo.config | 21:43 |
dhellmann | perhaps we can work out the API issues in oslo.messaging so the config isn't required -- I thought we had most of that handled with the new url schemes anyway | 21:44 |
harlowja | or eliminate the usage of oslo.config :-P | 21:44 |
dhellmann | yeah, that's not a realistic solution given our backwards compatibility requirements | 21:45 |
harlowja | sure i know tooz tried to use oslo.config when it brought in oslo-incubator, stuff like http://paste.openstack.org/show/99963/ started occuring | 21:45 |
harlowja | having a library that has an API that is magically touched at a distance by configuration options imho just doesn't feel right | 21:45 |
dhellmann | so they have 2 modules defining the same option with different settings | 21:45 |
dhellmann | the user needs to configure the transport stuff. We don't want different option definitions in each app, so we put them in the common library. | 21:46 |
harlowja | sure, thats great/nice for app usage | 21:48 |
dhellmann | harlowja: seriously, put together some sort of description of what issues you'd have with oslo.messaging and oslo.db and whatever else so we can talk about how to address them. I had no idea you had duplicate implementations of all of this. | 21:48 |
dhellmann | harlowja: look at the way we dealt with it in oslo.db, for example | 21:48 |
harlowja | not dupliacates neccasrily, they existed before the oslo.* stuff | 21:48 |
dhellmann | you wrote a message bus rpc thing before oslo.messaging? | 21:49 |
harlowja | yes | 21:49 |
dhellmann | how old is taskflow then? because I thought it was newer than oslo. | 21:49 |
harlowja | 1.65 years | 21:49 |
harlowja | newer than oslo incubator | 21:50 |
harlowja | but not newer than the rest | 21:50 |
harlowja | http://lists.openstack.org/pipermail/openstack-dev/2013-September/015088.html | 21:50 |
dhellmann | ok. well, now we have 2, and I don't like having 2 of things, so let's see what we can do about it | 21:50 |
ekarlso | yah, I remember that one looong way back : p | 21:51 |
harlowja | sure i did create https://blueprints.launchpad.net/taskflow/+spec/use-oslo-db and https://blueprints.launchpad.net/taskflow/+spec/use-oslo-messaging but recently the discussion was that oslo.* libraries should only be used in apps from what i remember | 21:51 |
harlowja | and taskflow isn't an app | 21:52 |
harlowja | anyways | 21:52 |
dhellmann | used within *openstack* not just apps, but we also assumed the rational wouldn't be used as a justification to support 2 implementations of those features | 21:53 |
harlowja | all for helping merge them, if we feel its a way to go | 21:55 |
harlowja | just gotta learn how to walk before u can run, and so-on | 21:55 |
*** alexpilotti has quit IRC | 21:57 | |
dhellmann | ok, so let's put together a realistic plan for making the changes needed in all 3 libs (and any others I haven't spotted -- I see some incubated modules in there, too) | 21:59 |
harlowja | dhellmann ya, the incubatored ones will have to be kicked on soon anyway | 22:03 |
harlowja | anyways, let see what i can writeuop | 22:05 |
dhellmann | ok, thanks | 22:05 |
*** bknudson has quit IRC | 22:05 | |
harlowja | sure | 22:06 |
*** dims has quit IRC | 22:07 | |
*** dims has joined #openstack-oslo | 22:08 | |
harlowja | dhellmann will just write this up @ https://etherpad.openstack.org/p/taskflow-oslo-db-messaging (empty right now, ha) | 22:11 |
dhellmann | harlowja: sounds good; we'll get the team to review it a bit and then you can turn it into a spec | 22:11 |
harlowja | sure | 22:12 |
*** dims has quit IRC | 22:12 | |
*** pcm_ has quit IRC | 22:13 | |
*** stevemar has quit IRC | 22:21 | |
*** jecarey_ has quit IRC | 22:21 | |
*** jaosorior has quit IRC | 22:22 | |
*** gordc has quit IRC | 22:28 | |
*** pcm_ has joined #openstack-oslo | 22:44 | |
*** pcm_ has quit IRC | 22:48 | |
*** pcm_ has joined #openstack-oslo | 22:49 | |
*** stevemar has joined #openstack-oslo | 22:54 | |
*** zzzeek has quit IRC | 23:05 | |
*** zzzeek has joined #openstack-oslo | 23:12 | |
*** tongli has quit IRC | 23:16 | |
*** tongli has joined #openstack-oslo | 23:16 | |
*** praneshp has quit IRC | 23:31 | |
*** stevemar has quit IRC | 23:35 | |
*** oomichi has quit IRC | 23:35 | |
*** markmcclain has quit IRC | 23:37 | |
*** oomichi has joined #openstack-oslo | 23:45 | |
*** zzzeek has quit IRC | 23:48 | |
*** takedakn1 has quit IRC | 23:58 | |
*** takedakn has joined #openstack-oslo | 23:58 | |
*** praneshp has joined #openstack-oslo | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!