*** salmon_ has quit IRC | 01:26 | |
*** openstack has joined #openstack-solar | 13:21 | |
*** openstackstatus has joined #openstack-solar | 13:21 | |
*** ChanServ sets mode: +v openstackstatus | 13:21 | |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Make zerorpc working with pyzmq > 13.0.2 https://review.openstack.org/284123 | 13:25 |
---|---|---|
pigmej | ^ dshulyak salmon_ | 13:25 |
pigmej | brb | 13:28 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Fix parsing list of dicts https://review.openstack.org/284129 | 13:33 |
mkwiek | pigmej: shouldn't this zerorpc patch change pyzmq version to be aligned with global requirements? | 13:38 |
mkwiek | 14.3.1 I think | 13:39 |
openstackgerrit | Aleksey Zvyagintsev proposed openstack/solar: Add rpm spec file for solar https://review.openstack.org/283056 | 14:24 |
azvyagintsev | pigmej: https://review.openstack.org/#/c/283056/ looks like we can merge it. all package-related issues cloused | 14:25 |
pigmej | mkwiek: well we could then | 14:26 |
pigmej | I will adjust | 14:26 |
pigmej | well mkwiek it's ok to leave it like that | 14:27 |
pigmej | because our version is lower | 14:27 |
pigmej | and we know that it works with 13.0.2 | 14:28 |
pigmej | salmon_: dshulyak any opinions about my fixes ? | 14:29 |
pigmej | I need to be sure that you accept them, after that we can merge spec file, so please leave your opinion :) | 14:29 |
mkwiek | pigmej: if we are ok with not complying with global requirements (I think we are now :)) then I am fine with that | 14:29 |
pigmej | afair you comply with global reqs as long as your packages doesn't exclude these | 14:30 |
pigmej | we require >13.0.2, global req >14.3.1 => result is >14.3.1 | 14:30 |
pigmej | or am I wrong? | 14:31 |
mkwiek | I think it's ok logically, but AFAIK the script that checks compliance tests if requirements are actually identical | 14:32 |
mkwiek | so if we are already touching it - why not touch it a bit more? :D | 14:33 |
pigmej | because In fact I would prefer <13.0.2 ;d | 14:33 |
pigmej | == | 14:33 |
pigmej | then it works without that hack :D | 14:33 |
salmon_ | yup | 14:33 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Make zerorpc working with pyzmq > 13.0.2 https://review.openstack.org/284123 | 14:33 |
pigmej | I added Closes-bug statement | 14:33 |
pigmej | dshulyak: ^ | 14:34 |
mkwiek | azvyagintsev: I am not an expert on packaging, so this may be a silly question, but why didn't you provide a version for some packages in rpm spec? for example for ansible - I think solar won't work with ansible<1.9 or even 2.0 . Or is it fine? | 14:38 |
openstackgerrit | Vitaly Parakhin proposed openstack/solar: Add rpm spec file for solar https://review.openstack.org/283056 | 14:38 |
azvyagintsev | mkwiek: sure. it's only and "base" data, which i get from requirmets.txt. i will fix it in a sec | 14:39 |
azvyagintsev | something more should be limited? | 14:40 |
mkwiek | I think that fabric package is actually python-fabric, but I am not sure | 14:41 |
pigmej | nope, it's without python- prefix :D | 14:42 |
azvyagintsev | yeah...its becouse "fabric-1.10.2-1.el7~mos1.noarch" (mos guys :)) | 14:43 |
mkwiek | I stand corrected then :) | 14:44 |
openstackgerrit | Lukasz Oles proposed openstack/solar: Fix parsing list of dicts https://review.openstack.org/284129 | 14:45 |
pigmej | salmon_: where is the bug for it? | 14:46 |
salmon_ | pigmej: in commit message | 14:46 |
openstackgerrit | Merged openstack/solar: Make zerorpc working with pyzmq > 13.0.2 https://review.openstack.org/284123 | 14:49 |
azvyagintsev | mkwiek: yup (i dig into rpm package of fabric- and look's like it also provide python-fabric. so i will fix it) | 14:50 |
pigmej | salmon_: incorrect statement;P | 14:51 |
azvyagintsev | mkwiek: pigmej: we have an ansible 1.9.4 in epel. will it be ok? | 14:52 |
pigmej | hmm | 14:52 |
pigmej | I'm starting to hate ansible | 14:52 |
azvyagintsev | :D | 14:52 |
azvyagintsev | lets try with 1.9.4 ? | 14:52 |
pigmej | it will crash now.... | 14:53 |
azvyagintsev | with 1.9.4 ? | 14:54 |
pigmej | Yeah, because we recently updated our resources to ansible 2.0 ;D | 14:55 |
pigmej | which introduced "become: yes" instead of "sudo: yes"... | 14:55 |
pigmej | salmon_: opinions about that? | 14:56 |
salmon_ | As of 1.9 become supersedes the old sudo/su, while still being backwards compatible. | 14:56 |
salmon_ | it was added in 1.9 | 14:56 |
pigmej | 1.9 ? | 14:57 |
pigmej | not 2.0 ? | 14:57 |
salmon_ | I just pasted a line from docs | 14:58 |
pigmej | ah right | 14:58 |
pigmej | ok so 1.9.4 should be ok | 14:58 |
azvyagintsev | ok | 14:58 |
pigmej | ;D | 14:58 |
azvyagintsev | no no ptoblem | 14:58 |
azvyagintsev | i ask our guru to build 2.0 :) | 14:58 |
pigmej | well but it's ok if we can use 1.9.x | 14:58 |
azvyagintsev | ok. let stay in spec => 1.9 , but ask for 2.0 ? | 14:59 |
pigmej | hmm, we mirgated to 2.0 because of some library issues | 14:59 |
pigmej | salmon_: do you remember exactly? | 14:59 |
salmon_ | pigmej: they just released 2.0 and we used it :) | 15:00 |
azvyagintsev | bad karma :\ | 15:00 |
pigmej | it was not that easy to move to 2.0 so there was a reason | 15:00 |
azvyagintsev | sooo...?) | 15:00 |
pigmej | hmm, maybe we could lower ansible to >=1.9.4 | 15:01 |
pigmej | salmon_: opinions? | 15:01 |
pigmej | azvyagintsev: maybe let's do 2.0 now because we can't test it properly now, then we *may* relax it to something lower, because 1.9.4 will be compatible with our usage for sure, I'm not sure what about resources stuff, but ... :) | 15:03 |
salmon_ | we are testing on 2.0 now so 2.0 is safer | 15:08 |
pigmej | azvyagintsev: so let's assume that we need 2.0, we may later relax this | 15:10 |
pigmej | salmon_: the only problematic thingy is library stuff from ansible that differs between 1.9 and 2.0 (we needed some parts from 2.0 docker?) | 15:11 |
salmon_ | for docker? No | 15:11 |
openstackgerrit | Annie Lezil proposed openstack/solar: Fixed alignment issues in the text, corrected length. https://review.openstack.org/283326 | 17:01 |
openstackgerrit | Jedrzej Nowak proposed openstack/solar: Workaround for TypeError in zerorpc Events.__del__ https://review.openstack.org/284262 | 17:03 |
openstackgerrit | Merged openstack/solar: Fixed alignment issues in the text, corrected length. https://review.openstack.org/283326 | 17:48 |
pigmej | salmon_: dshulyak I don't like my patch at all but I couldn't figure out better way than https://review.openstack.org/284262 | 17:50 |
openstackgerrit | Merged openstack/solar: Add rpm spec file for solar https://review.openstack.org/283056 | 19:05 |
*** dshulyak has quit IRC | 21:45 | |
*** salmon_ has quit IRC | 23:12 | |
*** salmon_ has joined #openstack-solar | 23:12 | |
*** salmon_ has quit IRC | 23:18 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!