*** dshulyak has joined #openstack-solar | 00:28 | |
*** dshulyak has quit IRC | 00:33 | |
*** angdraug has quit IRC | 01:20 | |
*** salmon_ has quit IRC | 02:34 | |
*** dshulyak has joined #openstack-solar | 07:02 | |
*** salmon_ has joined #openstack-solar | 08:22 | |
mkwiek | pigmej: any tips for reproducing the timestamp in total time? | 08:47 |
---|---|---|
mkwiek | I have problems making it work like you described | 08:47 |
*** openstackgerrit has quit IRC | 08:48 | |
*** openstackgerrit has joined #openstack-solar | 08:48 | |
mkwiek | or rather - not work :D | 08:52 |
mkwiek | I mean your comment in https://review.openstack.org/#/c/286040/1 | 08:52 |
pigmej | mkwiek: just use test script | 09:21 |
mkwiek | pigmej: which test script? | 09:21 |
pigmej | bash utils/jenkins/run_hosts_example.sh | 09:22 |
pigmej | it happens always there | 09:23 |
salmon_ | dshulyak: hmm, your graph is missing rsync_core_puppet | 09:23 |
mkwiek | oh, I haven't gotten to running examples yet, I had problems with packer and images | 09:24 |
mkwiek | need to investigate what's going on there | 09:24 |
pigmej | dshulyak: https://review.openstack.org/#/c/285336/ | 09:24 |
dshulyak | salmon_: sure, rsync should be used from created part | 09:24 |
pigmej | when we will merge it version 8.0 will be "invalid" how hard is to fix your scripts to generate 8.0.0 instead ? | 09:24 |
salmon_ | dshulyak: why? I thought it will be in a graph from nailgun | 09:25 |
dshulyak | salmon_: you r right, it would be better to create rsync resource from graph | 09:29 |
dshulyak | and also genkeys | 09:29 |
dshulyak | pigmej: lets wait a bit, it is not hard, but better to do it later | 09:30 |
pigmej | dshulyak: ok, but we need to merge it before releas | 09:31 |
salmon_ | dshulyak: did you try to deploy changes with your patch? For me astute fails with strange error: https://bpaste.net/raw/0bc8a103362b | 09:37 |
salmon_ | without you patch it's working ok | 09:38 |
salmon_ | *your | 09:38 |
dshulyak | salmon_: my patch rebased on top of some changes in nailgun, and if u want to deploy with it u also need astute part | 09:38 |
salmon_ | dshulyak: ah, ok | 09:38 |
dshulyak | salmon_: this one https://review.openstack.org/#/c/281448/ | 09:39 |
salmon_ | dshulyak: ok | 09:39 |
openstackgerrit | Merged openstack/solar: Update rpm spec dependency https://review.openstack.org/286057 | 09:39 |
salmon_ | dshulyak: btw. this is what astutes does with shell tasks: https://bpaste.net/show/85ccaa892012 | 09:39 |
salmon_ | it creates puppet munifest from it :/ | 09:40 |
dshulyak | i know :) | 09:40 |
salmon_ | ah | 09:40 |
dshulyak | it is because bash was blocking, and puppet is always spawned as daemon process | 09:40 |
salmon_ | I wonder if we can use astute to execute it... | 09:40 |
dshulyak | what do you mean? | 09:41 |
salmon_ | dshulyak: not only that, they also use some variables in commands like CLUSTER_ID | 09:41 |
salmon_ | dshulyak: just thinking... | 09:41 |
dshulyak | nope, this variable is resolved on the side of nailgun | 09:41 |
salmon_ | ah, one problem less then | 09:41 |
salmon_ | ok, then I need it in a graph | 09:42 |
dshulyak | the problematic task is update_nodes_info, because it needs to be called for each new added now on every node | 09:42 |
dshulyak | salmon_: can you show me that shell resource u was talking about | 09:43 |
salmon_ | dshulyak: update or upload? | 09:43 |
dshulyak | salmon_: i think we will need to trigger both somehow | 09:45 |
salmon_ | dshulyak: I don't see update_nodes_info task | 09:46 |
salmon_ | dshulyak: my resource is simple as this: https://bpaste.net/show/318fe2108a09 | 09:47 |
dshulyak | salmon_: https://github.com/openstack/fuel-library/blob/master/deployment/puppet/osnailyfacter/modular/astute/tasks.yaml#L24 | 09:47 |
salmon_ | dshulyak: it's upload not update | 09:47 |
dshulyak | salmon_: can we merge it? | 09:48 |
salmon_ | dshulyak: this resource? | 09:48 |
dshulyak | yes | 09:48 |
salmon_ | one moment | 09:48 |
salmon_ | dshulyak: btw. you need to rebase this one https://github.com/Mirantis/f2s/pull/6 | 09:52 |
salmon_ | dshulyak: https://github.com/Mirantis/f2s/pull/8 | 09:53 |
salmon_ | dshulyak: what's tasks_directory? | 10:16 |
dshulyak | salmon_: tasks connections and metadata are stored in different data structures to reduce size of data | 10:17 |
salmon_ | dshulyak: rsync_core_puppet is in tasks_directory, but it's not in tasks_graph | 10:21 |
dshulyak | thats bad | 10:22 |
salmon_ | yup, and this task is crucial :) | 10:22 |
dshulyak | salmon_: are u sure? because i have it in graph | 10:23 |
dshulyak | {u'type': u'sync', u'requires': [{u'node_id': None, u'name': u'pre_deployment_start'}], u'id': u'rsync_core_puppet', u'required_for': [{u'node_id': None, u'name': u'pre_deployment_end'}]} | 10:23 |
salmon_ | dshulyak: which role did you assigned? | 10:23 |
dshulyak | controller | 10:23 |
dshulyak | it shouldnt depend on role | 10:24 |
dshulyak | that would be even bigger problem :) | 10:24 |
salmon_ | dshulyak: hmm, I have base-os role assigned and this is what I have https://bpaste.net/raw/0f1ed5a6b662 | 10:25 |
dshulyak | strange | 10:27 |
dshulyak | do we have noop resource? | 10:27 |
salmon_ | noop? With handler: none? | 10:28 |
dshulyak | with noop we can avoid generation of stages | 10:28 |
dshulyak | yeah | 10:29 |
salmon_ | you can create one | 10:29 |
-openstackstatus- NOTICE: Gerrit is going to be restarted due to poor performance | 10:38 | |
*** ChanServ changes topic to "Gerrit is going to be restarted due to poor performance" | 10:38 | |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Timestamp comparison in calculating time fixed https://review.openstack.org/286040 | 10:44 |
*** ChanServ changes topic to "#openstack-solar" | 10:44 | |
-openstackstatus- NOTICE: gerrit finished restartign | 10:44 | |
pigmej | mkwiek: this time works ? :D | 10:45 |
mkwiek | yeah, it should ;) | 10:45 |
mkwiek | same issue as with calculating delta | 10:46 |
dshulyak | also we are missing override_configuration resource | 10:46 |
dshulyak | i believe it was added for reexecute_on feature | 10:46 |
pigmej | mkwiek: I don't get this comparsion with <1 | 10:50 |
mkwiek | I wanted to compare these float timestamps to 0 | 10:51 |
mkwiek | but you can't really test floats for equality reliably with "==" or "is" | 10:52 |
mkwiek | so sometimes "0.0" was not equal to "0.0" and it broke | 10:52 |
pigmej | why not int(float(.. ? | 10:53 |
pigmej | I mean, this float < 1 looks weird ;D | 10:53 |
pigmej | it's pretty much the same as int(float) == 0 | 10:53 |
pigmej | but... it looks more strange to me | 10:53 |
mkwiek | it's another option that came to my mind when salmon_ asked for it in review and I asked which one would you guys prefer :) | 10:53 |
mkwiek | so sure, I can cast it to int | 10:54 |
mkwiek | I think it may be more readable anyway | 10:54 |
mkwiek | will submit new patchset | 10:54 |
pigmej | btw what when there will be very fast task? | 10:55 |
pigmej | like noops ? | 10:55 |
salmon_ | dshulyak: is it required for now? | 10:55 |
pigmej | mkwiek: I think it will break then, isn't it? | 10:55 |
mkwiek | pigmej: not really | 10:55 |
pigmej | ah timestamp | 10:56 |
pigmej | ;D | 10:56 |
mkwiek | these are timestamps, so they won't be anywhere near 0 | 10:56 |
mkwiek | unless we GO BACK IN TIME!!! | 10:56 |
mkwiek | :D | 10:56 |
pigmej | 2037 :P | 10:56 |
dshulyak | salmon_: i guess no | 10:56 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Timestamp comparison in calculating time fixed https://review.openstack.org/286040 | 10:58 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Fix riak container nested docker mounts https://review.openstack.org/286501 | 11:04 |
dshulyak | salmon_: take a look https://github.com/Mirantis/f2s/pull/6/files, i will alse upload generated tasks from fresh fuel library | 11:08 |
dshulyak | salmon_: together with this https://github.com/Mirantis/f2s/pull/6/files - graph should be ok, but it is still disconnected from node | 11:10 |
salmon_ | dshulyak: it's the same link | 11:11 |
dshulyak | salmon_: https://github.com/Mirantis/f2s/pull/10 | 11:12 |
salmon_ | dshulyak: is it ready to be merged? | 11:15 |
dshulyak | salmon_: yes, please merge, it is not intergrated with nodes and fuel_data | 11:15 |
salmon_ | ok, merging | 11:15 |
salmon_ | merged | 11:16 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Fix riak container nested docker mounts https://review.openstack.org/286501 | 11:20 |
dshulyak | i will update readme after some work in fuel, so - *fsclient alloc 2 null* will create stage anchors in solar, i think the best would be to connect fuel_data before pre_deployment_start | 11:21 |
dshulyak | 2 is cluster id | 11:21 |
dshulyak | fsclient assoc 2 2 - wil generate full graph based on fuel tasks, but they are not yet connedted to nodes | 11:22 |
dshulyak | salmon_: btw fsclient nodes is working? | 11:22 |
dshulyak | yeah, it seems to work | 11:24 |
*** salmon_1 has joined #openstack-solar | 11:24 | |
mkwiek | can I take this one now: https://bugs.launchpad.net/solar/+bug/1547537 ? | 11:24 |
openstack | Launchpad bug 1547537 in Solar "`solar orch report` yields an error when there are no resources" [Undecided,New] | 11:24 |
*** salmon_ has quit IRC | 11:28 | |
*** salmon_1 is now known as salmon_ | 11:28 | |
pigmej | mkwiek: you can take any bug that is assigned to 0.3.0 | 11:37 |
pigmej | BUT if you take bug you need to fix it :P so choose wisely :P | 11:37 |
mkwiek | sure, will do :) | 11:38 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Describe how to create/use the builder container https://review.openstack.org/286517 | 11:39 |
pigmej | mkwiek: you could also check: https://review.openstack.org/#/c/286517/ | 11:40 |
pigmej | just say that it works for you, before build step, then I will merge that :) | 11:41 |
pigmej | because it works for me (which is sadly rare recently) :D | 11:41 |
mkwiek | ok, give me a minute, I will check it out | 11:42 |
openstackgerrit | Bogdan Dobrelya proposed openstack/solar: Describe how to create/use the builder container https://review.openstack.org/286517 | 11:47 |
pigmej | salmon_: dshulyak Maybe I will release new solar vagrant stuff today ? | 11:57 |
pigmej | and then centos7 + docker stuff + f2s in next release ? | 11:58 |
pigmej | mkwiek: ^ | 11:58 |
pigmej | because, well, current image doesn't work with master | 11:58 |
dshulyak | pigmej: i dont mind | 11:58 |
salmon_ | pigmej: go for it! | 11:59 |
openstackgerrit | Merged openstack/solar: Describe how to create/use the builder container https://review.openstack.org/286517 | 12:05 |
pigmej | yeah always blame others... :P | 12:05 |
dshulyak | who knows what is this error - AttributeError: 'CreatedResources' object has no attribute 'db_obj' ? | 12:58 |
pigmej | oh, you wanted to do something bad with CreatedResources | 12:58 |
pigmej | you probably passed it to connect | 12:58 |
pigmej | or something | 12:58 |
pigmej | vr.create(...) returns CreatedResources | 12:58 |
dshulyak | ok | 12:58 |
pigmej | it's not single resource | 12:58 |
pigmej | you can [int] or [name] | 12:58 |
pigmej | :) | 12:59 |
pigmej | the most frequent fuckup I would say d; | 12:59 |
salmon_ | dshulyak: do you know how refresh_on is working? They are not providing tasks there | 13:04 |
dshulyak | salmon_: there is configs files in nailgun, and reexecute_on acts like subscription to those config files | 13:06 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Solar orch report doesn't fail for empty graph https://review.openstack.org/286571 | 13:07 |
salmon_ | dshulyak: I see, thx | 13:07 |
pigmej | https://bpaste.net/show/da4fa3febef3 | 13:35 |
pigmej | wtf | 13:35 |
dshulyak | pigmej: i think i had to update zeromq | 13:37 |
pigmej | yup | 13:37 |
pigmej | dshulyak: anyway, alexz has some questions about packaging f2s | 13:37 |
pigmej | mkwiek: vagrant@solar-dev:/vagrant$ solar o report | 13:50 |
pigmej | 13:50 | |
pigmej | Nothing to report | 13:50 |
pigmej | Total Delta: 0.0 | 13:50 |
pigmej | Total Time: -inf | 13:50 |
pigmej | :> | 13:50 |
pigmej | rly ? | 13:50 |
dshulyak | salmon_: i’ve got this TemplateAssertionError: no filter named 'to_nice_yaml’, do i need to update smth? | 13:52 |
salmon_ | dshulyak: solar | 13:53 |
salmon_ | dshulyak: https://review.openstack.org/#/c/285449/ | 13:53 |
pigmej | dshulyak: that's my awesome hack | 13:57 |
pigmej | :D | 13:57 |
pigmej | salmon_: I don't think taht's this one | 13:57 |
dshulyak | now it works | 13:57 |
salmon_ | pigmej: https://review.openstack.org/#/c/285449/2/solar/utils.py | 13:57 |
dshulyak | :( we have problems with anchors | 13:57 |
pigmej | anchors ? | 13:58 |
dshulyak | noop resources | 13:58 |
salmon_ | dshulyak: why? | 13:58 |
dshulyak | they should be added to each deployment | 13:58 |
salmon_ | :/ | 13:59 |
pigmej | why? | 13:59 |
dshulyak | because this is like backbone of workflow in fuel | 14:00 |
dshulyak | and we cannot stage and commit them :) because each next time graph will be disjoined | 14:00 |
mkwiek | pigmej: I wasn't sure if we want to leave it, but I guess not. You are right, I should have removed it. | 14:04 |
pigmej | oh cmon we shouldn't display wrong information :D | 14:04 |
pigmej | if it would say 0 maybe :P | 14:04 |
pigmej | but -inf ?:D | 14:04 |
openstackgerrit | Maciej Kwiek proposed openstack/solar: Solar orch report doesn't fail for empty graph https://review.openstack.org/286571 | 14:10 |
dshulyak | and also we dont have a way to pass timeouts and retries from resource to orchestration :( | 14:20 |
salmon_ | dshulyak: https://github.com/Mirantis/f2s/pull/11 | 14:25 |
salmon_ | dshulyak: why do you want to pass it to orchestration? Can not we use it in resource? | 14:25 |
salmon_ | or, handler | 14:25 |
mkwiek | Hey guys, can I mark this bug https://bugs.launchpad.net/solar/+bug/1546497 as "Fix committed" as this patch was merged in https://review.openstack.org/#/c/283054/3 ? | 14:28 |
openstack | Launchpad bug 1546497 in Solar "Relax solar requirements" [High,Confirmed] - Assigned to Maciej Kwiek (maciej-iai) | 14:28 |
dshulyak | salmon_: yes, maybe it would be better to use them in handler, but still we dont have any interface for that | 14:29 |
pigmej | mkwiek: yeah | 14:30 |
salmon_ | dshulyak: not yet! | 14:30 |
mkwiek | salmon_: can you shed some light on exact scenario to reproduce this one: https://bugs.launchpad.net/solar/+bug/1549312 ? | 14:45 |
openstack | Launchpad bug 1549312 in Solar "AttributeError: PENDING_RETRY" [Undecided,New] | 14:45 |
dshulyak | salmon_: i added nodes and role_data integration https://github.com/Mirantis/f2s/pull/12/files | 14:46 |
salmon_ | mkwiek: "When running solar orch stop" | 14:49 |
mkwiek | salmon_: do you get it every time you run this, without even providing uid? | 14:49 |
pigmej | mkwiek: when you not provide uid then you will get 'last' from file | 14:50 |
salmon_ | mkwiek: I tried it once, maybe with uid. I don't remember :( | 14:50 |
salmon_ | mkwiek: variable is undefined there, I checked the code | 14:50 |
mkwiek | pigmej: I get this when I run just `solar orch stop` | 14:51 |
mkwiek | Usage: solar orch stop [OPTIONS] UID | 14:51 |
mkwiek | Error: Missing argument "uid". | 14:51 |
pigmej | oh | 14:52 |
pigmej | then you can submit PR that eanbles 'last' :) | 14:52 |
pigmej | (you just need to make uid a special type) | 14:52 |
salmon_ | dshulyak: did you deploy something with it? | 14:52 |
dshulyak | salmon_: not yet | 14:53 |
dshulyak | i also found bug in graph building | 14:54 |
mkwiek | pigmej: 'last' from what file? I don't follow | 14:55 |
pigmej | mkwiek: that 'last' is a bit hacky I would say, we inspect when you craete new uid via CLI (and only there), then we store it in file | 14:55 |
pigmej | and when you use command that requires uid, we usually (!) default that argument to last, then we have some special click type which translates 'last' to correct uid | 14:56 |
salmon_ | mkwiek: so I got with provided uid | 14:56 |
salmon_ | dshulyak: I will play with it today later | 14:58 |
mkwiek | pigmej: ok, I think I understand. I will check how it's implemented in other commands | 14:59 |
pigmej | yeah but that's just start :) because then you need to switch to original bug; P | 14:59 |
mkwiek | salmon_: is PENDING_RETRY a state that we want to have in code? or was it dropped? | 15:09 |
pigmej | mkwiek: it should be a question to dshulyak | 15:09 |
mkwiek | dshulyak then: is PENDING_RETRY a state that we want to have in code? or was it dropped? | 15:09 |
mkwiek | :) | 15:09 |
salmon_ | yup, dshulyak knows :) | 15:10 |
mkwiek | I gotta go now guys, I will ask dshulyak tomorrow :) | 15:11 |
mkwiek | have a nice afternoon, see you tomorrow :) | 15:12 |
dshulyak | mkwiek: i think it used in scheduler module | 15:16 |
pigmej | dshulyak: it doesn't exists :D | 15:16 |
dshulyak | ? | 15:16 |
pigmej | there is only one occurence of PENDING_RETRY in whole code | 15:17 |
dshulyak | ah | 15:18 |
dshulyak | it should be ERROR_RETRY, it is not fixed in soft_stop | 15:18 |
*** salmon_ has quit IRC | 15:18 | |
openstackgerrit | Dmitry Shulyak proposed openstack/solar: Insert missing events during build of staged graph https://review.openstack.org/286665 | 15:44 |
pigmej | dshulyak: what are these 'missing events' ? | 15:44 |
dshulyak | i dont how to anwer your question :) | 15:45 |
pigmej | how do you catch it, and where is bug for it ? | 15:45 |
pigmej | :) | 15:45 |
dshulyak | i will do that stuff later | 15:46 |
pigmej | btw dshulyak that's a neat bug.. ;/ | 15:47 |
pigmej | anyway, I need to test changes from bogdando I may be logged out, I will be back if so :D | 15:54 |
*** salmon_ has joined #openstack-solar | 17:42 | |
*** openstackgerrit has quit IRC | 18:18 | |
*** openstackgerrit has joined #openstack-solar | 18:18 | |
openstackgerrit | Artem Silenkov proposed openstack/solar: solar.spec install path fixed https://review.openstack.org/286762 | 18:31 |
*** evgenyl_ has joined #openstack-solar | 18:31 | |
*** evgenyl has quit IRC | 18:37 | |
*** evgenyl_ is now known as evgenyl | 18:37 | |
*** openstack has joined #openstack-solar | 19:15 | |
*** openstackstatus has joined #openstack-solar | 19:17 | |
*** ChanServ sets mode: +v openstackstatus | 19:17 | |
*** openstackgerrit has joined #openstack-solar | 19:19 | |
*** ikalnitsky has quit IRC | 19:25 | |
*** ikalnitsky has joined #openstack-solar | 19:31 | |
openstackgerrit | Merged openstack/solar: solar.spec install path fixed https://review.openstack.org/286762 | 20:12 |
*** dshulyak has quit IRC | 21:43 | |
*** dshulyak has joined #openstack-solar | 21:44 | |
*** dshulyak has quit IRC | 21:48 | |
*** dshulyak has joined #openstack-solar | 22:14 | |
*** dshulyak has quit IRC | 22:19 | |
*** angdraug has quit IRC | 22:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!