*** sbfox has joined #openstack-trove | 00:01 | |
*** sbfox has quit IRC | 00:04 | |
*** michael-yu has quit IRC | 00:13 | |
*** Barker has joined #openstack-trove | 00:22 | |
*** michael-yu has joined #openstack-trove | 00:24 | |
*** Hao has joined #openstack-trove | 00:25 | |
*** IvanZ has quit IRC | 00:25 | |
*** Hao has quit IRC | 00:29 | |
*** matsuhashi has joined #openstack-trove | 00:31 | |
*** mattgriffin has quit IRC | 00:40 | |
*** michael-yu has quit IRC | 00:52 | |
*** matsuhashi has quit IRC | 00:56 | |
*** matsuhashi has joined #openstack-trove | 01:05 | |
*** ViswaV_ has quit IRC | 01:09 | |
*** haomaiw__ has joined #openstack-trove | 01:12 | |
*** haomaiwa_ has quit IRC | 01:12 | |
*** kevinconway has quit IRC | 01:26 | |
*** eghobo has quit IRC | 01:28 | |
*** nosnos has joined #openstack-trove | 01:29 | |
*** mattgriffin has joined #openstack-trove | 01:37 | |
*** Barker has quit IRC | 01:41 | |
*** haomaiw__ has quit IRC | 01:47 | |
*** haomaiwa_ has joined #openstack-trove | 01:47 | |
*** ramashri_ has quit IRC | 02:02 | |
*** haomaiw__ has joined #openstack-trove | 02:06 | |
*** Hao has joined #openstack-trove | 02:07 | |
*** haomaiwa_ has quit IRC | 02:09 | |
*** Hao has quit IRC | 02:11 | |
*** coolsvap has joined #openstack-trove | 02:33 | |
*** demorris has joined #openstack-trove | 02:34 | |
*** kevinconway has joined #openstack-trove | 02:37 | |
*** achampio1 has joined #openstack-trove | 02:44 | |
*** achampion has quit IRC | 02:46 | |
*** Hao has joined #openstack-trove | 02:50 | |
*** Hao has quit IRC | 02:52 | |
hub_cap | juice: arent u glad u didnt do a ton of work??? | 02:58 |
---|---|---|
*** ramashri has joined #openstack-trove | 02:58 | |
*** matsuhashi has quit IRC | 03:12 | |
*** harlowja is now known as harlowja_away | 03:12 | |
*** coolsvap has quit IRC | 03:12 | |
*** kevinconway has quit IRC | 03:19 | |
*** eghobo has joined #openstack-trove | 03:19 | |
*** nosnos has quit IRC | 03:26 | |
*** coolsvap1 has joined #openstack-trove | 03:27 | |
*** coolsvap has joined #openstack-trove | 03:28 | |
*** amcrn has quit IRC | 03:30 | |
*** achampion has joined #openstack-trove | 03:46 | |
*** achampio1 has quit IRC | 03:48 | |
*** ViswaV has joined #openstack-trove | 03:57 | |
*** ViswaV_ has joined #openstack-trove | 03:58 | |
*** ViswaV has quit IRC | 04:01 | |
*** matsuhashi has joined #openstack-trove | 04:24 | |
*** nosnos has joined #openstack-trove | 04:25 | |
*** saurabhs has left #openstack-trove | 04:28 | |
*** demorris has quit IRC | 04:32 | |
*** ramashri has quit IRC | 04:41 | |
*** matsuhashi has quit IRC | 04:42 | |
juice | whatchyou talkin' bout hub_cap? | 04:46 |
juice | hub_cap: you talking about the ML? | 04:47 |
hub_cap | yar | 04:47 |
hub_cap | looks like the problem was solved for us :) | 04:48 |
juice | yessa | 04:48 |
hub_cap | already heh | 04:48 |
juice | pretty much | 04:48 |
hub_cap | horray for the BP meetings | 04:48 |
juice | would be nice to get it extended to secgroups | 04:48 |
hub_cap | ++ | 04:48 |
juice | indeed | 04:48 |
hub_cap | just do it ;) | 04:48 |
juice | good point - though it requires a db schema change | 04:49 |
juice | not sure what their policy is about backward's compatibility | 04:49 |
* hub_cap runs, arms flailing | 04:49 | |
juice | :) | 04:49 |
juice | on another topic, have you listened to Chance the Rapper? | 04:50 |
*** matsuhashi has joined #openstack-trove | 04:50 | |
juice | he has a free album off his site | 04:50 |
juice | give it a spin | 04:50 |
hub_cap | i will | 04:53 |
hub_cap | i was just talkin about luniz earlier today | 04:53 |
hub_cap | i miss 90s hip hop | 04:53 |
hub_cap | it was soo... perfect | 04:54 |
juice | back when it was innocent :) | 04:54 |
hub_cap | heh, and the beats were great | 04:54 |
hub_cap | and not overengineered | 04:54 |
*** sgotliv has joined #openstack-trove | 04:55 | |
*** amytron has joined #openstack-trove | 04:56 | |
juice | well let me know what you think of chance | 04:56 |
hub_cap | k, ill dl it now and jam tomorrow | 04:58 |
hub_cap | acid rap? | 04:59 |
hub_cap | dman he will be in sfo in like awk | 04:59 |
hub_cap | prolly sold out | 04:59 |
juice | you should go | 05:01 |
juice | supposed to be a great show | 05:01 |
juice | hmmm wonder how much a flight is... | 05:01 |
hub_cap | prolly < 200 | 05:01 |
hub_cap | yea but im married w kids now | 05:01 |
hub_cap | 2 yrs ago, id be there | 05:02 |
juice | :) | 05:02 |
juice | ok old man :) | 05:02 |
hub_cap | now ill bounce to it via my expensive headset | 05:02 |
hub_cap | whatevs single man | 05:02 |
juice | probably not for long ;) | 05:02 |
hub_cap | ok watchin silicone valley , first ep is Minimal Viable Product | 05:02 |
hub_cap | NIIIIECE | 05:02 |
juice | enjoy - i'll let you know if anything further develops | 05:03 |
mattgriffin | hub_cap, is there a list of things that will be the focus of juno? i think i have a partial list from conversations | 05:05 |
*** amytron has quit IRC | 05:35 | |
hub_cap | not really mattgriffin and ill defer to SlickNik, our juno ptl :) | 05:36 |
mattgriffin | hub_cap, ok. SlickNik - you around? | 05:37 |
*** SnowDust has joined #openstack-trove | 05:57 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 06:17 |
openstackgerrit | Jenkins proposed a change to openstack/trove: Imported Translations from Transifex https://review.openstack.org/82721 | 06:21 |
*** eghobo has quit IRC | 06:22 | |
*** yogesh has joined #openstack-trove | 06:28 | |
*** esp has left #openstack-trove | 06:33 | |
*** sgotliv has quit IRC | 06:40 | |
*** sgotliv has joined #openstack-trove | 06:41 | |
*** haomaiw__ has quit IRC | 06:47 | |
*** sgotliv has quit IRC | 06:57 | |
*** ViswaV_ has quit IRC | 07:01 | |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for TM https://review.openstack.org/86242 | 07:04 |
openstackgerrit | Steve Leon proposed a change to openstack/trove: Make storage strategy available for TM https://review.openstack.org/86242 | 07:05 |
*** flaper87|afk is now known as flaper87 | 07:06 | |
*** haomaiwang has joined #openstack-trove | 07:10 | |
*** SnowDust has quit IRC | 07:12 | |
*** matsuhashi has quit IRC | 07:29 | |
*** coolsvap is now known as coolsvap_away | 07:30 | |
*** matsuhashi has joined #openstack-trove | 07:31 | |
*** mattgriffin has quit IRC | 07:32 | |
*** matsuhashi has quit IRC | 07:35 | |
*** coolsvap_away is now known as coolsvap | 07:41 | |
*** matsuhashi has joined #openstack-trove | 07:49 | |
*** sgotliv has joined #openstack-trove | 08:08 | |
sgotliv | Guys, is there any place where I can get an image with trove guestagent installed? | 08:15 |
*** yogesh has quit IRC | 08:46 | |
*** coolsvap is now known as coolsvap|afk | 08:52 | |
openstackgerrit | Deepika Goswami proposed a change to openstack/trove: Incorrect error message- user-access-revoke API https://review.openstack.org/86258 | 08:56 |
*** coolsvap|afk is now known as coolsvap | 09:05 | |
*** haomaiw__ has joined #openstack-trove | 09:18 | |
*** haomaiwang has quit IRC | 09:20 | |
*** haomaiw__ has quit IRC | 09:39 | |
*** haomaiwa_ has joined #openstack-trove | 09:40 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Provide network manager interface https://review.openstack.org/86031 | 09:44 |
*** dmakogon_ is now known as denis_makogon | 09:44 | |
denis_makogon | sgotliv, ping | 09:44 |
sgotliv | denis_makogon, hi | 09:44 |
denis_makogon | sgotliv, you should do it by your one | 09:44 |
sgotliv | denis_makogon, I am a smart guy, I already realized that | 09:45 |
*** matsuhas_ has joined #openstack-trove | 09:45 | |
denis_makogon | sgotliv, if you are familiar with heat jeos you could create your own custom image | 09:45 |
*** matsuhashi has quit IRC | 09:45 | |
*** matsuhas_ has quit IRC | 09:45 | |
sgotliv | denis_makogon, look since yesterday I spent 8 hours to install it on my VM and still nothing | 09:46 |
*** matsuhashi has joined #openstack-trove | 09:46 | |
*** haomaiw__ has joined #openstack-trove | 09:55 | |
*** haomaiwa_ has quit IRC | 09:57 | |
*** matsuhashi has quit IRC | 10:12 | |
*** matsuhashi has joined #openstack-trove | 10:16 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Provide network manager interface https://review.openstack.org/86031 | 10:20 |
*** coolsvap is now known as coolsvap|afk | 10:38 | |
*** sgotliv has quit IRC | 10:46 | |
*** matsuhashi has quit IRC | 11:05 | |
*** matsuhashi has joined #openstack-trove | 11:05 | |
*** matsuhashi has quit IRC | 11:19 | |
*** sgotliv has joined #openstack-trove | 11:26 | |
*** matsuhashi has joined #openstack-trove | 11:36 | |
*** matsuhashi has quit IRC | 11:39 | |
*** Tushar_1 has joined #openstack-trove | 11:42 | |
*** Tushar_1 has quit IRC | 11:46 | |
*** coolsvap|afk is now known as coolsvap | 11:57 | |
*** sgotliv has quit IRC | 12:08 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 12:09 |
*** demorris has joined #openstack-trove | 12:14 | |
*** pdmars has joined #openstack-trove | 12:20 | |
*** sgotliv has joined #openstack-trove | 12:23 | |
*** achampion has quit IRC | 12:33 | |
*** radez_g0n3 is now known as radez | 12:38 | |
*** demorris has quit IRC | 12:46 | |
*** grapex has joined #openstack-trove | 13:12 | |
*** nosnos has quit IRC | 13:14 | |
*** grapex has quit IRC | 13:17 | |
*** grapex has joined #openstack-trove | 13:17 | |
*** coolsvap is now known as coolsvap|afk | 13:18 | |
*** coolsvap|afk is now known as coolsvap | 13:20 | |
*** coolsvap is now known as coolsvap|afk | 13:22 | |
*** Hao has joined #openstack-trove | 13:22 | |
openstackgerrit | Denis M. proposed a change to openstack/trove: Add backup size validation at restoring https://review.openstack.org/86300 | 13:33 |
*** jcru has joined #openstack-trove | 13:36 | |
*** freyes has joined #openstack-trove | 13:40 | |
*** Barker has joined #openstack-trove | 13:43 | |
*** denis_makogon has quit IRC | 13:44 | |
*** robertmyers has joined #openstack-trove | 13:47 | |
*** Barker has quit IRC | 13:49 | |
*** achampion has joined #openstack-trove | 14:03 | |
*** amytron has joined #openstack-trove | 14:04 | |
*** mattgriffin has joined #openstack-trove | 14:08 | |
*** demorris has joined #openstack-trove | 14:09 | |
*** Barker has joined #openstack-trove | 14:12 | |
*** kevinconway has joined #openstack-trove | 14:17 | |
*** thedodd has joined #openstack-trove | 14:22 | |
*** kevinconway has quit IRC | 14:23 | |
*** kevinconway has joined #openstack-trove | 14:25 | |
*** saju_m has joined #openstack-trove | 14:26 | |
*** radez is now known as radez_g0n3 | 14:28 | |
*** radez_g0n3 is now known as radez | 14:31 | |
cp16net | SlickNik: BTW we have some docs in review for trove now... https://review.openstack.org/#/c/85803 | 14:46 |
*** shivamshukla has joined #openstack-trove | 14:47 | |
*** coolsvap|afk is now known as coolsvap | 14:48 | |
openstackgerrit | Kaleb Pomeroy proposed a change to openstack/trove: Implements datastore capabilities https://review.openstack.org/83503 | 14:50 |
*** saju_m has quit IRC | 14:58 | |
*** Barker has quit IRC | 14:58 | |
*** Barker has joined #openstack-trove | 15:01 | |
*** Barker has quit IRC | 15:03 | |
*** Barker has joined #openstack-trove | 15:07 | |
*** ramashri has joined #openstack-trove | 15:24 | |
*** ramashri has quit IRC | 15:24 | |
*** flaper87 is now known as flaper87|afk | 15:25 | |
*** sgotliv has quit IRC | 15:29 | |
*** Barker has quit IRC | 15:31 | |
*** radez is now known as radez_g0n3 | 15:33 | |
*** ViswaV has joined #openstack-trove | 15:34 | |
*** ViswaV_ has joined #openstack-trove | 15:35 | |
*** jmontemayor has joined #openstack-trove | 15:38 | |
*** Barker has joined #openstack-trove | 15:38 | |
*** ViswaV has quit IRC | 15:38 | |
*** shivamshukla has quit IRC | 15:43 | |
*** ViswaV_ has quit IRC | 15:52 | |
*** eghobo has joined #openstack-trove | 15:52 | |
*** ramashri has joined #openstack-trove | 15:55 | |
*** radez_g0n3 is now known as radez | 15:56 | |
*** ramashri has quit IRC | 15:59 | |
*** freyes has quit IRC | 16:07 | |
k-pom | devs: https://review.openstack.org/#/c/83503/ has one plus two, waiting for approval | 16:08 |
k-pom | if someone could review that I'd appreciate it | 16:08 |
hub_cap | k-pom: what is devs: ? | 16:09 |
hub_cap | the openstack trove core devs dont hilight on that ;) | 16:09 |
k-pom | ah, switched my IRC rroms | 16:09 |
hub_cap | amcrn SlickNik vipul ^ ^ | 16:09 |
k-pom | *rooms | 16:09 |
hub_cap | :P | 16:09 |
hub_cap | i know.. its fun to poke at you in the public tho heh | 16:10 |
hub_cap | k-pom: have we gone over this bp in the review process yet? | 16:10 |
k-pom | at the mid cycle | 16:10 |
hub_cap | ive been gone for 1 of them | 16:10 |
k-pom | we discussed it | 16:10 |
hub_cap | ok we might still need to approve it at a monday meeting, can u add it to the list? | 16:11 |
k-pom | I don't know that we've discussed it since then | 16:11 |
hub_cap | ok we need to then | 16:11 |
hub_cap | put it on the top o the list for monday | 16:11 |
k-pom | where is that list? | 16:11 |
hub_cap | https://wiki.openstack.org/wiki/Meetings/TroveMeeting | 16:11 |
robertmyers | k-pom: I think your BP have the wrong definition for ephemeral volume | 16:11 |
robertmyers | that does not use cinder AFAIK | 16:12 |
hub_cap | k-pom: put yours on the top | 16:12 |
hub_cap | Agenda for Apr. 14 (blueprint meeting) | 16:12 |
hub_cap | yea i agree w robertmyers on that | 16:13 |
*** ramashri has joined #openstack-trove | 16:15 | |
*** denis_makogon has joined #openstack-trove | 16:17 | |
*** ramashri has quit IRC | 16:19 | |
*** ramashri has joined #openstack-trove | 16:21 | |
k-pom | Fixed the wiki to use "volume_support" and added it to the blueprint discussion for monday | 16:26 |
hub_cap | thx k-pom | 16:28 |
denis_makogon | robertmyers, ping =) | 16:30 |
*** ramashri has quit IRC | 16:38 | |
*** ramashri_ has joined #openstack-trove | 16:38 | |
*** ramashri_ has quit IRC | 16:42 | |
*** harlowja_away is now known as harlowja | 16:49 | |
*** radez is now known as radez_g0n3 | 16:55 | |
*** ramashri has joined #openstack-trove | 16:56 | |
*** Hao has quit IRC | 16:56 | |
*** freyes has joined #openstack-trove | 16:57 | |
*** ramashri_ has joined #openstack-trove | 17:02 | |
*** ramashri has quit IRC | 17:02 | |
*** amcrn has joined #openstack-trove | 17:03 | |
*** ramashri_ has quit IRC | 17:06 | |
*** ramashri has joined #openstack-trove | 17:06 | |
*** ramashri has quit IRC | 17:08 | |
*** ramashri has joined #openstack-trove | 17:08 | |
*** ramashri has quit IRC | 17:09 | |
*** ramashri has joined #openstack-trove | 17:10 | |
*** ramashri_ has joined #openstack-trove | 17:11 | |
*** ramashri_ has quit IRC | 17:11 | |
*** ramashri_ has joined #openstack-trove | 17:12 | |
*** yogesh has joined #openstack-trove | 17:12 | |
*** ramashri_ has quit IRC | 17:13 | |
*** ramashri_ has joined #openstack-trove | 17:13 | |
*** ramashri has quit IRC | 17:14 | |
*** ramashri_ has quit IRC | 17:16 | |
*** ramashri has joined #openstack-trove | 17:16 | |
*** coolsvap is now known as coolsvap|afk | 17:18 | |
*** yogesh_ has joined #openstack-trove | 17:19 | |
*** ramashri has quit IRC | 17:20 | |
*** yogesh has quit IRC | 17:22 | |
*** esp has joined #openstack-trove | 17:23 | |
*** eguz has joined #openstack-trove | 17:32 | |
robertmyers | denis_makogon: pong | 17:32 |
esp | hub_cap: ping | 17:33 |
denis_makogon | robertmyers, i update the BP, could you take a look at it after the meeting | 17:33 |
robertmyers | sure | 17:34 |
*** thedodd has quit IRC | 17:36 | |
*** eghobo has quit IRC | 17:36 | |
denis_makogon | robertmyers, thanks | 17:36 |
hub_cap | hey esp kinda around, fighting something internal, sup | 17:37 |
esp | hub_cap: np, I had a question about rpc-versioning. I’m just reading this https://wiki.openstack.org/wiki/Oslo/Messaging | 17:38 |
esp | will hit you guys up later :) | 17:38 |
hub_cap | sry man | 17:39 |
esp | hub_cap: np | 17:39 |
*** michael-yu has joined #openstack-trove | 17:41 | |
*** yogesh_ has quit IRC | 17:51 | |
*** yogesh has joined #openstack-trove | 17:51 | |
*** yogesh has quit IRC | 17:55 | |
SlickNik | meeting in #openstack-meetings-alt in ~2 minutes. | 17:57 |
SlickNik | #openstack-meeting-alt* | 17:57 |
*** rramirez has joined #openstack-trove | 17:58 | |
*** dougshelley66 has left #openstack-trove | 18:01 | |
*** dougshelley66 has joined #openstack-trove | 18:01 | |
*** saurabhs has joined #openstack-trove | 18:06 | |
*** jasonb365 has joined #openstack-trove | 18:06 | |
*** yogeshmehra has joined #openstack-trove | 18:09 | |
*** NehaV has joined #openstack-trove | 18:12 | |
*** sbfox has joined #openstack-trove | 18:13 | |
*** freyes has quit IRC | 18:15 | |
*** thedodd has joined #openstack-trove | 18:20 | |
denis_makogon | cp16net, ping | 18:21 |
cp16net | denis_makogon: yea? | 18:22 |
denis_makogon | cp16net, saw your comments on https://review.openstack.org/#/c/86300 | 18:22 |
*** yogeshmehra has quit IRC | 18:22 | |
denis_makogon | cp16net, about testing, it's cannot be done inside the integration, can be verified manually | 18:22 |
denis_makogon | cp16net, because we eventually hit the gate timeouts | 18:23 |
cp16net | thats why i said unit or init | 18:24 |
denis_makogon | cp16net, units - possibly, but do we have tests for restore ? | 18:25 |
cp16net | yes | 18:26 |
denis_makogon | cp16net, i mean units | 18:26 |
cp16net | umm not sure | 18:26 |
denis_makogon | cp16net, please point me | 18:26 |
denis_makogon | cp16net, i would say that it's a formal check i tests are not required, they are optional | 18:27 |
*** yogesh has joined #openstack-trove | 18:27 | |
denis_makogon | cp16net, so, do you agree ? | 18:29 |
*** ViswaV has joined #openstack-trove | 18:49 | |
*** ViswaV_ has joined #openstack-trove | 18:49 | |
denis_makogon | robertmyers, so, waiting the response from you =) | 18:52 |
*** ViswaV has quit IRC | 18:53 | |
robertmyers | denis_makogon: It looks good, however the guest rpc should not be needed | 18:53 |
robertmyers | basically it will be a normal create call that is prepopulated | 18:54 |
denis_makogon | robertmyers, ah, yes, right | 18:54 |
denis_makogon | robertmyers, let me fix it right now | 18:54 |
robertmyers | I would say also just go with /{tenant}/instances/{id}/restore | 18:55 |
cp16net | denis_makogon: i see some unit test in there | 18:56 |
cp16net | for restoring | 18:56 |
denis_makogon | cp16net, please show | 18:56 |
robertmyers | denis_makogon: possibly, make the date an optional parameter, so by default the latest backup is picked | 18:56 |
cp16net | https://github.com/openstack/trove/blob/master/trove/tests/unittests/backup/test_backupagent.py#L322 | 18:57 |
robertmyers | denis_makogon: so just POST /{tenant}/instances/{id}/restore {date: somedate} | 18:57 |
*** yogesh has quit IRC | 18:58 | |
denis_makogon | cp16net, this tests for the guest functionality | 18:58 |
*** yogesh has joined #openstack-trove | 18:58 | |
denis_makogon | cp16net, they have nothing common with api servie | 18:58 |
denis_makogon | *service | 18:58 |
denis_makogon | robertmyers, fixed | 18:58 |
denis_makogon | robertmyers, anything else ? | 18:58 |
robertmyers | I think that was it, it does seem a little wordy, so you might just edit out a few lines | 18:59 |
robertmyers | but it is good | 18:59 |
*** sgotliv has joined #openstack-trove | 19:01 | |
denis_makogon | robertmyers, could you also take a look at https://wiki.openstack.org/wiki/Trove/volume-data-snapshot-design | 19:01 |
robertmyers | denis_makogon: looking | 19:01 |
denis_makogon | robertmyers, what do you mean wordy ? | 19:01 |
denis_makogon | robertmyers, to many text ?)) | 19:02 |
*** yogesh has quit IRC | 19:03 | |
robertmyers | denis_makogon: yes, the introduction is a little redundant, as the goal of the blue print is pretty straight forward | 19:03 |
robertmyers | you could almost cut out the top section and start with the justification | 19:04 |
cp16net | denis_makogon: how can we make sure that the size change you made doesnt break now or in the future? | 19:04 |
cp16net | its functionality that needs to be tested | 19:05 |
*** pdmars has quit IRC | 19:06 | |
denis_makogon | cp16net, ok, i'll try to look what can be done here, but as for me, this fix is really flat, test suit setup code will take like 20-30 lines, to test the this that was missed long time ago | 19:07 |
*** SnowDust has joined #openstack-trove | 19:07 | |
robertmyers | denis_makogon: I'm confused with the configuration section of the volume snapshot blueprint. I'm not user what you are saying as the default and available are swapped | 19:08 |
robertmyers | denis_makogon: I'd also like to see the work flow listed in the BP | 19:09 |
robertmyers | 1. (implement this) flush database to disk and place in read only mode | 19:10 |
robertmyers | 2. run cinder snapshot (backup) | 19:10 |
robertmyers | 3. turn database writes back on | 19:10 |
robertmyers | also you'll need a recover workflow listed | 19:11 |
robertmyers | I think 1 above might need to be a new method on all datastore impls | 19:12 |
denis_makogon | robertmyers, didn't understand about configuration section | 19:12 |
robertmyers | you have default cinder, swift and available swift, cinder | 19:13 |
robertmyers | so I'm not sure what you are saying | 19:13 |
denis_makogon | robertmyers, volume snapshot is common for all datastores, so, do you really think that config attrs should be specific per datastore | 19:13 |
robertmyers | denis_makogon: no, I'm saying the flush db and readonly mode | 19:14 |
denis_makogon | ah | 19:14 |
robertmyers | that *is* specific | 19:14 |
denis_makogon | get it | 19:14 |
*** jmontemayor has quit IRC | 19:14 | |
denis_makogon | robertmyers, what about recovery process | 19:17 |
denis_makogon | so, lets say, cinder failed to create the snapshot | 19:17 |
denis_makogon | for us it's like - no problem, lets mark it as ERROR and thats all | 19:17 |
robertmyers | then the backup should be marked as failed | 19:18 |
robertmyers | the recovery I'm talking about is the happy path | 19:18 |
robertmyers | asuming everything worked, what is the workflow to restore the cinder snapshot | 19:19 |
denis_makogon | robertmyers, swap the volume | 19:19 |
robertmyers | ok, then put that in the BP | 19:19 |
denis_makogon | robertmyers, first create the volume from the snapshot and swap | 19:19 |
robertmyers | that is what I'm saying | 19:19 |
robertmyers | if the flow is any different we should see | 19:20 |
robertmyers | so that we can approve the BP | 19:20 |
denis_makogon | done | 19:21 |
robertmyers | is it possible that the new volume could be created before the instance? | 19:22 |
robertmyers | making the whole process even faster? | 19:22 |
denis_makogon | for now - no | 19:24 |
denis_makogon | it looks like depenent BP | 19:24 |
denis_makogon | i guess this feature can be done even in parallel | 19:24 |
robertmyers | yeah, thinking about it again, it should probably run thru the guest prepare anyway | 19:24 |
denis_makogon | because we can apply any type of backup to new volume, and then attach it | 19:25 |
robertmyers | all depends on the prepare logic, if it deletes files or anything | 19:25 |
robertmyers | I know it moves files if it sees them in /var/lib/mysql | 19:26 |
*** sbfox has quit IRC | 19:26 | |
robertmyers | so it might be more work than it is worth | 19:26 |
robertmyers | just go with this work flow for now and we'll see if it can be optimized in the review | 19:27 |
denis_makogon | cool | 19:27 |
denis_makogon | robertmyers, lets wait the monday and we'll see what community thinks | 19:27 |
robertmyers | well, yes of course | 19:27 |
robertmyers | I'm not even core | 19:27 |
robertmyers | :) | 19:28 |
robertmyers | but +1 | 19:28 |
*** sbfox has joined #openstack-trove | 19:29 | |
denis_makogon | robertmyers, thanks for the help ! | 19:29 |
denis_makogon | robertmyers, i appriciate your help | 19:30 |
robertmyers | denis_makogon: your welcome | 19:31 |
*** openstackgerrit has quit IRC | 19:34 | |
*** sbfox has quit IRC | 19:34 | |
*** SnowDust has quit IRC | 19:36 | |
*** radez_g0n3 is now known as radez | 19:38 | |
*** openstackgerrit has joined #openstack-trove | 19:42 | |
*** yogeshmehra has joined #openstack-trove | 19:44 | |
*** eguz has quit IRC | 20:07 | |
amrith | denis_makogon ... u around? | 20:07 |
denis_makogon | amrith, yes | 20:07 |
*** eghobo has joined #openstack-trove | 20:07 | |
denis_makogon | amrith, i saw your comments | 20:07 |
amrith | would you help me with https://review.openstack.org/#/c/86300/ | 20:07 |
amrith | what exactly is backup_info.size | 20:08 |
amrith | isn't it is the size in GB of the file from which the backup is coming? | 20:08 |
denis_makogon | amrith, the size backuped data stored in Swift | 20:08 |
amrith | that's what I thought | 20:08 |
amrith | do you see what my issue with the check you are making? | 20:09 |
amrith | does it make sense | 20:09 |
amrith | I agree with the intent of the bug | 20:09 |
denis_makogon | i only agreed that check rule should be backup_info.size > volume_size | 20:09 |
amrith | what I'm having a hard time is how that check makes sense | 20:10 |
amrith | a backup that is larger on disk (SWIFT) could fit just fine in a storage engine that does great compression | 20:10 |
amrith | tokudb has demonstrated 90% compression | 20:10 |
amrith | between the size of the xtradb backup and the on disk storage | 20:11 |
amrith | your test would prevent a user restoring that | 20:11 |
denis_makogon | amcrn, we're talking about ubuntu | 20:11 |
amrith | no? | 20:11 |
amrith | sorry, what's the question? | 20:11 |
amrith | tokudb is a storage engine for MySQL | 20:11 |
amrith | runs fine on Ubuntu | 20:11 |
denis_makogon | ah, sorry, misunderstood | 20:12 |
amrith | it is shipped with percona server | 20:12 |
amrith | and mariaDB | 20:12 |
denis_makogon | backup size is the actual size of the xtrabackup stream | 20:12 |
amrith | on the swift disk | 20:12 |
denis_makogon | no | 20:12 |
amrith | not on the disk used ONCE it gets into MySQL | 20:12 |
denis_makogon | it counts on guest side | 20:12 |
denis_makogon | before pushing it to the Swift | 20:12 |
amrith | I'm missing that | 20:13 |
amrith | you said earlier that it is "the size backuped data stored in swift" | 20:13 |
*** yogesh has joined #openstack-trove | 20:13 | |
denis_makogon | correcting myself | 20:13 |
denis_makogon | just look at the code | 20:13 |
denis_makogon | and you'll se | 20:13 |
denis_makogon | *see | 20:13 |
amrith | please help me understand where | 20:13 |
amrith | I don't see it | 20:13 |
amrith | (and I'm the first to confess, I'm new) | 20:14 |
hub_cap | heh yea denis_makogon , show him where in the code, u just dont tell people to "look at the code" | 20:14 |
denis_makogon | amrith, what the thing you cannot understand ? | 20:14 |
hub_cap | u show them in the gist | 20:14 |
*** NehaV1 has joined #openstack-trove | 20:14 | |
hub_cap | or in a github url | 20:14 |
amrith | what I cannot understand is where in the code I can see that 'size' is being set to the size of data on the guest side of the system being backed up. | 20:15 |
amrith | you claim (correcting yourself above) that 'size' is the size of data on the guest size | 20:15 |
amrith | in the database | 20:15 |
*** ViswaV_ has quit IRC | 20:15 | |
*** openstackstatus has quit IRC | 20:15 | |
amrith | I submit to you that what I see is that 'size' is the size of the backup file on SWIFT | 20:15 |
denis_makogon | amrith, https://github.com/openstack/trove/blob/master/trove/guestagent/backup/backupagent.py#L93-L95 | 20:15 |
amrith | I submit to you that you can compare the two numbers but the comparison is somewhat pointless | 20:16 |
hub_cap | im pretty darn sure amrith is right | 20:16 |
hub_cap | is the size of the dump'd file, right robertmyers ? | 20:16 |
*** openstackstatus has joined #openstack-trove | 20:16 | |
denis_makogon | hub_cap, no, take a look at link that i posted | 20:17 |
robertmyers | hub_cap: no | 20:17 |
robertmyers | it is the volume used | 20:17 |
denis_makogon | hub_cap, size is the size of the actual data that used at volume | 20:17 |
*** NehaV has quit IRC | 20:17 | |
amrith | the code indicate that it is the used size of the volume mounted | 20:17 |
robertmyers | So the idea is that the backup will use that much at least when it is restored | 20:17 |
*** yogesh has quit IRC | 20:18 | |
denis_makogon | robertmyers, please review, https://review.openstack.org/#/c/86300/ | 20:19 |
denis_makogon | the whole idea is to block user from the provisioning with restoring if bakup is way to big than flavor root disk or the volume size | 20:20 |
denis_makogon | amrith, are you still there ? | 20:22 |
hub_cap | denis_makogon: is size an int just showing the GBs? im just curious | 20:23 |
hub_cap | so if the volume_stats['used'] was 3.22 will it show 3, 4, or 3.22 ? | 20:23 |
hub_cap | i assume the whole ting right? ( cp16net 's "int" comment confused me) | 20:24 |
robertmyers | I think it is a float | 20:24 |
hub_cap | thx robertmyers | 20:25 |
robertmyers | so, we probably should compare floats | 20:25 |
robertmyers | I'll comment | 20:25 |
hub_cap | right | 20:25 |
hub_cap | thx | 20:25 |
hub_cap | robertmyers: >>> float(3.0000000000000000001) > int(3) | 20:27 |
hub_cap | thats False in python :P | 20:27 |
amcrn | shouldn't there be some fudge factor added in? | 20:27 |
hub_cap | peanut butter fudge factor amcrn ? | 20:27 |
*** yogeshmehra has quit IRC | 20:27 | |
amcrn | i.e. if it's 1.99999 and the volume is 2, you're going to have a good ol' time. | 20:27 |
hub_cap | yea u get to write 1 row amcrn | 20:28 |
hub_cap | but then again... should we care? | 20:28 |
amrith | denis: yes | 20:28 |
amcrn | hub_cap: we should | 20:28 |
hub_cap | robertmyers: nm wha ti said, plz comment my brain is not there | 20:28 |
denis_makogon | hub_cap, of course, sinse we allow restoring from any backup | 20:28 |
hub_cap | i mean do we care if they are eqal or not | 20:28 |
amrith | would this code also run on ther guest agents? | 20:28 |
amrith | no; i assume not? | 20:28 |
robertmyers | this is api | 20:29 |
hub_cap | naw amrith | 20:29 |
robertmyers | before the guest is involved | 20:29 |
amcrn | personally, i'd like to see a CONF.min_disk_left like concept | 20:29 |
amcrn | because certain datastores like to spray around quite a few temporary files before actually starting | 20:29 |
hub_cap | thats sensible amcrn | 20:31 |
amrith | denis: looking at the code you provided (thanks) it does look like size is the size of the data on the file system of the system being backed up. I will revert my comments; thanks. | 20:32 |
robertmyers | amcrn: sure, the actual restore may be smaller | 20:32 |
robertmyers | but 10gb will probably not fit in 1gb | 20:33 |
robertmyers | soo we should fail before we go and create a ton of resources | 20:33 |
denis_makogon | agreed | 20:34 |
*** ViswaV has joined #openstack-trove | 20:34 | |
amcrn | robertmyers: one example i'm thinking of (and i might be wrong here) is if you install mongodb with smallfiles off, it auto-creates roughly 2GB of files on-disk. If you have a mongodb backup, and say it's 1.5GB, then restoring that to a new instance with a 2GB volume very well might fail. | 20:34 |
robertmyers | amcrn: we are storing the size on disk as the backup size | 20:35 |
robertmyers | or the volume used | 20:35 |
amcrn | understood | 20:36 |
*** harlowja is now known as harlowja_away | 20:36 | |
hub_cap | what about mysq, 1.999999 gb used, restore to 2g, 1hr later, bam, instance full, now people are freaking | 20:36 |
hub_cap | any datastore really | 20:36 |
amcrn | correct | 20:36 |
hub_cap | let the operator say, ehhh 500mb fudge factor | 20:36 |
amrith | denis_makogon: I have changed my review to +0. I'm not wild about this change because I'm not comfortable using file system size as an indication of how much space is required on disk. Things like deleted records and things of that nature come to mind | 20:36 |
amrith | I believe that this is a reasonable first step | 20:36 |
amcrn | also, you're not accounting for the disk space taken after the datastore has initialized (irrespective of backup or no backup) | 20:36 |
amrith | it also does not account for other things that may be on the same mount point | 20:37 |
amrith | that are not part of the backup | 20:37 |
*** michael-yu has quit IRC | 20:37 | |
robertmyers | so we (rax) have had a number of people run out of disk space on the volume and it is bad | 20:37 |
amrith | but as stated the code does what you intended it to do. I don't think it is a complete solution but it is at least a partial solution | 20:37 |
robertmyers | horrible things happen | 20:37 |
robertmyers | so we *should* find a way in trove to notify people | 20:38 |
robertmyers | but that is another story | 20:38 |
amrith | see: http://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk-space-after-deleting-data-rows-from-table | 20:38 |
amrith | but I will let others decide whether to let this move forward or not; I'm still unsure about it | 20:39 |
robertmyers | amrith: we do use file per table | 20:39 |
robertmyers | so, that helps | 20:39 |
hub_cap | im curious to know if thatll creep into a dump tho | 20:39 |
amrith | oh, it helps | 20:39 |
amrith | but only if you backup, drop and recreate the table | 20:40 |
amcrn | robertmyers: so, are you against adding a CONF.minimum_disk_left_after_restore? i.e. if you set that to 2, then that means if the backup if 5GB, and the volume is 6.0GB, that 6.0 - 5 - 2 < 0, so it doesn't allow it. | 20:40 |
amrith | robertmyers: a delete won't free up space; file_per_table or not | 20:40 |
amcrn | backup is* | 20:40 |
robertmyers | amrith: I know of the issues of using the volume used, just we don't have any other good way to say how small the data will be after a restore | 20:41 |
robertmyers | amcrn: I might be for it | 20:42 |
amrith | robertmyers: understood. My issue was solely with the fact that I wanted to convince myself that .size was in fact size on disk in the database, not size on SWIFT | 20:42 |
amrith | robertmyers: denis showed me the code; I'm annoyed that I couldn't find it myself, but he showed me what I was looking for | 20:42 |
amrith | robertmyers: my question is answered. | 20:42 |
robertmyers | cool | 20:42 |
amrith | denis: you there? | 20:43 |
amrith | did you see my comments above? | 20:44 |
amrith | denis_makogon: u there? | 20:44 |
robertmyers | amcrn: actually it might be overkill, especially in testing, say you have a small test DB that is << 1GB than you could only restore to a 3GB volume | 20:47 |
amcrn | robertmyers: sure, but the default would either be 0 or 1 | 20:47 |
amcrn | then in my production environments i'd set it ridiculously high for tier 0 use-cases | 20:47 |
robertmyers | yeah, well even then your customers might hate you | 20:47 |
amrith | ;) | 20:48 |
hub_cap | .05 | 20:49 |
hub_cap | fixed :) | 20:49 |
denis_makogon | amrith, i'm still here | 20:49 |
amrith | denis: u see my comments above? | 20:49 |
amrith | thx for the pointer | 20:49 |
denis_makogon | amrith, i guess =) | 20:50 |
denis_makogon | amcrn, robertmyers so what about bringing the CONF.get(datastore).minimum_disk_left_after_restore ? | 20:50 |
denis_makogon | it seems valid | 20:50 |
hub_cap | denis_makogon: seperate BP i think | 20:51 |
denis_makogon | hub_cap, right | 20:51 |
denis_makogon | and what about current fix ? | 20:51 |
robertmyers | denis_makogon: I jsut have the one comment about floating point math | 20:52 |
hub_cap | minor nits denis_makogon | 20:52 |
robertmyers | possibly we should round up | 20:52 |
denis_makogon | robertmyers, ah, i see, thanks | 20:52 |
denis_makogon | there's another lifehack | 20:52 |
robertmyers | it *might* not be an issue | 20:52 |
robertmyers | but I've been burned by floats | 20:52 |
denis_makogon | we could check how long is the str(backup.size) | 20:52 |
denis_makogon | and then prepare flavor disk or volume support to look like backup size | 20:53 |
robertmyers | ? | 20:53 |
denis_makogon | if backup size equals to 0.845, volume size should look like 2.000 | 20:53 |
robertmyers | joking? | 20:53 |
robertmyers | volume is an int | 20:54 |
denis_makogon | yes | 20:54 |
denis_makogon | right | 20:54 |
*** harlowja_away is now known as harlowja | 20:55 | |
denis_makogon | (%s.%s) % (volume_size, "0"*len(str(backup.size)) | 20:55 |
hub_cap | ceil(backup.size) <= flavor.size | 20:55 |
hub_cap | thats what u need, nothign more | 20:56 |
robertmyers | hub_cap: +1 | 20:56 |
*** pdmars has joined #openstack-trove | 20:56 | |
*** kevinconway has quit IRC | 20:57 | |
hub_cap | https://gist.github.com/hub-cap/10314743 | 20:57 |
hub_cap | simple as that (of course fudge_factor will be in a diff BP) | 20:57 |
hub_cap | i have no idea waht the len () thing is all about | 20:57 |
amrith | wait a second | 20:57 |
amrith | size is also an int | 20:57 |
robertmyers | no | 20:58 |
robertmyers | it is a float | 20:58 |
amrith | so this whole float thing may be moot ;) | 20:58 |
hub_cap | which size? | 20:58 |
hub_cap | backup.size or flavor.size? | 20:58 |
robertmyers | backup.size is a float | 20:58 |
amrith | backup_info.size | 20:58 |
hub_cap | lets be specific so my head doesnt explode :P | 20:58 |
amrith | really | 20:58 |
robertmyers | yes | 20:58 |
denis_makogon | volume size is an int, backup size is a float, flavor roo disk size int | 20:58 |
robertmyers | amrith: https://github.com/openstack/trove/blob/master/trove/guestagent/dbaas.py#L57 | 21:00 |
hub_cap | used_gb = to_gb(total - free) | 21:00 |
robertmyers | bytes/ 1024.0 ** 3 gives you a float | 21:01 |
robertmyers | since you are dividing by a float | 21:01 |
amrith | yup | 21:01 |
amrith | yup | 21:01 |
amrith | I was looking at free | 21:01 |
amrith | never mind | 21:01 |
hub_cap | cool, so lets go w/ math.ceil() and we have no issues | 21:01 |
robertmyers | done | 21:01 |
amrith | +1 | 21:01 |
cp16net | amrith: you asked me about the change for local-infile | 21:02 |
*** iccha has quit IRC | 21:02 | |
amrith | yessir | 21:02 |
cp16net | so a dba mentioned that the global scope variable should be named as local_infile with _ and not - | 21:03 |
*** rramirez has quit IRC | 21:03 | |
amrith | oh, ok | 21:04 |
amrith | i think dougshelley66 has other concerns as well | 21:04 |
cp16net | the thing that sucks with how mysql params are set is that we set them with the client with one name but the conf file sets them with another name | 21:04 |
dougshelley66 | i put my question on the bug | 21:04 |
cp16net | this is kinda the problem we have with this variable in particular | 21:04 |
*** michael-yu has joined #openstack-trove | 21:04 | |
hub_cap | cp16net: FAIL | 21:05 |
hub_cap | good ole mysql | 21:05 |
amrith | never fails to amaze | 21:05 |
cp16net | hub_cap: yup | 21:05 |
amrith | hub_cap: you've met monty, no? | 21:05 |
amrith | not taylor, the other one | 21:05 |
amrith | the mysql ne | 21:05 |
amrith | s/ne/one/ | 21:05 |
amrith | crap, got to run. goodbye all ... | 21:06 |
cp16net | peace amrith | 21:07 |
*** kevinconway has joined #openstack-trove | 21:07 | |
*** iccha has joined #openstack-trove | 21:08 | |
hub_cap | wiedenes or whatever | 21:09 |
hub_cap | amrith: ^ ^ | 21:09 |
hub_cap | yea i have amrith, we met about maria last yr | 21:09 |
*** rueb7363 has joined #openstack-trove | 21:09 | |
*** rueb7363 has quit IRC | 21:10 | |
*** rueb7363 has joined #openstack-trove | 21:10 | |
*** eghobo has quit IRC | 21:12 | |
esmute | Hi reviewers, would like to get this reviewed if you have anytime https://review.openstack.org/#/c/81379/? Should be short and quick | 21:12 |
*** openstackstatus has quit IRC | 21:14 | |
*** openstackstatus has joined #openstack-trove | 21:22 | |
peterstac | denis_makogon: I've added a blueprint for the Trove client formatting changes | 21:24 |
peterstac | denis_makogon: if you want to take a look: https://blueprints.launchpad.net/trove/+spec/emulate-osc-in-python-troveclient | 21:24 |
denis_makogon | peterstac, nice, what about other projects ? | 21:25 |
*** ramashri has joined #openstack-trove | 21:25 | |
peterstac | denis_makogon: You can look at other projects too :) | 21:26 |
denis_makogon | peterstac, i've got another scope of tasks =) | 21:26 |
denis_makogon | peterstac, but, seriously, i think you should try to talk with other teams to see what they think about the common policy related to shell outputs | 21:27 |
*** sgotliv has quit IRC | 21:27 | |
peterstac | denis_makogon: Looks like that will be wrapped in the OSC project, but they're still a little vague in output formats | 21:28 |
*** thedodd has quit IRC | 21:30 | |
robertmyers | how is the troveclient different? they both use pretty table | 21:30 |
denis_makogon | peterstac, that's the problem OSC is the another client, cloud client, i bet that devs. will decide to re-invent the wheel and create their own format for output | 21:30 |
denis_makogon | robertmyers, aligning, etc. | 21:30 |
denis_makogon | robertmyers, https://blueprints.launchpad.net/trove/+spec/emulate-osc-in-python-troveclient | 21:30 |
robertmyers | aligning what? | 21:30 |
*** Barker has quit IRC | 21:30 | |
denis_makogon | robertmyers, align content inside the pretty tables, i guess | 21:31 |
robertmyers | that looks like prettytables output | 21:31 |
hub_cap | hey peterstac i assume this is in every -client project? | 21:31 |
denis_makogon | hub_cap, i guess, it's not, but, yet | 21:31 |
denis_makogon | robertmyers, i think i'll help more https://wiki.openstack.org/wiki/Trove-Client-Look-And-Feel | 21:32 |
*** thedodd has joined #openstack-trove | 21:32 | |
hub_cap | hmm im not sure i a fan of this :) | 21:32 |
robertmyers | denis_makogon: Well, this seems like a waste of time | 21:32 |
robertmyers | it is a lot of work for a tiny change I bet | 21:32 |
denis_makogon | robertmyers, hub_cap, for now - yes, agreed | 21:32 |
robertmyers | possibly errors | 21:33 |
denis_makogon | robertmyers, you can't know until you try =) | 21:33 |
hub_cap | yea what prompted this? | 21:33 |
robertmyers | denis_makogon: we have better things to do with our time | 21:33 |
robertmyers | like actually deliver features | 21:33 |
denis_makogon | robertmyers, hah, lol, of course= )) | 21:33 |
robertmyers | we should focus on the project | 21:34 |
robertmyers | make it better not look better | 21:34 |
denis_makogon | robertmyers, what if this is the first contributor into the trove | 21:34 |
robertmyers | fix docs | 21:34 |
denis_makogon | robertmyers, it's like misspell corrections | 21:34 |
robertmyers | fix one of the N number of real bugs | 21:34 |
denis_makogon | robertmyers, at least one, but yes, i feel the same | 21:35 |
robertmyers | the point is we need to move trove forward | 21:35 |
robertmyers | :) | 21:35 |
denis_makogon | btw, does anyone rides the sport bikes ? | 21:38 |
denis_makogon | annashen, ping | 21:40 |
denis_makogon | annashen, are you there ? | 21:40 |
annashen | denis_makogon: pong | 21:44 |
annashen | so, about blueprint | 21:44 |
denis_makogon | annashen, let's deal with it | 21:44 |
annashen | #link https://wiki.openstack.org/wiki/Trove/neutron-support | 21:44 |
denis_makogon | annashen, i already saw that, https://review.openstack.org/#/c/86031/ <- hope you saw this too | 21:45 |
denis_makogon | annashen, i made what i proposed | 21:46 |
denis_makogon | annashen, so, now, we can move forwad with tuning redstack to have multiple networks | 21:46 |
denis_makogon | annashen, and then you can write neutron manager | 21:46 |
peterstac | hub_cap: not sure what you mean by 'every -client project' but they all have capitalized headers, etc. | 21:46 |
denis_makogon | annashen, does it works for you ? | 21:47 |
peterstac | This wasn't to create work, just to get my feet wet with the process - didn't want it to suck up everyone's time | 21:47 |
annashen | denis_makogon, how soon can you make all the tests for the patch you mentioned above? | 21:47 |
denis_makogon | peterstac, hub_cap means the same as i said: "Is this change the part of common initiative?" | 21:47 |
denis_makogon | annashen, tests, which? | 21:48 |
peterstac | denis_makogon, hub_cap: No, this change would only be in python-troveclient | 21:48 |
annashen | i will post my comments soon on the patch also, denis_makogon | 21:48 |
denis_makogon | annashen, i made this layer to fit to the current requirements | 21:48 |
denis_makogon | annashen, sounds great | 21:48 |
denis_makogon | annashen, with my patch trove works with nova-network manager, your task, i suppose, write the neutron driver, right ? | 21:49 |
*** grapex has quit IRC | 21:49 | |
denis_makogon | michael-yu, ping | 21:51 |
robertmyers | peterstac: sorry to shoot you down, but i still think it is not worth our time to fix the output of prettytable | 21:51 |
robertmyers | peterstac: especially if another group is just going to rewrite the whole thing | 21:51 |
robertmyers | let them do it | 21:51 |
peterstac | robertmyers: It took hardly any time to fix the output - writing the blueprint/wiki on the other hand | 21:52 |
michael-yu | denis_makogon: yes | 21:52 |
robertmyers | peterstac: well, how does that effect the way the --json works | 21:52 |
robertmyers | I'm just concerned with breaking things | 21:52 |
robertmyers | to make it look good | 21:53 |
denis_makogon | michael-yu, saw your patch for horizon, i've got bug report that already been marked as High, no need to use BP | 21:53 |
robertmyers | peterstac: I hate prettytables too | 21:53 |
*** demorris has quit IRC | 21:53 | |
denis_makogon | michael-yu, https://bugs.launchpad.net/horizon/+bug/1298451 | 21:53 |
peterstac | robertmyers: it shouldn't affect --json, but let me quickly test | 21:53 |
denis_makogon | denis_makogon, use this one because you probably will waste a lot of time to get it approved, or David can approve it ? | 21:54 |
peterstac | robertmyers: Just verified - doesn't change --json at all | 21:54 |
robertmyers | peterstac: fine, but still, I think we should focus on bugs and features | 21:55 |
robertmyers | :) | 21:55 |
denis_makogon | robertmyers, correct | 21:55 |
robertmyers | we have a huge backlog | 21:55 |
robertmyers | it is only getting longer | 21:55 |
amcrn | denis_makogon: it's a blueprint, and the blueprint filing predates your bug by at least 2 months | 21:55 |
robertmyers | and all i see is noise | 21:55 |
peterstac | robertmyers: I agree - I'm working on the Tempest tests, but noticed this and thought to use it as a way to get familiar with the process | 21:56 |
denis_makogon | amcrn, does david-lyle or other cores approved it ? | 21:56 |
denis_makogon | amcrn, it seems like not | 21:56 |
peterstac | robertmyers: Along with making us look more like other CLI's | 21:56 |
amcrn | denis_makogon: your point being? | 21:56 |
denis_makogon | amcrn, i'm just suggesting the more easiest way | 21:57 |
robertmyers | peterstac: All I ask is wait for the BP to be approved before you submit a review | 21:57 |
amcrn | denis_makogon: it isn't a bug, by definition it should be a blueprint. | 21:57 |
denis_makogon | amcrn, no need to wait until BP get reviewed | 21:57 |
robertmyers | that goes for everyone | 21:57 |
robertmyers | denis_makogon: I'm looking at you ;) | 21:57 |
peterstac | robertmyers: Sure, not a problem | 21:57 |
denis_makogon | robertmyers, what do you mean ? | 21:58 |
robertmyers | don't submit reviews until the bp is approved | 21:59 |
robertmyers | we all need to follow the rules | 21:59 |
robertmyers | cause we shave a small team | 21:59 |
robertmyers | and the backlog is getting too big | 21:59 |
robertmyers | anyway, I have to run | 22:00 |
*** robertmyers has quit IRC | 22:00 | |
*** NehaV1 has quit IRC | 22:03 | |
*** denis_makogon has quit IRC | 22:12 | |
*** thedodd has quit IRC | 22:15 | |
*** jasonb365 has quit IRC | 22:19 | |
openstackgerrit | Dan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy https://review.openstack.org/85225 | 22:21 |
*** openstack has joined #openstack-trove | 22:33 | |
*** mattgriffin has quit IRC | 22:37 | |
*** rueb7363 has quit IRC | 22:38 | |
*** kevinconway has quit IRC | 22:40 | |
*** ViswaV has quit IRC | 22:46 | |
*** khyati_ has joined #openstack-trove | 22:52 | |
*** ramashri has quit IRC | 22:53 | |
*** jcru has quit IRC | 22:56 | |
*** ViswaV has joined #openstack-trove | 23:08 | |
*** achampion has joined #openstack-trove | 23:34 | |
*** Barker has joined #openstack-trove | 23:49 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!