Wednesday, 2014-04-09

*** sbfox has joined #openstack-trove00:01
*** sbfox has quit IRC00:04
*** michael-yu has quit IRC00:13
*** Barker has joined #openstack-trove00:22
*** michael-yu has joined #openstack-trove00:24
*** Hao has joined #openstack-trove00:25
*** IvanZ has quit IRC00:25
*** Hao has quit IRC00:29
*** matsuhashi has joined #openstack-trove00:31
*** mattgriffin has quit IRC00:40
*** michael-yu has quit IRC00:52
*** matsuhashi has quit IRC00:56
*** matsuhashi has joined #openstack-trove01:05
*** ViswaV_ has quit IRC01:09
*** haomaiw__ has joined #openstack-trove01:12
*** haomaiwa_ has quit IRC01:12
*** kevinconway has quit IRC01:26
*** eghobo has quit IRC01:28
*** nosnos has joined #openstack-trove01:29
*** mattgriffin has joined #openstack-trove01:37
*** Barker has quit IRC01:41
*** haomaiw__ has quit IRC01:47
*** haomaiwa_ has joined #openstack-trove01:47
*** ramashri_ has quit IRC02:02
*** haomaiw__ has joined #openstack-trove02:06
*** Hao has joined #openstack-trove02:07
*** haomaiwa_ has quit IRC02:09
*** Hao has quit IRC02:11
*** coolsvap has joined #openstack-trove02:33
*** demorris has joined #openstack-trove02:34
*** kevinconway has joined #openstack-trove02:37
*** achampio1 has joined #openstack-trove02:44
*** achampion has quit IRC02:46
*** Hao has joined #openstack-trove02:50
*** Hao has quit IRC02:52
hub_capjuice: arent u glad u didnt do a ton of work???02:58
*** ramashri has joined #openstack-trove02:58
*** matsuhashi has quit IRC03:12
*** harlowja is now known as harlowja_away03:12
*** coolsvap has quit IRC03:12
*** kevinconway has quit IRC03:19
*** eghobo has joined #openstack-trove03:19
*** nosnos has quit IRC03:26
*** coolsvap1 has joined #openstack-trove03:27
*** coolsvap has joined #openstack-trove03:28
*** amcrn has quit IRC03:30
*** achampion has joined #openstack-trove03:46
*** achampio1 has quit IRC03:48
*** ViswaV has joined #openstack-trove03:57
*** ViswaV_ has joined #openstack-trove03:58
*** ViswaV has quit IRC04:01
*** matsuhashi has joined #openstack-trove04:24
*** nosnos has joined #openstack-trove04:25
*** saurabhs has left #openstack-trove04:28
*** demorris has quit IRC04:32
*** ramashri has quit IRC04:41
*** matsuhashi has quit IRC04:42
juicewhatchyou talkin' bout hub_cap?04:46
juicehub_cap: you talking about the ML?04:47
hub_capyar04:47
hub_caplooks like the problem was solved for us :)04:48
juiceyessa04:48
hub_capalready heh04:48
juicepretty much04:48
hub_caphorray for the BP meetings04:48
juicewould be nice to get it extended to secgroups04:48
hub_cap++04:48
juiceindeed04:48
hub_capjust do it ;)04:48
juicegood point - though it requires a db schema change04:49
juicenot sure what their policy is about backward's compatibility04:49
* hub_cap runs, arms flailing04:49
juice:)04:49
juiceon another topic, have you listened to Chance the Rapper?04:50
*** matsuhashi has joined #openstack-trove04:50
juicehe has a free album off his site04:50
juicegive it a spin04:50
hub_capi will04:53
hub_capi was just talkin about luniz earlier today04:53
hub_capi miss 90s hip hop04:53
hub_capit was soo... perfect04:54
juiceback when it was innocent :)04:54
hub_capheh, and the beats were great04:54
hub_capand not overengineered04:54
*** sgotliv has joined #openstack-trove04:55
*** amytron has joined #openstack-trove04:56
juicewell let me know what you think of chance04:56
hub_capk, ill dl it now and jam tomorrow04:58
hub_capacid rap?04:59
hub_capdman he will be in sfo in like  awk04:59
hub_capprolly sold out04:59
juiceyou should go05:01
juicesupposed to be a great show05:01
juicehmmm wonder how much a flight is...05:01
hub_capprolly < 20005:01
hub_capyea but im married w kids now05:01
hub_cap2 yrs ago, id be there05:02
juice:)05:02
juiceok old man :)05:02
hub_capnow ill bounce to it via my expensive headset05:02
hub_capwhatevs single man05:02
juiceprobably not for long ;)05:02
hub_capok watchin silicone valley , first ep is Minimal Viable Product05:02
hub_capNIIIIECE05:02
juiceenjoy - i'll let you know if anything further develops05:03
mattgriffinhub_cap, is there a list of things that will be the focus of juno? i think i have a partial list from conversations05:05
*** amytron has quit IRC05:35
hub_capnot really mattgriffin and ill defer to SlickNik, our juno ptl :)05:36
mattgriffinhub_cap, ok. SlickNik - you around?05:37
*** SnowDust has joined #openstack-trove05:57
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522506:17
openstackgerritJenkins proposed a change to openstack/trove: Imported Translations from Transifex  https://review.openstack.org/8272106:21
*** eghobo has quit IRC06:22
*** yogesh has joined #openstack-trove06:28
*** esp has left #openstack-trove06:33
*** sgotliv has quit IRC06:40
*** sgotliv has joined #openstack-trove06:41
*** haomaiw__ has quit IRC06:47
*** sgotliv has quit IRC06:57
*** ViswaV_ has quit IRC07:01
openstackgerritSteve Leon proposed a change to openstack/trove: Make storage strategy available for TM  https://review.openstack.org/8624207:04
openstackgerritSteve Leon proposed a change to openstack/trove: Make storage strategy available for TM  https://review.openstack.org/8624207:05
*** flaper87|afk is now known as flaper8707:06
*** haomaiwang has joined #openstack-trove07:10
*** SnowDust has quit IRC07:12
*** matsuhashi has quit IRC07:29
*** coolsvap is now known as coolsvap_away07:30
*** matsuhashi has joined #openstack-trove07:31
*** mattgriffin has quit IRC07:32
*** matsuhashi has quit IRC07:35
*** coolsvap_away is now known as coolsvap07:41
*** matsuhashi has joined #openstack-trove07:49
*** sgotliv has joined #openstack-trove08:08
sgotlivGuys, is there any place where I can get an image with trove guestagent installed?08:15
*** yogesh has quit IRC08:46
*** coolsvap is now known as coolsvap|afk08:52
openstackgerritDeepika Goswami proposed a change to openstack/trove: Incorrect error message- user-access-revoke API  https://review.openstack.org/8625808:56
*** coolsvap|afk is now known as coolsvap09:05
*** haomaiw__ has joined #openstack-trove09:18
*** haomaiwang has quit IRC09:20
*** haomaiw__ has quit IRC09:39
*** haomaiwa_ has joined #openstack-trove09:40
openstackgerritDenis M. proposed a change to openstack/trove: Provide network manager interface  https://review.openstack.org/8603109:44
*** dmakogon_ is now known as denis_makogon09:44
denis_makogonsgotliv, ping09:44
sgotlivdenis_makogon, hi09:44
denis_makogonsgotliv, you should do it by your one09:44
sgotlivdenis_makogon, I am a smart guy, I already realized that09:45
*** matsuhas_ has joined #openstack-trove09:45
denis_makogonsgotliv, if you are familiar with heat jeos you could create your own custom image09:45
*** matsuhashi has quit IRC09:45
*** matsuhas_ has quit IRC09:45
sgotlivdenis_makogon, look since yesterday I spent 8 hours to install it on my VM and still nothing09:46
*** matsuhashi has joined #openstack-trove09:46
*** haomaiw__ has joined #openstack-trove09:55
*** haomaiwa_ has quit IRC09:57
*** matsuhashi has quit IRC10:12
*** matsuhashi has joined #openstack-trove10:16
openstackgerritDenis M. proposed a change to openstack/trove: Provide network manager interface  https://review.openstack.org/8603110:20
*** coolsvap is now known as coolsvap|afk10:38
*** sgotliv has quit IRC10:46
*** matsuhashi has quit IRC11:05
*** matsuhashi has joined #openstack-trove11:05
*** matsuhashi has quit IRC11:19
*** sgotliv has joined #openstack-trove11:26
*** matsuhashi has joined #openstack-trove11:36
*** matsuhashi has quit IRC11:39
*** Tushar_1 has joined #openstack-trove11:42
*** Tushar_1 has quit IRC11:46
*** coolsvap|afk is now known as coolsvap11:57
*** sgotliv has quit IRC12:08
openstackgerritDenis M. proposed a change to openstack/trove: Add backup size validation at restoring  https://review.openstack.org/8630012:09
*** demorris has joined #openstack-trove12:14
*** pdmars has joined #openstack-trove12:20
*** sgotliv has joined #openstack-trove12:23
*** achampion has quit IRC12:33
*** radez_g0n3 is now known as radez12:38
*** demorris has quit IRC12:46
*** grapex has joined #openstack-trove13:12
*** nosnos has quit IRC13:14
*** grapex has quit IRC13:17
*** grapex has joined #openstack-trove13:17
*** coolsvap is now known as coolsvap|afk13:18
*** coolsvap|afk is now known as coolsvap13:20
*** coolsvap is now known as coolsvap|afk13:22
*** Hao has joined #openstack-trove13:22
openstackgerritDenis M. proposed a change to openstack/trove: Add backup size validation at restoring  https://review.openstack.org/8630013:33
*** jcru has joined #openstack-trove13:36
*** freyes has joined #openstack-trove13:40
*** Barker has joined #openstack-trove13:43
*** denis_makogon has quit IRC13:44
*** robertmyers has joined #openstack-trove13:47
*** Barker has quit IRC13:49
*** achampion has joined #openstack-trove14:03
*** amytron has joined #openstack-trove14:04
*** mattgriffin has joined #openstack-trove14:08
*** demorris has joined #openstack-trove14:09
*** Barker has joined #openstack-trove14:12
*** kevinconway has joined #openstack-trove14:17
*** thedodd has joined #openstack-trove14:22
*** kevinconway has quit IRC14:23
*** kevinconway has joined #openstack-trove14:25
*** saju_m has joined #openstack-trove14:26
*** radez is now known as radez_g0n314:28
*** radez_g0n3 is now known as radez14:31
cp16netSlickNik: BTW we have some docs in review for trove now... https://review.openstack.org/#/c/8580314:46
*** shivamshukla has joined #openstack-trove14:47
*** coolsvap|afk is now known as coolsvap14:48
openstackgerritKaleb Pomeroy proposed a change to openstack/trove: Implements datastore capabilities  https://review.openstack.org/8350314:50
*** saju_m has quit IRC14:58
*** Barker has quit IRC14:58
*** Barker has joined #openstack-trove15:01
*** Barker has quit IRC15:03
*** Barker has joined #openstack-trove15:07
*** ramashri has joined #openstack-trove15:24
*** ramashri has quit IRC15:24
*** flaper87 is now known as flaper87|afk15:25
*** sgotliv has quit IRC15:29
*** Barker has quit IRC15:31
*** radez is now known as radez_g0n315:33
*** ViswaV has joined #openstack-trove15:34
*** ViswaV_ has joined #openstack-trove15:35
*** jmontemayor has joined #openstack-trove15:38
*** Barker has joined #openstack-trove15:38
*** ViswaV has quit IRC15:38
*** shivamshukla has quit IRC15:43
*** ViswaV_ has quit IRC15:52
*** eghobo has joined #openstack-trove15:52
*** ramashri has joined #openstack-trove15:55
*** radez_g0n3 is now known as radez15:56
*** ramashri has quit IRC15:59
*** freyes has quit IRC16:07
k-pomdevs: https://review.openstack.org/#/c/83503/ has one plus two, waiting for approval16:08
k-pomif someone could review that I'd appreciate it16:08
hub_capk-pom: what is devs: ?16:09
hub_capthe openstack trove core devs dont hilight on that ;)16:09
k-pomah, switched my IRC rroms16:09
hub_capamcrn SlickNik vipul ^  ^16:09
k-pom*rooms16:09
hub_cap:P16:09
hub_capi know.. its fun to poke at you in the public tho heh16:10
hub_capk-pom: have we gone over this bp in the review process yet?16:10
k-pomat the mid cycle16:10
hub_capive been gone for 1 of them16:10
k-pomwe discussed it16:10
hub_capok we might still need to approve it at a monday meeting, can u add it to the list?16:11
k-pomI don't know that we've discussed it since then16:11
hub_capok we need to then16:11
hub_capput it on the top o the list for monday16:11
k-pomwhere is that list?16:11
hub_caphttps://wiki.openstack.org/wiki/Meetings/TroveMeeting16:11
robertmyersk-pom: I think your BP have the wrong definition for ephemeral volume16:11
robertmyersthat does not use cinder AFAIK16:12
hub_capk-pom: put yours on the top16:12
hub_capAgenda for Apr. 14 (blueprint meeting)16:12
hub_capyea i agree w robertmyers on that16:13
*** ramashri has joined #openstack-trove16:15
*** denis_makogon has joined #openstack-trove16:17
*** ramashri has quit IRC16:19
*** ramashri has joined #openstack-trove16:21
k-pomFixed the wiki to use "volume_support" and added it to the blueprint discussion for monday16:26
hub_capthx k-pom16:28
denis_makogonrobertmyers, ping =)16:30
*** ramashri has quit IRC16:38
*** ramashri_ has joined #openstack-trove16:38
*** ramashri_ has quit IRC16:42
*** harlowja_away is now known as harlowja16:49
*** radez is now known as radez_g0n316:55
*** ramashri has joined #openstack-trove16:56
*** Hao has quit IRC16:56
*** freyes has joined #openstack-trove16:57
*** ramashri_ has joined #openstack-trove17:02
*** ramashri has quit IRC17:02
*** amcrn has joined #openstack-trove17:03
*** ramashri_ has quit IRC17:06
*** ramashri has joined #openstack-trove17:06
*** ramashri has quit IRC17:08
*** ramashri has joined #openstack-trove17:08
*** ramashri has quit IRC17:09
*** ramashri has joined #openstack-trove17:10
*** ramashri_ has joined #openstack-trove17:11
*** ramashri_ has quit IRC17:11
*** ramashri_ has joined #openstack-trove17:12
*** yogesh has joined #openstack-trove17:12
*** ramashri_ has quit IRC17:13
*** ramashri_ has joined #openstack-trove17:13
*** ramashri has quit IRC17:14
*** ramashri_ has quit IRC17:16
*** ramashri has joined #openstack-trove17:16
*** coolsvap is now known as coolsvap|afk17:18
*** yogesh_ has joined #openstack-trove17:19
*** ramashri has quit IRC17:20
*** yogesh has quit IRC17:22
*** esp has joined #openstack-trove17:23
*** eguz has joined #openstack-trove17:32
robertmyersdenis_makogon: pong17:32
esphub_cap: ping17:33
denis_makogonrobertmyers, i update the BP, could you take a look at it after the meeting17:33
robertmyerssure17:34
*** thedodd has quit IRC17:36
*** eghobo has quit IRC17:36
denis_makogonrobertmyers, thanks17:36
hub_caphey esp kinda around, fighting something internal, sup17:37
esphub_cap: np, I had a question about rpc-versioning.  I’m just reading this https://wiki.openstack.org/wiki/Oslo/Messaging17:38
espwill hit you guys up later :)17:38
hub_capsry man17:39
esphub_cap: np17:39
*** michael-yu has joined #openstack-trove17:41
*** yogesh_ has quit IRC17:51
*** yogesh has joined #openstack-trove17:51
*** yogesh has quit IRC17:55
SlickNikmeeting in #openstack-meetings-alt in ~2 minutes.17:57
SlickNik#openstack-meeting-alt*17:57
*** rramirez has joined #openstack-trove17:58
*** dougshelley66 has left #openstack-trove18:01
*** dougshelley66 has joined #openstack-trove18:01
*** saurabhs has joined #openstack-trove18:06
*** jasonb365 has joined #openstack-trove18:06
*** yogeshmehra has joined #openstack-trove18:09
*** NehaV has joined #openstack-trove18:12
*** sbfox has joined #openstack-trove18:13
*** freyes has quit IRC18:15
*** thedodd has joined #openstack-trove18:20
denis_makogoncp16net, ping18:21
cp16netdenis_makogon: yea?18:22
denis_makogoncp16net, saw your comments on https://review.openstack.org/#/c/8630018:22
*** yogeshmehra has quit IRC18:22
denis_makogoncp16net, about testing, it's cannot be done inside the integration, can be verified manually18:22
denis_makogoncp16net, because we eventually hit the gate timeouts18:23
cp16netthats why i said unit or init18:24
denis_makogoncp16net, units - possibly, but do we have tests for restore ?18:25
cp16netyes18:26
denis_makogoncp16net, i mean units18:26
cp16netumm not sure18:26
denis_makogoncp16net, please point me18:26
denis_makogoncp16net, i would say that it's a formal check i tests are not required, they are optional18:27
*** yogesh has joined #openstack-trove18:27
denis_makogoncp16net, so, do you agree ?18:29
*** ViswaV has joined #openstack-trove18:49
*** ViswaV_ has joined #openstack-trove18:49
denis_makogonrobertmyers, so, waiting the response from you =)18:52
*** ViswaV has quit IRC18:53
robertmyersdenis_makogon: It looks good, however the guest rpc should not be needed18:53
robertmyersbasically it will be a normal create call that is prepopulated18:54
denis_makogonrobertmyers, ah, yes, right18:54
denis_makogonrobertmyers, let me fix it right now18:54
robertmyersI would say also just go with /{tenant}/instances/{id}/restore18:55
cp16netdenis_makogon: i see some unit test in there18:56
cp16netfor restoring18:56
denis_makogoncp16net, please show18:56
robertmyersdenis_makogon: possibly, make the date an optional parameter, so by default the latest backup is picked18:56
cp16nethttps://github.com/openstack/trove/blob/master/trove/tests/unittests/backup/test_backupagent.py#L32218:57
robertmyersdenis_makogon: so just POST /{tenant}/instances/{id}/restore {date: somedate}18:57
*** yogesh has quit IRC18:58
denis_makogoncp16net, this tests for the guest functionality18:58
*** yogesh has joined #openstack-trove18:58
denis_makogoncp16net, they have nothing common with api servie18:58
denis_makogon*service18:58
denis_makogonrobertmyers, fixed18:58
denis_makogonrobertmyers, anything else ?18:58
robertmyersI think that was it, it does seem a little wordy, so you might just edit out a few lines18:59
robertmyersbut it is good18:59
*** sgotliv has joined #openstack-trove19:01
denis_makogonrobertmyers, could you also take a look at https://wiki.openstack.org/wiki/Trove/volume-data-snapshot-design19:01
robertmyersdenis_makogon: looking19:01
denis_makogonrobertmyers, what do you mean wordy ?19:01
denis_makogonrobertmyers, to many text ?))19:02
*** yogesh has quit IRC19:03
robertmyersdenis_makogon: yes, the introduction is a little redundant, as the goal of the blue print is pretty straight forward19:03
robertmyersyou could almost cut out the top section and start with the justification19:04
cp16netdenis_makogon: how can we make sure that the size change you made doesnt break now or in the future?19:04
cp16netits functionality that needs to be tested19:05
*** pdmars has quit IRC19:06
denis_makogoncp16net, ok, i'll try to look what can be done here, but as for me, this fix is really flat, test suit setup code will take like 20-30 lines, to test the this that was missed long time ago19:07
*** SnowDust has joined #openstack-trove19:07
robertmyersdenis_makogon: I'm confused with the configuration section of the volume snapshot blueprint. I'm not user what you are saying as the default and available are swapped19:08
robertmyersdenis_makogon: I'd also like to see the work flow listed in the BP19:09
robertmyers1. (implement this) flush database to disk and place in read only mode19:10
robertmyers2. run cinder snapshot (backup)19:10
robertmyers3. turn database writes back on19:10
robertmyersalso you'll need a recover workflow listed19:11
robertmyersI think 1 above might need to be a new method on all datastore impls19:12
denis_makogonrobertmyers, didn't understand about configuration section19:12
robertmyersyou have default cinder, swift and available swift, cinder19:13
robertmyersso I'm not sure what you are saying19:13
denis_makogonrobertmyers, volume snapshot is common for all datastores, so, do you really think that config attrs should be specific per datastore19:13
robertmyersdenis_makogon: no, I'm saying the flush db and readonly mode19:14
denis_makogonah19:14
robertmyersthat *is* specific19:14
denis_makogonget it19:14
*** jmontemayor has quit IRC19:14
denis_makogonrobertmyers, what about recovery process19:17
denis_makogonso, lets say, cinder failed to create the snapshot19:17
denis_makogonfor us it's like - no problem, lets mark it as ERROR and thats all19:17
robertmyersthen the backup should be marked as failed19:18
robertmyersthe recovery I'm talking about is the happy path19:18
robertmyersasuming everything worked, what is the workflow to restore the cinder snapshot19:19
denis_makogonrobertmyers, swap the volume19:19
robertmyersok, then put that in the BP19:19
denis_makogonrobertmyers, first create the volume from the snapshot and swap19:19
robertmyersthat is what I'm saying19:19
robertmyersif the flow is any different we should see19:20
robertmyersso that we can approve the BP19:20
denis_makogondone19:21
robertmyersis it possible that the new volume could be created before the instance?19:22
robertmyersmaking the whole process even faster?19:22
denis_makogonfor now - no19:24
denis_makogonit looks like depenent BP19:24
denis_makogoni guess this feature can be done even in parallel19:24
robertmyersyeah, thinking about it again, it should probably run thru the guest prepare anyway19:24
denis_makogonbecause we can apply any type of backup to new volume, and then attach it19:25
robertmyersall depends on the prepare logic, if it deletes files or anything19:25
robertmyersI know it moves files if it sees them in /var/lib/mysql19:26
*** sbfox has quit IRC19:26
robertmyersso it might be more work than it is worth19:26
robertmyersjust go with this work flow for now and we'll see if it can be optimized in the review19:27
denis_makogoncool19:27
denis_makogonrobertmyers, lets wait the monday and we'll see what community thinks19:27
robertmyerswell, yes of course19:27
robertmyersI'm not even core19:27
robertmyers :)19:28
robertmyersbut +119:28
*** sbfox has joined #openstack-trove19:29
denis_makogonrobertmyers, thanks for the help !19:29
denis_makogonrobertmyers, i appriciate your help19:30
robertmyersdenis_makogon: your welcome19:31
*** openstackgerrit has quit IRC19:34
*** sbfox has quit IRC19:34
*** SnowDust has quit IRC19:36
*** radez_g0n3 is now known as radez19:38
*** openstackgerrit has joined #openstack-trove19:42
*** yogeshmehra has joined #openstack-trove19:44
*** eguz has quit IRC20:07
amrithdenis_makogon ... u around?20:07
denis_makogonamrith, yes20:07
*** eghobo has joined #openstack-trove20:07
denis_makogonamrith, i saw your comments20:07
amrithwould you help me with https://review.openstack.org/#/c/86300/20:07
amrithwhat exactly is backup_info.size20:08
amrithisn't it is the size in GB of the file from which the backup is coming?20:08
denis_makogonamrith, the size backuped data stored in Swift20:08
amriththat's what I thought20:08
amrithdo you see what my issue with the check you are making?20:09
amrithdoes it make sense20:09
amrithI agree with the intent of the bug20:09
denis_makogoni only agreed that check rule should be backup_info.size > volume_size20:09
amrithwhat I'm having a hard time is how that check makes sense20:10
amritha backup that is larger on disk (SWIFT) could fit just fine in a storage engine that does great compression20:10
amrithtokudb has demonstrated 90% compression20:10
amrithbetween the size of the xtradb backup and the on disk storage20:11
amrithyour test would prevent a user restoring that20:11
denis_makogonamcrn, we're talking about ubuntu20:11
amrithno?20:11
amrithsorry, what's the question?20:11
amrithtokudb is a storage engine for MySQL20:11
amrithruns fine on Ubuntu20:11
denis_makogonah, sorry, misunderstood20:12
amrithit is shipped with percona server20:12
amrithand mariaDB20:12
denis_makogonbackup size is the actual size of the xtrabackup stream20:12
amrithon the swift disk20:12
denis_makogonno20:12
amrithnot on the disk used ONCE it gets into MySQL20:12
denis_makogonit counts on guest side20:12
denis_makogonbefore pushing it to the Swift20:12
amrithI'm missing that20:13
amrithyou said earlier that it is "the size backuped data stored in swift"20:13
*** yogesh has joined #openstack-trove20:13
denis_makogoncorrecting myself20:13
denis_makogonjust look at the code20:13
denis_makogonand you'll se20:13
denis_makogon*see20:13
amrithplease help me understand where20:13
amrithI don't see it20:13
amrith(and I'm the first to confess, I'm new)20:14
hub_capheh yea denis_makogon , show him where in the code, u just dont tell people to "look at the code"20:14
denis_makogonamrith, what the thing you cannot understand ?20:14
hub_capu show them in the gist20:14
*** NehaV1 has joined #openstack-trove20:14
hub_capor in a github url20:14
amrithwhat I cannot understand is where in the code I can see that 'size' is being set to the size of data on the guest side of the system being backed up.20:15
amrithyou claim (correcting yourself above) that 'size' is the size of data on the guest size20:15
amrithin the database20:15
*** ViswaV_ has quit IRC20:15
*** openstackstatus has quit IRC20:15
amrithI submit to you that what I see is that 'size' is the size of the backup file on SWIFT20:15
denis_makogonamrith, https://github.com/openstack/trove/blob/master/trove/guestagent/backup/backupagent.py#L93-L9520:15
amrithI submit to you that you can compare the two numbers but the comparison is somewhat pointless20:16
hub_capim pretty darn sure amrith is right20:16
hub_capis the size of the dump'd file, right robertmyers ?20:16
*** openstackstatus has joined #openstack-trove20:16
denis_makogonhub_cap, no, take a look at link that i posted20:17
robertmyershub_cap: no20:17
robertmyersit is the volume used20:17
denis_makogonhub_cap, size is the size of the actual data that used at volume20:17
*** NehaV has quit IRC20:17
amriththe code indicate that it is the used size of the volume mounted20:17
robertmyersSo the idea is that the backup will use that much at least when it is restored20:17
*** yogesh has quit IRC20:18
denis_makogonrobertmyers, please review,  https://review.openstack.org/#/c/86300/20:19
denis_makogonthe whole idea is to block user from the provisioning with restoring if bakup is way to big than flavor root disk or the volume size20:20
denis_makogonamrith, are you still there ?20:22
hub_capdenis_makogon: is size an int just showing the GBs? im just curious20:23
hub_capso if the volume_stats['used'] was 3.22 will it show 3, 4, or 3.22 ?20:23
hub_capi assume the whole ting right? ( cp16net 's "int" comment confused me)20:24
robertmyersI think it is a float20:24
hub_capthx robertmyers20:25
robertmyersso, we probably should compare floats20:25
robertmyersI'll comment20:25
hub_capright20:25
hub_capthx20:25
hub_caprobertmyers: >>> float(3.0000000000000000001) > int(3)20:27
hub_capthats False in python :P20:27
amcrnshouldn't there be some fudge factor added in?20:27
hub_cappeanut butter fudge factor amcrn ?20:27
*** yogeshmehra has quit IRC20:27
amcrni.e. if it's 1.99999 and the volume is 2, you're going to have a good ol' time.20:27
hub_capyea u get to write 1 row amcrn20:28
hub_capbut then again... should we care?20:28
amrithdenis: yes20:28
amcrnhub_cap: we should20:28
hub_caprobertmyers: nm wha ti said, plz comment my brain is not there20:28
denis_makogonhub_cap, of course, sinse we allow restoring from any backup20:28
hub_capi mean do we care if they are eqal or not20:28
amrithwould this code also run on ther guest agents?20:28
amrithno; i assume not?20:28
robertmyersthis is api20:29
hub_capnaw amrith20:29
robertmyersbefore the guest is involved20:29
amcrnpersonally, i'd like to see a CONF.min_disk_left like concept20:29
amcrnbecause certain datastores like to spray around quite a few temporary files before actually starting20:29
hub_capthats sensible amcrn20:31
amrithdenis: looking at the code you provided (thanks) it does look like size is the size of the data on the file system of the system being backed up. I will revert my comments; thanks.20:32
robertmyersamcrn: sure, the actual restore may be smaller20:32
robertmyersbut 10gb will probably not fit in 1gb20:33
robertmyerssoo we should fail before we go and create a ton of resources20:33
denis_makogonagreed20:34
*** ViswaV has joined #openstack-trove20:34
amcrnrobertmyers: one example i'm thinking of (and i might be wrong here) is if you install mongodb with smallfiles off, it auto-creates roughly 2GB of files on-disk. If you have a mongodb backup, and say it's 1.5GB, then restoring that to a new instance with a 2GB volume very well might fail.20:34
robertmyersamcrn: we are storing the size on disk as the backup size20:35
robertmyersor the volume used20:35
amcrnunderstood20:36
*** harlowja is now known as harlowja_away20:36
hub_capwhat about mysq, 1.999999 gb used, restore to 2g, 1hr later, bam, instance full, now people are freaking20:36
hub_capany datastore really20:36
amcrncorrect20:36
hub_caplet the operator say, ehhh 500mb fudge factor20:36
amrithdenis_makogon: I have changed my review to +0. I'm not wild about this change because I'm not comfortable using file system size as an indication of how much space is required on disk. Things like deleted records and things of that nature come to mind20:36
amrithI believe that this is a reasonable first step20:36
amcrnalso, you're not accounting for the disk space taken after the datastore has initialized (irrespective of backup or no backup)20:36
amrithit also does not account for other things that may be on the same mount point20:37
amriththat are not part of the backup20:37
*** michael-yu has quit IRC20:37
robertmyersso we (rax) have had a number of people run out of disk space on the volume and it is bad20:37
amrithbut as stated the code does what you intended it to do. I don't think it is a complete solution but it is at least a partial solution20:37
robertmyershorrible things happen20:37
robertmyersso we *should* find a way in trove to notify people20:38
robertmyersbut that is another story20:38
amrithsee: http://stackoverflow.com/questions/1270944/mysql-innodb-not-releasing-disk-space-after-deleting-data-rows-from-table20:38
amrithbut I will let others decide whether to let this move forward or not; I'm still unsure about it20:39
robertmyersamrith: we do use file per table20:39
robertmyersso, that helps20:39
hub_capim curious to know if thatll creep into a dump tho20:39
amrithoh, it helps20:39
amrithbut only if you backup, drop and recreate the table20:40
amcrnrobertmyers: so, are you against adding a CONF.minimum_disk_left_after_restore? i.e. if you set that to 2, then that means if the backup if 5GB, and the volume is 6.0GB, that 6.0 - 5 - 2 < 0, so it doesn't allow it.20:40
amrithrobertmyers: a delete won't free up space; file_per_table or not20:40
amcrnbackup is*20:40
robertmyersamrith: I know of the issues of using the volume used, just we don't have any other good way to say how small the data will be after a restore20:41
robertmyersamcrn: I might be for it20:42
amrithrobertmyers: understood. My issue was solely with the fact that I wanted to convince myself that .size was in fact size on disk in the database, not size on SWIFT20:42
amrithrobertmyers: denis showed me the code; I'm annoyed that I couldn't find it myself, but he showed me what I was looking for20:42
amrithrobertmyers: my question is answered.20:42
robertmyerscool20:42
amrithdenis: you there?20:43
amrithdid you see my comments above?20:44
amrithdenis_makogon: u there?20:44
robertmyersamcrn: actually it might be overkill, especially in testing, say you have a small test DB that is << 1GB than you could only restore to a 3GB volume20:47
amcrnrobertmyers: sure, but the default would either be 0 or 120:47
amcrnthen in my production environments i'd set it ridiculously high for tier 0 use-cases20:47
robertmyersyeah, well even then your customers might hate you20:47
amrith;)20:48
hub_cap.0520:49
hub_capfixed :)20:49
denis_makogonamrith, i'm still here20:49
amrithdenis: u see my comments above?20:49
amriththx for the pointer20:49
denis_makogonamrith, i guess =)20:50
denis_makogonamcrn, robertmyers so what about bringing the CONF.get(datastore).minimum_disk_left_after_restore ?20:50
denis_makogonit seems valid20:50
hub_capdenis_makogon: seperate BP i think20:51
denis_makogonhub_cap, right20:51
denis_makogonand what about current fix ?20:51
robertmyersdenis_makogon: I jsut have the one comment about floating point math20:52
hub_capminor nits denis_makogon20:52
robertmyerspossibly we should round up20:52
denis_makogonrobertmyers, ah, i see, thanks20:52
denis_makogonthere's another lifehack20:52
robertmyersit *might* not be an issue20:52
robertmyersbut I've been burned by floats20:52
denis_makogonwe could check how long is the str(backup.size)20:52
denis_makogonand then prepare flavor disk or volume support to look like backup size20:53
robertmyers?20:53
denis_makogonif backup size equals to 0.845, volume size should look like 2.00020:53
robertmyersjoking?20:53
robertmyersvolume is an int20:54
denis_makogonyes20:54
denis_makogonright20:54
*** harlowja_away is now known as harlowja20:55
denis_makogon(%s.%s) % (volume_size, "0"*len(str(backup.size))20:55
hub_capceil(backup.size) <= flavor.size20:55
hub_capthats what u need, nothign more20:56
robertmyershub_cap: +120:56
*** pdmars has joined #openstack-trove20:56
*** kevinconway has quit IRC20:57
hub_caphttps://gist.github.com/hub-cap/1031474320:57
hub_capsimple as that (of course fudge_factor will be in a diff BP)20:57
hub_capi have no idea waht the len () thing is all about20:57
amrithwait a second20:57
amrithsize is also an int20:57
robertmyersno20:58
robertmyersit is a float20:58
amrithso this whole float thing may be moot ;)20:58
hub_capwhich size?20:58
hub_capbackup.size or flavor.size?20:58
robertmyersbackup.size is a float20:58
amrithbackup_info.size20:58
hub_caplets be specific so my head doesnt explode :P20:58
amrithreally20:58
robertmyersyes20:58
denis_makogonvolume size is an int, backup size is a float, flavor roo disk size int20:58
robertmyersamrith: https://github.com/openstack/trove/blob/master/trove/guestagent/dbaas.py#L5721:00
hub_cap    used_gb = to_gb(total - free)21:00
robertmyersbytes/ 1024.0 ** 3 gives you a float21:01
robertmyerssince you are dividing by a float21:01
amrithyup21:01
amrithyup21:01
amrithI was looking at free21:01
amrithnever mind21:01
hub_capcool, so lets go w/ math.ceil() and we have no issues21:01
robertmyersdone21:01
amrith+121:01
cp16netamrith: you asked me about the change for local-infile21:02
*** iccha has quit IRC21:02
amrithyessir21:02
cp16netso a dba mentioned that the global scope variable should be named as local_infile with _ and not -21:03
*** rramirez has quit IRC21:03
amrithoh, ok21:04
amrithi think dougshelley66 has other concerns as well21:04
cp16netthe thing that sucks with how mysql params are set is that we set them with the client with one name but the conf file sets them with another name21:04
dougshelley66i put my question on the bug21:04
cp16netthis is kinda the problem we have with this variable in particular21:04
*** michael-yu has joined #openstack-trove21:04
hub_capcp16net: FAIL21:05
hub_capgood ole mysql21:05
amrithnever fails to amaze21:05
cp16nethub_cap: yup21:05
amrithhub_cap: you've met monty, no?21:05
amrithnot taylor, the other one21:05
amriththe mysql ne21:05
amriths/ne/one/21:05
amrithcrap, got to run. goodbye all ...21:06
cp16netpeace amrith21:07
*** kevinconway has joined #openstack-trove21:07
*** iccha has joined #openstack-trove21:08
hub_capwiedenes or whatever21:09
hub_capamrith: ^ ^21:09
hub_capyea i have amrith, we met about maria last yr21:09
*** rueb7363 has joined #openstack-trove21:09
*** rueb7363 has quit IRC21:10
*** rueb7363 has joined #openstack-trove21:10
*** eghobo has quit IRC21:12
esmuteHi reviewers, would like to get this reviewed if you have anytime https://review.openstack.org/#/c/81379/? Should be short and quick21:12
*** openstackstatus has quit IRC21:14
*** openstackstatus has joined #openstack-trove21:22
peterstacdenis_makogon: I've added a blueprint for the Trove client formatting changes21:24
peterstacdenis_makogon: if you want to take a look: https://blueprints.launchpad.net/trove/+spec/emulate-osc-in-python-troveclient21:24
denis_makogonpeterstac, nice, what about other projects ?21:25
*** ramashri has joined #openstack-trove21:25
peterstacdenis_makogon: You can look at other projects too :)21:26
denis_makogonpeterstac, i've got another scope of tasks =)21:26
denis_makogonpeterstac, but, seriously, i think you should try to talk with other teams to see what they think about the common policy related to shell outputs21:27
*** sgotliv has quit IRC21:27
peterstacdenis_makogon: Looks like that will be wrapped in the OSC project, but they're still a little vague in output formats21:28
*** thedodd has quit IRC21:30
robertmyershow is the troveclient different? they both use pretty table21:30
denis_makogonpeterstac, that's the problem OSC is the another client, cloud client, i bet that devs. will decide to re-invent the wheel and create their own format for output21:30
denis_makogonrobertmyers, aligning, etc.21:30
denis_makogonrobertmyers, https://blueprints.launchpad.net/trove/+spec/emulate-osc-in-python-troveclient21:30
robertmyersaligning what?21:30
*** Barker has quit IRC21:30
denis_makogonrobertmyers, align content inside the pretty tables, i guess21:31
robertmyersthat looks like prettytables output21:31
hub_caphey peterstac i assume this is in every -client project?21:31
denis_makogonhub_cap, i guess, it's not, but, yet21:31
denis_makogonrobertmyers, i think i'll help more https://wiki.openstack.org/wiki/Trove-Client-Look-And-Feel21:32
*** thedodd has joined #openstack-trove21:32
hub_caphmm im not sure i a fan of this :)21:32
robertmyersdenis_makogon: Well, this seems like a waste of time21:32
robertmyersit is a lot of work for a tiny change I bet21:32
denis_makogonrobertmyers, hub_cap, for now - yes, agreed21:32
robertmyerspossibly errors21:33
denis_makogonrobertmyers, you can't know until you try =)21:33
hub_capyea what prompted this?21:33
robertmyersdenis_makogon: we have better things to do with our time21:33
robertmyerslike actually deliver features21:33
denis_makogonrobertmyers, hah, lol, of course= ))21:33
robertmyerswe should focus on the project21:34
robertmyersmake it better not look better21:34
denis_makogonrobertmyers, what if this is the first contributor into the trove21:34
robertmyersfix docs21:34
denis_makogonrobertmyers, it's like misspell corrections21:34
robertmyersfix one of the N number of real bugs21:34
denis_makogonrobertmyers, at least one, but yes, i feel the same21:35
robertmyersthe point is we need to move trove forward21:35
robertmyers:)21:35
denis_makogonbtw, does anyone rides the sport bikes ?21:38
denis_makogonannashen, ping21:40
denis_makogonannashen, are you there ?21:40
annashendenis_makogon: pong21:44
annashenso, about blueprint21:44
denis_makogonannashen, let's deal with it21:44
annashen#link https://wiki.openstack.org/wiki/Trove/neutron-support21:44
denis_makogonannashen, i already saw that, https://review.openstack.org/#/c/86031/ <- hope you saw this too21:45
denis_makogonannashen, i made what i proposed21:46
denis_makogonannashen, so, now, we can move forwad with tuning redstack to have multiple networks21:46
denis_makogonannashen, and then you can write neutron manager21:46
peterstachub_cap: not sure what you mean by 'every -client project' but they all have capitalized headers, etc.21:46
denis_makogonannashen, does it works for you ?21:47
peterstacThis wasn't to create work, just to get my feet wet with the process - didn't want it to suck up everyone's time21:47
annashendenis_makogon, how soon can you make all the tests for the patch you mentioned above?21:47
denis_makogonpeterstac, hub_cap means the same as i said: "Is this change the part of common initiative?"21:47
denis_makogonannashen, tests, which?21:48
peterstacdenis_makogon, hub_cap: No, this change would only be in python-troveclient21:48
annasheni will post my comments soon on the patch also, denis_makogon21:48
denis_makogonannashen, i made this layer to fit to the current requirements21:48
denis_makogonannashen, sounds great21:48
denis_makogonannashen, with my patch trove works with nova-network manager, your task, i suppose, write the neutron driver, right ?21:49
*** grapex has quit IRC21:49
denis_makogonmichael-yu, ping21:51
robertmyerspeterstac: sorry to shoot you down, but i still think it is not worth our time to fix the output of prettytable21:51
robertmyerspeterstac: especially if another group is just going to rewrite the whole thing21:51
robertmyerslet them do it21:51
peterstacrobertmyers: It took hardly any time to fix the output - writing the blueprint/wiki on the other hand21:52
michael-yudenis_makogon: yes21:52
robertmyerspeterstac: well, how does that effect the way the  --json works21:52
robertmyersI'm just concerned with breaking things21:52
robertmyersto make it look good21:53
denis_makogonmichael-yu, saw your patch for horizon, i've got bug report that already been marked as High, no need to use BP21:53
robertmyerspeterstac: I hate prettytables too21:53
*** demorris has quit IRC21:53
denis_makogonmichael-yu, https://bugs.launchpad.net/horizon/+bug/129845121:53
peterstacrobertmyers: it shouldn't affect --json, but let me quickly test21:53
denis_makogondenis_makogon, use this one because you probably will waste a lot of time to get it approved, or David can approve it ?21:54
peterstacrobertmyers: Just verified - doesn't change --json at all21:54
robertmyerspeterstac: fine, but still, I think we should focus on bugs and features21:55
robertmyers:)21:55
denis_makogonrobertmyers, correct21:55
robertmyerswe have a huge backlog21:55
robertmyersit is only getting longer21:55
amcrndenis_makogon: it's a blueprint, and the blueprint filing predates your bug by at least 2 months21:55
robertmyersand all i see is noise21:55
peterstacrobertmyers: I agree - I'm working on the Tempest tests, but noticed this and thought to use it as a way to get familiar with the process21:56
denis_makogonamcrn, does david-lyle or other cores approved it ?21:56
denis_makogonamcrn, it seems like not21:56
peterstacrobertmyers: Along with making us look more like other CLI's21:56
amcrndenis_makogon: your point being?21:56
denis_makogonamcrn, i'm just suggesting the more easiest way21:57
robertmyerspeterstac: All I ask is wait for the BP to be approved before you submit a review21:57
amcrndenis_makogon: it isn't a bug, by definition it should be a blueprint.21:57
denis_makogonamcrn, no need to wait until BP get reviewed21:57
robertmyersthat goes for everyone21:57
robertmyersdenis_makogon: I'm looking at you ;)21:57
peterstacrobertmyers: Sure, not a problem21:57
denis_makogonrobertmyers, what do you mean ?21:58
robertmyersdon't submit reviews until the bp is approved21:59
robertmyerswe all need to follow the rules21:59
robertmyerscause we shave a small team21:59
robertmyersand the backlog is getting too big21:59
robertmyersanyway, I have to run22:00
*** robertmyers has quit IRC22:00
*** NehaV1 has quit IRC22:03
*** denis_makogon has quit IRC22:12
*** thedodd has quit IRC22:15
*** jasonb365 has quit IRC22:19
openstackgerritDan Nguyen proposed a change to openstack/trove: Partially implements guest agent upgrade strategy  https://review.openstack.org/8522522:21
*** openstack has joined #openstack-trove22:33
*** mattgriffin has quit IRC22:37
*** rueb7363 has quit IRC22:38
*** kevinconway has quit IRC22:40
*** ViswaV has quit IRC22:46
*** khyati_ has joined #openstack-trove22:52
*** ramashri has quit IRC22:53
*** jcru has quit IRC22:56
*** ViswaV has joined #openstack-trove23:08
*** achampion has joined #openstack-trove23:34
*** Barker has joined #openstack-trove23:49

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!