| *** bryanfraschetti609845 is now known as bryanfraschetti60984 | 00:17 | |
| opendevreview | Marios Andreou proposed openstack/watcher master: WIP Add prometheus data source for watcher decision engine https://review.opendev.org/c/openstack/watcher/+/934423 | 08:44 |
|---|---|---|
| marios | o/ amoralej thanks for your review on https://review.opendev.org/c/openstack/watcher/+/934423 | 10:50 |
| marios | i think i'll work out the client options at least for user/pass (bas9c auth) and certs, and add those in the next couple days | 10:51 |
| marios | we can still get it 'ready for merge' by end next week i think | 10:51 |
| amoralej | the good part is that returned values are correct in my test | 10:51 |
| marios | the actually work is done on the observabiliticlient so we just have to pass the opts through | 10:51 |
| amoralej | the bad part is that i'd say it's not returning the right data types | 10:51 |
| amoralej | still, getting the right metric and formula is tricky | 10:52 |
| marios | yeah right i just checked your latest comment | 10:53 |
| marios | so yeah we can update that to return an actual float | 10:54 |
| marios | very nice catch | 10:54 |
| *** rlandy_ is now known as rlandy | 11:27 | |
| marios | watcher weekly irc meeting starting here in 5 mins o/ add agenda items to https://etherpad.opendev.org/p/openstack-watcher-irc-meeting | 11:55 |
| marios | #startmeeting watcher | 12:00 |
| opendevmeet | Meeting started Thu Dec 12 12:00:01 2024 UTC and is due to finish in 60 minutes. The chair is marios. Information about MeetBot at http://wiki.debian.org/MeetBot. | 12:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 12:00 |
| opendevmeet | The meeting name has been set to 'watcher' | 12:00 |
| marios | hello all o/ who is around today | 12:00 |
| amoralej | o/ | 12:00 |
| dviroel | o/ | 12:00 |
| jgilaber | o/ | 12:00 |
| chandankumar | o/ | 12:01 |
| marios | #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting meeting agenda | 12:01 |
| marios | ok lets get going on the agenda items we will take them in order given | 12:01 |
| marios | #topic ( rlandy) Open reviews (not expected to be merged before year end): | 12:01 |
| marios | #link https://review.opendev.org/q/project:openstack/watcher+status:open+-is:wip | 12:01 |
| rlandy | thanks @marios | 12:02 |
| marios | lets add dashboard there too | 12:02 |
| rlandy | listed the reviews there that would need W+ | 12:02 |
| marios | #link https://review.opendev.org/q/project:openstack/watcher-dashboard+status:open+-is:wip | 12:02 |
| marios | ok lets take them one at a time, give folks chance for any concerns or comments or status | 12:02 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/934423 Add prometheus data source for watcher decision engine | 12:02 |
| marios | thanks for reviews on this one i think it is close now. | 12:03 |
| marios | thanks amoralej and sean for the latest round of reviews | 12:03 |
| marios | my plan is to add in the client auth options and try to get it into mergeable state by the end of th eyear | 12:03 |
| marios | (i.e. next week ;)) | 12:03 |
| marios | then the followup patch will deal with vm level metrics | 12:04 |
| amoralej | you mean auth or better https handling ? | 12:04 |
| marios | i mean both | 12:04 |
| amoralej | i thought we wouldn't need auth | 12:04 |
| marios | basicaaly add the client opts for basic_auth user/pass if user wants, or client cert/ca | 12:04 |
| marios | from our side its just adding the client opts | 12:04 |
| marios | the "heavy lifting " is done on the observabilityclient | 12:04 |
| amoralej | does observabilityclient support auth ? | 12:04 |
| marios | so agree with the notion of trying to establish the interface | 12:05 |
| marios | it has basic_auth | 12:05 |
| marios | you can set the user/pass on the session | 12:05 |
| marios | if you pass it through | 12:05 |
| amoralej | good | 12:05 |
| amoralej | yeah, then, let's expose it | 12:05 |
| marios | so it should be cheap to add the client opts on our side anyway | 12:05 |
| amoralej | but in follow up :) | 12:05 |
| marios | and establish our interface | 12:05 |
| marios | ok lets discuss this bit on the review then, personally i think one more iteration for th eclient opts is OK | 12:05 |
| amoralej | ok | 12:06 |
| marios | thanks amoralej for diving in there and as discussed earlier in this channel helping to test this it is very useful and helpful feedback | 12:06 |
| marios | thanks to others that have had a look already and please keep reviews coming thank you | 12:06 |
| marios | anything else before we move on from this one | 12:06 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/935371 Add Tempest test for Prometheus integration | 12:07 |
| rlandy | thanks for all the reviews | 12:07 |
| rlandy | only W needed here | 12:07 |
| marios | nice one rlandy++ | 12:08 |
| rlandy | working on scenarios in follow up patch | 12:08 |
| rlandy | but hitting the stated bug - so will report on that in next meeting | 12:08 |
| marios | so this patch is setting up sg-core to expose ceilometer metrics exported as prometheus metrics | 12:09 |
| marios | i mean 935371 (adding some general info for anyone following along in the meeting logs) | 12:09 |
| marios | but currently it is actually not using any of the prometheus metrics right? | 12:09 |
| marios | so that is coming in the followup patch | 12:09 |
| rlandy | correct | 12:09 |
| marios | lets link it here? | 12:09 |
| rlandy | https://review.opendev.org/c/openstack/watcher/+/937497 | 12:10 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/937497 WIP: Run scenario tests with prometheus | 12:10 |
| marios | anything further on this topic rlandy or anyone? | 12:11 |
| rlandy | you will notice they all fail on https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2090853 | 12:11 |
| rlandy | so we have no option but to get the prometheus metrics in :) | 12:11 |
| rlandy | that's all | 12:11 |
| marios | #info known bug on watcher-tempest-plugin affecting https://bugs.launchpad.net/watcher-tempest-plugin/+bug/2090853 | 12:12 |
| marios | thanks for the info rlandy | 12:12 |
| marios | anything else here before we move to the next | 12:12 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/933909 Update python versions, drop py3.8 | 12:13 |
| marios | looks like martin is not here right now? | 12:13 |
| marios | anyone else can talk about this one? i think as written, we just need a workflow . | 12:13 |
| marios | our only current active core has already added +2 (Sean) | 12:14 |
| rlandy | marios: note these were just added to the list to notify people that we are waiting on W ... idk if there is a need to address any one in particular | 12:14 |
| rlandy | martin is out until monday | 12:14 |
| marios | so right now it would mean harrassing dsmith or slaweq as the other two cores. | 12:14 |
| marios | probably we should add them to the review, doing that now in fact with a note | 12:14 |
| marios | Dan, Slaweq can you please check this and merge if you agree. Right now we only have Sean as active core so until we get some more please help us merge some of the things. Sorry for unsolicited pings and thanks in advance ;) | 12:16 |
| marios | i added this note ^ | 12:16 |
| marios | anything further on this topic? | 12:16 |
| marios | i think if there is no push back until the new year we can ask sean to merge like this | 12:16 |
| marios | that is another solution until we build our core team | 12:16 |
| rlandy | +1 | 12:16 |
| rlandy | ie: ok to wait | 12:17 |
| marios | yes | 12:17 |
| marios | ok, moving on ... | 12:17 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/934583 Remove default override for config options policy_file | 12:17 |
| marios | i think similar story here right | 12:18 |
| marios | this one belongs to gmann | 12:18 |
| marios | so sean has voted and we'll need to harrass Dan/Chenker/Slaweq for now, and in the new year we can ask sean to merge with one +2 if needed until we build core team out | 12:19 |
| marios | i won't copy/paste my review request note on this review (or others) yet for example i think some folks will indeed be out until the new year | 12:19 |
| marios | anything else on this one before we move on? | 12:19 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/932264 tox: Drop envdir | 12:20 |
| marios | same story here ... | 12:20 |
| marios | ah in fact, here sean can merge it | 12:20 |
| marios | dsmith added his +2 | 12:20 |
| marios | adding note for sean | 12:21 |
| marios | anything else here? | 12:21 |
| marios | #link https://review.opendev.org/c/openstack/watcher/+/934996 Unblock the CI gate | 12:22 |
| marios | so per seans comment here we need to wait for https://review.opendev.org/c/openstack/project-config/+/936754 | 12:22 |
| marios | but then we should workflow -1 /934996 or add depends-on | 12:23 |
| marios | moving on ... | 12:24 |
| marios | next topic | 12:24 |
| marios | #topic (amoralej) For watcher-dashboard the more meaningful reviews are: | 12:24 |
| marios | amoralej: i will list them here but feel free to start giving any context you wanted to | 12:24 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/932693 | 12:25 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/888912 | 12:25 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/933910 | 12:25 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/935043 | 12:25 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/934781 | 12:25 |
| amoralej | we don't need to go one by one, i just wanted to focus what are the more relevant reviews in watcher-dashboards | 12:25 |
| marios | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/932890 | 12:25 |
| marios | ack anything we need to call out? | 12:25 |
| amoralej | it's mostly some sanity fixes | 12:26 |
| amoralej | and bug fixing | 12:26 |
| amoralej | just, asking for review and we can discuss there or here if you have doubts | 12:26 |
| marios | thanks amoralej any comments before we move on | 12:27 |
| marios | (anyone) | 12:27 |
| amoralej | I was wondering if we should backport those fixes in watcher-dashboard to supported releases | 12:28 |
| amoralej | I'm not sure if it's worthy, tbh | 12:28 |
| marios | so, it might be more work than worth it, but i am also not sure yet | 12:29 |
| marios | the project has been mostly dormant in the last couple years so ... might be easy/cheap to backport | 12:29 |
| marios | but does anyone care? | 12:29 |
| rlandy | it seems there is enough work to get them into the current release | 12:29 |
| amoralej | I expect backports should be easy to do, but yes, that's my question | 12:29 |
| amoralej | if anyone is interested | 12:30 |
| amoralej | and it's mostly work to get ci running, etc... | 12:30 |
| amoralej | in case it's not, i didn't check | 12:30 |
| marios | yes this is another good point rlandy ; can we revisit this in the new year amoralej sounds like a good agenda item once these things actually start mergein on master | 12:30 |
| amoralej | we can focus in master so far | 12:30 |
| rlandy | +1 | 12:30 |
| marios | k moving on .. | 12:31 |
| dviroel | +1 on revisit this, once we have more reviewers too | 12:31 |
| dviroel | reviewers that have power to merge them :) | 12:31 |
| marios | yes | 12:32 |
| amoralej | +1 | 12:32 |
| marios | #topic https://review.opendev.org/q/project:openstack/watcher-specs+status:open+-is:wip | 12:32 |
| marios | #link https://review.opendev.org/c/openstack/watcher-specs/+/752508 Fix hacking min version to 3.0.1 | 12:32 |
| marios | i *think* takashi had a series of patches for this no? | 12:33 |
| marios | checking | 12:33 |
| marios | ah this is watcher-specs though maybe he missed that one | 12:33 |
| marios | k cant quickly find anyway | 12:34 |
| marios | any discussion on this one? | 12:34 |
| marios | moving on momentarily .. | 12:35 |
| marios | #topic https://review.opendev.org/q/project:openstack/watcher-tempest-plugin+status:open+-is:wip | 12:35 |
| marios | #link https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/936837 Update documentation and add a job to publish it | 12:35 |
| marios | #link https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/934009 Drop translation sections | 12:35 |
| marios | any dicussion here ? | 12:35 |
| marios | moving on in a moment... | 12:36 |
| marios | #topic (doug) Meetings on Dec 26th and Jan 2nd. Should we cancel these due to holidays? | 12:37 |
| marios | thanks for adding this one i was going to propose the same | 12:37 |
| dviroel | yep, due to holidays and low audience, is anyone against to cancel both? | 12:38 |
| marios | looks like there is agreement on the etherpad | 12:38 |
| jgilaber | +1 to cancel, there's likely very few people around on those dates | 12:38 |
| marios | #info watcher weekly irc meeting cancelled Thursday 26 December 2024 and Thursday 02 January 2025 due to engineering holiday outages | 12:39 |
| marios | anything else before we move on ? | 12:39 |
| dviroel | we need someone to send that in the ML | 12:39 |
| marios | yes good call dviroel | 12:40 |
| marios | any volunteer | 12:40 |
| dviroel | i can | 12:40 |
| marios | #action dviroel will mail openstack-discuss about cancelled irc meetings 26Dec & 02Jan | 12:40 |
| marios | thank you | 12:40 |
| marios | #topic (doug) Nova spec merged: scheduler hints info available in server details | 12:41 |
| marios | #link https://review.opendev.org/c/openstack/nova-specs/+/936140 Add spec for show scheduler hints in server details | 12:41 |
| dviroel | yeap, just want to bring this topic, since is important from watcher's point of view | 12:41 |
| marios | nice job getting that merged dviroel | 12:42 |
| dviroel | this spec is now merged in nova-spec, and one of the main use cases is to allow services, like watcher to retrieve additional placement constraints of running instances | 12:42 |
| amoralej | nice | 12:42 |
| amoralej | dviroel++ | 12:42 |
| dviroel | for watcher, this could reflect on more constraints to be evaluated by Strategies, when selecting a destination host for instance migrations | 12:42 |
| dviroel | I am expecting to propose the nova changes and get them merged in this release too | 12:43 |
| dviroel | and after that, watcher and strategies will also need to be modified to properly account these new constraints... | 12:43 |
| dviroel | but probably work for another release | 12:43 |
| dviroel | any questions on that $topic? | 12:44 |
| marios | thanks for the extra context dviroel | 12:45 |
| amoralej | you think some initial improvements in the strategy to align with nova scheduler, other that the related with the scheduler-hints, is doable in this release? | 12:45 |
| dviroel | :) | 12:45 |
| dviroel | amoralej: maybe, it is also possible to include other constraints like server_groups for instance... | 12:46 |
| dviroel | that are already available in nova's api | 12:46 |
| amoralej | exactly, that was my point | 12:46 |
| amoralej | given that we already have part of it, i was thinking if we may start implementing that part which does not require the new feature | 12:46 |
| amoralej | even if it's not perfect, it may be better that what we have | 12:47 |
| amoralej | said so, i have no idea about how complex it is | 12:47 |
| dviroel | right, I think that is something that I can bring to the following meetings... | 12:48 |
| amoralej | sounds good to me | 12:48 |
| marios | anything further from anyone for right now on this before we move on | 12:48 |
| marios | #topic next meeting chair | 12:49 |
| marios | so rlandy is in the list but i don't know if they will be up for it... we can revisit between now and then | 12:49 |
| amoralej | I may not be available at meeting time next week | 12:49 |
| marios | but i think rlandy said they can do it so leaving as is for now | 12:50 |
| rlandy | I can do it next week | 12:50 |
| marios | #info rlandy to chair irc meeting 19th December 2024 | 12:50 |
| marios | next one after that is (checks calendar) | 12:50 |
| marios | 09th Jan | 12:50 |
| marios | volunteer to chair 09 Jan irc meeting please? | 12:50 |
| amoralej | i can take it | 12:51 |
| marios | if you aren't up for next week i can take it rlandy we talk before then obv | 12:51 |
| marios | thank you amoralej | 12:51 |
| marios | #info amoralej to chair irc meeting 09 Jan 2025 | 12:51 |
| dviroel | thanks amoralej | 12:51 |
| marios | that is the end of topics | 12:52 |
| marios | #topic open discussion | 12:52 |
| marios | anything anyone would like to bring up here before we close out today? | 12:52 |
| marios | ok then thanks all for participating o/ | 12:53 |
| marios | #endmeeting | 12:53 |
| opendevmeet | Meeting ended Thu Dec 12 12:53:59 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 12:53 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-12-12.00.html | 12:53 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-12-12.00.txt | 12:53 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/watcher/2024/watcher.2024-12-12-12.00.log.html | 12:53 |
| dviroel | marios++ thanks for leading | 12:54 |
| amoralej | thanks marios ! | 12:54 |
| marios | wow | 12:54 |
| jgilaber | thanks marios++ | 12:54 |
| marios | we almost stretched that into an hour ;) | 12:55 |
| amoralej | right on time :) | 12:56 |
| *** bryanfraschetti6098451 is now known as bryanfraschetti609845 | 14:30 | |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Remove ceilometer datasource https://review.opendev.org/c/openstack/watcher/+/937625 | 14:32 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Remove ceilometer datasource https://review.opendev.org/c/openstack/watcher/+/937625 | 14:34 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Remove ceilometer datasource https://review.opendev.org/c/openstack/watcher/+/937625 | 14:37 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: Remove ceilometer datasource https://review.opendev.org/c/openstack/watcher/+/937625 | 14:41 |
| opendevreview | Martin Kopec proposed openstack/watcher-tempest-plugin master: Update documentation and add a job to publish it https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/936837 | 14:54 |
| opendevreview | Martin Kopec proposed openstack/watcher-tempest-plugin master: Update documentation and add a job to publish it https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/936837 | 14:55 |
| *** bryanfraschetti60984571 is now known as bryanfraschetti6098457 | 16:10 | |
| opendevreview | Merged openstack/watcher-dashboard master: Update python versions, drop py3.8 https://review.opendev.org/c/openstack/watcher-dashboard/+/933910 | 16:15 |
| *** bryanfraschetti60984575 is now known as bryanfraschetti6098457 | 16:26 | |
| *** bryanfraschetti60984571 is now known as bryanfraschetti6098457 | 19:01 | |
| *** bryanfraschetti60984570 is now known as bryanfraschetti6098457 | 21:31 | |
| opendevreview | Ronelle Landy proposed openstack/watcher master: WIP: Run scenario tests with prometheus https://review.opendev.org/c/openstack/watcher/+/937497 | 22:18 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!