| *** cpallares has quit IRC | 00:13 | |
| *** cpallares has joined #openstack-zaqar | 01:17 | |
| *** amalagon has joined #openstack-zaqar | 01:38 | |
| *** cpallares has quit IRC | 02:16 | |
| *** cpallares has joined #openstack-zaqar | 03:50 | |
| *** flwang1 has quit IRC | 04:20 | |
| *** chandankumar has joined #openstack-zaqar | 05:02 | |
| *** cpallares has quit IRC | 05:24 | |
| *** amalagon has quit IRC | 05:36 | |
| *** echevemaster has quit IRC | 05:38 | |
| *** achanda has quit IRC | 05:50 | |
| *** number80 has quit IRC | 05:55 | |
| *** achanda has joined #openstack-zaqar | 06:19 | |
| *** fifieldt has joined #openstack-zaqar | 06:26 | |
| *** chandankumar has quit IRC | 06:44 | |
| *** chandankumar has joined #openstack-zaqar | 06:55 | |
| *** achanda has quit IRC | 08:09 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:14 | |
| exploreshaifali | gooooooooood morning!! | 08:22 |
|---|---|---|
| *** flwang1 has joined #openstack-zaqar | 08:57 | |
| flwang1 | flaper87: ping | 08:57 |
| flaper87 | flwang1: pong | 09:00 |
| flaper87 | exploreshaifali: gooooooood morning | 09:00 |
| flaper87 | exploreshaifali: how's the patch going? | 09:00 |
| flaper87 | flwang1: the tempest patch landed | 09:00 |
| flwang1 | flaper87: awesome | 09:00 |
| flaper87 | flwang1: no idea what's going on with redis, though | 09:01 |
| flaper87 | I tried in a local vm and it worked | 09:01 |
| flaper87 | but it seems to still fail in the gate | 09:01 |
| flaper87 | :/ | 09:01 |
| flwang1 | yep, that's really weird | 09:02 |
| flwang1 | what did you mean worked? | 09:02 |
| flwang1 | the function worked or the test? | 09:02 |
| flaper87 | flwang1: "./stack.sh" worked | 09:02 |
| flaper87 | it installed everything and ran zaqar | 09:02 |
| flaper87 | no failures | 09:02 |
| flwang1 | oh, ok | 09:02 |
| flaper87 | all good | 09:02 |
| flaper87 | so, no idea why it's not running in the gate | 09:02 |
| flwang1 | it's not a good news for me :) | 09:03 |
| flaper87 | :( sorry buddy, I need to investigate more | 09:04 |
| flwang1 | flaper87: don't say sorry, body. i just feel hopeless if you can't tell me why :( | 09:08 |
| exploreshaifali | flaper87: even after passing "self._storage" instead of "self" it is returning None :( | 09:14 |
| exploreshaifali | I am iterating everything once again from start | 09:14 |
| exploreshaifali | flaper87: it is saying *TypeError: MessageQueueHandler constructor argument after * must be a sequence, not DataDriver* | 09:16 |
| flaper87 | exploreshaifali: that error seems very explicit to me :D Try looking at the MessageQueueHandler __init__. What does it look like? | 09:16 |
| exploreshaifali | it have only two args: (self, driver) | 09:18 |
| flaper87 | and what does your invoke_args looks like ? | 09:18 |
| exploreshaifali | flaper87: invoke_args = self._storage from storage/pipeline.DataDriver | 09:21 |
| flaper87 | exploreshaifali: the error is there | 09:21 |
| flaper87 | you should pass a sequence to invoke_args, not a DataDriver | 09:21 |
| flaper87 | try with [self._storage] | 09:21 |
| exploreshaifali | oh yes yes | 09:22 |
| flaper87 | The reason is that stevedore will pass that to the loaded driver as `*invoke_args` | 09:22 |
| exploreshaifali | flaper87: yes correct | 09:22 |
| exploreshaifali | flaper87: now it wants - queues_database - *AttributeError: 'DataDriver' object has no attribute 'queues_database'* | 09:41 |
| exploreshaifali | flaper87: we cannot define queues_database inside pipeline.DataDriver as we are suppose to place them in control plane | 09:41 |
| exploreshaifali | flaper87: also I initialized MessageController object inside MessageQueueHandelr like - "self.message_controller = MessageController(self)" I could not think of any other option there for same | 09:53 |
| exploreshaifali | https://review.openstack.org/#/c/144340/20/zaqar/storage/mongodb/messages.py L873 | 09:53 |
| exploreshaifali | I am sure it will create problmes as there are many things which are not defined in MessageQueueHandler but MessageController's driver is using | 09:55 |
| *** achanda has joined #openstack-zaqar | 10:01 | |
| *** achanda has quit IRC | 10:17 | |
| *** malini has joined #openstack-zaqar | 10:44 | |
| *** achanda has joined #openstack-zaqar | 10:50 | |
| *** achanda has quit IRC | 11:17 | |
| *** pcaruana has joined #openstack-zaqar | 11:19 | |
| *** malini has quit IRC | 11:19 | |
| *** ihrachyshka has joined #openstack-zaqar | 11:19 | |
| *** malini has joined #openstack-zaqar | 11:19 | |
| *** exploreshaifali has quit IRC | 11:27 | |
| *** exploreshaifali has joined #openstack-zaqar | 11:31 | |
| *** dguerri is now known as dguerri`afk | 11:47 | |
| vkmc | morning all | 11:59 |
| kragniz | morning | 11:59 |
| vkmc | how are you kragniz? long time no chat | 12:00 |
| kragniz | I'm pretty good! | 12:00 |
| kragniz | how's things in troveland? | 12:00 |
| vkmc | interesting... would be the word, I think | 12:01 |
| kragniz | what are the interesting bits? | 12:02 |
| vkmc | the features being developed and the discussions around them | 12:03 |
| kragniz | is that interesting good, or interesting bad? | 12:03 |
| * kragniz -> lunch | 12:04 | |
| vkmc | generally good :D | 12:04 |
| vkmc | enjoy it! | 12:04 |
| *** malini has quit IRC | 12:26 | |
| *** malini has joined #openstack-zaqar | 12:26 | |
| *** malini has left #openstack-zaqar | 12:26 | |
| vkmc | \(•◡•)/ | 12:45 |
| vkmc | flaper87, yo yo yo | 12:47 |
| flaper87 | vkmc: yo yo yo yo yo | 12:48 |
| vkmc | flaper87, could you poke someone on globalrequirements? for this? https://review.openstack.org/#/c/156982/ | 12:48 |
| flaper87 | vkmc: yes | 12:48 |
| vkmc | they don't want to give their blessing yet :( | 12:49 |
| flaper87 | vkmc: done | 12:49 |
| vkmc | flaper87, you are da best | 12:50 |
| flaper87 | vkmc: wait for the +2's before you say that :P | 12:51 |
| vkmc | flaper87, haha | 12:51 |
| vkmc | flaper87, what's the status of the gates? let me know how I can help | 12:53 |
| flaper87 | vkmc: mind adding a min_version to the requirements patch? | 12:57 |
| flaper87 | the mongo one should be fixed | 12:58 |
| flaper87 | need to dig in the redis one | 12:58 |
| vkmc | sure | 12:58 |
| *** exploreshaifali has quit IRC | 13:05 | |
| flaper87 | vkmc: meen version ? | 13:11 |
| flaper87 | ern, min* | 13:11 |
| vkmc | https://review.openstack.org/#/c/156982/ | 13:15 |
| vkmc | flaper87, ^ | 13:15 |
| flaper87 | awesome, thanks | 13:16 |
| flaper87 | literally no idea what's going on with the redis gate | 13:27 |
| *** chandankumar has quit IRC | 13:27 | |
| *** mpanetta has joined #openstack-zaqar | 13:35 | |
| *** dynarro has joined #openstack-zaqar | 14:07 | |
| *** exploreshaifali has joined #openstack-zaqar | 14:11 | |
| *** chandankumar has joined #openstack-zaqar | 14:12 | |
| exploreshaifali | flaper87, AttributeError: 'DataDriver' object has no attribute 'queues_database' | 14:16 |
| exploreshaifali | flaper87, MessageQueueHandler that we are defining should have an attribute 'self._collection' | 14:17 |
| exploreshaifali | and its value need 'queues_database' | 14:18 |
| exploreshaifali | https://review.openstack.org/#/c/144340/20/zaqar/storage/mongodb/messages.py L871 | 14:19 |
| exploreshaifali | flaper87, I think we need ControlDriver inside pipeline.py | 14:27 |
| *** chandankumar has quit IRC | 14:36 | |
| openstackgerrit | Shaifali Agrawal proposed openstack/zaqar: Removing QueueController from data to control plane https://review.openstack.org/144340 | 14:36 |
| *** chandankumar has joined #openstack-zaqar | 14:50 | |
| *** csoukup has joined #openstack-zaqar | 14:55 | |
| *** ametts has joined #openstack-zaqar | 14:58 | |
| *** exploreshaifali has quit IRC | 14:59 | |
| *** chandankumar has quit IRC | 15:01 | |
| *** chandankumar has joined #openstack-zaqar | 15:01 | |
| *** chandankumar has quit IRC | 15:02 | |
| *** dynarro has quit IRC | 15:13 | |
| *** malini has joined #openstack-zaqar | 15:30 | |
| *** malini has quit IRC | 15:47 | |
| *** reed has joined #openstack-zaqar | 15:48 | |
| *** malini has joined #openstack-zaqar | 15:52 | |
| *** dynarro has joined #openstack-zaqar | 15:59 | |
| *** kgriffs|afk is now known as kgriffs | 16:04 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:22 | |
| *** malini has quit IRC | 16:31 | |
| *** amitgandhinz has joined #openstack-zaqar | 16:38 | |
| *** pcaruana has quit IRC | 16:50 | |
| *** amitgandhinz has quit IRC | 16:56 | |
| *** ihrachyshka has quit IRC | 17:00 | |
| *** kgriffs is now known as kgriffs|afk | 17:16 | |
| flaper87 | flwang1: http://paste.openstack.org/show/182573/ | 17:25 |
| flaper87 | that's the error in the gate | 17:25 |
| flaper87 | vkmc: ^ | 17:25 |
| flaper87 | exploreshaifali: hey, sorry I was heads down coding | 17:26 |
| exploreshaifali | flaper87, no worries at all :) | 17:26 |
| exploreshaifali | flaper87, so still you are busy ? | 17:26 |
| flaper87 | exploreshaifali: just a tiny bit, lemme figure out the issue with the gate and I'll get back to you | 17:27 |
| exploreshaifali | flaper87, yea :D | 17:27 |
| *** dynarro has quit IRC | 17:29 | |
| vkmc | flaper87, is that the transport driver? | 17:30 |
| flaper87 | vkmc: mmh, it dies while loading it but I believe it's something to do with flwang1's patch | 17:32 |
| flaper87 | not sure | 17:32 |
| flaper87 | we need to improve logging here | 17:32 |
| vkmc | yeah | 17:32 |
| flaper87 | I know what the problem is | 17:36 |
| flaper87 | flwang1: you need to add fake implementations for the subcription methods to zaqar.storage.redis.driver.DataDriver | 17:36 |
| flaper87 | flwang1: actually, I'll do it | 17:38 |
| flaper87 | mmh, but | 17:38 |
| flaper87 | why didn't it fail in my vm | 17:38 |
| flaper87 | OHHHH | 17:38 |
| vkmc | :| | 17:39 |
| flaper87 | because I wasn't testing your freaking patch but vanilla Zaqar | 17:39 |
| flaper87 | I'm an IDIOT! | 17:39 |
| flaper87 | QUE COÑO | 17:39 |
| * flaper87 slaps himself ten times | 17:39 | |
| flaper87 | head -> desk -> air -> desk -> air -> desk | 17:39 |
| flaper87 | I'm a freaking idiot | 17:39 |
| flaper87 | anyway, glad we found it | 17:39 |
| vkmc | looool | 17:39 |
| exploreshaifali | :D | 17:40 |
| flaper87 | jeeeez, so much time wasted | 17:40 |
| flaper87 | we could have figured this out ages ago | 17:40 |
| * vkmc gives flaper87 a poptart | 17:41 | |
| flaper87 | vkmc: I need a shrink | 17:41 |
| flaper87 | I'm going NUTS | 17:41 |
| flaper87 | nuts, nuts. nuts | 17:41 |
| vkmc | you need to take some days off dude | 17:42 |
| flaper87 | vkmc: :( | 17:53 |
| flaper87 | exploreshaifali: here | 17:53 |
| flaper87 | exploreshaifali: turns out the work you're doing for the "builtin" stages will be needed for the work flwang1 is doing | 17:53 |
| exploreshaifali | flaper87, okay | 17:54 |
| flaper87 | exploreshaifali: let me read your questions again | 17:54 |
| flaper87 | exploreshaifali: passing the control driver sounds good to me | 17:56 |
| flaper87 | exploreshaifali: in summary, you'd pass both drivers | 17:56 |
| flaper87 | which gives the builtin stage enough control | 17:56 |
| exploreshaifali | flaper87, you mean adding ControlDriver inside pipeline ? | 17:56 |
| flaper87 | and it should be fine, it's builtin trait | 17:56 |
| flaper87 | erm, fuckit, stage | 17:56 |
| flaper87 | trait is a rust lang thing | 17:56 |
| flaper87 | T_T | 17:57 |
| flaper87 | exploreshaifali: I mean, passing it in the invoke_args | 17:57 |
| *** cpallares has joined #openstack-zaqar | 17:57 | |
| flaper87 | and having it in the MessageQueueHandler | 17:57 |
| flaper87 | exploreshaifali: also, you don't need to call ensure_index from the handler | 17:57 |
| exploreshaifali | flaper87, we are passing args from pipeline's DataDriver where no ControlDriver is defined | 17:58 |
| flaper87 | exploreshaifali: mmh, not sure I follow that | 17:59 |
| exploreshaifali | flaper87, https://review.openstack.org/#/c/144340/21/zaqar/storage/pipeline.py L126 | 17:59 |
| exploreshaifali | from there we are calling _get_builtin_entry_points which is initializing MessageQueueHandler | 18:00 |
| flaper87 | yes, you need to pass self._storage and self.control_driver | 18:00 |
| flaper87 | then, those need to be passed to the entry_point | 18:00 |
| exploreshaifali | flaper87, yes but we are not sure if self.control_driver will not be always Nonw | 18:02 |
| exploreshaifali | None* | 18:02 |
| flaper87 | in what cases can it be None ? | 18:03 |
| flaper87 | AFAICT, it shouldn't have a None default | 18:04 |
| exploreshaifali | flaper87, it is getting called from bootstrap https://review.openstack.org/#/c/144340/21/zaqar/bootstrap.py | 18:07 |
| exploreshaifali | there we are not passing value of control_driver | 18:07 |
| exploreshaifali | L116 | 18:07 |
| flaper87 | exploreshaifali: that's my point, we should :D | 18:08 |
| flaper87 | The point is that all data drivers should have a consistent API | 18:08 |
| flaper87 | if we break consistency (therfore, not always passing what DataDrivers should receive) we'll break the contract | 18:08 |
| flaper87 | and that's not good :( | 18:09 |
| exploreshaifali | flaper87, okay, so while calling pipeline.DataDriver() I will add one more parameter=self.control........... but in case of non-pooling conf storage_driver already have that | 18:13 |
| exploreshaifali | is it okay to send same thing twice? | 18:14 |
| exploreshaifali | its tiny thing so I think it will be okay | 18:14 |
| flaper87 | exploreshaifali: yeah, it shouldn't be an issue | 18:15 |
| exploreshaifali | coool | 18:15 |
| *** cpallares has quit IRC | 18:42 | |
| *** exploreshaifali has quit IRC | 18:55 | |
| *** flwang1 has quit IRC | 19:07 | |
| *** exploreshaifali has joined #openstack-zaqar | 19:30 | |
| *** achanda has joined #openstack-zaqar | 19:45 | |
| *** exploreshaifali has quit IRC | 19:56 | |
| *** flwang1 has joined #openstack-zaqar | 20:10 | |
| *** malini has joined #openstack-zaqar | 20:18 | |
| *** flwang1 has quit IRC | 20:40 | |
| *** mpanetta_ has joined #openstack-zaqar | 20:43 | |
| *** mpanetta has quit IRC | 20:43 | |
| *** flwang1 has joined #openstack-zaqar | 20:44 | |
| *** mpanetta_ is now known as mpanetta | 20:49 | |
| *** malini has quit IRC | 21:26 | |
| *** achanda has quit IRC | 21:34 | |
| *** achanda has joined #openstack-zaqar | 21:35 | |
| flaper87 | flwang1: hey, there? | 22:07 |
| flaper87 | flwang1: pls, read my comment on your review | 22:08 |
| flaper87 | s/review/patch/ | 22:08 |
| *** mpanetta has quit IRC | 22:26 | |
| *** achanda has quit IRC | 22:51 | |
| *** achanda has joined #openstack-zaqar | 23:02 | |
| *** csoukup has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!