opendevreview | liang jiechao proposed openstack/nova-specs master: Generic vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/879338 | 02:09 |
---|---|---|
opendevreview | liang jiechao proposed openstack/nova-specs master: Generic vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/879338 | 02:15 |
opendevreview | liang jiechao proposed openstack/nova-specs master: Generic vdpa spec https://review.opendev.org/c/openstack/nova-specs/+/879338 | 04:45 |
*** elodilles_pto is now known as elodilles | 08:04 | |
opendevreview | Konrad Gube proposed openstack/nova-specs master: Re-propose using extend volume completion action for 2023.2 https://review.opendev.org/c/openstack/nova-specs/+/877233 | 08:38 |
kgube | Hi bauzas, could you have a look at my spec? https://review.opendev.org/c/openstack/nova-specs/+/877233 | 08:50 |
kgube | You had some issues with the implemtentation for Antelope that might be better to discuss at the spec level: https://review.opendev.org/c/openstack/nova/+/873560 | 08:50 |
bauzas | kgube: ack, will try to do todaty | 08:50 |
kgube | thanks! | 08:51 |
sahid | lajoskatona: o/ if that sounds right for you I'm taking the lead to migrate nova on openstacksdk https://etherpad.opendev.org/p/python-neutronclient_deprecation | 11:20 |
lajoskatona | sahid: cool, thanks for checking it | 11:54 |
opendevreview | Alexey Stupnikov proposed openstack/nova stable/xena: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879404 | 12:23 |
opendevreview | Alexey Stupnikov proposed openstack/nova stable/wallaby: Add debug log for scheduler weight calculation https://review.opendev.org/c/openstack/nova/+/879405 | 12:24 |
dansmith | bauzas: what regression do you think the long-wait change introduced? | 13:33 |
bauzas | dansmith: well, I don't really know but the test you modified was hit | 13:33 |
dansmith | uh, okay :) | 13:34 |
dansmith | bauzas: it's failing on create server, I only modified the attach volume line | 13:36 |
dansmith | so I think it's not likely related | 13:36 |
bauzas | ok | 13:36 |
wangrong | dansmith: hello Dan, based on our previous agreement, we have prepared the relevant spec and would like you to review them. If you have any questions, please contact with us anytime. Thank you! | 13:50 |
wangrong | https://review.opendev.org/c/openstack/nova-specs/+/877291 | 13:50 |
dansmith | wangrong: that's my spec that I showed you as an example.. did you paste the wrong link? | 13:51 |
wangrong | dansmith: oh, sorry, my bad... | 13:53 |
wangrong | dansmith: https://review.opendev.org/c/openstack/nova-specs/+/879338 | 13:53 |
wangrong | dansmith: I think this the one we posted | 13:54 |
dansmith | wangrong: cool, sean-k-mooney is the one that needs to do most of the review, but I'll try to take a first stab later today as well | 13:54 |
dansmith | bauzas: also cc ^ as discussed maybe you can provide some early feedback like we promised | 13:54 |
bauzas | cool | 13:54 |
wangrong | sure, thank you very much, so appreciate your help, dansmith, bauzas and sean-k-mooney . | 13:57 |
bauzas | as a reminder, due to European DST change one week before, the nova meeting will be in ~2 hours | 14:02 |
bauzas | (still the same UTC time, in case you're not in Europe) | 14:03 |
TheJulia | Are there any known issues on grenade from 2023.1 to master in regards to flavors? Specifically we're seeing a ~40% failure rate for grenade jobs on ironic, nova is specifically reporting the flavor baremetal is not found when it was added 5+ minutes earlier in the logs. Looks like post-create (200 response code), a lookup for it immediately fails with a 404. | 15:11 |
TheJulia | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b1d/879215/3/check/ironic-grenade/b1d6cf4/controller/logs/screen-n-api.txt | 15:11 |
TheJulia | and the returned flavor does indicate it is public, btw. | 15:17 |
sean-k-mooney | it might be related to srbac | 15:37 |
sean-k-mooney | tempest need to be using proejct scoped tokens | 15:37 |
sean-k-mooney | but im not really aware of anythng that woudl cause that other then srbac | 15:37 |
sean-k-mooney | and i would not expect it to be flaky in that case | 15:38 |
sean-k-mooney | so im not sure what explains the 40% rate | 15:38 |
bauzas | gentle reminder : nova meeting in 10 mins here | 15:50 |
frickler | TheJulia: I think that 404 is a red herring, it is OSC first trying to use the name_or_id parameter as ID. you should see the same in passing runs | 15:59 |
bauzas | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Apr 4 16:00:04 2023 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
bauzas | hey folks | 16:00 |
bauzas | hope you had a good PTG | 16:00 |
Uggla | o/ | 16:00 |
bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:00 |
elodilles | o/ | 16:00 |
* bauzas again misses all of you | 16:00 | |
TheJulia | sean-k-mooney: I looked at the query on the db, just looks like it is not there based upon the error. Only option I have is to attempt local reproduction most likely. | 16:00 |
auniyal | o/ | 16:01 |
bauzas | TheJulia: sorry but we just started our weekly meeting | 16:01 |
TheJulia | I'm aware | 16:01 |
* bauzas awaits for folks to be arriving | 16:01 | |
dansmith | o/ | 16:01 |
gibi | o/ | 16:02 |
bauzas | ok, let's start then | 16:03 |
bauzas | #topic Bugs (stuck/critical) | 16:03 |
bauzas | #info No Critical bug | 16:03 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 22 new untriaged bugs (+5 since the last meeting) | 16:03 |
bauzas | sorry I didn't had time to look at all the bugs | 16:03 |
bauzas | that said, I think we could quickly close some of them when I just opened ^ | 16:04 |
bauzas | so, | 16:04 |
bauzas | I'll continue to have the bug baton for this weeek | 16:04 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:04 |
bauzas | #info bug baton is being passed to bauzas | 16:04 |
bauzas | any bug to discuss before we move ? | 16:04 |
bauzas | looks not | 16:05 |
bauzas | #topic Gate status | 16:06 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:06 |
bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures | 16:06 |
bauzas | I need to look again on the ci failures | 16:06 |
dansmith | I haven't had anything in the gate since before PTG, but it sounds like things are sucking a gain? | 16:06 |
bauzas | I saw some other issues so I'll try to verify whether they are a lot | 16:06 |
bauzas | dansmith: unfortunately yes, see for example https://review.opendev.org/c/openstack/nova/+/875621 and https://review.opendev.org/c/openstack/nova/+/878693 | 16:07 |
bauzas | anyway, let's move on | 16:08 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:08 |
bauzas | all greens :) | 16:09 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:09 |
bauzas | #info STOP DOING BLIND RECHECKS aka. 'recheck' https://docs.openstack.org/project-team-guide/testing.html#how-to-handle-test-failures | 16:09 |
bauzas | that's it | 16:09 |
bauzas | moving on ? | 16:09 |
bauzas | looks so | 16:11 |
bauzas | #topic Release Planning | 16:11 |
bauzas | #link https://releases.openstack.org/bobcat/schedule.html | 16:11 |
bauzas | #link https://review.opendev.org/c/openstack/releases/+/877094 Proposed deadlines for Bobcat | 16:11 |
gmann | o/ | 16:11 |
bauzas | as I said on Friday, I eventually provided a new revision | 16:11 |
bauzas | #link https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_2b8/877094/3/check/openstack-tox-docs/2b8febf/docs/bobcat/schedule.html Generated HTML for proposed deadlines | 16:11 |
bauzas | please review those dates | 16:12 |
bauzas | before tomorrow | 16:12 |
bauzas | #info Nova contributors should review this change before tomorrow 1600UTC. | 16:12 |
bauzas | I added one stable review day | 16:12 |
bauzas | and I added a second feature review day | 16:12 |
bauzas | on milestone-1 we could review the stable branches | 16:13 |
elodilles | ++ | 16:13 |
bauzas | then we'll have one spec review day *before* the summit | 16:13 |
bauzas | and another one two weeks after the summit (one week before spec feature freeze) | 16:13 |
bauzas | spec approval freeze sorry | 16:14 |
bauzas | then, on the day after the spec approval freeze, we could review some series from accepted blueprints | 16:14 |
bauzas | and eventually, a second implementation review day the last week of July | 16:15 |
bauzas | (which would be 5 weeks before FF) | 16:15 |
bauzas | that's it. | 16:16 |
bauzas | we could review some series on the week before FF, but honestly, I think it's late (and also I'll just be back from PTO) | 16:16 |
bauzas | so I'd prefer to tell the blueprints owners to provide their series one month before (as we also discussed during the PTG) | 16:17 |
bauzas | anyway, as a reminder, please review https://review.opendev.org/c/openstack/releases/+/877094 before tomorrow 1600UTC | 16:17 |
bauzas | again, that's it on this topic for me | 16:18 |
bauzas | moving on, I guess | 16:19 |
bauzas | oh, last point | 16:19 |
bauzas | #info Bobcat-1 is in 5 weeks. | 16:19 |
opendevreview | Merged openstack/nova master: Update min support for Bobcat https://review.opendev.org/c/openstack/nova/+/875621 | 16:19 |
bauzas | woooohoooooooooooooooooooooooo | 16:19 |
bauzas | ^ | 16:19 |
bauzas | so, next topic | 16:20 |
bauzas | #topic vPTG feedback | 16:20 |
bauzas | #link https://lists.openstack.org/pipermail/openstack-discuss/2023-April/033124.html | 16:20 |
bauzas | I provided an email summary ^ | 16:20 |
bauzas | btw. heh, sorry about s/NFV/NFS :p | 16:20 |
bauzas | -ETOOMANYNETWORKINGDISCUSSIONS | 16:21 |
elodilles | :) | 16:21 |
bauzas | anyway, it was more a FYI | 16:21 |
bauzas | #topic Review priorities | 16:21 |
bauzas | #link https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement+OR+project:openstack/os-traits+OR+project:openstack/os-resource-classes+OR+project:openstack/os-vif+OR+project:openstack/python-novaclient+OR+project:openstack/osc-placement)+(label:Review-Priority%252B1+OR+label:Review-Priority%252B2) | 16:21 |
bauzas | #info As a reminder, cores eager to review changes can +1 to indicate their interest, +2 for committing to the review | 16:21 |
bauzas | next topic | 16:22 |
bauzas | #topic Stable Branches | 16:22 |
bauzas | elodilles: before I'm asking you, let me first add something :) | 16:22 |
elodilles | sure :) | 16:22 |
bauzas | #link https://review.opendev.org/c/openstack/releases/+/878860 Xena stable branche EM proposal | 16:22 |
bauzas | so, | 16:22 |
bauzas | I said last week we should discuss the Xena EM approval this week | 16:22 |
bauzas | #link https://review.opendev.org/q/project:openstack/nova+branch:stable/xena+is:open | 16:23 |
bauzas | those are the open changes we have | 16:23 |
bauzas | so, question | 16:23 |
opendevreview | Rajesh Tailor proposed openstack/nova master: Fix trivial doc issues https://review.opendev.org/c/openstack/nova/+/878779 | 16:23 |
bauzas | does anyone want to have their series be merged in xena before we EM ? | 16:24 |
*** iurygregory_ is now known as iurygregory | 16:24 | |
bauzas | as a reminder, we can continue to merge patches in that branch | 16:24 |
bauzas | this is just we won't have an upstream .z or .y release after EM tag | 16:25 |
bauzas | anyone ? | 16:25 |
auniyal | this is a clean backport for xena https://review.opendev.org/c/openstack/nova/+/874066 | 16:25 |
elodilles | just an addition to what bauzas said: anyone see any patch that "would be good to get merged & released as final"? | 16:26 |
elodilles | in xena | 16:26 |
bauzas | elodilles: maybe we could wait for https://review.opendev.org/c/openstack/nova/+/866156 to be merged | 16:26 |
bauzas | since it's a bit of a regression | 16:26 |
bauzas | and yoga was merged | 16:27 |
elodilles | btw, we have a tracking pad if needed: https://etherpad.opendev.org/p/nova-stable-xena-em | 16:27 |
elodilles | so we can add these patches there ^^^ | 16:27 |
sean-k-mooney | ill review that backport now | 16:27 |
bauzas | auniyal: the problem is that the patch you proposed needs to have its yoga backport approved before | 16:27 |
elodilles | and (stable) cores could review them when they have time | 16:27 |
elodilles | i can also help with some reviews hopefully | 16:28 |
bauzas | elodilles: remind me when the deadline for Xena EM is ? | 16:28 |
auniyal | yeah my bad its not merged in yoga | 16:28 |
elodilles | well, the transition date is April 20th | 16:28 |
elodilles | should be good to release earlier though | 16:29 |
bauzas | ok, then we'll track the progress every week | 16:29 |
bauzas | and every week, I'll ask the question | 16:29 |
elodilles | maybe we can see if next week we can cut a release | 16:29 |
bauzas | in the meantime, people can merge whatever they want | 16:29 |
bauzas | elodilles: yup | 16:29 |
bauzas | don't disagree | 16:29 |
elodilles | note also, that we had a xena release around end of january (24.2.0) | 16:30 |
bauzas | #link https://etherpad.opendev.org/p/nova-stable-xena-em Tracking etherpad for Xena | 16:30 |
elodilles | so really the open patches is mostly the ones that we need to consider | 16:30 |
sean-k-mooney | bauzas: i have approved the mdev patch | 16:31 |
bauzas | #info please tell the nova community which patches you want to have to be released before next week by pinging bauzas on IRC | 16:31 |
sean-k-mooney | just skimin gthe open ones now | 16:31 |
bauzas | cool thanks | 16:31 |
bauzas | anyway, elodilles, add your points now | 16:31 |
elodilles | ++ | 16:31 |
elodilles | well, there is nothing left just the usual | 16:31 |
elodilles | #info stable gates seem to be OK - though it's hard to merge patches due to intermittent failures | 16:31 |
elodilles | #info stable branch status / gate failures tracking etherpad: https://etherpad.opendev.org/p/nova-stable-branch-ci | 16:31 |
bauzas | cool | 16:33 |
bauzas | last topic then | 16:33 |
bauzas | #topic Open discussion | 16:33 |
bauzas | the agenda is empty | 16:33 |
auniyal | so I was looking for backports in 2023.1, zed and yoga | 16:33 |
bauzas | anyone wants to discuss about something that we missed at the PTG ? | 16:33 |
gibi | bauzas: the lower constraint job discussion was punted last week | 16:34 |
bauzas | gibi: yup, I haven't asked you if you wanted to discuss about it today | 16:35 |
gibi | bauzas: I have not much to add to what was in the current or in the previous PTG etherpad just that I have the intention to add a limited lower constraint job | 16:35 |
bauzas | gibi: do you want now ? | 16:35 |
gibi | we can | 16:35 |
bauzas | cool | 16:35 |
bauzas | (we also have other punted topics, but again, those were not prioritary for this week) | 16:36 |
bauzas | gibi: so, shoot | 16:36 |
gibi | yeah, this is not priority either | 16:36 |
bauzas | we discussed your topic briefly | 16:36 |
bauzas | concerns were coming from any potential transitive dependencies and the scope | 16:36 |
gibi | so I see that sean-k-mooney prefer not to have it | 16:37 |
bauzas | we said this was for unittests and functionaltests | 16:37 |
dansmith | gmann also had comments I think | 16:37 |
gibi | so the scope is intentionally limited | 16:37 |
bauzas | correct | 16:37 |
sean-k-mooney | i do not wnat nova to be the only ones to have it if we do i would prefer it to be a perodic | 16:37 |
gibi | so run unit and functional test, only with the some of our direct depds pinned to lowest | 16:37 |
bauzas | and if I'm not wrong, this wouldn't be having transitive deps in the filez | 16:37 |
bauzas | file | 16:37 |
gibi | no transitives yes | 16:37 |
sean-k-mooney | im more or less ok with that but limitation | 16:38 |
bauzas | ok, then I wasn't wrong | 16:38 |
dansmith | I didn't hear the pitch about why we should, but I too am a bit skeptical | 16:38 |
bauzas | dansmith: it was due to a regression we had with os-traits | 16:38 |
bauzas | we modified the code by using the new traits | 16:38 |
gibi | dansmith: in Zed we released nova code that depended on os-traits versions but we forgot to bump the version | 16:38 |
gmann | gibi: did you try how it will run with nova as lower bound and other deps's deps as upper bound ? | 16:38 |
bauzas | that yeah | 16:38 |
gibi | gmann: not yet, I had some local trials but mostly got sidetracked | 16:38 |
gmann | I am ok to run unit test lower bound job but just wondering how complex it will be to setup and keep green | 16:39 |
dansmith | traits is kinda weird though right? we sort of always need that to move in lockstep with our usage of it yeah/ | 16:39 |
gmann | gibi: ack | 16:39 |
dansmith | so requirements and the lower constraint is always the same? | 16:39 |
dansmith | it's not like libvirt where we actually want to support a range of older and newer versions | 16:39 |
gibi | dansmith: yeah, in case of os-traits we have a fairly hard connection | 16:40 |
gmann | I think we need to keep lower constraint file as requirements.txt constraints might be higher than lowest supported versions | 16:40 |
dansmith | so was the miss that we always get the latest os-traits from other stuff and we didn't notice we needed a bump? | 16:40 |
sean-k-mooney | gmann: they should not be | 16:40 |
gmann | or gibi you want to test what we have in requirements.txt as lower bound and not actual lower bound ? | 16:40 |
gibi | gmann: I thought that the minimum in requiremenets.txt is the lowest we need to test with | 16:40 |
gmann | ok | 16:40 |
sean-k-mooney | requirements has our lower bound | 16:40 |
sean-k-mooney | while lower version might work if you dont use all features | 16:41 |
gmann | sean-k-mooney: yeah but they are no guaranteed to be lowest bound, we can have b>8 where it might work b==6 also | 16:41 |
gibi | dansmith: os-vif is a bit softer, i.e. lower != higher, but we can break the dep the same way | 16:41 |
dansmith | that's true of libvirt but probably less so os-traits | 16:41 |
sean-k-mooney | gmann: if you use somthing older then in in requiremtns i would say thats an unsupported config | 16:41 |
dansmith | so is the proposal to maintain a separate list, or to sed the >= out of requirements.txt? | 16:42 |
bauzas | do people say we shall pin our versions in reqs.txt ? | 16:42 |
gmann | that is why there are two things 1. test what we have lower bound in requirements.txt 2. test actual lower(st) bound work for nova | 16:42 |
gibi | dansmith: basically sedding the requirements.txt | 16:42 |
dansmith | gibi: okay if it's that, and periodic, then I'm okay with it.. what I don't want is a second list and pre-merge testing (just because of the load) | 16:42 |
sean-k-mooney | we dont want to do 2 | 16:42 |
bauzas | hah | 16:42 |
bauzas | so, s/>=/== then ? | 16:43 |
sean-k-mooney | we could do 1 | 16:43 |
gibi | dansmith: ack, I'm OK to make it periodic | 16:43 |
gmann | yeah, doing 2 is difficult | 16:43 |
bauzas | automatically from reqs.txt ? | 16:43 |
dansmith | bauzas: yeah, I think that's reasonable | 16:43 |
sean-k-mooney | i would say 2 is a non goal | 16:43 |
gibi | bauzas: that is the idea | 16:43 |
gmann | I am ok to doing 1 and even in check pipeline as unit test also ok | 16:43 |
gmann | sean-k-mooney: yes | 16:43 |
bauzas | so a specific tox target ? | 16:43 |
gibi | bauzas: yepp | 16:43 |
bauzas | to -epy38-min ? | 16:43 |
gmann | yeah, that will be helpful to check locally also | 16:44 |
bauzas | ok, then I don't disagree the idea | 16:44 |
dansmith | a specific tox target that runs both in a single go would be nice to avoid needing separate unit/functional jobs yeah | 16:44 |
bauzas | I see | 16:44 |
dansmith | and I'd prefer periodic until/unless we see it breaking more often | 16:44 |
gibi | sean-k-mooney, gmann : I agree to aim for 1. If somebody want to find the real lower bound (i.e 2) then that person can play with the requirements.txt and with the new job | 16:44 |
bauzas | so the tox target would call out a script that would copy/sed reqs.txt by pinning to the mins | 16:44 |
gmann | gibi: agree | 16:45 |
gibi | bauzas: yeah | 16:45 |
bauzas | and the gate would periodically run a job that would call this target | 16:45 |
bauzas | then I don't disagree | 16:45 |
gibi | cool | 16:45 |
gibi | I see an agreement forming :) | 16:45 |
bauzas | anyone having concerns ? | 16:45 |
gibi | (now I need to find the time to do the scripting) | 16:46 |
bauzas | say it now or forever hold your peace | 16:46 |
bauzas | crickets, all cool | 16:46 |
gibi | thanks | 16:46 |
gibi | and sorry again for missing the firday sessions | 16:46 |
gibi | Friday even | 16:46 |
bauzas | #agreed gibi to work on a new tox target that would run unittests with a pinned min version of reqs.txt, with a periodic job testing it weekly | 16:47 |
bauzas | gibi: I guess you may want to do it as well for functional tests but this doesn't harm to me | 16:47 |
gibi | bauzas: yeah, lets see the unit first, adding functional to it is easy then | 16:48 |
bauzas | cool | 16:48 |
bauzas | I think dust is settled now | 16:48 |
bauzas | anything else before I call it a wrap ? | 16:48 |
auniyal | bauzas, I dont have anything w.r.t PTG missing item, can we discuss few backports ? | 16:48 |
gibi | I've updated the etherpad with the link to this meeting log | 16:48 |
bauzas | gibi: excellent for tracking decisions | 16:49 |
bauzas | auniyal: are you asking for specific change reviews ? | 16:49 |
auniyal | I have few backports which can be merged mostly for zed and yoga, I have reviewed them from my end, I would like to request cores to review them | 16:49 |
bauzas | if so, I'd prefer if you could ping folks off the meeting | 16:49 |
bauzas | (we generally try to avoid review requests during the meeting, for obvious reasons) | 16:50 |
auniyal | okay | 16:50 |
bauzas | (the main one is brevity) | 16:50 |
bauzas | ok, so, last call ? | 16:50 |
bauzas | thanks all | 16:51 |
bauzas | #endmeeting | 16:51 |
opendevmeet | Meeting ended Tue Apr 4 16:51:56 2023 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:51 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.html | 16:51 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.txt | 16:51 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2023/nova.2023-04-04-16.00.log.html | 16:51 |
gibi | o/ | 16:51 |
elodilles | thanks o/ | 16:52 |
bauzas | that's also it for me today | 16:53 |
bauzas | see ya folks | 16:53 |
bauzas | for the fun, I want to test virtiofs on my laptop with a windows guest :) | 16:54 |
bauzas | waaah that works with winfcp | 16:57 |
dansmith | gibi: sean-k-mooney: can ya'll hit this at some point: https://review.opendev.org/c/openstack/nova/+/878238 | 17:01 |
dansmith | related to a recent conversation we had | 17:01 |
gibi | dansmith: added to my list | 17:04 |
dansmith | thanks | 17:04 |
opendevreview | Dan Smith proposed openstack/nova master: Add compute_id column to instances table https://review.opendev.org/c/openstack/nova/+/879499 | 17:42 |
opendevreview | Dan Smith proposed openstack/nova master: Add compute_id to Instance object https://review.opendev.org/c/openstack/nova/+/879500 | 17:42 |
dansmith | anyone else having trouble with the fast8 target? it's complaining about python not being in the list of allowed externals, presumably because of the install_command override | 17:45 |
dansmith | adding it causes it to fail install because it tries to install nova to my /usr/local instead of the venv | 17:46 |
dansmith | other targets don't seem to have any problems | 17:46 |
clarkb | python shouldn't be in externals because it is in the venv | 17:48 |
dansmith | I know that's how it should work | 17:48 |
dansmith | okay I blew away .tox and it may be working | 17:50 |
dansmith | I cleaned a(n apparently very old) .tox/fast8 before and it didn't fix it, but I think because flake8 now uses .tox/shared | 17:50 |
dansmith | so removing that seems to have fixed it up | 17:50 |
dansmith | I dunno how it got confused about that, but it was the python pip install on the nova package that it was failing with that error | 17:51 |
dansmith | so maybe something to do with me recently upgrading to py311 on my system | 17:51 |
dansmith | yeah, that worked | 17:51 |
dansmith | the pep8 target worked, but I guess it doesn't use the shared venv so I guess it got rebuilt and the one fast8 uses didn't trigger it or soemthing | 17:54 |
sean-k-mooney | it could be related to the fact we now dont set useddevelop | 17:59 |
sean-k-mooney | or what ever | 17:59 |
dansmith | we still do for all the regular venvs, AFAICT | 18:01 |
dansmith | I think it's more likely a stale bin/python link in that venv pointing to the old python3.10 on my system or something | 18:01 |
sean-k-mooney | as in i cant fine the sepcific thing i was likign for | 18:01 |
sean-k-mooney | it might be related to this https://github.com/openstack/nova/commit/5e5b6751d32aa50dc372c55b5c2044d0dade51f4 | 18:02 |
sean-k-mooney | but i toug we change how ew used sdigts | 18:02 |
sean-k-mooney | i tought we did somethign for tox 4 | 18:02 |
dansmith | yeah, that added isntall_command which was the problem | 18:02 |
sean-k-mooney | ok ya that was the tox 4 change https://review.opendev.org/c/openstack/nova/+/869545 | 18:03 |
sean-k-mooney | i tought thact actully bumped the min version to 4 but it did not | 18:04 |
sean-k-mooney | just made it compatible | 18:04 |
sean-k-mooney | dansmith: im going to call it a day but this is the youtube link i added to the vdpa spec https://www.youtube.com/watch?v=zyDSUU0TLB4 its not that long but it answered some of my questions | 18:55 |
dansmith | I saw the link but haven't watched it | 18:55 |
dansmith | cool | 18:55 |
sean-k-mooney | i think we are going to want two flags hw_disk_bus=vdpa-blk and then a second flag for if it requires hardware offload | 18:56 |
sean-k-mooney | if we want to supprot the software and hardware backends eventually | 18:56 |
dansmith | hmm okay I guess I don't know why we'd need two flags, but I'm sure it's ignorance.. I'll watch, we can chat tomorrow or later | 18:57 |
sean-k-mooney | well its vdpa-blk in the guest in either caes but ya watch the vid and we can chat about it whenever | 18:57 |
sean-k-mooney | o/ | 18:57 |
dansmith | o/ | 18:58 |
opendevreview | Merged openstack/nova stable/yoga: db: Resolve additional SAWarning warnings https://review.opendev.org/c/openstack/nova/+/874065 | 19:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!