*** bauzas_ is now known as bauzas | 01:26 | |
*** __ministry is now known as Guest1582 | 02:17 | |
*** __ministry is now known as Guest1587 | 04:07 | |
gibi | sean-k-mooney: I have no preference between eventlet an healthcheck. I will take a look at the healthcheck series today | 07:03 |
---|---|---|
gibi | sean-k-mooney: on the timer, I will reply in the review | 07:09 |
*** __ministry is now known as Guest1598 | 07:22 | |
*** bauzas_ is now known as bauzas | 07:25 | |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: functional: Handle multiple networks https://review.opendev.org/c/openstack/python-novaclient/+/927249 | 10:09 |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: tox: Add Python-specific functional envs https://review.opendev.org/c/openstack/python-novaclient/+/927250 | 10:09 |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: Fix Python 3.12 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/927251 | 10:09 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927254 | 10:44 |
*** bauzas_ is now known as bauzas | 13:23 | |
*** __ministry is now known as Guest1625 | 13:59 | |
bauzas | that's been a while but we'll have a nova meeting here in 50 mins | 15:11 |
stephenfin | sean-k-mooney: Here's the fix for the novaclient issue https://review.opendev.org/c/openstack/python-novaclient/+/927249/ I know you were saying that should test the default configuration of auto-configuring a network, but that will never work with multiple possible networks. If we want to test that properly we'll need a separate job that removes e.g. the share network, but that seems like overkill | 15:15 |
stephenfin | So hopefully the bit of logic I've copied in there if sufficient | 15:15 |
sean-k-mooney | the legacy test is testing before the auto network feature was added | 15:15 |
sean-k-mooney | so ya the issue here is that the job is not conigured to allw the test to run | 15:16 |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: functional: Handle multiple networks https://review.opendev.org/c/openstack/python-novaclient/+/927249 | 15:16 |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: tox: Add Python-specific functional envs https://review.opendev.org/c/openstack/python-novaclient/+/927250 | 15:16 |
opendevreview | Stephen Finucane proposed openstack/python-novaclient master: Fix Python 3.12 compatibility https://review.opendev.org/c/openstack/python-novaclient/+/927251 | 15:16 |
stephenfin | (just spotted so leftover print statements) | 15:16 |
sean-k-mooney | i saw them | 15:16 |
stephenfin | s/so/some/ | 15:16 |
sean-k-mooney | but my point it this is ment to be testing when we do not specify a nic | 15:16 |
sean-k-mooney | so adding a nic invaldiates the test | 15:16 |
stephenfin | so do we add a skipTest if self.multiple_networks? | 15:17 |
sean-k-mooney | it would be better to use the skip test funciontion if we detect multiple networks | 15:17 |
sean-k-mooney | yep that was one of the opetions | 15:17 |
sean-k-mooney | i was also lookig at modifyitg the job to remove the share network | 15:17 |
stephenfin | though I'll note there's nothing in the test name or docstring that says this needs to rely on being able to auto-configure a network | 15:18 |
sean-k-mooney | its not | 15:18 |
stephenfin | so what makes you say that we're testing that? | 15:18 |
sean-k-mooney | auto configuring the network is an diffent feature then we are testing | 15:18 |
stephenfin | right, but we're testing the '--image-with' falg | 15:18 |
stephenfin | *flag | 15:18 |
sean-k-mooney | this is testing the bahvior or there is only one network | 15:18 |
stephenfin | having to/not to pass the '--nic' option is secondary to the main test, from the looks of things? | 15:19 |
sean-k-mooney | which is diffent then auto config which will create it if there is none | 15:19 |
stephenfin | right, but do we care? that's not the aim of this test | 15:19 |
sean-k-mooney | it is the aim to ensure that the old command line argument work as openstack evolves | 15:19 |
sean-k-mooney | at least fo the legacy version that is testin 2.1 | 15:20 |
sean-k-mooney | stephenfin: if we have a sperate test case for this then im fine with changing this one | 15:20 |
stephenfin | Again, right, but the test is testing the '--image-with' option, not the '--nic' option (or lack thereof). My change proves the '--image-with' option works on both 2.1 and 2.latest | 15:20 |
stephenfin | okay, lemme see | 15:20 |
sean-k-mooney | i think this is the only test without a nic specifed | 15:21 |
stephenfin | that was easy. It's a short file. None there. Do we add one (with the skip)? | 15:21 |
stephenfin | relying on there only being one test seems fairly fragile and would prevent us running said tests against a local devstack (at least without doing what CI does and e.g. deleting the 'shared' network) | 15:22 |
stephenfin | *one network | 15:22 |
sean-k-mooney | so i think this regression was intoduced by https://github.com/openstack/devstack/commit/24b65adc9cedff9c7a8ab412fb39613ef5d4a627 | 15:24 |
stephenfin | Hardly. That's there since yoga | 15:24 |
stephenfin | per the GitHub UI anyway | 15:24 |
sean-k-mooney | maybe not but was srbac enabeld in neutron by default for that long | 15:25 |
sean-k-mooney | ok im torn personally i want to remvoe the cli testing and the shell module | 15:26 |
sean-k-mooney | on the other hand while its there we shoudl nto reduce test coverage | 15:26 |
sean-k-mooney | so if you want to add a test taht will skip if multiple networks i guess that fine | 15:26 |
sean-k-mooney | but it also kind of useless without fixing the ci | 15:26 |
stephenfin | agreed | 15:26 |
stephenfin | maybe we just merge that and move on with our lives? 🤷 | 15:26 |
stephenfin | undoubtedly better than making the whole thing non-voting | 15:27 |
sean-k-mooney | if we do then i think we need to delete the cli next cycle | 15:27 |
stephenfin | perfect is the enemy of the good | 15:27 |
stephenfin | etc. etc. | 15:27 |
sean-k-mooney | well no voting was just a precuisor to deleting it | 15:27 |
sean-k-mooney | we can see what people think in the nova meeting in 30 mins | 15:28 |
stephenfin | ack | 15:28 |
sean-k-mooney | if they are fine with our patch then we can merge it but i dicussed this with melwitt last week and we wanted to wait for the team meeting | 15:29 |
sean-k-mooney | as in i discussed skiping or modifying the test to work with multiple networks | 15:29 |
*** __ministry is now known as Guest1632 | 15:55 | |
bauzas | #startmeeting nova | 16:01 |
opendevmeet | Meeting started Tue Aug 27 16:01:36 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:01 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:01 |
opendevmeet | The meeting name has been set to 'nova' | 16:01 |
bauzas | hey folks | 16:01 |
bauzas | sorry, that's been so long, maybe you forgot about it | 16:01 |
gibi | never! | 16:02 |
fwiesel | o/ | 16:02 |
elodilles | o/ | 16:02 |
sean-k-mooney | o/ | 16:03 |
auniyal | o/ | 16:03 |
bauzas | cool folks | 16:03 |
bauzas | let's start then :) | 16:03 |
bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:03 |
bauzas | #topic Bugs (stuck/critical) | 16:04 |
bauzas | #info No Critical bug | 16:04 |
bauzas | (glad to hear it) | 16:04 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:04 |
bauzas | any important bug people would want to discuss ? | 16:04 |
bauzas | I was off for 3 weeks so I don't really know | 16:04 |
bauzas | looks no | 16:06 |
bauzas | moving on | 16:06 |
sean-k-mooney | novaclint is blokced but we will talk about that later | 16:06 |
bauzas | okay | 16:06 |
bauzas | #topic Gate status | 16:06 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:06 |
bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:06 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:07 |
bauzas | all greens | 16:07 |
bauzas | (well, we have a stable/zed job done, but meh) | 16:07 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:07 |
bauzas | #info Please try to provide meaningful comment when you recheck | 16:07 |
bauzas | moving on ? | 16:08 |
bauzas | #topic Release Planning | 16:08 |
bauzas | #link https://releases.openstack.org/dalmatian/schedule.html | 16:08 |
bauzas | #info Dalmatian-3 in 1 week | 16:09 |
bauzas | #info non-client library freeze happened last week | 16:09 |
bauzas | #info client library freeze this week | 16:09 |
bauzas | sean-k-mooney: want to discss the novaclient issue ? | 16:09 |
dansmith | I kinda have something for release planning | 16:10 |
sean-k-mooney | we have 2 issues | 16:10 |
sean-k-mooney | the first one is just a ci job issue | 16:10 |
bauzas | okay, tell me both | 16:10 |
sean-k-mooney | the functioanl job is exepcting there to only be one network | 16:10 |
sean-k-mooney | there are now 2 | 16:10 |
sean-k-mooney | so 2 tests fail | 16:10 |
sean-k-mooney | we can update them to skip or modify them to use the first network | 16:11 |
sean-k-mooney | stephenfin: has a patch for the latter | 16:11 |
sean-k-mooney | the second issue is the cli does not work on python 3.11 | 16:11 |
bauzas | this is a priority before we release novaclient IMHO | 16:11 |
sean-k-mooney | it was deprecated when the newest veriohn we supproted was 3.9 | 16:11 |
sean-k-mooney | so i think we need to look at removing the nova client cli in 2025.1 and the python bidnign by 2026.1 | 16:12 |
sean-k-mooney | that is a ptg discussion that im hopign melwitt and stephenfin can partake in | 16:12 |
sean-k-mooney | to actully do that we need to dicsuss with neutron and heat to get them to swap to the sdk | 16:13 |
bauzas | https://github.com/openstack/python-novaclient/blob/master/setup.cfg#L22-L24 | 16:13 |
bauzas | are you saying that we don't have any job testing 3.11 ? | 16:13 |
sean-k-mooney | we do and it fails | 16:13 |
sean-k-mooney | but we deprecated the cli before that | 16:13 |
sean-k-mooney | so the cli has not been updated to supprot py311 | 16:14 |
bauzas | oh, you're saying the deprecation of the CLI | 16:14 |
bauzas | I see | 16:14 |
sean-k-mooney | the 3.11 issue is a change in argparse behavior | 16:14 |
sean-k-mooney | so only affect the cli | 16:14 |
bauzas | this is deprecated, but we could provide some exception telling "sorry, we only support up to 3.9 for the CLI" | 16:14 |
sean-k-mooney | anyway there are two patches to fix the 3.11 issue | 16:14 |
sean-k-mooney | so the main question is do we quickly fix this for 2024.2 | 16:15 |
bauzas | we could backport such patches then | 16:15 |
sean-k-mooney | and then look at removing the shell in 2025.1/2 | 16:15 |
bauzas | I think we should rather just fix the 3.11 issues | 16:16 |
sean-k-mooney | actully we can dicussss post 2024.1 at the ptg | 16:16 |
bauzas | we can write some relnote before we release explaning the status of the CLI if you wan | 16:16 |
bauzas | want* | 16:16 |
sean-k-mooney | well the cil is deprecated for removal | 16:16 |
sean-k-mooney | so unless we are going to set a release there is no point | 16:17 |
sean-k-mooney | im hoping to deprecate the entire project in 2025.1 | 16:17 |
bauzas | at a previous PTG, we said we preferred to defer the removal | 16:17 |
elodilles | with the relmgt hat on, i like the idea of landing the two patch that fixes the gate o:) (thanks sean-k-mooney for bringing this topic up :)) | 16:17 |
bauzas | there are people continuing to run scrips with the CLI | 16:17 |
sean-k-mooney | ok then all we need to do is see if we are happy with stephenfin patch for functional | 16:17 |
sean-k-mooney | and then we can merge one of the two patches for 3.11 | 16:17 |
sean-k-mooney | and backport those to stable branches | 16:18 |
sean-k-mooney | if needed | 16:18 |
bauzas | could you please add all the patches in the release etherpad if they're not there yet ? | 16:18 |
bauzas | for tracking | 16:18 |
sean-k-mooney | yep | 16:18 |
bauzas | thanks | 16:18 |
bauzas | do both of the problems have bug reports against them ? | 16:18 |
sean-k-mooney | yes i think so | 16:18 |
bauzas | cool | 16:18 |
bauzas | sean-k-mooney: thanks for helping | 16:18 |
bauzas | dansmith: you had a comment | 16:19 |
elodilles | yepp, thanks sean-k-mooney \o/ | 16:19 |
dansmith | bauzas: release-wise, i think it's critical that we get this into 2024.2: https://review.opendev.org/c/openstack/nova/+/925025 | 16:19 |
dansmith | it will reduce the number of releases where we carry the format_inspector stuff, | 16:19 |
dansmith | and the sooner we get that in the more coverage we'll get before the release | 16:19 |
bauzas | good point | 16:20 |
bauzas | I'll add it to the tracker | 16:20 |
dansmith | just made the oslo release, so we should take advantage of it | 16:20 |
gibi | I can start my tomorrow on that commit | 16:20 |
bauzas | ++ | 16:20 |
dansmith | gibi: thanks | 16:20 |
bauzas | I can review that patch | 16:20 |
bauzas | (I actually reviewed the first patch that added the module :) ) | 16:20 |
dansmith | -1741 +55 | 16:21 |
dansmith | pretty good stats :) | 16:21 |
gibi | dansmith: nice work! | 16:21 |
bauzas | yeah, thanks for having worked on it from the last semester :) | 16:21 |
dansmith | yeah, I'm sick of it :) | 16:21 |
bauzas | I don't guess the reason why :-P | 16:21 |
bauzas | (jk) | 16:22 |
bauzas | anyway, moving on, I'll review that patch and gibi too | 16:22 |
bauzas | release-wise too, I'll start adding the procedural patches we usually merge before RC1 | 16:22 |
bauzas | the rpcapi pins, etc. | 16:23 |
bauzas | #topic Review priorities | 16:23 |
bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:24 |
bauzas | I'll start scrubbing that list and identify the series that are impacted by the client freeze and need to be punted | 16:24 |
* sean-k-mooney added the nova clinet patches https://etherpad.opendev.org/p/nova-dalmatian-status#L32 | 16:24 | |
bauzas | ++ | 16:24 |
bauzas | I'll provide comments in the etherpad about what can be reviewed | 16:24 |
bauzas | classic paperwork | 16:24 |
bauzas | next topic | 16:25 |
bauzas | #topic Stable Branches | 16:25 |
bauzas | elodilles: happy to listen to you | 16:25 |
elodilles | #info stable/202*.* gates seem to be OK | 16:25 |
bauzas | I like that | 16:25 |
elodilles | and that's all from me about stable :) | 16:25 |
bauzas | short and nice | 16:26 |
bauzas | I love that | 16:27 |
bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:27 |
fwiesel | #info Fixed regression in neutron driver used in CI. | 16:27 |
bauzas | \o/ | 16:27 |
fwiesel | sean-k-mooney: We are back to the two known failures | 16:27 |
sean-k-mooney | yep | 16:28 |
sean-k-mooney | i asked a question on the patch about rebuild | 16:28 |
sean-k-mooney | is that expected to fail | 16:28 |
sean-k-mooney | i see normal bfv works | 16:28 |
fwiesel | Yeah, that is its own bug an discussion | 16:28 |
sean-k-mooney | if there is a followup for the rebuild case i can upgrade to +2 | 16:28 |
sean-k-mooney | ok upgraded to +2 based on the latest ci results | 16:29 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/910627 | 16:29 |
fwiesel | \o/ | 16:29 |
fwiesel | That would be then from my side for this week, unless there are questions. | 16:29 |
sean-k-mooney | im tempeted to +w since other have not reviewd in 6 months | 16:29 |
bauzas | not from me | 16:29 |
bauzas | I can review the patch | 16:29 |
bauzas | CI is green | 16:30 |
bauzas | and we have some kind of gentlemen's agreement on 'other virt drivers' patches we may not know by heart | 16:30 |
sean-k-mooney | ok, but general question since cores are not really maintianing the vmware stuff do we want ot require 2 +2s if ci is green and fwiesel's team are the autors of the patch? | 16:30 |
sean-k-mooney | im stictly talking about chagne that only impact vmware like this | 16:30 |
bauzas | that's the whole point of running a stable CI | 16:30 |
dansmith | I still want good review (i.e. two +2s) | 16:31 |
bauzas | if we can trust the vmware job, then we can get some good regressing insight | 16:31 |
bauzas | but I second dansmith on not release our two cores approval | 16:31 |
sean-k-mooney | ok then unless i see more people reviewin this i think we need to reopen the deprecation pathces | 16:31 |
bauzas | previously, we had the same concerns when other drivers were asking for reviews and we had that agreement | 16:31 |
bauzas | I don't see the need of threatening the driver | 16:32 |
sean-k-mooney | im not seeing other actully take the time to review but bauzas if your happy too review then cool | 16:32 |
gibi | I would be OK to drop down to 1x +2 for a driver only code with a good CI | 16:32 |
dansmith | I'm mostly concerned about drivers doing things they shouldn't and not so much the review of the actual vmware-specific bits | 16:32 |
bauzas | fwiesel makes a solid effort of keeping the job paceful, so we just need reviews | 16:32 |
dansmith | and I think if we drop down the review requirement we're just asking for rubber stamps | 16:32 |
bauzas | yeah, exactly why I think we need to continue the agreement we had | 16:33 |
sean-k-mooney | bauzas: that agreement goes too ways assuming more cores then just me look at the patch :) | 16:33 |
bauzas | two cores need to lookup the patches and somehow be "enlighted" by the result of the CI job | 16:33 |
sean-k-mooney | im happy for the work fwiesel has been doing | 16:34 |
bauzas | sean-k-mooney: correct and that's why I'm saying this is a normal situation | 16:34 |
bauzas | I got the signal and I'll do my homework | 16:34 |
bauzas | anything else about vmware ? | 16:34 |
fwiesel | Not from me. | 16:35 |
bauzas | #topic Open discussion | 16:35 |
bauzas | I have two procedural items | 16:35 |
bauzas | (bauzas) Sep 3 meeting | 16:35 |
bauzas | I'll be traveling to the OIF Asia Summit | 16:36 |
bauzas | only that week | 16:36 |
bauzas | so I won't be able to run the meeting | 16:36 |
bauzas | so either we skip or someone runs it | 16:36 |
bauzas | the most critical thing is to say next week that FeatureFreeze is coming in 2 days | 16:37 |
bauzas | so, anyone fancy runnning it ? | 16:37 |
bauzas | I can notify the deadline async using the ML | 16:37 |
bauzas | okay, I don't see any head popping up | 16:38 |
bauzas | so, | 16:38 |
bauzas | #info Sep 3 meeting is CANCELLED | 16:38 |
bauzas | #action bauzas to notify by email | 16:38 |
bauzas | second poit | 16:38 |
bauzas | point* | 16:38 |
bauzas | (bauzas) Epoxy PTL seat | 16:39 |
bauzas | if you contributed to nova recently, you received some email | 16:39 |
bauzas | maybe you don't know but I'm running for a TC seat this cycle | 16:39 |
bauzas | I think I can both sit on two chairs (TC and PTL) but I wanted to let people consider the PTL position | 16:40 |
bauzas | either way, my personal take is that IMHO nova is that important to me that I'd rather stick on that seat than leave the project to be leaderless (procedurarely) | 16:41 |
bauzas | but if you consider running for that position, my DM is open | 16:41 |
bauzas | that's it from me | 16:41 |
bauzas | I don't see any other item in the agenda | 16:42 |
bauzas | so unless someone disagrees loudly, let's end this meeting earlier and lemme give you 15 mins back of your time | 16:42 |
bauzas | okay, thanks folks | 16:43 |
bauzas | #endmeeting | 16:43 |
opendevmeet | Meeting ended Tue Aug 27 16:43:44 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:43 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.html | 16:43 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.txt | 16:43 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.log.html | 16:43 |
fwiesel | Thanks, everyone | 16:43 |
gibi | thanks | 16:43 |
elodilles | thanks o/ | 16:44 |
JayF | sean-k-mooney: https://review.opendev.org/c/openstack/nova/+/923910 what do you need from me for this to land? | 16:44 |
JayF | sean-k-mooney: I know FF is in two days, I've been asking for reviews but with the image issues flipping everything upside down, they haven't been coming :) | 16:45 |
bauzas | JayF: no, FF is next week | 16:46 |
JayF | oh, cool, I thought it was literally EOW | 16:47 |
JayF | either way doesn't matter unless I get reviews and/or know what actions I need to take :D | 16:47 |
bauzas | oh shit | 16:47 |
bauzas | https://releases.openstack.org/dalmatian/schedule.html#d-ff | 16:47 |
bauzas | this is this week | 16:47 |
JayF | Maybe I'll find time to do a video demo, one of my junior folks did that for a patch stuck in Ironic and it helped get reviews | 16:47 |
bauzas | my brain fucked it up | 16:47 |
JayF | I think every core on any OpenStack project has a get-out-of-mistake-free card after the major CVE handling in the middle of the cycle | 16:48 |
opendevreview | Jay Faulkner proposed openstack/nova master: [ironic] Factor out metadata and send to ironic https://review.opendev.org/c/openstack/nova/+/923910 | 16:51 |
dansmith | bauzas: did you see my comments on that vmware patch? | 16:56 |
dansmith | I didn't -1 because they were questions | 16:56 |
sean-k-mooney | JayF: i guess i just need to back and review agian | 16:56 |
JayF | sean-k-mooney: would a video demo of it in devstack help you review it? | 16:56 |
sean-k-mooney | JayF: i think it was largly fine the last time i looked but i wanted to see it end to end | 16:56 |
sean-k-mooney | JayF: proably not but ill watch it if you ahve one | 16:56 |
JayF | I mean, I won't make one if the primary audience doesn't want it :D | 16:57 |
*** bauzas_ is now known as bauzas | 17:03 | |
dansmith | man the gate is effing busy | 17:07 |
sean-k-mooney | i havnt looked recently but we are coming to FF | 18:01 |
sean-k-mooney | so ya... | 18:01 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Handle empty imageRef alongside null for local BDM check https://review.opendev.org/c/openstack/nova/+/927311 | 18:53 |
opendevreview | Merged openstack/nova master: Use format_inspector from oslo https://review.opendev.org/c/openstack/nova/+/925025 | 18:54 |
dansmith | hoo bioy | 18:55 |
sean-k-mooney | ah cool so the tempest test change also merged | 19:06 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!