Tuesday, 2024-08-27

*** bauzas_ is now known as bauzas01:26
*** __ministry is now known as Guest158202:17
*** __ministry is now known as Guest158704:07
gibisean-k-mooney: I have no preference between eventlet an healthcheck. I will take a look at the healthcheck series today07:03
gibisean-k-mooney: on the timer, I will reply in the review07:09
*** __ministry is now known as Guest159807:22
*** bauzas_ is now known as bauzas07:25
opendevreviewStephen Finucane proposed openstack/python-novaclient master: functional: Handle multiple networks  https://review.opendev.org/c/openstack/python-novaclient/+/92724910:09
opendevreviewStephen Finucane proposed openstack/python-novaclient master: tox: Add Python-specific functional envs  https://review.opendev.org/c/openstack/python-novaclient/+/92725010:09
opendevreviewStephen Finucane proposed openstack/python-novaclient master: Fix Python 3.12 compatibility  https://review.opendev.org/c/openstack/python-novaclient/+/92725110:09
opendevreviewMichael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection.  https://review.opendev.org/c/openstack/nova/+/92725410:44
*** bauzas_ is now known as bauzas13:23
*** __ministry is now known as Guest162513:59
bauzasthat's been a while but we'll have a nova meeting here in 50 mins15:11
stephenfinsean-k-mooney: Here's the fix for the novaclient issue https://review.opendev.org/c/openstack/python-novaclient/+/927249/ I know you were saying that should test the default configuration of auto-configuring a network, but that will never work with multiple possible networks. If we want to test that properly we'll need a separate job that removes e.g. the share network, but that seems like overkill15:15
stephenfinSo hopefully the bit of logic I've copied in there if sufficient15:15
sean-k-mooneythe legacy test is testing before the auto network feature was added15:15
sean-k-mooneyso ya the issue here is that the job is not conigured to allw the test to run15:16
opendevreviewStephen Finucane proposed openstack/python-novaclient master: functional: Handle multiple networks  https://review.opendev.org/c/openstack/python-novaclient/+/92724915:16
opendevreviewStephen Finucane proposed openstack/python-novaclient master: tox: Add Python-specific functional envs  https://review.opendev.org/c/openstack/python-novaclient/+/92725015:16
opendevreviewStephen Finucane proposed openstack/python-novaclient master: Fix Python 3.12 compatibility  https://review.opendev.org/c/openstack/python-novaclient/+/92725115:16
stephenfin(just spotted so leftover print statements)15:16
sean-k-mooneyi saw them 15:16
stephenfins/so/some/15:16
sean-k-mooneybut my point it this is ment to be testing when we do not specify a nic15:16
sean-k-mooneyso adding a nic invaldiates the test15:16
stephenfinso do we add a skipTest if self.multiple_networks?15:17
sean-k-mooneyit would be better to use the skip test funciontion if we detect multiple networks15:17
sean-k-mooneyyep that was one of the opetions15:17
sean-k-mooneyi was also lookig at modifyitg the job to remove the share network15:17
stephenfinthough I'll note there's nothing in the test name or docstring that says this needs to rely on being able to auto-configure a network15:18
sean-k-mooneyits not15:18
stephenfinso what makes you say that we're testing that?15:18
sean-k-mooneyauto configuring the network is an diffent feature then we are testing15:18
stephenfinright, but we're testing the '--image-with' falg15:18
stephenfin*flag15:18
sean-k-mooneythis is testing the bahvior or there is only one network15:18
stephenfinhaving to/not to pass the '--nic' option is secondary to the main test, from the looks of things?15:19
sean-k-mooneywhich is diffent then auto config which will create it if there is none15:19
stephenfinright, but do we care? that's not the aim of this test15:19
sean-k-mooneyit is the aim to ensure that the old command line argument work as openstack evolves15:19
sean-k-mooneyat least fo the legacy version that is testin 2.115:20
sean-k-mooneystephenfin: if we have a sperate test case for this then im fine with changing this one15:20
stephenfinAgain, right, but the test is testing the '--image-with' option, not the '--nic' option (or lack thereof). My change proves the '--image-with' option works on both 2.1 and 2.latest15:20
stephenfinokay, lemme see15:20
sean-k-mooneyi think this is the only test without a nic specifed15:21
stephenfinthat was easy. It's a short file. None there. Do we add one (with the skip)?15:21
stephenfinrelying on there only being one test seems fairly fragile and would prevent us running said tests against a local devstack (at least without doing what CI does and e.g. deleting the 'shared' network)15:22
stephenfin*one network15:22
sean-k-mooneyso i think this regression was intoduced by https://github.com/openstack/devstack/commit/24b65adc9cedff9c7a8ab412fb39613ef5d4a62715:24
stephenfinHardly. That's there since yoga15:24
stephenfinper the GitHub UI anyway15:24
sean-k-mooneymaybe not but was srbac enabeld in neutron by default for that long15:25
sean-k-mooneyok im torn personally i want to remvoe the cli testing and the shell module15:26
sean-k-mooneyon the other hand while its there we shoudl nto reduce test coverage15:26
sean-k-mooneyso if you want to add a test taht will skip if multiple networks i guess that fine15:26
sean-k-mooneybut it also kind of useless without fixing the ci15:26
stephenfinagreed15:26
stephenfinmaybe we just merge that and move on with our lives? 🤷15:26
stephenfinundoubtedly better than making the whole thing non-voting15:27
sean-k-mooneyif we do then i think we need to delete the cli next cycle15:27
stephenfinperfect is the enemy of the good15:27
stephenfinetc. etc.15:27
sean-k-mooneywell no voting was just a precuisor to deleting it15:27
sean-k-mooneywe can see what people think in the nova meeting in 30 mins15:28
stephenfinack15:28
sean-k-mooneyif they are fine with our patch then we can merge it but i dicussed this with melwitt last week and we wanted to wait for the team meeting15:29
sean-k-mooneyas in i discussed skiping or modifying the test to work with multiple networks15:29
*** __ministry is now known as Guest163215:55
bauzas#startmeeting nova16:01
opendevmeetMeeting started Tue Aug 27 16:01:36 2024 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:01
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:01
opendevmeetThe meeting name has been set to 'nova'16:01
bauzashey folks16:01
bauzassorry, that's been so long, maybe you forgot about it16:01
gibinever!16:02
fwieselo/16:02
elodilleso/16:02
sean-k-mooneyo/16:03
auniyalo/16:03
bauzascool folks16:03
bauzaslet's start then :)16:03
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:03
bauzas#topic Bugs (stuck/critical) 16:04
bauzas#info No Critical bug16:04
bauzas(glad to hear it)16:04
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:04
bauzasany important bug people would want to discuss ?16:04
bauzasI was off for 3 weeks so I don't really know16:04
bauzaslooks no16:06
bauzasmoving on16:06
sean-k-mooneynovaclint is blokced but we will talk about that later16:06
bauzasokay16:06
bauzas#topic Gate status 16:06
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:06
bauzas#link https://etherpad.opendev.org/p/nova-ci-failures-minimal16:06
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status16:07
bauzasall greens16:07
bauzas(well, we have a stable/zed job done, but meh)16:07
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:07
bauzas#info Please try to provide meaningful comment when you recheck16:07
bauzasmoving on ?16:08
bauzas#topic Release Planning 16:08
bauzas#link https://releases.openstack.org/dalmatian/schedule.html16:08
bauzas#info Dalmatian-3 in 1 week16:09
bauzas#info non-client library freeze happened last week16:09
bauzas#info client library freeze this week16:09
bauzassean-k-mooney: want to discss the novaclient issue ?16:09
dansmithI kinda have something for release planning16:10
sean-k-mooneywe have 2 issues16:10
sean-k-mooneythe first one is just a ci job issue16:10
bauzasokay, tell me both16:10
sean-k-mooneythe functioanl job is exepcting there to only be one network16:10
sean-k-mooneythere are now 216:10
sean-k-mooneyso 2 tests fail16:10
sean-k-mooneywe can update them to skip or modify them to use the first network16:11
sean-k-mooneystephenfin: has a patch for the latter16:11
sean-k-mooneythe second issue is the cli does not work on python 3.1116:11
bauzasthis is a priority before we release novaclient IMHO16:11
sean-k-mooneyit was deprecated when the newest veriohn we supproted was 3.916:11
sean-k-mooneyso i think we need to look at removing the nova client cli in 2025.1 and the python bidnign by 2026.116:12
sean-k-mooneythat is a ptg discussion that im hopign melwitt and stephenfin can partake in16:12
sean-k-mooneyto actully do that we need to dicsuss with neutron and heat to get them to swap to the sdk16:13
bauzashttps://github.com/openstack/python-novaclient/blob/master/setup.cfg#L22-L2416:13
bauzasare you saying that we don't have any job testing 3.11 ?16:13
sean-k-mooneywe do and it fails16:13
sean-k-mooneybut we deprecated the cli before that16:13
sean-k-mooneyso the cli has not been updated to supprot py31116:14
bauzasoh, you're saying the deprecation of the CLI16:14
bauzasI see16:14
sean-k-mooneythe 3.11 issue is a change in argparse behavior16:14
sean-k-mooneyso only affect the cli16:14
bauzasthis is deprecated, but we could provide some exception telling "sorry, we only support up to 3.9 for the CLI"16:14
sean-k-mooneyanyway there are two patches to fix the 3.11 issue16:14
sean-k-mooneyso the main question is do we quickly fix this for 2024.216:15
bauzaswe could backport such patches then16:15
sean-k-mooneyand then look at removing the shell in 2025.1/216:15
bauzasI think we should rather just fix the 3.11 issues16:16
sean-k-mooneyactully we can dicussss post 2024.1 at the ptg16:16
bauzaswe can write some relnote before we release explaning the status of the CLI if you wan16:16
bauzaswant*16:16
sean-k-mooneywell the cil is deprecated for removal16:16
sean-k-mooneyso unless we are going to set a release there is no point16:17
sean-k-mooneyim hoping to deprecate the entire project in 2025.116:17
bauzasat a previous PTG, we said we preferred to defer the removal 16:17
elodilleswith the relmgt hat on, i like the idea of landing the two patch that fixes the gate o:) (thanks sean-k-mooney for bringing this topic up :))16:17
bauzasthere are people continuing to run scrips with the CLI16:17
sean-k-mooneyok then all we need to do is see if we are happy with stephenfin patch for functional16:17
sean-k-mooneyand then we can merge one of the two patches for 3.1116:17
sean-k-mooneyand backport those to stable branches16:18
sean-k-mooneyif needed16:18
bauzascould you please add all the patches in the release etherpad if they're not there yet ?16:18
bauzasfor tracking 16:18
sean-k-mooneyyep16:18
bauzasthanks16:18
bauzasdo both of the problems have bug reports against them ?16:18
sean-k-mooneyyes i think so16:18
bauzascool16:18
bauzassean-k-mooney: thanks for helping16:18
bauzasdansmith: you had a comment16:19
elodillesyepp, thanks sean-k-mooney \o/16:19
dansmithbauzas: release-wise, i think it's critical that we get this into 2024.2: https://review.opendev.org/c/openstack/nova/+/92502516:19
dansmithit will reduce the number of releases where we carry the format_inspector stuff,16:19
dansmithand the sooner we get that in the more coverage we'll get before the release16:19
bauzasgood point16:20
bauzasI'll add it to the tracker16:20
dansmithjust made the oslo release, so we should take advantage of it16:20
gibiI can start my tomorrow on that commit16:20
bauzas++16:20
dansmithgibi: thanks16:20
bauzasI can review that patch16:20
bauzas(I actually reviewed the first patch that added the module :) )16:20
dansmith-1741 +5516:21
dansmithpretty good stats :)16:21
gibidansmith: nice work!16:21
bauzasyeah, thanks for having worked on it from the last semester :)16:21
dansmithyeah, I'm sick of it :)16:21
bauzasI don't guess the reason why :-P 16:21
bauzas(jk)16:22
bauzasanyway, moving on, I'll review that patch and gibi too16:22
bauzasrelease-wise too, I'll start adding the procedural patches we usually merge before RC116:22
bauzasthe rpcapi pins, etc.16:23
bauzas#topic Review priorities 16:23
bauzas#link https://etherpad.opendev.org/p/nova-dalmatian-status16:24
bauzasI'll start scrubbing that list and identify the series that are impacted by the client freeze and need to be punted16:24
* sean-k-mooney added the nova clinet patches https://etherpad.opendev.org/p/nova-dalmatian-status#L3216:24
bauzas++16:24
bauzasI'll provide comments in the etherpad about what can be reviewed16:24
bauzasclassic paperwork16:24
bauzasnext topic16:25
bauzas#topic Stable Branches 16:25
bauzaselodilles: happy to listen to you 16:25
elodilles#info stable/202*.* gates seem to be OK16:25
bauzasI like that16:25
elodillesand that's all from me about stable :)16:25
bauzasshort and nice16:26
bauzasI love that16:27
bauzas#topic vmwareapi 3rd-party CI efforts Highlights 16:27
fwiesel#info Fixed regression in neutron driver used in CI.16:27
bauzas\o/16:27
fwieselsean-k-mooney: We are back to the two known failures16:27
sean-k-mooneyyep16:28
sean-k-mooneyi asked a question on the patch about rebuild16:28
sean-k-mooneyis that expected to fail16:28
sean-k-mooneyi see normal bfv works16:28
fwieselYeah, that is its own bug an discussion16:28
sean-k-mooneyif there is a followup for the rebuild case i can upgrade to +216:28
sean-k-mooneyok upgraded to +2 based on the latest ci results16:29
sean-k-mooneyhttps://review.opendev.org/c/openstack/nova/+/91062716:29
fwiesel\o/16:29
fwieselThat would be then from my side for this week, unless there are questions.16:29
sean-k-mooneyim tempeted to +w since other have not reviewd in 6 months16:29
bauzasnot from me16:29
bauzasI can review the patch16:29
bauzasCI is green 16:30
bauzasand we have some kind of gentlemen's agreement on 'other virt drivers' patches we may not know by heart16:30
sean-k-mooneyok, but general question since cores are not really maintianing the vmware stuff do we want ot require 2 +2s if ci is green and fwiesel's team are the autors of the patch?16:30
sean-k-mooneyim stictly talking about chagne that only impact vmware like this16:30
bauzasthat's the whole point of running a stable CI16:30
dansmithI still want good review (i.e. two +2s)16:31
bauzasif we can trust the vmware job, then we can get some good regressing insight16:31
bauzasbut I second dansmith on not release our two cores approval16:31
sean-k-mooneyok then unless i see more people reviewin this i think we need to reopen the deprecation pathces16:31
bauzaspreviously, we had the same concerns when other drivers were asking for reviews and we had that agreement16:31
bauzasI don't see the need of threatening the driver16:32
sean-k-mooneyim not seeing other actully take the time to review but bauzas if your happy too review then cool16:32
gibiI would be OK to drop down to 1x +2 for a driver only code with a good CI16:32
dansmithI'm mostly concerned about drivers doing things they shouldn't and not so much the review of the actual vmware-specific bits16:32
bauzasfwiesel makes a solid effort of keeping the job paceful, so we just need reviews16:32
dansmithand I think if we drop down the review requirement we're just asking for rubber stamps16:32
bauzasyeah, exactly why I think we need to continue the agreement we had16:33
sean-k-mooneybauzas: that agreement goes too ways assuming more cores then just me look at the patch :)16:33
bauzastwo cores need to lookup the patches and somehow be "enlighted" by the result of the CI job16:33
sean-k-mooneyim happy for the work fwiesel has been doing16:34
bauzassean-k-mooney: correct and that's why I'm saying this is a normal situation16:34
bauzasI got the signal and I'll do my homework16:34
bauzasanything else about vmware ?16:34
fwieselNot from me.16:35
bauzas#topic Open discussion 16:35
bauzasI have two procedural items16:35
bauzas(bauzas) Sep 3 meeting16:35
bauzasI'll be traveling to the OIF Asia Summit16:36
bauzasonly that week16:36
bauzasso I won't be able to run the meeting16:36
bauzasso either we skip or someone runs it16:36
bauzasthe most critical thing is to say next week that FeatureFreeze is coming in 2 days16:37
bauzasso, anyone fancy runnning it ?16:37
bauzasI can notify the deadline async using the ML16:37
bauzasokay, I don't see any head popping up16:38
bauzasso,16:38
bauzas#info Sep 3 meeting is CANCELLED16:38
bauzas#action bauzas to notify by email16:38
bauzassecond poit16:38
bauzaspoint*16:38
bauzas(bauzas) Epoxy PTL seat16:39
bauzasif you contributed to nova recently, you received some email16:39
bauzasmaybe you don't know but I'm running for a TC seat this cycle16:39
bauzasI think I can both sit on two chairs (TC and PTL) but I wanted to let people consider the PTL position16:40
bauzaseither way, my personal take is that IMHO nova is that important to me that I'd rather stick on that seat than leave the project to be leaderless (procedurarely)16:41
bauzasbut if you consider running for that position, my DM is open16:41
bauzasthat's it from me16:41
bauzasI don't see any other item in the agenda16:42
bauzasso unless someone disagrees loudly, let's end this meeting earlier and lemme give you 15 mins back of your time16:42
bauzasokay, thanks folks16:43
bauzas#endmeeting16:43
opendevmeetMeeting ended Tue Aug 27 16:43:44 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:43
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.html16:43
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.txt16:43
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2024/nova.2024-08-27-16.01.log.html16:43
fwieselThanks, everyone16:43
gibithanks16:43
elodillesthanks o/16:44
JayFsean-k-mooney: https://review.opendev.org/c/openstack/nova/+/923910 what do you need from me for this to land?16:44
JayFsean-k-mooney: I know FF is in two days, I've been asking for reviews but with the image issues flipping everything upside down, they haven't been coming :)16:45
bauzasJayF: no, FF is next week16:46
JayFoh, cool, I thought it was literally EOW16:47
JayFeither way doesn't matter unless I get reviews and/or know what actions I need to take :D 16:47
bauzasoh shit16:47
bauzashttps://releases.openstack.org/dalmatian/schedule.html#d-ff16:47
bauzasthis is this week16:47
JayFMaybe I'll find time to do a video demo, one of my junior folks did that for a patch stuck in Ironic and it helped get reviews16:47
bauzasmy brain fucked it up16:47
JayFI think every core on any OpenStack project has a get-out-of-mistake-free card after the major CVE handling in the middle of the cycle16:48
opendevreviewJay Faulkner proposed openstack/nova master: [ironic] Factor out metadata and  send to ironic  https://review.opendev.org/c/openstack/nova/+/92391016:51
dansmithbauzas: did you see my comments on that vmware patch?16:56
dansmithI didn't -1 because they were questions16:56
sean-k-mooneyJayF: i guess i just need to back and review agian16:56
JayFsean-k-mooney: would a video demo of it in devstack help you review it?16:56
sean-k-mooneyJayF: i think it was largly fine the last time i looked but i wanted to see it end to end16:56
sean-k-mooneyJayF: proably not but ill watch it if you ahve one16:56
JayFI mean, I won't make one if the primary audience doesn't want it :D 16:57
*** bauzas_ is now known as bauzas17:03
dansmithman the gate is effing busy17:07
sean-k-mooneyi havnt looked recently but we are coming to FF18:01
sean-k-mooneyso ya...18:01
opendevreviewStephen Finucane proposed openstack/nova master: api: Handle empty imageRef alongside null for local BDM check  https://review.opendev.org/c/openstack/nova/+/92731118:53
opendevreviewMerged openstack/nova master: Use format_inspector from oslo  https://review.opendev.org/c/openstack/nova/+/92502518:54
dansmithhoo bioy18:55
sean-k-mooneyah cool so the tempest test change also merged19:06

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!