Tuesday, 2021-11-30

*** tbachman is now known as Guest717900:21
*** tbachman is now known as Guest718202:05
*** bhagyashris_ is now known as bhagyashris08:42
opendevreviewBalazs Gibizer proposed openstack/placement master: DNM: check if doc build is broken on master  https://review.opendev.org/c/openstack/placement/+/81976608:51
opendevreviewTobias Urdin proposed openstack/nova master: libvirt: Add announce-self post live-migration workaround  https://review.opendev.org/c/openstack/nova/+/74152908:59
opendevreviewBalazs Gibizer proposed openstack/placement master: Add yoga spec directory  https://review.opendev.org/c/openstack/placement/+/81966009:51
opendevreviewBalazs Gibizer proposed openstack/placement master: Spec: support any trait in allocation candidates  https://review.opendev.org/c/openstack/placement/+/64999209:51
opendevreviewBalazs Gibizer proposed openstack/placement master: Spec: support mixing required traits with any traits  https://review.opendev.org/c/openstack/placement/+/64936809:51
qiujuntingsean-k-mooney11:07
qiujuntinghi11:07
qiujuntingcan you help me. review this commit about pmem spec:https://review.opendev.org/c/openstack/nova/+/80222511:08
*** tbachman is now known as Guest721811:55
opendevreviewBalazs Gibizer proposed openstack/nova master: Log which instance event was timed out  https://review.opendev.org/c/openstack/nova/+/81981713:03
opendevreviewElod Illes proposed openstack/nova stable/wallaby: Ensure MAC addresses characters are in the same case  https://review.opendev.org/c/openstack/nova/+/81688313:48
bauzasgibi: thanks for creating the yoga specs directory for placement, I forgot about it14:13
gibibauzas: I'm still failing to make it right :D14:13
gibidoc generation is hard :/14:14
bauzasyeah I saw it14:14
gibithe extra pain is that locally I have pip dependency issue with the doc generation tox target 14:16
opendevreviewBalazs Gibizer proposed openstack/placement master: Add yoga spec directory  https://review.opendev.org/c/openstack/placement/+/81966014:17
opendevreviewBalazs Gibizer proposed openstack/placement master: Spec: support any trait in allocation candidates  https://review.opendev.org/c/openstack/placement/+/64999214:17
opendevreviewBalazs Gibizer proposed openstack/placement master: Spec: support mixing required traits with any traits  https://review.opendev.org/c/openstack/placement/+/64936814:17
gibihere is the next stab for it :)14:17
gibibauzas: btw I did it becuase I reheated two of my old specs for placement :)14:21
bauzasI saw iy14:21
elodillesbauzas: not so much things to add to 'stable branches' section of novameetings, but let me know when i can update that14:31
bauzaselodilles: just do it (c)14:32
bauzaselodilles: and I'll update after you14:32
elodillesbauzas: ack :]14:33
elodillesbauzas: done14:36
*** tbachman is now known as Guest722414:37
*** tbachman is now known as Guest722715:06
bauzasin case people have other opinions about this wontfix... https://bugs.launchpad.net/nova/+bug/195198315:19
bauzasalso, super weirdo bug https://bugs.launchpad.net/nova/+bug/195116915:22
bauzasplacement cores, easy peasy for adding specs to yoga https://review.opendev.org/c/openstack/placement/+/81966015:26
bauzasalso, reminder: nova meeting in 33 mins here at #openstack-nova15:27
gibibauzas: agree about https://bugs.launchpad.net/nova/+bug/1951983 until somebody proposes a better regexp it is simply a wontfix15:27
bauzascool thanks15:27
bauzaslast reminder: nova meeting in 7 mins here15:53
* gibi is reminded :)15:58
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Nov 30 16:00:00 2021 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:00
bauzasgood 'day, 'vyone16:00
gibi\o16:00
gansoo/16:00
elodilleso/16:00
bauzasokay, let's statry16:01
* bauzas shouldn't wear mittens when typing16:02
bauzas#topic Bugs (stuck/critical) 16:02
bauzas#info No Critical bug16:02
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.status=New 23 new untriaged bugs (-6 since the last meeting)16:02
bauzasthanks to all who helped 16:02
bauzas#help Nova bug triage help is appreciated https://wiki.openstack.org/wiki/Nova/BugTriage16:03
bauzas#link https://storyboard.openstack.org/#!/project/openstack/placement 25 open stories (-8 since the last meeting) in Storyboard for Placement 16:03
bauzasditto ^16:03
bauzasimpressive number16:03
bauzasI know the names :p16:04
dansmitho/16:04
bauzasany particular bug to discuss before we move to the next topic ?16:04
bauzasI guess no16:05
bauzas#topic Gate status 16:05
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:05
bauzasno new gate bug I can see16:05
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fplacement&pipeline=periodic-weekly Placement periodic job status 16:05
bauzasthe issue we discussed last week is fixed ^16:06
bauzas#info Please look at the gate failures, file a bug, and add an  elastic-recheck signature in the opendev/elastic-recheck repo (example: https://review.opendev.org/#/c/759967)16:06
bauzasfwiw, I haven't see any specific issue with our gate16:06
gibibauzas: the issue is not fixed it just did not appear in the recent runs16:07
bauzasah right, it was a race16:07
gibiI don't know about any active effor on our side making that fixed16:07
gibiit was about the pmlogger service16:07
bauzasright16:07
bauzasok, nothing else to tell ?16:08
bauzas#topic Release Planning 16:08
bauzas#info Yoga-2 is due Jan 6th#link https://releases.openstack.org/yoga/schedule.html#y-216:09
bauzas#undo16:09
opendevmeetRemoving item from minutes: #info Yoga-2 is due Jan 6th#link https://releases.openstack.org/yoga/schedule.html#y-216:09
bauzas#info Yoga-2 is due Jan 6th16:09
bauzas#link https://releases.openstack.org/yoga/schedule.html#y-216:09
bauzas#info Next spec review day to be planned for mid-Dec16:09
bauzasso,16:09
bauzaswhat do you think about Dec 14th for a new spec review day ?16:10
bauzasthe next week, I'll be off16:10
sean-k-mooney+1 for 14th16:10
gibi14th works for me16:10
bauzaswe have a few open specs16:10
gibiI'm off from the 20th 16:10
bauzasgibi: maybe like me16:11
bauzasmaybe I'll work on the Dec 22th day16:11
bauzasbut...16:11
bauzasI'm not sure we would have quorum16:11
bauzasok, any other thought?16:12
bauzas#agreed Next spec review day will be Tuesday Dec 14th16:13
gibiI will not be around in the week of Yoga-216:13
bauzasI'll provide a new ML email16:13
gibiI will be back on the 10th of Jan16:13
bauzasgibi: oh, you're now living in France ?16:13
bauzas:p16:13
gibiI've just checked, no :D16:14
bauzasanyway, no worries16:14
bauzaswe will only have the spec deadline for yoga-216:14
gibiI have two placement specs to get approved :)16:15
bauzasI've seen them :p16:15
bauzasanyway, moving on16:15
bauzas#topic Review priorities 16:16
bauzas#link  https://review.opendev.org/q/status:open+(project:openstack/nova+OR+project:openstack/placement)+label:Review-Priority%252B116:16
bauzas#link https://review.opendev.org/c/openstack/nova/+/816861 bauzas proposing a documentation change for helping contributors to ask for reviews16:16
bauzasI'm afraid I didn't had time to modify it16:16
bauzasnothing to discuss then for this week16:16
bauzasunless people want to have review priorities ?16:17
bauzasfwiw, my main priority will be unified limits reviews16:17
bauzasOK, next topic16:18
bauzas#topic Stable Branches 16:18
bauzasI'm sitting down, listening to elodilles16:18
elodilles#info stable gates are OK16:18
elodillesstable/xena has ~3 merged bug fixes, maybe we can wait some more bug fix to land before we do a release16:19
elodillesand that's it16:19
bauzasI was triaging a bug related to the compute service delete issue, and I saw we hadn't yet merged https://review.opendev.org/c/openstack/nova/+/80284716:20
*** whoami-rajat__ is now known as whoami-rajat16:20
bauzasI'll look at other backports that are fixing bad bugs, and I'll try to review them16:20
elodillesthanks in advance \o/16:21
bauzaswell, no problem16:22
bauzasmoving on16:22
bauzas#topic Sub/related team Highlights 16:22
bauzasLibvirt :lyarwood ?16:22
lyarwoodNothing from me16:22
bauzascool16:22
bauzas#topic Open discussion 16:22
bauzas(gmann) Specless BP approval request for RBAC community-wide goal 16:22
bauzas#link https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-216:23
bauzasgmann: around ?16:23
dansmithI am, if you have questions16:23
bauzashonestly, I don't think I have any concerns 16:24
dansmithI've been working on a patch to get servers back to the place where we want it,16:24
bauzasmaybe one about upgrades and what it means for operators that were modifying the policies16:24
dansmithas an example people can work from16:24
dansmithand it's very close16:24
bauzasbut this is just changing the defaults16:24
dansmithgmann and johnthetubaguy[m] are mostly happy I think, just working out one more functional thing16:24
dansmithbauzas: well, this is pretty much all about defaults anyway,16:25
dansmithand nobody could really have rolled to the new ones yet anyway, so not an upgrade concern, IMHO16:25
dansmithbut the revised plan involves less change when they do upgrade16:25
bauzasdansmith: I guess you're referring to https://review.opendev.org/c/openstack/governance/+/815158/20/goals/proposed/consistent-and-secure-rbac.rst as the revised plan ?16:26
dansmithyep16:26
bauzasok, 16:27
bauzasthis plan isn't yet sold but whatever it will be, nothing will really change from nova 16:27
dansmithwell, things have to change in nova of course,16:28
bauzasso as you said, I don't think there is any upgrade concern then16:28
bauzasnothing will really change from a nova perspective if you prefer16:28
dansmithbut mostly just undoing some of the proposed stuff that hasn't been able to be realized yet.. stepping back from some of that stuff that we merged proactively16:28
bauzasthings have to change, but upgrades aren't a concern either way16:28
dansmithmuch less of a concern than what they were, but of the stuff we're keeping, no real change, yeah16:29
dansmithand keystone will go first which will help our upgrade be even less impactful than it was going to be, if we ever got past the big bubble we had going16:29
bauzasto answer the original paperwork question, I think there is no controversy to tell it's a specless BP and we don't to document this as we already have https://review.opendev.org/c/openstack/governance/+/815158/20/goals/proposed/consistent-and-secure-rbac.rst16:29
bauzaswe don't need* to16:30
dansmith++16:30
bauzasthat said, of course this work will need some release notes16:30
dansmithobviously16:30
bauzasto explain the changes to the operators16:30
bauzasok16:31
bauzasanyone has other concerns N?16:31
bauzasdang, I need to learn typing16:31
bauzas(and that's what happens when you have a french keyboard with ? located near n and requiring shift)16:31
bauzasanyway16:32
bauzas#agreed https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-2 accepted as a specless BP as the direction is already explained in https://review.opendev.org/c/openstack/governance/+/815158/16:32
bauzasmoving on, last topic16:32
bauzas(ganso) Raising awareness of vif_multiqueue_enabled in flavor work that is ready to be reviewed/merged 16:33
bauzasganso: around ?16:33
gansoo/16:33
bauzas#link https://blueprints.launchpad.net/nova/+spec/multiqueue-flavor-extra-spec16:33
gansoso as the topic titles says: https://review.opendev.org/q/topic:%22bp%252Fmultiqueue-flavor-extra-spec%22+(status:open%20OR%20status:merged)16:33
gansowe've discussed 2-3 weeks ago about this and that it could/may be specless, but it was approved to be specless ~6 months ago16:34
bauzasganso: nothing changed during the implementation phase requiring further discussion ?16:34
gansobauzas: as far as I know, nothing changed and the code is complete16:34
bauzasthe BP was previously approved as specless so I don't see problems approving it again providing there were no changes in design 16:35
gansoI rebased it and it is passing CI16:35
bauzas(requiring further discussions)16:35
gansoI'm pretty much shepherding this set of changes now, but the work was done by stephenfin 16:36
bauzasganso: I guess you're taking over stephenfin's work ?16:36
gansoyes16:36
bauzasOK, that's crystal clear then16:36
bauzasI don't have any problems reapproving it16:36
bauzasanyone else disagreeing ?16:36
gansogreat =)16:36
bauzas#agreed https://blueprints.launchpad.net/nova/+spec/multiqueue-flavor-extra-spec to approve it again as a specless BP for the yoga release cycle16:37
bauzaswe're at the end of the agenda, anything else to mention ?16:37
bauzasI'm happy to say we were quick this time :)16:38
gibi\o/16:38
bauzasif not,16:38
bauzas#endmeeting*16:38
opendevmeetMeeting ended Tue Nov 30 16:38:34 2021 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:38
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-30-16.00.html16:38
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-30-16.00.txt16:38
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2021/nova.2021-11-30-16.00.log.html16:38
bauzasman, I'm fed up with my typing issues16:38
* bauzas will install TuxType16:39
bauzasthanks all16:40
elodillesthanks bauzas o/16:40
bauzasI'm a gross person, I haven't officially thanked you all at the end of the meeting16:40
elodilles:D16:42
*** xek_ is now known as xek16:48
bauzasgmann: can I put you assignee on https://blueprints.launchpad.net/nova/+spec/policy-defaults-refresh-2 ?17:07
opendevreviewNicolas Parquet proposed openstack/nova master: Add v2.91 microversion, allowing @ and dot (.) characters in keypair name  https://review.opendev.org/c/openstack/nova/+/78107617:14
gmannbauzas: sure, thanks 18:05
opendevreviewDan Smith proposed openstack/nova master: Revert project-specific APIs for servers  https://review.opendev.org/c/openstack/nova/+/81620618:07
opendevreviewDan Smith proposed openstack/nova master: Make API fixture pass roles  https://review.opendev.org/c/openstack/nova/+/81990718:08
dansmithgmann: this has the fixture change on top ^ so you can see it not working without it, and then working when we change that18:08
dansmithI haven't done more digging on why this is required, but hoping it's something you can spot easily18:08
gmanndansmith: ok, checking18:08
dansmithI wonder if we're not really testing fake policy like we think in functional?18:08
gmanndansmith: which is good :). I wanted to remove those fake policy from unit as well as from functional tests completely but that might need more tests modification but something we should do. 18:09
dansmithdon't disagree that it would be better, I just don't know why this is required right now,18:10
dansmithsince I would expect us to at most be testing with old defaults OR'd in18:10
gmannsure, I will check it where we are missing things. 18:11
gmanndansmith: did you see my comment https://review.opendev.org/c/openstack/nova/+/816206/9/nova/policies/base.py18:11
gmanndansmith: if CONTEXT_ADMIN if more readable then it is fine otherwise we can ad ADMIN ?18:12
dansmithgmann: oh yeah I did, I just got distracted by the functional failures18:12
gmannI started converting SYSTEM_READER to SYSTEM_ADMIN on top of your patch so doing it in base patch will avoid rebase or so18:12
gmannsure18:13
gmanndansmith: this is reason for functional test failure https://review.opendev.org/c/openstack/nova/+/816206/comment/510a59e0_5ffbc2f5/18:57
gmanndansmith: functional test using the real policy helped us to capture it.18:58
dansmithgmann: ahh, I was probably conflating that rule with the admin_or_owner below it when thinking that we'd still have the old default19:00
gmanndansmith: yeah, and those role hierarchy fix in 819907 made test passing because of 'admin' being used as user-id for functional test  https://review.opendev.org/c/openstack/nova/+/819907/comment/eba56840_d585da0a/ 19:01
dansmithgmann: you mean that's why they worked before I switched the rule...19:02
dansmithgmann: should I use admin_or_owner for those flavor-extra-spec rules, or add the DEPRECATED_ADMIN_OR_OWNER to context_admin/19:03
gmanndansmith:  I think DEPRECATED_ADMIN_POLICY as CONTEXT_ADMIN is going to replace SYSTEM_ADMIN only . I was trying to do it this way https://review.opendev.org/c/openstack/nova/+/81938919:05
gmannand PROJECT_ADMIN going to be with DEPRECATED_ADMIN_OR_OWNER  which has project_id in that19:06
gmanndansmith: let me update my patch and then you can use the new ADMIN rule for place of role:admin19:08
dansmithgmann: ack19:08
dansmithgmann: we still want my patch to pass proper roles from the fixture though right?19:09
dansmithpresumably we need to also let you get a fixture with no (or foo) roles for testing that member is enforced19:09
gmanndansmith: for is_admin L1092 yeah it is ok but else part make reader also give member authority https://review.opendev.org/c/openstack/nova/+/819907/1/nova/tests/fixtures/nova.py#109219:14
gmannif we remove the else part and let real role being tested what test use then it should be ok19:15
dansmithgmann: well, it just assumes member if not admin, which all the current users of that fixture are going to expect.. I'm saying it needs to be extended to allow you to tell it what roles you want19:15
gmannand later we can add user_id as 'member', 'reader' etc and add role accodringl;y 19:15
dansmithgmann: otherwise non-admin stuff will all fail too because roles=[] can't do aything19:15
gmannyeah that is true19:16
dansmithif we fix the deprecated rule bit, then this doesn't matter just yet, but before we can test with deprecated rules disabled, we'll have to fix this I think19:16
gmanndansmith: right for No legacy tests we need that. and we can add we can add  user_id == 'member' and add only member role and else part as add reader19:17
dansmithsure, or just pass roles= to the fixture19:18
dansmithright now, the user that is used is something other than "member" so we probably need a bunch of changes for that first19:18
gmann+1, much better19:18
opendevreviewDan Smith proposed openstack/nova master: Make API fixture pass roles  https://review.opendev.org/c/openstack/nova/+/81990719:30
dansmithgmann: like this-ish ^19:30
gmanndansmith: +1 yeah, and you want default to reader only (lower level of access) ? here https://review.opendev.org/c/openstack/nova/+/819907/2/nova/tests/functional/api/client.py#14019:33
dansmithgmann: that defaults to member, not reader.. since that's what everything else would expect currently, it seemed like that would be the best default19:34
dansmithlooks like maybe it's only used in one other place though,19:34
dansmithso I guess I could default it even lower and fix that one too19:35
dansmithdefault should be roles=[] right? since that's what you get if you're not explicitly granted reader/member/admin on a project19:35
gmanndansmith: yeah. but if it need mroe test fix then we can leave as of now and later we can do while moving func tests also to reader/mem,ber19:35
dansmithoh nm, it's just used here19:35
opendevreviewDan Smith proposed openstack/nova master: Make API fixture pass roles  https://review.opendev.org/c/openstack/nova/+/81990719:37
dansmithI thought client was used a few other places directly, but it's not, so we should be good to default to roles=[] ^19:37
gmann+1. yeah its self.api and self.admin_api19:39
gmannas of now19:39
dansmithyup19:39
sean-k-mooneywell default to roles=None19:39
sean-k-mooneyrather then []19:39
opendevreviewGhanshyam proposed openstack/nova master: Introduce 'admin' policy base rule  https://review.opendev.org/c/openstack/nova/+/81938919:39
sean-k-mooneysicne you should not use mutable defaults but same effect19:39
gmanndansmith: ^^ this is for 'admin' basically renaming 'context_is_admin' to 'admin'19:39
dansmithsean-k-mooney: did you look at the patch? :)19:40
dansmithgmann: cool thanks19:40
sean-k-mooneynope just saw the converstaion scroll by19:40
dansmithsean-k-mooney: trying not to take offense that you think I don't know not to use mutable defaults :)19:40
sean-k-mooney:)19:41
sean-k-mooneyi still see it in code often enough but ya you already did it the right way https://review.opendev.org/c/openstack/nova/+/819907/3/nova/tests/functional/api/client.py#14019:42
gmannI think we have hacking rule for that. 19:49
dansmithgmann: I don't think your admin patch works for me by itself,20:13
dansmithsince it's still requiring role:admin, which isn't what we have today20:13
dansmithit needs to be is_admin in order to work as-is right?20:13
* dansmith will bbl20:19
gmanndansmith: context set is_admin based on this rule itself https://github.com/openstack/nova/blob/d630615a02469442fb50ed4aa7e092206a28166a/nova/context.py#L138 20:24
gmannhttps://review.opendev.org/c/openstack/nova/+/819389/4/nova/policy.py20:24
gmannbut as it is two level deprecated rule combined I hope each one is logical ORed by oslo policy. but is it failing on your patch? if so then we can avoid to rename it for now. and add DEPRECATED_ADMIN_POLICY in is_context_admin rule only20:29
gmanndansmith: yeah, i ran your patch with my change and it does not work. oslo policy add only one level of deprecated rule in logical OR. 20:39
gmanndansmith: I will abandon my patch and let's rename CONTEXT_ADMIN to ADMIN in your patch but keeping rule:is_context_admin. commented in https://review.opendev.org/c/openstack/nova/+/816206/comment/543216d1_15fecfb1/20:40
dansmithgmann: okay, but that's not enough, it needs to be "role:admin or is_admin:True"21:43
dansmithso do you want me to do that on context_is_admin with a deprecated_rule= or add it to admin_api?21:44
gmanndansmith: yeah that will add ORed both21:44
gmanndansmith: yeah deprecated_rule=DEPRECATED_ADMIN_POLICY  .21:45
dansmithokay that's not enough either, I need this: https://termbin.com/bnqh21:46
dansmithyou okay with that?21:46
dansmithoh wait21:46
dansmithit's enough to use it as-is for today, you're right21:46
dansmithI'm thinking this needs to work for both old and new, but not as of this patch21:46
dansmithso yeah, I will just add the deprecated_admin_policy there21:46
gmannif you do this then it should ADMIN = 'rule:context_is_admin'21:47
dansmithyep, hadn't saved that before paste :)21:47
dansmithrunning all the tests now, but expect this to work now21:48
gmanndansmith: so with that you do not need this right? 'check_str='is_admin:True or role:admin','21:48
dansmithcorrect, for just this patch, I don't 21:48
gmannyeah.21:48
dansmiththere are just too many balls in the air with this stuff for my tiny brain :D21:50
artomdansmith, for the record, I'm painfully aware of the door that your last line opened, but am steadfastly refusing to step through it23:06
dansmithartom: lol, I *literally* almost pinged you, asking if you wanted to do the mriedem thing in his stead :D23:06
artomI'm all grown up now23:07
dansmithriiight23:08
artomNo really, I'm organizing expensive calls and everything :P23:09
opendevreviewDan Smith proposed openstack/nova master: Allow per-context rule in error messages  https://review.opendev.org/c/openstack/nova/+/81686523:37
opendevreviewDan Smith proposed openstack/nova master: Revert project-specific APIs for servers  https://review.opendev.org/c/openstack/nova/+/81620623:37
opendevreviewGhanshyam proposed openstack/nova master: Convert SYSTEM_ADMIN|READER to Admin and system scope  https://review.opendev.org/c/openstack/nova/+/81939023:42
opendevreviewGhanshyam proposed openstack/nova master: Convert SYSTEM_ADMIN|READER to Admin and system scope  https://review.opendev.org/c/openstack/nova/+/81939023:44
opendevreviewGhanshyam proposed openstack/nova master: Convert SYSTEM_ADMIN|READER to Admin and system scope  https://review.opendev.org/c/openstack/nova/+/81939023:44

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!