opendevreview | Merged openstack/nova master: hardware: Fix image_meta.id within get_mem_encryption_constraint https://review.opendev.org/c/openstack/nova/+/904197 | 04:39 |
---|---|---|
*** ChanServ changes topic to "This channel is for Nova development. For support of Nova deployments, please use #openstack" | 04:51 | |
whoami-rajat | hey #openstack-nova , can i have review on this small patch? it's sitting for quite a while https://review.opendev.org/c/openstack/nova/+/889257 | 05:19 |
amorin | melwitt, sean-k-mooney so maybe I misconfigured something because my volume endup in a different AZ when doing my tests, I will double check, thanks for your answers | 07:34 |
bauzas_ | morning folks | 09:11 |
*** bauzas_ is now known as bauzas | 09:14 | |
sean-k-mooney | amorin: check if you have the cross az attach config option configured to prevent cross az attach | 11:25 |
sean-k-mooney | bauzas: this is a very short spec form melwitt which we have discussed at previous ptgs https://review.opendev.org/c/openstack/nova-specs/+/923807 will you have time to review that today | 12:47 |
bauzas | yes, I'm slowing starting back | 12:47 |
sean-k-mooney | ack melwitt also has a poc implemation up for it | 12:48 |
frickler | bauzas: Uggla: auniyal: could you please check https://review.opendev.org/c/openstack/releases/+/923118 once again? (osc-placement release) | 12:52 |
weanew | Hello! I've submitted a bug fix: https://review.opendev.org/c/openstack/nova/+/923395 Could someone review it? | 13:16 |
opendevreview | Takashi Natsume proposed openstack/nova-specs master: Create specs directory for 2025.1 Epoxy https://review.opendev.org/c/openstack/nova-specs/+/924227 | 13:21 |
jlejeune | hello, can I have some review for my fix in unit tests please: https://review.opendev.org/c/openstack/nova/+/924148 ? | 13:36 |
bauzas | folks, can we try to not use this channel for asking for some fixes ? | 13:39 |
bauzas | jlejeune: weanew: if you want, you can add your changes in the Dalmatian etherpad : https://etherpad.opendev.org/p/nova-dalmatian-status | 13:40 |
jlejeune | bauzas: ok, I didn't create a bug in launchpad for that because it just affects unit tests, is that ok ? | 13:49 |
bauzas | jlejeune: yup, for internal changes like that, indeed you don't need to add a new Launchpad bug report | 13:57 |
jlejeune | bauzas: perfect, thanks | 13:58 |
bauzas | reminder (it was long due) : next nova meeting here in 1.5 hours (1600UTC) | 14:25 |
opendevreview | Balazs Gibizer proposed openstack/nova master: DNM: test back and forth migration https://review.opendev.org/c/openstack/nova/+/924234 | 14:55 |
elodilles | dansmith sean-k-mooney : i know it's unmaintained, but could you please have a quick look that my thinking was right when resolving conflict in this backport? https://review.opendev.org/c/openstack/nova/+/924083 | 15:00 |
elodilles | conflicts were due to patch to consolidate image creation functions (I111cfc8a5eae27b15c6312957255fcf973038ddf) was added only in zed | 15:01 |
elodilles | and as far as i understood, now i only had to touch the create_cow_image function, and no need for to change anything in create_image function (nova/virt/libvirt/utils.py) | 15:02 |
elodilles | as create_cow_image functions handles only the case when there is a backing_file | 15:03 |
sean-k-mooney | elodilles: a very light reivew, it looks correct but havented dnoe anything more then compare the 2023.1 patch to the yoga version | 15:08 |
elodilles | sean-k-mooney: ACK, thanks, i know that this is unmaintained, so i appreciate it! o:) | 15:09 |
sean-k-mooney | the ci results are relivily clean too | 15:10 |
opendevreview | Merged openstack/nova-specs master: Propose config option to control behavior of unset unified limits https://review.opendev.org/c/openstack/nova-specs/+/923807 | 15:10 |
elodilles | yepp, hence i dared to ask o:) | 15:10 |
sean-k-mooney | this obviously still has the iso regression | 15:11 |
sean-k-mooney | and im not sure if you have alredy fixed the ami format | 15:12 |
sean-k-mooney | ok the ami regression is adressed in the backport of a previous file as it was in master | 15:13 |
sean-k-mooney | https://review.opendev.org/c/openstack/nova/+/924082/1/nova/virt/images.py#163 | 15:13 |
sean-k-mooney | so the main regression is the breakgae of iso supprot form rescue, volumes and boot form iso | 15:14 |
elodilles | so you say something is still missing? | 15:19 |
sean-k-mooney | elodilles: not for the cve mitigation but the cve broke seveeral features | 15:22 |
sean-k-mooney | the one you are missing is the fixes for ISO files | 15:22 |
sean-k-mooney | elodilles: this series https://review.opendev.org/q/topic:%22format-inspector%22 | 15:23 |
elodilles | sean-k-mooney: oh, that, those are still on my TODO to backport o:) ACK | 15:26 |
elodilles | thx o/ | 15:26 |
sean-k-mooney | we backported them downstream to our trian equivelent branch with very little issues | 15:27 |
sean-k-mooney | all of thhis code is basically new so there is almost no opertunity for there to be a conflict | 15:27 |
elodilles | oh, good to hear that :] | 15:29 |
bauzas | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Jul 16 16:00:02 2024 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
fwiesel | o/ | 16:00 |
tkajinam | o/ | 16:00 |
bauzas | hey everyone, welcome back, it was long overdue | 16:00 |
elodilles | o/ | 16:00 |
bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:01 |
auniyal | o/ | 16:01 |
bauzas | I guess we can softly start | 16:02 |
bauzas | #topic Bugs (stuck/critical) | 16:02 |
bauzas | #info No Critical bug | 16:02 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:02 |
bauzas | do people want to discuss about some specific bugs, like some now public ones :) | 16:03 |
sean-k-mooney | i think you can take that as a no | 16:04 |
bauzas | thanks btw. dansmith and sean-k-mooney for https://bugs.launchpad.net/nova/+bug/2059809 | 16:04 |
bauzas | moving on | 16:05 |
gibi | o./ | 16:05 |
sean-k-mooney | *for fixing https://bugs.launchpad.net/nova/+bug/2059809 :) elodilles did a lot fo the hevay lifting on the backports as did gibi | 16:05 |
bauzas | :) | 16:05 |
elodilles | o:) | 16:05 |
bauzas | sorry, I was on PTO so I wasn't able to help :) | 16:06 |
bauzas | anyway, moving on | 16:06 |
bauzas | #topic Gate status | 16:06 |
sean-k-mooney | its fine it got done in the end | 16:06 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:06 |
bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:06 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status | 16:06 |
bauzas | all greens | 16:06 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:06 |
bauzas | #info Please try to provide meaningful comment when you recheck | 16:06 |
bauzas | so, how is the current CI ? | 16:07 |
sean-k-mooney | better then it was. we merged the zswap changes and that seams to help stablise things | 16:07 |
sean-k-mooney | i have a patch up for review to slightly increase the ram of the default falvor | 16:07 |
sean-k-mooney | im hoping that will reduce or remove the kernel panics | 16:08 |
bauzas | ok | 16:08 |
sean-k-mooney | so we will want to monitor those once that merges | 16:08 |
bauzas | I could look at opensearch | 16:09 |
sean-k-mooney | we could do that yes alhtough im hopign it will become obvious or not if its enouch | 16:10 |
sean-k-mooney | https://review.opendev.org/c/openstack/devstack/+/924094 is the patch in question | 16:10 |
sean-k-mooney | downstream we obseved a crash that we have not seen since we changed form 128 to 256 mb upstream i only went to 192 | 16:10 |
sean-k-mooney | so lets see how thing go for the next week | 16:11 |
tkajinam | that makes very clear sense | 16:12 |
bauzas | okay, I see that it's close to be merged | 16:12 |
sean-k-mooney | yep i also did a DNM to nova https://review.opendev.org/c/openstack/nova/+/924142 | 16:13 |
*** ykarel is now known as ykarel|away | 16:13 | |
sean-k-mooney | just to run our full set of jobs and it was green | 16:13 |
bauzas | for the guest panics, I'll ask opensearch about something like " ---[ end Kernel panic " | 16:14 |
bauzas | anyway, we'll see | 16:15 |
bauzas | moving on ? | 16:15 |
bauzas | looks so | 16:15 |
bauzas | #topic Release Planning | 16:15 |
bauzas | #link https://releases.openstack.org/dalmatian/schedule.html | 16:15 |
bauzas | #info Dalmatian-3 in 6 weeks | 16:16 |
bauzas | #info Spec approval freeze planned on Thursday | 16:16 |
bauzas | so that will be my review priority until Thursday | 16:16 |
bauzas | after Thursday EOD, we won't accept any other specs for Dalmatian, but you can then ask them for Epoxy once we merge https://review.opendev.org/c/openstack/nova-specs/+/924227 | 16:17 |
bauzas | anything about the spec freeze ? | 16:17 |
tkajinam | I'm willing to move SEV-ES support forward this cycle so am looking for further feedback to https://review.opendev.org/c/openstack/nova-specs/+/907702 :-) | 16:18 |
fwiesel | I'd like raise attention then to my lazy-metadata-loading spec: https://review.opendev.org/c/openstack/nova-specs/+/922201 | 16:19 |
sean-k-mooney | i can try and review that before thrusday | 16:19 |
bauzas | tkajinam: ack, I'll review | 16:19 |
bauzas | ditto for fwiesel | 16:19 |
bauzas | moving on so | 16:20 |
bauzas | #topic Review priorities | 16:20 |
bauzas | #link https://etherpad.opendev.org/p/nova-dalmatian-status | 16:20 |
bauzas | #action bauzas to update the above etherpad and Launchpad by tomorrow morning | 16:20 |
bauzas | I need to exactly look at what we already accepted | 16:20 |
bauzas | #topic Stable Branches | 16:21 |
bauzas | elodilles: heya | 16:21 |
elodilles | o7 | 16:21 |
elodilles | #info stable gates should be in OK state | 16:21 |
elodilles | #info nova stable versions were released a week ago: 29.1.0 (2024.1 Caracal), 28.2.0 (2023.2 Bobcat), 27.4.0 (Antelope) | 16:21 |
elodilles | but i guess we will need new releases after some time as new fixes landed after the release | 16:21 |
elodilles | either feel free to propose the release patch or ping me | 16:22 |
elodilles | and that's all from me for stable for now | 16:22 |
bauzas | okay, we'll see | 16:22 |
bauzas | and indeed we will need to create new releases due to the cve fixes | 16:22 |
sean-k-mooney | does already shipped btu the regression fixes are pending | 16:23 |
bauzas | we'll just see when it's needed | 16:23 |
bauzas | yeah that | 16:23 |
tkajinam | once a new release with follow-up fixes is created then we can start the discussion to oslo'nize the implementation | 16:23 |
sean-k-mooney | release are fortunetly relitively cheap | 16:24 |
elodilles | sean-k-mooney: yepp | 16:24 |
sean-k-mooney | also yes that | 16:24 |
bauzas | given all the distros already fixed their cves, this is not that urgent, but I'd still want to get those stable versions quickly | 16:24 |
sean-k-mooney | bauzas: i mean it semi urgent | 16:24 |
sean-k-mooney | we broke all useage of isos in nova | 16:24 |
bauzas | semi-urgent indeeed | 16:24 |
bauzas | I'm not telling about the backports | 16:25 |
bauzas | but about the stable releases | 16:25 |
sean-k-mooney | yep we broke all useage of iso on the sable branches too | 16:25 |
sean-k-mooney | they are now fixed but not released | 16:25 |
gibi | :) | 16:25 |
sean-k-mooney | but we can likely od that in the next weeek or so | 16:26 |
sean-k-mooney | i think the last patch to stable/2023.1 landed friday | 16:26 |
bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:26 |
fwiesel | #info No updates | 16:26 |
bauzas | fwiesel: want to say anything ? | 16:26 |
bauzas | cool with me | 16:26 |
bauzas | #topic Open discussion | 16:26 |
bauzas | anything from me, anything anyone ? | 16:27 |
tkajinam | I have one thing | 16:27 |
tkajinam | I have a few items pending on os-traits change. I wonder if I can ask for an early release (probably right after spec freeze) so that I can start pushing patches early | 16:27 |
tkajinam | See https://review.opendev.org/q/project:openstack/os-traits+status:open | 16:28 |
elodilles | +1 for early release o:) | 16:28 |
bauzas | that's always a good idea (to release os-traits release way earlier than milestone-3) | 16:28 |
bauzas | ditto with os-vif if required | 16:29 |
tkajinam | ok, that's nice. :-) | 16:29 |
bauzas | once the spec is approved, I don't see any reason to hold a os-traits patch | 16:30 |
bauzas | tkajinam: accordingly, please ping me if you want once your both specs are validated | 16:30 |
sean-k-mooney | i dont see why not | 16:30 |
bauzas | I just can't remember the state of both specs :) | 16:31 |
bauzas | so I'll first look whether they're accepted or not | 16:31 |
tkajinam | the SEV-ES work still needs spec approval but the other two have specs approved | 16:31 |
tkajinam | I'll update the status after the meeting | 16:32 |
bauzas | thanks | 16:32 |
bauzas | (yeah I remembered about the firmware one) | 16:32 |
sean-k-mooney | im not sure if we need the es trait | 16:33 |
opendevreview | Takashi Kajinami proposed openstack/os-traits master: Add a new trait for stateless firmware support https://review.opendev.org/c/openstack/os-traits/+/908885 | 16:33 |
sean-k-mooney | didnt we say we would use a seperate resouce class for that | 16:33 |
bauzas | for SEV-ES ? | 16:33 |
sean-k-mooney | yep | 16:33 |
sean-k-mooney | oh no we didnt | 16:34 |
sean-k-mooney | its the same resouce class | 16:34 |
tkajinam | sean-k-mooney, we agreed using trait, not resource class to distinguish SEV and SEV-ES, IIUC | 16:34 |
sean-k-mooney | just with a triat | 16:34 |
sean-k-mooney | it been a while since i looked | 16:34 |
tkajinam | yes | 16:34 |
sean-k-mooney | ya ok | 16:34 |
bauzas | yeah https://etherpad.opendev.org/p/nova-dalmatian-ptg#L498 | 16:34 |
bauzas | (I was looking at the etherpad) | 16:35 |
bauzas | we didn't wanted to differentiate all the SEV supports | 16:35 |
bauzas | s/supports/types | 16:35 |
bauzas | anything else to discuss ? | 16:35 |
sean-k-mooney | not on this topic at least not form me | 16:36 |
tkajinam | nothing else from me | 16:36 |
bauzas | sorry, I looked at other stuff | 16:41 |
bauzas | thanks folks | 16:41 |
bauzas | #endmeeting | 16:41 |
opendevmeet | Meeting ended Tue Jul 16 16:41:23 2024 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:41 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-16-16.00.html | 16:41 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-16-16.00.txt | 16:41 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2024/nova.2024-07-16-16.00.log.html | 16:41 |
fwiesel | thank you too, bye | 16:41 |
elodilles | thanks o/ | 16:41 |
tkajinam | thanks ! | 16:42 |
tkajinam | bauzas, if you have a moment, could you approve https://blueprints.launchpad.net/nova/+spec/libvirt-stateless-firmware ? its spec was already merged https://review.opendev.org/c/openstack/nova-specs/+/908297 | 16:43 |
tkajinam | I remember we discussed the missing bp link which was fixed by https://review.opendev.org/c/openstack/nova-specs/+/920612 | 16:43 |
bauzas | tkajinam: as I said, I'll update Launchpad for all approved specs | 16:43 |
bauzas | I was on PTO last 10 days, so I'll both check the open specs but also the new merged ones | 16:43 |
bauzas | (and then update the status etherpad for adding series of the accepted specs) | 16:44 |
tkajinam | ah, ok. I'll recheck it after that "batch update" | 16:44 |
opendevreview | Merged openstack/os-traits master: Add traits for TPM models https://review.opendev.org/c/openstack/os-traits/+/909107 | 16:48 |
melwitt | thanks sean-k-mooney and bauzas for the spec reviews 🙏 | 19:07 |
*** bauzas_ is now known as bauzas | 19:36 | |
*** bauzas_ is now known as bauzas | 20:55 | |
*** bauzas_ is now known as bauzas | 22:21 | |
*** bauzas_ is now known as bauzas | 23:56 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!