Tuesday, 2025-01-28

opendevreviewmelanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node  https://review.opendev.org/c/openstack/nova/+/93292603:00
opendevreviewmelanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node  https://review.opendev.org/c/openstack/nova/+/93292607:25
*** elodilles is now known as elodilles_pto08:23
opendevreviewStephen Finucane proposed openstack/nova master: api: Add response body schemas for image metadata APIs  https://review.opendev.org/c/openstack/nova/+/94029912:24
opendevreviewStephen Finucane proposed openstack/nova master: api: Add response body schemas for server topology API  https://review.opendev.org/c/openstack/nova/+/94030012:24
opendevreviewAmit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info  https://review.opendev.org/c/openstack/nova/+/93964313:48
opendevreviewAmit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage  https://review.opendev.org/c/openstack/nova/+/94030413:48
opendevreviewRajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response  https://review.opendev.org/c/openstack/nova/+/93964914:35
stephenfingmann: sean-k-mooney: Would I be able to ask for another burst through those OpenAPI patches in the next few days? I suspect this is going to drag into a third release, but I'd really like there not to be fourth and I still have quite a few patches to push beyond what's there15:27
sean-k-mooneyi can try15:45
bauzas#startmeeting nova16:00
opendevmeetMeeting started Tue Jan 28 16:00:27 2025 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:00
opendevmeetThe meeting name has been set to 'nova'16:00
fwieselo/16:01
masahitoo/16:01
r-taketno/16:01
sean-k-mooneyo/16:01
gibio/16:01
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:03
bauzasI guess we can softly start16:03
bauzas#topic Bugs (stuck/critical) 16:04
bauzas#info No Critical bug16:04
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:05
masahitohi, question for the bug roster activity.16:05
bauzasany othre sure16:05
masahitoIs it bug triage activity newly reported?16:06
bauzaswe stopped looking at the non triaged bugs, as unfortunately there were no longer any volunteers :(16:07
bauzasand it takes a large hit to triage those new bugs, given 2 of 3 are more configuration problems than real bugs :(16:07
Ugglao/16:08
sean-k-mooneyocationally we will still look and triage some16:08
sean-k-mooneybut its now mostly async or based on pings form folks on irc or teh mailign list16:08
bauzasthis indeed16:09
masahitoI got the situation.16:09
sean-k-mooneywe still use the bug tracker but we are not doing tirage weekly in thei meeting16:09
sean-k-mooneyif you have issue you can however bring them up here 16:09
masahitowe hit some bugs in the v2.96 API and started to report and to fix it. Let me bring it up here or the bug triage roaster.16:10
masahitoI try to check other bugs as well for the triage if possible.16:11
masahitoping on irc is sometime difficult for us because of time difference. The bug roster activity sounds nice :)16:12
masahitothank you.16:12
bauzasmasahito: what you can do is to add your patches in the tracking etherpad, we'll look over them16:12
bauzascan we move on ?16:13
masahitoGot it. Looks last update is the last September. We could refresh the etherpad, too.16:14
masahitoyes. Thank you.16:14
bauzas#topic Gate status 16:15
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:15
bauzas#link https://etherpad.opendev.org/p/nova-ci-failures-minimal16:15
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status16:15
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:15
bauzas#info Please try to provide meaningful comment when you recheck16:15
bauzasthe periodics are in a good shape16:16
bauzasany gate failure you wanna talk ?16:16
sean-k-mooneyi havent really been looking at the gate in a while but the only fialures i notices were the usual volume or kernel panic issues16:16
bauzasditto here16:17
sean-k-mooneywith that said tehree was a fix for some of the volume tests in tempest16:17
sean-k-mooneyso that may help16:17
bauzasand I definitely need to do a round of reviews16:17
sean-k-mooneyhttps://review.opendev.org/c/openstack/tempest/+/939663/2 and https://review.opendev.org/c/openstack/tempest/+/939633/11 for context16:17
sean-k-mooneythat shoudl help with some of the volume failures in test_instances_with_cinder_volumes16:18
sean-k-mooneytl;dr those tests were not waiting for the vm to be sshabel ebfore trying to attach the voluems16:18
bauzasgood call, we can give them a shot16:18
sean-k-mooneywe can move on unless anyone else what to raise something16:19
bauzasyup16:19
bauzas#topic Release Planning 16:19
bauzas#link https://releases.openstack.org/epoxy/schedule.html16:19
bauzas#info Nova deadlines are set in the above schedule16:19
bauzas#info 4 weeks before Feature Freeze16:19
bauzasthe clock is ticking16:19
bauzasas I said, I'll try to do a round of reviews as soon as my availability raises once I'm done with implementing a few things16:20
bauzasas a reminder:16:20
bauzas#info we'll try to create as os-traits release by this week, please provide your os-traits patches sooner than later.16:20
bauzasUggla: still volunteering for the release ?16:21
Ugglasure16:21
sean-k-mooneyare there pending patches16:21
sean-k-mooneythat need review16:21
gibiI think we need the vtpm one16:21
gibihttps://review.opendev.org/c/openstack/os-traits/+/94019116:22
sean-k-mooneyhttps://review.opendev.org/c/openstack/os-traits/+/94019116:22
sean-k-mooneyok ill try and do a pass on the open patcher after the meeting16:22
Ugglayes you were faster than me.16:22
sean-k-mooneyactully that look like the only relevent one16:22
sean-k-mooneyhttps://review.opendev.org/q/project:openstack/os-traits+status:open 16:23
sean-k-mooneythe rest are not requried16:23
Ugglabtw I'm waiting this patch to be merged, then I'll go ahead with the release.16:23
sean-k-mooneyi have +2'd it16:23
sean-k-mooneythe traits alinght to what we dicussed in the spec and follow our naming convention16:24
sean-k-mooneyso looks good to me16:24
bauzasI just +wd it, I was just reading the spec16:24
Uggla\o/16:24
bauzasso yeah, it was a nobrainer16:24
gibiawesome16:24
Ugglayep reviewing that one was not difficult. ;)16:24
bauzas#action Uggla to release os-traits this week16:25
bauzasmoving on16:25
bauzas#topic Review priorities 16:25
bauzas#link https://etherpad.opendev.org/p/nova-2025.1-status16:26
bauzasI'll be honest, I have some cleanup to do on that etherpad16:26
bauzasI guess we can move on16:29
bauzas#topic Stable Branches 16:29
gibielodilles is out 16:29
bauzasah ok16:29
bauzasI guess we can discuss that next week then16:29
gibisure16:29
bauzas#topic vmwareapi 3rd-party CI efforts Highlights 16:30
bauzasfwiesel: around ?16:30
fwieselHi, I discovered another regression in the networking driver and investigating that.16:30
fwieselSo, any failures are due to that.16:30
fwiesel(In master that is)16:30
fwieselThat's from my side.16:30
bauzasoh sad newds16:31
bauzasgood luck then and thanks for your report16:31
fwieselThanks.16:31
bauzas#topic Open discussion 16:31
bauzaswe have one item for today 16:31
bauzas(r-taketn) Request for comments on the following - Discussion of ArmCCA feature merge16:31
bauzasr-taketn: around ?16:32
r-taketnHi, thanks for adding this to the agenda.16:32
bauzas#link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/244U52T3HINVWUFSMPMA45A67BUPAQGK/16:32
r-taketnPlease review the above mailing list about an Arm CCA new feature. 16:32
r-taketnIn particular, We would like to discuss the feature merging timeline mentioned at the beginning with nova core developers.16:32
opendevreviewMerged openstack/os-traits master: Add vTPM secret policy traits  https://review.opendev.org/c/openstack/os-traits/+/94019116:32
r-taketnWe are proposing development for a feature (ArmCCA) targeting hardware not yet released to the market.16:32
r-taketnWe would appreciate your comments on the feasibility of merging a feature for unreleased hardware.16:33
* bauzas reads the mailing thread16:33
sean-k-mooneyr-taketn: we do not allow meging enabling code for unreleased hardware16:33
sean-k-mooneywwe are also passed the spec approveal deadline for this cycle16:33
sean-k-mooneybut it can be proposed for next cycle if the hardware is aviable16:34
sean-k-mooneywe only merge hardware enabling code after the hardware is generally aviabel in teh market not before16:34
bauzasyes indeed, there are a few limitations that you should be aware16:34
r-taketnTo our knowledge, no products currently support Arm CCA. FUJITSU-MONAKA [1], scheduled for release by Fujitsu in 2027, may be the first such product. 16:35
bauzasusually, we would want to make sure that our upstream CI can test specific hardware16:35
bauzasif specific hardware can't be tested on upstream CI, then there are two possibilities :16:35
bauzas1/ either you're able to test nova against fake hardware that reproduces the hardware behaviour16:36
bauzas2/ or you have to provide third-party CI16:36
sean-k-mooneywhile 2 is preferd it much more overhead btu actull tests that the feature works end to end16:38
r-taketnDoes this mean that if we submit third-party CI and comprehensive test results, there is a possibility that they will be merged before the hardware release?16:38
sean-k-mooneyno16:38
sean-k-mooneywe have strictly applied the requriemetn that hardware is released before its enabeld in the past. we coudl change that16:39
sean-k-mooneybut it would eb a break with precedent16:39
sean-k-mooneywe also require that any kernel/qemu/libivrt supprot is in a public offcial release16:39
sean-k-mooneyso if this requires qemu changes16:40
sean-k-mooneyor libvirt16:40
sean-k-mooneythose must be in a public offical release formr that upstream proejct before we can enabel it in nova16:40
r-taketnok, i understood.16:41
sean-k-mooneyis arm CCA supported in the kernel, qemu and libvirt today16:41
r-taketnno. LinuxKernel, qemu and libvirt are being developed now.16:41
sean-k-mooneyif you want to propose poc patches and prepare them that is fine16:42
sean-k-mooneybut we cant merge them until the deps are resolved16:42
bauzasindeed, nothing blocks you to create a feature branch that you could use for your own testing16:42
bauzaswhat I could suggest you is to come back to us as soon as kernel, QEMU and libvirt versions are released upstream so then we can discuss the alternatives16:44
sean-k-mooneyjust looking at https://patchwork.kernel.org/project/qemu-devel/cover/20240419155709.318866-2-jean-philippe@linaro.org/16:44
bauzasbut I strongly suggest you to invest a bit of your time into providing a testing kernel framework that could mock any specific hardware16:44
sean-k-mooneyit nodes that 16:44
sean-k-mooney Enabled support for guest memfd by Xiaoyao Li and Chao Peng [3].16:45
sean-k-mooney  Guest memfd is mandatory for CCA.16:45
sean-k-mooneynova does not supprot memfd currently16:45
sean-k-mooneyso there may be other work that is required and we wont knwo that until the qemu/libvirt work is complete16:45
r-taketnI got it. I understood that merging of  LinuxKernel, qemu and libvirt  are prerequisite.16:46
bauzaswhich I assume is the reason why r-taketn wants to work on nova16:46
sean-k-mooneywell adressing thing like supprotign memfd which is pretty simiple coudl be done independetly16:46
sean-k-mooneywe considered addign supprot for it to enabel the manial share attachment feature without hugepages or file backed memory16:47
sean-k-mooneyso there may be some work that can be doen without wiating for the hardware.16:47
sean-k-mooneyperhaps we can discss this after the meeting if needed16:48
opendevreviewArtom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property  https://review.opendev.org/c/openstack/nova/+/94019616:49
opendevreviewArtom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation  https://review.opendev.org/c/openstack/nova/+/94019716:49
opendevreviewArtom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins  https://review.opendev.org/c/openstack/nova/+/92577116:49
r-taketnok. I'll rethink the strategy. It would be helpful if you could let us discuss it on the mailing list, etc.16:49
sean-k-mooneyyou are definetly free too16:50
bauzassure, r-taketn are you familiar with our release cadence ?16:50
sean-k-mooneythis could also be a good topic for a future PTG 16:51
sean-k-mooneyi know other are also interested in confindcial computing in general16:51
r-taketnI have read and understand the Eproxy Release Schedule.16:51
bauzasr-taketn: the PTG dates for the next release were recently announced16:53
bauzasPTG is a virtual event occuring a couple of days where we usually chat about feature requests16:53
bauzasas sean-k-mooney said, it could be one item worth speaking about16:54
bauzasanyway, we're almost at time, so we need to wrap16:54
r-taketnI would like to attend PTG and discuss it.16:54
fwiesells16:55
bauzasr-taketn: then please continue to look at the mailing-list, you'll see some emails about the next steps16:57
bauzasour agenda is pretty free-form, as soon as we draft some ptg etherpad you should be able to add your topic16:58
bauzasok, that's it for now16:58
r-taketnOk. Thank you for discussing.16:58
bauzasany other item to cover ?16:58
gibi-16:59
bauzasokay then thanks all16:59
bauzas#endmeeting16:59
opendevmeetMeeting ended Tue Jan 28 16:59:26 2025 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:59
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.html16:59
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.txt16:59
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.log.html16:59
fwieselThanks, and sorry for the noise.16:59
masahito thank you16:59
gibithanks 17:02
*** priteau is now known as Guest726717:04
*** priteau2 is now known as priteau17:04
gibibauzas, dansmith, melwitt, sean-k-mooney: I just discovered that we missed the rebuild API action response when we considered the image properties in server details https://review.opendev.org/c/openstack/nova/+/939649/4#message-7d57a602cdd025a52c15c2470091baa6f0ee034017:12
gibiwould you be OK to amend the spec with this impact?17:12
gibiI need to drop soon but I will read back17:16
priteaubauzas and sean-k-mooney, could you please review this backport? Same as yesterday but for Bobcat: https://review.opendev.org/c/openstack/nova/+/94027217:21
dviroelgibi: i hit the same issue in https://review.opendev.org/c/openstack/nova/+/938604 -  so the same decision should also impact the scheduler_hints spec...17:21
bauzasgibi: I need to reload the context but if you ask for updating a spec post-approval-freeze, that's absolutely fine to me17:25
sean-k-mooneypriteau: +217:29
dansmithgibi: yep, commented17:53
opendevreviewStephen Finucane proposed openstack/nova master: api: Only check minimum API version  https://review.opendev.org/c/openstack/nova/+/94032518:05
stephenfinsean-k-mooney: took a different approach ^18:05
sean-k-mooneyya that could work as well. although if your only checkign the min version why is it not positional18:06
stephenfinIt effectively is. Do you mean using the forward slash operator?18:06
sean-k-mooneythis https://review.opendev.org/c/openstack/nova/+/940325/1/nova/api/openstack/api_version_request.py#300 does not need to be a kw arg18:06
stephenfinI don't understand the question? Are you thinking Python here or Go? :D18:07
sean-k-mooneyin python 18:07
sean-k-mooneyif we always expect to pass version18:07
sean-k-mooneyinstead of is_supported(req, version=_MIN_API_VERSION):18:07
stephenfinOh18:07
sean-k-mooneyit should be is_supported(req, version):18:08
stephenfinOkay, you were asking why does it take a default18:08
sean-k-mooneyyou just dont call this if your not enforcing a min right?18:08
sean-k-mooneyyes18:08
stephenfinyup, 100%. Good call18:08
opendevreviewStephen Finucane proposed openstack/nova master: api: Only check minimum API version  https://review.opendev.org/c/openstack/nova/+/94032518:08
stephenfinDone. Thanks18:08
sean-k-mooneyok so for make you just using not min18:09
sean-k-mooneyya that works18:09
stephenfinLike I said, if you really want a max check just negate the call18:10
sean-k-mooneywell i was just reviewing https://review.opendev.org/c/openstack/nova/+/940325/2/nova/api/openstack/compute/create_backup.py#6818:10
sean-k-mooneywhere your doing that18:10
stephenfinI'm nothing if not consistent18:10
sean-k-mooney+1 for now i looked at the first couple of files and ill loop back to it once i have reveiewd the previosu patches18:11
sean-k-mooneysicne your here why did you add a bunch of commans an reflow things in https://review.opendev.org/c/openstack/nova/+/936369/7/nova/api/validation/parameter_types.py18:14
stephenfinsean-k-mooney: literally leaving a comment on that now. I ran ruff by mistake on the file. I thought I had undone most of it manually in a respin but apparently not (or I've undone the undo)18:16
stephenfinIf it's impossible to review, I can respin. If not, this code is *very* rarely touched in backports and therefore shouldn't cause issues down the line. I didn't do it in any other change that I'm aware of18:17
sean-k-mooneyack, can ruff be configure to not add the trailing commas im pretty sure black can18:17
stephenfinIt can now. It was a preview feature until recently18:17
sean-k-mooneyits not imposibel to revieww it just dislike the stypel which i normally dont -1 for 18:17
stephenfinhttps://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma18:18
sean-k-mooneyoh i dont mind the backport impact its trivial, its just annoying to read when it expand the enum in particalar18:18
sean-k-mooney we are not actully using ruff, at least right now but it might be nice ot add that to our pyproject.toml anyway18:19
sean-k-mooneystephenfin: i belive we have a bug in the openapi schma serise. you are asusmign that project id and user id have to be uuids but as afar as i cna tell looking at keystone and our own code they are not required to eb uuids19:19
opendevreviewMichael Still proposed openstack/nova master: libvirt: direct SPICE console object changes  https://review.opendev.org/c/openstack/nova/+/92687619:22
opendevreviewMichael Still proposed openstack/nova master: libvirt: direct SPICE console database changes  https://review.opendev.org/c/openstack/nova/+/92687719:22
opendevreviewMichael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu  https://review.opendev.org/c/openstack/nova/+/92484419:22
opendevreviewMichael Still proposed openstack/nova master: libvirt: Add extra spec for sound device.  https://review.opendev.org/c/openstack/nova/+/92612619:22
opendevreviewMichael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection.  https://review.opendev.org/c/openstack/nova/+/92735419:22
mikalsean-k-mooney: ^--- is a rebase and the tweaked USB controller patch.19:22
opendevreviewMerged openstack/nova master: Fix typo in release note  https://review.opendev.org/c/openstack/nova/+/93568120:11
opendevreviewMerged openstack/nova stable/2023.2: libvirt: Wrap un-proxied listDevices() and listAllDevices()  https://review.opendev.org/c/openstack/nova/+/94027220:11
opendevreviewMerged openstack/nova master: zuul: Add missing context comments for nova-next  https://review.opendev.org/c/openstack/nova/+/93568222:32

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!