opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | 03:00 |
---|---|---|
opendevreview | melanie witt proposed openstack/nova master: pwr mgmt: power down free PCPUS when updating compute node https://review.opendev.org/c/openstack/nova/+/932926 | 07:25 |
*** elodilles is now known as elodilles_pto | 08:23 | |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for image metadata APIs https://review.opendev.org/c/openstack/nova/+/940299 | 12:24 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Add response body schemas for server topology API https://review.opendev.org/c/openstack/nova/+/940300 | 12:24 |
opendevreview | Amit Uniyal proposed openstack/nova master: WIP: remove swap.disk from disk.info https://review.opendev.org/c/openstack/nova/+/939643 | 13:48 |
opendevreview | Amit Uniyal proposed openstack/nova master: WIP:Reproducer for cold migration on shared storage https://review.opendev.org/c/openstack/nova/+/940304 | 13:48 |
opendevreview | Rajesh Tailor proposed openstack/nova master: Add support for showing image properties in server show response https://review.opendev.org/c/openstack/nova/+/939649 | 14:35 |
stephenfin | gmann: sean-k-mooney: Would I be able to ask for another burst through those OpenAPI patches in the next few days? I suspect this is going to drag into a third release, but I'd really like there not to be fourth and I still have quite a few patches to push beyond what's there | 15:27 |
sean-k-mooney | i can try | 15:45 |
bauzas | #startmeeting nova | 16:00 |
opendevmeet | Meeting started Tue Jan 28 16:00:27 2025 UTC and is due to finish in 60 minutes. The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot. | 16:00 |
opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 16:00 |
opendevmeet | The meeting name has been set to 'nova' | 16:00 |
fwiesel | o/ | 16:01 |
masahito | o/ | 16:01 |
r-taketn | o/ | 16:01 |
sean-k-mooney | o/ | 16:01 |
gibi | o/ | 16:01 |
bauzas | #link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting | 16:03 |
bauzas | I guess we can softly start | 16:03 |
bauzas | #topic Bugs (stuck/critical) | 16:04 |
bauzas | #info No Critical bug | 16:04 |
bauzas | #info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster | 16:05 |
masahito | hi, question for the bug roster activity. | 16:05 |
bauzas | any othre sure | 16:05 |
masahito | Is it bug triage activity newly reported? | 16:06 |
bauzas | we stopped looking at the non triaged bugs, as unfortunately there were no longer any volunteers :( | 16:07 |
bauzas | and it takes a large hit to triage those new bugs, given 2 of 3 are more configuration problems than real bugs :( | 16:07 |
Uggla | o/ | 16:08 |
sean-k-mooney | ocationally we will still look and triage some | 16:08 |
sean-k-mooney | but its now mostly async or based on pings form folks on irc or teh mailign list | 16:08 |
bauzas | this indeed | 16:09 |
masahito | I got the situation. | 16:09 |
sean-k-mooney | we still use the bug tracker but we are not doing tirage weekly in thei meeting | 16:09 |
sean-k-mooney | if you have issue you can however bring them up here | 16:09 |
masahito | we hit some bugs in the v2.96 API and started to report and to fix it. Let me bring it up here or the bug triage roaster. | 16:10 |
masahito | I try to check other bugs as well for the triage if possible. | 16:11 |
masahito | ping on irc is sometime difficult for us because of time difference. The bug roster activity sounds nice :) | 16:12 |
masahito | thank you. | 16:12 |
bauzas | masahito: what you can do is to add your patches in the tracking etherpad, we'll look over them | 16:12 |
bauzas | can we move on ? | 16:13 |
masahito | Got it. Looks last update is the last September. We could refresh the etherpad, too. | 16:14 |
masahito | yes. Thank you. | 16:14 |
bauzas | #topic Gate status | 16:15 |
bauzas | #link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs | 16:15 |
bauzas | #link https://etherpad.opendev.org/p/nova-ci-failures-minimal | 16:15 |
bauzas | #link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&branch=stable%2F*&branch=master&pipeline=periodic-weekly&skip=0 Nova&Placement periodic jobs status | 16:15 |
bauzas | #info Please look at the gate failures and file a bug report with the gate-failure tag. | 16:15 |
bauzas | #info Please try to provide meaningful comment when you recheck | 16:15 |
bauzas | the periodics are in a good shape | 16:16 |
bauzas | any gate failure you wanna talk ? | 16:16 |
sean-k-mooney | i havent really been looking at the gate in a while but the only fialures i notices were the usual volume or kernel panic issues | 16:16 |
bauzas | ditto here | 16:17 |
sean-k-mooney | with that said tehree was a fix for some of the volume tests in tempest | 16:17 |
sean-k-mooney | so that may help | 16:17 |
bauzas | and I definitely need to do a round of reviews | 16:17 |
sean-k-mooney | https://review.opendev.org/c/openstack/tempest/+/939663/2 and https://review.opendev.org/c/openstack/tempest/+/939633/11 for context | 16:17 |
sean-k-mooney | that shoudl help with some of the volume failures in test_instances_with_cinder_volumes | 16:18 |
sean-k-mooney | tl;dr those tests were not waiting for the vm to be sshabel ebfore trying to attach the voluems | 16:18 |
bauzas | good call, we can give them a shot | 16:18 |
sean-k-mooney | we can move on unless anyone else what to raise something | 16:19 |
bauzas | yup | 16:19 |
bauzas | #topic Release Planning | 16:19 |
bauzas | #link https://releases.openstack.org/epoxy/schedule.html | 16:19 |
bauzas | #info Nova deadlines are set in the above schedule | 16:19 |
bauzas | #info 4 weeks before Feature Freeze | 16:19 |
bauzas | the clock is ticking | 16:19 |
bauzas | as I said, I'll try to do a round of reviews as soon as my availability raises once I'm done with implementing a few things | 16:20 |
bauzas | as a reminder: | 16:20 |
bauzas | #info we'll try to create as os-traits release by this week, please provide your os-traits patches sooner than later. | 16:20 |
bauzas | Uggla: still volunteering for the release ? | 16:21 |
Uggla | sure | 16:21 |
sean-k-mooney | are there pending patches | 16:21 |
sean-k-mooney | that need review | 16:21 |
gibi | I think we need the vtpm one | 16:21 |
gibi | https://review.opendev.org/c/openstack/os-traits/+/940191 | 16:22 |
sean-k-mooney | https://review.opendev.org/c/openstack/os-traits/+/940191 | 16:22 |
sean-k-mooney | ok ill try and do a pass on the open patcher after the meeting | 16:22 |
Uggla | yes you were faster than me. | 16:22 |
sean-k-mooney | actully that look like the only relevent one | 16:22 |
sean-k-mooney | https://review.opendev.org/q/project:openstack/os-traits+status:open | 16:23 |
sean-k-mooney | the rest are not requried | 16:23 |
Uggla | btw I'm waiting this patch to be merged, then I'll go ahead with the release. | 16:23 |
sean-k-mooney | i have +2'd it | 16:23 |
sean-k-mooney | the traits alinght to what we dicussed in the spec and follow our naming convention | 16:24 |
sean-k-mooney | so looks good to me | 16:24 |
bauzas | I just +wd it, I was just reading the spec | 16:24 |
Uggla | \o/ | 16:24 |
bauzas | so yeah, it was a nobrainer | 16:24 |
gibi | awesome | 16:24 |
Uggla | yep reviewing that one was not difficult. ;) | 16:24 |
bauzas | #action Uggla to release os-traits this week | 16:25 |
bauzas | moving on | 16:25 |
bauzas | #topic Review priorities | 16:25 |
bauzas | #link https://etherpad.opendev.org/p/nova-2025.1-status | 16:26 |
bauzas | I'll be honest, I have some cleanup to do on that etherpad | 16:26 |
bauzas | I guess we can move on | 16:29 |
bauzas | #topic Stable Branches | 16:29 |
gibi | elodilles is out | 16:29 |
bauzas | ah ok | 16:29 |
bauzas | I guess we can discuss that next week then | 16:29 |
gibi | sure | 16:29 |
bauzas | #topic vmwareapi 3rd-party CI efforts Highlights | 16:30 |
bauzas | fwiesel: around ? | 16:30 |
fwiesel | Hi, I discovered another regression in the networking driver and investigating that. | 16:30 |
fwiesel | So, any failures are due to that. | 16:30 |
fwiesel | (In master that is) | 16:30 |
fwiesel | That's from my side. | 16:30 |
bauzas | oh sad newds | 16:31 |
bauzas | good luck then and thanks for your report | 16:31 |
fwiesel | Thanks. | 16:31 |
bauzas | #topic Open discussion | 16:31 |
bauzas | we have one item for today | 16:31 |
bauzas | (r-taketn) Request for comments on the following - Discussion of ArmCCA feature merge | 16:31 |
bauzas | r-taketn: around ? | 16:32 |
r-taketn | Hi, thanks for adding this to the agenda. | 16:32 |
bauzas | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/244U52T3HINVWUFSMPMA45A67BUPAQGK/ | 16:32 |
r-taketn | Please review the above mailing list about an Arm CCA new feature. | 16:32 |
r-taketn | In particular, We would like to discuss the feature merging timeline mentioned at the beginning with nova core developers. | 16:32 |
opendevreview | Merged openstack/os-traits master: Add vTPM secret policy traits https://review.opendev.org/c/openstack/os-traits/+/940191 | 16:32 |
r-taketn | We are proposing development for a feature (ArmCCA) targeting hardware not yet released to the market. | 16:32 |
r-taketn | We would appreciate your comments on the feasibility of merging a feature for unreleased hardware. | 16:33 |
* bauzas reads the mailing thread | 16:33 | |
sean-k-mooney | r-taketn: we do not allow meging enabling code for unreleased hardware | 16:33 |
sean-k-mooney | wwe are also passed the spec approveal deadline for this cycle | 16:33 |
sean-k-mooney | but it can be proposed for next cycle if the hardware is aviable | 16:34 |
sean-k-mooney | we only merge hardware enabling code after the hardware is generally aviabel in teh market not before | 16:34 |
bauzas | yes indeed, there are a few limitations that you should be aware | 16:34 |
r-taketn | To our knowledge, no products currently support Arm CCA. FUJITSU-MONAKA [1], scheduled for release by Fujitsu in 2027, may be the first such product. | 16:35 |
bauzas | usually, we would want to make sure that our upstream CI can test specific hardware | 16:35 |
bauzas | if specific hardware can't be tested on upstream CI, then there are two possibilities : | 16:35 |
bauzas | 1/ either you're able to test nova against fake hardware that reproduces the hardware behaviour | 16:36 |
bauzas | 2/ or you have to provide third-party CI | 16:36 |
sean-k-mooney | while 2 is preferd it much more overhead btu actull tests that the feature works end to end | 16:38 |
r-taketn | Does this mean that if we submit third-party CI and comprehensive test results, there is a possibility that they will be merged before the hardware release? | 16:38 |
sean-k-mooney | no | 16:38 |
sean-k-mooney | we have strictly applied the requriemetn that hardware is released before its enabeld in the past. we coudl change that | 16:39 |
sean-k-mooney | but it would eb a break with precedent | 16:39 |
sean-k-mooney | we also require that any kernel/qemu/libivrt supprot is in a public offcial release | 16:39 |
sean-k-mooney | so if this requires qemu changes | 16:40 |
sean-k-mooney | or libvirt | 16:40 |
sean-k-mooney | those must be in a public offical release formr that upstream proejct before we can enabel it in nova | 16:40 |
r-taketn | ok, i understood. | 16:41 |
sean-k-mooney | is arm CCA supported in the kernel, qemu and libvirt today | 16:41 |
r-taketn | no. LinuxKernel, qemu and libvirt are being developed now. | 16:41 |
sean-k-mooney | if you want to propose poc patches and prepare them that is fine | 16:42 |
sean-k-mooney | but we cant merge them until the deps are resolved | 16:42 |
bauzas | indeed, nothing blocks you to create a feature branch that you could use for your own testing | 16:42 |
bauzas | what I could suggest you is to come back to us as soon as kernel, QEMU and libvirt versions are released upstream so then we can discuss the alternatives | 16:44 |
sean-k-mooney | just looking at https://patchwork.kernel.org/project/qemu-devel/cover/20240419155709.318866-2-jean-philippe@linaro.org/ | 16:44 |
bauzas | but I strongly suggest you to invest a bit of your time into providing a testing kernel framework that could mock any specific hardware | 16:44 |
sean-k-mooney | it nodes that | 16:44 |
sean-k-mooney | Enabled support for guest memfd by Xiaoyao Li and Chao Peng [3]. | 16:45 |
sean-k-mooney | Guest memfd is mandatory for CCA. | 16:45 |
sean-k-mooney | nova does not supprot memfd currently | 16:45 |
sean-k-mooney | so there may be other work that is required and we wont knwo that until the qemu/libvirt work is complete | 16:45 |
r-taketn | I got it. I understood that merging of LinuxKernel, qemu and libvirt are prerequisite. | 16:46 |
bauzas | which I assume is the reason why r-taketn wants to work on nova | 16:46 |
sean-k-mooney | well adressing thing like supprotign memfd which is pretty simiple coudl be done independetly | 16:46 |
sean-k-mooney | we considered addign supprot for it to enabel the manial share attachment feature without hugepages or file backed memory | 16:47 |
sean-k-mooney | so there may be some work that can be doen without wiating for the hardware. | 16:47 |
sean-k-mooney | perhaps we can discss this after the meeting if needed | 16:48 |
opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw_tpm_secret_security image property https://review.opendev.org/c/openstack/nova/+/940196 | 16:49 |
opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Add hw:tpm_secret_security extra spec validation https://review.opendev.org/c/openstack/nova/+/940197 | 16:49 |
opendevreview | Artom Lifshitz proposed openstack/nova master: WIP: Allow vTPM live migrations for admins https://review.opendev.org/c/openstack/nova/+/925771 | 16:49 |
r-taketn | ok. I'll rethink the strategy. It would be helpful if you could let us discuss it on the mailing list, etc. | 16:49 |
sean-k-mooney | you are definetly free too | 16:50 |
bauzas | sure, r-taketn are you familiar with our release cadence ? | 16:50 |
sean-k-mooney | this could also be a good topic for a future PTG | 16:51 |
sean-k-mooney | i know other are also interested in confindcial computing in general | 16:51 |
r-taketn | I have read and understand the Eproxy Release Schedule. | 16:51 |
bauzas | r-taketn: the PTG dates for the next release were recently announced | 16:53 |
bauzas | PTG is a virtual event occuring a couple of days where we usually chat about feature requests | 16:53 |
bauzas | as sean-k-mooney said, it could be one item worth speaking about | 16:54 |
bauzas | anyway, we're almost at time, so we need to wrap | 16:54 |
r-taketn | I would like to attend PTG and discuss it. | 16:54 |
fwiesel | ls | 16:55 |
bauzas | r-taketn: then please continue to look at the mailing-list, you'll see some emails about the next steps | 16:57 |
bauzas | our agenda is pretty free-form, as soon as we draft some ptg etherpad you should be able to add your topic | 16:58 |
bauzas | ok, that's it for now | 16:58 |
r-taketn | Ok. Thank you for discussing. | 16:58 |
bauzas | any other item to cover ? | 16:58 |
gibi | - | 16:59 |
bauzas | okay then thanks all | 16:59 |
bauzas | #endmeeting | 16:59 |
opendevmeet | Meeting ended Tue Jan 28 16:59:26 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 16:59 |
opendevmeet | Minutes: https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.html | 16:59 |
opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.txt | 16:59 |
opendevmeet | Log: https://meetings.opendev.org/meetings/nova/2025/nova.2025-01-28-16.00.log.html | 16:59 |
fwiesel | Thanks, and sorry for the noise. | 16:59 |
masahito | thank you | 16:59 |
gibi | thanks | 17:02 |
*** priteau is now known as Guest7267 | 17:04 | |
*** priteau2 is now known as priteau | 17:04 | |
gibi | bauzas, dansmith, melwitt, sean-k-mooney: I just discovered that we missed the rebuild API action response when we considered the image properties in server details https://review.opendev.org/c/openstack/nova/+/939649/4#message-7d57a602cdd025a52c15c2470091baa6f0ee0340 | 17:12 |
gibi | would you be OK to amend the spec with this impact? | 17:12 |
gibi | I need to drop soon but I will read back | 17:16 |
priteau | bauzas and sean-k-mooney, could you please review this backport? Same as yesterday but for Bobcat: https://review.opendev.org/c/openstack/nova/+/940272 | 17:21 |
dviroel | gibi: i hit the same issue in https://review.opendev.org/c/openstack/nova/+/938604 - so the same decision should also impact the scheduler_hints spec... | 17:21 |
bauzas | gibi: I need to reload the context but if you ask for updating a spec post-approval-freeze, that's absolutely fine to me | 17:25 |
sean-k-mooney | priteau: +2 | 17:29 |
dansmith | gibi: yep, commented | 17:53 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Only check minimum API version https://review.opendev.org/c/openstack/nova/+/940325 | 18:05 |
stephenfin | sean-k-mooney: took a different approach ^ | 18:05 |
sean-k-mooney | ya that could work as well. although if your only checkign the min version why is it not positional | 18:06 |
stephenfin | It effectively is. Do you mean using the forward slash operator? | 18:06 |
sean-k-mooney | this https://review.opendev.org/c/openstack/nova/+/940325/1/nova/api/openstack/api_version_request.py#300 does not need to be a kw arg | 18:06 |
stephenfin | I don't understand the question? Are you thinking Python here or Go? :D | 18:07 |
sean-k-mooney | in python | 18:07 |
sean-k-mooney | if we always expect to pass version | 18:07 |
sean-k-mooney | instead of is_supported(req, version=_MIN_API_VERSION): | 18:07 |
stephenfin | Oh | 18:07 |
sean-k-mooney | it should be is_supported(req, version): | 18:08 |
stephenfin | Okay, you were asking why does it take a default | 18:08 |
sean-k-mooney | you just dont call this if your not enforcing a min right? | 18:08 |
sean-k-mooney | yes | 18:08 |
stephenfin | yup, 100%. Good call | 18:08 |
opendevreview | Stephen Finucane proposed openstack/nova master: api: Only check minimum API version https://review.opendev.org/c/openstack/nova/+/940325 | 18:08 |
stephenfin | Done. Thanks | 18:08 |
sean-k-mooney | ok so for make you just using not min | 18:09 |
sean-k-mooney | ya that works | 18:09 |
stephenfin | Like I said, if you really want a max check just negate the call | 18:10 |
sean-k-mooney | well i was just reviewing https://review.opendev.org/c/openstack/nova/+/940325/2/nova/api/openstack/compute/create_backup.py#68 | 18:10 |
sean-k-mooney | where your doing that | 18:10 |
stephenfin | I'm nothing if not consistent | 18:10 |
sean-k-mooney | +1 for now i looked at the first couple of files and ill loop back to it once i have reveiewd the previosu patches | 18:11 |
sean-k-mooney | sicne your here why did you add a bunch of commans an reflow things in https://review.opendev.org/c/openstack/nova/+/936369/7/nova/api/validation/parameter_types.py | 18:14 |
stephenfin | sean-k-mooney: literally leaving a comment on that now. I ran ruff by mistake on the file. I thought I had undone most of it manually in a respin but apparently not (or I've undone the undo) | 18:16 |
stephenfin | If it's impossible to review, I can respin. If not, this code is *very* rarely touched in backports and therefore shouldn't cause issues down the line. I didn't do it in any other change that I'm aware of | 18:17 |
sean-k-mooney | ack, can ruff be configure to not add the trailing commas im pretty sure black can | 18:17 |
stephenfin | It can now. It was a preview feature until recently | 18:17 |
sean-k-mooney | its not imposibel to revieww it just dislike the stypel which i normally dont -1 for | 18:17 |
stephenfin | https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma | 18:18 |
sean-k-mooney | oh i dont mind the backport impact its trivial, its just annoying to read when it expand the enum in particalar | 18:18 |
sean-k-mooney | we are not actully using ruff, at least right now but it might be nice ot add that to our pyproject.toml anyway | 18:19 |
sean-k-mooney | stephenfin: i belive we have a bug in the openapi schma serise. you are asusmign that project id and user id have to be uuids but as afar as i cna tell looking at keystone and our own code they are not required to eb uuids | 19:19 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console object changes https://review.opendev.org/c/openstack/nova/+/926876 | 19:22 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: direct SPICE console database changes https://review.opendev.org/c/openstack/nova/+/926877 | 19:22 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: allow direct SPICE connections to qemu https://review.opendev.org/c/openstack/nova/+/924844 | 19:22 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra spec for sound device. https://review.opendev.org/c/openstack/nova/+/926126 | 19:22 |
opendevreview | Michael Still proposed openstack/nova master: libvirt: Add extra specs for USB redirection. https://review.opendev.org/c/openstack/nova/+/927354 | 19:22 |
mikal | sean-k-mooney: ^--- is a rebase and the tweaked USB controller patch. | 19:22 |
opendevreview | Merged openstack/nova master: Fix typo in release note https://review.opendev.org/c/openstack/nova/+/935681 | 20:11 |
opendevreview | Merged openstack/nova stable/2023.2: libvirt: Wrap un-proxied listDevices() and listAllDevices() https://review.opendev.org/c/openstack/nova/+/940272 | 20:11 |
opendevreview | Merged openstack/nova master: zuul: Add missing context comments for nova-next https://review.opendev.org/c/openstack/nova/+/935682 | 22:32 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!