Tuesday, 2024-09-17

opendevreviewribaudr proposed openstack/nova master: Amend ShareMappingStatus due to asynchronous call  https://review.opendev.org/c/openstack/nova/+/90886406:44
opendevreviewribaudr proposed openstack/nova master: Amend DB model add a unique constraint.  https://review.opendev.org/c/openstack/nova/+/91251806:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (manila abstraction)  https://review.opendev.org/c/openstack/nova/+/83119406:44
opendevreviewribaudr proposed openstack/nova master: Use client token when talking to manila  https://review.opendev.org/c/openstack/nova/+/92527706:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (drivers and compute manager part)  https://review.opendev.org/c/openstack/nova/+/83309006:44
opendevreviewribaudr proposed openstack/nova master: Mounting the shares as part of the initialization process  https://review.opendev.org/c/openstack/nova/+/88007506:44
opendevreviewribaudr proposed openstack/nova master: Deletion of associated share mappings on instance deletion  https://review.opendev.org/c/openstack/nova/+/88147206:44
opendevreviewribaudr proposed openstack/nova master: Add metadata for shares  https://review.opendev.org/c/openstack/nova/+/85050006:44
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to reboot method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/85482306:44
opendevreviewribaudr proposed openstack/nova master: Support rebooting an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/85482406:44
opendevreviewribaudr proposed openstack/nova master: Add share_info parameter to resume method for each driver (driver part)  https://review.opendev.org/c/openstack/nova/+/86028406:44
opendevreviewribaudr proposed openstack/nova master: Support resuming an instance with shares (compute manager part)  https://review.opendev.org/c/openstack/nova/+/86028506:44
opendevreviewribaudr proposed openstack/nova master: Add helper methods to rescue/unrescue shares  https://review.opendev.org/c/openstack/nova/+/86028606:44
opendevreviewribaudr proposed openstack/nova master: Support rescuing an instance with shares  https://review.opendev.org/c/openstack/nova/+/86028706:44
opendevreviewribaudr proposed openstack/nova master: Allow to mount manila share using Cephfs protocol  https://review.opendev.org/c/openstack/nova/+/88386206:44
opendevreviewribaudr proposed openstack/nova master: Check shares support (compute manager)  https://review.opendev.org/c/openstack/nova/+/88575106:44
opendevreviewribaudr proposed openstack/nova master: Attach Manila shares via virtiofs (API)  https://review.opendev.org/c/openstack/nova/+/83683006:44
opendevreviewribaudr proposed openstack/nova master: Add helper methods to attach/detach shares  https://review.opendev.org/c/openstack/nova/+/88575306:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach notification  https://review.opendev.org/c/openstack/nova/+/85050106:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach notification  https://review.opendev.org/c/openstack/nova/+/85102806:44
opendevreviewribaudr proposed openstack/nova master: Add shares to InstancePayload  https://review.opendev.org/c/openstack/nova/+/85102906:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_attach_error notification  https://review.opendev.org/c/openstack/nova/+/86028206:44
opendevreviewribaudr proposed openstack/nova master: Add instance.share_detach_error notification  https://review.opendev.org/c/openstack/nova/+/86028306:44
opendevreviewribaudr proposed openstack/nova master: Reports instance events to the DB regarding attaching and detaching a share  https://review.opendev.org/c/openstack/nova/+/92708806:44
opendevreviewribaudr proposed openstack/nova master: Add libvirt test to ensure metadata are working.  https://review.opendev.org/c/openstack/nova/+/85208606:45
opendevreviewribaudr proposed openstack/nova master: Add virt/libvirt error test cases  https://review.opendev.org/c/openstack/nova/+/85208706:45
opendevreviewribaudr proposed openstack/nova master: Docs about Manila shares API usage  https://review.opendev.org/c/openstack/nova/+/87164206:45
*** bauzas_ is now known as bauzas07:28
*** __ministry is now known as Guest370307:36
zigoHi there! When should I expect the RC1 for Nova?10:29
zigoWhat's blocking?10:29
opendevreviewMerged openstack/placement stable/2024.2: Update .gitreview for stable/2024.2  https://review.opendev.org/c/openstack/placement/+/92929010:41
opendevreviewMerged openstack/placement stable/2024.2: Update TOX_CONSTRAINTS_FILE for stable/2024.2  https://review.opendev.org/c/openstack/placement/+/92929110:41
stephenfinzigo: https://review.opendev.org/c/openstack/requirements/+/92950410:51
toskyuhm, is there a bug which tracks the failure of nova-live-migration?11:06
zigostephenfin: FYI, I have all packages ready for Dalmatian but Nova, and I'm not affected by the issue with openstackclient (since 7.1.1 is there it's going to be used).11:15
zigoMaybe I should package tip of master? Or is this already in a stable branch?11:15
stephenfinit's already in a stable branch11:15
zigoOk, thanks.11:15
zigoI'll do an ~rc1~git.<something> then.11:16
zigoNot correct, I can't see a stable/2024.2 branch at https://opendev.org/openstack/nova11:17
stephenfinI'm talking about OSC11:18
zigoOh... :P11:18
zigoSo nova is still on master, then I guess.11:18
gibijust to set expectations after https://review.opendev.org/c/openstack/requirements/+/929504 lands we have at least 3 regression bug fixes lined up to land before we can cut RC1.11:36
elodillesgibi or bauzas or other cores o:) when you have time, could you please do a quick review on these reno patches? https://review.opendev.org/c/openstack/python-novaclient/+/928366 and https://review.opendev.org/c/openstack/placement/+/92929211:46
gibion it11:52
gibiI lost, stephenfin was faster :)11:53
stephenfin🥷11:53
gibi:)11:53
opendevreviewMerged openstack/python-novaclient master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/python-novaclient/+/92836612:00
opendevreviewMerged openstack/placement master: Update master for stable/2024.2  https://review.opendev.org/c/openstack/placement/+/92929212:01
elodillesthx :]12:03
*** __ministry is now known as Guest373013:21
zigohttps://paste.opendev.org/show/bSMhXjOBcgfTTiNF0s1I/ <--- Is this a new behavior expected in Dalmatian ?14:40
zigoIf I provide --domain it works ...14:40
sean-k-mooneyi dont know but the keyston folks might. i doubt it woudl hav echanged but its possible14:53
fricklerzigo: sean-k-mooney: that's a bug in OSC, see https://review.opendev.org/c/openstack/python-openstackclient/+/92945614:59
zigoYeah, found the patch.14:59
zigoThanks.14:59
zigoI'm already building OSC with it.14:59
sean-k-mooneyfrickler:  so we would need another osc release for that right15:00
sean-k-mooney7.1.215:00
zigoAgreed.15:00
fricklerI've been wondering whether the bug is critical enough to warrant another OSC release right away or whether it could wait until 2024.2 is out, but likely you're right15:05
dansmithsurely that's done in a devstack setup right?15:07
dansmithhow are the jobs supposedly testing osc not catching that?15:07
sean-k-mooneyit might always pass the domain15:07
dansmithah yeah I guess it must15:08
dansmithprobably because it's possible to set the domain in devstack I guess15:08
zigofrickler: IMO, it is. It broke my puppet provider for creating users...15:09
dansmithzigo: yeah agree, it would certainly have broken some of my own scripts that test glance-remote15:10
sean-k-mooneydansmith: https://github.com/openstack/devstack/blob/0ff627286297a3957143577412884dc50ff8a57a/functions-common#L902-L92115:16
sean-k-mooneyso ya we alwasy pass a domain15:16
dansmithyeah15:16
frickleryes, devstack always is explicit in specifying the domain15:19
sean-k-mooneyto be fair this should be tested in the devstack-functionatl job but there is  obviously a testing gap15:20
opendevreviewMasahito Muroi proposed openstack/nova master: Use boot_roles_count and boot_role_<count> key for system_metadata  https://review.opendev.org/c/openstack/nova/+/92516315:26
elodillesbauzas: fyi, this has just merged: 'update constraint for python-openstackclient to new release 7.1.1'  https://review.opendev.org/c/openstack/requirements/+/929504 15:57
bauzasI saw16:00
bauzasI'm late for the meeting, let me run it16:00
bauzas#startmeeting16:01
opendevmeetbauzas: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee'16:01
bauzas#startmeeting nova16:01
opendevmeetMeeting started Tue Sep 17 16:01:19 2024 UTC and is due to finish in 60 minutes.  The chair is bauzas. Information about MeetBot at http://wiki.debian.org/MeetBot.16:01
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.16:01
opendevmeetThe meeting name has been set to 'nova'16:01
bauzashey everyone16:01
fwieselo/16:01
bauzasthe agenda isn't written yet, lemme do it16:01
elodilleso/16:01
dansmitho/16:01
bauzasokay, I'm done with the agenda16:02
bauzas#link https://wiki.openstack.org/wiki/Meetings/Nova#Agenda_for_next_meeting16:02
bauzas#topic Bugs (stuck/critical) 16:02
bauzas#info One critical bug16:03
bauzas#link https://bugs.launchpad.net/nova/+bugs?search=Search&field.importance=Critical&field.status=New&field.status=Incomplete&field.status=Confirmed&field.status=Triaged&field.status=In+Progress16:03
bauzas#link https://bugs.launchpad.net/nova/+bug/207985016:03
gibio/16:03
bauzasso we know about it, we just need to merge the bugfix16:03
bauzasbut, we'll discuss why we weren't able to do it previously in a second16:04
bauzasanything else about bugs ?16:04
bauzas#info Add yourself in the team bug roster if you want to help https://etherpad.opendev.org/p/nova-bug-triage-roster16:04
bauzaslooks not16:05
bauzas#topic Gate status 16:05
bauzas#link https://bugs.launchpad.net/nova/+bugs?field.tag=gate-failure Nova gate bugs 16:05
bauzas#link https://etherpad.opendev.org/p/nova-ci-failures-minimal16:05
bauzas#link https://zuul.openstack.org/builds?project=openstack%2Fnova&project=openstack%2Fplacement&pipeline=periodic-weekly Nova&Placement periodic jobs status16:05
bauzas#info Please look at the gate failures and file a bug report with the gate-failure tag.16:05
bauzas#info Please try to provide meaningful comment when you recheck16:05
bauzasso, you probably saw but the gate is blocked16:05
Ugglao/16:06
bauzas#info Gate is currently blocked due to a bug in OpenStackClient 7.1.0 16:06
gibibauzas: https://review.opendev.org/c/openstack/requirements/+/929504 is merged 7.1.1 is in uc now16:07
bauzaselodilles just told me that u-c now supports 7.1.1 where the bug is fixed (due to a parameter modification)16:07
bauzasgibi: yup, was writing it :)16:07
bauzasso, now, we can recheck, which I willk16:07
gibiI already did16:07
bauzascool16:07
gibirechecked the bottom of the 3 RC bug we track in the etherpad16:08
bauzascool16:08
bauzaswe need to recheck the prelude and another Dalmatian change 16:08
bauzasbut we'll discuss that in the next topic16:08
gibithe prelude is already merged :)16:09
bauzas#info Gate should now be unblocked as upper-constraints now supports OSC 7.1.1 which fixes the cause16:09
bauzasoh cool16:09
* bauzas was in meetings for the last 2 hours16:09
bauzasthat's how you can be productive, right?16:09
bauzasgibi: thanks then16:10
gibiI think the dalmatian service version patch is still open, I rechecked it now16:10
bauzasack16:10
bauzasI can basically now take a beer then :)16:10
bauzas'hold my beer' literally16:10
gibisure, but keep your fingres crossed :)16:10
bauzasmy toes are even crossed16:11
bauzaswe're super late and I feel bad about it16:11
bauzasbut we shouldn't need another RC216:11
bauzas#topic Release Planning 16:11
bauzas#link https://releases.openstack.org/dalmatian/schedule.html16:11
gibiso we just name this RC2 and say we have an early  :)16:11
bauzas#info Dalmatian RC1 not yet tagged, hopefully tomorrow16:12
bauzas#link https://etherpad.opendev.org/p/nova-dalmatian-rc-potential Tracking etherpad for RC candidates 16:12
bauzasokay, I think we discussed that enough, unless someone has any question ?16:12
bauzas#topic Review priorities 16:13
bauzas#link https://etherpad.opendev.org/p/nova-2025.1-status16:14
bauzasplease add the series you'd want us to look at16:14
bauzasI already see two proposals16:14
bauzasmoving on16:15
bauzas#topic PTG planning16:15
bauzas#info as a reminder, we'll meet (virtually) at the PTG on Oct 21-25 202416:16
bauzasI'm starting to draft an etherpad where you could add your topics of interest16:16
bauzas#link https://etherpad.opendev.org/p/nova-2025.1-ptg16:16
bauzasI'll send an email to openstack-discuss soon to tell about it16:17
bauzasI think I'm done 16:18
bauzasnext topic16:18
bauzas#topic Stable Branches16:18
bauzaselodilles: floor is yours16:18
elodilleso716:18
elodilles#info stable/202*.* gates seem to be OK16:18
elodilles#info stable/2024.2 branch is not yet cut for nova, but all the other repos the new branch exist16:18
elodillesand that's all from me about stable branches for now16:18
bauzascool16:19
bauzaslast topic16:20
bauzaswell16:20
bauzas#topic vmwareapi 3rd-party CI efforts Highlights 16:20
bauzasfwiesel: anything to report ?16:20
fwiesel#info No updates16:20
fwieselNot really... patch still stuck in ci... I'll recheck it soon16:21
bauzascool16:21
bauzaslast topic then16:21
bauzas#topic Open discussion 16:21
bauzas(noonedeadpunk) Enable serving NoVNC under subpath (not only via port/subdomain) 16:21
bauzasnoonedeadpunk: around ?16:21
bauzas#link https://review.opendev.org/c/openstack/nova/+/92883916:21
sean-k-mooneyso its tecnnically possible ot do ^ externally with the correct revers proxy config but its a bit of a pain16:22
sean-k-mooneyim generally supportive of this as a minor feature (specless blueprint)16:23
sean-k-mooneytl;dr 16:23
sean-k-mooneyif you want to deploy all services on port 443 including novnc16:23
gibiI only skimmed it, is this only support a single new query param "path"?16:23
sean-k-mooney(either beacuse of yoru isp or firewall issues) you can do it with subdomains but its tricky to do with subfolders16:24
sean-k-mooneyyep path is the subpath to append ot the websocket16:24
sean-k-mooneyso in there case they wanted to deply openstac.my.domain/vnc16:24
bauzasI'm having a few concerns by the implementation but I don't have any concenr about the design16:24
sean-k-mooneywithout setting path it will connect ot /16:25
noonedeadpunkyeah, around jsut a bit busy 16:25
bauzaslike, I don't want nova to just sub the path and see whether there is path16:25
sean-k-mooneyso this is just exposing a way to pass path to novnc16:25
bauzasmaybe a config option, maybe something like a relnote16:25
noonedeadpunknova does not sub the path - but it jsut respects whatever user defiens in config16:26
bauzasbut I don't want us to not expose that 16:26
noonedeadpunkby not respecting query, and not just fqdn16:26
bauzaswell your change will parse the qs16:26
noonedeadpunkand append to it16:26
sean-k-mooneyso we brifly dicussed having a config option like the exisitng port option for the query sting16:27
noonedeadpunkvs currnet behaviour where  query is hardcoded basically16:27
sean-k-mooneyfor libvirt we decieded that just passing a uri for the connection was better16:28
bauzaswell, here you're hard parsing the query with only 'path'16:28
noonedeadpunkwell, I'm not sure about config option ,as there could be more usecases whre you wnat to pass smth as admin to novnc16:28
sean-k-mooneyso that why i was mostly ok with noonedeadpunk  approch as its consitent with that16:28
sean-k-mooneybauzas: there may be other query arges that novnc uses tha tcould be reasoanable to pass16:28
noonedeadpunkbauzas: yeah, but current code will jsut add `?path=?token=<uuid>`16:29
sean-k-mooneyso i woudl prefer not to limit it to path16:29
bauzasanyway, as I said, this is a technical detail16:29
noonedeadpunkso if you try to add like anything to the `novncproxy_base_url` - you will end up with invalid token 16:29
bauzasI don't oppose to the usecase and I think keeping an URI is important16:29
noonedeadpunkprobably I jsut don't get what you're proposing isntead...16:30
bauzasas I said, I only have implementation concerns16:30
bauzasyour current patch only accepts 'path' as a qs param 16:30
noonedeadpunkbut like unit tests shows it should be quite consistent... I can add more test cases if I'll get what these concerns are16:30
bauzasif we restrict to 'path' then we need to document it better than "oh and now you can pass *any* qs"16:31
sean-k-mooneynoonedeadpunk: bauzas  is askign to make sure it will work with any arg16:31
noonedeadpunkit's not restricted with path?16:31
noonedeadpunkl133 of https://review.opendev.org/c/openstack/nova/+/928839/3/nova/tests/unit/objects/test_console_auth_token.py16:32
bauzas"@item(hotlist):button216:32
bauzasdoh16:32
bauzasthe documentation says "You can also supply extra request arguments"16:32
bauzasanyway, can we just (for the sake of my beer) accept that blueprint as specless and nitpick over the change as much as we want over the Epoxy timeframe ? :)16:33
noonedeadpunk++16:33
sean-k-mooney+1 form me also16:33
bauzasany objection ?16:34
bauzaslooks not16:34
bauzas#agreed https://blueprints.launchpad.net/nova/+spec/novnc-base-url-respect-extra-params accepted as specless for the Epoxy release16:35
bauzasI'll file the paperwork16:35
gibiOK for me16:35
bauzasthat's it for the agenda16:35
bauzasany other bit you'd like to raise ?16:35
bauzaslooks not16:35
bauzasmy beer won't heat, cool16:36
bauzasthanks all16:36
bauzas#endmeeting16:36
opendevmeetMeeting ended Tue Sep 17 16:36:13 2024 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)16:36
opendevmeetMinutes:        https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.html16:36
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.txt16:36
opendevmeetLog:            https://meetings.opendev.org/meetings/nova/2024/nova.2024-09-17-16.01.log.html16:36
sean-k-mooneyo/16:36
elodillesthanks o/16:36
gibio/16:38
*** bauzas_ is now known as bauzas19:28

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!